[GitHub] [ofbiz-framework] fredster33 closed pull request #286: Added Markdown to pull request template
fredster33 closed pull request #286: URL: https://github.com/apache/ofbiz-framework/pull/286 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] fredster33 commented on pull request #286: Added Markdown to pull request template
fredster33 commented on pull request #286: URL: https://github.com/apache/ofbiz-framework/pull/286#issuecomment-794678420 All right, I'll close this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] mbrohl commented on pull request #286: Added Markdown to pull request template
mbrohl commented on pull request #286: URL: https://github.com/apache/ofbiz-framework/pull/286#issuecomment-794573751 Mmmhh, I don't see much value in adding additional markdown code to the template. The PR comment mostly contains the commit message according to our commit message template (https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+commit+message+template), which to me needs no additional markup. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #286: Added Markdown to pull request template
sonarcloud[bot] commented on pull request #286: URL: https://github.com/apache/ofbiz-framework/pull/286#issuecomment-794518338 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=286=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=286=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=286=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=286=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=286=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=286=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=286=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=286=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=286=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=286=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=286=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=286=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=286) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=286=duplicated_lines_density=list) No Duplication information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] fredster33 opened a new pull request #286: Added Markdown to pull request template
fredster33 opened a new pull request #286: URL: https://github.com/apache/ofbiz-framework/pull/286 Improved: Pull request template (The above might have been a section for a JIRA issue, but I haven't created one) ## Explanation Added Markdown to the pull request template for neater formatting. ## Thanks: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12193) Cant search ViewEntity InventoryItemDetailForSum
[ https://issues.apache.org/jira/browse/OFBIZ-12193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298248#comment-17298248 ] Jacques Le Roux commented on OFBIZ-12193: - Thanks Sebastian, I'll have a look tmrw :) > Cant search ViewEntity InventoryItemDetailForSum > > > Key: OFBIZ-12193 > URL: https://issues.apache.org/jira/browse/OFBIZ-12193 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Sebastian Berg >Assignee: Sebastian Berg >Priority: Major > > Go to Entity Engine - > search entity InventoryItemDetailForSum (view entity) > -> search for entries -> an error message is shown. > A SQL exception occurred running the service executeFind -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #285: OFBIZ-12193 Fixed: Addressed log issues caused in FindGeneric.groovy
sonarcloud[bot] commented on pull request #285: URL: https://github.com/apache/ofbiz-framework/pull/285#issuecomment-793982046 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=285=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=285=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=285=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=285=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=285=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=285=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=285=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=285=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=285=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=285=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=285=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=285=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=285) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=285=duplicated_lines_density=list) No Duplication information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12193) Cant search ViewEntity InventoryItemDetailForSum
[ https://issues.apache.org/jira/browse/OFBIZ-12193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298096#comment-17298096 ] Sebastian Berg commented on OFBIZ-12193: [~jleroux] I created a new PR for the 18.12 branch where the log issues are fixed. The rendered form in trunk which was backportet is more advanced than the version used in 18.12 therefore the log issues. I worked in the necessary changes for fixing the ViewEntity Bug into the 18.12 form structure and now its working fine without errors in logs. There shouldn't be any problems applying these changes to the 17.12 version. > Cant search ViewEntity InventoryItemDetailForSum > > > Key: OFBIZ-12193 > URL: https://issues.apache.org/jira/browse/OFBIZ-12193 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Sebastian Berg >Assignee: Sebastian Berg >Priority: Major > > Go to Entity Engine - > search entity InventoryItemDetailForSum (view entity) > -> search for entries -> an error message is shown. > A SQL exception occurred running the service executeFind -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] SebastianEcomify opened a new pull request #285: OFBIZ-12193 Fixed: Addressed log issues caused in FindGeneric.groovy
SebastianEcomify opened a new pull request #285: URL: https://github.com/apache/ofbiz-framework/pull/285 Fixed: Addressed log issues caused in FindGeneric.groovy (OFBIZ-12193) The backportet Version of searchForm in FindGeneric.groovy was to advanced for the 18.12 Version. The form was changed back to its previous version and the changes causing the view Error in ViewEntities have been worked into it This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (OFBIZ-12195) webtools/control/threadList no longer works on trunk (only)
Jacques Le Roux created OFBIZ-12195: --- Summary: webtools/control/threadList no longer works on trunk (only) Key: OFBIZ-12195 URL: https://issues.apache.org/jira/browse/OFBIZ-12195 Project: OFBiz Issue Type: Bug Components: framework/webtools Affects Versions: Trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux Fix For: Upcoming Branch This can be currently tested at https://demo-trunk.ofbiz.apache.org/webtools/control/threadList R18 and R17 are OK -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12166) Default ordering of webapps titles in main menu
[ https://issues.apache.org/jira/browse/OFBIZ-12166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17297960#comment-17297960 ] Jacques Le Roux commented on OFBIZ-12166: - Hi Olivier, That sounds like a good improvement to me. I let you do it, right? > Default ordering of webapps titles in main menu > --- > > Key: OFBIZ-12166 > URL: https://issues.apache.org/jira/browse/OFBIZ-12166 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: 18.12.01, Upcoming Branch > > > This follows https://markmail.org/message/ftgfpwztflty7klb, excerpt: > bq. [...] having more important apps in 1st places would be better [...] the > feature should be easily changed by custom projects [...] documentation for > that would be enough. > I propose this order: > 1. partymgr(because you need parties to do anything) > 2. catalog (because you need products to do anything) > 3. facility (because you need to store products to do anything) > 4. order (because it's there that things begin to "move") > 5. accounting (because it's there that things "end"; ar & ap should > disappear) > 6. content (because you need to associate contents to make things better) > 7. manufacturing (because OFBiz is also an ERP) > 8. sfa (because people are often looking for a CRM, BTW most them don't know > what SFA is) > 9. workeffort (this one could be above, but it's not obvious for most people) > 10. humanres (more important than below IMO) > 11. marketing (not sure about the place of this one) > 12. webtools (maybe higher?) > - (plugins start below) > 1. rest (could be named api soon) > 2. projectmgr > 3. webpos > 4. bi > 5. birt > 6. myportal > 7. assetmaint > 8. ismgr > 9. scrum > 10. solr > 11. ebay > 12. firstdata > 13. - (those are special, maybe above?) > 14. example > 15. exampleext > - (those plugins don't show atm but exist, maybe need more info > from backend menu?) > 1. ecommerce > 2. ecomseo > 3. multiflex > 4. cmssite > 5. ebaystore > 6. ldap > 7. lucene > 8. passport > 9. pricat > 10. msggateway -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12166) Default ordering of webapps titles in main menu
[ https://issues.apache.org/jira/browse/OFBIZ-12166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17297938#comment-17297938 ] Olivier Heintz commented on OFBIZ-12166: I propose to put the help of the different components in the same order as the menus. Only change order of the include in the user-manual > Default ordering of webapps titles in main menu > --- > > Key: OFBIZ-12166 > URL: https://issues.apache.org/jira/browse/OFBIZ-12166 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: 18.12.01, Upcoming Branch > > > This follows https://markmail.org/message/ftgfpwztflty7klb, excerpt: > bq. [...] having more important apps in 1st places would be better [...] the > feature should be easily changed by custom projects [...] documentation for > that would be enough. > I propose this order: > 1. partymgr(because you need parties to do anything) > 2. catalog (because you need products to do anything) > 3. facility (because you need to store products to do anything) > 4. order (because it's there that things begin to "move") > 5. accounting (because it's there that things "end"; ar & ap should > disappear) > 6. content (because you need to associate contents to make things better) > 7. manufacturing (because OFBiz is also an ERP) > 8. sfa (because people are often looking for a CRM, BTW most them don't know > what SFA is) > 9. workeffort (this one could be above, but it's not obvious for most people) > 10. humanres (more important than below IMO) > 11. marketing (not sure about the place of this one) > 12. webtools (maybe higher?) > - (plugins start below) > 1. rest (could be named api soon) > 2. projectmgr > 3. webpos > 4. bi > 5. birt > 6. myportal > 7. assetmaint > 8. ismgr > 9. scrum > 10. solr > 11. ebay > 12. firstdata > 13. - (those are special, maybe above?) > 14. example > 15. exampleext > - (those plugins don't show atm but exist, maybe need more info > from backend menu?) > 1. ecommerce > 2. ecomseo > 3. multiflex > 4. cmssite > 5. ebaystore > 6. ldap > 7. lucene > 8. passport > 9. pricat > 10. msggateway -- This message was sent by Atlassian Jira (v8.3.4#803005)
