[jira] [Updated] (OFBIZ-12195) webtools/control/threadList no longer works on trunk (only)

2021-03-11 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-12195:

Parent: OFBIZ-1525
Issue Type: Sub-task  (was: Bug)

> webtools/control/threadList no longer works on trunk (only)
> ---
>
> Key: OFBIZ-12195
> URL: https://issues.apache.org/jira/browse/OFBIZ-12195
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> This can be currently tested at 
> https://demo-trunk.ofbiz.apache.org/webtools/control/threadList
> R18 and R17 are OK



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-12195) webtools/control/threadList no longer works on trunk (only)

2021-03-11 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300055#comment-17300055
 ] 

Jacques Le Roux edited comment on OFBIZ-12195 at 3/12/21, 5:26 AM:
---

We need to handle things at the Groovy level, ie put in context, rather than in 
Freemarker template.

It's easy to currentThread more work for allThreadList

And that should be backported, because it's a security issue.


was (Author: jacques.le.roux):
We need to handle things at the Groovy level, ie put in context, rather than in 
Freemarker template.

It's easy to currentThread more work for allThreadList

> webtools/control/threadList no longer works on trunk (only)
> ---
>
> Key: OFBIZ-12195
> URL: https://issues.apache.org/jira/browse/OFBIZ-12195
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> This can be currently tested at 
> https://demo-trunk.ofbiz.apache.org/webtools/control/threadList
> R18 and R17 are OK



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12195) webtools/control/threadList no longer works on trunk (only)

2021-03-11 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300055#comment-17300055
 ] 

Jacques Le Roux commented on OFBIZ-12195:
-

We need to handle things at the Groovy level, ie put in context, rather than in 
Freemarker template.

It's easy to currentThread more work for allThreadList

> webtools/control/threadList no longer works on trunk (only)
> ---
>
> Key: OFBIZ-12195
> URL: https://issues.apache.org/jira/browse/OFBIZ-12195
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> This can be currently tested at 
> https://demo-trunk.ofbiz.apache.org/webtools/control/threadList
> R18 and R17 are OK



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Warning!!! Suspicious Login Attempt iP: 92.972.453

2021-03-11 Thread server














 


Sign-in attempt was blocked 




notifications@ofbiz.apache.org
Someone just used your password to try to sign in to your account. ip security blocked them, but you should check activity below.

Check activity
You can also go directly to:https://notifications@ofbiz.apache.org//notifications

[jira] [Commented] (OFBIZ-12195) webtools/control/threadList no longer works on trunk (only)

2021-03-11 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299770#comment-17299770
 ] 

Jacques Le Roux commented on OFBIZ-12195:
-

It works if we downgrade Freemarker to 2.3.28 as in R18 and even using 2.3.29, 
not 2.3.30.

> webtools/control/threadList no longer works on trunk (only)
> ---
>
> Key: OFBIZ-12195
> URL: https://issues.apache.org/jira/browse/OFBIZ-12195
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> This can be currently tested at 
> https://demo-trunk.ofbiz.apache.org/webtools/control/threadList
> R18 and R17 are OK



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-12166) Default ordering of webapps titles in main menu

2021-03-11 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-12166.
---
Resolution: Implemented

> Default ordering of webapps titles in main menu
> ---
>
> Key: OFBIZ-12166
> URL: https://issues.apache.org/jira/browse/OFBIZ-12166
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: 18.12.01, Upcoming Branch
>
>
> This follows https://markmail.org/message/ftgfpwztflty7klb, excerpt:
> bq.  [...] having more important apps in 1st places would be better [...] the 
> feature should be easily changed by custom projects [...] documentation for 
> that would be enough. 
> I propose this order:
> 1. partymgr(because you need parties to do anything)
> 2. catalog (because you need products to do anything)
> 3. facility (because you need to store products to do anything)
> 4. order (because it's there that things begin to "move")
> 5. accounting  (because it's there that things "end"; ar & ap should 
> disappear)
> 6. content (because you need to associate contents to make things better)
> 7. manufacturing (because OFBiz is also an ERP)
> 8. sfa (because people are often looking for a CRM, BTW most them don't know 
> what SFA is)
> 9. workeffort (this one could be above, but it's not obvious for most people)
> 10. humanres (more important than below IMO)
> 11. marketing (not sure about the place of this one)
> 12. webtools (maybe higher?)
> - (plugins start below)
> 1. rest (could be named api soon)
> 2. projectmgr
> 3. webpos
> 4. bi
> 5. birt
> 6. myportal
> 7. assetmaint
> 8. ismgr
> 9. scrum
> 10. solr
> 11. ebay
> 12. firstdata
> 13. - (those are special, maybe above?)
> 14. example
> 15. exampleext
> - (those plugins don't show atm but exist, maybe need more info 
> from backend menu?)
> 1. ecommerce
> 2. ecomseo
> 3. multiflex
> 4. cmssite
> 5. ebaystore
> 6. ldap
> 7. lucene
> 8. passport
> 9. pricat
> 10. msggateway 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12166) Default ordering of webapps titles in main menu

2021-03-11 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299671#comment-17299671
 ] 

Jacques Le Roux commented on OFBIZ-12166:
-

Ah yes, forgot that

> Default ordering of webapps titles in main menu
> ---
>
> Key: OFBIZ-12166
> URL: https://issues.apache.org/jira/browse/OFBIZ-12166
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: 18.12.01, Upcoming Branch
>
>
> This follows https://markmail.org/message/ftgfpwztflty7klb, excerpt:
> bq.  [...] having more important apps in 1st places would be better [...] the 
> feature should be easily changed by custom projects [...] documentation for 
> that would be enough. 
> I propose this order:
> 1. partymgr(because you need parties to do anything)
> 2. catalog (because you need products to do anything)
> 3. facility (because you need to store products to do anything)
> 4. order (because it's there that things begin to "move")
> 5. accounting  (because it's there that things "end"; ar & ap should 
> disappear)
> 6. content (because you need to associate contents to make things better)
> 7. manufacturing (because OFBiz is also an ERP)
> 8. sfa (because people are often looking for a CRM, BTW most them don't know 
> what SFA is)
> 9. workeffort (this one could be above, but it's not obvious for most people)
> 10. humanres (more important than below IMO)
> 11. marketing (not sure about the place of this one)
> 12. webtools (maybe higher?)
> - (plugins start below)
> 1. rest (could be named api soon)
> 2. projectmgr
> 3. webpos
> 4. bi
> 5. birt
> 6. myportal
> 7. assetmaint
> 8. ismgr
> 9. scrum
> 10. solr
> 11. ebay
> 12. firstdata
> 13. - (those are special, maybe above?)
> 14. example
> 15. exampleext
> - (those plugins don't show atm but exist, maybe need more info 
> from backend menu?)
> 1. ecommerce
> 2. ecomseo
> 3. multiflex
> 4. cmssite
> 5. ebaystore
> 6. ldap
> 7. lucene
> 8. passport
> 9. pricat
> 10. msggateway 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-12194) Remove deprecated ByteWrapper class

2021-03-11 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-12194.
---
Resolution: Implemented

> Remove deprecated ByteWrapper class   
> --
>
> Key: OFBIZ-12194
> URL: https://issues.apache.org/jira/browse/OFBIZ-12194
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/entity
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> [I send a message about it to dev ML in mid 
> 2017|https://markmail.org/message/4we6tognqbck42df]: 
> {quote}
> Here is a comment from David in 2007 in the ByteWrapper class
>  * @deprecated
>  * NOTE DEJ20071022: deprecating this because we want to save the byte[] 
> directly instead of inside a serialized
>  * object, which makes it hard for other apps to use the data, and causes 
> problems if this object is ever updated
> Here is another comment where it's used, in GenericEntity.getBytes()
> if (value instanceof byte[]) {
> return (byte[]) value;
> }
> if (value instanceof org.apache.ofbiz.entity.util.ByteWrapper) {
> // NOTE DEJ20071022: the use of ByteWrapper is not recommended 
> and is deprecated, only old data should be stored that way
> Debug.logWarning("Found a ByteWrapper object in the database for 
> field [" + this.getEntityName() + "." + name + "]; converting to byte[] and 
> returning, but note that you need to update your database to unwrap these 
> objects for future compatibility", module);
> org.apache.ofbiz.entity.util.ByteWrapper wrapper = 
> (org.apache.ofbiz.entity.util.ByteWrapper) value;
> return wrapper.getBytes();
> }
> Here is another related comment (in SqlJdbcUtil.deserializeField())
> // NOTE DEJ20071022: the following code is to convert the byte[] back 
> into an object; if that fails
> //just return the byte[]; this was for the ByteWrapper thing which is 
> now deprecated, so this may
> //be removed in the near future to enhance performance
> Where there is also this code commented out
> //alt 1: binaryInput = rs.getBinaryStream(ind);
> //alt 2: Blob blobLocator = rs.getBlob(ind);
> //if (blobLocator != null) {
> //binaryInput = blobLocator.getBinaryStream();
> //}
> deserializeField() is only used (twice) in SqlJdbcUtil.getValue() and here 
> are the concerned types (11 & 12):
> fieldTypeMap.put("java.lang.Object", 11);
> fieldTypeMap.put("Object", 11);
> fieldTypeMap.put("java.sql.Blob", 12);
> fieldTypeMap.put("Blob", 12);
> fieldTypeMap.put("byte[]", 12);
> fieldTypeMap.put("java.nio.ByteBuffer", 12);
> fieldTypeMap.put("java.nio.HeapByteBuffer", 12);
> And I think we can clean this 2 cases from the ByteWrapper class . So it was 
> 10 years ago, opinions before I open a Jira ?
> {quote}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12194) Remove deprecated ByteWrapper class

2021-03-11 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299665#comment-17299665
 ] 

ASF subversion and git services commented on OFBIZ-12194:
-

Commit 2c1a395df6785ab6402045cf40d4c511d6172788 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=2c1a395 ]

Improved: Remove deprecated ByteWrapper class (OFBIZ-12194)

Removes SqlJdbcUtil::deserializeField and its usage

BY accident I formatted the whole. I had to complete it by hand and I think
it's better as is


> Remove deprecated ByteWrapper class   
> --
>
> Key: OFBIZ-12194
> URL: https://issues.apache.org/jira/browse/OFBIZ-12194
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/entity
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> [I send a message about it to dev ML in mid 
> 2017|https://markmail.org/message/4we6tognqbck42df]: 
> {quote}
> Here is a comment from David in 2007 in the ByteWrapper class
>  * @deprecated
>  * NOTE DEJ20071022: deprecating this because we want to save the byte[] 
> directly instead of inside a serialized
>  * object, which makes it hard for other apps to use the data, and causes 
> problems if this object is ever updated
> Here is another comment where it's used, in GenericEntity.getBytes()
> if (value instanceof byte[]) {
> return (byte[]) value;
> }
> if (value instanceof org.apache.ofbiz.entity.util.ByteWrapper) {
> // NOTE DEJ20071022: the use of ByteWrapper is not recommended 
> and is deprecated, only old data should be stored that way
> Debug.logWarning("Found a ByteWrapper object in the database for 
> field [" + this.getEntityName() + "." + name + "]; converting to byte[] and 
> returning, but note that you need to update your database to unwrap these 
> objects for future compatibility", module);
> org.apache.ofbiz.entity.util.ByteWrapper wrapper = 
> (org.apache.ofbiz.entity.util.ByteWrapper) value;
> return wrapper.getBytes();
> }
> Here is another related comment (in SqlJdbcUtil.deserializeField())
> // NOTE DEJ20071022: the following code is to convert the byte[] back 
> into an object; if that fails
> //just return the byte[]; this was for the ByteWrapper thing which is 
> now deprecated, so this may
> //be removed in the near future to enhance performance
> Where there is also this code commented out
> //alt 1: binaryInput = rs.getBinaryStream(ind);
> //alt 2: Blob blobLocator = rs.getBlob(ind);
> //if (blobLocator != null) {
> //binaryInput = blobLocator.getBinaryStream();
> //}
> deserializeField() is only used (twice) in SqlJdbcUtil.getValue() and here 
> are the concerned types (11 & 12):
> fieldTypeMap.put("java.lang.Object", 11);
> fieldTypeMap.put("Object", 11);
> fieldTypeMap.put("java.sql.Blob", 12);
> fieldTypeMap.put("Blob", 12);
> fieldTypeMap.put("byte[]", 12);
> fieldTypeMap.put("java.nio.ByteBuffer", 12);
> fieldTypeMap.put("java.nio.HeapByteBuffer", 12);
> And I think we can clean this 2 cases from the ByteWrapper class . So it was 
> 10 years ago, opinions before I open a Jira ?
> {quote}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12166) Default ordering of webapps titles in main menu

2021-03-11 Thread Olivier Heintz (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299661#comment-17299661
 ] 

Olivier Heintz commented on OFBIZ-12166:


in R18 the help files are not migrated to asciidoc, so not ;)

> Default ordering of webapps titles in main menu
> ---
>
> Key: OFBIZ-12166
> URL: https://issues.apache.org/jira/browse/OFBIZ-12166
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: 18.12.01, Upcoming Branch
>
>
> This follows https://markmail.org/message/ftgfpwztflty7klb, excerpt:
> bq.  [...] having more important apps in 1st places would be better [...] the 
> feature should be easily changed by custom projects [...] documentation for 
> that would be enough. 
> I propose this order:
> 1. partymgr(because you need parties to do anything)
> 2. catalog (because you need products to do anything)
> 3. facility (because you need to store products to do anything)
> 4. order (because it's there that things begin to "move")
> 5. accounting  (because it's there that things "end"; ar & ap should 
> disappear)
> 6. content (because you need to associate contents to make things better)
> 7. manufacturing (because OFBiz is also an ERP)
> 8. sfa (because people are often looking for a CRM, BTW most them don't know 
> what SFA is)
> 9. workeffort (this one could be above, but it's not obvious for most people)
> 10. humanres (more important than below IMO)
> 11. marketing (not sure about the place of this one)
> 12. webtools (maybe higher?)
> - (plugins start below)
> 1. rest (could be named api soon)
> 2. projectmgr
> 3. webpos
> 4. bi
> 5. birt
> 6. myportal
> 7. assetmaint
> 8. ismgr
> 9. scrum
> 10. solr
> 11. ebay
> 12. firstdata
> 13. - (those are special, maybe above?)
> 14. example
> 15. exampleext
> - (those plugins don't show atm but exist, maybe need more info 
> from backend menu?)
> 1. ecommerce
> 2. ecomseo
> 3. multiflex
> 4. cmssite
> 5. ebaystore
> 6. ldap
> 7. lucene
> 8. passport
> 9. pricat
> 10. msggateway 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12171) Handling the JCenter shutdown

2021-03-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299610#comment-17299610
 ] 

Michael Brohl commented on OFBIZ-12171:
---

For reference, a comprehensive Guide from Gradle: 
[https://blog.gradle.org/jcenter-shutdown]

The important part for our case here is (Plugin Portal = plugins.gradle.org):
{code:java}
Impact to Gradle plugins

Behind the scenes, the Gradle Plugin Portal
uses JCenter to resolve dependencies of plugins. We will be migrating 
the Plugin Portal away from JCenter before the final shutdown. Builds 
will not need to make changes while the Plugin Portal migrates away from
JCenter.
{code}
This means that a constant block of jcenter.bintray.com is currently not 
possible until this issue is solved.

 

> Handling the JCenter shutdown
> -
>
> Key: OFBIZ-12171
> URL: https://issues.apache.org/jira/browse/OFBIZ-12171
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS
>Affects Versions: Release Branch 18.12, Trunk, 17.12.05
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Major
>  Labels: backport-needed
> Fix For: 18.12.01, Upcoming Branch, 17.12.06
>
> Attachments: OFBIZ-12171-1712-README.patch
>
>
> Citing Taher's message at [2]:
> Hello Everyone, 
>  
> I received emails and checked resources [1] that seem to confirm JCenter from 
> JFrog is going down and that the last day of operation for the repository is 
> going to be May 1st 2021. 
>  
> This is a big deal as many running instances will crash unless updated, so 
> not only do future versions of OFBiz need to adapt, but also existing 
> installations. 
>  
> I'm not sure how to best handle this? Especially for production instances out 
> there on older versions of OFBiz. Maybe one solution is to host the existing 
> libraries in some temporary location or try to migrate them to MavenCentral 
> ... Whatever is the solution I think we should make a fast move. 
>  
> [1] 
> [https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter]
>  
> [https://www.infoq.com/news/2021/02/jfrog-jcenter-bintray-closure]
> [2] 
> [https://lists.apache.org/thread.html/rf8e883ca8b90d51ad9d6d48c46f8f1fcc1cb82cce802daeeab0b910a%40%3Cdev.ofbiz.apache.org%3E]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12194) Remove deprecated ByteWrapper class

2021-03-11 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299494#comment-17299494
 ] 

ASF subversion and git services commented on OFBIZ-12194:
-

Commit 9f8ff6255c16c67440a1d7f8170835fb3b39359d in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=9f8ff62 ]

Improved: Remove deprecated ByteWrapper class (OFBIZ-12194)

This due for many years

NOTE DEJ20071022: the use of ByteWrapper is not recommended and is deprecated,
only old data should be stored that way.

I have still to verify the implication of removing
deserializeField() in SqlJdbcUtil.getValue()


> Remove deprecated ByteWrapper class   
> --
>
> Key: OFBIZ-12194
> URL: https://issues.apache.org/jira/browse/OFBIZ-12194
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/entity
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> [I send a message about it to dev ML in mid 
> 2017|https://markmail.org/message/4we6tognqbck42df]: 
> {quote}
> Here is a comment from David in 2007 in the ByteWrapper class
>  * @deprecated
>  * NOTE DEJ20071022: deprecating this because we want to save the byte[] 
> directly instead of inside a serialized
>  * object, which makes it hard for other apps to use the data, and causes 
> problems if this object is ever updated
> Here is another comment where it's used, in GenericEntity.getBytes()
> if (value instanceof byte[]) {
> return (byte[]) value;
> }
> if (value instanceof org.apache.ofbiz.entity.util.ByteWrapper) {
> // NOTE DEJ20071022: the use of ByteWrapper is not recommended 
> and is deprecated, only old data should be stored that way
> Debug.logWarning("Found a ByteWrapper object in the database for 
> field [" + this.getEntityName() + "." + name + "]; converting to byte[] and 
> returning, but note that you need to update your database to unwrap these 
> objects for future compatibility", module);
> org.apache.ofbiz.entity.util.ByteWrapper wrapper = 
> (org.apache.ofbiz.entity.util.ByteWrapper) value;
> return wrapper.getBytes();
> }
> Here is another related comment (in SqlJdbcUtil.deserializeField())
> // NOTE DEJ20071022: the following code is to convert the byte[] back 
> into an object; if that fails
> //just return the byte[]; this was for the ByteWrapper thing which is 
> now deprecated, so this may
> //be removed in the near future to enhance performance
> Where there is also this code commented out
> //alt 1: binaryInput = rs.getBinaryStream(ind);
> //alt 2: Blob blobLocator = rs.getBlob(ind);
> //if (blobLocator != null) {
> //binaryInput = blobLocator.getBinaryStream();
> //}
> deserializeField() is only used (twice) in SqlJdbcUtil.getValue() and here 
> are the concerned types (11 & 12):
> fieldTypeMap.put("java.lang.Object", 11);
> fieldTypeMap.put("Object", 11);
> fieldTypeMap.put("java.sql.Blob", 12);
> fieldTypeMap.put("Blob", 12);
> fieldTypeMap.put("byte[]", 12);
> fieldTypeMap.put("java.nio.ByteBuffer", 12);
> fieldTypeMap.put("java.nio.HeapByteBuffer", 12);
> And I think we can clean this 2 cases from the ByteWrapper class . So it was 
> 10 years ago, opinions before I open a Jira ?
> {quote}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-12171) Handling the JCenter shutdown

2021-03-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299402#comment-17299402
 ] 

Michael Brohl edited comment on OFBIZ-12171 at 3/11/21, 9:54 AM:
-

Hi Michael,

I can't reproduce locally:

C:\projectsASF\Git\ofbiz-framework>type C:\Windows\System32\drivers\etc\hosts
{noformat}
...
127.0.0.1   localhost
127.0.0.1 jcenter.bintray.com
{noformat}
{noformat}
C:\projectsASF\Git\ofbiz-framework>g clean build

C:\projectsASF\Git\ofbiz-framework>gradlew --no-daemon clean build
To honour the JVM settings for this build a new JVM will be forked. Please 
consider using the daemon: 
https://docs.gradle.org/6.5.1/userguide/gradle_daemon.html.
Daemon will be stopped at the end of the build stopping after processing

> Configure project :
You are using one or more deprecated Asciidoctor Gradle plugin features. To 
help with migration run with --warning-mode=all.

> Task :clean

> Task :compileJava
Z:\Gradle\caches\modules-2\files-2.1\org.apache.tomcat\tomcat-el-api\9.0.43\ce73ae606e6bee7df54e4a7701e51886e793d3ac\tomcat-el-api-9.0.43.jar(javax/el/ExpressionFactory.class):
 warning: Cannot find annotation method 'value()' in type 'Se
rviceConsumer': class file for aQute.bnd.annotation.spi.ServiceConsumer not 
found
1 warning

> Task :compileGroovy
> Task :processResources
> Task :classes
> Task :jar
> Task :startScripts
> Task :distTar
> Task :distZip
> Task :assemble
> Task :compileGroovyScriptsJava NO-SOURCE
> Task :compileGroovyScriptsGroovy SKIPPED
> Task :processGroovyScriptsResources NO-SOURCE
> Task :groovyScriptsClasses UP-TO-DATE
> Task :checkstyleGroovyScripts NO-SOURCE

> Task :checkstyleMain
Checkstyle rule violations were found. See the report at: 
file:///C:/projectsASF/Git/ofbiz-framework/build/reports/checkstyle/main.html
Checkstyle files with violations: 63
Checkstyle violations by severity: [error:127]


> Task :compileTestJava
> Task :compileTestGroovy
> Task :processTestResources
> Task :testClasses
> Task :checkstyleTest
> Task :test
> Task :check
> Task :build

BUILD SUCCESSFUL in 4m 38s
14 actionable tasks: 14 executed
C:\projectsASF\Git\ofbiz-framework>git branch
  release17.12
  release18.12
* trunk

C:\projectsASF\Git\ofbiz-framework>
{noformat}


was (Author: jacques.le.roux):
Hi Michael,

I can't reproduce locally:

C:\projectsASF\Git\ofbiz-framework>type C:\Windows\System32\drivers\etc\hosts

{noformat}
# Copyright (c) 1993-2009 Microsoft Corp.
#
# This is a sample HOSTS file used by Microsoft TCP/IP for Windows.
#
# This file contains the mappings of IP addresses to host names. Each
# entry should be kept on an individual line. The IP address should
# be placed in the first column followed by the corresponding host name.
# The IP address and the host name should be separated by at least one
# space.
#
# Additionally, comments (such as these) may be inserted on individual
# lines or following the machine name denoted by a '#' symbol.
#
# For example:
#
#  102.54.94.97 rhino.acme.com  # source server
#   38.25.63.10 x.acme.com  # x client host

# localhost name resolution is handled within DNS itself.
#   127.0.0.1   localhost
#   ::1 localhost

127.0.0.1   localhost
127.0.0.1 jcenter.bintray.com
{noformat}

{noformat}
C:\projectsASF\Git\ofbiz-framework>g clean build

C:\projectsASF\Git\ofbiz-framework>gradlew --no-daemon clean build
To honour the JVM settings for this build a new JVM will be forked. Please 
consider using the daemon: 
https://docs.gradle.org/6.5.1/userguide/gradle_daemon.html.
Daemon will be stopped at the end of the build stopping after processing

> Configure project :
You are using one or more deprecated Asciidoctor Gradle plugin features. To 
help with migration run with --warning-mode=all.

> Task :clean

> Task :compileJava
Z:\Gradle\caches\modules-2\files-2.1\org.apache.tomcat\tomcat-el-api\9.0.43\ce73ae606e6bee7df54e4a7701e51886e793d3ac\tomcat-el-api-9.0.43.jar(javax/el/ExpressionFactory.class):
 warning: Cannot find annotation method 'value()' in type 'Se
rviceConsumer': class file for aQute.bnd.annotation.spi.ServiceConsumer not 
found
1 warning

> Task :compileGroovy
> Task :processResources
> Task :classes
> Task :jar
> Task :startScripts
> Task :distTar
> Task :distZip
> Task :assemble
> Task :compileGroovyScriptsJava NO-SOURCE
> Task :compileGroovyScriptsGroovy SKIPPED
> Task :processGroovyScriptsResources NO-SOURCE
> Task :groovyScriptsClasses UP-TO-DATE
> Task :checkstyleGroovyScripts NO-SOURCE

> Task :checkstyleMain
Checkstyle rule violations were found. See the report at: 
file:///C:/projectsASF/Git/ofbiz-framework/build/reports/checkstyle/main.html
Checkstyle files with violations: 63
Checkstyle violations by severity: [error:127]


> Task :compileTestJava
> Task :compileTestGroovy
> Task :processTestResources
> Task :testClasses
> Task 

[jira] [Commented] (OFBIZ-12171) Handling the JCenter shutdown

2021-03-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299450#comment-17299450
 ] 

Michael Brohl commented on OFBIZ-12171:
---

Ah, great, thanks for checking, Nicolas. That's bad and weird because it worked 
initially on several independent machines.

I'll check the Gradle issues you've linked and see if there is any safe 
workaround.

> Handling the JCenter shutdown
> -
>
> Key: OFBIZ-12171
> URL: https://issues.apache.org/jira/browse/OFBIZ-12171
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS
>Affects Versions: Release Branch 18.12, Trunk, 17.12.05
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Major
>  Labels: backport-needed
> Fix For: 18.12.01, Upcoming Branch, 17.12.06
>
> Attachments: OFBIZ-12171-1712-README.patch
>
>
> Citing Taher's message at [2]:
> Hello Everyone, 
>  
> I received emails and checked resources [1] that seem to confirm JCenter from 
> JFrog is going down and that the last day of operation for the repository is 
> going to be May 1st 2021. 
>  
> This is a big deal as many running instances will crash unless updated, so 
> not only do future versions of OFBiz need to adapt, but also existing 
> installations. 
>  
> I'm not sure how to best handle this? Especially for production instances out 
> there on older versions of OFBiz. Maybe one solution is to host the existing 
> libraries in some temporary location or try to migrate them to MavenCentral 
> ... Whatever is the solution I think we should make a fast move. 
>  
> [1] 
> [https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter]
>  
> [https://www.infoq.com/news/2021/02/jfrog-jcenter-bintray-closure]
> [2] 
> [https://lists.apache.org/thread.html/rf8e883ca8b90d51ad9d6d48c46f8f1fcc1cb82cce802daeeab0b910a%40%3Cdev.ofbiz.apache.org%3E]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12171) Handling the JCenter shutdown

2021-03-11 Thread Nicolas Malin (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299436#comment-17299436
 ] 

Nicolas Malin commented on OFBIZ-12171:
---

I have the same result [~mbrohl]  on fresh environment.

My feeling is the problem seems to come from gradle and after search on gradle 
community I found this :
{code:java}
curl -I 
https://plugins.gradle.org/m2/org/owasp/dependency-check-utils/6.0.3/dependency-check-utils-6.0.3.pom
HTTP/1.1 303 See Other
Date: Thu, 11 Mar 2021 09:29:08 GMT
Content-Length: 0
Connection: keep-alive
Set-Cookie: __cfduid=db39b8919c2ae1868deaeb124ccf084001615454948; expires=Sat, 
10-Apr-21 09:29:08 GMT; path=/; domain=.gradle.org; HttpOnly; SameSite=Lax; 
Secure
Location: 
https://jcenter.bintray.com/org/owasp/dependency-check-utils/6.0.3/dependency-check-utils-6.0.3.pom
{code}
plugins.gradle.org contains some redirect on jcenter.bintray.com.



:( crap

 

I suppose that the gradle community prepare from their part to solve this issue 
https://github.com/gradle/gradle/issues?q=jcenter

> Handling the JCenter shutdown
> -
>
> Key: OFBIZ-12171
> URL: https://issues.apache.org/jira/browse/OFBIZ-12171
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS
>Affects Versions: Release Branch 18.12, Trunk, 17.12.05
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Major
>  Labels: backport-needed
> Fix For: 18.12.01, Upcoming Branch, 17.12.06
>
> Attachments: OFBIZ-12171-1712-README.patch
>
>
> Citing Taher's message at [2]:
> Hello Everyone, 
>  
> I received emails and checked resources [1] that seem to confirm JCenter from 
> JFrog is going down and that the last day of operation for the repository is 
> going to be May 1st 2021. 
>  
> This is a big deal as many running instances will crash unless updated, so 
> not only do future versions of OFBiz need to adapt, but also existing 
> installations. 
>  
> I'm not sure how to best handle this? Especially for production instances out 
> there on older versions of OFBiz. Maybe one solution is to host the existing 
> libraries in some temporary location or try to migrate them to MavenCentral 
> ... Whatever is the solution I think we should make a fast move. 
>  
> [1] 
> [https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter]
>  
> [https://www.infoq.com/news/2021/02/jfrog-jcenter-bintray-closure]
> [2] 
> [https://lists.apache.org/thread.html/rf8e883ca8b90d51ad9d6d48c46f8f1fcc1cb82cce802daeeab0b910a%40%3Cdev.ofbiz.apache.org%3E]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12171) Handling the JCenter shutdown

2021-03-11 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299402#comment-17299402
 ] 

Jacques Le Roux commented on OFBIZ-12171:
-

Hi Michael,

I can't reproduce locally:

C:\projectsASF\Git\ofbiz-framework>type C:\Windows\System32\drivers\etc\hosts

{noformat}
# Copyright (c) 1993-2009 Microsoft Corp.
#
# This is a sample HOSTS file used by Microsoft TCP/IP for Windows.
#
# This file contains the mappings of IP addresses to host names. Each
# entry should be kept on an individual line. The IP address should
# be placed in the first column followed by the corresponding host name.
# The IP address and the host name should be separated by at least one
# space.
#
# Additionally, comments (such as these) may be inserted on individual
# lines or following the machine name denoted by a '#' symbol.
#
# For example:
#
#  102.54.94.97 rhino.acme.com  # source server
#   38.25.63.10 x.acme.com  # x client host

# localhost name resolution is handled within DNS itself.
#   127.0.0.1   localhost
#   ::1 localhost

127.0.0.1   localhost
127.0.0.1 jcenter.bintray.com
{noformat}

{noformat}
C:\projectsASF\Git\ofbiz-framework>g clean build

C:\projectsASF\Git\ofbiz-framework>gradlew --no-daemon clean build
To honour the JVM settings for this build a new JVM will be forked. Please 
consider using the daemon: 
https://docs.gradle.org/6.5.1/userguide/gradle_daemon.html.
Daemon will be stopped at the end of the build stopping after processing

> Configure project :
You are using one or more deprecated Asciidoctor Gradle plugin features. To 
help with migration run with --warning-mode=all.

> Task :clean

> Task :compileJava
Z:\Gradle\caches\modules-2\files-2.1\org.apache.tomcat\tomcat-el-api\9.0.43\ce73ae606e6bee7df54e4a7701e51886e793d3ac\tomcat-el-api-9.0.43.jar(javax/el/ExpressionFactory.class):
 warning: Cannot find annotation method 'value()' in type 'Se
rviceConsumer': class file for aQute.bnd.annotation.spi.ServiceConsumer not 
found
1 warning

> Task :compileGroovy
> Task :processResources
> Task :classes
> Task :jar
> Task :startScripts
> Task :distTar
> Task :distZip
> Task :assemble
> Task :compileGroovyScriptsJava NO-SOURCE
> Task :compileGroovyScriptsGroovy SKIPPED
> Task :processGroovyScriptsResources NO-SOURCE
> Task :groovyScriptsClasses UP-TO-DATE
> Task :checkstyleGroovyScripts NO-SOURCE

> Task :checkstyleMain
Checkstyle rule violations were found. See the report at: 
file:///C:/projectsASF/Git/ofbiz-framework/build/reports/checkstyle/main.html
Checkstyle files with violations: 63
Checkstyle violations by severity: [error:127]


> Task :compileTestJava
> Task :compileTestGroovy
> Task :processTestResources
> Task :testClasses
> Task :checkstyleTest
> Task :test
> Task :check
> Task :build

BUILD SUCCESSFUL in 4m 38s
14 actionable tasks: 14 executed
C:\projectsASF\Git\ofbiz-framework>git branch
  release17.12
  release18.12
* trunk

C:\projectsASF\Git\ofbiz-framework>
{noformat}

> Handling the JCenter shutdown
> -
>
> Key: OFBIZ-12171
> URL: https://issues.apache.org/jira/browse/OFBIZ-12171
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS
>Affects Versions: Release Branch 18.12, Trunk, 17.12.05
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Major
>  Labels: backport-needed
> Fix For: 18.12.01, Upcoming Branch, 17.12.06
>
> Attachments: OFBIZ-12171-1712-README.patch
>
>
> Citing Taher's message at [2]:
> Hello Everyone, 
>  
> I received emails and checked resources [1] that seem to confirm JCenter from 
> JFrog is going down and that the last day of operation for the repository is 
> going to be May 1st 2021. 
>  
> This is a big deal as many running instances will crash unless updated, so 
> not only do future versions of OFBiz need to adapt, but also existing 
> installations. 
>  
> I'm not sure how to best handle this? Especially for production instances out 
> there on older versions of OFBiz. Maybe one solution is to host the existing 
> libraries in some temporary location or try to migrate them to MavenCentral 
> ... Whatever is the solution I think we should make a fast move. 
>  
> [1] 
> [https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter]
>  
> [https://www.infoq.com/news/2021/02/jfrog-jcenter-bintray-closure]
> [2] 
> [https://lists.apache.org/thread.html/rf8e883ca8b90d51ad9d6d48c46f8f1fcc1cb82cce802daeeab0b910a%40%3Cdev.ofbiz.apache.org%3E]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)