[jira] [Assigned] (OFBIZ-11684) Form to add an employee position doesn't function properly when invoked from Humanres tree

2021-03-27 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-11684:
---

Assignee: Aditya Sharma  (was: Jacques Le Roux)

> Form to add an employee position doesn't function properly when invoked from 
> Humanres tree
> --
>
> Key: OFBIZ-11684
> URL: https://issues.apache.org/jira/browse/OFBIZ-11684
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres
>Affects Versions: Release Branch 18.12, 18.12.01, Release Branch 17.12, 
> 17.12.03, Trunk, 17.12.04
>Reporter: Pierre Smits
>Assignee: Aditya Sharma
>Priority: Major
>  Labels: usability
>
> Selecting Add Employee Position or Add Person from the context menu opens the 
> corresponding edit forms with calendar lookup fields.
> The calendar form does no open when the lookup icon is clicked.
> Expected calendar to open on click.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #289: Fixed: Form to add an employee position doesn't function properly when invoked from Humanres tree (OFBIZ-11684)

2021-03-27 Thread GitBox


sonarcloud[bot] commented on pull request #289:
URL: https://github.com/apache/ofbiz-framework/pull/289#issuecomment-808747747


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=289=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=289=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=289=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=289=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=289=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=289=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=289=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=289=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=289=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=289=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=289=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=289=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=289)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=289=duplicated_lines_density=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-11684) Form to add an employee position doesn't function properly when invoked from Humanres tree

2021-03-27 Thread Aditya Sharma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309966#comment-17309966
 ] 

Aditya Sharma commented on OFBIZ-11684:
---

Hi [~jleroux] , all,

The issue doesn't exist on trunk due to work by James where we moved the logic 
to load datejs library in specific macros when needed 
https://github.com/apache/ofbiz-framework/commit/bc5b0d595cab9103e9ec0c03234cec81c80f47c3

In releases 18.12 and 17.12, we include them through GlobalAction decorator. 
The issue with the current approach is the current page and the 
EditEmplPosition page both have GlobalActions decorator all the js files in 
GlobalActions are loaded twice. Either we should Ajaxify a section of the page 
or we should navigate the user to the EditEmplPosition page.

Here is my solution:
[https://github.com/apache/ofbiz-framework/pull/289/files]

Replaced logic to Ajaxify the response from EditEmplPosition with navigating 
the user to EditEmplPosition page.
When we are getting the entire page and updating it into the DOM, it would be 
better if we navigate the user to the page.

Other than that, I noticed that all the labels are not internationalized and 
there is an error for Add Internal Organisation on console:
{code:java}
jquery-3.5.1.min.js:2 Uncaught Error: cannot call methods on dialog prior to 
initialization; attempted to call method 'open'
 at Function.error (jquery-3.5.1.min.js:2)
 at HTMLDivElement. (jquery-ui-1.12.1.min.js:6)
 at Function.each (jquery-3.5.1.min.js:2)
 at s.fn.init.each (jquery-3.5.1.min.js:2)
 at s.fn.init.t.fn. [as dialog] (jquery-ui-1.12.1.min.js:6)
 at :2:18
 at b (jquery-3.5.1.min.js:2)
 at Pe (jquery-3.5.1.min.js:2)
 at s.fn.init.append (jquery-3.5.1.min.js:2)
 at s.fn.init. (jquery-3.5.1.min.js:2){code}

> Form to add an employee position doesn't function properly when invoked from 
> Humanres tree
> --
>
> Key: OFBIZ-11684
> URL: https://issues.apache.org/jira/browse/OFBIZ-11684
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres
>Affects Versions: Release Branch 18.12, 18.12.01, Release Branch 17.12, 
> 17.12.03, Trunk, 17.12.04
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: usability
>
> Selecting Add Employee Position or Add Person from the context menu opens the 
> corresponding edit forms with calendar lookup fields.
> The calendar form does no open when the lookup icon is clicked.
> Expected calendar to open on click.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] adityasharma7 opened a new pull request #289: Fixed: Form to add an employee position doesn't function properly when invoked from Humanres tree (OFBIZ-11684)

2021-03-27 Thread GitBox


adityasharma7 opened a new pull request #289:
URL: https://github.com/apache/ofbiz-framework/pull/289


   Replaced logic to Ajaxify the response from EditEmplPosition with navigating 
the user to EditEmplPosition page.
   When we are getting the entire page and updating it into the DOM, it would 
be better if we navigate the user to the page.
   The issue with the current approach is the current page and the 
EditEmplPosition page both have GlobalActions decorator all the js files in 
GlobalActions are loaded twice. Either we should Ajaxify a section of the page 
or we should navigate the user to the EditEmplPosition page.
   
   Thanks Pierre Smits for reporting the issue and Sebastian Berg, Michael 
Brohl, & Jacques Le Roux for the discussion and efforts
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Assigned] (OFBIZ-12108) Invalid Currency symbol in income statement csv export

2021-03-27 Thread Devanshu Vyas (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Devanshu Vyas reassigned OFBIZ-12108:
-

Assignee: Devanshu Vyas  (was: Praveen Sharma)

> Invalid Currency symbol in income statement csv export
> --
>
> Key: OFBIZ-12108
> URL: https://issues.apache.org/jira/browse/OFBIZ-12108
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Lalit Dashora
>Assignee: Devanshu Vyas
>Priority: Major
> Attachments: OFBIZ-12108.patch
>
>
> 1. Navigate to URL: 
> accounting/control/IncomeStatement?organizationPartyId=Company 
> 2. In income statement section click on export as csv button.
> 3. The exported csv has correct balance but with invalid currency symbol.
> 4. On screen USD $ symbol is shown and in csv some other currency symbol is 
> shown.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-12210) orderStatus.changeReason not set when orderItem is cancelled

2021-03-27 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-12210.
-
Fix Version/s: 17.12.06
   18.12.01
   Resolution: Fixed

Thanks: [~lalit.dashora]

> orderStatus.changeReason not set when orderItem is cancelled
> 
>
> Key: OFBIZ-12210
> URL: https://issues.apache.org/jira/browse/OFBIZ-12210
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Lalit Dashora
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: 18.12.01, 17.12.06
>
> Attachments: 17-12.patch, 18-12.patch, TRUNK.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12210) orderStatus.changeReason not set when orderItem is cancelled

2021-03-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309927#comment-17309927
 ] 

ASF subversion and git services commented on OFBIZ-12210:
-

Commit 921db68bdea34f2757b7d3b6f142d6255a8d3950 in ofbiz-framework's branch 
refs/heads/release17.12 from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=921db68 ]

Fixed: ChangeReason was not being set on OrderStatus when orderItem was marked 
cancelled with reason.
(OFBIZ-12210)
Thanks Lalit Dashora for reporting the issue and providing the patch.


> orderStatus.changeReason not set when orderItem is cancelled
> 
>
> Key: OFBIZ-12210
> URL: https://issues.apache.org/jira/browse/OFBIZ-12210
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Lalit Dashora
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: 17-12.patch, 18-12.patch, TRUNK.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12210) orderStatus.changeReason not set when orderItem is cancelled

2021-03-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309924#comment-17309924
 ] 

ASF subversion and git services commented on OFBIZ-12210:
-

Commit bbab5e18b4cfa611c9fbe84ad602925262e8bb91 in ofbiz-framework's branch 
refs/heads/release18.12 from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=bbab5e1 ]

Fixed: ChangeReason was not being set on OrderStatus when orderItem was marked 
cancelled with reason.
(OFBIZ-12210)
Thanks Lalit Dashora for reporting the issue and providing the patch.


> orderStatus.changeReason not set when orderItem is cancelled
> 
>
> Key: OFBIZ-12210
> URL: https://issues.apache.org/jira/browse/OFBIZ-12210
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Lalit Dashora
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: 17-12.patch, 18-12.patch, TRUNK.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12207) Update swagger ui and redoc and track version

2021-03-27 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309922#comment-17309922
 ] 

Michael Brohl commented on OFBIZ-12207:
---

[~gvasmatkar] I have now updated the swagger ui version and changed the redoc 
loading mechanism from cdn to local with the latest available version.

I've also added a README to track the currently used versions.

Please check and confirm, thank you.

> Update swagger ui and redoc and track version
> -
>
> Key: OFBIZ-12207
> URL: https://issues.apache.org/jira/browse/OFBIZ-12207
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: rest-api
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
>
> The swagger ui files should be updated with the latest  distribution files 
> and a version file should track the currently used version for easier 
> maintenance.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #61: Improved: Updates swagger ui and redoc version, tracks versions in the README (OFBIZ-12207)

2021-03-27 Thread GitBox


sonarcloud[bot] removed a comment on pull request #61:
URL: https://github.com/apache/ofbiz-plugins/pull/61#issuecomment-808709680


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=61=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=61=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=61=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=61=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=61=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=61=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=61=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=61=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=61=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=61=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=61=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=61=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=61)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=61=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=61=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #61: Improved: Updates swagger ui and redoc version, tracks versions in the README (OFBIZ-12207)

2021-03-27 Thread GitBox


sonarcloud[bot] commented on pull request #61:
URL: https://github.com/apache/ofbiz-plugins/pull/61#issuecomment-808710810


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=61=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=61=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=61=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=61=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=61=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=61=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=61=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=61=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=61=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=61=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=61=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=61=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=61)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=61=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=61=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-12210) orderStatus.changeReason not set when orderItem is cancelled

2021-03-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309919#comment-17309919
 ] 

ASF subversion and git services commented on OFBIZ-12210:
-

Commit 933c3e0bc6bc29d142f0ed9f922f0332bcb76df6 in ofbiz-framework's branch 
refs/heads/trunk from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=933c3e0 ]

Fixed: ChangeReason was not being set on OrderStatus when orderItem was marked 
cancelled with reason.
(OFBIZ-12210)
Thanks Lalit Dashora for reporting the issue and providing the patch.


> orderStatus.changeReason not set when orderItem is cancelled
> 
>
> Key: OFBIZ-12210
> URL: https://issues.apache.org/jira/browse/OFBIZ-12210
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Lalit Dashora
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: 17-12.patch, 18-12.patch, TRUNK.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #61: Improved: Updates swagger ui and redoc version, tracks versions in the README (OFBIZ-12207)

2021-03-27 Thread GitBox


sonarcloud[bot] commented on pull request #61:
URL: https://github.com/apache/ofbiz-plugins/pull/61#issuecomment-808709680


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=61=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=61=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=61=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=61=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=61=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=61=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=61=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=61=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=61=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=61=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=61=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=61=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=61)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=61=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=61=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-plugins] mbrohl opened a new pull request #61: Improved: Updates swagger ui and redoc version, tracks versions in the README (OFBIZ-12207)

2021-03-27 Thread GitBox


mbrohl opened a new pull request #61:
URL: https://github.com/apache/ofbiz-plugins/pull/61


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Updated] (OFBIZ-12207) Update swagger ui and redoc and track version

2021-03-27 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-12207:
--
Summary: Update swagger ui and redoc and track version  (was: Update 
swagger ui and track version)

> Update swagger ui and redoc and track version
> -
>
> Key: OFBIZ-12207
> URL: https://issues.apache.org/jira/browse/OFBIZ-12207
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: rest-api
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
>
> The swagger ui files should be updated with the latest  distribution files 
> and a version file should track the currently used version for easier 
> maintenance.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-12197) Remove "ofbiz" prefix from files and folders, code cleanup

2021-03-27 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-12197.
-
Fix Version/s: Upcoming Branch
   Resolution: Implemented

> Remove "ofbiz" prefix from files and folders, code cleanup
> --
>
> Key: OFBIZ-12197
> URL: https://issues.apache.org/jira/browse/OFBIZ-12197
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: rest-api
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> See discussion in OFBIZ-11328.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12197) Remove "ofbiz" prefix from files and folders, code cleanup

2021-03-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309913#comment-17309913
 ] 

ASF subversion and git services commented on OFBIZ-12197:
-

Commit 84d705373fcc7043434f02c97507deb7c3ad2fca in ofbiz-plugins's branch 
refs/heads/trunk from Michael Brohl
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=84d7053 ]

Improved: Fixes html bugs spotted by sonarcloud (OFBIZ-12197)

> Remove "ofbiz" prefix from files and folders, code cleanup
> --
>
> Key: OFBIZ-12197
> URL: https://issues.apache.org/jira/browse/OFBIZ-12197
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: rest-api
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
>
> See discussion in OFBIZ-11328.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12197) Remove "ofbiz" prefix from files and folders, code cleanup

2021-03-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309912#comment-17309912
 ] 

ASF subversion and git services commented on OFBIZ-12197:
-

Commit b5c6a17024013ec655b18975d6878e95f019ee40 in ofbiz-plugins's branch 
refs/heads/trunk from Michael Brohl
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=b5c6a17 ]

Improved: Corrects asciidoc levels and follows  one-sentence-per-line
rule (OFBIZ-12197)

> Remove "ofbiz" prefix from files and folders, code cleanup
> --
>
> Key: OFBIZ-12197
> URL: https://issues.apache.org/jira/browse/OFBIZ-12197
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: rest-api
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
>
> See discussion in OFBIZ-11328.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12197) Remove "ofbiz" prefix from files and folders, code cleanup

2021-03-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309914#comment-17309914
 ] 

ASF subversion and git services commented on OFBIZ-12197:
-

Commit 66055a731aa15706044e4612ea8b7f36c4dbe60c in ofbiz-plugins's branch 
refs/heads/trunk from Michael Brohl
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=66055a7 ]

Improved: Fixes sonarcloud error by using the resource integrity feature
for embedding external redoc javascript file (OFBIZ-12197)

> Remove "ofbiz" prefix from files and folders, code cleanup
> --
>
> Key: OFBIZ-12197
> URL: https://issues.apache.org/jira/browse/OFBIZ-12197
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: rest-api
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
>
> See discussion in OFBIZ-11328.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12197) Remove "ofbiz" prefix from files and folders, code cleanup

2021-03-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309910#comment-17309910
 ] 

ASF subversion and git services commented on OFBIZ-12197:
-

Commit 107b26b66c0a594994bb32d122976622673ef5ce in ofbiz-plugins's branch 
refs/heads/trunk from Michael Brohl
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=107b26b ]

Improved: Remove ofbiz prefix from files and folders (OFBIZ-12197)

Renames ofbiz-rest-impl to rest-api.

> Remove "ofbiz" prefix from files and folders, code cleanup
> --
>
> Key: OFBIZ-12197
> URL: https://issues.apache.org/jira/browse/OFBIZ-12197
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: rest-api
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
>
> See discussion in OFBIZ-11328.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12197) Remove "ofbiz" prefix from files and folders, code cleanup

2021-03-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309911#comment-17309911
 ] 

ASF subversion and git services commented on OFBIZ-12197:
-

Commit 1a6e4f82947f14ab4725d5763985b68972259ca7 in ofbiz-plugins's branch 
refs/heads/trunk from Michael Brohl
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=1a6e4f8 ]

Improved: Removes "ofbiz" prefix from files and folders, code cleanup
(OFBIZ-12197)

> Remove "ofbiz" prefix from files and folders, code cleanup
> --
>
> Key: OFBIZ-12197
> URL: https://issues.apache.org/jira/browse/OFBIZ-12197
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: rest-api
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
>
> See discussion in OFBIZ-11328.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-plugins] mbrohl commented on pull request #60: Improved: Remove ofbiz suffix from rest plugin, code cleanup (OFBIZ-12197)

2021-03-27 Thread GitBox


mbrohl commented on pull request #60:
URL: https://github.com/apache/ofbiz-plugins/pull/60#issuecomment-808703391


   Thanks @girishvasmatkar !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-plugins] mbrohl merged pull request #60: Improved: Remove ofbiz suffix from rest plugin, code cleanup (OFBIZ-12197)

2021-03-27 Thread GitBox


mbrohl merged pull request #60:
URL: https://github.com/apache/ofbiz-plugins/pull/60


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Assigned] (OFBIZ-12210) orderStatus.changeReason not set when orderItem is cancelled

2021-03-27 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-12210:
-

Assignee: Suraj Khurana

> orderStatus.changeReason not set when orderItem is cancelled
> 
>
> Key: OFBIZ-12210
> URL: https://issues.apache.org/jira/browse/OFBIZ-12210
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Lalit Dashora
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: 17-12.patch, 18-12.patch, TRUNK.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-12210) orderStatus.changeReason not set when orderItem is cancelled

2021-03-27 Thread Lalit Dashora (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lalit Dashora reassigned OFBIZ-12210:
-

Assignee: (was: Lalit Dashora)

> orderStatus.changeReason not set when orderItem is cancelled
> 
>
> Key: OFBIZ-12210
> URL: https://issues.apache.org/jira/browse/OFBIZ-12210
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Lalit Dashora
>Priority: Major
> Attachments: 17-12.patch, 18-12.patch, TRUNK.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12210) orderStatus.changeReason not set when orderItem is cancelled

2021-03-27 Thread Lalit Dashora (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lalit Dashora updated OFBIZ-12210:
--
Attachment: 17-12.patch

> orderStatus.changeReason not set when orderItem is cancelled
> 
>
> Key: OFBIZ-12210
> URL: https://issues.apache.org/jira/browse/OFBIZ-12210
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Lalit Dashora
>Assignee: Lalit Dashora
>Priority: Major
> Attachments: 17-12.patch, 18-12.patch, TRUNK.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12210) orderStatus.changeReason not set when orderItem is cancelled

2021-03-27 Thread Lalit Dashora (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309907#comment-17309907
 ] 

Lalit Dashora commented on OFBIZ-12210:
---

Hello,

Please find the attached patch. Now on order item cancellation if the reason is 
selected then it will reflect in orderStatus.changeReason.

Thanks!

> orderStatus.changeReason not set when orderItem is cancelled
> 
>
> Key: OFBIZ-12210
> URL: https://issues.apache.org/jira/browse/OFBIZ-12210
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Lalit Dashora
>Assignee: Lalit Dashora
>Priority: Major
> Attachments: 17-12.patch, 18-12.patch, TRUNK.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12210) orderStatus.changeReason not set when orderItem is cancelled

2021-03-27 Thread Lalit Dashora (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lalit Dashora updated OFBIZ-12210:
--
Attachment: 18-12.patch

> orderStatus.changeReason not set when orderItem is cancelled
> 
>
> Key: OFBIZ-12210
> URL: https://issues.apache.org/jira/browse/OFBIZ-12210
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Lalit Dashora
>Assignee: Lalit Dashora
>Priority: Major
> Attachments: 17-12.patch, 18-12.patch, TRUNK.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12210) orderStatus.changeReason not set when orderItem is cancelled

2021-03-27 Thread Lalit Dashora (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lalit Dashora updated OFBIZ-12210:
--
Attachment: TRUNK.patch

> orderStatus.changeReason not set when orderItem is cancelled
> 
>
> Key: OFBIZ-12210
> URL: https://issues.apache.org/jira/browse/OFBIZ-12210
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Lalit Dashora
>Assignee: Lalit Dashora
>Priority: Major
> Attachments: 17-12.patch, 18-12.patch, TRUNK.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-12188) Error message is displayed when user clicks on create link after the user quick chechout and user is not logged in

2021-03-27 Thread Devanshu Vyas (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Devanshu Vyas closed OFBIZ-12188.
-
Fix Version/s: Upcoming Branch
   Resolution: Fixed

> Error message is displayed when user clicks on create link after the user 
> quick chechout and user is not logged in 
> ---
>
> Key: OFBIZ-12188
> URL: https://issues.apache.org/jira/browse/OFBIZ-12188
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Arpit Mor
>Assignee: Devanshu Vyas
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: 001.webm, OFBIZ-12188.patch
>
>
> Steps to regenerate:
>  * Navigate to ecommerce: [https://demo-trunk.ofbiz.apache.org/ecomseo/]
>  * User should not be logged in 
>  * Add product to cart
>  * Click on quick checkout
>  * Click on create link
> Actual: Error message is displayed. Please refer attachment: 001
> [^001.webm]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12188) Error message is displayed when user clicks on create link after the user quick chechout and user is not logged in

2021-03-27 Thread Devanshu Vyas (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309903#comment-17309903
 ] 

Devanshu Vyas commented on OFBIZ-12188:
---

This has already been fixed at release 18.12 and 17.12 and I have committed for 
the trunk at Commit c6704e90c33c577f05dedc2b41a7037e7d70f20f.

Thank you [~arpit.mor] for reporting the issue and [~sourabh.punyani] for 
providing the fix.

> Error message is displayed when user clicks on create link after the user 
> quick chechout and user is not logged in 
> ---
>
> Key: OFBIZ-12188
> URL: https://issues.apache.org/jira/browse/OFBIZ-12188
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Arpit Mor
>Assignee: Devanshu Vyas
>Priority: Major
> Attachments: 001.webm, OFBIZ-12188.patch
>
>
> Steps to regenerate:
>  * Navigate to ecommerce: [https://demo-trunk.ofbiz.apache.org/ecomseo/]
>  * User should not be logged in 
>  * Add product to cart
>  * Click on quick checkout
>  * Click on create link
> Actual: Error message is displayed. Please refer attachment: 001
> [^001.webm]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12188) Error message is displayed when user clicks on create link after the user quick chechout and user is not logged in

2021-03-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309901#comment-17309901
 ] 

ASF subversion and git services commented on OFBIZ-12188:
-

Commit c6704e90c33c577f05dedc2b41a7037e7d70f20f in ofbiz-plugins's branch 
refs/heads/trunk from Devanshu Vyas
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=c6704e9 ]

Fixed: Error message is displayed when user clicks on create link after the 
user quick chechout and user is not logged in (OFBIZ-12188)
Added missing UtilHttp class import statement
Thanks: Arpit Mor for reporting the issue and Sourabh Punyani for providing the 
fix.


> Error message is displayed when user clicks on create link after the user 
> quick chechout and user is not logged in 
> ---
>
> Key: OFBIZ-12188
> URL: https://issues.apache.org/jira/browse/OFBIZ-12188
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Arpit Mor
>Assignee: Devanshu Vyas
>Priority: Major
> Attachments: 001.webm, OFBIZ-12188.patch
>
>
> Steps to regenerate:
>  * Navigate to ecommerce: [https://demo-trunk.ofbiz.apache.org/ecomseo/]
>  * User should not be logged in 
>  * Add product to cart
>  * Click on quick checkout
>  * Click on create link
> Actual: Error message is displayed. Please refer attachment: 001
> [^001.webm]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12108) Invalid Currency symbol in income statement csv export

2021-03-27 Thread Praveen Sharma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309895#comment-17309895
 ] 

Praveen Sharma commented on OFBIZ-12108:


Added Patch for the same. Please Verify.

> Invalid Currency symbol in income statement csv export
> --
>
> Key: OFBIZ-12108
> URL: https://issues.apache.org/jira/browse/OFBIZ-12108
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Lalit Dashora
>Assignee: Praveen Sharma
>Priority: Major
> Attachments: OFBIZ-12108.patch
>
>
> 1. Navigate to URL: 
> accounting/control/IncomeStatement?organizationPartyId=Company 
> 2. In income statement section click on export as csv button.
> 3. The exported csv has correct balance but with invalid currency symbol.
> 4. On screen USD $ symbol is shown and in csv some other currency symbol is 
> shown.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12108) Invalid Currency symbol in income statement csv export

2021-03-27 Thread Praveen Sharma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Praveen Sharma updated OFBIZ-12108:
---
Attachment: OFBIZ-12108.patch

> Invalid Currency symbol in income statement csv export
> --
>
> Key: OFBIZ-12108
> URL: https://issues.apache.org/jira/browse/OFBIZ-12108
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Lalit Dashora
>Assignee: Praveen Sharma
>Priority: Major
> Attachments: OFBIZ-12108.patch
>
>
> 1. Navigate to URL: 
> accounting/control/IncomeStatement?organizationPartyId=Company 
> 2. In income statement section click on export as csv button.
> 3. The exported csv has correct balance but with invalid currency symbol.
> 4. On screen USD $ symbol is shown and in csv some other currency symbol is 
> shown.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12210) orderStatus.changeReason not set when orderItem is cancelled

2021-03-27 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-12210:
--
Component/s: order

> orderStatus.changeReason not set when orderItem is cancelled
> 
>
> Key: OFBIZ-12210
> URL: https://issues.apache.org/jira/browse/OFBIZ-12210
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Lalit Dashora
>Assignee: Lalit Dashora
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12210) orderStatus.changeReason not set when orderItem is cancelled

2021-03-27 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-12210:
--
Affects Version/s: Release Branch 17.12
   Release Branch 18.12

> orderStatus.changeReason not set when orderItem is cancelled
> 
>
> Key: OFBIZ-12210
> URL: https://issues.apache.org/jira/browse/OFBIZ-12210
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Lalit Dashora
>Assignee: Lalit Dashora
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12210) orderStatus.changeReason not set when orderItem is cancelled

2021-03-27 Thread Suraj Khurana (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309894#comment-17309894
 ] 

Suraj Khurana commented on OFBIZ-12210:
---

I checked on demo-trunk order, by canceling and item after EditItem and 
selecting change reason. It doesn't saved to OrderStatus.changeReason.

[https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=Demo1002]

I think this is a Bug rather than an improvement, changing type.

> orderStatus.changeReason not set when orderItem is cancelled
> 
>
> Key: OFBIZ-12210
> URL: https://issues.apache.org/jira/browse/OFBIZ-12210
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Lalit Dashora
>Assignee: Lalit Dashora
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12210) orderStatus.changeReason not set when orderItem is cancelled

2021-03-27 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-12210:
--
Issue Type: Bug  (was: Improvement)

> orderStatus.changeReason not set when orderItem is cancelled
> 
>
> Key: OFBIZ-12210
> URL: https://issues.apache.org/jira/browse/OFBIZ-12210
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Lalit Dashora
>Assignee: Lalit Dashora
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12109) Invalid Currency symbol in cashflow statement csv export

2021-03-27 Thread Sourabh Punyani (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309891#comment-17309891
 ] 

Sourabh Punyani commented on OFBIZ-12109:
-

I have added a patch (OFBIZ-12109.patch) for the same.

Please verify.

> Invalid Currency symbol in cashflow statement csv export
> 
>
> Key: OFBIZ-12109
> URL: https://issues.apache.org/jira/browse/OFBIZ-12109
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Lalit Dashora
>Assignee: Sourabh Punyani
>Priority: Major
> Attachments: OFBIZ-12109.patch
>
>
> 1. Navigate to URL: 
> accounting/control/CashFlowStatement?organizationPartyId=Company
> 2. In Cash Flow Statement section click on export as csv button.
> 3. The exported csv has correct balance but with invalid currency symbol.
> 4. On screen USD $ symbol is shown and in csv some other currency symbol is 
> shown.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12109) Invalid Currency symbol in cashflow statement csv export

2021-03-27 Thread Sourabh Punyani (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sourabh Punyani updated OFBIZ-12109:

Attachment: OFBIZ-12109.patch

> Invalid Currency symbol in cashflow statement csv export
> 
>
> Key: OFBIZ-12109
> URL: https://issues.apache.org/jira/browse/OFBIZ-12109
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Lalit Dashora
>Assignee: Sourabh Punyani
>Priority: Major
> Attachments: OFBIZ-12109.patch
>
>
> 1. Navigate to URL: 
> accounting/control/CashFlowStatement?organizationPartyId=Company
> 2. In Cash Flow Statement section click on export as csv button.
> 3. The exported csv has correct balance but with invalid currency symbol.
> 4. On screen USD $ symbol is shown and in csv some other currency symbol is 
> shown.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-12108) Invalid Currency symbol in income statement csv export

2021-03-27 Thread Praveen Sharma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Praveen Sharma reassigned OFBIZ-12108:
--

Assignee: Praveen Sharma  (was: Sourabh Punyani)

> Invalid Currency symbol in income statement csv export
> --
>
> Key: OFBIZ-12108
> URL: https://issues.apache.org/jira/browse/OFBIZ-12108
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Lalit Dashora
>Assignee: Praveen Sharma
>Priority: Major
>
> 1. Navigate to URL: 
> accounting/control/IncomeStatement?organizationPartyId=Company 
> 2. In income statement section click on export as csv button.
> 3. The exported csv has correct balance but with invalid currency symbol.
> 4. On screen USD $ symbol is shown and in csv some other currency symbol is 
> shown.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-12109) Invalid Currency symbol in cashflow statement csv export

2021-03-27 Thread Sourabh Punyani (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sourabh Punyani reassigned OFBIZ-12109:
---

Assignee: Sourabh Punyani

> Invalid Currency symbol in cashflow statement csv export
> 
>
> Key: OFBIZ-12109
> URL: https://issues.apache.org/jira/browse/OFBIZ-12109
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Lalit Dashora
>Assignee: Sourabh Punyani
>Priority: Major
>
> 1. Navigate to URL: 
> accounting/control/CashFlowStatement?organizationPartyId=Company
> 2. In Cash Flow Statement section click on export as csv button.
> 3. The exported csv has correct balance but with invalid currency symbol.
> 4. On screen USD $ symbol is shown and in csv some other currency symbol is 
> shown.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-12108) Invalid Currency symbol in income statement csv export

2021-03-27 Thread Sourabh Punyani (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sourabh Punyani reassigned OFBIZ-12108:
---

Assignee: Sourabh Punyani

> Invalid Currency symbol in income statement csv export
> --
>
> Key: OFBIZ-12108
> URL: https://issues.apache.org/jira/browse/OFBIZ-12108
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Lalit Dashora
>Assignee: Sourabh Punyani
>Priority: Major
>
> 1. Navigate to URL: 
> accounting/control/IncomeStatement?organizationPartyId=Company 
> 2. In income statement section click on export as csv button.
> 3. The exported csv has correct balance but with invalid currency symbol.
> 4. On screen USD $ symbol is shown and in csv some other currency symbol is 
> shown.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12210) orderStatus.changeReason not set when orderItem is cancelled

2021-03-27 Thread Lalit Dashora (Jira)
Lalit Dashora created OFBIZ-12210:
-

 Summary: orderStatus.changeReason not set when orderItem is 
cancelled
 Key: OFBIZ-12210
 URL: https://issues.apache.org/jira/browse/OFBIZ-12210
 Project: OFBiz
  Issue Type: Improvement
Affects Versions: Trunk
Reporter: Lalit Dashora
Assignee: Lalit Dashora






--
This message was sent by Atlassian Jira
(v8.3.4#803005)