[GitHub] [ofbiz-plugins] nmalin closed pull request #66: Fixed: ecommerce head title (OFBIZ-12326)

2021-09-28 Thread GitBox


nmalin closed pull request #66:
URL: https://github.com/apache/ofbiz-plugins/pull/66


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-plugins] nmalin closed pull request #65: Improved: Best Selling Ecommerce template translations (OFBIZ-12323)

2021-09-28 Thread GitBox


nmalin closed pull request #65:
URL: https://github.com/apache/ofbiz-plugins/pull/65


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-plugins] nmalin commented on pull request #65: Improved: Best Selling Ecommerce template translations (OFBIZ-12323)

2021-09-28 Thread GitBox


nmalin commented on pull request #65:
URL: https://github.com/apache/ofbiz-plugins/pull/65#issuecomment-929306372


   Thanks it merged from my local


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #320: Improved: Seo translation for Content, Product and Category alternatives urls (OFBIZ-12329)

2021-09-28 Thread GitBox


sonarcloud[bot] commented on pull request #320:
URL: https://github.com/apache/ofbiz-framework/pull/320#issuecomment-929257191


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=320=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=320=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=320=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=320=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=320=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=320=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=320=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=320=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=320=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=320=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=320=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=320=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=320)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=320=duplicated_lines_density=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-plugins] nmalin commented on pull request #41: Fixed: Add To Cart and related UI issue for the products with variant explosion and feature explosion (OFBIZ-11970)

2021-09-28 Thread GitBox


nmalin commented on pull request #41:
URL: https://github.com/apache/ofbiz-plugins/pull/41#issuecomment-929187571


   I loaded from my local,
   Thanks all


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-plugins] nmalin commented on pull request #66: Fixed: ecommerce head title (OFBIZ-12326)

2021-09-28 Thread GitBox


nmalin commented on pull request #66:
URL: https://github.com/apache/ofbiz-plugins/pull/66#issuecomment-929292175


   Thanks, I merged from my local


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-plugins] nmalin closed pull request #41: Fixed: Add To Cart and related UI issue for the products with variant explosion and feature explosion (OFBIZ-11970)

2021-09-28 Thread GitBox


nmalin closed pull request #41:
URL: https://github.com/apache/ofbiz-plugins/pull/41


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #67: Improved: Ecommerce website content (OFBIZ-12330)

2021-09-28 Thread GitBox


sonarcloud[bot] commented on pull request #67:
URL: https://github.com/apache/ofbiz-plugins/pull/67#issuecomment-929279193


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=67=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=67=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=67=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=67=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=67=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=67=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=67=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=67=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=67=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=67=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=67=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=67=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=67)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=67=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=67=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-12328) Some online help links don't get where they should

2021-09-28 Thread Olivier Heintz (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17421616#comment-17421616
 ] 

Olivier Heintz commented on OFBIZ-12328:


I have made the corrections for content link and change the link for accounting 
AR & AP to go to accounting glossary.

Now I will do
 # a short file for "No existing documentation for this component"
 # include the file at the end  of plugin-user-manual
 # change the link for all plugin without doc
 # Create a workeffort.adoc (with just an overview)
 # change the link for workeffort

> Some online help links don't get where they should
> --
>
> Key: OFBIZ-12328
> URL: https://issues.apache.org/jira/browse/OFBIZ-12328
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> Here is a list where the results are wrong. It's only from applications main 
> pages.
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_content_management_overview
> https://demo-trunk.ofbiz.apache.org/ismgr/control/main
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_apache_ofbiz_plugins
> https://demo-trunk.ofbiz.apache.org/ar
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_accounting
> https://demo-trunk.ofbiz.apache.org/ap
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_accounting
> These should better go to 
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_accounting_glossary
> https://demo-trunk.ofbiz.apache.org/firstdata
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html
> https://demo-trunk.ofbiz.apache.org/webpos
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_apache_ofbiz_plugins
> https://demo-trunk.ofbiz.apache.org/bi
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_apache_ofbiz_plugins
> https://demo-trunk.ofbiz.apache.org/solr
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html
> https://demo-trunk.ofbiz.apache.org/workeffort
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_core_business_applications
> Should not get there
> I tried from Catalog sub-pages. Only Image Management went where it's 
> expected. It's less important but still. Order seems better from this POV but 
> only when the help page is already opened. So a lot more to say but not much 
> time for that...



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12328) Some online help links don't get where they should

2021-09-28 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17421612#comment-17421612
 ] 

ASF subversion and git services commented on OFBIZ-12328:
-

Commit 874e2dd03c5d55205d2b230107662e2bd4e61812 in ofbiz-framework's branch 
refs/heads/trunk from Olivier Heintz
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=874e2dd ]

Fixed: online help links don't get where they should (OFBIZ-12328)

Correction for content and accounting AR & AP

> Some online help links don't get where they should
> --
>
> Key: OFBIZ-12328
> URL: https://issues.apache.org/jira/browse/OFBIZ-12328
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> Here is a list where the results are wrong. It's only from applications main 
> pages.
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_content_management_overview
> https://demo-trunk.ofbiz.apache.org/ismgr/control/main
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_apache_ofbiz_plugins
> https://demo-trunk.ofbiz.apache.org/ar
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_accounting
> https://demo-trunk.ofbiz.apache.org/ap
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_accounting
> These should better go to 
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_accounting_glossary
> https://demo-trunk.ofbiz.apache.org/firstdata
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html
> https://demo-trunk.ofbiz.apache.org/webpos
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_apache_ofbiz_plugins
> https://demo-trunk.ofbiz.apache.org/bi
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_apache_ofbiz_plugins
> https://demo-trunk.ofbiz.apache.org/solr
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html
> https://demo-trunk.ofbiz.apache.org/workeffort
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_core_business_applications
> Should not get there
> I tried from Catalog sub-pages. Only Image Management went where it's 
> expected. It's less important but still. Order seems better from this POV but 
> only when the help page is already opened. So a lot more to say but not much 
> time for that...



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10592) OutOfMemory and stucked JobPoller issue

2021-09-28 Thread Giulio Speri (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17421511#comment-17421511
 ] 

Giulio Speri commented on OFBIZ-10592:
--

Hello Nicolas,

 

I will check the modified patch and give you a feedback soon.

 

Thanks!

 

 

> OutOfMemory and stucked JobPoller issue
> ---
>
> Key: OFBIZ-10592
> URL: https://issues.apache.org/jira/browse/OFBIZ-10592
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL APPLICATIONS
>Affects Versions: Release Branch 13.07
>Reporter: Giulio Speri
>Assignee: Giulio Speri
>Priority: Critical
> Attachments: OFBIZ-10592-nmalin.patch, 
> OFBIZ-10592-trunkv18-OutOfMemory_ShoppingListServices.patch, 
> OFBIZ-10592-trunkv18-OutOfMemory_ShoppingListServices.patch, 
> OFBIZ-10592-trunkv18-OutOfMemory_ShoppingListServices.patch, 
> OFBIZ-10592-trunkv18-OutOfMemory_order_properties.patch, 
> OFBIZ-10592-trunkv18-OutOfMemory_order_properties.patch, 
> OFBIZ-10592_OutOfMemory_order_properties.patch, Screenshot from 2019-04-20 
> 02-32-37.png, ShoppingListServices.patch, ShoppingListServices.patch, 
> ShoppingListServices_patchv2.patch, alloc_tree_600k_12102018.png, 
> jvm_ofbiz1_profi_telem.png, jvm_prof_ofbiz1_telem2.png, 
> ofbiz1_jvm_profil_nojobpoller.png, order_properties.patch, 
> order_properties_patchv2.patch, recorder_object_600k_12102018.png, 
> telemetry_ovrl_600k_12102018.png
>
>
>  
> This installation is composed by two instances of OFBiz (v13.07.03), served 
> via an Apache Tomcat webserver, along with a load balancer.
> The database server is MariaDB.
>  
> We had the first problems, about 3 weeks ago, when suddenly, the front1 
> (ofbiz instance 1), stopped serving web requests; front2, instead, was still 
> working correctly.
>  
> Obviously we checked the log files, and we saw that async services were 
> failing; the failure was accompanied by this error line:
>  
> *_Thread "AsyncAppender-async" java.lang.OutOfMemoryError: GC overhead limit 
> exceeded_*
>  
> We analyzed the situation with our system specialists, and they told us that 
> the application was highly stressing machine resources (cpu always at or near 
> 100%, RAM usage rapidly increasing), until the jvm run out of memory.
> This "resource-high-consumption situation", occurred only when ofbiz1 
> instance was started with the JobPoller enabled; if the JobPoller was not 
> enabled, ofbiz run with low resource usage. 
>  
> We then focused on the db, to check first of all the dimensions; the result 
> was disconcerting; 45GB, mainly divided on four tables: SERVER_HIT (about 18 
> GB), VISIT (about 15 GB), ENTITY_SYNC_REMOVE (about 8 GB), VISITOR (about 2 
> GB).
> All the other tables had a size in the order of few MB each.
>  
> The first thing we did, was to clear all those tables, reducing considerably 
> the db size.
> After the cleaning, we tried to start ofbiz1 again, with the JobPoller 
> component enabled; this caused a lot of old scheduled/queued jobs, to execute.
> Except than for the start-up time, the resource usage of the machine, 
> stabilized around normal to low values (cpu 1-10%).
> Ofbiz seemed to work (web request was served), but we noticed that the 
> JobPoller did not schedule or run jobs, anymore. 
> The number of job in "Pending" state in the JobSandbox entity was small 
> (about 20); no Queued, no Failed, no jobs in other states.
> In addition to this, unfortunately, after few hours, jvm run out of memory 
> again.
>  
> Our jvm has an heap maximum size of 20GB ( we have 32GB on the  machine), so 
> it's not so small, I think.
> The next step we're going to do is set-up locally the application over the 
> same production db to see what happens.
>  
> Now that I explained the situation, I am going to ask if, in your 
> opinion/experience:
>  
> Could the JobPoller component be the root (and only) cause of the OutOfMemory 
> of the jvm?
>  
> Could this issue be related to OFBIZ-5710?
>  
> Dumping and analyzing the heap of the jvm could help in some way to 
> understand what or who fills the memory or is this operation a waste of time?
>  
> Is there something that we did not considered or missed during the whole 
> process of problem analysis?
>  
>  
> I really thank you all for your attention and your help; any suggestion or 
> advice would really be greatly appreciated.
>  
> Kind regards,
> Giulio



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-10592) OutOfMemory and stucked JobPoller issue

2021-09-28 Thread Nicolas Malin (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin updated OFBIZ-10592:
--
Attachment: OFBIZ-10592-nmalin.patch

> OutOfMemory and stucked JobPoller issue
> ---
>
> Key: OFBIZ-10592
> URL: https://issues.apache.org/jira/browse/OFBIZ-10592
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL APPLICATIONS
>Affects Versions: Release Branch 13.07
>Reporter: Giulio Speri
>Assignee: Giulio Speri
>Priority: Critical
> Attachments: OFBIZ-10592-nmalin.patch, 
> OFBIZ-10592-trunkv18-OutOfMemory_ShoppingListServices.patch, 
> OFBIZ-10592-trunkv18-OutOfMemory_ShoppingListServices.patch, 
> OFBIZ-10592-trunkv18-OutOfMemory_ShoppingListServices.patch, 
> OFBIZ-10592-trunkv18-OutOfMemory_order_properties.patch, 
> OFBIZ-10592-trunkv18-OutOfMemory_order_properties.patch, 
> OFBIZ-10592_OutOfMemory_order_properties.patch, Screenshot from 2019-04-20 
> 02-32-37.png, ShoppingListServices.patch, ShoppingListServices.patch, 
> ShoppingListServices_patchv2.patch, alloc_tree_600k_12102018.png, 
> jvm_ofbiz1_profi_telem.png, jvm_prof_ofbiz1_telem2.png, 
> ofbiz1_jvm_profil_nojobpoller.png, order_properties.patch, 
> order_properties_patchv2.patch, recorder_object_600k_12102018.png, 
> telemetry_ovrl_600k_12102018.png
>
>
>  
> This installation is composed by two instances of OFBiz (v13.07.03), served 
> via an Apache Tomcat webserver, along with a load balancer.
> The database server is MariaDB.
>  
> We had the first problems, about 3 weeks ago, when suddenly, the front1 
> (ofbiz instance 1), stopped serving web requests; front2, instead, was still 
> working correctly.
>  
> Obviously we checked the log files, and we saw that async services were 
> failing; the failure was accompanied by this error line:
>  
> *_Thread "AsyncAppender-async" java.lang.OutOfMemoryError: GC overhead limit 
> exceeded_*
>  
> We analyzed the situation with our system specialists, and they told us that 
> the application was highly stressing machine resources (cpu always at or near 
> 100%, RAM usage rapidly increasing), until the jvm run out of memory.
> This "resource-high-consumption situation", occurred only when ofbiz1 
> instance was started with the JobPoller enabled; if the JobPoller was not 
> enabled, ofbiz run with low resource usage. 
>  
> We then focused on the db, to check first of all the dimensions; the result 
> was disconcerting; 45GB, mainly divided on four tables: SERVER_HIT (about 18 
> GB), VISIT (about 15 GB), ENTITY_SYNC_REMOVE (about 8 GB), VISITOR (about 2 
> GB).
> All the other tables had a size in the order of few MB each.
>  
> The first thing we did, was to clear all those tables, reducing considerably 
> the db size.
> After the cleaning, we tried to start ofbiz1 again, with the JobPoller 
> component enabled; this caused a lot of old scheduled/queued jobs, to execute.
> Except than for the start-up time, the resource usage of the machine, 
> stabilized around normal to low values (cpu 1-10%).
> Ofbiz seemed to work (web request was served), but we noticed that the 
> JobPoller did not schedule or run jobs, anymore. 
> The number of job in "Pending" state in the JobSandbox entity was small 
> (about 20); no Queued, no Failed, no jobs in other states.
> In addition to this, unfortunately, after few hours, jvm run out of memory 
> again.
>  
> Our jvm has an heap maximum size of 20GB ( we have 32GB on the  machine), so 
> it's not so small, I think.
> The next step we're going to do is set-up locally the application over the 
> same production db to see what happens.
>  
> Now that I explained the situation, I am going to ask if, in your 
> opinion/experience:
>  
> Could the JobPoller component be the root (and only) cause of the OutOfMemory 
> of the jvm?
>  
> Could this issue be related to OFBIZ-5710?
>  
> Dumping and analyzing the heap of the jvm could help in some way to 
> understand what or who fills the memory or is this operation a waste of time?
>  
> Is there something that we did not considered or missed during the whole 
> process of problem analysis?
>  
>  
> I really thank you all for your attention and your help; any suggestion or 
> advice would really be greatly appreciated.
>  
> Kind regards,
> Giulio



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10592) OutOfMemory and stucked JobPoller issue

2021-09-28 Thread Nicolas Malin (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17421505#comment-17421505
 ] 

Nicolas Malin commented on OFBIZ-10592:
---

Hello [~Giulio_MpStyle] ,

I review your patch and add some adaptation.

Mainly, I move the date filter directly to the database request, I didn't 
understand why currently we extract all to analyse after if we can delete it or 
not.

If you can check it from your part, I I will push your improvement after.
[^OFBIZ-10592-nmalin.patch]

> OutOfMemory and stucked JobPoller issue
> ---
>
> Key: OFBIZ-10592
> URL: https://issues.apache.org/jira/browse/OFBIZ-10592
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL APPLICATIONS
>Affects Versions: Release Branch 13.07
>Reporter: Giulio Speri
>Assignee: Giulio Speri
>Priority: Critical
> Attachments: OFBIZ-10592-nmalin.patch, 
> OFBIZ-10592-trunkv18-OutOfMemory_ShoppingListServices.patch, 
> OFBIZ-10592-trunkv18-OutOfMemory_ShoppingListServices.patch, 
> OFBIZ-10592-trunkv18-OutOfMemory_ShoppingListServices.patch, 
> OFBIZ-10592-trunkv18-OutOfMemory_order_properties.patch, 
> OFBIZ-10592-trunkv18-OutOfMemory_order_properties.patch, 
> OFBIZ-10592_OutOfMemory_order_properties.patch, Screenshot from 2019-04-20 
> 02-32-37.png, ShoppingListServices.patch, ShoppingListServices.patch, 
> ShoppingListServices_patchv2.patch, alloc_tree_600k_12102018.png, 
> jvm_ofbiz1_profi_telem.png, jvm_prof_ofbiz1_telem2.png, 
> ofbiz1_jvm_profil_nojobpoller.png, order_properties.patch, 
> order_properties_patchv2.patch, recorder_object_600k_12102018.png, 
> telemetry_ovrl_600k_12102018.png
>
>
>  
> This installation is composed by two instances of OFBiz (v13.07.03), served 
> via an Apache Tomcat webserver, along with a load balancer.
> The database server is MariaDB.
>  
> We had the first problems, about 3 weeks ago, when suddenly, the front1 
> (ofbiz instance 1), stopped serving web requests; front2, instead, was still 
> working correctly.
>  
> Obviously we checked the log files, and we saw that async services were 
> failing; the failure was accompanied by this error line:
>  
> *_Thread "AsyncAppender-async" java.lang.OutOfMemoryError: GC overhead limit 
> exceeded_*
>  
> We analyzed the situation with our system specialists, and they told us that 
> the application was highly stressing machine resources (cpu always at or near 
> 100%, RAM usage rapidly increasing), until the jvm run out of memory.
> This "resource-high-consumption situation", occurred only when ofbiz1 
> instance was started with the JobPoller enabled; if the JobPoller was not 
> enabled, ofbiz run with low resource usage. 
>  
> We then focused on the db, to check first of all the dimensions; the result 
> was disconcerting; 45GB, mainly divided on four tables: SERVER_HIT (about 18 
> GB), VISIT (about 15 GB), ENTITY_SYNC_REMOVE (about 8 GB), VISITOR (about 2 
> GB).
> All the other tables had a size in the order of few MB each.
>  
> The first thing we did, was to clear all those tables, reducing considerably 
> the db size.
> After the cleaning, we tried to start ofbiz1 again, with the JobPoller 
> component enabled; this caused a lot of old scheduled/queued jobs, to execute.
> Except than for the start-up time, the resource usage of the machine, 
> stabilized around normal to low values (cpu 1-10%).
> Ofbiz seemed to work (web request was served), but we noticed that the 
> JobPoller did not schedule or run jobs, anymore. 
> The number of job in "Pending" state in the JobSandbox entity was small 
> (about 20); no Queued, no Failed, no jobs in other states.
> In addition to this, unfortunately, after few hours, jvm run out of memory 
> again.
>  
> Our jvm has an heap maximum size of 20GB ( we have 32GB on the  machine), so 
> it's not so small, I think.
> The next step we're going to do is set-up locally the application over the 
> same production db to see what happens.
>  
> Now that I explained the situation, I am going to ask if, in your 
> opinion/experience:
>  
> Could the JobPoller component be the root (and only) cause of the OutOfMemory 
> of the jvm?
>  
> Could this issue be related to OFBIZ-5710?
>  
> Dumping and analyzing the heap of the jvm could help in some way to 
> understand what or who fills the memory or is this operation a waste of time?
>  
> Is there something that we did not considered or missed during the whole 
> process of problem analysis?
>  
>  
> I really thank you all for your attention and your help; any suggestion or 
> advice would really be greatly appreciated.
>  
> Kind regards,
> Giulio



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-12303) ShoppingCart object does not recognize two products with different configurations

2021-09-28 Thread Nicolas Malin (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin closed OFBIZ-12303.
-
Fix Version/s: Upcoming Branch
   Resolution: Fixed

I loaded on trunk, thanks [~sashoran]

> ShoppingCart object does not recognize two products with different 
> configurations
> -
>
> Key: OFBIZ-12303
> URL: https://issues.apache.org/jira/browse/OFBIZ-12303
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: 17.12.04
> Environment: Centos Linux 8;
> openjdk version "11.0.9" 2020-10-20 LTS;
> PostgreSQL 12.1
>Reporter: Alexander Tzvetanov
>Assignee: Nicolas Malin
>Priority: Minor
>  Labels: easyfix
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12303.patch, OFBIZ-12303.patch
>
>
> By adding two equal products with different configurations in eCommerce cart 
> it results in qty aggregation instead of adding 2 separate cart lines.
>  This is very easy to reproduce in Ofbiz demo site.
>  1. Select PC configuration as it is by default  with 2 GB memory;
>  2. Add it to cart;
>  3. Change a little PC's - i.e. with different memory (1 GB);
>  4. Add to cart again.
>  In result of that in the cart appears the first config with 2 GB twice. The 
> correct behavior is to add 2 different cart lines with 2 different prices.
> I found that the issue is in the class ConfigItem - equals method.
>  In my site I've done a quick fix. I am attaching my code to this bug only 
> for demonstration of the problem.
>  Please apply fix for the next Ofbiz version.
> {noformat}
> applications/product/src/main/java/org/apache/ofbiz/product/config/ProductConfigWrapper.java
> Original code:
> @Override
> public boolean equals(Object o) {
> if (this == o) return true;
> if (o == null || getClass() != o.getClass()) return false;
> ConfigItem that = (ConfigItem) o;
> return Objects.equals(getConfigItem(), that.getConfigItem()) &&
> Objects.equals(getConfigItemAssoc(), 
> that.getConfigItemAssoc()) &&
> Objects.equals(getOptions(), that.getOptions());
> }
> Changed code:
> private boolean isConfigOptionsSelectionEqual( List 
> otherOptions) {
>   List mineOptions = getOptions();
>   for (int i = 0; i < mineOptions.size(); i ++) {
>   if 
> (!(mineOptions.get(i).getId().equals(otherOptions.get(i).getId()) && 
> 
> mineOptions.get(i).isSelected()==otherOptions.get(i).isSelected())) {
>   return false;
>   }
>   
>   }
>   return true;
> }
> 
> @Override
> public boolean equals(Object o) {
> if (this == o) return true;
> if (o == null || getClass() != o.getClass()) return false;
> ConfigItem that = (ConfigItem) o;
> return Objects.equals(getConfigItem(), that.getConfigItem()) &&
> Objects.equals(getConfigItemAssoc(), 
> that.getConfigItemAssoc()) &&
> // Objects.equals(getOptions(), that.getOptions()
> isConfigOptionsSelectionEqual(that.getOptions());
> }
> {noformat}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12303) ShoppingCart object does not recognize two products with different configurations

2021-09-28 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17421461#comment-17421461
 ] 

ASF subversion and git services commented on OFBIZ-12303:
-

Commit b9c8938bc13d28d2a8eaaad33856172f3c901803 in ofbiz-framework's branch 
refs/heads/trunk from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b9c8938 ]

Fixed: ShoppingCart object does not recognize two products with different 
configurations (OFBIZ-12303)

By adding two equal products with different configurations in eCommerce cart it 
results in qty aggregation instead of adding 2 separate cart lines.

When we added a new configuration in cart, we analyze all configuration options 
already present to know if this configuration case is alredy load and merge the 
quantity added.

Thanks: Alexander Tzvetanov for raise this issue


> ShoppingCart object does not recognize two products with different 
> configurations
> -
>
> Key: OFBIZ-12303
> URL: https://issues.apache.org/jira/browse/OFBIZ-12303
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: 17.12.04
> Environment: Centos Linux 8;
> openjdk version "11.0.9" 2020-10-20 LTS;
> PostgreSQL 12.1
>Reporter: Alexander Tzvetanov
>Assignee: Nicolas Malin
>Priority: Minor
>  Labels: easyfix
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12303.patch, OFBIZ-12303.patch
>
>
> By adding two equal products with different configurations in eCommerce cart 
> it results in qty aggregation instead of adding 2 separate cart lines.
>  This is very easy to reproduce in Ofbiz demo site.
>  1. Select PC configuration as it is by default  with 2 GB memory;
>  2. Add it to cart;
>  3. Change a little PC's - i.e. with different memory (1 GB);
>  4. Add to cart again.
>  In result of that in the cart appears the first config with 2 GB twice. The 
> correct behavior is to add 2 different cart lines with 2 different prices.
> I found that the issue is in the class ConfigItem - equals method.
>  In my site I've done a quick fix. I am attaching my code to this bug only 
> for demonstration of the problem.
>  Please apply fix for the next Ofbiz version.
> {noformat}
> applications/product/src/main/java/org/apache/ofbiz/product/config/ProductConfigWrapper.java
> Original code:
> @Override
> public boolean equals(Object o) {
> if (this == o) return true;
> if (o == null || getClass() != o.getClass()) return false;
> ConfigItem that = (ConfigItem) o;
> return Objects.equals(getConfigItem(), that.getConfigItem()) &&
> Objects.equals(getConfigItemAssoc(), 
> that.getConfigItemAssoc()) &&
> Objects.equals(getOptions(), that.getOptions());
> }
> Changed code:
> private boolean isConfigOptionsSelectionEqual( List 
> otherOptions) {
>   List mineOptions = getOptions();
>   for (int i = 0; i < mineOptions.size(); i ++) {
>   if 
> (!(mineOptions.get(i).getId().equals(otherOptions.get(i).getId()) && 
> 
> mineOptions.get(i).isSelected()==otherOptions.get(i).isSelected())) {
>   return false;
>   }
>   
>   }
>   return true;
> }
> 
> @Override
> public boolean equals(Object o) {
> if (this == o) return true;
> if (o == null || getClass() != o.getClass()) return false;
> ConfigItem that = (ConfigItem) o;
> return Objects.equals(getConfigItem(), that.getConfigItem()) &&
> Objects.equals(getConfigItemAssoc(), 
> that.getConfigItemAssoc()) &&
> // Objects.equals(getOptions(), that.getOptions()
> isConfigOptionsSelectionEqual(that.getOptions());
> }
> {noformat}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-12303) ShoppingCart object does not recognize two products with different configurations

2021-09-28 Thread Nicolas Malin (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin reassigned OFBIZ-12303:
-

Assignee: Nicolas Malin

> ShoppingCart object does not recognize two products with different 
> configurations
> -
>
> Key: OFBIZ-12303
> URL: https://issues.apache.org/jira/browse/OFBIZ-12303
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: 17.12.04
> Environment: Centos Linux 8;
> openjdk version "11.0.9" 2020-10-20 LTS;
> PostgreSQL 12.1
>Reporter: Alexander Tzvetanov
>Assignee: Nicolas Malin
>Priority: Minor
>  Labels: easyfix
> Attachments: OFBIZ-12303.patch, OFBIZ-12303.patch
>
>
> By adding two equal products with different configurations in eCommerce cart 
> it results in qty aggregation instead of adding 2 separate cart lines.
>  This is very easy to reproduce in Ofbiz demo site.
>  1. Select PC configuration as it is by default  with 2 GB memory;
>  2. Add it to cart;
>  3. Change a little PC's - i.e. with different memory (1 GB);
>  4. Add to cart again.
>  In result of that in the cart appears the first config with 2 GB twice. The 
> correct behavior is to add 2 different cart lines with 2 different prices.
> I found that the issue is in the class ConfigItem - equals method.
>  In my site I've done a quick fix. I am attaching my code to this bug only 
> for demonstration of the problem.
>  Please apply fix for the next Ofbiz version.
> {noformat}
> applications/product/src/main/java/org/apache/ofbiz/product/config/ProductConfigWrapper.java
> Original code:
> @Override
> public boolean equals(Object o) {
> if (this == o) return true;
> if (o == null || getClass() != o.getClass()) return false;
> ConfigItem that = (ConfigItem) o;
> return Objects.equals(getConfigItem(), that.getConfigItem()) &&
> Objects.equals(getConfigItemAssoc(), 
> that.getConfigItemAssoc()) &&
> Objects.equals(getOptions(), that.getOptions());
> }
> Changed code:
> private boolean isConfigOptionsSelectionEqual( List 
> otherOptions) {
>   List mineOptions = getOptions();
>   for (int i = 0; i < mineOptions.size(); i ++) {
>   if 
> (!(mineOptions.get(i).getId().equals(otherOptions.get(i).getId()) && 
> 
> mineOptions.get(i).isSelected()==otherOptions.get(i).isSelected())) {
>   return false;
>   }
>   
>   }
>   return true;
> }
> 
> @Override
> public boolean equals(Object o) {
> if (this == o) return true;
> if (o == null || getClass() != o.getClass()) return false;
> ConfigItem that = (ConfigItem) o;
> return Objects.equals(getConfigItem(), that.getConfigItem()) &&
> Objects.equals(getConfigItemAssoc(), 
> that.getConfigItemAssoc()) &&
> // Objects.equals(getOptions(), that.getOptions()
> isConfigOptionsSelectionEqual(that.getOptions());
> }
> {noformat}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12303) ShoppingCart object does not recognize two products with different configurations

2021-09-28 Thread Nicolas Malin (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin updated OFBIZ-12303:
--
Priority: Minor  (was: Critical)

> ShoppingCart object does not recognize two products with different 
> configurations
> -
>
> Key: OFBIZ-12303
> URL: https://issues.apache.org/jira/browse/OFBIZ-12303
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: 17.12.04
> Environment: Centos Linux 8;
> openjdk version "11.0.9" 2020-10-20 LTS;
> PostgreSQL 12.1
>Reporter: Alexander Tzvetanov
>Priority: Minor
>  Labels: easyfix
> Attachments: OFBIZ-12303.patch, OFBIZ-12303.patch
>
>
> By adding two equal products with different configurations in eCommerce cart 
> it results in qty aggregation instead of adding 2 separate cart lines.
>  This is very easy to reproduce in Ofbiz demo site.
>  1. Select PC configuration as it is by default  with 2 GB memory;
>  2. Add it to cart;
>  3. Change a little PC's - i.e. with different memory (1 GB);
>  4. Add to cart again.
>  In result of that in the cart appears the first config with 2 GB twice. The 
> correct behavior is to add 2 different cart lines with 2 different prices.
> I found that the issue is in the class ConfigItem - equals method.
>  In my site I've done a quick fix. I am attaching my code to this bug only 
> for demonstration of the problem.
>  Please apply fix for the next Ofbiz version.
> {noformat}
> applications/product/src/main/java/org/apache/ofbiz/product/config/ProductConfigWrapper.java
> Original code:
> @Override
> public boolean equals(Object o) {
> if (this == o) return true;
> if (o == null || getClass() != o.getClass()) return false;
> ConfigItem that = (ConfigItem) o;
> return Objects.equals(getConfigItem(), that.getConfigItem()) &&
> Objects.equals(getConfigItemAssoc(), 
> that.getConfigItemAssoc()) &&
> Objects.equals(getOptions(), that.getOptions());
> }
> Changed code:
> private boolean isConfigOptionsSelectionEqual( List 
> otherOptions) {
>   List mineOptions = getOptions();
>   for (int i = 0; i < mineOptions.size(); i ++) {
>   if 
> (!(mineOptions.get(i).getId().equals(otherOptions.get(i).getId()) && 
> 
> mineOptions.get(i).isSelected()==otherOptions.get(i).isSelected())) {
>   return false;
>   }
>   
>   }
>   return true;
> }
> 
> @Override
> public boolean equals(Object o) {
> if (this == o) return true;
> if (o == null || getClass() != o.getClass()) return false;
> ConfigItem that = (ConfigItem) o;
> return Objects.equals(getConfigItem(), that.getConfigItem()) &&
> Objects.equals(getConfigItemAssoc(), 
> that.getConfigItemAssoc()) &&
> // Objects.equals(getOptions(), that.getOptions()
> isConfigOptionsSelectionEqual(that.getOptions());
> }
> {noformat}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-plugins] nmalin commented on pull request #65: Improved: Best Selling Ecommerce template translations (OFBIZ-12323)

2021-09-28 Thread GitBox


nmalin commented on pull request #65:
URL: https://github.com/apache/ofbiz-plugins/pull/65#issuecomment-929306372


   Thanks it merged from my local


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-plugins] nmalin closed pull request #65: Improved: Best Selling Ecommerce template translations (OFBIZ-12323)

2021-09-28 Thread GitBox


nmalin closed pull request #65:
URL: https://github.com/apache/ofbiz-plugins/pull/65


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Closed] (OFBIZ-12323) Best Selling Ecommerce template

2021-09-28 Thread Nicolas Malin (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin closed OFBIZ-12323.
-
Fix Version/s: Upcoming Branch
 Assignee: Nicolas Malin
   Resolution: Fixed

It loaded on trunk, thanks [~charles steltzlen]

> Best Selling Ecommerce template
> ---
>
> Key: OFBIZ-12323
> URL: https://issues.apache.org/jira/browse/OFBIZ-12323
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Charles STELTZLEN
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> {color:#172b4d}The template (ShowBestSellingCategory.ftl) of catalog category 
> type 'Best Selling' 
> ({color}P{color:#172b4d}CCT_BEST_SELL{color}{color:#6a8759}) used on home 
> page (Main.ftl) of Ecommerce front could be improved with traduction 
> usage.{color}
>  
>  We can labellise the 'Popular categories' title by adding an 
> EcommerceBestSelling label and replace traduction by 'Best Selling' to avoid 
> confusion with catalog category type 'Most Popular (one)'.
>  {color:#172b4d}We can also use ContentWrapper for category and product 
> names, description, image.
> {color}
> You can see the PR :
> {color:#172b4d}https://github.com/apache/ofbiz-plugins/pull/65{color}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12323) Best Selling Ecommerce template

2021-09-28 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17421437#comment-17421437
 ] 

ASF subversion and git services commented on OFBIZ-12323:
-

Commit 553472c052dad93cb55c2e66cf7257b2ace511a3 in ofbiz-plugins's branch 
refs/heads/trunk from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=553472c ]

Fixed: Replace hardcoded label 'Popular categories' (OFBIZ-12323)

Labellise the 'Popular categories' title by adding an EcommerceBestSelling 
label and replace traduction by 'Best Selling' to avoid confusion with catalog 
category type 'Most Popular (one)'.

Thanks: Charles STELTZLEN


> Best Selling Ecommerce template
> ---
>
> Key: OFBIZ-12323
> URL: https://issues.apache.org/jira/browse/OFBIZ-12323
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Charles STELTZLEN
>Priority: Minor
>
> {color:#172b4d}The template (ShowBestSellingCategory.ftl) of catalog category 
> type 'Best Selling' 
> ({color}P{color:#172b4d}CCT_BEST_SELL{color}{color:#6a8759}) used on home 
> page (Main.ftl) of Ecommerce front could be improved with traduction 
> usage.{color}
>  
>  We can labellise the 'Popular categories' title by adding an 
> EcommerceBestSelling label and replace traduction by 'Best Selling' to avoid 
> confusion with catalog category type 'Most Popular (one)'.
>  {color:#172b4d}We can also use ContentWrapper for category and product 
> names, description, image.
> {color}
> You can see the PR :
> {color:#172b4d}https://github.com/apache/ofbiz-plugins/pull/65{color}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12326) Ecommerce Head Title

2021-09-28 Thread Nicolas Malin (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin updated OFBIZ-12326:
--
Fix Version/s: Upcoming Branch

> Ecommerce Head Title
> 
>
> Key: OFBIZ-12326
> URL: https://issues.apache.org/jira/browse/OFBIZ-12326
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Reporter: Charles STELTZLEN
>Assignee: Nicolas Malin
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> Fixed: ecommerce head title (no ':' if no title or titleProperty)
> Explanation: To avoid the ':' in the tabs title for Ecommerce
>  
> https://github.com/apache/ofbiz-plugins/pull/66



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-plugins] nmalin closed pull request #66: Fixed: ecommerce head title (OFBIZ-12326)

2021-09-28 Thread GitBox


nmalin closed pull request #66:
URL: https://github.com/apache/ofbiz-plugins/pull/66


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-plugins] nmalin commented on pull request #66: Fixed: ecommerce head title (OFBIZ-12326)

2021-09-28 Thread GitBox


nmalin commented on pull request #66:
URL: https://github.com/apache/ofbiz-plugins/pull/66#issuecomment-929292175


   Thanks, I merged from my local


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Closed] (OFBIZ-12326) Ecommerce Head Title

2021-09-28 Thread Nicolas Malin (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin closed OFBIZ-12326.
-
  Assignee: Nicolas Malin
Resolution: Fixed

Thanks [~charles steltzlen] it loaded on trunk

> Ecommerce Head Title
> 
>
> Key: OFBIZ-12326
> URL: https://issues.apache.org/jira/browse/OFBIZ-12326
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Reporter: Charles STELTZLEN
>Assignee: Nicolas Malin
>Priority: Trivial
>
> Fixed: ecommerce head title (no ':' if no title or titleProperty)
> Explanation: To avoid the ':' in the tabs title for Ecommerce
>  
> https://github.com/apache/ofbiz-plugins/pull/66



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12326) Ecommerce Head Title

2021-09-28 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17421428#comment-17421428
 ] 

ASF subversion and git services commented on OFBIZ-12326:
-

Commit 7b373040435460e914b4147edb25f3f525d70851 in ofbiz-plugins's branch 
refs/heads/trunk from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=7b37304 ]

Fixed: ecommerce head title, no ':' if no title or titleProperty (OFBIZ-12326)

When the page title is empty, avoid the ':' in the navigator tabs title for 
Ecommerce

Thanks: Charles STELTZLEN


> Ecommerce Head Title
> 
>
> Key: OFBIZ-12326
> URL: https://issues.apache.org/jira/browse/OFBIZ-12326
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Reporter: Charles STELTZLEN
>Priority: Trivial
>
> Fixed: ecommerce head title (no ':' if no title or titleProperty)
> Explanation: To avoid the ':' in the tabs title for Ecommerce
>  
> https://github.com/apache/ofbiz-plugins/pull/66



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #67: Improved: Ecommerce website content (OFBIZ-12330)

2021-09-28 Thread GitBox


sonarcloud[bot] commented on pull request #67:
URL: https://github.com/apache/ofbiz-plugins/pull/67#issuecomment-929279193


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=67=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=67=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=67=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=67=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=67=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=67=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=67=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=67=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=67=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=67=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=67=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=67=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=67)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=67=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=67=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-plugins] CharlesNereide opened a new pull request #67: Improved: Ecommerce website content (OFBIZ-12330)

2021-09-28 Thread GitBox


CharlesNereide opened a new pull request #67:
URL: https://github.com/apache/ofbiz-plugins/pull/67


   Improved: WebSite configurations for contents, blogs, forums and factoids


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (OFBIZ-12330) Ecommerce and WebSite roots

2021-09-28 Thread Charles STELTZLEN (Jira)
Charles STELTZLEN created OFBIZ-12330:
-

 Summary: Ecommerce and WebSite roots
 Key: OFBIZ-12330
 URL: https://issues.apache.org/jira/browse/OFBIZ-12330
 Project: OFBiz
  Issue Type: Improvement
  Components: ecommerce
Affects Versions: Trunk
Reporter: Charles STELTZLEN


Ecommerce plugin use a template with different areas to display front 
information. These areas retrieve the data to display by different way and need 
to be review.

 

The goal of this Jira is to add variables instead of hard data for Content, 
Blog, Forum and Factoids.
We used the WebSiteContent definition (like the definition of WebStoreCONTENT) 
to declare all variable roots :
 * Blog: WebStoreBLOG / BLOG_ROOT
 * Forum: WebSToreFORUM / FORUM_ROOT
 * Factoids: WebStoreFACTOIDS / FACTOIDS_ROOT

Then, in all FTL or Screens using an hard coded id, we replace by retrieving 
the correct Web Site Content.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #320: Improved: Seo translation for Content, Product and Category alternatives urls (OFBIZ-12329)

2021-09-28 Thread GitBox


sonarcloud[bot] commented on pull request #320:
URL: https://github.com/apache/ofbiz-framework/pull/320#issuecomment-929257191


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=320=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=320=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=320=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=320=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=320=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=320=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=320=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=320=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=320=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=320=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=320=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=320=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=320)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=320=duplicated_lines_density=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] CharlesNereide opened a new pull request #320: Improved: Seo translation for Content, Product and Category alternatives urls (OFBIZ-12329)

2021-09-28 Thread GitBox


CharlesNereide opened a new pull request #320:
URL: https://github.com/apache/ofbiz-framework/pull/320


   Improved: Seo translation for Content, Product and Category
   Fixed: get alt url before retrieving the name or description from record
   Fixed: the mandatory character '/' for objectInfo alternative url


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (OFBIZ-12329) Seo Improvements

2021-09-28 Thread Charles STELTZLEN (Jira)
Charles STELTZLEN created OFBIZ-12329:
-

 Summary: Seo Improvements
 Key: OFBIZ-12329
 URL: https://issues.apache.org/jira/browse/OFBIZ-12329
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL APPLICATIONS
Affects Versions: Trunk
Reporter: Charles STELTZLEN


The system of alternatives url can not be used actually for translated url.

The goal is to translation for alternative urls (content, product and category 
objects) and improve code (for example, the '/' character is now not mandatory 
for alternative url object info).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-plugins] nmalin closed pull request #41: Fixed: Add To Cart and related UI issue for the products with variant explosion and feature explosion (OFBIZ-11970)

2021-09-28 Thread GitBox


nmalin closed pull request #41:
URL: https://github.com/apache/ofbiz-plugins/pull/41


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-plugins] nmalin commented on pull request #41: Fixed: Add To Cart and related UI issue for the products with variant explosion and feature explosion (OFBIZ-11970)

2021-09-28 Thread GitBox


nmalin commented on pull request #41:
URL: https://github.com/apache/ofbiz-plugins/pull/41#issuecomment-929187571


   I loaded from my local,
   Thanks all


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Closed] (OFBIZ-11970) Add to cart is not working for products with selectable features

2021-09-28 Thread Nicolas Malin (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin closed OFBIZ-11970.
-
Fix Version/s: Upcoming Branch
   18.12.01
   Resolution: Fixed

Thanks both, I loaded your fix on 18.12 and trunk.

> Add to cart is not working for products with selectable features
> 
>
> Key: OFBIZ-11970
> URL: https://issues.apache.org/jira/browse/OFBIZ-11970
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Ravi Lodhi
>Assignee: Nicolas Malin
>Priority: Major
> Fix For: 18.12.01, Upcoming Branch
>
> Attachments: addToCartProductWithVariantExplosionError.png
>
>
> Issue-1: Steps to regenerate:
> 1. Visit the [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main].
>  2. Select the "Giant Widget with feature explosion" from the Popular 
> Categories section on home page. You will be redirected to product detail 
> page.
>  3. Select color and size from the respective dropdowns and click on Add To 
> Cart button.
>  4. Product is not getting added in cart.
> Error on browser console:
> {code:java}
> getJs?name=ProductDetail:52 Uncaught TypeError: Cannot read property 'value' 
> of undefined
>  at addItem (getJs?name=ProductDetail:52)
>  at :1:12
> addItem @ getJs?name=ProductDetail:52
> (anonymous) @ VM1370:1
> {code}
>  
>  
> Expected: Product should be added successfully.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11970) Add to cart is not working for products with selectable features

2021-09-28 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17421353#comment-17421353
 ] 

ASF subversion and git services commented on OFBIZ-11970:
-

Commit df7ae11c73055050d30564df7af4872718e26616 in ofbiz-plugins's branch 
refs/heads/release18.12 from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=df7ae11 ]

Fixed: Add to cart is not working for products with selectable features 
(OFBIZ-11970)

Two issues were present, first was due to incorrect markup and the second was 
due to ajax request and response view of the additem request.
In additem request last saved view or the view of the last request is rendered 
on successful operation and in this case the last request/view is the one which 
is used to render UOM dropdown.

Thanks: Akash Jain and Ravi Lodhi


> Add to cart is not working for products with selectable features
> 
>
> Key: OFBIZ-11970
> URL: https://issues.apache.org/jira/browse/OFBIZ-11970
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Ravi Lodhi
>Assignee: Nicolas Malin
>Priority: Major
> Attachments: addToCartProductWithVariantExplosionError.png
>
>
> Issue-1: Steps to regenerate:
> 1. Visit the [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main].
>  2. Select the "Giant Widget with feature explosion" from the Popular 
> Categories section on home page. You will be redirected to product detail 
> page.
>  3. Select color and size from the respective dropdowns and click on Add To 
> Cart button.
>  4. Product is not getting added in cart.
> Error on browser console:
> {code:java}
> getJs?name=ProductDetail:52 Uncaught TypeError: Cannot read property 'value' 
> of undefined
>  at addItem (getJs?name=ProductDetail:52)
>  at :1:12
> addItem @ getJs?name=ProductDetail:52
> (anonymous) @ VM1370:1
> {code}
>  
>  
> Expected: Product should be added successfully.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11970) Add to cart is not working for products with selectable features

2021-09-28 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17421354#comment-17421354
 ] 

ASF subversion and git services commented on OFBIZ-11970:
-

Commit 20e00c82a3950e413395cdfd7e79a424ec9178f4 in ofbiz-plugins's branch 
refs/heads/trunk from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=20e00c8 ]

Fixed: Add to cart is not working for products with selectable features 
(OFBIZ-11970)

Two issues were present, first was due to incorrect markup and the second was 
due to ajax request and response view of the additem request.
In additem request last saved view or the view of the last request is rendered 
on successful operation and in this case the last request/view is the one which 
is used to render UOM dropdown.

Thanks: Akash Jain and Ravi Lodhi


> Add to cart is not working for products with selectable features
> 
>
> Key: OFBIZ-11970
> URL: https://issues.apache.org/jira/browse/OFBIZ-11970
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Ravi Lodhi
>Assignee: Nicolas Malin
>Priority: Major
> Attachments: addToCartProductWithVariantExplosionError.png
>
>
> Issue-1: Steps to regenerate:
> 1. Visit the [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main].
>  2. Select the "Giant Widget with feature explosion" from the Popular 
> Categories section on home page. You will be redirected to product detail 
> page.
>  3. Select color and size from the respective dropdowns and click on Add To 
> Cart button.
>  4. Product is not getting added in cart.
> Error on browser console:
> {code:java}
> getJs?name=ProductDetail:52 Uncaught TypeError: Cannot read property 'value' 
> of undefined
>  at addItem (getJs?name=ProductDetail:52)
>  at :1:12
> addItem @ getJs?name=ProductDetail:52
> (anonymous) @ VM1370:1
> {code}
>  
>  
> Expected: Product should be added successfully.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11970) Add to cart is not working for products with selectable features

2021-09-28 Thread Nicolas Malin (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin reassigned OFBIZ-11970:
-

Assignee: Nicolas Malin  (was: Akash Jain)

> Add to cart is not working for products with selectable features
> 
>
> Key: OFBIZ-11970
> URL: https://issues.apache.org/jira/browse/OFBIZ-11970
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Ravi Lodhi
>Assignee: Nicolas Malin
>Priority: Major
> Attachments: addToCartProductWithVariantExplosionError.png
>
>
> Issue-1: Steps to regenerate:
> 1. Visit the [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main].
>  2. Select the "Giant Widget with feature explosion" from the Popular 
> Categories section on home page. You will be redirected to product detail 
> page.
>  3. Select color and size from the respective dropdowns and click on Add To 
> Cart button.
>  4. Product is not getting added in cart.
> Error on browser console:
> {code:java}
> getJs?name=ProductDetail:52 Uncaught TypeError: Cannot read property 'value' 
> of undefined
>  at addItem (getJs?name=ProductDetail:52)
>  at :1:12
> addItem @ getJs?name=ProductDetail:52
> (anonymous) @ VM1370:1
> {code}
>  
>  
> Expected: Product should be added successfully.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12328) Some online help links don't get where they should

2021-09-28 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17421286#comment-17421286
 ] 

Jacques Le Roux commented on OFBIZ-12328:
-

Hi Olivier,

As is said in description
{quote}

https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_content_management_overview
gets nowhere, should be
https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_overview_6
{quote}
It was the 1st I stumbled upon

{quote}
https://demo-trunk.ofbiz.apache.org/ar
https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_accounting
https://demo-trunk.ofbiz.apache.org/ap
https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_accounting
These should better go to
https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_accounting_glossary
{quote}

Somehow related
https://demo-trunk.ofbiz.apache.org/webpos
https://demo-trunk.ofbiz.apache.org/solr
https://demo-trunk.ofbiz.apache.org/bi
https://demo-trunk.ofbiz.apache.org/ismgr
https://demo-trunk.ofbiz.apache.org/firstdata
Have no doc, not sure where the help buttons should bo, maybe nowhere until 
some doc is present? But what nowhere is?

https://demo-trunk.ofbiz.apache.org/workeffort
https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_core_business_applications
Should not get there. It's weird that this component has no doc

So, apart content, AR and AP, the problem is rather missing doc

Also:
bq. I tried from Catalog sub-pages. Only Image Management went where it's 
expected. It's less important but still. Order seems better from this POV but 
only when the help page is already opened. So a lot more to say but not much 
time for that...


HTH

> Some online help links don't get where they should
> --
>
> Key: OFBIZ-12328
> URL: https://issues.apache.org/jira/browse/OFBIZ-12328
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> Here is a list where the results are wrong. It's only from applications main 
> pages.
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_content_management_overview
> https://demo-trunk.ofbiz.apache.org/ismgr/control/main
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_apache_ofbiz_plugins
> https://demo-trunk.ofbiz.apache.org/ar
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_accounting
> https://demo-trunk.ofbiz.apache.org/ap
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_accounting
> These should better go to 
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_accounting_glossary
> https://demo-trunk.ofbiz.apache.org/firstdata
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html
> https://demo-trunk.ofbiz.apache.org/webpos
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_apache_ofbiz_plugins
> https://demo-trunk.ofbiz.apache.org/bi
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_apache_ofbiz_plugins
> https://demo-trunk.ofbiz.apache.org/solr
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html
> https://demo-trunk.ofbiz.apache.org/workeffort
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_core_business_applications
> Should not get there
> I tried from Catalog sub-pages. Only Image Management went where it's 
> expected. It's less important but still. Order seems better from this POV but 
> only when the help page is already opened. So a lot more to say but not much 
> time for that...



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12328) Some online help links don't get where they should

2021-09-28 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-12328:

Description: 
Here is a list where the results are wrong. It's only from applications main 
pages.

https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_content_management_overview

https://demo-trunk.ofbiz.apache.org/ismgr/control/main
https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_apache_ofbiz_plugins

https://demo-trunk.ofbiz.apache.org/ar
https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_accounting
https://demo-trunk.ofbiz.apache.org/ap
https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_accounting
These should better go to 
https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_accounting_glossary

https://demo-trunk.ofbiz.apache.org/firstdata
https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html

https://demo-trunk.ofbiz.apache.org/webpos
https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_apache_ofbiz_plugins

https://demo-trunk.ofbiz.apache.org/bi
https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_apache_ofbiz_plugins

https://demo-trunk.ofbiz.apache.org/solr
https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html

https://demo-trunk.ofbiz.apache.org/workeffort
https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_core_business_applications
Should not get there

I tried from Catalog sub-pages. Only Image Management went where it's expected. 
It's less important but still. Order seems better from this POV but only when 
the help page is already opened. So a lot more to say but not much time for 
that...

  was:
Here is a list where the results are wrong. It's only from applications main 
pages.

https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_content_management_overview

https://demo-trunk.ofbiz.apache.org/ismgr/control/main
https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_apache_ofbiz_plugins

https://demo-trunk.ofbiz.apache.org/ar
https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_accounting
https://demo-trunk.ofbiz.apache.org/ap
https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_accounting
These should better go to 
https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_accounting_glossary

https://demo-trunk.ofbiz.apache.org/firstdata
https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html

https://demo-trunk.ofbiz.apache.org/webpos
https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_apache_ofbiz_plugins

https://demo-trunk.ofbiz.apache.org/bi
https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_apache_ofbiz_plugins

https://demo-trunk.ofbiz.apache.org/solr
https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html

https://demo-trunk.ofbiz.apache.org/ebay
https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_ebay_appl_introduction
It exists but you don't get there at 1st time, weird

https://demo-trunk.ofbiz.apache.org/workeffort
https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_core_business_applications
Should not get there

I tried from Catalog sub-pages. Only Image Management went where it's expected. 
It's less important but still. Order seems better from this POV but only when 
the help page is already opened. So a lot more to say but not much time for 
that...


> Some online help links don't get where they should
> --
>
> Key: OFBIZ-12328
> URL: https://issues.apache.org/jira/browse/OFBIZ-12328
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> Here is a list where the results are wrong. It's only from applications main 
> pages.
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_content_management_overview
> https://demo-trunk.ofbiz.apache.org/ismgr/control/main
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_apache_ofbiz_plugins
> https://demo-trunk.ofbiz.apache.org/ar
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_accounting
> https://demo-trunk.ofbiz.apache.org/ap
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_accounting
> These should better go to 
> 

[jira] [Commented] (OFBIZ-11683) Humanres tree right-click pop-up menu allows existing OU to be added again

2021-09-28 Thread Nicolas Malin (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17421264#comment-17421264
 ] 

Nicolas Malin commented on OFBIZ-11683:
---

I think the problem come from the inconsistency between the demo data and how 
the human tree resolve and create.

The main question that I wish to say, do we display each relation with 
different role or just limit the display to a specific role.

For my view, it's not a bug but an improvement, because technically all work, 
and functionally it's just a fog on the spotted purpose

> Humanres tree right-click pop-up menu allows existing OU to be added again
> --
>
> Key: OFBIZ-11683
> URL: https://issues.apache.org/jira/browse/OFBIZ-11683
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Pierre Smits
>Assignee: Sebastian Berg
>Priority: Major
>  Labels: usability
> Attachments: Screen Shot 2020-05-09 at 22.02.48.png, Screen Shot 
> 2020-05-09 at 22.03.09.png, Screen Shot 2020-05-09 at 22.03.25.png
>
>
> When on the main page, the user right-clicks on an organisation or 
> organisation unit (OU) to add an new subordinate organisation unit, an 
> existing OU can be added again.
> See attached images.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12328) Some online help links don't get where they should

2021-09-28 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-12328:

Summary: Some online help links don't get where they should  (was: Most 
online help links don't get where they should)

> Some online help links don't get where they should
> --
>
> Key: OFBIZ-12328
> URL: https://issues.apache.org/jira/browse/OFBIZ-12328
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> Here is a list where the results are wrong. It's only from applications main 
> pages.
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_content_management_overview
> https://demo-trunk.ofbiz.apache.org/ismgr/control/main
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_apache_ofbiz_plugins
> https://demo-trunk.ofbiz.apache.org/ar
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_accounting
> https://demo-trunk.ofbiz.apache.org/ap
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_accounting
> These should better go to 
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_accounting_glossary
> https://demo-trunk.ofbiz.apache.org/firstdata
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html
> https://demo-trunk.ofbiz.apache.org/webpos
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_apache_ofbiz_plugins
> https://demo-trunk.ofbiz.apache.org/bi
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_apache_ofbiz_plugins
> https://demo-trunk.ofbiz.apache.org/solr
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html
> https://demo-trunk.ofbiz.apache.org/ebay
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_ebay_appl_introduction
> It exists but you don't get there at 1st time, weird
> https://demo-trunk.ofbiz.apache.org/workeffort
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_core_business_applications
> Should not get there
> I tried from Catalog sub-pages. Only Image Management went where it's 
> expected. It's less important but still. Order seems better from this POV but 
> only when the help page is already opened. So a lot more to say but not much 
> time for that...



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12328) Most online help links don't get where they should

2021-09-28 Thread Olivier Heintz (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17421195#comment-17421195
 ] 

Olivier Heintz commented on OFBIZ-12328:


is it possible to give me a detail process example, because all seem works for 
me,
so, I'm clearly not understanding in which case link is not correct.

When I go to Accounting AR main page and I click to help, Help page is open on 
Accounting chapter, like it's parametrized in screen helpAnchor field = 
"_accounting"  (currently there is no accounting AR sub-chapter in help, so I 
have chosen  the main accounting help page).

 

> Most online help links don't get where they should
> --
>
> Key: OFBIZ-12328
> URL: https://issues.apache.org/jira/browse/OFBIZ-12328
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> Here is a list where the results are wrong. It's only from applications main 
> pages.
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_content_management_overview
> https://demo-trunk.ofbiz.apache.org/ismgr/control/main
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_apache_ofbiz_plugins
> https://demo-trunk.ofbiz.apache.org/ar
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_accounting
> https://demo-trunk.ofbiz.apache.org/ap
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_accounting
> These should better go to 
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_accounting_glossary
> https://demo-trunk.ofbiz.apache.org/firstdata
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html
> https://demo-trunk.ofbiz.apache.org/webpos
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_apache_ofbiz_plugins
> https://demo-trunk.ofbiz.apache.org/bi
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_apache_ofbiz_plugins
> https://demo-trunk.ofbiz.apache.org/solr
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html
> https://demo-trunk.ofbiz.apache.org/ebay
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_ebay_appl_introduction
> It exists but you don't get there at 1st time, weird
> https://demo-trunk.ofbiz.apache.org/workeffort
> https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_core_business_applications
> Should not get there
> I tried from Catalog sub-pages. Only Image Management went where it's 
> expected. It's less important but still. Order seems better from this POV but 
> only when the help page is already opened. So a lot more to say but not much 
> time for that...



--
This message was sent by Atlassian Jira
(v8.3.4#803005)