[jira] [Assigned] (OFBIZ-12407) Downloadable costing PDF

2021-12-06 Thread Priya Sharma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Priya Sharma reassigned OFBIZ-12407:


Assignee: Priya Sharma

> Downloadable costing PDF
> 
>
> Key: OFBIZ-12407
> URL: https://issues.apache.org/jira/browse/OFBIZ-12407
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product/catalog
>Affects Versions: Trunk
>Reporter: Aishwary Shrivastava
>Assignee: Priya Sharma
>Priority: Minor
>
> Costing is integral part for decision making.
> Many businesses will be benefited if they can generate a PDF for the costing 
> to make vital decisions and also to compare different costings.
> A support for downloadable PDF for costing can be a nice improvement



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #391: Improved: AccountingUiLabels clean-up (OFBIZ-9352)

2021-12-06 Thread GitBox


sonarcloud[bot] commented on pull request #391:
URL: https://github.com/apache/ofbiz-framework/pull/391#issuecomment-986894935


   Kudos, SonarCloud Quality Gate passed!    ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=391&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=391&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=391&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=391&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=391&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=391&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=391&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=391&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=391&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=391&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=391&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=391&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=391)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=391&metric=duplicated_lines_density&view=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-12384) User with only 'VIEW' permissions and invoice payments

2021-12-06 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454091#comment-17454091
 ] 

Pierre Smits commented on OFBIZ-12384:
--

Thanks to Jacques for his assistance to get this into the codebase

> User with only 'VIEW' permissions and invoice payments
> --
>
> Key: OFBIZ-12384
> URL: https://issues.apache.org/jira/browse/OFBIZ-12384
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: invoice, usability
>
> Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo 
> with userId = auditor, accessing the payments screen on an invoice sees 
> fields editable and triggers to requests reserved for users with 'CREATE' or 
> 'UPDATE' permissions.
> To see (test): 
> https://demo-trunk.ofbiz.apache.org/accounting/control/editInvoiceApplications?invoiceId=demo10001



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #390: Improved: VIEW permissions - Financial Account Overview (OFBIZ-12434)

2021-12-06 Thread GitBox


sonarcloud[bot] commented on pull request #390:
URL: https://github.com/apache/ofbiz-framework/pull/390#issuecomment-986893408


   Kudos, SonarCloud Quality Gate passed!    ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=390&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=390&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=390&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=390&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=390&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=390&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=390&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=390&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=390&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=390&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=390&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=390&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=390)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=390&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=390&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #391: Improved: AccountingUiLabels clean-up (OFBIZ-9352)

2021-12-06 Thread GitBox


PierreSmits opened a new pull request #391:
URL: https://github.com/apache/ofbiz-framework/pull/391


   Removing unused labels from AccountingUiLabels.xml
   
   Checked screens, forms, templates, scripts and java code


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #390: Improved: VIEW permissions - Financial Account Overview (OFBIZ-12434)

2021-12-06 Thread GitBox


PierreSmits opened a new pull request #390:
URL: https://github.com/apache/ofbiz-framework/pull/390


   Currently, a user with only 'VIEW' permissions, as demonstrated in trunk 
demo with userId = auditor, accessing the Financial Account overview screen, 
sees editable fields and/or triggers (to requests) reserved for users with 
'CREATE' or 'UPDATE' permissions.
   See (test with): 
https://demo-trunk.ofbiz.apache.org/accounting/control/EditFinAccount?finAccountId=ABN_CHECKING
   
   Modified:
   FinAccountScreens.xml - reworked EditFinAccount screen to work with 
permissions, additional clean up.
   FinAccountForms.xml - added form to be used for VIEW permission users


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-12384) User with only 'VIEW' permissions and invoice payments

2021-12-06 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454087#comment-17454087
 ] 

ASF subversion and git services commented on OFBIZ-12384:
-

Commit 878495aa2f286f4b7b281e496f70602ad9ded5f2 in ofbiz-framework's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=878495a ]

Improved: User with only 'VIEW' permissions and invoice payments (OFBIZ-12384) 
(#386)

Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo 
with userId = auditor, accessing the payments screen on an invoice sees fields 
editable and triggers to requests reserved for users with 'CREATE' or 'UPDATE' 
permissions.
To see (test): 
https://demo-trunk.ofbiz.apache.org/accounting/control/editInvoiceApplications?invoiceId=demo10001

Modifiied: InvoiceScreens.xml
restructured EditInvoiceApplications screen to work with user's permissions, 
additional clean-up

> User with only 'VIEW' permissions and invoice payments
> --
>
> Key: OFBIZ-12384
> URL: https://issues.apache.org/jira/browse/OFBIZ-12384
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: invoice, usability
>
> Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo 
> with userId = auditor, accessing the payments screen on an invoice sees 
> fields editable and triggers to requests reserved for users with 'CREATE' or 
> 'UPDATE' permissions.
> To see (test): 
> https://demo-trunk.ofbiz.apache.org/accounting/control/editInvoiceApplications?invoiceId=demo10001



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #386: Improved: User with only 'VIEW' permissions and invoice payments (OFBIZ-12384)

2021-12-06 Thread GitBox


JacquesLeRoux merged pull request #386:
URL: https://github.com/apache/ofbiz-framework/pull/386


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-12430) Add Invoice notes

2021-12-06 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454074#comment-17454074
 ] 

Jacques Le Roux commented on OFBIZ-12430:
-

Hi Nameet,

Yes sure, just provide a PR :)

> Add Invoice notes
> -
>
> Key: OFBIZ-12430
> URL: https://issues.apache.org/jira/browse/OFBIZ-12430
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Nameet Jain
>Assignee: sourabh jain
>Priority: Major
>
> OFBiz provides supporting data-model and CRUD services but missed the UI 
> support.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12430) Add Invoice notes

2021-12-06 Thread Nameet Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454019#comment-17454019
 ] 

Nameet Jain commented on OFBIZ-12430:
-

[~jleroux] that is something I was looking for.  

Currently, we allowed the viewing of Invoice notes. I believe we can have add 
and remove option also from the screen.  WDYT?

Thanks

> Add Invoice notes
> -
>
> Key: OFBIZ-12430
> URL: https://issues.apache.org/jira/browse/OFBIZ-12430
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Nameet Jain
>Assignee: sourabh jain
>Priority: Major
>
> OFBiz provides supporting data-model and CRUD services but missed the UI 
> support.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12434) VIEW permissions - Financial Account Overview

2021-12-06 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-12434:
-
Summary: VIEW permissions - Financial Account Overview  (was: VIEW 
permissions)

> VIEW permissions - Financial Account Overview
> -
>
> Key: OFBIZ-12434
> URL: https://issues.apache.org/jira/browse/OFBIZ-12434
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: financial_account, permissions, usability
>
> Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo 
> with userId = auditor, accessing the Financial Account overview screen, sees 
> editable fields and/or triggers (to requests) reserved for users with 
> 'CREATE' or 'UPDATE' permissions.
> See (test with): 
> https://demo-trunk.ofbiz.apache.org/accounting/control/EditFinAccount?finAccountId=ABN_CHECKING



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Created] (OFBIZ-12434) VIEW permissions

2021-12-06 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-12434:


 Summary: VIEW permissions
 Key: OFBIZ-12434
 URL: https://issues.apache.org/jira/browse/OFBIZ-12434
 Project: OFBiz
  Issue Type: Improvement
  Components: accounting
Affects Versions: Trunk
Reporter: Pierre Smits
Assignee: Pierre Smits


Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo 
with userId = auditor, accessing the Financial Account overview screen, sees 
editable fields and/or triggers (to requests) reserved for users with 'CREATE' 
or 'UPDATE' permissions.

See (test with): 
https://demo-trunk.ofbiz.apache.org/accounting/control/EditFinAccount?finAccountId=ABN_CHECKING



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [ofbiz-framework] PierreSmits commented on pull request #384: Improved: VIEW permissions Commission Run (OFBIZ-12433)

2021-12-06 Thread GitBox


PierreSmits commented on pull request #384:
URL: https://github.com/apache/ofbiz-framework/pull/384#issuecomment-986704914


   Then you can regard point 2 as a bonus. :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Closed] (OFBIZ-12433) VIEW permissions Commission Run

2021-12-06 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits closed OFBIZ-12433.

Fix Version/s: Upcoming Branch
   Resolution: Implemented

Thanks to Jacques for his assistance to get this into the codebase.

> VIEW permissions Commission Run
> ---
>
> Key: OFBIZ-12433
> URL: https://issues.apache.org/jira/browse/OFBIZ-12433
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: invoice, permssion, usability
> Fix For: Upcoming Branch
>
> Attachments: Screenshot 2021-12-04 at 14.58.23.png
>
>
> Currently, when using a userId with only VIEW permission, the Commission Run 
> trigger (menuItem) presents a screen to search and find invoices applicable 
> for the underlying service of creating commission invoices. 
> On the result shown, the user has access to triggers (functionalities) 
> reserved for users with CREATE/UPDATE permissions. 
> See (test with): 
> [https://demo-trunk.ofbiz.apache.org/accounting/control/CommissionRun] and 
> from date= 12/1/1999 12:00:00 AM



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12433) VIEW permissions Commission Run

2021-12-06 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453962#comment-17453962
 ] 

ASF subversion and git services commented on OFBIZ-12433:
-

Commit 033ab16de78f65c712baccae245861b4bcada2f9 in ofbiz-framework's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=033ab16 ]

Improved: VIEW permissions Commission Run (OFBIZ-12433) (#384)

* Improved: VIEW permissions Commission Run (OFBIZ-12433)

Currently, when using a userId with only VIEW permission, the Commission Run 
trigger (menuItem) presents a screen to search and find invoices applicable for 
the underlying service of creating commission invoices.
On the result shown, the user has access to triggers (functionalities) reserved 
for users with CREATE/UPDATE permissions.
See (test with): 
https://demo-trunk.ofbiz.apache.org/accounting/control/CommissionRun and from 
date= 12/1/1999 12:00:00 AM

Modified:
InvoiceScreens.xml (in AP) - screen CommissionRun
- restructured the screen to show result based on permissions
- added reference to template for users with VIEW permissions

Added:
CommissionRunSearchResult.ftl template for users with VIEW permissions

* Improved: VIEW permissions Commission Run (OFBIZ-12433)

Currently, when using a userId with only VIEW permission, the Commission Run 
trigger (menuItem) presents a screen to search and find invoices applicable for 
the underlying service of creating commission invoices.
On the result shown, the user has access to triggers (functionalities) reserved 
for users with CREATE/UPDATE permissions.
See (test with): 
https://demo-trunk.ofbiz.apache.org/accounting/control/CommissionRun and from 
date= 12/1/1999 12:00:00 AM

Modified:
InvoiceScreens.xml (in AP) - screen CommissionRun
- restructured the screen to show result based on permissions
- added reference to template for users with VIEW permissions

Added:
CommissionRunSearchResult.ftl template for users with VIEW permissions

> VIEW permissions Commission Run
> ---
>
> Key: OFBIZ-12433
> URL: https://issues.apache.org/jira/browse/OFBIZ-12433
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: invoice, permssion, usability
> Attachments: Screenshot 2021-12-04 at 14.58.23.png
>
>
> Currently, when using a userId with only VIEW permission, the Commission Run 
> trigger (menuItem) presents a screen to search and find invoices applicable 
> for the underlying service of creating commission invoices. 
> On the result shown, the user has access to triggers (functionalities) 
> reserved for users with CREATE/UPDATE permissions. 
> See (test with): 
> [https://demo-trunk.ofbiz.apache.org/accounting/control/CommissionRun] and 
> from date= 12/1/1999 12:00:00 AM



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #384: Improved: VIEW permissions Commission Run (OFBIZ-12433)

2021-12-06 Thread GitBox


JacquesLeRoux merged pull request #384:
URL: https://github.com/apache/ofbiz-framework/pull/384


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #384: Improved: VIEW permissions Commission Run (OFBIZ-12433)

2021-12-06 Thread GitBox


JacquesLeRoux commented on pull request #384:
URL: https://github.com/apache/ofbiz-framework/pull/384#issuecomment-986692762


   I was only interested in point 1, but thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-12351) Builds fail due to unauthorized access to repo.spring.io/plugins-release

2021-12-06 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453948#comment-17453948
 ] 

Jacques Le Roux commented on OFBIZ-12351:
-

Thanks Wiebke,

Much appreciated, works locally I restart the demos :)

> Builds fail due to unauthorized access to repo.spring.io/plugins-release
> 
>
> Key: OFBIZ-12351
> URL: https://issues.apache.org/jira/browse/OFBIZ-12351
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, 18.12.01
>Reporter: Mart Naum
>Assignee: Wiebke Pätzold
>Priority: Major
> Fix For: Upcoming Branch, 18.12.02
>
>
> I just flushed my gradle cache and observed that I am not able to build OFBiz 
> any longer due to unauthorized access to spring/plugins-release. The 
> repository seems to be required for com.springsource.com.sun.syndication, 
> maven lists . I reckon we are affected by the [repo.spring.io permission 
> changes|https://spring.io/blog/2020/10/29/notice-of-permissions-changes-to-repo-spring-io-fall-and-winter-2020].
>  
> {code:java}
> $ ./gradlew cleanAll loadAll> Configure project :
> You are using one or more deprecated Asciidoctor Gradle plugin features. To 
> help with migration run with --warning-mode=all.FAILURE: Build completed with 
> 2 failures.1: Task failed with an exception.
> ---
> * Where:
> Build file 'D:\Martin\git\ofbiz-framework-latest\build.gradle' line: 1117* 
> What went wrong:
> A problem occurred evaluating root project 'ofbiz'.
> > Could not resolve all files for configuration ':runtimeClasspath'.
>> Could not resolve 
> com.sun.syndication:com.springsource.com.sun.syndication:1.0.0.
>  Required by:
>  project :
>   > Could not resolve 
> com.sun.syndication:com.springsource.com.sun.syndication:1.0.0.
>  > Could not get resource 
> 'https://repo.spring.io/plugins-release/com/sun/syndication/com.springsource.com.sun.syndication/1.0.0/com.springsource.com.sun.syndication-1.0.0.pom'.
> > Could not GET 
> 'https://repo.spring.io/plugins-release/com/sun/syndication/com.springsource.com.sun.syndication/1.0.0/com.springsource.com.sun.syndication-1.0.0.pom'.
>  Received status code 401 from server: Unauthorized* Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output. Run with --scan to get full insights.
> ==2:
>  Task failed with an exception.
> ---
> * What went wrong:
> A problem occurred configuring root project 'ofbiz'.
> > No hooks found* Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output. Run with --scan to get full insights.
> ==*
>  Get more help at https://help.gradle.orgBUILD FAILED in 20s
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Comment Edited] (OFBIZ-12351) Builds fail due to unauthorized access to repo.spring.io/plugins-release

2021-12-06 Thread Jira


[ 
https://issues.apache.org/jira/browse/OFBIZ-12351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453937#comment-17453937
 ] 

Wiebke Pätzold edited comment on OFBIZ-12351 at 12/6/21, 10:51 AM:
---

I used the solution from trunk for release17.12 to create a permanent solution 
for the syndication replacement.

So we do not need to insert jcenter again.


was (Author: wpaetzold):
I used the solution from trunk for release17.12 to create a permanent solution 
for the syndication replacement.

> Builds fail due to unauthorized access to repo.spring.io/plugins-release
> 
>
> Key: OFBIZ-12351
> URL: https://issues.apache.org/jira/browse/OFBIZ-12351
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, 18.12.01
>Reporter: Mart Naum
>Assignee: Wiebke Pätzold
>Priority: Major
> Fix For: Upcoming Branch, 18.12.02
>
>
> I just flushed my gradle cache and observed that I am not able to build OFBiz 
> any longer due to unauthorized access to spring/plugins-release. The 
> repository seems to be required for com.springsource.com.sun.syndication, 
> maven lists . I reckon we are affected by the [repo.spring.io permission 
> changes|https://spring.io/blog/2020/10/29/notice-of-permissions-changes-to-repo-spring-io-fall-and-winter-2020].
>  
> {code:java}
> $ ./gradlew cleanAll loadAll> Configure project :
> You are using one or more deprecated Asciidoctor Gradle plugin features. To 
> help with migration run with --warning-mode=all.FAILURE: Build completed with 
> 2 failures.1: Task failed with an exception.
> ---
> * Where:
> Build file 'D:\Martin\git\ofbiz-framework-latest\build.gradle' line: 1117* 
> What went wrong:
> A problem occurred evaluating root project 'ofbiz'.
> > Could not resolve all files for configuration ':runtimeClasspath'.
>> Could not resolve 
> com.sun.syndication:com.springsource.com.sun.syndication:1.0.0.
>  Required by:
>  project :
>   > Could not resolve 
> com.sun.syndication:com.springsource.com.sun.syndication:1.0.0.
>  > Could not get resource 
> 'https://repo.spring.io/plugins-release/com/sun/syndication/com.springsource.com.sun.syndication/1.0.0/com.springsource.com.sun.syndication-1.0.0.pom'.
> > Could not GET 
> 'https://repo.spring.io/plugins-release/com/sun/syndication/com.springsource.com.sun.syndication/1.0.0/com.springsource.com.sun.syndication-1.0.0.pom'.
>  Received status code 401 from server: Unauthorized* Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output. Run with --scan to get full insights.
> ==2:
>  Task failed with an exception.
> ---
> * What went wrong:
> A problem occurred configuring root project 'ofbiz'.
> > No hooks found* Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output. Run with --scan to get full insights.
> ==*
>  Get more help at https://help.gradle.orgBUILD FAILED in 20s
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12351) Builds fail due to unauthorized access to repo.spring.io/plugins-release

2021-12-06 Thread Jira


[ 
https://issues.apache.org/jira/browse/OFBIZ-12351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453937#comment-17453937
 ] 

Wiebke Pätzold commented on OFBIZ-12351:


I used the solution from trunk for release17.12 to create a permanent solution 
for the syndication replacement.

> Builds fail due to unauthorized access to repo.spring.io/plugins-release
> 
>
> Key: OFBIZ-12351
> URL: https://issues.apache.org/jira/browse/OFBIZ-12351
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, 18.12.01
>Reporter: Mart Naum
>Assignee: Wiebke Pätzold
>Priority: Major
> Fix For: Upcoming Branch, 18.12.02
>
>
> I just flushed my gradle cache and observed that I am not able to build OFBiz 
> any longer due to unauthorized access to spring/plugins-release. The 
> repository seems to be required for com.springsource.com.sun.syndication, 
> maven lists . I reckon we are affected by the [repo.spring.io permission 
> changes|https://spring.io/blog/2020/10/29/notice-of-permissions-changes-to-repo-spring-io-fall-and-winter-2020].
>  
> {code:java}
> $ ./gradlew cleanAll loadAll> Configure project :
> You are using one or more deprecated Asciidoctor Gradle plugin features. To 
> help with migration run with --warning-mode=all.FAILURE: Build completed with 
> 2 failures.1: Task failed with an exception.
> ---
> * Where:
> Build file 'D:\Martin\git\ofbiz-framework-latest\build.gradle' line: 1117* 
> What went wrong:
> A problem occurred evaluating root project 'ofbiz'.
> > Could not resolve all files for configuration ':runtimeClasspath'.
>> Could not resolve 
> com.sun.syndication:com.springsource.com.sun.syndication:1.0.0.
>  Required by:
>  project :
>   > Could not resolve 
> com.sun.syndication:com.springsource.com.sun.syndication:1.0.0.
>  > Could not get resource 
> 'https://repo.spring.io/plugins-release/com/sun/syndication/com.springsource.com.sun.syndication/1.0.0/com.springsource.com.sun.syndication-1.0.0.pom'.
> > Could not GET 
> 'https://repo.spring.io/plugins-release/com/sun/syndication/com.springsource.com.sun.syndication/1.0.0/com.springsource.com.sun.syndication-1.0.0.pom'.
>  Received status code 401 from server: Unauthorized* Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output. Run with --scan to get full insights.
> ==2:
>  Task failed with an exception.
> ---
> * What went wrong:
> A problem occurred configuring root project 'ofbiz'.
> > No hooks found* Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output. Run with --scan to get full insights.
> ==*
>  Get more help at https://help.gradle.orgBUILD FAILED in 20s
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #389: Fixed: Builds fail due to unauthorized access to repo.spring.io/plugins-release (OFBIZ-12351)

2021-12-06 Thread GitBox


sonarcloud[bot] commented on pull request #389:
URL: https://github.com/apache/ofbiz-framework/pull/389#issuecomment-986656772


   Kudos, SonarCloud Quality Gate passed!    ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=389&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=389&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=389&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=389&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=389&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=389&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=389&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=389&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=389&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=389&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=389&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=389&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=389)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=389&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=389&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-10093) Replace ELRTE plugin with Quill.

2021-12-06 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453935#comment-17453935
 ] 

Jacques Le Roux commented on OFBIZ-10093:
-

Hi Benjami,

That sounds quite promising, a PR yes!

> Replace ELRTE plugin with Quill.
> 
>
> Key: OFBIZ-10093
> URL: https://issues.apache.org/jira/browse/OFBIZ-10093
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Benjamin Jugl
>Priority: Major
>
> As there is no support for elrte since elrte-1.3 
> [https://github.com/Studio-42/elRTE] it is to be replaced with some other 
> good editor & we found Quill Js editor as quite suitable:
>  * 139 releases
>  * Good community support of 101 contributors
>  * Licence - BSD 3-Clause "New" or "Revised" License
> Links for reference:
>  [https://quilljs.com/]
> [https://github.com/quilljs/quill]
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12351) Builds fail due to unauthorized access to repo.spring.io/plugins-release

2021-12-06 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453934#comment-17453934
 ] 

ASF subversion and git services commented on OFBIZ-12351:
-

Commit c5d262aeab8af408be8c25649524f7a3e8d63d5c in ofbiz-framework's branch 
refs/heads/release17.12 from Wiebke Pätzold
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=c5d262a ]

Fixed: Builds fail due to unauthorized access to
repo.spring.io/plugins-release (OFBIZ-12351)

Replaces repository syndication by rometools

> Builds fail due to unauthorized access to repo.spring.io/plugins-release
> 
>
> Key: OFBIZ-12351
> URL: https://issues.apache.org/jira/browse/OFBIZ-12351
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, 18.12.01
>Reporter: Mart Naum
>Assignee: Wiebke Pätzold
>Priority: Major
> Fix For: Upcoming Branch, 18.12.02
>
>
> I just flushed my gradle cache and observed that I am not able to build OFBiz 
> any longer due to unauthorized access to spring/plugins-release. The 
> repository seems to be required for com.springsource.com.sun.syndication, 
> maven lists . I reckon we are affected by the [repo.spring.io permission 
> changes|https://spring.io/blog/2020/10/29/notice-of-permissions-changes-to-repo-spring-io-fall-and-winter-2020].
>  
> {code:java}
> $ ./gradlew cleanAll loadAll> Configure project :
> You are using one or more deprecated Asciidoctor Gradle plugin features. To 
> help with migration run with --warning-mode=all.FAILURE: Build completed with 
> 2 failures.1: Task failed with an exception.
> ---
> * Where:
> Build file 'D:\Martin\git\ofbiz-framework-latest\build.gradle' line: 1117* 
> What went wrong:
> A problem occurred evaluating root project 'ofbiz'.
> > Could not resolve all files for configuration ':runtimeClasspath'.
>> Could not resolve 
> com.sun.syndication:com.springsource.com.sun.syndication:1.0.0.
>  Required by:
>  project :
>   > Could not resolve 
> com.sun.syndication:com.springsource.com.sun.syndication:1.0.0.
>  > Could not get resource 
> 'https://repo.spring.io/plugins-release/com/sun/syndication/com.springsource.com.sun.syndication/1.0.0/com.springsource.com.sun.syndication-1.0.0.pom'.
> > Could not GET 
> 'https://repo.spring.io/plugins-release/com/sun/syndication/com.springsource.com.sun.syndication/1.0.0/com.springsource.com.sun.syndication-1.0.0.pom'.
>  Received status code 401 from server: Unauthorized* Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output. Run with --scan to get full insights.
> ==2:
>  Task failed with an exception.
> ---
> * What went wrong:
> A problem occurred configuring root project 'ofbiz'.
> > No hooks found* Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output. Run with --scan to get full insights.
> ==*
>  Get more help at https://help.gradle.orgBUILD FAILED in 20s
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [ofbiz-framework] wpaetzold merged pull request #389: Fixed: Builds fail due to unauthorized access to repo.spring.io/plugins-release (OFBIZ-12351)

2021-12-06 Thread GitBox


wpaetzold merged pull request #389:
URL: https://github.com/apache/ofbiz-framework/pull/389


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] wpaetzold opened a new pull request #389: Fixed: Builds fail due to unauthorized access to repo.spring.io/plugins-release (OFBIZ-12351)

2021-12-06 Thread GitBox


wpaetzold opened a new pull request #389:
URL: https://github.com/apache/ofbiz-framework/pull/389


   Replaces repository syndication by rometools
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-10093) Replace ELRTE plugin with Quill.

2021-12-06 Thread Benjamin Jugl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453903#comment-17453903
 ] 

Benjamin Jugl commented on OFBIZ-10093:
---

Hi there. We discovered another alternative and had so far very good 
experiences with it: [Trubowyg|https://alex-d.github.io/Trumbowyg/]

It has all the features of summernote and additionally is highly customizable 
with plugins.

I can provide a PR, if you want.

> Replace ELRTE plugin with Quill.
> 
>
> Key: OFBIZ-10093
> URL: https://issues.apache.org/jira/browse/OFBIZ-10093
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Benjamin Jugl
>Priority: Major
>
> As there is no support for elrte since elrte-1.3 
> [https://github.com/Studio-42/elRTE] it is to be replaced with some other 
> good editor & we found Quill Js editor as quite suitable:
>  * 139 releases
>  * Good community support of 101 contributors
>  * Licence - BSD 3-Clause "New" or "Revised" License
> Links for reference:
>  [https://quilljs.com/]
> [https://github.com/quilljs/quill]
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #388: Improved: VIEW permissions and Payment Applications (OFBIZ-12427)

2021-12-06 Thread GitBox


sonarcloud[bot] commented on pull request #388:
URL: https://github.com/apache/ofbiz-framework/pull/388#issuecomment-986581247


   Kudos, SonarCloud Quality Gate passed!    ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=388&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=388&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=388&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=388&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=388&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=388&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=388&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=388&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=388&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=388&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=388&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=388&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=388)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=388&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=388&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #388: Improved: VIEW permissions and Payment Applications (OFBIZ-12427)

2021-12-06 Thread GitBox


PierreSmits opened a new pull request #388:
URL: https://github.com/apache/ofbiz-framework/pull/388


   Currently, a user with only 'VIEW' permissions, as demonstrated in trunk 
demo with userId = auditor, accessing the Payment Applications screen on a 
payment, sees editable fields and/or triggers (to requests) reserved for users 
with 'CREATE' or 'UPDATE' permissions.
   This can be observed/tested via:
   
https://demo-trunk.ofbiz.apache.org/accounting/control/editPaymentApplications?paymentId=8004
   
https://demo-trunk.ofbiz.apache.org/accounting/control/editPaymentApplications?paymentId=8003
   etc.
   
   modified: PaymentScreens.xml
   restructured screen EditPaymentApplications in order to work for users with 
VIEW and/or CREATE/UPDATE
   permissions, additional cleanup


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-12351) Builds fail due to unauthorized access to repo.spring.io/plugins-release

2021-12-06 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453861#comment-17453861
 ] 

ASF subversion and git services commented on OFBIZ-12351:
-

Commit 208d44e0a30df1e12e59702cb1c04423a41967a5 in ofbiz-framework's branch 
refs/heads/release17.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=208d44e ]

Fixed: Builds fail due to unauthorized access to repo.spring.io/plugins-release 
(OFBIZ-12351)

The old demo crashed. I guess this should be OK, let's try...


> Builds fail due to unauthorized access to repo.spring.io/plugins-release
> 
>
> Key: OFBIZ-12351
> URL: https://issues.apache.org/jira/browse/OFBIZ-12351
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, 18.12.01
>Reporter: Mart Naum
>Assignee: Wiebke Pätzold
>Priority: Major
> Fix For: Upcoming Branch, 18.12.02
>
>
> I just flushed my gradle cache and observed that I am not able to build OFBiz 
> any longer due to unauthorized access to spring/plugins-release. The 
> repository seems to be required for com.springsource.com.sun.syndication, 
> maven lists . I reckon we are affected by the [repo.spring.io permission 
> changes|https://spring.io/blog/2020/10/29/notice-of-permissions-changes-to-repo-spring-io-fall-and-winter-2020].
>  
> {code:java}
> $ ./gradlew cleanAll loadAll> Configure project :
> You are using one or more deprecated Asciidoctor Gradle plugin features. To 
> help with migration run with --warning-mode=all.FAILURE: Build completed with 
> 2 failures.1: Task failed with an exception.
> ---
> * Where:
> Build file 'D:\Martin\git\ofbiz-framework-latest\build.gradle' line: 1117* 
> What went wrong:
> A problem occurred evaluating root project 'ofbiz'.
> > Could not resolve all files for configuration ':runtimeClasspath'.
>> Could not resolve 
> com.sun.syndication:com.springsource.com.sun.syndication:1.0.0.
>  Required by:
>  project :
>   > Could not resolve 
> com.sun.syndication:com.springsource.com.sun.syndication:1.0.0.
>  > Could not get resource 
> 'https://repo.spring.io/plugins-release/com/sun/syndication/com.springsource.com.sun.syndication/1.0.0/com.springsource.com.sun.syndication-1.0.0.pom'.
> > Could not GET 
> 'https://repo.spring.io/plugins-release/com/sun/syndication/com.springsource.com.sun.syndication/1.0.0/com.springsource.com.sun.syndication-1.0.0.pom'.
>  Received status code 401 from server: Unauthorized* Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output. Run with --scan to get full insights.
> ==2:
>  Task failed with an exception.
> ---
> * What went wrong:
> A problem occurred configuring root project 'ofbiz'.
> > No hooks found* Try:
> Run with --stacktrace option to get the stack trace. Run with --info or 
> --debug option to get more log output. Run with --scan to get full insights.
> ==*
>  Get more help at https://help.gradle.orgBUILD FAILED in 20s
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #387: Improved: Remove Whitespaces before checkboxes (OFBIZ-10461)

2021-12-06 Thread GitBox


sonarcloud[bot] commented on pull request #387:
URL: https://github.com/apache/ofbiz-framework/pull/387#issuecomment-986559425


   Kudos, SonarCloud Quality Gate passed!    ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=387&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=387&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=387&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=387&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=387&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=387&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=387&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=387&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=387&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=387&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=387&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=387&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=387)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=387&metric=duplicated_lines_density&view=list)
 No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] bjugl opened a new pull request #387: Improved: Remove Whitespaces before checkboxes (OFBIZ-10461)

2021-12-06 Thread GitBox


bjugl opened a new pull request #387:
URL: https://github.com/apache/ofbiz-framework/pull/387


   Improved: Remove Whitespaces before checkboxes
   
   (OFBIZ-10461)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-12386) Fix some bugs Spotbugs reports

2021-12-06 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453851#comment-17453851
 ] 

ASF subversion and git services commented on OFBIZ-12386:
-

Commit b02255ae5fa54b27368b90be46853ae276c43a28 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b02255a ]

Improved:  Fix some bugs Spotbugs reports (OFBIZ-12386)

No functional change: removes unused MODULE in ReferenceCleaner class


> Fix some bugs Spotbugs reports
> --
>
> Key: OFBIZ-12386
> URL: https://issues.apache.org/jira/browse/OFBIZ-12386
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12386) Fix some bugs Spotbugs reports

2021-12-06 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453852#comment-17453852
 ] 

ASF subversion and git services commented on OFBIZ-12386:
-

Commit d6c18f2998e8b0cc3af398ae19ee2e05f83215d8 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=d6c18f2 ]

Improved:  Fix some bugs Spotbugs reports (OFBIZ-12386)

ModelFormField::isAllChecked can't return null, must be a boolean


> Fix some bugs Spotbugs reports
> --
>
> Key: OFBIZ-12386
> URL: https://issues.apache.org/jira/browse/OFBIZ-12386
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12386) Fix some bugs Spotbugs reports

2021-12-06 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453850#comment-17453850
 ] 

ASF subversion and git services commented on OFBIZ-12386:
-

Commit ca03e21ae8e61e2408eb4e1497e99336d7741163 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=ca03e21 ]

Improved:  Fix some bugs Spotbugs reports (OFBIZ-12386)

Rearranges order of modifiers after transient insertion, in classes
ProductConfigWrapper, ModelEntity, ModelViewEntity and ModelService


> Fix some bugs Spotbugs reports
> --
>
> Key: OFBIZ-12386
> URL: https://issues.apache.org/jira/browse/OFBIZ-12386
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12386) Fix some bugs Spotbugs reports

2021-12-06 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453846#comment-17453846
 ] 

ASF subversion and git services commented on OFBIZ-12386:
-

Commit 1ecf6d3929f775516ea3b804e90c5554aaffe8d4 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=1ecf6d3 ]

Improved:  Fix some bugs Spotbugs reports (OFBIZ-12386)

Adds @SuppressWarnings("serial") to AbstractJob and removes unused MODULE var
from PurgeJob


> Fix some bugs Spotbugs reports
> --
>
> Key: OFBIZ-12386
> URL: https://issues.apache.org/jira/browse/OFBIZ-12386
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12386) Fix some bugs Spotbugs reports

2021-12-06 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453844#comment-17453844
 ] 

ASF subversion and git services commented on OFBIZ-12386:
-

Commit d4306b9f59296c13d73683d1cee1647427a512fd in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=d4306b9 ]

Improved:  Fix some bugs Spotbugs reports (OFBIZ-12386)

ComparableRange is a super class of DateRange that is Serializable. So
ComparableRange needs to be Serializable Too. Same with AbstractJob for PurgeJob
and GenericServiceJob


> Fix some bugs Spotbugs reports
> --
>
> Key: OFBIZ-12386
> URL: https://issues.apache.org/jira/browse/OFBIZ-12386
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12386) Fix some bugs Spotbugs reports

2021-12-06 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453839#comment-17453839
 ] 

ASF subversion and git services commented on OFBIZ-12386:
-

Commit ed6241cb5234173a86db69a8ea8b9e2e0b77f7a6 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=ed6241c ]

Improved:  Fix some bugs Spotbugs reports (OFBIZ-12386)

transient is needed for not serialisable fields of a Serializable class


> Fix some bugs Spotbugs reports
> --
>
> Key: OFBIZ-12386
> URL: https://issues.apache.org/jira/browse/OFBIZ-12386
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)