[jira] [Commented] (OFBIZ-6002) Have the RoleType field in AddInvoiceRole only show the roles of the selected party
[ https://issues.apache.org/jira/browse/OFBIZ-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17457426#comment-17457426 ] mandy boyd commented on OFBIZ-6002: --- > Have the RoleType field in AddInvoiceRole only show the roles of the selected > party > --- > > Key: OFBIZ-6002 > URL: https://issues.apache.org/jira/browse/OFBIZ-6002 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: invoice, roles > > Currently, and regardless of the party selected, the roletype fields show all > possible roletypes. This field should only show the roles of the party > selected, and it should only show the roles available at the moment of > creation of the invoice role (life-span, filter-by-date). -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-12386) Fix some bugs Spotbugs reports
[ https://issues.apache.org/jira/browse/OFBIZ-12386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17457202#comment-17457202 ] ASF subversion and git services commented on OFBIZ-12386: - Commit 8b9fc99d7df10246c95d2280376441d085e72f3f in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=8b9fc99 ] Improved: Fix some bugs Spotbugs reports (OFBIZ-12386) In ProductWorker::getProductFeaturesApplIncludeMarketingPackage fixes a possible null dereferencement (tested too late) In FileUtil::unZip uses a try-w-resource w/ ZipFile to close it. I crossed an issue with automated OOTB formatting (clean-up on save in Eclipse). Fixed with my external default editor (could not find where to change that in OFBizJavaFormatter.xml In ServiceArtifactInfo::calledServiceEcaSet fixes a possible null dereferencement (tested too late), also minor formatting In MacroScreenRenderer::renderScreenletSubWidget fixes a possible null dereferencement (tested too late) in FileUtil > Fix some bugs Spotbugs reports > -- > > Key: OFBIZ-12386 > URL: https://issues.apache.org/jira/browse/OFBIZ-12386 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [ofbiz-framework] PierreSmits commented on pull request #182: Improvement: Have a Menu in Manufacturing featuring actions to create the main objects (OFBIZ-11782)
PierreSmits commented on pull request #182: URL: https://github.com/apache/ofbiz-framework/pull/182#issuecomment-990893710 Closing due to going stale. Superseded by PR 406 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] PierreSmits closed pull request #182: Improvement: Have a Menu in Manufacturing featuring actions to create the main objects (OFBIZ-11782)
PierreSmits closed pull request #182: URL: https://github.com/apache/ofbiz-framework/pull/182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #406: Improved: Have a Menu in Manufacturing featuring actions to create the main objects (OFBIZ-11782)
sonarcloud[bot] commented on pull request #406: URL: https://github.com/apache/ofbiz-framework/pull/406#issuecomment-990892664 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=406&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=406&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=406&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=406&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=406&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=406&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=406&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=406&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=406&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=406&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=406&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=406&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=406) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=406&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=406&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #406: Improved: Have a Menu in Manufacturing featuring actions to create th…
PierreSmits opened a new pull request #406: URL: https://github.com/apache/ofbiz-framework/pull/406 …e main objects (OFBIZ-11782) Currently the create buttons for the main objects of the manufacturing application are located within find and profile widgets/templates of those objects. In order to improve the usability of this application, OFBiz and thus the appeal of it for adopters and users, these create buttons/links/etc. should be in a main action menu visible at all times when a user is working within the appliclation of the component. modified: ManufacturingMenus.xml - added MainActionMenu CommonScreens.xlm - added pre-body decorator-section with MainActionMenu ref. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12386) Fix some bugs Spotbugs reports
[ https://issues.apache.org/jira/browse/OFBIZ-12386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17457061#comment-17457061 ] ASF subversion and git services commented on OFBIZ-12386: - Commit cba9471cb03024e6ab8cc35801f79f186be0efc9 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=cba9471 ] Improved: Fix some bugs Spotbugs reports (OFBIZ-12386) Despite by best efforts in SecuredUpload::isValidFile and PricatParseExcelHtmlThread::storePricatFile SpotBugs still reports possible null dereferencements. The error is NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE. It's false reports to me. Hence excluding them in these places > Fix some bugs Spotbugs reports > -- > > Key: OFBIZ-12386 > URL: https://issues.apache.org/jira/browse/OFBIZ-12386 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #405: Improved: List and Grid (OFBIZ-11345)
sonarcloud[bot] commented on pull request #405: URL: https://github.com/apache/ofbiz-framework/pull/405#issuecomment-990832606 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=405&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=405&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=405&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=405&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=405&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=405&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=405&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=405&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=405&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=405&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=405&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=405&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=405) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=405&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=405&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #405: Improved: List and Grid (OFBIZ-11345)
PierreSmits opened a new pull request #405: URL: https://github.com/apache/ofbiz-framework/pull/405 According to the definition in widget-form.xsd the use of a combination of a form with type="list" is deprecated in favour of a grid. Refactor various list forms into grids. Refactor various list form references in screens. Modified: PromoScreens.xml: from form ref to grid ref , additional cleanup PromoForms.xml: from form definition with list ref to grid definition with list ref, additional clean-up -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-11345) Lists and grids
[ https://issues.apache.org/jira/browse/OFBIZ-11345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17457027#comment-17457027 ] Pierre Smits commented on OFBIZ-11345: -- Thanks to Jacques for his assistance to get this into the codebase. > Lists and grids > --- > > Key: OFBIZ-11345 > URL: https://issues.apache.org/jira/browse/OFBIZ-11345 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: cleanup, refactoring, widget > Fix For: Upcoming Branch > > > According to the definition in widget-form.xsd the use of a combination of a > form with type="list" is deprecated in favour of a grid. > Refactor various list forms into grids. > Refactor various list form references in screens. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Comment Edited] (OFBIZ-12442) VIEW permissions show ManufacturingAppBar items
[ https://issues.apache.org/jira/browse/OFBIZ-12442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456998#comment-17456998 ] Jacques Le Roux edited comment on OFBIZ-12442 at 12/10/21, 10:14 AM: - Commit 4494d071fa55d2433827bf20dc739739d428cb94 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=4494d07 ] Improved: VIEW permissions show ManufacturingTabBar items (OFBIZ-12442) PR399 missed GlTransaction This was actually related to https://github.com/apache/ofbiz-framework/pull/403 and OFBIZ-11780 was (Author: jira-bot): Commit 4494d071fa55d2433827bf20dc739739d428cb94 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=4494d07 ] Improved: VIEW permissions show ManufacturingTabBar items (OFBIZ-12442) PR399 missed GlTransaction > VIEW permissions show ManufacturingAppBar items > --- > > Key: OFBIZ-12442 > URL: https://issues.apache.org/jira/browse/OFBIZ-12442 > Project: OFBiz > Issue Type: Improvement > Components: manufacturing >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: manufacturing, menu-item, permissions, usability > Fix For: Upcoming Branch > > > Currently, when a user with only VIEW permissions accesses the manufacturing > component menu-items of the ManufacturingAppBar are not shown due to too > restrictive conditions. > These menu-items allow users to access various overviews related to > manufacturing, like > * production runs, > * routings (production schemas), > * routing task (schema tasks), > * production calendar, > * etc. > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-11345) Lists and grids
[ https://issues.apache.org/jira/browse/OFBIZ-11345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17457021#comment-17457021 ] ASF subversion and git services commented on OFBIZ-11345: - Commit 0babdf468fc3920c75d97c2912a93009a2528637 in ofbiz-framework's branch refs/heads/trunk from Pierre Smits [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=0babdf4 ] Improved: List and Grid (OFBIZ-11345) (#397) * Improved: List and Grid (OFBIZ-11345) According to the definition in widget-form.xsd the use of a combination of a form with type="list" is deprecated in favour of a grid. Refactor various list forms into grids. Refactor various list form references in screens. Modified: InvoiceScreens.xml: from form ref to grid ref , additional cleanup InvoiceForms.xml: from form definition with list ref to grid definition with list ref, additional clean-up * Improved: List and Grid (OFBIZ-11345) Modified: InvoiceScreens.xml: missed ref to ListInvoicePaymentInfo in InvoiceScreens.xml > Lists and grids > --- > > Key: OFBIZ-11345 > URL: https://issues.apache.org/jira/browse/OFBIZ-11345 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: cleanup, refactoring, widget > Fix For: Upcoming Branch > > > According to the definition in widget-form.xsd the use of a combination of a > form with type="list" is deprecated in favour of a grid. > Refactor various list forms into grids. > Refactor various list form references in screens. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #397: Improved: List and Grid (OFBIZ-11345)
JacquesLeRoux merged pull request #397: URL: https://github.com/apache/ofbiz-framework/pull/397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (OFBIZ-12448) VIEW permissions Budget Attributes
Pierre Smits created OFBIZ-12448: Summary: VIEW permissions Budget Attributes Key: OFBIZ-12448 URL: https://issues.apache.org/jira/browse/OFBIZ-12448 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: Trunk Reporter: Pierre Smits Assignee: Pierre Smits Though there is an entity BudgetAttribute this cannot be accessed by user with VIEW permissions when accessing a Budget. See: * for entity data: https://demo-trunk.ofbiz.apache.org/webtools/control/entity/find/BudgetAttribute * test budget: https://demo-trunk.ofbiz.apache.org/accounting/control/EditBudget?budgetId=DemoBudget001 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-12386) Fix some bugs Spotbugs reports
[ https://issues.apache.org/jira/browse/OFBIZ-12386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17457000#comment-17457000 ] ASF subversion and git services commented on OFBIZ-12386: - Commit 576d5534a288b77d130eac2ba95862b112ac836c in ofbiz-plugins's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=576d553 ] Improved: Fix some bugs Spotbugs reports (OFBIZ-12386) In AbstractPricatParser::writeCommentsToFile fixes a possible null dereferencement Fixes 2 JavaDoc issues > Fix some bugs Spotbugs reports > -- > > Key: OFBIZ-12386 > URL: https://issues.apache.org/jira/browse/OFBIZ-12386 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-12442) VIEW permissions show ManufacturingAppBar items
[ https://issues.apache.org/jira/browse/OFBIZ-12442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456998#comment-17456998 ] ASF subversion and git services commented on OFBIZ-12442: - Commit 4494d071fa55d2433827bf20dc739739d428cb94 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=4494d07 ] Improved: VIEW permissions show ManufacturingTabBar items (OFBIZ-12442) PR399 missed GlTransaction > VIEW permissions show ManufacturingAppBar items > --- > > Key: OFBIZ-12442 > URL: https://issues.apache.org/jira/browse/OFBIZ-12442 > Project: OFBiz > Issue Type: Improvement > Components: manufacturing >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: manufacturing, menu-item, permissions, usability > Fix For: Upcoming Branch > > > Currently, when a user with only VIEW permissions accesses the manufacturing > component menu-items of the ManufacturingAppBar are not shown due to too > restrictive conditions. > These menu-items allow users to access various overviews related to > manufacturing, like > * production runs, > * routings (production schemas), > * routing task (schema tasks), > * production calendar, > * etc. > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #404: Improved: Accounting remove create trigger for objects (OFBIZ-12447)
sonarcloud[bot] commented on pull request #404: URL: https://github.com/apache/ofbiz-framework/pull/404#issuecomment-990762392 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=404&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=404&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=404&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=404&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=404&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=404&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=404&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=404&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=404&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=404&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=404&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=404&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=404) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=404&metric=duplicated_lines_density&view=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] PierreSmits commented on pull request #397: Improved: List and Grid (OFBIZ-11345)
PierreSmits commented on pull request #397: URL: https://github.com/apache/ofbiz-framework/pull/397#issuecomment-990762065 Hi Jacques, Thanks for the feedback. I'll look into it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #404: Improved: Accounting remove create trigger for objects (OFBIZ-12447)
PierreSmits opened a new pull request #404: URL: https://github.com/apache/ofbiz-framework/pull/404 With the implementation of the Accounting MainActionMenu, various menu-items and/or other triggers to create an object are now obsolete modified: AccountingMenus.xml - removed 'create' menu-items for invoice and payment GlScreens.xml - removed trigger for a new gl transaction -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (OFBIZ-12447) Accounting remove create trigger for Invoice
Pierre Smits created OFBIZ-12447: Summary: Accounting remove create trigger for Invoice Key: OFBIZ-12447 URL: https://issues.apache.org/jira/browse/OFBIZ-12447 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: Trunk Reporter: Pierre Smits Assignee: Pierre Smits With the implementation of the Accounting MainActionMenu, various menu-items and/or other triggers to create an object are now obsolete -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (OFBIZ-12447) Accounting remove create trigger for objects
[ https://issues.apache.org/jira/browse/OFBIZ-12447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-12447: - Summary: Accounting remove create trigger for objects (was: Accounting remove create trigger for Invoice) > Accounting remove create trigger for objects > > > Key: OFBIZ-12447 > URL: https://issues.apache.org/jira/browse/OFBIZ-12447 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: usability > > With the implementation of the Accounting MainActionMenu, various menu-items > and/or other triggers to create an object are now obsolete -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (OFBIZ-11780) Have a Menu in Accounting featuring actions to create the main objects
[ https://issues.apache.org/jira/browse/OFBIZ-11780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits closed OFBIZ-11780. Fix Version/s: Upcoming Branch Resolution: Implemented Thanks to Jacques for his feedback and assistance to get this into the codebase. > Have a Menu in Accounting featuring actions to create the main objects > -- > > Key: OFBIZ-11780 > URL: https://issues.apache.org/jira/browse/OFBIZ-11780 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: menus, refactoring, usability > Fix For: Upcoming Branch > > > Currently the create buttons for the main objects of the accounting > application are located within find and profile widgets/templates of those > objects. > In order to improve the usability of this application, OFBiz and thus the > appeal of it for adopters and users, these create buttons/links/etc. should > be in a main action menu visible at all times when a user (with the CREATE > permission) is working within the application of the component. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-12386) Fix some bugs Spotbugs reports
[ https://issues.apache.org/jira/browse/OFBIZ-12386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456977#comment-17456977 ] ASF subversion and git services commented on OFBIZ-12386: - Commit 69cff24c829ca8a45b41b66f39c37aa949e96f73 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=69cff24 ] Improved: Fix some bugs Spotbugs reports (OFBIZ-12386) In WebToolsServices::entityImportDir fixes a possible null dereferencement Missed in previous commit, not sure why > Fix some bugs Spotbugs reports > -- > > Key: OFBIZ-12386 > URL: https://issues.apache.org/jira/browse/OFBIZ-12386 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-11780) Have a Menu in Accounting featuring actions to create the main objects
[ https://issues.apache.org/jira/browse/OFBIZ-11780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456972#comment-17456972 ] ASF subversion and git services commented on OFBIZ-11780: - Commit e736a5fc7075312fcd5bfdb65f3c1d57d47b3a80 in ofbiz-framework's branch refs/heads/trunk from Pierre Smits [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=e736a5f ] Improved: Have a Menu in Accounting featuring actions to create the main objects (OFBIZ-11780) (#403) Currently the create buttons for the main objects of the accounting application are located within find and profile widgets/templates of those objects. In order to improve the usability of this application, OFBiz and thus the appeal of it for adopters and users, these create buttons/links/etc. should be in a main action menu visible at all times when a user (with the CREATE permission) is working within the application of the component. Modified: - AccountingMenus.xml: added MainActionMenu for users with CREATE permission - AgreementScreens.xml: added ref to MainActionMenu in CommonAgreementDecorator - BillingAccountScreens.xml: added ref to MainActionMenu in CommonBillingAccountDecorator - BudgetScreens.xml: added ref to MainActionMenu in various appropriate screens - CommonScreens.xml: added ref to MainActionMenu in various appropriate screens - FinAccountScreens.xml: added ref to MainActionMenu in CommonFinAccountDecorator - FixedAssetScreens.xml: added ref to MainActionMenu in various appropriate screens - InvoiceScreens.xml: added ref to MainActionMenu in CommonInvoiceDecorator - PaymentGatewayConfigScreens.xml: added ref to MainActionMenu in GenericPaymentGatewayConfigDecorator - PaymentGroupScreens.xml: added ref to MainActionMenu in FindPaymentGroup - PaymentScreens.xml: added ref to MainActionMenu in CommonPaymentDecorator - TaxAuthorityScreens.xml: added ref to MainActionMenu in CommonTaxAuthorityDecorator - TransactionScreens.xml: added ref to MainActionMenu in GenericTransactionDecorator > Have a Menu in Accounting featuring actions to create the main objects > -- > > Key: OFBIZ-11780 > URL: https://issues.apache.org/jira/browse/OFBIZ-11780 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: menus, refactoring, usability > > Currently the create buttons for the main objects of the accounting > application are located within find and profile widgets/templates of those > objects. > In order to improve the usability of this application, OFBiz and thus the > appeal of it for adopters and users, these create buttons/links/etc. should > be in a main action menu visible at all times when a user (with the CREATE > permission) is working within the application of the component. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (OFBIZ-12442) VIEW permissions show ManufacturingAppBar items
[ https://issues.apache.org/jira/browse/OFBIZ-12442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits closed OFBIZ-12442. Fix Version/s: Upcoming Branch Resolution: Implemented Thanks to Jacques for his assistance to get this into the codebase. > VIEW permissions show ManufacturingAppBar items > --- > > Key: OFBIZ-12442 > URL: https://issues.apache.org/jira/browse/OFBIZ-12442 > Project: OFBiz > Issue Type: Improvement > Components: manufacturing >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: manufacturing, menu-item, permissions, usability > Fix For: Upcoming Branch > > > Currently, when a user with only VIEW permissions accesses the manufacturing > component menu-items of the ManufacturingAppBar are not shown due to too > restrictive conditions. > These menu-items allow users to access various overviews related to > manufacturing, like > * production runs, > * routings (production schemas), > * routing task (schema tasks), > * production calendar, > * etc. > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #403: Improved: Have a Menu in Accounting featuring actions to create the main objects (OFBIZ-11780)
JacquesLeRoux merged pull request #403: URL: https://github.com/apache/ofbiz-framework/pull/403 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12442) VIEW permissions show ManufacturingAppBar items
[ https://issues.apache.org/jira/browse/OFBIZ-12442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456969#comment-17456969 ] ASF subversion and git services commented on OFBIZ-12442: - Commit 7c4a7512b4d7140d3f172b37c96aaf838cc07abf in ofbiz-framework's branch refs/heads/trunk from Pierre Smits [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=7c4a751 ] Improved: VIEW permissions show ManufacturingTabBar items (OFBIZ-12442) (#399) Currently, when a user with only VIEW permissions accesses the manufacturing component menu-items of the ManufacturingAppBar are not shown due to too restrictive conditions. These menu-items allow users to access various overviews related to manufacturing, like * production runs, * routings (production schemas), * routing task (schema tasks), * production calendar, * etc. Improved: ManufacturingMenus.xml - removed 'CREATE' condition from menu-items in ManufacturingAppBar, additional title improvement(s) ManufacturingUiLabels.xml - updated labels regarding menu-items in ManufacturingAppBar. > VIEW permissions show ManufacturingAppBar items > --- > > Key: OFBIZ-12442 > URL: https://issues.apache.org/jira/browse/OFBIZ-12442 > Project: OFBiz > Issue Type: Improvement > Components: manufacturing >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: manufacturing, menu-item, permissions, usability > > Currently, when a user with only VIEW permissions accesses the manufacturing > component menu-items of the ManufacturingAppBar are not shown due to too > restrictive conditions. > These menu-items allow users to access various overviews related to > manufacturing, like > * production runs, > * routings (production schemas), > * routing task (schema tasks), > * production calendar, > * etc. > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #399: Improved: VIEW permissions show ManufacturingTabBar items (OFBIZ-12442)
JacquesLeRoux merged pull request #399: URL: https://github.com/apache/ofbiz-framework/pull/399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12386) Fix some bugs Spotbugs reports
[ https://issues.apache.org/jira/browse/OFBIZ-12386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456963#comment-17456963 ] ASF subversion and git services commented on OFBIZ-12386: - Commit 0aa06d9c3d1fc88059fd491b6315c017b685ec7c in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=0aa06d9 ] Improved: Fix some bugs Spotbugs reports (OFBIZ-12386) In WebToolsServices::entityImportDir fixes a possible null dereferencement In ProductionRunServices::createProductionRunFromConfiguration fixes a possible null dereferencement and remove 2 unused vars > Fix some bugs Spotbugs reports > -- > > Key: OFBIZ-12386 > URL: https://issues.apache.org/jira/browse/OFBIZ-12386 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [ofbiz-framework] PierreSmits closed pull request #181: Improved: Have a main action menu for accounting (OFBIZ-11780)
PierreSmits closed pull request #181: URL: https://github.com/apache/ofbiz-framework/pull/181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] PierreSmits commented on pull request #181: Improved: Have a main action menu for accounting (OFBIZ-11780)
PierreSmits commented on pull request #181: URL: https://github.com/apache/ofbiz-framework/pull/181#issuecomment-990725799 Closing due to going stale. Superseded by PR 403 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #403: Improved: Have a Menu in Accounting featuring actions to create the main objects (OFBIZ-11780)
sonarcloud[bot] commented on pull request #403: URL: https://github.com/apache/ofbiz-framework/pull/403#issuecomment-990713917 Kudos, SonarCloud Quality Gate passed!  [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=403&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=403&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=403&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=403&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=403&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=403&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=403&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=403&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=403&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=403&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=403&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=403&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=403) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=403&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=403&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
