[jira] [Commented] (OFBIZ-9498) Improve DevOps using environment variable configuration

2021-12-17 Thread Ioan Eugen Stan (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461549#comment-17461549
 ] 

Ioan Eugen Stan commented on OFBIZ-9498:


I think it's a good evolution of the current situation. 

Related to this part of the code.

I know I looked at UtilProperties  some time and I noticed it pulls in 
dependency on UtilCache and that pulls in some other stuff.

Ideally these would be composeable and replaceable. 

It would be nice to be able to swap in a more modern configuration management.

Since UtilPropertiees is based on static methods, one way (the only way ?!) is 
to replace the class on the class path. 

This could be done if UtilProperties where in a `configuration-properties` 
module that we could  replace during distribution assembly with 
`configuration-awesome-new` that contains a class with same binary signature. 

But having static initialized fields makes it hard to draw a clear boundary. 

> Improve DevOps using environment variable configuration
> ---
>
> Key: OFBIZ-9498
> URL: https://issues.apache.org/jira/browse/OFBIZ-9498
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Attachments: OFBIZ-9498.patch
>
>
> Discussed in thread : https://s.apache.org/Mh3q
> This Jira will present the improvment proposal giving a way to configure 
> OFBiz using environment variable.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12401) Improved OFBiz configuration management for containers

2021-12-17 Thread Marco RODRIGUES (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461489#comment-17461489
 ] 

Marco RODRIGUES commented on OFBIZ-12401:
-

I will have some days off, two next week.

If you have material to integrate into the common reflection, it would be 
interesting to send it. Even if it is not finalized, it will provide ideas that 
could be integrated, trying to fit the needs.

> Improved OFBiz configuration management for containers
> --
>
> Key: OFBIZ-12401
> URL: https://issues.apache.org/jira/browse/OFBIZ-12401
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Ioan Eugen Stan
>Priority: Major
>
> It's hard to use OFBiz with containers and other deployment scenarios because 
> the OFBiz configuration is intertwined with source files and there are a lot 
> of them.
> We also need:
>  * the ability to override configuration properties
>  * load configs from a single / handful of files in a single location
>  * optionally load from multiple sources (files, db, configuration services 
> like kubernetes, consul ,etc) .
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-9498) Improve DevOps using environment variable configuration

2021-12-17 Thread Marco RODRIGUES (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461487#comment-17461487
 ] 

Marco RODRIGUES commented on OFBIZ-9498:


Hi, 
I will have some days off, two next week.

If you have material to integrate into the common reflection, it would be 
interesting to send it. Even if it is not finalized, it will provide ideas that 
could be integrated, trying to fit the needs.

> Improve DevOps using environment variable configuration
> ---
>
> Key: OFBIZ-9498
> URL: https://issues.apache.org/jira/browse/OFBIZ-9498
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Attachments: OFBIZ-9498.patch
>
>
> Discussed in thread : https://s.apache.org/Mh3q
> This Jira will present the improvment proposal giving a way to configure 
> OFBiz using environment variable.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12400) Upgrade to gradle 7.3 - support jdk 8 -> 17

2021-12-17 Thread Ioan Eugen Stan (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ioan Eugen Stan updated OFBIZ-12400:

Summary: Upgrade to gradle 7.3 - support jdk 8 -> 17  (was: Upgrade to 
gradle 7.3 )

> Upgrade to gradle 7.3 - support jdk 8 -> 17
> ---
>
> Key: OFBIZ-12400
> URL: https://issues.apache.org/jira/browse/OFBIZ-12400
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Ioan Eugen Stan
>Assignee: Ioan Eugen Stan
>Priority: Major
>
> For working with Java 17, we need to upgrade to gradle 7.3 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-6796) Group menu items to a side panel

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-6796:
-
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Group menu items to a side panel
> 
>
> Key: OFBIZ-6796
> URL: https://issues.apache.org/jira/browse/OFBIZ-6796
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Consolidate the menus definitions for management modules into one file and 
> display them in a side panel for easy access. 
> The menus can be displayed in accordion + tree form.
> There will be a content panel, and clicking the menu item will refresh the 
> content panel.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-4896) ProductionRunDeclaration doesn't show Routing

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-4896:
-
Affects Version/s: Upcoming Branch
   (was: Trunk)

> ProductionRunDeclaration doesn't show Routing
> -
>
> Key: OFBIZ-4896
> URL: https://issues.apache.org/jira/browse/OFBIZ-4896
> Project: OFBiz
>  Issue Type: Improvement
>  Components: manufacturing
>Affects Versions: Release Branch 12.04, Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Trunk
>
> Attachments: EditProductionRun.png, EditRoutingProductLink.png, 
> ProductionRunDeclaration_Confirmed.png
>
>
> When having created a new production run in MFG with a routing selected, the 
> routing isn't shown when the production run is confirmed.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-4896) ProductionRunDeclaration doesn't show Routing

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-4896:
-
Fix Version/s: Upcoming Branch
   (was: Trunk)

> ProductionRunDeclaration doesn't show Routing
> -
>
> Key: OFBIZ-4896
> URL: https://issues.apache.org/jira/browse/OFBIZ-4896
> Project: OFBiz
>  Issue Type: Improvement
>  Components: manufacturing
>Affects Versions: Release Branch 12.04, Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: EditProductionRun.png, EditRoutingProductLink.png, 
> ProductionRunDeclaration_Confirmed.png
>
>
> When having created a new production run in MFG with a routing selected, the 
> routing isn't shown when the production run is confirmed.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-6796) Group menu items to a side panel

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-6796:
-
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Group menu items to a side panel
> 
>
> Key: OFBIZ-6796
> URL: https://issues.apache.org/jira/browse/OFBIZ-6796
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Priority: Minor
> Fix For: Trunk
>
>
> Consolidate the menus definitions for management modules into one file and 
> display them in a side panel for easy access. 
> The menus can be displayed in accordion + tree form.
> There will be a content panel, and clicking the menu item will refresh the 
> content panel.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-6928) Have the layered model renderer work with EntityUtilProperties regarding retrieval of property values

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-6928:
-
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Have the layered model renderer work with EntityUtilProperties regarding 
> retrieval of property values
> -
>
> Key: OFBIZ-6928
> URL: https://issues.apache.org/jira/browse/OFBIZ-6928
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
>  Labels: multi-tenant
> Fix For: Trunk
>
>
> Currently property values are retrieved through
> {code}
> UtilProperties.getPropertyValue
> {code} function
> This should be using  EntityUtilProperties.getPropertyValue function.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-6928) Have the layered model renderer work with EntityUtilProperties regarding retrieval of property values

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-6928:
-
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Have the layered model renderer work with EntityUtilProperties regarding 
> retrieval of property values
> -
>
> Key: OFBIZ-6928
> URL: https://issues.apache.org/jira/browse/OFBIZ-6928
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
>  Labels: multi-tenant
> Fix For: Upcoming Branch
>
>
> Currently property values are retrieved through
> {code}
> UtilProperties.getPropertyValue
> {code} function
> This should be using  EntityUtilProperties.getPropertyValue function.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-7762) Full support for serialized inventory

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-7762:
-
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Full support for serialized inventory
> -
>
> Key: OFBIZ-7762
> URL: https://issues.apache.org/jira/browse/OFBIZ-7762
> Project: OFBiz
>  Issue Type: Improvement
>  Components: manufacturing, order, product
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
>
> The serialized inventory support is not feature complete.
> There have been some discussion on it at
> http://ofbiz.135035.n4.nabble.com/Serialized-inventory-not-well-implemented-td4656591.html
> Need further discussion to finalise implementation details and create 
> sub-issues as required. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-7762) Full support for serialized inventory

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-7762:
-
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Full support for serialized inventory
> -
>
> Key: OFBIZ-7762
> URL: https://issues.apache.org/jira/browse/OFBIZ-7762
> Project: OFBiz
>  Issue Type: Improvement
>  Components: manufacturing, order, product
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> The serialized inventory support is not feature complete.
> There have been some discussion on it at
> http://ofbiz.135035.n4.nabble.com/Serialized-inventory-not-well-implemented-td4656591.html
> Need further discussion to finalise implementation details and create 
> sub-issues as required. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-7976) ebaystore screen rendering exception

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-7976:
-
Fix Version/s: Upcoming Branch
   (was: Trunk)

> ebaystore screen rendering exception
> 
>
> Key: OFBIZ-7976
> URL: https://issues.apache.org/jira/browse/OFBIZ-7976
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Wai
>Priority: Major
> Fix For: Upcoming Branch
>
>
> go to https://localhost:8443/ebaystore/control/main
> click on submit
> page show errors...
> ERROR rendering error page [/error/error.jsp], but here is the error text: 
> org.apache.ofbiz.widget.renderer.ScreenRenderException: Error rendering 
> screen 
> [component://ebaystore/widget/EbayAccountScreens.xml#EbayPersonalInformation]:
>  org.apache.ofbiz.widget.renderer.ScreenRenderException: Error rendering 
> screen [component://ebaystore/widget/CommonScreens.xml#AccountDecorator]: 
> org.apache.ofbiz.entity.transaction.GenericTransactionException: The current 
> transaction is marked for rollback, not beginning a new transaction and 
> aborting current operation; the rollbackOnly was caused by: Error in Service 
> [getEbayUser]: Please set the API developer (ApiAccount.setDeveloper()). (The 
> current transaction is marked for rollback, not beginning a new transaction 
> and aborting current operation; the rollbackOnly was caused by: Error in 
> Service [getEbayUser]: Please set the API developer 
> (ApiAccount.setDeveloper()).) (Error rendering screen 
> [component://ebaystore/widget/CommonScreens.xml#AccountDecorator]: 
> org.apache.ofbiz.entity.transaction.GenericTransactionException: The current 
> transaction is marked for rollback, not beginning a new transaction and 
> aborting current operation; the rollbackOnly was caused by: Error in Service 
> [getEbayUser]: Please set the API developer (ApiAccount.setDeveloper()). (The 
> current transaction is marked for rollback, not beginning a new transaction 
> and aborting current operation; the rollbackOnly was caused by: Error in 
> Service [getEbayUser]: Please set the API developer 
> (ApiAccount.setDeveloper()).))



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-7248) Improve the layout of PDF documents

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-7248:
-
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Improve the layout of PDF documents
> ---
>
> Key: OFBIZ-7248
> URL: https://issues.apache.org/jira/browse/OFBIZ-7248
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Mohammad Kathawala
>Priority: Major
> Fix For: Upcoming Branch
>
>
> The layout of all the PDF documents in OFBiz like Order, Invoice, Picklist, 
> Shipment etc. does not look very good and is not very readable for end users. 
> We need to have a properly structured PDF documents which is easy to read.
> I am going  to create sub-tasks of this parent task for all the different 
> objects.  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-8253) Success/Error Message On CRUD Operations

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-8253:
-
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Success/Error Message On CRUD Operations
> 
>
> Key: OFBIZ-8253
> URL: https://issues.apache.org/jira/browse/OFBIZ-8253
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Reporter: Avnindra Sharma
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: screenshot-withoutSuccessMessage.png
>
>
> There are many screens where we don't get any success/error message on any 
> CRUD operation. 
> In this ticket, we will cover all that screen and make the Generic 
> Success/Error message of CRUD operations.
> For eg: While creating a new facility, we don't get any success message and 
> on also not a generic error message for it.
>  
> Please find the attached screenshot for more reference.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-7976) ebaystore screen rendering exception

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-7976:
-
Affects Version/s: Upcoming Branch
   (was: Trunk)

> ebaystore screen rendering exception
> 
>
> Key: OFBIZ-7976
> URL: https://issues.apache.org/jira/browse/OFBIZ-7976
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Wai
>Priority: Major
> Fix For: Trunk
>
>
> go to https://localhost:8443/ebaystore/control/main
> click on submit
> page show errors...
> ERROR rendering error page [/error/error.jsp], but here is the error text: 
> org.apache.ofbiz.widget.renderer.ScreenRenderException: Error rendering 
> screen 
> [component://ebaystore/widget/EbayAccountScreens.xml#EbayPersonalInformation]:
>  org.apache.ofbiz.widget.renderer.ScreenRenderException: Error rendering 
> screen [component://ebaystore/widget/CommonScreens.xml#AccountDecorator]: 
> org.apache.ofbiz.entity.transaction.GenericTransactionException: The current 
> transaction is marked for rollback, not beginning a new transaction and 
> aborting current operation; the rollbackOnly was caused by: Error in Service 
> [getEbayUser]: Please set the API developer (ApiAccount.setDeveloper()). (The 
> current transaction is marked for rollback, not beginning a new transaction 
> and aborting current operation; the rollbackOnly was caused by: Error in 
> Service [getEbayUser]: Please set the API developer 
> (ApiAccount.setDeveloper()).) (Error rendering screen 
> [component://ebaystore/widget/CommonScreens.xml#AccountDecorator]: 
> org.apache.ofbiz.entity.transaction.GenericTransactionException: The current 
> transaction is marked for rollback, not beginning a new transaction and 
> aborting current operation; the rollbackOnly was caused by: Error in Service 
> [getEbayUser]: Please set the API developer (ApiAccount.setDeveloper()). (The 
> current transaction is marked for rollback, not beginning a new transaction 
> and aborting current operation; the rollbackOnly was caused by: Error in 
> Service [getEbayUser]: Please set the API developer 
> (ApiAccount.setDeveloper()).))



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10360) Refactoring Variable Scope for org.apache.ofbiz.webapp

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10360:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.webapp 
> ---
>
> Key: OFBIZ-10360
> URL: https://issues.apache.org/jira/browse/OFBIZ-10360
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Assignee: Girish Vasmatkar
>Priority: Minor
> Fix For: Trunk
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10361) Refactoring Variable Scope for org.apache.ofbiz.service

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10361:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.service
> ---
>
> Key: OFBIZ-10361
> URL: https://issues.apache.org/jira/browse/OFBIZ-10361
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Assignee: Girish Vasmatkar
>Priority: Minor
> Fix For: Upcoming Branch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10343) Refactoring Variable Scope

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10343:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope  
> 
>
> Key: OFBIZ-10343
> URL: https://issues.apache.org/jira/browse/OFBIZ-10343
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Trunk
>
>
> Here is the detailed information about the things I am working on for 
> performance optimization in our OFBiz code.
>  
>  *1.) Downsize Accessibility Scope*
> I've tried to downsize accessibility scope of classes, interfaces, abstract 
> class, declared member variables, enumerations, methods, and constructors to 
> as minimum as possible as per OFBIz current implementation, still there is a 
> lot of scope for improvement but it would require changes at the granular 
> level. I've used 
> [this|https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html] 
> as my reference point. example:
>  
> {code:java}
> public void noteKeyRemoval(UtilCache cache, K key, V oldValue);{code}
> {code:java}
> void noteKeyRemoval(UtilCache cache, K key, V oldValue); {code}
>  
>  *2.) Using Lambda Expressions*
> Then tried to use lambda expressions on simple functional work to leverage 
> implicit type of coding an example: 
>  
> {code:java}
> Map initParameters = new LinkedHashMap<>();
> for (Element e : initParamList) {
> initParameters.put(e.getAttribute("name"), e.getAttribute("value"));
> }{code}
> {code:java}
> Map initParameters = 
> initParamList.stream().collect(Collectors.toMap(e -> e.getAttribute("name"), 
> e -> e.getAttribute("value"), (a, b) -> b, LinkedHashMap::new));{code}
> Some of the key benefits of using lambdas will introduce [Functional style 
> over Imperative 
> style|https://stackoverflow.com/questions/2078978/functional-programming-vs-object-oriented-programming],
>  we can use [method 
> referencing|https://docs.oracle.com/javase/tutorial/java/javaOO/methodreferences.html],
>  usage of aggregate operations, and it will help developers to write memory 
> efficient code. 
>  
>  *3.) Using Type Inference*
> Java uses type inference so to make code lightweight I've updated code 
> constructs as shown in the example for more on this refer this 
> [article|https://docs.oracle.com/javase/tutorial/java/generics/genTypeInference.htmlv].
>  
> {code:java}
> Map systemProps = UtilGenerics. 
> checkMap(System.getProperties());{code}
> {code:java}
> Map systemProps = 
> UtilGenerics.checkMap(System.getProperties());{code}
>  
>  *4.) Use of single quote for character*
> There is a significant usage of <"Single Character"> in the codebase for 
> example:-
>  
> {code:java}
> throw new GenericConfigException("Error opening file at location [" + 
> fileUrl.toExternalForm() + "]", e);{code}
> {code:java}
> throw new GenericConfigException("Error opening file at location [" + 
> fileUrl.toExternalForm() + ']', e);  "]" {code}
> "]" is comparatively slower than ']' Java internally uses Flyweight Design 
> pattern to create String literals so for every call it will not create a new 
> Object and used an existing one this will improve performance to some extent 
> a study can be seen on 
> [this|https://stackoverflow.com/questions/24859500/concatenate-char-literal-x-vs-single-char-string-literal-x]
>  page.  
>  
>  *5.) Updated Variable Declaration*
> Lastly, some of the variable declarations are updated this doesn't create a 
> huge difference but helps JVM at the from implicit conversion. 
>  
> {code:java}
> private long cumulativeEvents = 0;{code}
> {code:java}
> private long cumulativeEvents = 0L;{code}
> Based on above findings, I have done some code improvement and provided 
> following patches.
> *And need community help for reviewing these changes.*
> Kindly provide any improvements or suggestion you have in mind :)
>  
> P.S. Apart from this I am also working on performance matrix and will share 
> it soon.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10360) Refactoring Variable Scope for org.apache.ofbiz.webapp

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10360:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.webapp 
> ---
>
> Key: OFBIZ-10360
> URL: https://issues.apache.org/jira/browse/OFBIZ-10360
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Assignee: Girish Vasmatkar
>Priority: Minor
> Fix For: Upcoming Branch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-8538) Unit test case for service - updateSimpleTextContent

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-8538:
-
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Unit test case for service - updateSimpleTextContent
> 
>
> Key: OFBIZ-8538
> URL: https://issues.apache.org/jira/browse/OFBIZ-8538
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Reporter: Akash Jain
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Unit test case for service - updateSimpleTextContent



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10477) Parent ticket for reducing scope of variables and methods

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10477:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Parent ticket for reducing scope of variables and methods
> -
>
> Key: OFBIZ-10477
> URL: https://issues.apache.org/jira/browse/OFBIZ-10477
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> *Downsize Accessibility Scope*
> I've tried to downsize accessibility scope of classes, interfaces, abstract 
> class, declared member variables, enumerations, methods, and constructors to 
> as minimum as possible as per OFBIz current implementation, still there is a 
> lot of scope for improvement but it would require changes at the granular 
> level. I've used 
> [this|https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html] 
> as my reference point. example:
>  
> {code:java}
> public void noteKeyRemoval(UtilCache cache, K key, V oldValue);{code}
> {code:java}
> void noteKeyRemoval(UtilCache cache, K key, V oldValue); {code}
> As per the current implementation, I will try to give minimum scope 
> furthermore can be enhanced 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10361) Refactoring Variable Scope for org.apache.ofbiz.service

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10361:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.service
> ---
>
> Key: OFBIZ-10361
> URL: https://issues.apache.org/jira/browse/OFBIZ-10361
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Assignee: Girish Vasmatkar
>Priority: Minor
> Fix For: Trunk
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-11409) POC for Dynamic Screen Using MVVM

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-11409:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> POC for Dynamic Screen Using MVVM
> -
>
> Key: OFBIZ-11409
> URL: https://issues.apache.org/jira/browse/OFBIZ-11409
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11409.patch, OFBIZ-11409.patch, OFBIZ-11409.patch, 
> OFBIZ-11409.patch, OFBIZ-11409.patch, OFBIZ-11409.patch
>
>
> Proof of concept for Model–view–viewmodel (MVVM) in form widgets.
> Added data-bind attribute to the field, form and grid tag.
> *Example 1:*
> Go to [https://localhost:8443/humanres/control/NewEmployee] and try the 
> following field:
>  # First name
>  # Middle name
>  # Last name
> Added Full Name field to demonstrate computed observable/property.
> *Example 2:*
> Page at 
> [https://localhost:8443/ordermgr/control/ListQuoteItemsDemo?quoteId=CQ0001] 
> duplicated the functionality of Quote Items page, but done using data-binding 
> way. 
> mbrohl: here is a link to the discussion on the dev mailing list: 
> [https://lists.apache.org/thread.html/r1cddbc8041e5a6559bfad979bc8570581a3d1f662a0f8692c7ee9e59%40%3Cdev.ofbiz.apache.org%3E]
> *15th March 2020* 
>  Updated the patch with more concrete examples for form and grid.
> *10th April 2020*
> Updated the patch with initVmFunc and some refactoring.
> *3rd May 2020*
> Updated the patch with a single demo that uses form and grid together.
>  # The demo can be accessed from 
> [https://localhost:8443/ordermgr/control/EditQuoteAndItems].
>  # Added a view='knockout' attribute so that form renderer will render the 
> form / grid for use by knockout framework.
>  # Added autocomplete templates
>  
> *Details*
> 1) -A javascript model function will be generated for the form / grid widgets 
> when its data-bind attribute is defined.- 
>  As of 3rd April, all datamodel are not autogenerated.
> 2) First row of the grid is generated by the ofbiz form renderer at the 
> server side. Subsequent rows will be generated by knockout at the browser 
> side.
> -3) Naming convention of the viewmodel function is  Grid>*VmFunc*. There is a viewmodel for the Grid widget at row level; naming 
> convention is *VmRowFunc*.-
> 4) Viewmodel function can be extended using javascript prototype. See the 
> *.js.ftl files in the patch. 
> 5) The following javascript files are used:
>  * big/big.js - for basic mathematics operation
>  * knockout/knockout-3.5.1.js - knockout library
>  * knockout/knockout-config.js - extending the library and some code to 
> configure knockout-secure-binding
>  * knockout/knockout-secure-binding - allow knockout js to be used with a 
> Content Security Policy that disables eval and new Function.
>  * knockout-jqAutocomplete.js -  for autocomplete
> 6)  Example of hyperlink:
> Before:
> {code:xml}
>  widget-style="buttontext" use-when="${groovy: 'N'.equals(isPromo)}">
>  also-hidden="false">
> 
> 
> 
> 
> {code}
> After:
> {code:xml}
>  data-bind="text:quoteItemSeqId, attr: { href: 
> editQuoteItemLink, title: 'Quote Item Seq ID'}"
>widget-style="buttontext">
> 
> 
> {code}
> {code:javascript}
> QuoteItem.prototype = {
> computed: {
> "editQuoteItemLink": function(){
> return "<@ofbizUrl>EditQuoteItem?=" + 
> this.quoteItemSeqId() + "=" + this.quoteId();
> },
>...
> };
> {code}
> From the value of data-bind attribute, we can see that the href attribute 
> points to the editQuoteItemLink function.
> editQuoteItemLink is a prototype member of QuoteItems which is viewmodel 
> function for the Grid widget at row level.
> 7) Example of decimal places:
> {code:javascript}
> extend: {
> "quoteUnitPrice": {numeric: 2}
> }
> {code}
> The column or field for qouteUnitPrice will be rounded to 2 decimal places.
> 8) Example of calculating line totals:
> {code:xml}
>  
> {code}
> {code:javascript}
> QuoteItems.prototype = {
> computed: {
> ...
> "lineTotal": function() {
> var itemPrice = this.quoteUnitPrice();
> var selectedAmount = this.selectedAmount() || 1;
> var quantity = this.quantity() || 0;
> return new 
> Big(itemPrice).times(selectedAmount).times(quantity).toFixed(2);
> }
> ...
> };
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-11069) Add coalesce to aggregate-function of model view

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-11069:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Add coalesce to aggregate-function of model view
> 
>
> Key: OFBIZ-11069
> URL: https://issues.apache.org/jira/browse/OFBIZ-11069
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Reporter: Shi Jinghai
>Priority: Trivial
>  Labels: IoT, ModelViewEntity
> Fix For: Upcoming Branch
>
> Attachments: ModelViewEntity-function-coalesce.patch
>
>
> While in our IoT case, a product may have a sku product id as well as a 
> productId (product instance) by identified from unique id i.e. an EPC.
> When building operation/inventory reports, to be compatible with previous 
> implement, I have to merge the sku product Id column into the productId 
> column, so comes the coalesce patch. 
> The usage example:
> {code:java}
>  function="coalesce">
> 
> 
> 
> 
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10477) Parent ticket for reducing scope of variables and methods

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10477:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Parent ticket for reducing scope of variables and methods
> -
>
> Key: OFBIZ-10477
> URL: https://issues.apache.org/jira/browse/OFBIZ-10477
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Trunk
>
>
> *Downsize Accessibility Scope*
> I've tried to downsize accessibility scope of classes, interfaces, abstract 
> class, declared member variables, enumerations, methods, and constructors to 
> as minimum as possible as per OFBIz current implementation, still there is a 
> lot of scope for improvement but it would require changes at the granular 
> level. I've used 
> [this|https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html] 
> as my reference point. example:
>  
> {code:java}
> public void noteKeyRemoval(UtilCache cache, K key, V oldValue);{code}
> {code:java}
> void noteKeyRemoval(UtilCache cache, K key, V oldValue); {code}
> As per the current implementation, I will try to give minimum scope 
> furthermore can be enhanced 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-11409) POC for Dynamic Screen Using MVVM

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-11409:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> POC for Dynamic Screen Using MVVM
> -
>
> Key: OFBIZ-11409
> URL: https://issues.apache.org/jira/browse/OFBIZ-11409
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11409.patch, OFBIZ-11409.patch, OFBIZ-11409.patch, 
> OFBIZ-11409.patch, OFBIZ-11409.patch, OFBIZ-11409.patch
>
>
> Proof of concept for Model–view–viewmodel (MVVM) in form widgets.
> Added data-bind attribute to the field, form and grid tag.
> *Example 1:*
> Go to [https://localhost:8443/humanres/control/NewEmployee] and try the 
> following field:
>  # First name
>  # Middle name
>  # Last name
> Added Full Name field to demonstrate computed observable/property.
> *Example 2:*
> Page at 
> [https://localhost:8443/ordermgr/control/ListQuoteItemsDemo?quoteId=CQ0001] 
> duplicated the functionality of Quote Items page, but done using data-binding 
> way. 
> mbrohl: here is a link to the discussion on the dev mailing list: 
> [https://lists.apache.org/thread.html/r1cddbc8041e5a6559bfad979bc8570581a3d1f662a0f8692c7ee9e59%40%3Cdev.ofbiz.apache.org%3E]
> *15th March 2020* 
>  Updated the patch with more concrete examples for form and grid.
> *10th April 2020*
> Updated the patch with initVmFunc and some refactoring.
> *3rd May 2020*
> Updated the patch with a single demo that uses form and grid together.
>  # The demo can be accessed from 
> [https://localhost:8443/ordermgr/control/EditQuoteAndItems].
>  # Added a view='knockout' attribute so that form renderer will render the 
> form / grid for use by knockout framework.
>  # Added autocomplete templates
>  
> *Details*
> 1) -A javascript model function will be generated for the form / grid widgets 
> when its data-bind attribute is defined.- 
>  As of 3rd April, all datamodel are not autogenerated.
> 2) First row of the grid is generated by the ofbiz form renderer at the 
> server side. Subsequent rows will be generated by knockout at the browser 
> side.
> -3) Naming convention of the viewmodel function is  Grid>*VmFunc*. There is a viewmodel for the Grid widget at row level; naming 
> convention is *VmRowFunc*.-
> 4) Viewmodel function can be extended using javascript prototype. See the 
> *.js.ftl files in the patch. 
> 5) The following javascript files are used:
>  * big/big.js - for basic mathematics operation
>  * knockout/knockout-3.5.1.js - knockout library
>  * knockout/knockout-config.js - extending the library and some code to 
> configure knockout-secure-binding
>  * knockout/knockout-secure-binding - allow knockout js to be used with a 
> Content Security Policy that disables eval and new Function.
>  * knockout-jqAutocomplete.js -  for autocomplete
> 6)  Example of hyperlink:
> Before:
> {code:xml}
>  widget-style="buttontext" use-when="${groovy: 'N'.equals(isPromo)}">
>  also-hidden="false">
> 
> 
> 
> 
> {code}
> After:
> {code:xml}
>  data-bind="text:quoteItemSeqId, attr: { href: 
> editQuoteItemLink, title: 'Quote Item Seq ID'}"
>widget-style="buttontext">
> 
> 
> {code}
> {code:javascript}
> QuoteItem.prototype = {
> computed: {
> "editQuoteItemLink": function(){
> return "<@ofbizUrl>EditQuoteItem?=" + 
> this.quoteItemSeqId() + "=" + this.quoteId();
> },
>...
> };
> {code}
> From the value of data-bind attribute, we can see that the href attribute 
> points to the editQuoteItemLink function.
> editQuoteItemLink is a prototype member of QuoteItems which is viewmodel 
> function for the Grid widget at row level.
> 7) Example of decimal places:
> {code:javascript}
> extend: {
> "quoteUnitPrice": {numeric: 2}
> }
> {code}
> The column or field for qouteUnitPrice will be rounded to 2 decimal places.
> 8) Example of calculating line totals:
> {code:xml}
>  
> {code}
> {code:javascript}
> QuoteItems.prototype = {
> computed: {
> ...
> "lineTotal": function() {
> var itemPrice = this.quoteUnitPrice();
> var selectedAmount = this.selectedAmount() || 1;
> var quantity = this.quantity() || 0;
> return new 
> Big(itemPrice).times(selectedAmount).times(quantity).toFixed(2);
> }
> ...
> };
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-7789) ReserveStoreInventory with insufficient inventory

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-7789:
-
Fix Version/s: Upcoming Branch
   (was: Trunk)

> ReserveStoreInventory with insufficient inventory
> -
>
> Key: OFBIZ-7789
> URL: https://issues.apache.org/jira/browse/OFBIZ-7789
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 13.07, Upcoming Branch
>Reporter: Mirko Vogelsmeier
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7789.patch
>
>
> When trying to reserve inventory for an item that does not have sufficient 
> amount of inventory ( ProductStoreServices#reserveStoreInventory ) no error 
> is thrown. This results in a successfully processed service.
> Following problem occured to us:
> We have a unique product (qoh 1) that is in the current order.
> Using the appendOrderItem on the exact product, does trigger 
> updateCartForUpdate which removes all reservations followed by 
> saveUpdatedCartToOrder that does store all orderItems to the order. Since no 
> error is being thrown due to the insufficient inventory, the product is added 
> to the order twice, although there is not enough inventory.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-7789) ReserveStoreInventory with insufficient inventory

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-7789:
-
Affects Version/s: Upcoming Branch
   (was: Trunk)

> ReserveStoreInventory with insufficient inventory
> -
>
> Key: OFBIZ-7789
> URL: https://issues.apache.org/jira/browse/OFBIZ-7789
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 13.07, Upcoming Branch
>Reporter: Mirko Vogelsmeier
>Priority: Major
> Fix For: Trunk
>
> Attachments: OFBIZ-7789.patch
>
>
> When trying to reserve inventory for an item that does not have sufficient 
> amount of inventory ( ProductStoreServices#reserveStoreInventory ) no error 
> is thrown. This results in a successfully processed service.
> Following problem occured to us:
> We have a unique product (qoh 1) that is in the current order.
> Using the appendOrderItem on the exact product, does trigger 
> updateCartForUpdate which removes all reservations followed by 
> saveUpdatedCartToOrder that does store all orderItems to the order. Since no 
> error is being thrown due to the insufficient inventory, the product is added 
> to the order twice, although there is not enough inventory.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-6360) Form widget rendering broken for EmailServices.java

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-6360:
-
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Form widget rendering broken for EmailServices.java
> ---
>
> Key: OFBIZ-6360
> URL: https://issues.apache.org/jira/browse/OFBIZ-6360
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Christian Carlow
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6360-release13.07.patch, OFBIZ-6360.patch
>
>
> Currently only FTL files are rendered by EmailServices.java because 
> formStringRenderer is null for 
> HtmlScreenRenderer.java#renderScreenletSubWidget which is supposed to be 
> extracted from the context parameter, previously from the request parameter, 
> which never exists for the emailing service.  This issue was encountered when 
> testing the sendQuoteReportMail service for the form widget that replaced the 
> FTL for OFBIZ-6349.  
> EmailServices.java is still using the deprecated HtmlScreenRenderer and 
> FoScreenRenderer which should both be replaced by MacroScreenRenderer.  This 
> made me realize I left out the new header rendering functionality for patch 
> OFBIZ-6354 for these two deprecated classes which probably need to be 
> provided along with the existing patch.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-6360) Form widget rendering broken for EmailServices.java

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-6360:
-
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Form widget rendering broken for EmailServices.java
> ---
>
> Key: OFBIZ-6360
> URL: https://issues.apache.org/jira/browse/OFBIZ-6360
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Christian Carlow
>Priority: Major
> Fix For: Trunk
>
> Attachments: OFBIZ-6360-release13.07.patch, OFBIZ-6360.patch
>
>
> Currently only FTL files are rendered by EmailServices.java because 
> formStringRenderer is null for 
> HtmlScreenRenderer.java#renderScreenletSubWidget which is supposed to be 
> extracted from the context parameter, previously from the request parameter, 
> which never exists for the emailing service.  This issue was encountered when 
> testing the sendQuoteReportMail service for the form widget that replaced the 
> FTL for OFBIZ-6349.  
> EmailServices.java is still using the deprecated HtmlScreenRenderer and 
> FoScreenRenderer which should both be replaced by MacroScreenRenderer.  This 
> made me realize I left out the new header rendering functionality for patch 
> OFBIZ-6354 for these two deprecated classes which probably need to be 
> provided along with the existing patch.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10344) Refactoring Variable Scope for org.apache.ofbiz.base package

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10344:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.base package
> 
>
> Key: OFBIZ-10344
> URL: https://issues.apache.org/jira/browse/OFBIZ-10344
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10344.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10164) Splitter Widget

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10164:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Splitter Widget
> ---
>
> Key: OFBIZ-10164
> URL: https://issues.apache.org/jira/browse/OFBIZ-10164
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10164.patch, OFBIZ-10164.patch, OFBIZ-10164.patch, 
> horizontal.png, vertical.png
>
>
> A new splitter widget that will use a tag named 'splitter'.
> This splitter tag has the following attributes:
> a. sizes = [25, 75] where the containers within will be splitted with a ratio 
> of 25% and 75%
> b. parentId which is the ID of the parent container
> c. direction = vertical or horizonal (default)
> The splitter tag can only contains container(s) as immediate child.
> Using the library from http://nathancahill.github.io/Split.js/ which is 
> licensed under MIT license.
> Update on 20180128:
> 1) The patch comes with an example where you can view the splitter at 
> https://localhost:8443/catalog/control/main
> 2) No need to add square brackets when defining sizes.
> 3) parentId attribute is removed,



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-8301) The state dropdown not ordered alphabetically on the create/edit address screen of related components

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-8301:
-
Affects Version/s: Upcoming Branch
   (was: Trunk)

> The state dropdown not ordered alphabetically on the create/edit address 
> screen of related components
> -
>
> Key: OFBIZ-8301
> URL: https://issues.apache.org/jira/browse/OFBIZ-8301
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Upcoming Branch
>Reporter: Supatthra Nawicha
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Trunk
>
> Attachments: Image2.png, Image4.png, OFBIZ-8301.patch
>
>
> I have found this issue when I try to create a new customer from the party 
> manager. Then I try to select the state of UK but I see the state is not 
> order alphabetically. 
> I have check on the getAssociatedStateList service and it provide the 
> listOrderBy parameter for order the value on the state dropdown but the 
> getDependentDropdownValues function on javascript does not send the 
> listOrderBy parameter to the service. 
> {code:title=framework/common/src/main/java/org/apache/ofbiz/common/CommonWorkers.java|borderStyle=solid}
> public static List getAssociatedStateList(Delegator delegator, 
> String country, String listOrderBy) {
> if (UtilValidate.isEmpty(country)) {
> // Load the system default country
> country = EntityUtilProperties.getPropertyValue("general", 
> "country.geo.id.default", delegator);
> }
> if (UtilValidate.isEmpty(listOrderBy)) {
> listOrderBy = "geoId";
> }
> List sortList = UtilMisc.toList(listOrderBy);
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10344) Refactoring Variable Scope for org.apache.ofbiz.base package

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10344:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.base package
> 
>
> Key: OFBIZ-10344
> URL: https://issues.apache.org/jira/browse/OFBIZ-10344
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10344.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-8301) The state dropdown not ordered alphabetically on the create/edit address screen of related components

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-8301:
-
Fix Version/s: Upcoming Branch
   (was: Trunk)

> The state dropdown not ordered alphabetically on the create/edit address 
> screen of related components
> -
>
> Key: OFBIZ-8301
> URL: https://issues.apache.org/jira/browse/OFBIZ-8301
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Upcoming Branch
>Reporter: Supatthra Nawicha
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: Image2.png, Image4.png, OFBIZ-8301.patch
>
>
> I have found this issue when I try to create a new customer from the party 
> manager. Then I try to select the state of UK but I see the state is not 
> order alphabetically. 
> I have check on the getAssociatedStateList service and it provide the 
> listOrderBy parameter for order the value on the state dropdown but the 
> getDependentDropdownValues function on javascript does not send the 
> listOrderBy parameter to the service. 
> {code:title=framework/common/src/main/java/org/apache/ofbiz/common/CommonWorkers.java|borderStyle=solid}
> public static List getAssociatedStateList(Delegator delegator, 
> String country, String listOrderBy) {
> if (UtilValidate.isEmpty(country)) {
> // Load the system default country
> country = EntityUtilProperties.getPropertyValue("general", 
> "country.geo.id.default", delegator);
> }
> if (UtilValidate.isEmpty(listOrderBy)) {
> listOrderBy = "geoId";
> }
> List sortList = UtilMisc.toList(listOrderBy);
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-8641) Unit test case for service - createPostalAddressAndPurposes

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-8641:
-
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Unit test case for service - createPostalAddressAndPurposes
> ---
>
> Key: OFBIZ-8641
> URL: https://issues.apache.org/jira/browse/OFBIZ-8641
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: party
>Reporter: Akash Jain
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-8641.patch
>
>
> Unit test case for service - createPostalAddressAndPurposes



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10164) Splitter Widget

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10164:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Splitter Widget
> ---
>
> Key: OFBIZ-10164
> URL: https://issues.apache.org/jira/browse/OFBIZ-10164
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10164.patch, OFBIZ-10164.patch, OFBIZ-10164.patch, 
> horizontal.png, vertical.png
>
>
> A new splitter widget that will use a tag named 'splitter'.
> This splitter tag has the following attributes:
> a. sizes = [25, 75] where the containers within will be splitted with a ratio 
> of 25% and 75%
> b. parentId which is the ID of the parent container
> c. direction = vertical or horizonal (default)
> The splitter tag can only contains container(s) as immediate child.
> Using the library from http://nathancahill.github.io/Split.js/ which is 
> licensed under MIT license.
> Update on 20180128:
> 1) The patch comes with an example where you can view the splitter at 
> https://localhost:8443/catalog/control/main
> 2) No need to add square brackets when defining sizes.
> 3) parentId attribute is removed,



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10346) Refactoring Variable Scope for org.apache.ofbiz.common

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10346:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.common
> --
>
> Key: OFBIZ-10346
> URL: https://issues.apache.org/jira/browse/OFBIZ-10346
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10346.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10345) Refactoring Variable Scope for org.apache.ofbiz.catalina.container

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10345:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.catalina.container
> --
>
> Key: OFBIZ-10345
> URL: https://issues.apache.org/jira/browse/OFBIZ-10345
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10345.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10346) Refactoring Variable Scope for org.apache.ofbiz.common

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10346:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.common
> --
>
> Key: OFBIZ-10346
> URL: https://issues.apache.org/jira/browse/OFBIZ-10346
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10346.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10347) Refactoring Variable Scope for org.apache.ofbiz.datafile

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10347:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.datafile
> 
>
> Key: OFBIZ-10347
> URL: https://issues.apache.org/jira/browse/OFBIZ-10347
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Assignee: Girish Vasmatkar
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10347.patch, OFBIZ-10347_updated.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10345) Refactoring Variable Scope for org.apache.ofbiz.catalina.container

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10345:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.catalina.container
> --
>
> Key: OFBIZ-10345
> URL: https://issues.apache.org/jira/browse/OFBIZ-10345
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10345.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10347) Refactoring Variable Scope for org.apache.ofbiz.datafile

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10347:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.datafile
> 
>
> Key: OFBIZ-10347
> URL: https://issues.apache.org/jira/browse/OFBIZ-10347
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Assignee: Girish Vasmatkar
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10347.patch, OFBIZ-10347_updated.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10348) Refactoring Variable Scope for org.apache.ofbiz.entity

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10348:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.entity
> --
>
> Key: OFBIZ-10348
> URL: https://issues.apache.org/jira/browse/OFBIZ-10348
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10348_1.patch, OFBIZ-10348_2.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10351) Tree View of Call Graph for Services and Simple Methods

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10351:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Tree View of Call Graph for Services and Simple Methods
> ---
>
> Key: OFBIZ-10351
> URL: https://issues.apache.org/jira/browse/OFBIZ-10351
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10351.patch, OFBIZ-10351.patch, OFBIZ-10351.patch, 
> OFBIZ-10351.patch, OFBIZ-10351.patch
>
>
> Option to log a tree view of services and simple methods, and events that are 
> called in a request. 
> Some discussion at 
> https://lists.apache.org/thread.html/079455a596056334265ecbd410b4de13b6e61e1449ac258af5e9679b@%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10349) Refactoring Variable Scope for org.apache.ofbiz.entityext

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10349:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.entityext
> -
>
> Key: OFBIZ-10349
> URL: https://issues.apache.org/jira/browse/OFBIZ-10349
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Assignee: Girish Vasmatkar
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10349.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10349) Refactoring Variable Scope for org.apache.ofbiz.entityext

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10349:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.entityext
> -
>
> Key: OFBIZ-10349
> URL: https://issues.apache.org/jira/browse/OFBIZ-10349
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Assignee: Girish Vasmatkar
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10349.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10352) Refactoring Variable Scope for org.apache.ofbiz.minilang

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10352:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.minilang
> 
>
> Key: OFBIZ-10352
> URL: https://issues.apache.org/jira/browse/OFBIZ-10352
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Assignee: Girish Vasmatkar
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10352.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10352) Refactoring Variable Scope for org.apache.ofbiz.minilang

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10352:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.minilang
> 
>
> Key: OFBIZ-10352
> URL: https://issues.apache.org/jira/browse/OFBIZ-10352
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Assignee: Girish Vasmatkar
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10352.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10348) Refactoring Variable Scope for org.apache.ofbiz.entity

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10348:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.entity
> --
>
> Key: OFBIZ-10348
> URL: https://issues.apache.org/jira/browse/OFBIZ-10348
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10348_1.patch, OFBIZ-10348_2.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10351) Tree View of Call Graph for Services and Simple Methods

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10351:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Tree View of Call Graph for Services and Simple Methods
> ---
>
> Key: OFBIZ-10351
> URL: https://issues.apache.org/jira/browse/OFBIZ-10351
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10351.patch, OFBIZ-10351.patch, OFBIZ-10351.patch, 
> OFBIZ-10351.patch, OFBIZ-10351.patch
>
>
> Option to log a tree view of services and simple methods, and events that are 
> called in a request. 
> Some discussion at 
> https://lists.apache.org/thread.html/079455a596056334265ecbd410b4de13b6e61e1449ac258af5e9679b@%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10358) Refactoring Variable Scope for org.apache.ofbiz.base.start

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10358:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.base.start
> --
>
> Key: OFBIZ-10358
> URL: https://issues.apache.org/jira/browse/OFBIZ-10358
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10358.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10358) Refactoring Variable Scope for org.apache.ofbiz.base.start

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10358:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.base.start
> --
>
> Key: OFBIZ-10358
> URL: https://issues.apache.org/jira/browse/OFBIZ-10358
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10358.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10359) Refactoring Variable Scope for org.apache.ofbiz.security

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10359:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope  for org.apache.ofbiz.security
> -
>
> Key: OFBIZ-10359
> URL: https://issues.apache.org/jira/browse/OFBIZ-10359
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Assignee: Girish Vasmatkar
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10359.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10359) Refactoring Variable Scope for org.apache.ofbiz.security

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10359:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope  for org.apache.ofbiz.security
> -
>
> Key: OFBIZ-10359
> URL: https://issues.apache.org/jira/browse/OFBIZ-10359
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Assignee: Girish Vasmatkar
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10359.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10480) Refactoring and Reducing scope of variables in org.apache.ofbiz.common package

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10480:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring and Reducing scope of variables in org.apache.ofbiz.common package
> --
>
> Key: OFBIZ-10480
> URL: https://issues.apache.org/jira/browse/OFBIZ-10480
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Assignee: Girish Vasmatkar
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10480.patch
>
>
> Updated summary of this ticket to include any code refactoring that can be 
> done on this package. Not to limit this ticket for only variable/method 
> scoping.
> Please let me know if anyone has any issue and I will revert the update.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10480) Refactoring and Reducing scope of variables in org.apache.ofbiz.common package

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10480:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring and Reducing scope of variables in org.apache.ofbiz.common package
> --
>
> Key: OFBIZ-10480
> URL: https://issues.apache.org/jira/browse/OFBIZ-10480
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Assignee: Girish Vasmatkar
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10480.patch
>
>
> Updated summary of this ticket to include any code refactoring that can be 
> done on this package. Not to limit this ticket for only variable/method 
> scoping.
> Please let me know if anyone has any issue and I will revert the update.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10496) Defective inventories are valuating in Inventory valuation report

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10496:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Defective inventories are valuating in Inventory valuation report 
> --
>
> Key: OFBIZ-10496
> URL: https://issues.apache.org/jira/browse/OFBIZ-10496
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Upcoming Branch
>Reporter: Amit Gadaley
>Assignee: Amit Gadaley
>Priority: Major
> Fix For: Trunk
>
> Attachments: OFBIZ-10496.patch
>
>
> Inventory items with status 'INV_NS_DEFECTIVE' and 'INV_DEFECTIVE' are also 
> included in the inventory valuation report.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10481) Reducing scope of variables in org.apache.ofbiz.datafile package

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10481:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Reducing scope of variables in org.apache.ofbiz.datafile package
> 
>
> Key: OFBIZ-10481
> URL: https://issues.apache.org/jira/browse/OFBIZ-10481
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10481.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10481) Reducing scope of variables in org.apache.ofbiz.datafile package

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10481:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Reducing scope of variables in org.apache.ofbiz.datafile package
> 
>
> Key: OFBIZ-10481
> URL: https://issues.apache.org/jira/browse/OFBIZ-10481
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10481.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10496) Defective inventories are valuating in Inventory valuation report

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10496:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Defective inventories are valuating in Inventory valuation report 
> --
>
> Key: OFBIZ-10496
> URL: https://issues.apache.org/jira/browse/OFBIZ-10496
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Upcoming Branch
>Reporter: Amit Gadaley
>Assignee: Amit Gadaley
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10496.patch
>
>
> Inventory items with status 'INV_NS_DEFECTIVE' and 'INV_DEFECTIVE' are also 
> included in the inventory valuation report.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10630) eCommerce - Return History Feature

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10630:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> eCommerce - Return History Feature
> --
>
> Key: OFBIZ-10630
> URL: https://issues.apache.org/jira/browse/OFBIZ-10630
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ecommerce
>Affects Versions: Upcoming Branch
>Reporter: Ratnesh Upadhyay
>Assignee: Ratnesh Upadhyay
>Priority: Major
> Fix For: Trunk
>
>
> While walk though the eCommerce application, noticed that we have Order 
> History section there but we don't have Return History. So based upon 
> community's approval we have to add support for "Return History" feature in 
> eCommerce application.
>  Items needs to be implemented under this ticket : 
>  - Add new navigation for return history.
>  - Display list of returns submitted by the customer along with basic details.
>  - Customer should be able to view return details by clicking upon view link 
> OR returnID.
>   
>  Thanks to all the members for the discussion and approval.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-11039) add a chapter "About this documentation"

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-11039:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> add a chapter "About this documentation"
> 
>
> Key: OFBIZ-11039
> URL: https://issues.apache.org/jira/browse/OFBIZ-11039
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: humanres
>Affects Versions: Upcoming Branch
>Reporter: Olivier Heintz
>Priority: Major
> Fix For: Trunk
>
> Attachments: Employee_Main_Screen.png, 
> HR-Employee_Submenu_Rainbow_Stone.png, HR-Employee_Submenu_Tomahawk.png, 
> HR_Application_Submenu_Rainbow_Stone.png, 
> HR_Application_Submenu_Tomahawk.png, 
> OFBIZ-11039_Documented-add-a-chapter-About-this-documentation-in.patch, 
> hr-about-doc.adoc
>
>
> This chapter present the main OFBiz GUI rules with some screenshot and link 
> between tutorial and video of "Scenario GUI Test"
> Currently it's in HR, but when other application will be done it can be 
> generalize and go to User Manual introduction.
> The file hr-about-doc.adoc associated with this task is included via a 
> include:: line in the humanres.adoc



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10630) eCommerce - Return History Feature

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10630:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> eCommerce - Return History Feature
> --
>
> Key: OFBIZ-10630
> URL: https://issues.apache.org/jira/browse/OFBIZ-10630
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ecommerce
>Affects Versions: Upcoming Branch
>Reporter: Ratnesh Upadhyay
>Assignee: Ratnesh Upadhyay
>Priority: Major
> Fix For: Upcoming Branch
>
>
> While walk though the eCommerce application, noticed that we have Order 
> History section there but we don't have Return History. So based upon 
> community's approval we have to add support for "Return History" feature in 
> eCommerce application.
>  Items needs to be implemented under this ticket : 
>  - Add new navigation for return history.
>  - Display list of returns submitted by the customer along with basic details.
>  - Customer should be able to view return details by clicking upon view link 
> OR returnID.
>   
>  Thanks to all the members for the discussion and approval.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10976) Unable to add product to cart when user enter detail in Tell-A-Friend link.

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10976:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Unable to add product to cart when user enter detail in Tell-A-Friend link.
> ---
>
> Key: OFBIZ-10976
> URL: https://issues.apache.org/jira/browse/OFBIZ-10976
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Reporter: Ashish Sharma
>Assignee: Swapnil Mane
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10976.patch, OFBIZ-10976.png
>
>
> *Step to reproduce*
> 1. Login with valid username and password.
> 2. Navigate to ecommerce.
> 3. Select a product and click on link Tell-A-Friend.
> 4. Enter detail in Tell-A-Friend window.
> 5. Click on link add to cart link.
> *Actual Result:* Error message is displayed as "Tell a friend sorry".
> *Screen print attached*
> *Note - Email validation is not added in Tell-A-Friend window.*



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-11039) add a chapter "About this documentation"

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-11039:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> add a chapter "About this documentation"
> 
>
> Key: OFBIZ-11039
> URL: https://issues.apache.org/jira/browse/OFBIZ-11039
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: humanres
>Affects Versions: Upcoming Branch
>Reporter: Olivier Heintz
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: Employee_Main_Screen.png, 
> HR-Employee_Submenu_Rainbow_Stone.png, HR-Employee_Submenu_Tomahawk.png, 
> HR_Application_Submenu_Rainbow_Stone.png, 
> HR_Application_Submenu_Tomahawk.png, 
> OFBIZ-11039_Documented-add-a-chapter-About-this-documentation-in.patch, 
> hr-about-doc.adoc
>
>
> This chapter present the main OFBiz GUI rules with some screenshot and link 
> between tutorial and video of "Scenario GUI Test"
> Currently it's in HR, but when other application will be done it can be 
> generalize and go to User Manual introduction.
> The file hr-about-doc.adoc associated with this task is included via a 
> include:: line in the humanres.adoc



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-11042) Allow to choose salaryStepSeqId when create a SalaryStep

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-11042:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Allow to choose salaryStepSeqId when create a SalaryStep
> 
>
> Key: OFBIZ-11042
> URL: https://issues.apache.org/jira/browse/OFBIZ-11042
> Project: OFBiz
>  Issue Type: Improvement
>  Components: humanres
>Affects Versions: Upcoming Branch
>Reporter: Olivier Heintz
>Priority: Major
>  Labels: humanres
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11042.patch
>
>
> Comming from "The Data model Resource Book"
> {{«}} Salary Grade-Step are used in entreprise that have a predefined, highly 
> structure pay system (such as the federal government). This is done by 
> reference to a structure pay schedule.{{»}}
> Currently in OFBiz in HR in Global HR Settings, it's possible to choose 
> gradeId but not stepSeqId and so it's not readable when you want select a 
> Grade-Step for a EmployeePositionType or a Employment / PayHistory because 
> it's not same as legal "Structure Pay Schedule" (like "Convention collective, 
> salaire minimum par position" in France).
> In patch propose, add a field in form and in create service use it if not 
> empty



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12459) Cybersource - configuration

2021-12-17 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461457#comment-17461457
 ] 

Michael Brohl commented on OFBIZ-12459:
---

Wow, you spent a lot of energy for rants, false accusations and personal 
attacks instead of responding to the criticisms and proposed solutions.

That makes it hard to take you seriously.

> Cybersource - configuration
> ---
>
> Key: OFBIZ-12459
> URL: https://issues.apache.org/jira/browse/OFBIZ-12459
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: 3rdParty, cybersource, fintech, integration
>
> Move 3rd party Fintech integration configuration for Cybersource from 
> initialisation configuration to runtime configuration.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-11042) Allow to choose salaryStepSeqId when create a SalaryStep

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-11042:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Allow to choose salaryStepSeqId when create a SalaryStep
> 
>
> Key: OFBIZ-11042
> URL: https://issues.apache.org/jira/browse/OFBIZ-11042
> Project: OFBiz
>  Issue Type: Improvement
>  Components: humanres
>Affects Versions: Upcoming Branch
>Reporter: Olivier Heintz
>Priority: Major
>  Labels: humanres
> Fix For: Trunk
>
> Attachments: OFBIZ-11042.patch
>
>
> Comming from "The Data model Resource Book"
> {{«}} Salary Grade-Step are used in entreprise that have a predefined, highly 
> structure pay system (such as the federal government). This is done by 
> reference to a structure pay schedule.{{»}}
> Currently in OFBiz in HR in Global HR Settings, it's possible to choose 
> gradeId but not stepSeqId and so it's not readable when you want select a 
> Grade-Step for a EmployeePositionType or a Employment / PayHistory because 
> it's not same as legal "Structure Pay Schedule" (like "Convention collective, 
> salaire minimum par position" in France).
> In patch propose, add a field in form and in create service use it if not 
> empty



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-11044) EmplPositionType Rate and Grade better User interface

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-11044:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> EmplPositionType Rate and Grade better User interface
> -
>
> Key: OFBIZ-11044
> URL: https://issues.apache.org/jira/browse/OFBIZ-11044
> Project: OFBiz
>  Issue Type: Improvement
>  Components: humanres
>Affects Versions: Upcoming Branch
>Reporter: Olivier Heintz
>Priority: Minor
>  Labels: humanres
> Fix For: Upcoming Branch
>
> Attachments: 
> 0001-Improved-EmplPositionType-Rate-and-Grade-better-User.patch, 
> OFBIZ-11044.patch
>
>
> EmplPositionType can be associated with a Rate or a Grade-Step, look to 
> [Position Type - User 
> Manual|[https://ofbizextra.org/ofbizextra_adocs/docs/asciidoc/user-manual.html#_position_types].]
> Currently Rate and Grade-Step are on the same Form, I propose to split in two 
> form, one for Rate and one for Grade-Step.
> Sub enhancement, Grade and Step lookup don't work, corrections for this are 
> included



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-11044) EmplPositionType Rate and Grade better User interface

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-11044:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> EmplPositionType Rate and Grade better User interface
> -
>
> Key: OFBIZ-11044
> URL: https://issues.apache.org/jira/browse/OFBIZ-11044
> Project: OFBiz
>  Issue Type: Improvement
>  Components: humanres
>Affects Versions: Upcoming Branch
>Reporter: Olivier Heintz
>Priority: Minor
>  Labels: humanres
> Fix For: Trunk
>
> Attachments: 
> 0001-Improved-EmplPositionType-Rate-and-Grade-better-User.patch, 
> OFBIZ-11044.patch
>
>
> EmplPositionType can be associated with a Rate or a Grade-Step, look to 
> [Position Type - User 
> Manual|[https://ofbizextra.org/ofbizextra_adocs/docs/asciidoc/user-manual.html#_position_types].]
> Currently Rate and Grade-Step are on the same Form, I propose to split in two 
> form, one for Rate and one for Grade-Step.
> Sub enhancement, Grade and Step lookup don't work, corrections for this are 
> included



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-11046) add a HR Data model chapter

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-11046:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> add a HR Data model chapter
> ---
>
> Key: OFBIZ-11046
> URL: https://issues.apache.org/jira/browse/OFBIZ-11046
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: humanres
>Affects Versions: Upcoming Branch
>Reporter: Olivier Heintz
>Priority: Major
>  Labels: humanres
> Fix For: Trunk
>
> Attachments: EmplPosition.png, EmplPositionDetail.png, 
> Employment.png, EmploymentApp.png, OFBIZ_11046_humanres.adoc.patch, 
> PartyHumanRes.png, PerfReview.png, ability.png, hr-data-model.adoc
>
>
> Add some UML diagram about main HR entities.
> Each diagram contain not all associated entities but only one important to 
> have a first understanding about the main entity of the diagram.
> In the doc, each diagram is associated with some link to others diagram to 
> easily naviguate.
> This chapter could be included in hr-documentation just before hr-glossary



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-11046) add a HR Data model chapter

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-11046:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> add a HR Data model chapter
> ---
>
> Key: OFBIZ-11046
> URL: https://issues.apache.org/jira/browse/OFBIZ-11046
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: humanres
>Affects Versions: Upcoming Branch
>Reporter: Olivier Heintz
>Priority: Major
>  Labels: humanres
> Fix For: Upcoming Branch
>
> Attachments: EmplPosition.png, EmplPositionDetail.png, 
> Employment.png, EmploymentApp.png, OFBIZ_11046_humanres.adoc.patch, 
> PartyHumanRes.png, PerfReview.png, ability.png, hr-data-model.adoc
>
>
> Add some UML diagram about main HR entities.
> Each diagram contain not all associated entities but only one important to 
> have a first understanding about the main entity of the diagram.
> In the doc, each diagram is associated with some link to others diagram to 
> easily naviguate.
> This chapter could be included in hr-documentation just before hr-glossary



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-11222) Wrong heading on creating quote under Accounting-AP component.

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-11222:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Wrong heading on creating quote under Accounting-AP component.
> --
>
> Key: OFBIZ-11222
> URL: https://issues.apache.org/jira/browse/OFBIZ-11222
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Upcoming Branch
>Reporter: Pradyum Dharwa
>Assignee: Aditya Sharma
>Priority: Trivial
>  Labels: agreement(s)
> Fix For: Upcoming Branch
>
> Attachments: Accounting-ap.png, OFBIZ-11222.patch
>
>
> Steps to re-generate
>  # Logging with the correct username and password.
>  # Click on the Accounting Section.
>  # Click on Agreements section.
>  # Click on create new
> Error: Edit quote is shown on the place of edit quote/new quote .
> Actual: edit quote/new quote  should be shown on the place of edit quote



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-11222) Wrong heading on creating quote under Accounting-AP component.

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-11222:
--
Affects Version/s: Upcoming Branch

> Wrong heading on creating quote under Accounting-AP component.
> --
>
> Key: OFBIZ-11222
> URL: https://issues.apache.org/jira/browse/OFBIZ-11222
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Upcoming Branch, Trunk
>Reporter: Pradyum Dharwa
>Assignee: Aditya Sharma
>Priority: Trivial
>  Labels: agreement(s)
> Fix For: Trunk
>
> Attachments: Accounting-ap.png, OFBIZ-11222.patch
>
>
> Steps to re-generate
>  # Logging with the correct username and password.
>  # Click on the Accounting Section.
>  # Click on Agreements section.
>  # Click on create new
> Error: Edit quote is shown on the place of edit quote/new quote .
> Actual: edit quote/new quote  should be shown on the place of edit quote



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-11222) Wrong heading on creating quote under Accounting-AP component.

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-11222:
--
Affects Version/s: (was: Trunk)

> Wrong heading on creating quote under Accounting-AP component.
> --
>
> Key: OFBIZ-11222
> URL: https://issues.apache.org/jira/browse/OFBIZ-11222
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Upcoming Branch
>Reporter: Pradyum Dharwa
>Assignee: Aditya Sharma
>Priority: Trivial
>  Labels: agreement(s)
> Fix For: Trunk
>
> Attachments: Accounting-ap.png, OFBIZ-11222.patch
>
>
> Steps to re-generate
>  # Logging with the correct username and password.
>  # Click on the Accounting Section.
>  # Click on Agreements section.
>  # Click on create new
> Error: Edit quote is shown on the place of edit quote/new quote .
> Actual: edit quote/new quote  should be shown on the place of edit quote



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #421: Fixed: PriceRule - values of existing ProductPriceCond record not shown (OFBIZ-12467)

2021-12-17 Thread GitBox


sonarcloud[bot] commented on pull request #421:
URL: https://github.com/apache/ofbiz-framework/pull/421#issuecomment-996742999


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=421=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=421=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=421=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=421=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=421=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=421=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=421=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=421=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=421=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=421=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=421=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=421=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=421)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=421=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=421=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Updated] (OFBIZ-12244) Code clarity - separate Groovy implementations vs test cases in org.apache.ofbiz.order

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-12244:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Code clarity - separate Groovy implementations vs test cases in 
> org.apache.ofbiz.order
> --
>
> Key: OFBIZ-12244
> URL: https://issues.apache.org/jira/browse/OFBIZ-12244
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Upcoming Branch
>Reporter: Carsten Schinzer
>Assignee: Carsten Schinzer
>Priority: Minor
>  Labels: test
> Fix For: Upcoming Branch
>
> Attachments: ofbiz-12244.patch
>
>
> 1. File move:
> 1.a Create package org.apache.ofbiz.order.test in path 
> ofbiz-framework/applications/order/src/main
> 1.b Move the following files to the new package:
>  * OrderRequirementTests
>  * OrderReturnTests
>  * OrderTests
>  * QuoteTests
>  * TestCustRequestPermissionCheck
> 2. Apply attached patch



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12244) Code clarity - separate Groovy implementations vs test cases in org.apache.ofbiz.order

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-12244:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Code clarity - separate Groovy implementations vs test cases in 
> org.apache.ofbiz.order
> --
>
> Key: OFBIZ-12244
> URL: https://issues.apache.org/jira/browse/OFBIZ-12244
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Carsten Schinzer
>Assignee: Carsten Schinzer
>Priority: Minor
>  Labels: test
> Fix For: Upcoming Branch
>
> Attachments: ofbiz-12244.patch
>
>
> 1. File move:
> 1.a Create package org.apache.ofbiz.order.test in path 
> ofbiz-framework/applications/order/src/main
> 1.b Move the following files to the new package:
>  * OrderRequirementTests
>  * OrderReturnTests
>  * OrderTests
>  * QuoteTests
>  * TestCustRequestPermissionCheck
> 2. Apply attached patch



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #421: Fixed: PriceRule - values of existing ProductPriceCond record not shown (OFBIZ-12467)

2021-12-17 Thread GitBox


PierreSmits opened a new pull request #421:
URL: https://github.com/apache/ofbiz-framework/pull/421


   When a price rule is shown in the screen, the associated existing conditions 
are not shown in the overview for the conditions
   Modified: Priceforms.xml
   - changed grid 'EditProductPriceRulesCondition' list-name to reflect correct 
list


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #420: Fixed: Price Rules: Price rules configurations are not syncing with eCommerce storefront (OFBIZ-12450)

2021-12-17 Thread GitBox


sonarcloud[bot] commented on pull request #420:
URL: https://github.com/apache/ofbiz-framework/pull/420#issuecomment-996731418


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=420=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=420=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=420=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=420=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=420=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=420=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=420=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=420=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=420=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=420=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=420=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=420=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=420)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=420=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=420=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #420: Fixed: Price Rules: Price rules configurations are not syncing with eCommerce storefront (OFBIZ-12450)

2021-12-17 Thread GitBox


sonarcloud[bot] removed a comment on pull request #420:
URL: https://github.com/apache/ofbiz-framework/pull/420#issuecomment-996684460


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=420=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=420=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=420=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=420=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=420=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=420=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=420=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=420=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=420=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=420=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=420=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=420=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=420)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=420=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=420=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (OFBIZ-12467) PriceRule - values of existing ProductPriceCond record not shown

2021-12-17 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-12467:


 Summary: PriceRule - values of existing ProductPriceCond record 
not shown
 Key: OFBIZ-12467
 URL: https://issues.apache.org/jira/browse/OFBIZ-12467
 Project: OFBiz
  Issue Type: Bug
  Components: product/catalog
Affects Versions: Trunk
Reporter: Pierre Smits
Assignee: Pierre Smits


When a price rule is shown in the screen, the associated existing conditions 
are not shown in the overview for the conditions



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12466) Solr generates an error

2021-12-17 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461430#comment-17461430
 ] 

Pierre Smits commented on OFBIZ-12466:
--

Tja

I remember having it brought up before (here in Jira, somewhere else), but 
would it not be smart to integrate both lucence and solr extensions into one? 
Solr uses lucence, and it seems that the redundant parts makes us having to 
maintain both

> Solr generates an error
> ---
>
> Key: OFBIZ-12466
> URL: https://issues.apache.org/jira/browse/OFBIZ-12466
> Project: OFBiz
>  Issue Type: Bug
>  Components: solr
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Major
>
> Following error is shown:
> {code:java}
> 2021-12-17 12:45:37,676 |main                 |SolrDispatchFilter            
> |E| Could not start Solr. Check solr/home property and the logs
> 2021-12-17 12:45:37,707 |main                 |SolrCore                      
> |E| null:java.lang.NoClassDefFoundError: Could not initialize class 
> org.slf4j.impl.StaticLoggerBinder
>   at 
> org.apache.solr.util.StartupLoggingUtils.(StartupLoggingUtils.java:45)
>   at 
> org.apache.solr.servlet.SolrDispatchFilter.init(SolrDispatchFilter.java:158)
>   at 
> org.apache.ofbiz.solr.webapp.OFBizSolrContextFilter.init(OFBizSolrContextFilter.java:100)
>   at 
> org.apache.catalina.core.ApplicationFilterConfig.initFilter(ApplicationFilterConfig.java:270)
>   at 
> org.apache.catalina.core.ApplicationFilterConfig.getFilter(ApplicationFilterConfig.java:251)
>   at 
> org.apache.catalina.core.ApplicationFilterConfig.(ApplicationFilterConfig.java:101)
>   at 
> org.apache.catalina.core.StandardContext.filterStart(StandardContext.java:4613)
>   at 
> org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5256)
>   at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>   at 
> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1396)
>   at 
> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1386)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
>   at 
> java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:134)
>   at 
> org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:919)
>   at 
> org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:835)
>   at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>   at 
> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1396)
>   at 
> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1386)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
>   at 
> java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:134)
>   at 
> org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:919)
>   at 
> org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:263)
>   at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>   at 
> org.apache.catalina.core.StandardService.startInternal(StandardService.java:432)
>   at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>   at 
> org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:927)
>   at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>   at org.apache.catalina.startup.Tomcat.start(Tomcat.java:486)
>   at 
> org.apache.ofbiz.catalina.container.CatalinaContainer.start(CatalinaContainer.java:134)
>   at 
> org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:153)
>   at 
> org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:77)
>   at 
> org.apache.ofbiz.base.start.StartupControlPanel.loadContainers(StartupControlPanel.java:146)
>   at 
> org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:70)
>   at org.apache.ofbiz.base.start.Start.main(Start.java:89)
> Dec 17, 2021 12:45:37 PM org.apache.catalina.core.StandardContext filterStart
> SEVERE: Exception starting filter [SolrFilter]
> java.lang.NoClassDefFoundError: Could not initialize class 
> org.slf4j.impl.StaticLoggerBinder
>   at 
> org.apache.solr.util.StartupLoggingUtils.(StartupLoggingUtils.java:45)
>   at 
> org.apache.solr.servlet.SolrDispatchFilter.init(SolrDispatchFilter.java:158)
>   at 
> 

[jira] [Commented] (OFBIZ-12466) Solr generates an error

2021-12-17 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461429#comment-17461429
 ] 

Jacques Le Roux commented on OFBIZ-12466:
-

Finally I now use artifact-listener.org

> Solr generates an error
> ---
>
> Key: OFBIZ-12466
> URL: https://issues.apache.org/jira/browse/OFBIZ-12466
> Project: OFBiz
>  Issue Type: Bug
>  Components: solr
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Major
>
> Following error is shown:
> {code:java}
> 2021-12-17 12:45:37,676 |main                 |SolrDispatchFilter            
> |E| Could not start Solr. Check solr/home property and the logs
> 2021-12-17 12:45:37,707 |main                 |SolrCore                      
> |E| null:java.lang.NoClassDefFoundError: Could not initialize class 
> org.slf4j.impl.StaticLoggerBinder
>   at 
> org.apache.solr.util.StartupLoggingUtils.(StartupLoggingUtils.java:45)
>   at 
> org.apache.solr.servlet.SolrDispatchFilter.init(SolrDispatchFilter.java:158)
>   at 
> org.apache.ofbiz.solr.webapp.OFBizSolrContextFilter.init(OFBizSolrContextFilter.java:100)
>   at 
> org.apache.catalina.core.ApplicationFilterConfig.initFilter(ApplicationFilterConfig.java:270)
>   at 
> org.apache.catalina.core.ApplicationFilterConfig.getFilter(ApplicationFilterConfig.java:251)
>   at 
> org.apache.catalina.core.ApplicationFilterConfig.(ApplicationFilterConfig.java:101)
>   at 
> org.apache.catalina.core.StandardContext.filterStart(StandardContext.java:4613)
>   at 
> org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5256)
>   at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>   at 
> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1396)
>   at 
> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1386)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
>   at 
> java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:134)
>   at 
> org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:919)
>   at 
> org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:835)
>   at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>   at 
> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1396)
>   at 
> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1386)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
>   at 
> java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:134)
>   at 
> org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:919)
>   at 
> org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:263)
>   at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>   at 
> org.apache.catalina.core.StandardService.startInternal(StandardService.java:432)
>   at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>   at 
> org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:927)
>   at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>   at org.apache.catalina.startup.Tomcat.start(Tomcat.java:486)
>   at 
> org.apache.ofbiz.catalina.container.CatalinaContainer.start(CatalinaContainer.java:134)
>   at 
> org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:153)
>   at 
> org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:77)
>   at 
> org.apache.ofbiz.base.start.StartupControlPanel.loadContainers(StartupControlPanel.java:146)
>   at 
> org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:70)
>   at org.apache.ofbiz.base.start.Start.main(Start.java:89)
> Dec 17, 2021 12:45:37 PM org.apache.catalina.core.StandardContext filterStart
> SEVERE: Exception starting filter [SolrFilter]
> java.lang.NoClassDefFoundError: Could not initialize class 
> org.slf4j.impl.StaticLoggerBinder
>   at 
> org.apache.solr.util.StartupLoggingUtils.(StartupLoggingUtils.java:45)
>   at 
> org.apache.solr.servlet.SolrDispatchFilter.init(SolrDispatchFilter.java:158)
>   at 
> org.apache.ofbiz.solr.webapp.OFBizSolrContextFilter.init(OFBizSolrContextFilter.java:100)
>   at 
> org.apache.catalina.core.ApplicationFilterConfig.initFilter(ApplicationFilterConfig.java:270)
>   at 
> 

[jira] [Commented] (OFBIZ-12466) Solr generates an error

2021-12-17 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461425#comment-17461425
 ] 

Jacques Le Roux commented on OFBIZ-12466:
-

I (manually) "monitor" both on Maven. If it's late I'll use that: 
https://www.artifact-listener.org/. And yes we need both at same version. I 
wait for Tika too...

> Solr generates an error
> ---
>
> Key: OFBIZ-12466
> URL: https://issues.apache.org/jira/browse/OFBIZ-12466
> Project: OFBiz
>  Issue Type: Bug
>  Components: solr
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Major
>
> Following error is shown:
> {code:java}
> 2021-12-17 12:45:37,676 |main                 |SolrDispatchFilter            
> |E| Could not start Solr. Check solr/home property and the logs
> 2021-12-17 12:45:37,707 |main                 |SolrCore                      
> |E| null:java.lang.NoClassDefFoundError: Could not initialize class 
> org.slf4j.impl.StaticLoggerBinder
>   at 
> org.apache.solr.util.StartupLoggingUtils.(StartupLoggingUtils.java:45)
>   at 
> org.apache.solr.servlet.SolrDispatchFilter.init(SolrDispatchFilter.java:158)
>   at 
> org.apache.ofbiz.solr.webapp.OFBizSolrContextFilter.init(OFBizSolrContextFilter.java:100)
>   at 
> org.apache.catalina.core.ApplicationFilterConfig.initFilter(ApplicationFilterConfig.java:270)
>   at 
> org.apache.catalina.core.ApplicationFilterConfig.getFilter(ApplicationFilterConfig.java:251)
>   at 
> org.apache.catalina.core.ApplicationFilterConfig.(ApplicationFilterConfig.java:101)
>   at 
> org.apache.catalina.core.StandardContext.filterStart(StandardContext.java:4613)
>   at 
> org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5256)
>   at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>   at 
> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1396)
>   at 
> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1386)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
>   at 
> java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:134)
>   at 
> org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:919)
>   at 
> org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:835)
>   at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>   at 
> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1396)
>   at 
> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1386)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
>   at 
> java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:134)
>   at 
> org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:919)
>   at 
> org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:263)
>   at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>   at 
> org.apache.catalina.core.StandardService.startInternal(StandardService.java:432)
>   at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>   at 
> org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:927)
>   at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>   at org.apache.catalina.startup.Tomcat.start(Tomcat.java:486)
>   at 
> org.apache.ofbiz.catalina.container.CatalinaContainer.start(CatalinaContainer.java:134)
>   at 
> org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:153)
>   at 
> org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:77)
>   at 
> org.apache.ofbiz.base.start.StartupControlPanel.loadContainers(StartupControlPanel.java:146)
>   at 
> org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:70)
>   at org.apache.ofbiz.base.start.Start.main(Start.java:89)
> Dec 17, 2021 12:45:37 PM org.apache.catalina.core.StandardContext filterStart
> SEVERE: Exception starting filter [SolrFilter]
> java.lang.NoClassDefFoundError: Could not initialize class 
> org.slf4j.impl.StaticLoggerBinder
>   at 
> org.apache.solr.util.StartupLoggingUtils.(StartupLoggingUtils.java:45)
>   at 
> org.apache.solr.servlet.SolrDispatchFilter.init(SolrDispatchFilter.java:158)
>   at 
> org.apache.ofbiz.solr.webapp.OFBizSolrContextFilter.init(OFBizSolrContextFilter.java:100)
>   at 
> 

[jira] [Updated] (OFBIZ-12450) Price Rules: Price rules configurations are not syncing with eCommerce storefront

2021-12-17 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-12450:
-
Labels: price-rule user-experience  (was: user-experience)

> Price Rules: Price rules configurations are not syncing with eCommerce 
> storefront
> -
>
> Key: OFBIZ-12450
> URL: https://issues.apache.org/jira/browse/OFBIZ-12450
> Project: OFBiz
>  Issue Type: Bug
>  Components: product/catalog
>Affects Versions: Trunk
>Reporter: Justine Nowak
>Assignee: Pierre Smits
>Priority: Critical
>  Labels: price-rule, user-experience
>
> When adding a Price Rule, whether it be a Product Category, Product, Party, 
> Party Classification, the system doesn't show a price difference.
> The price rules work with the Database as they do get changed when saved. But 
> their functionality doesn't work, it won't give a price increase or decrease 
> or restriction.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12450) Price Rules: Price rules configurations are not syncing with eCommerce storefront

2021-12-17 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461412#comment-17461412
 ] 

Pierre Smits commented on OFBIZ-12450:
--

Additional observations:
 * function 'makeProducePriceRuleList' is used in function 
'calculateProductPrice'
 * function 'calculateProductPrice' is used in 
 ** service 'calculateProductPrice' in services_pricePromo.xml
 * service 'calculateProductPrice' is used in the ecommerce component in:
 ** MiniProductSummary.groovy
 ** EditShoppingList.groovy

> Price Rules: Price rules configurations are not syncing with eCommerce 
> storefront
> -
>
> Key: OFBIZ-12450
> URL: https://issues.apache.org/jira/browse/OFBIZ-12450
> Project: OFBiz
>  Issue Type: Bug
>  Components: product/catalog
>Affects Versions: Trunk
>Reporter: Justine Nowak
>Assignee: Pierre Smits
>Priority: Critical
>  Labels: user-experience
>
> When adding a Price Rule, whether it be a Product Category, Product, Party, 
> Party Classification, the system doesn't show a price difference.
> The price rules work with the Database as they do get changed when saved. But 
> their functionality doesn't work, it won't give a price increase or decrease 
> or restriction.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #420: Fixed: Price Rules: Price rules configurations are not syncing with e…

2021-12-17 Thread GitBox


sonarcloud[bot] commented on pull request #420:
URL: https://github.com/apache/ofbiz-framework/pull/420#issuecomment-996684460


   Kudos, SonarCloud Quality Gate passed!  ![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate passed')
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=420=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=420=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=420=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=420=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=420=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=420=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=420=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=420=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=420=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=420=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=420=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=420=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=420)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=420=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=420=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #420: Fixed: Price Rules: Price rules configurations are not syncing with e…

2021-12-17 Thread GitBox


PierreSmits opened a new pull request #420:
URL: https://github.com/apache/ofbiz-framework/pull/420


   …Commerce storefront (OFBIZ-12450)
   
   When adding a Price Rule, whether it be a Product Category, Product, Party, 
Party Classification, the system doesn't show a price difference.
   The price rules work with the Database as they do get changed when saved. 
But their functionality doesn't work, it won't give a price increase or 
decrease or restriction.
   
   Modified:
   Various data files to enhance demonstration of price rule functionality


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-12466) Solr generates an error

2021-12-17 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461402#comment-17461402
 ] 

Pierre Smits commented on OFBIZ-12466:
--

Hi Jacques,

Thanks for the reaction.

Looking at [https://github.com/apache/solr/commits/main,] I see that yesterday 
the Sole team committed changes to the repo regarding 8.11.1. So we just have 
to monitor that repo (and maven central ?) to see that changes come through. 

I guess, the combo of Lucene and Solr extensions in the plugins repo makes this 
harder for us. Correct?

> Solr generates an error
> ---
>
> Key: OFBIZ-12466
> URL: https://issues.apache.org/jira/browse/OFBIZ-12466
> Project: OFBiz
>  Issue Type: Bug
>  Components: solr
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Major
>
> Following error is shown:
> {code:java}
> 2021-12-17 12:45:37,676 |main                 |SolrDispatchFilter            
> |E| Could not start Solr. Check solr/home property and the logs
> 2021-12-17 12:45:37,707 |main                 |SolrCore                      
> |E| null:java.lang.NoClassDefFoundError: Could not initialize class 
> org.slf4j.impl.StaticLoggerBinder
>   at 
> org.apache.solr.util.StartupLoggingUtils.(StartupLoggingUtils.java:45)
>   at 
> org.apache.solr.servlet.SolrDispatchFilter.init(SolrDispatchFilter.java:158)
>   at 
> org.apache.ofbiz.solr.webapp.OFBizSolrContextFilter.init(OFBizSolrContextFilter.java:100)
>   at 
> org.apache.catalina.core.ApplicationFilterConfig.initFilter(ApplicationFilterConfig.java:270)
>   at 
> org.apache.catalina.core.ApplicationFilterConfig.getFilter(ApplicationFilterConfig.java:251)
>   at 
> org.apache.catalina.core.ApplicationFilterConfig.(ApplicationFilterConfig.java:101)
>   at 
> org.apache.catalina.core.StandardContext.filterStart(StandardContext.java:4613)
>   at 
> org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5256)
>   at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>   at 
> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1396)
>   at 
> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1386)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
>   at 
> java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:134)
>   at 
> org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:919)
>   at 
> org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:835)
>   at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>   at 
> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1396)
>   at 
> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1386)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
>   at 
> java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:134)
>   at 
> org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:919)
>   at 
> org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:263)
>   at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>   at 
> org.apache.catalina.core.StandardService.startInternal(StandardService.java:432)
>   at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>   at 
> org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:927)
>   at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>   at org.apache.catalina.startup.Tomcat.start(Tomcat.java:486)
>   at 
> org.apache.ofbiz.catalina.container.CatalinaContainer.start(CatalinaContainer.java:134)
>   at 
> org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:153)
>   at 
> org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:77)
>   at 
> org.apache.ofbiz.base.start.StartupControlPanel.loadContainers(StartupControlPanel.java:146)
>   at 
> org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:70)
>   at org.apache.ofbiz.base.start.Start.main(Start.java:89)
> Dec 17, 2021 12:45:37 PM org.apache.catalina.core.StandardContext filterStart
> SEVERE: Exception starting filter [SolrFilter]
> java.lang.NoClassDefFoundError: Could not initialize class 
> org.slf4j.impl.StaticLoggerBinder
>   at 
> org.apache.solr.util.StartupLoggingUtils.(StartupLoggingUtils.java:45)
>   at 
> 

[jira] [Commented] (OFBIZ-12450) Price Rules: Price rules configurations are not syncing with eCommerce storefront

2021-12-17 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461395#comment-17461395
 ] 

Pierre Smits commented on OFBIZ-12450:
--

There is also a 'getAssociatedPriceRulesConds' in PriceServices.groovy that 
does something with a price rule for the aforementioned conditions.

> Price Rules: Price rules configurations are not syncing with eCommerce 
> storefront
> -
>
> Key: OFBIZ-12450
> URL: https://issues.apache.org/jira/browse/OFBIZ-12450
> Project: OFBiz
>  Issue Type: Bug
>  Components: product/catalog
>Affects Versions: Trunk
>Reporter: Justine Nowak
>Assignee: Pierre Smits
>Priority: Critical
>  Labels: user-experience
>
> When adding a Price Rule, whether it be a Product Category, Product, Party, 
> Party Classification, the system doesn't show a price difference.
> The price rules work with the Database as they do get changed when saved. But 
> their functionality doesn't work, it won't give a price increase or decrease 
> or restriction.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12466) Solr generates an error

2021-12-17 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461397#comment-17461397
 ] 

Jacques Le Roux commented on OFBIZ-12466:
-

Thanks Pierre,

This is waiting for Solr-core 8.11.1 on Maven: 
https://solr.apache.org/security.html#apache-solr-affected-by-apache-log4j-cve-2021-44228

BTW Lucene must be synced in OFBiz (same version) and it's not clear yet:
https://mvnrepository.com/artifact/org.apache.solr/solr-core
https://mvnrepository.com/artifact/org.apache.lucene/lucene-core

> Solr generates an error
> ---
>
> Key: OFBIZ-12466
> URL: https://issues.apache.org/jira/browse/OFBIZ-12466
> Project: OFBiz
>  Issue Type: Bug
>  Components: solr
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Major
>
> Following error is shown:
> {code:java}
> 2021-12-17 12:45:37,676 |main                 |SolrDispatchFilter            
> |E| Could not start Solr. Check solr/home property and the logs
> 2021-12-17 12:45:37,707 |main                 |SolrCore                      
> |E| null:java.lang.NoClassDefFoundError: Could not initialize class 
> org.slf4j.impl.StaticLoggerBinder
>   at 
> org.apache.solr.util.StartupLoggingUtils.(StartupLoggingUtils.java:45)
>   at 
> org.apache.solr.servlet.SolrDispatchFilter.init(SolrDispatchFilter.java:158)
>   at 
> org.apache.ofbiz.solr.webapp.OFBizSolrContextFilter.init(OFBizSolrContextFilter.java:100)
>   at 
> org.apache.catalina.core.ApplicationFilterConfig.initFilter(ApplicationFilterConfig.java:270)
>   at 
> org.apache.catalina.core.ApplicationFilterConfig.getFilter(ApplicationFilterConfig.java:251)
>   at 
> org.apache.catalina.core.ApplicationFilterConfig.(ApplicationFilterConfig.java:101)
>   at 
> org.apache.catalina.core.StandardContext.filterStart(StandardContext.java:4613)
>   at 
> org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5256)
>   at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>   at 
> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1396)
>   at 
> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1386)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
>   at 
> java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:134)
>   at 
> org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:919)
>   at 
> org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:835)
>   at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>   at 
> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1396)
>   at 
> org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1386)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
>   at 
> java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:134)
>   at 
> org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:919)
>   at 
> org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:263)
>   at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>   at 
> org.apache.catalina.core.StandardService.startInternal(StandardService.java:432)
>   at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>   at 
> org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:927)
>   at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
>   at org.apache.catalina.startup.Tomcat.start(Tomcat.java:486)
>   at 
> org.apache.ofbiz.catalina.container.CatalinaContainer.start(CatalinaContainer.java:134)
>   at 
> org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:153)
>   at 
> org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:77)
>   at 
> org.apache.ofbiz.base.start.StartupControlPanel.loadContainers(StartupControlPanel.java:146)
>   at 
> org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:70)
>   at org.apache.ofbiz.base.start.Start.main(Start.java:89)
> Dec 17, 2021 12:45:37 PM org.apache.catalina.core.StandardContext filterStart
> SEVERE: Exception starting filter [SolrFilter]
> java.lang.NoClassDefFoundError: Could not initialize class 
> org.slf4j.impl.StaticLoggerBinder
>   at 
> org.apache.solr.util.StartupLoggingUtils.(StartupLoggingUtils.java:45)
>   at 
> 

[jira] [Comment Edited] (OFBIZ-12450) Price Rules: Price rules configurations are not syncing with eCommerce storefront

2021-12-17 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461321#comment-17461321
 ] 

Pierre Smits edited comment on OFBIZ-12450 at 12/17/21, 12:03 PM:
--

Price calculations working with price rules is done through PriceServices.java 
in function makeProducePriceRuleList

According to the code price calculations should work for following conditions 
(as referenced in the description):
 * Product Category (productCateogryId
 * Product Id (both productId and pvirtualProductId)
 * Party (partyId)

And there are others referenced (based on records in the Enumeration table with 
enumTypeId="PROD_PRICE_IN_PARAM")


was (Author: pfm.smits):
Price calculations working with price rules is done through PriceServices.java

According to the code price calculations should work for following conditions 
(as referenced in the description):
 * Product Category (productCateogryId
 * Product Id (both productId and pvirtualProductId)
 * Party (partyId)

And there are others referenced (based on records in the Enumeration table with 
enumTypeId="PROD_PRICE_IN_PARAM")

> Price Rules: Price rules configurations are not syncing with eCommerce 
> storefront
> -
>
> Key: OFBIZ-12450
> URL: https://issues.apache.org/jira/browse/OFBIZ-12450
> Project: OFBiz
>  Issue Type: Bug
>  Components: product/catalog
>Affects Versions: Trunk
>Reporter: Justine Nowak
>Assignee: Pierre Smits
>Priority: Critical
>  Labels: user-experience
>
> When adding a Price Rule, whether it be a Product Category, Product, Party, 
> Party Classification, the system doesn't show a price difference.
> The price rules work with the Database as they do get changed when saved. But 
> their functionality doesn't work, it won't give a price increase or decrease 
> or restriction.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12450) Price Rules: Price rules configurations are not syncing with eCommerce storefront

2021-12-17 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-12450:
-
Description: 
When adding a Price Rule, whether it be a Product Category, Product, Party, 
Party Classification, the system doesn't show a price difference.

The price rules work with the Database as they do get changed when saved. But 
their functionality doesn't work, it won't give a price increase or decrease or 
restriction.

  was:
When adding a Price Rule, whether it be a Product Category, Product, Party, 
Party Classification, the system doesn't show a price difference.

 

The price rules work with the Database as they do get changed when saved. But 
their functionality doesn't work, it won't give a price increase or decrease or 
restriction.


> Price Rules: Price rules configurations are not syncing with eCommerce 
> storefront
> -
>
> Key: OFBIZ-12450
> URL: https://issues.apache.org/jira/browse/OFBIZ-12450
> Project: OFBiz
>  Issue Type: Bug
>  Components: product/catalog
>Affects Versions: Trunk
>Reporter: Justine Nowak
>Assignee: Pierre Smits
>Priority: Critical
>  Labels: user-experience
>
> When adding a Price Rule, whether it be a Product Category, Product, Party, 
> Party Classification, the system doesn't show a price difference.
> The price rules work with the Database as they do get changed when saved. But 
> their functionality doesn't work, it won't give a price increase or decrease 
> or restriction.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12450) Price Rules: Price rules configurations are not syncing with eCommerce storefront

2021-12-17 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461385#comment-17461385
 ] 

Pierre Smits commented on OFBIZ-12450:
--

Is a bit hard to demonstrate without proper data in our datasets.

> Price Rules: Price rules configurations are not syncing with eCommerce 
> storefront
> -
>
> Key: OFBIZ-12450
> URL: https://issues.apache.org/jira/browse/OFBIZ-12450
> Project: OFBiz
>  Issue Type: Bug
>  Components: product/catalog
>Affects Versions: Trunk
>Reporter: Justine Nowak
>Assignee: Pierre Smits
>Priority: Critical
>  Labels: user-experience
>
> When adding a Price Rule, whether it be a Product Category, Product, Party, 
> Party Classification, the system doesn't show a price difference.
>  
> The price rules work with the Database as they do get changed when saved. But 
> their functionality doesn't work, it won't give a price increase or decrease 
> or restriction.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Created] (OFBIZ-12466) Solr generates an error

2021-12-17 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-12466:


 Summary: Solr generates an error
 Key: OFBIZ-12466
 URL: https://issues.apache.org/jira/browse/OFBIZ-12466
 Project: OFBiz
  Issue Type: Bug
  Components: solr
Affects Versions: Trunk
Reporter: Pierre Smits


Following error is shown:
{code:java}
2021-12-17 12:45:37,676 |main                 |SolrDispatchFilter            
|E| Could not start Solr. Check solr/home property and the logs
2021-12-17 12:45:37,707 |main                 |SolrCore                      
|E| null:java.lang.NoClassDefFoundError: Could not initialize class 
org.slf4j.impl.StaticLoggerBinder
at 
org.apache.solr.util.StartupLoggingUtils.(StartupLoggingUtils.java:45)
at 
org.apache.solr.servlet.SolrDispatchFilter.init(SolrDispatchFilter.java:158)
at 
org.apache.ofbiz.solr.webapp.OFBizSolrContextFilter.init(OFBizSolrContextFilter.java:100)
at 
org.apache.catalina.core.ApplicationFilterConfig.initFilter(ApplicationFilterConfig.java:270)
at 
org.apache.catalina.core.ApplicationFilterConfig.getFilter(ApplicationFilterConfig.java:251)
at 
org.apache.catalina.core.ApplicationFilterConfig.(ApplicationFilterConfig.java:101)
at 
org.apache.catalina.core.StandardContext.filterStart(StandardContext.java:4613)
at 
org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5256)
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
at 
org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1396)
at 
org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1386)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
at 
java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:134)
at 
org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:919)
at 
org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:835)
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
at 
org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1396)
at 
org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1386)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
at 
java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:134)
at 
org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:919)
at 
org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:263)
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
at 
org.apache.catalina.core.StandardService.startInternal(StandardService.java:432)
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
at 
org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:927)
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
at org.apache.catalina.startup.Tomcat.start(Tomcat.java:486)
at 
org.apache.ofbiz.catalina.container.CatalinaContainer.start(CatalinaContainer.java:134)
at 
org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:153)
at 
org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:77)
at 
org.apache.ofbiz.base.start.StartupControlPanel.loadContainers(StartupControlPanel.java:146)
at 
org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:70)
at org.apache.ofbiz.base.start.Start.main(Start.java:89)


Dec 17, 2021 12:45:37 PM org.apache.catalina.core.StandardContext filterStart
SEVERE: Exception starting filter [SolrFilter]
java.lang.NoClassDefFoundError: Could not initialize class 
org.slf4j.impl.StaticLoggerBinder
at 
org.apache.solr.util.StartupLoggingUtils.(StartupLoggingUtils.java:45)
at 
org.apache.solr.servlet.SolrDispatchFilter.init(SolrDispatchFilter.java:158)
at 
org.apache.ofbiz.solr.webapp.OFBizSolrContextFilter.init(OFBizSolrContextFilter.java:100)
at 
org.apache.catalina.core.ApplicationFilterConfig.initFilter(ApplicationFilterConfig.java:270)
at 
org.apache.catalina.core.ApplicationFilterConfig.getFilter(ApplicationFilterConfig.java:251)
at 
org.apache.catalina.core.ApplicationFilterConfig.(ApplicationFilterConfig.java:101)
at 
org.apache.catalina.core.StandardContext.filterStart(StandardContext.java:4613)
at 
org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5256)
at 

[GitHub] [ofbiz-framework] PierreSmits commented on pull request #354: Improved: Upgrade to gradle 7.3 to support jdk 17 (OFBIZ-12400)

2021-12-17 Thread GitBox


PierreSmits commented on pull request #354:
URL: https://github.com/apache/ofbiz-framework/pull/354#issuecomment-996655615


   HI Ioan,
   
   I like it too, and am not worried about the argument regarding 'introduce 
regressions or cut features during the upgrade' without proof being provided, 
or the argument regarding (unknown) users relying on this second class feature 
of OFBiz
   
   However, may I suggest that you update the title, description and/or 
environment of the associated ticket? As you commented there about version 7.3 
supporting also current JVM (8) and intermediate (11). The title of the ticket 
is what shows up in the release notes of a future release.
   
   +1 for merging this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-12459) Cybersource - configuration

2021-12-17 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17461369#comment-17461369
 ] 

Pierre Smits commented on OFBIZ-12459:
--

[~mbrohl] 

Switching over to using SystemProperty records for runtime configuration is an 
ongoing effort since it was introduced way back when in 2012, effected by 
contributors of all kinds. Never before somewhere in 2018, in your 20 years of 
history with OFBiz (or even the 15 years of this project being part of the ASF) 
have you 'collaborated' on this subject. And even when you started providing 
comments/suggestions to the subject, you couldn't convince the community to 
change directions.

Here, elsewhere, you keep circling back, or referring to creating a mess for 
users. But the thing is that by insisting (like you do) on not moving forward 
you perpetuate the mess. Not only regarding this aspects, but others as well. 

A while back I advised you to read the header of OFBiz code files. Apparently 
you did not learn anything from those files, still thinking that the project 
must ensure any kind of compatibility.
You claim to know what OFBiz users want/need from the project. I suggest you 
wake up. You're no OFBiz user! And what you know about what OFBiz users 
wanted/needed is from the limited few that paid you regarding the 
implementations you worked on. 

You talk about destroying trust? You made me both cringe and laugh when you 
mentioned that.  In an other ticket discussion, you insist on not improving 
just that trust by rejecting that fields like createdByUserLogin and 
modifiedByUserLogin should be part of the metadata fields automatically added 
and populated. Fields that are included in every piece of serious software 
(like SalesForce, Microsoft Dynamics 365, SAP, etc.).

If you're so dissatisfied about the direction of the project, I suggest you 
follow the route other (privileged) contributors embarked on and start working 
on and  promoting your own derivative. 
And, if you're dissatisfied with how contributors react to your kind of 
collaboration I suggest you take a hard look at your own actions and [those 
tickets | 
https://issues.apache.org/jira/issues/?jql=project%20%3D%20OFBIZ%20AND%20resolution%20%3D%20Unresolved%20AND%20assignee%20in%20(mbrohl)%20ORDER%20BY%20updated%20DESC]
 you're 'collaborating on'.

I appreciate suggestions, but nowhere is it stated that any other contributor 
(or I) *must* follow that, or adhere your kind of collaboration, blindly.
I object to your kind of collaboration. I reject your kind of collaboration. 
Your kind of collaboration moves (contributions to) the project to a grinding 
halt. You can't even seem to able to collaborate with the contributors from 
your own company to get their contributions to move the project forward.
I rather have you 'collaborate' similarly to the dozens of other privileged 
contributors than you injecting your unwanted kind of collaboration into 
tickets.

So you ask yourself what else can you do...
Here are a few suggestions (how you can adjust your kind of collaborating for 
the good of the project, its users and its contributors):
 * go 'collaborate' with someone else, and stop stalking me,
 * go take any of the tickets you have assigned yourself to and work those to a 
satisfactory resolution, instead of 'managing' the status,
 * go take any PR that is good enough and merge that into the code base,
 * go take any other open ticket and work that to a satisfactory resolution,
 * go take any Confluence page that is WIP and work that to an acceptable level.

> Cybersource - configuration
> ---
>
> Key: OFBIZ-12459
> URL: https://issues.apache.org/jira/browse/OFBIZ-12459
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: 3rdParty, cybersource, fintech, integration
>
> Move 3rd party Fintech integration configuration for Cybersource from 
> initialisation configuration to runtime configuration.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


  1   2   >