[jira] [Closed] (OFBIZ-12654) Add sequenceNum on contentAssoc list

2022-07-01 Thread Nicolas Malin (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin closed OFBIZ-12654.
-
Fix Version/s: (was: Upcoming Branch)
   Resolution: Done

It's loaded on trunk, thanks

> Add sequenceNum on contentAssoc list
> 
>
> Key: OFBIZ-12654
> URL: https://issues.apache.org/jira/browse/OFBIZ-12654
> Project: OFBiz
>  Issue Type: Improvement
>  Components: content
>Affects Versions: Upcoming Branch
>Reporter: Ingo Wolfmayr
>Assignee: Nicolas Malin
>Priority: Trivial
> Attachments: ContentAssocSeq.patch
>
>
> It would be sometimes quite helpful if the sequence number is displayed on 
> the ContentAssoc List widget.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12654) Add sequenceNum on contentAssoc list

2022-07-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561549#comment-17561549
 ] 

ASF subversion and git services commented on OFBIZ-12654:
-

Commit 8ee85ec3906197fb50c26445c0ec928ad49fc623 in ofbiz-framework's branch 
refs/heads/trunk from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=8ee85ec390 ]

Improved: Add sequenceNum field on contentAssoc list (OFBIZ-12654)

By the way, clean unnecessary code and change groovy scripting call by the 
native date translation

Thanks to Ingo Wolfmayr for this issue


> Add sequenceNum on contentAssoc list
> 
>
> Key: OFBIZ-12654
> URL: https://issues.apache.org/jira/browse/OFBIZ-12654
> Project: OFBiz
>  Issue Type: Improvement
>  Components: content
>Affects Versions: Upcoming Branch
>Reporter: Ingo Wolfmayr
>Assignee: Nicolas Malin
>Priority: Trivial
> Fix For: Upcoming Branch
>
> Attachments: ContentAssocSeq.patch
>
>
> It would be sometimes quite helpful if the sequence number is displayed on 
> the ContentAssoc List widget.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" is working again!

2022-07-01 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has 
succeeded.
Run started by GitHub user nmalin (triggered by nmalin).

Head commit for run:
576307ac5ce1a830c52abbed0bc0ea22a612a368 / Nicolas Malin 

Improved: Add missing parameter on xsd for 
widget-form:on-field-event-update-area (OFBIZ-12586)

On the widget-form.xsd definition, the element on-field-event-update-area 
haven't possibility to define some parameters.

But on java code, the on-field-event-update-area is read like 
on-event-update-area.

If you put some parameters on your code, your editor raise a syntax error but 
OFBiz analyse and execute it well.








By the way we can synchronize the on-field-event-update-area xsd on 
on-event-update-area.

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/2597915068

With regards,
GitHub Actions via GitBox



[jira] [Updated] (OFBIZ-12586) Add missing parameter on xsd for widget-form:on-field-event-update-area

2022-07-01 Thread Nicolas Malin (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin updated OFBIZ-12586:
--
Affects Version/s: (was: 18.12.06)

> Add missing parameter on xsd for widget-form:on-field-event-update-area
> ---
>
> Key: OFBIZ-12586
> URL: https://issues.apache.org/jira/browse/OFBIZ-12586
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/widget
>Affects Versions: 22.01.01, Upcoming Branch
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Trivial
> Fix For: 22.01.01
>
> Attachments: OFBIZ-12586.patch
>
>
> On the widget-form.xsd definition, the element on-field-event-update-area 
> haven't possibility to define some parameters.
> But on java code, the on-field-event-update-area is read like 
> on-event-update-area.
> If you put some parameters on your code, your editor raise a syntax error but 
> OFBiz analyse and execute it well.
> {code:java}
>             
>                 
>                                                             area-target="ReloadIt">
>                      service-name="computeForReload" send-if-empty="false"/>
>                 
>             
> {code}
> By the way we can synchronize the on-field-event-update-area xsd on 
> on-event-update-area.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-12586) Add missing parameter on xsd for widget-form:on-field-event-update-area

2022-07-01 Thread Nicolas Malin (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin closed OFBIZ-12586.
-
Fix Version/s: 22.01.01
   Resolution: Done

> Add missing parameter on xsd for widget-form:on-field-event-update-area
> ---
>
> Key: OFBIZ-12586
> URL: https://issues.apache.org/jira/browse/OFBIZ-12586
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/widget
>Affects Versions: 18.12.06, 22.01.01, Upcoming Branch
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Trivial
> Fix For: 22.01.01
>
> Attachments: OFBIZ-12586.patch
>
>
> On the widget-form.xsd definition, the element on-field-event-update-area 
> haven't possibility to define some parameters.
> But on java code, the on-field-event-update-area is read like 
> on-event-update-area.
> If you put some parameters on your code, your editor raise a syntax error but 
> OFBiz analyse and execute it well.
> {code:java}
>             
>                 
>                                                             area-target="ReloadIt">
>                      service-name="computeForReload" send-if-empty="false"/>
>                 
>             
> {code}
> By the way we can synchronize the on-field-event-update-area xsd on 
> on-event-update-area.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12586) Add missing parameter on xsd for widget-form:on-field-event-update-area

2022-07-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561536#comment-17561536
 ] 

ASF subversion and git services commented on OFBIZ-12586:
-

Commit 62b3a0e42a878d38bb82b6dc6fdb14d30792bda3 in ofbiz-site's branch 
refs/heads/master from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-site.git;h=62b3a0e ]

Add missing parameter on xsd for widget-form:on-field-event-update-area 
(OFBIZ-12586)


> Add missing parameter on xsd for widget-form:on-field-event-update-area
> ---
>
> Key: OFBIZ-12586
> URL: https://issues.apache.org/jira/browse/OFBIZ-12586
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/widget
>Affects Versions: 18.12.06, 22.01.01, Upcoming Branch
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Trivial
> Attachments: OFBIZ-12586.patch
>
>
> On the widget-form.xsd definition, the element on-field-event-update-area 
> haven't possibility to define some parameters.
> But on java code, the on-field-event-update-area is read like 
> on-event-update-area.
> If you put some parameters on your code, your editor raise a syntax error but 
> OFBiz analyse and execute it well.
> {code:java}
>             
>                 
>                                                             area-target="ReloadIt">
>                      service-name="computeForReload" send-if-empty="false"/>
>                 
>             
> {code}
> By the way we can synchronize the on-field-event-update-area xsd on 
> on-event-update-area.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!

2022-07-01 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user nmalin (triggered by nmalin).

Head commit for run:
6e2b9bd08894c1eb659ba44112f26743e42e22da / Nicolas Malin 

Improved: Add missing parameter on xsd for 
widget-form:on-field-event-update-area (OFBIZ-12586)

On the widget-form.xsd definition, the element on-field-event-update-area 
haven't possibility to define some parameters.

But on java code, the on-field-event-update-area is read like 
on-event-update-area.

If you put some parameters on your code, your editor raise a syntax error but 
OFBiz analyse and execute it well.








By the way we can synchronize the on-field-event-update-area xsd on 
on-event-update-area.

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/2597908155

With regards,
GitHub Actions via GitBox



[jira] [Commented] (OFBIZ-12586) Add missing parameter on xsd for widget-form:on-field-event-update-area

2022-07-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561535#comment-17561535
 ] 

ASF subversion and git services commented on OFBIZ-12586:
-

Commit 576307ac5ce1a830c52abbed0bc0ea22a612a368 in ofbiz-framework's branch 
refs/heads/trunk from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=576307ac5c ]

Improved: Add missing parameter on xsd for 
widget-form:on-field-event-update-area (OFBIZ-12586)

On the widget-form.xsd definition, the element on-field-event-update-area 
haven't possibility to define some parameters.

But on java code, the on-field-event-update-area is read like 
on-event-update-area.

If you put some parameters on your code, your editor raise a syntax error but 
OFBiz analyse and execute it well.








By the way we can synchronize the on-field-event-update-area xsd on 
on-event-update-area.


> Add missing parameter on xsd for widget-form:on-field-event-update-area
> ---
>
> Key: OFBIZ-12586
> URL: https://issues.apache.org/jira/browse/OFBIZ-12586
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/widget
>Affects Versions: 18.12.06, 22.01.01, Upcoming Branch
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Trivial
> Attachments: OFBIZ-12586.patch
>
>
> On the widget-form.xsd definition, the element on-field-event-update-area 
> haven't possibility to define some parameters.
> But on java code, the on-field-event-update-area is read like 
> on-event-update-area.
> If you put some parameters on your code, your editor raise a syntax error but 
> OFBiz analyse and execute it well.
> {code:java}
>             
>                 
>                                                             area-target="ReloadIt">
>                      service-name="computeForReload" send-if-empty="false"/>
>                 
>             
> {code}
> By the way we can synchronize the on-field-event-update-area xsd on 
> on-event-update-area.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12586) Add missing parameter on xsd for widget-form:on-field-event-update-area

2022-07-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561532#comment-17561532
 ] 

ASF subversion and git services commented on OFBIZ-12586:
-

Commit 6e2b9bd08894c1eb659ba44112f26743e42e22da in ofbiz-framework's branch 
refs/heads/release22.01 from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=6e2b9bd088 ]

Improved: Add missing parameter on xsd for 
widget-form:on-field-event-update-area (OFBIZ-12586)

On the widget-form.xsd definition, the element on-field-event-update-area 
haven't possibility to define some parameters.

But on java code, the on-field-event-update-area is read like 
on-event-update-area.

If you put some parameters on your code, your editor raise a syntax error but 
OFBiz analyse and execute it well.








By the way we can synchronize the on-field-event-update-area xsd on 
on-event-update-area.


> Add missing parameter on xsd for widget-form:on-field-event-update-area
> ---
>
> Key: OFBIZ-12586
> URL: https://issues.apache.org/jira/browse/OFBIZ-12586
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/widget
>Affects Versions: 18.12.06, 22.01.01, Upcoming Branch
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Trivial
> Attachments: OFBIZ-12586.patch
>
>
> On the widget-form.xsd definition, the element on-field-event-update-area 
> haven't possibility to define some parameters.
> But on java code, the on-field-event-update-area is read like 
> on-event-update-area.
> If you put some parameters on your code, your editor raise a syntax error but 
> OFBiz analyse and execute it well.
> {code:java}
>             
>                 
>                                                             area-target="ReloadIt">
>                      service-name="computeForReload" send-if-empty="false"/>
>                 
>             
> {code}
> By the way we can synchronize the on-field-event-update-area xsd on 
> on-event-update-area.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-12547) Convert a display-entity to hyperlink if subhyperlink this empty

2022-07-01 Thread Nicolas Malin (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin closed OFBIZ-12547.
-
Resolution: Done

> Convert a display-entity to hyperlink if subhyperlink this empty
> 
>
> Key: OFBIZ-12547
> URL: https://issues.apache.org/jira/browse/OFBIZ-12547
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/widget
>Affects Versions: 22.01.01, Upcoming Branch
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: 22.01.01
>
> Attachments: OFBIZ-12547.patch
>
>
> When you define a display-entity you have the possibility to add a 
> sub-hyperlink related to the element displayed.
> {code}
>  
>      key-field-name="partyId" description="${groupName}${firstName} ${lastName}">
>      description="view">...
>     
>     
> {code}
> This display the party name with a link "view" connected. 
> When you use the name a as link without a dedicate sub link, you need to 
> change all the form to resolve the information to display for creating an 
> hyperlink
> {code}
>     
>      value-field="partyName">
>      from-field="partyIdFrom"/>
>     
>     
>     
>     
>      description="${partyNameValue}">..
>     
> {code}
> We lost the advantage of the display-entity. We can suggest to improve 
> display-entity with the rule :
> If the display-entity has a subhyperlink and the subhyperlink haven't 
> description, the description of the link is the display-entity description.
> In the code, if a sub-hyperlink has an empty description, we convert the 
> display entity as a hyperlink



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Reopened] (OFBIZ-12547) Convert a display-entity to hyperlink if subhyperlink this empty

2022-07-01 Thread Nicolas Malin (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin reopened OFBIZ-12547:
---

> Convert a display-entity to hyperlink if subhyperlink this empty
> 
>
> Key: OFBIZ-12547
> URL: https://issues.apache.org/jira/browse/OFBIZ-12547
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/widget
>Affects Versions: 22.01.01, Upcoming Branch
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: 22.01.01
>
> Attachments: OFBIZ-12547.patch
>
>
> When you define a display-entity you have the possibility to add a 
> sub-hyperlink related to the element displayed.
> {code}
>  
>      key-field-name="partyId" description="${groupName}${firstName} ${lastName}">
>      description="view">...
>     
>     
> {code}
> This display the party name with a link "view" connected. 
> When you use the name a as link without a dedicate sub link, you need to 
> change all the form to resolve the information to display for creating an 
> hyperlink
> {code}
>     
>      value-field="partyName">
>      from-field="partyIdFrom"/>
>     
>     
>     
>     
>      description="${partyNameValue}">..
>     
> {code}
> We lost the advantage of the display-entity. We can suggest to improve 
> display-entity with the rule :
> If the display-entity has a subhyperlink and the subhyperlink haven't 
> description, the description of the link is the display-entity description.
> In the code, if a sub-hyperlink has an empty description, we convert the 
> display entity as a hyperlink



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-12547) Convert a display-entity to hyperlink if subhyperlink this empty

2022-07-01 Thread Nicolas Malin (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin closed OFBIZ-12547.
-
Fix Version/s: 22.01.01
   Resolution: Fixed

> Convert a display-entity to hyperlink if subhyperlink this empty
> 
>
> Key: OFBIZ-12547
> URL: https://issues.apache.org/jira/browse/OFBIZ-12547
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/widget
>Affects Versions: 22.01.01, Upcoming Branch
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: 22.01.01
>
> Attachments: OFBIZ-12547.patch
>
>
> When you define a display-entity you have the possibility to add a 
> sub-hyperlink related to the element displayed.
> {code}
>  
>      key-field-name="partyId" description="${groupName}${firstName} ${lastName}">
>      description="view">...
>     
>     
> {code}
> This display the party name with a link "view" connected. 
> When you use the name a as link without a dedicate sub link, you need to 
> change all the form to resolve the information to display for creating an 
> hyperlink
> {code}
>     
>      value-field="partyName">
>      from-field="partyIdFrom"/>
>     
>     
>     
>     
>      description="${partyNameValue}">..
>     
> {code}
> We lost the advantage of the display-entity. We can suggest to improve 
> display-entity with the rule :
> If the display-entity has a subhyperlink and the subhyperlink haven't 
> description, the description of the link is the display-entity description.
> In the code, if a sub-hyperlink has an empty description, we convert the 
> display entity as a hyperlink



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" is working again!

2022-07-01 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has 
succeeded.
Run started by GitHub user nmalin (triggered by nmalin).

Head commit for run:
e0f61dceb7395a5e31d6e8416d93c635de9f12d5 / Nicolas Malin 

Improved: Convert a display-entity to hyperlink if subhyperlink this empty 
(OFBIZ-12547)

When you define a display-entity you have the possibility to add a 
sub-hyperlink related to the element displayed.

 

...



This display the party name with a link "view" connected.

When you use the name as link without a dedicate sub link, you need to change 
all the form to resolve the information to display for creating an hyperlink








..


We lost the advantage of the display-entity. With this case, we improve 
display-entity with the following rule :

If the display-entity has a subhyperlink and the subhyperlink haven't 
description, the description of the link is the display-entity description.
In the code, if a sub-hyperlink has an empty description, we convert the 
display entity as a hyperlink

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/2597871067

With regards,
GitHub Actions via GitBox



[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!

2022-07-01 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user nmalin (triggered by nmalin).

Head commit for run:
8cccb4b586e120d5e550beeec820e72b73102455 / Nicolas Malin 

Improved: Convert a display-entity to hyperlink if subhyperlink this empty 
(OFBIZ-12547)

When you define a display-entity you have the possibility to add a 
sub-hyperlink related to the element displayed.

 

...



This display the party name with a link "view" connected.

When you use the name as link without a dedicate sub link, you need to change 
all the form to resolve the information to display for creating an hyperlink








..


We lost the advantage of the display-entity. With this case, we improve 
display-entity with the following rule :

If the display-entity has a subhyperlink and the subhyperlink haven't 
description, the description of the link is the display-entity description.
In the code, if a sub-hyperlink has an empty description, we convert the 
display entity as a hyperlink

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/2597875871

With regards,
GitHub Actions via GitBox



[jira] [Commented] (OFBIZ-12547) Convert a display-entity to hyperlink if subhyperlink this empty

2022-07-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561528#comment-17561528
 ] 

ASF subversion and git services commented on OFBIZ-12547:
-

Commit 8cccb4b586e120d5e550beeec820e72b73102455 in ofbiz-framework's branch 
refs/heads/release22.01 from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=8cccb4b586 ]

Improved: Convert a display-entity to hyperlink if subhyperlink this empty 
(OFBIZ-12547)

When you define a display-entity you have the possibility to add a 
sub-hyperlink related to the element displayed.

 

...



This display the party name with a link "view" connected.

When you use the name as link without a dedicate sub link, you need to change 
all the form to resolve the information to display for creating an hyperlink








..


We lost the advantage of the display-entity. With this case, we improve 
display-entity with the following rule :

If the display-entity has a subhyperlink and the subhyperlink haven't 
description, the description of the link is the display-entity description.
In the code, if a sub-hyperlink has an empty description, we convert the 
display entity as a hyperlink


> Convert a display-entity to hyperlink if subhyperlink this empty
> 
>
> Key: OFBIZ-12547
> URL: https://issues.apache.org/jira/browse/OFBIZ-12547
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/widget
>Affects Versions: 22.01.01, Upcoming Branch
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-12547.patch
>
>
> When you define a display-entity you have the possibility to add a 
> sub-hyperlink related to the element displayed.
> {code}
>  
>      key-field-name="partyId" description="${groupName}${firstName} ${lastName}">
>      description="view">...
>     
>     
> {code}
> This display the party name with a link "view" connected. 
> When you use the name a as link without a dedicate sub link, you need to 
> change all the form to resolve the information to display for creating an 
> hyperlink
> {code}
>     
>      value-field="partyName">
>      from-field="partyIdFrom"/>
>     
>     
>     
>     
>      description="${partyNameValue}">..
>     
> {code}
> We lost the advantage of the display-entity. We can suggest to improve 
> display-entity with the rule :
> If the display-entity has a subhyperlink and the subhyperlink haven't 
> description, the description of the link is the display-entity description.
> In the code, if a sub-hyperlink has an empty description, we convert the 
> display entity as a hyperlink



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12547) Convert a display-entity to hyperlink if subhyperlink this empty

2022-07-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561524#comment-17561524
 ] 

ASF subversion and git services commented on OFBIZ-12547:
-

Commit e0f61dceb7395a5e31d6e8416d93c635de9f12d5 in ofbiz-framework's branch 
refs/heads/trunk from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=e0f61dceb7 ]

Improved: Convert a display-entity to hyperlink if subhyperlink this empty 
(OFBIZ-12547)

When you define a display-entity you have the possibility to add a 
sub-hyperlink related to the element displayed.

 

...



This display the party name with a link "view" connected.

When you use the name as link without a dedicate sub link, you need to change 
all the form to resolve the information to display for creating an hyperlink








..


We lost the advantage of the display-entity. With this case, we improve 
display-entity with the following rule :

If the display-entity has a subhyperlink and the subhyperlink haven't 
description, the description of the link is the display-entity description.
In the code, if a sub-hyperlink has an empty description, we convert the 
display entity as a hyperlink


> Convert a display-entity to hyperlink if subhyperlink this empty
> 
>
> Key: OFBIZ-12547
> URL: https://issues.apache.org/jira/browse/OFBIZ-12547
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/widget
>Affects Versions: 22.01.01, Upcoming Branch
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-12547.patch
>
>
> When you define a display-entity you have the possibility to add a 
> sub-hyperlink related to the element displayed.
> {code}
>  
>      key-field-name="partyId" description="${groupName}${firstName} ${lastName}">
>      description="view">...
>     
>     
> {code}
> This display the party name with a link "view" connected. 
> When you use the name a as link without a dedicate sub link, you need to 
> change all the form to resolve the information to display for creating an 
> hyperlink
> {code}
>     
>      value-field="partyName">
>      from-field="partyIdFrom"/>
>     
>     
>     
>     
>      description="${partyNameValue}">..
>     
> {code}
> We lost the advantage of the display-entity. We can suggest to improve 
> display-entity with the rule :
> If the display-entity has a subhyperlink and the subhyperlink haven't 
> description, the description of the link is the display-entity description.
> In the code, if a sub-hyperlink has an empty description, we convert the 
> display entity as a hyperlink



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" is working again!

2022-07-01 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has 
succeeded.
Run started by GitHub user nmalin (triggered by nmalin).

Head commit for run:
8015dcb02d5127b9845d2ae3dc6bcf678224fad6 / Nicolas Malin 

Improved: Refactoring service resenquence (OFBIZ-12624)

The service "resequence" compute for a content all sequenceNum for linked 
content assoc.

The code is very old (before apache) so apply a slim refactor and migrate the 
service name resequence to resequenceContentAssocChildren.

By the way I kept the service definition resequence to move it as deprecated.

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/2597790070

With regards,
GitHub Actions via GitBox



[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!

2022-07-01 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user nmalin (triggered by nmalin).

Head commit for run:
4c0773e53172b8fa45d4a8abab7b19fd684650b6 / Nicolas Malin 

Improved: Refactoring service resenquence (OFBIZ-12624)

The service "resequence" compute for a content all sequenceNum for linked 
content assoc.

The code is very old (before apache) so apply a slim refactor and migrate the 
service name resequence to resequenceContentAssocChildren.

By the way I kept the service definition resequence to move it as deprecated.

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/2597800762

With regards,
GitHub Actions via GitBox



[jira] [Commented] (OFBIZ-12624) Refactoring service resenquence

2022-07-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561518#comment-17561518
 ] 

ASF subversion and git services commented on OFBIZ-12624:
-

Commit 4c0773e53172b8fa45d4a8abab7b19fd684650b6 in ofbiz-framework's branch 
refs/heads/release22.01 from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=4c0773e531 ]

Improved: Refactoring service resenquence (OFBIZ-12624)

The service "resequence" compute for a content all sequenceNum for linked 
content assoc.

The code is very old (before apache) so apply a slim refactor and migrate the 
service name resequence to resequenceContentAssocChildren.

By the way I kept the service definition resequence to move it as deprecated.


> Refactoring service resenquence
> ---
>
> Key: OFBIZ-12624
> URL: https://issues.apache.org/jira/browse/OFBIZ-12624
> Project: OFBiz
>  Issue Type: Improvement
>  Components: content
>Affects Versions: 22.01.01, Upcoming Branch
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
>  Labels: Refactoring
> Fix For: 22.01.01
>
> Attachments: OFBIZ-12624.patch
>
>
> Recently I discovered the service "resequence" that for a content compute all 
> sequenceNum on linked content assoc.
> The code is very old (before apache) so I propose to refactore it and migrate 
> the service name *resequence* to *resequenceContentAssocChildren* (or if you 
> have a better suggest :) )
> By the way I kept the service definition resequence to move it as deprecated.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-12624) Refactoring service resenquence

2022-07-01 Thread Nicolas Malin (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin closed OFBIZ-12624.
-
Fix Version/s: 22.01.01
   Resolution: Done

> Refactoring service resenquence
> ---
>
> Key: OFBIZ-12624
> URL: https://issues.apache.org/jira/browse/OFBIZ-12624
> Project: OFBiz
>  Issue Type: Improvement
>  Components: content
>Affects Versions: 22.01.01, Upcoming Branch
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
>  Labels: Refactoring
> Fix For: 22.01.01
>
> Attachments: OFBIZ-12624.patch
>
>
> Recently I discovered the service "resequence" that for a content compute all 
> sequenceNum on linked content assoc.
> The code is very old (before apache) so I propose to refactore it and migrate 
> the service name *resequence* to *resequenceContentAssocChildren* (or if you 
> have a better suggest :) )
> By the way I kept the service definition resequence to move it as deprecated.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12624) Refactoring service resenquence

2022-07-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561517#comment-17561517
 ] 

ASF subversion and git services commented on OFBIZ-12624:
-

Commit 8015dcb02d5127b9845d2ae3dc6bcf678224fad6 in ofbiz-framework's branch 
refs/heads/trunk from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=8015dcb02d ]

Improved: Refactoring service resenquence (OFBIZ-12624)

The service "resequence" compute for a content all sequenceNum for linked 
content assoc.

The code is very old (before apache) so apply a slim refactor and migrate the 
service name resequence to resequenceContentAssocChildren.

By the way I kept the service definition resequence to move it as deprecated.


> Refactoring service resenquence
> ---
>
> Key: OFBIZ-12624
> URL: https://issues.apache.org/jira/browse/OFBIZ-12624
> Project: OFBiz
>  Issue Type: Improvement
>  Components: content
>Affects Versions: 22.01.01, Upcoming Branch
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
>  Labels: Refactoring
> Attachments: OFBIZ-12624.patch
>
>
> Recently I discovered the service "resequence" that for a content compute all 
> sequenceNum on linked content assoc.
> The code is very old (before apache) so I propose to refactore it and migrate 
> the service name *resequence* to *resequenceContentAssocChildren* (or if you 
> have a better suggest :) )
> By the way I kept the service definition resequence to move it as deprecated.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12639) Upload image size issue

2022-07-01 Thread Ingo Wolfmayr (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561515#comment-17561515
 ] 

Ingo Wolfmayr commented on OFBIZ-12639:
---

[~jleroux]: I will work on that next week. It would be good if the user gets a 
proper message.

> Upload image size issue
> ---
>
> Key: OFBIZ-12639
> URL: https://issues.apache.org/jira/browse/OFBIZ-12639
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product/catalog
>Affects Versions: Upcoming Branch
>Reporter: Ingo Wolfmayr
>Priority: Major
> Attachments: test.jpeg
>
>
> I tied to uploaded an Image > 3MB and it fails as the line length > 1
> Does this security check make sense for images? Attached you will find the 
> image.
> Additional to that, the security message is missleading: For security reason 
> only valid files of supported image formats...
> Responsible code can be found in: SecuredUploads.java (line 205) & 
> DataServices.java (line 216)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-12653) Sanitizer fail

2022-07-01 Thread Ingo Wolfmayr (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ingo Wolfmayr closed OFBIZ-12653.
-
Resolution: Fixed

> Sanitizer  fail
> ---
>
> Key: OFBIZ-12653
> URL: https://issues.apache.org/jira/browse/OFBIZ-12653
> Project: OFBiz
>  Issue Type: Improvement
>  Components: content
>Affects Versions: Upcoming Branch
>Reporter: Ingo Wolfmayr
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: CustomSafePolicy.patch, OFBIZ-12653.patch, 
> UtilCodec.patch
>
>
> I copied a text with multiple lines from a text editor into the Trumbowyg 
> Html field.The editor creates the Html structure using unclosed  elements.
> Unfortunately the sanitizer logic just takes . A security warning is 
> thrown and the content will not be stored.
> Issue also a request on Trumbowyg request list:
> [https://github.com/Alex-D/Trumbowyg/issues/1283]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12653) Sanitizer fail

2022-07-01 Thread Ingo Wolfmayr (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561514#comment-17561514
 ] 

Ingo Wolfmayr commented on OFBIZ-12653:
---

Thanks Jacques!

> Sanitizer  fail
> ---
>
> Key: OFBIZ-12653
> URL: https://issues.apache.org/jira/browse/OFBIZ-12653
> Project: OFBiz
>  Issue Type: Improvement
>  Components: content
>Affects Versions: Upcoming Branch
>Reporter: Ingo Wolfmayr
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: CustomSafePolicy.patch, OFBIZ-12653.patch, 
> UtilCodec.patch
>
>
> I copied a text with multiple lines from a text editor into the Trumbowyg 
> Html field.The editor creates the Html structure using unclosed  elements.
> Unfortunately the sanitizer logic just takes . A security warning is 
> thrown and the content will not be stored.
> Issue also a request on Trumbowyg request list:
> [https://github.com/Alex-D/Trumbowyg/issues/1283]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-12628) MenuItem doesn't follow correctly extend information

2022-07-01 Thread Nicolas Malin (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin closed OFBIZ-12628.
-
Resolution: Fixed

Ok thanks Jacques the pb appeared when your origin menu item haven't link.

 

It's now fixed

> MenuItem doesn't follow correctly extend information
> 
>
> Key: OFBIZ-12628
> URL: https://issues.apache.org/jira/browse/OFBIZ-12628
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/widget
>Affects Versions: 22.01.01, Upcoming Branch
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: 22.01.01
>
> Attachments: OFBIZ-12628.patch
>
>
> When you use two menus where the second extend the first, menu item and menu 
> link aren't propage correctly.
> The menu items and menu link presents on the second menu already have the 
> first menu on their model.
>  
> {code:java}
>  extends-resource="component://common/widget/CommonMenus.xml">
> 
> 
> 
> 
>  {code}
> The result, if during the rendering some information are generate from the 
> menu, in the previous case, it's always the "FirstMenu" that would be use.
> To solve it and don't break the thread safe pattern, I introduce two new 
> constructor for ModelItem and MenuLink for duplicate the ModelMenuItem and 
> MenuLink in memory with the new parent.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" is working again!

2022-07-01 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has 
succeeded.
Run started by GitHub user nmalin (triggered by nmalin).

Head commit for run:
7ea371bde3c06d6ae7f86b13a755672f92764aaf / Nicolas Malin 

Fixed: MenuItem doesn't follow correctly extended informations (OFBIZ-12628)

Fix a null pointer exception when the extended menu have an entry without link.

Thanks to Jacques Leroux for the alert

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/2597651204

With regards,
GitHub Actions via GitBox



[jira] [Commented] (OFBIZ-12628) MenuItem doesn't follow correctly extend information

2022-07-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561509#comment-17561509
 ] 

ASF subversion and git services commented on OFBIZ-12628:
-

Commit d95c23cbd3243fb8f90ed5eeab2b9e6179ba8338 in ofbiz-framework's branch 
refs/heads/release22.01 from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=d95c23cbd3 ]

Fixed: MenuItem doesn't follow correctly extended informations (OFBIZ-12628)

Fix a null pointer exception when the extended menu have an entry without link.

Thanks to Jacques Leroux for the alert


> MenuItem doesn't follow correctly extend information
> 
>
> Key: OFBIZ-12628
> URL: https://issues.apache.org/jira/browse/OFBIZ-12628
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/widget
>Affects Versions: 22.01.01, Upcoming Branch
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: 22.01.01
>
> Attachments: OFBIZ-12628.patch
>
>
> When you use two menus where the second extend the first, menu item and menu 
> link aren't propage correctly.
> The menu items and menu link presents on the second menu already have the 
> first menu on their model.
>  
> {code:java}
>  extends-resource="component://common/widget/CommonMenus.xml">
> 
> 
> 
> 
>  {code}
> The result, if during the rendering some information are generate from the 
> menu, in the previous case, it's always the "FirstMenu" that would be use.
> To solve it and don't break the thread safe pattern, I introduce two new 
> constructor for ModelItem and MenuLink for duplicate the ModelMenuItem and 
> MenuLink in memory with the new parent.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12628) MenuItem doesn't follow correctly extend information

2022-07-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561508#comment-17561508
 ] 

ASF subversion and git services commented on OFBIZ-12628:
-

Commit 7ea371bde3c06d6ae7f86b13a755672f92764aaf in ofbiz-framework's branch 
refs/heads/trunk from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=7ea371bde3 ]

Fixed: MenuItem doesn't follow correctly extended informations (OFBIZ-12628)

Fix a null pointer exception when the extended menu have an entry without link.

Thanks to Jacques Leroux for the alert


> MenuItem doesn't follow correctly extend information
> 
>
> Key: OFBIZ-12628
> URL: https://issues.apache.org/jira/browse/OFBIZ-12628
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/widget
>Affects Versions: 22.01.01, Upcoming Branch
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: 22.01.01
>
> Attachments: OFBIZ-12628.patch
>
>
> When you use two menus where the second extend the first, menu item and menu 
> link aren't propage correctly.
> The menu items and menu link presents on the second menu already have the 
> first menu on their model.
>  
> {code:java}
>  extends-resource="component://common/widget/CommonMenus.xml">
> 
> 
> 
> 
>  {code}
> The result, if during the rendering some information are generate from the 
> menu, in the previous case, it's always the "FirstMenu" that would be use.
> To solve it and don't break the thread safe pattern, I introduce two new 
> constructor for ModelItem and MenuLink for duplicate the ModelMenuItem and 
> MenuLink in memory with the new parent.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #517: Codenarc integration

2022-07-01 Thread GitBox


sonarcloud[bot] commented on PR #517:
URL: https://github.com/apache/ofbiz-framework/pull/517#issuecomment-1172471042

   SonarCloud Quality Gate failed.  [![Quality Gate 
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
 'Quality Gate 
failed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=517)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=517=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=517=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=517=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=517=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=517=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=517=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=517=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=517=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=517=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=517=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=517=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=517=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=517)
 No Coverage information  
   
[![9.4%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/10-16px.png
 
'9.4%')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=517=new_duplicated_lines_density=list)
 [9.4% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=517=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!

2022-07-01 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user gilPts (triggered by gilPts).

Head commit for run:
2f1d026a849946db48a858f03e54cb7262436aea / Gil Portenseigne 
Fix codenarc ForStatementBraces rule Use braces for for statements, even for a 
single statement.

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/2597616299

With regards,
GitHub Actions via GitBox



[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" is working again!

2022-07-01 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has 
succeeded.
Run started by GitHub user asfgit (triggered by asfgit).

Head commit for run:
78ee6f8792f8610563931fef2d86e75678b9056c / Jacques Le Roux 

Improved: CustomSafePolicy, also use TagBalancingHtmlStreamEventReceiver 
(OFBIZ-12653)

Adds  and  to CustomSafePolicy, removes obsolete .  allows
only attributes src and alt.

Both  and  are correct. For that, this rather uses
TagBalancingHtmlStreamEventReceiver

Thanks: Ingo Wolfmayr

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/2597593937

With regards,
GitHub Actions via GitBox



[jira] [Commented] (OFBIZ-12653) Sanitizer fail

2022-07-01 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561502#comment-17561502
 ] 

Jacques Le Roux commented on OFBIZ-12653:
-

I think we can close now, I let you decide...

> Sanitizer  fail
> ---
>
> Key: OFBIZ-12653
> URL: https://issues.apache.org/jira/browse/OFBIZ-12653
> Project: OFBiz
>  Issue Type: Improvement
>  Components: content
>Affects Versions: Upcoming Branch
>Reporter: Ingo Wolfmayr
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: CustomSafePolicy.patch, OFBIZ-12653.patch, 
> UtilCodec.patch
>
>
> I copied a text with multiple lines from a text editor into the Trumbowyg 
> Html field.The editor creates the Html structure using unclosed  elements.
> Unfortunately the sanitizer logic just takes . A security warning is 
> thrown and the content will not be stored.
> Issue also a request on Trumbowyg request list:
> [https://github.com/Alex-D/Trumbowyg/issues/1283]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12653) Sanitizer fail

2022-07-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561501#comment-17561501
 ] 

ASF subversion and git services commented on OFBIZ-12653:
-

Commit 78ee6f8792f8610563931fef2d86e75678b9056c in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=78ee6f8792 ]

Improved: CustomSafePolicy, also use TagBalancingHtmlStreamEventReceiver 
(OFBIZ-12653)

Adds  and  to CustomSafePolicy, removes obsolete .  allows
only attributes src and alt.

Both  and  are correct. For that, this rather uses
TagBalancingHtmlStreamEventReceiver

Thanks: Ingo Wolfmayr


> Sanitizer  fail
> ---
>
> Key: OFBIZ-12653
> URL: https://issues.apache.org/jira/browse/OFBIZ-12653
> Project: OFBiz
>  Issue Type: Improvement
>  Components: content
>Affects Versions: Upcoming Branch
>Reporter: Ingo Wolfmayr
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: CustomSafePolicy.patch, OFBIZ-12653.patch, 
> UtilCodec.patch
>
>
> I copied a text with multiple lines from a text editor into the Trumbowyg 
> Html field.The editor creates the Html structure using unclosed  elements.
> Unfortunately the sanitizer logic just takes . A security warning is 
> thrown and the content will not be stored.
> Issue also a request on Trumbowyg request list:
> [https://github.com/Alex-D/Trumbowyg/issues/1283]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12653) Sanitizer fail

2022-07-01 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561497#comment-17561497
 ] 

Jacques Le Roux commented on OFBIZ-12653:
-

Hi Ingo,

Maybe img was not OOTB in the CustomSafePolicy (copied from an OWASP example 
IIRW), because there is at least a case where it can be used to create a 
vulnerability*:
{code:java}

{code}
 * [https://portswigger.net/web-security/cross-site-scripting/cheat-sheet]

This said UtilCodec::checkStringForHtmlSafe does not allow the above code to 
pass. Nor examples related to  we can found at [http://html5sec.org/]. So 
your CustomSafePolicy is strong enough to be safe.

Your other patch extends our perspective with 
TagBalancingHtmlStreamEventReceiver, that's interesting. I was not aware of 
that.
I wondered about safety, reading ["A 'void' element doesn't require a closing 
tag"|https://www.thoughtco.com/html-singleton-tags-3468620]. Since your 
CustomSafePolicy allows only br and img among them; it's safe about that too. 
BTW, we could add hr and remove tt, I'll do that

> Sanitizer  fail
> ---
>
> Key: OFBIZ-12653
> URL: https://issues.apache.org/jira/browse/OFBIZ-12653
> Project: OFBiz
>  Issue Type: Improvement
>  Components: content
>Affects Versions: Upcoming Branch
>Reporter: Ingo Wolfmayr
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: CustomSafePolicy.patch, OFBIZ-12653.patch, 
> UtilCodec.patch
>
>
> I copied a text with multiple lines from a text editor into the Trumbowyg 
> Html field.The editor creates the Html structure using unclosed  elements.
> Unfortunately the sanitizer logic just takes . A security warning is 
> thrown and the content will not be stored.
> Issue also a request on Trumbowyg request list:
> [https://github.com/Alex-D/Trumbowyg/issues/1283]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (OFBIZ-12654) Add sequenceNum on contentAssoc list

2022-07-01 Thread Nicolas Malin (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin reassigned OFBIZ-12654:
-

Assignee: Nicolas Malin

> Add sequenceNum on contentAssoc list
> 
>
> Key: OFBIZ-12654
> URL: https://issues.apache.org/jira/browse/OFBIZ-12654
> Project: OFBiz
>  Issue Type: Improvement
>  Components: content
>Affects Versions: Upcoming Branch
>Reporter: Ingo Wolfmayr
>Assignee: Nicolas Malin
>Priority: Trivial
> Fix For: Upcoming Branch
>
> Attachments: ContentAssocSeq.patch
>
>
> It would be sometimes quite helpful if the sequence number is displayed on 
> the ContentAssoc List widget.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!

2022-07-01 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user gilPts (triggered by gilPts).

Head commit for run:
6f05f1b36a86aa3e98d2a049698647ed94ec3f53 / Gil Portenseigne 
Document all Basic rules while fixing it.

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/2597174880

With regards,
GitHub Actions via GitBox



[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #517: Codenarc integration

2022-07-01 Thread GitBox


sonarcloud[bot] commented on PR #517:
URL: https://github.com/apache/ofbiz-framework/pull/517#issuecomment-1172394427

   SonarCloud Quality Gate failed.  [![Quality Gate 
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
 'Quality Gate 
failed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=517)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=517=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=517=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=517=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=517=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=517=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=517=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=517=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=517=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=517=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=517=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=517=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=517=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=517)
 No Coverage information  
   
[![9.4%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/10-16px.png
 
'9.4%')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=517=new_duplicated_lines_density=list)
 [9.4% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=517=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (OFBIZ-11167) Use Codenarc to test Groovy code

2022-07-01 Thread Gil Portenseigne (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561468#comment-17561468
 ] 

Gil Portenseigne commented on OFBIZ-11167:
--

Hello Folks, i dig up this subject and started to work on it actively, i will 
push my progress here [https://github.com/apache/ofbiz-framework/pull/517.]

The Idea is to document each rule, and make one commit by rule on the pull 
request to ease the review and decide if a rule is worth keeping etc.

 

> Use Codenarc to test Groovy code
> 
>
> Key: OFBIZ-11167
> URL: https://issues.apache.org/jira/browse/OFBIZ-11167
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Reporter: Jacques Le Roux
>Assignee: Gil Portenseigne
>Priority: Minor
> Attachments: OFBIZ-11167.patch, main.html, test.html
>
>
> Now that we use Groovy more and more, I think we should really have a look a 
> Codenarc
> https://docs.gradle.org/current/userguide/codenarc_plugin.html
> We already discussed it at https://markmail.org/message/uigcpnxqgizhd2oi and 
> https://markmail.org/message/rp6njoiohkkiodbe
> We know it's a crucial task but not an easy but rather a long term one
> Here are some interesting links (before I delete my FF tabs group about it)
> http://codenarc.sourceforge.net/codenarc-other-tools-frameworks.html
> http://codenarc.sourceforge.net/codenarc-creating-ruleset.html
> https://github.com/gradle/gradle/tree/master/config
> https://stackoverflow.com/questions/14358471/how-to-generate-codenarc-report-for-main-and-test-classes-using-different-rule-s
> https://mrhaki.blogspot.com/2011/01/gradle-goodness-use-groovy-ruleset-file.html



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [ofbiz-framework] gilPts opened a new pull request, #517: Codenarc integration

2022-07-01 Thread GitBox


gilPts opened a new pull request, #517:
URL: https://github.com/apache/ofbiz-framework/pull/517

   Implemented: add codenarc and fix first basic rules.
   (OFBIZ-11167)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (OFBIZ-12663) Allow DynamicView use in standard performFind services

2022-07-01 Thread Leila Mekika (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leila Mekika updated OFBIZ-12663:
-
Description: 
This is a proposition to extend the use of standard find services (prepareFind, 
executeFind and performFind) to dynamicView.

It can help to have performFind services (such has performFindParty) that use 
the same standard service

To describe quickly, it adds dynamicViewEntity as an optional parameter of 
prepareFind, executeFind and performFind services and adapt the query 
accordingly

  was:
This is a proposition to extend the use of standard find services (prepareFind, 
executeFind and performFind) to dynamicView.

It can help to have performFind services (such has performFindParty) that use 
the same standard service


> Allow DynamicView use in standard performFind services
> --
>
> Key: OFBIZ-12663
> URL: https://issues.apache.org/jira/browse/OFBIZ-12663
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/common
>Affects Versions: Upcoming Branch
>Reporter: Leila Mekika
>Priority: Major
> Attachments: OFBIZ-12663.patch
>
>
> This is a proposition to extend the use of standard find services 
> (prepareFind, executeFind and performFind) to dynamicView.
> It can help to have performFind services (such has performFindParty) that use 
> the same standard service
> To describe quickly, it adds dynamicViewEntity as an optional parameter of 
> prepareFind, executeFind and performFind services and adapt the query 
> accordingly



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (OFBIZ-12663) Allow DynamicView use in standard performFind services

2022-07-01 Thread Leila Mekika (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leila Mekika updated OFBIZ-12663:
-
Attachment: OFBIZ-12663.patch

> Allow DynamicView use in standard performFind services
> --
>
> Key: OFBIZ-12663
> URL: https://issues.apache.org/jira/browse/OFBIZ-12663
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/common
>Affects Versions: Upcoming Branch
>Reporter: Leila Mekika
>Priority: Major
> Attachments: OFBIZ-12663.patch
>
>
> This is a proposition to extend the use of standard find services 
> (prepareFind, executeFind and performFind) to dynamicView.
> It can help to have performFind services (such has performFindParty) that use 
> the same standard service



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (OFBIZ-12663) Allow DynamicView use in standard performFind services

2022-07-01 Thread Leila Mekika (Jira)
Leila Mekika created OFBIZ-12663:


 Summary: Allow DynamicView use in standard performFind services
 Key: OFBIZ-12663
 URL: https://issues.apache.org/jira/browse/OFBIZ-12663
 Project: OFBiz
  Issue Type: Improvement
  Components: framework/common
Affects Versions: Upcoming Branch
Reporter: Leila Mekika


This is a proposition to extend the use of standard find services (prepareFind, 
executeFind and performFind) to dynamicView.

It can help to have performFind services (such has performFindParty) that use 
the same standard service



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12619) Required field not working on upload type form

2022-07-01 Thread Leila Mekika (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561448#comment-17561448
 ] 

Leila Mekika commented on OFBIZ-12619:
--

Thank you Jacques,

Sorry for the example, I didn't see your previous question...

> Required field not working on upload type form
> --
>
> Key: OFBIZ-12619
> URL: https://issues.apache.org/jira/browse/OFBIZ-12619
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Leila Mekika
>Assignee: Jacques Le Roux
>Priority: Minor
>  Labels: trunk
> Fix For: 18.12.06, 22.01.01
>
> Attachments: OFBIZ-12619.patch
>
>
> When trying to submit an upload form with empty required fields,
> the validation is not blocked and the submit is made.
>  
> Here is a patch to allow required validation control in upload forms



--
This message was sent by Atlassian Jira
(v8.20.10#820010)