[GitHub] [ofbiz-framework]: Workflow run "CodeQL" is working again!
The GitHub Actions job "CodeQL" on ofbiz-framework.git has succeeded. Run started by GitHub user dependabot[bot] (triggered by dependabot[bot]). Head commit for run: 9c2ed30054681a56fd5ab3906703ad77b926e0ca / dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump uglify-js in /themes/common-theme/webapp/common-theme/js Bumps [uglify-js](https://github.com/mishoo/UglifyJS) from 3.16.3 to 3.17.0. - [Release notes](https://github.com/mishoo/UglifyJS/releases) - [Commits](https://github.com/mishoo/UglifyJS/compare/v3.16.3...v3.17.0) --- updated-dependencies: - dependency-name: uglify-js dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] Report URL: https://github.com/apache/ofbiz-framework/actions/runs/2889794432 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "CodeQL" failed!
The GitHub Actions job "CodeQL" on ofbiz-framework.git has failed. Run started by GitHub user JacquesLeRoux (triggered by JacquesLeRoux). Head commit for run: 5d76a40f79bd325d09e92ca5bf8bd4631fd93b28 / dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump uglify-js in /themes/common-theme/webapp/common-theme/js (#536) Bumps [uglify-js](https://github.com/mishoo/UglifyJS) from 3.16.3 to 3.17.0. - [Release notes](https://github.com/mishoo/UglifyJS/releases) - [Commits](https://github.com/mishoo/UglifyJS/compare/v3.16.3...v3.17.0) --- updated-dependencies: - dependency-name: uglify-js dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Report URL: https://github.com/apache/ofbiz-framework/actions/runs/2890267395 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user gilPts (triggered by gilPts). Head commit for run: f9b633aa2d784258f741f700e71c921758ad424b / Gil Portenseigne LineLength rule implementation Report URL: https://github.com/apache/ofbiz-framework/actions/runs/2890458616 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #517: Codenarc integration
sonarcloud[bot] commented on PR #517: URL: https://github.com/apache/ofbiz-framework/pull/517#issuecomment-1220809233 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=517) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=517&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=517&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=517&resolved=false&types=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=517&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=517&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=517&resolved=false&types=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=517&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=517&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=517&resolved=false&types=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=517&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=517&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=517&resolved=false&types=CODE_SMELL) [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=517) No Coverage information [![9.3%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/10-16px.png '9.3%')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=517&metric=new_duplicated_lines_density&view=list) [9.3% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=517&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #536: Bump uglify-js from 3.16.3 to 3.17.0 in /themes/common-theme/webapp/common-theme/js
JacquesLeRoux merged PR #536: URL: https://github.com/apache/ofbiz-framework/pull/536 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #536: Bump uglify-js from 3.16.3 to 3.17.0 in /themes/common-theme/webapp/common-theme/js
sonarcloud[bot] commented on PR #536: URL: https://github.com/apache/ofbiz-framework/pull/536#issuecomment-1220695061 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=536) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=536&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=536&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=536&resolved=false&types=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=536&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=536&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=536&resolved=false&types=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=536&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=536&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=536&resolved=false&types=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=536&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=536&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=536&resolved=false&types=CODE_SMELL) [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=536) No Coverage information [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=536&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=536&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] dependabot[bot] opened a new pull request, #536: Bump uglify-js from 3.16.3 to 3.17.0 in /themes/common-theme/webapp/common-theme/js
dependabot[bot] opened a new pull request, #536: URL: https://github.com/apache/ofbiz-framework/pull/536 Bumps [uglify-js](https://github.com/mishoo/UglifyJS) from 3.16.3 to 3.17.0. Release notes Sourced from https://github.com/mishoo/UglifyJS/releases";>uglify-js's releases. v3.17.0 Features merge common tail of if statements (996836b67e1800af188d7ca4e79813967ebc8bc2) eliminate superfluous Object() wrappers (db6fd6db3e8eaa0b2ebbddb5e1cbcea81f0631ab) improve elimination of return statements (08c386f363c8e3549e63c2d996c0e4f11c4cf116, ab5c7e6863f0a898798cf3b2fd87a52a89ed018d, 6667440aafa04669e99c641ef945d6903e086b7a, e39f33e41b1234b195b90d299014f40a999a8608, 64e3ceec3b6a7ee37dc4772dc3ad88542013f88f, 8076d66ae58315671821d9ecaa1f726f509e331d, 884842cd6ceb49766c152a60b151fcf386c13831, a9d9af53e9f469ed89f0be0a53da2a0ac07f3733) improve compression of ternary expressions (672cdfa57ae67aae726f5b46ea20638aa1e9ce1d) exclude latest ECMAScript runtime properties from builtin mangling (8a07f1202c135bd2fa6f2d5cc0231c466e73242e) introduce --expression for ease of handling bookmarklets or JSON expressions (f451a7ad79165dda0d3f7fa7a56b3841eeba8174) improve resolution and accuracy of source-maps (2c3c4ec32381bad3f21bf2778470d58abba7b82a) inline function calls with simple assignments (5a4cd09938e46bbf7d9a875e03ce7e99c6e6c442) Bug Fixes async generator function (da930affd2b9969e042dc8c9e9ded4de8f1174c2) class property (41b65af6e2ef75010b30bfc10a40cea705ff12ac, dd90135944fb3f980b8ff2fcbef961d05cd8) class static block (41b65af6e2ef75010b30bfc10a40cea705ff12ac) default parameter (c32fe26b8d9b7a8fc9ddbd0e6771a0e2af40365b) destructuring syntax (c32fe26b8d9b7a8fc9ddbd0e6771a0e2af40365b) function literal (513995f57dfb295a7880ac5d33f633a2ee381f3b) lexical declaration (937a6728798cc139defa868c78ddf57d851913d7) Commits https://github.com/mishoo/UglifyJS/commit/8602d1ba1735be428137685dd3aa59bcdb2712b0";>8602d1b v3.17.0 https://github.com/mishoo/UglifyJS/commit/dd90135944fb3f980b8ff2fcbef961d05cd8";>dd90135 fix corner case in pure_getters (https://github-redirect.dependabot.com/mishoo/UglifyJS/issues/5617";>#5617) https://github.com/mishoo/UglifyJS/commit/612701a706fb389efba3ffdcdcbc563784791efc";>612701a tweak ufuzz test case generation (https://github-redirect.dependabot.com/mishoo/UglifyJS/issues/5615";>#5615) https://github.com/mishoo/UglifyJS/commit/503532cf7774a826f031ea1459abc304ca4b819b";>503532c workaround sporadic I/O lags in GitHub Actions (https://github-redirect.dependabot.com/mishoo/UglifyJS/issues/5613";>#5613) https://github.com/mishoo/UglifyJS/commit/6c0e52292201bf8a192f7455a1aa3fc0f5ad4855";>6c0e522 workaround sporadic I/O lags in GitHub Actions (https://github-redirect.dependabot.com/mishoo/UglifyJS/issues/5612";>#5612) https://github.com/mishoo/UglifyJS/commit/9d3727698656e4ffe6f9277de6770ba43cb8bdf8";>9d37276 tweak ufuzz test case generation (https://github-redirect.dependabot.com/mishoo/UglifyJS/issues/5611";>#5611) https://github.com/mishoo/UglifyJS/commit/5a4cd09938e46bbf7d9a875e03ce7e99c6e6c442";>5a4cd09 enhance inline (https://github-redirect.dependabot.com/mishoo/UglifyJS/issues/5610";>#5610) https://github.com/mishoo/UglifyJS/commit/c32fe26b8d9b7a8fc9ddbd0e6771a0e2af40365b";>c32fe26 fix corner case in merge_vars (https://github-redirect.dependabot.com/mishoo/UglifyJS/issues/5609";>#5609) https://github.com/mishoo/UglifyJS/commit/2c3c4ec32381bad3f21bf2778470d58abba7b82a";>2c3c4ec improve source mapping accuracy (https://github-redirect.dependabot.com/mishoo/UglifyJS/issues/5608";>#5608) https://github.com/mishoo/UglifyJS/commit/f451a7ad79165dda0d3f7fa7a56b3841eeba8174";>f451a7a implement --expression (https://github-redirect.dependabot.com/mishoo/UglifyJS/issues/5607";>#5607) Additional commits viewable in https://github.com/mishoo/UglifyJS/compare/v3.16.3...v3.17.0";>compare view [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=uglify-js&package-manager=npm_and_yarn&previous-version=3.16.3&new-version=3.17.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabo
[jira] [Commented] (OFBIZ-12680) Optimize the 'get average product rating' method logic
[ https://issues.apache.org/jira/browse/OFBIZ-12680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17581702#comment-17581702 ] Jacques Le Roux commented on OFBIZ-12680: - Hi Sourabh, We don't apply improvements on releases branches, only on trunk. I tried to apply your patch on trunk but the paths have changed. Please recreate your patch on trunk HEAD, TIA > Optimize the 'get average product rating' method logic > -- > > Key: OFBIZ-12680 > URL: https://issues.apache.org/jira/browse/OFBIZ-12680 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: 18.12.06 >Reporter: sourabh jain >Assignee: sourabh jain >Priority: Major > Fix For: 18.12.06 > > > *#Problem*: When calculating the average product rating for any product, the > 'get average product rating' method first retrieves the whole list of reviews > and then iterates all product reviews to determine. > The approach takes time to respond when there are thousands of reviews of a > single product. It takes significantly longer to display many products > together with their reviews. (e.g. search result page) > *#Solution*: We can use the 'average' function to get the average rather than > iterating all the product reviews. -- This message was sent by Atlassian Jira (v8.20.10#820010)