[jira] [Commented] (OFBIZ-11456) MacroFormRenderer refactoring
[ https://issues.apache.org/jira/browse/OFBIZ-11456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635975#comment-17635975 ] ASF subversion and git services commented on OFBIZ-11456: - Commit c7bdaf160599187f87a8a90e9f39e6aa0dec800c in ofbiz-framework's branch refs/heads/trunk from Daniel Watford [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=c7bdaf1605 ] Improved: MacroFormRenderer refactoring of datefind fields (OFBIZ-12712) Part of the OFBIZ-11456 MacroFormRenderer refactoring effort. Rather than MacroFormRenderer producing and evaulating FTL strings, it now uses RenderableFtlElementsBuilder to create RenderableFtlMacroCall objects for datefind fields which are then passed to an FtlWriter for evaluation. Removed unused parameters from the renderDateFindField FTL macro definition. Set defaults for several parameters, simplifying generation of macro calls. Synchronised the parameter list of rendateDateFindField macros across all output types - i.e. html, xml, text, etc. > MacroFormRenderer refactoring > - > > Key: OFBIZ-11456 > URL: https://issues.apache.org/jira/browse/OFBIZ-11456 > Project: OFBiz > Issue Type: Improvement > Components: framework/widget >Affects Versions: Trunk, Upcoming Branch >Reporter: Daniel Watford >Assignee: Daniel Watford >Priority: Minor > > Class MacroFormRender is 3400 lines long and performs the following: > * Renders the various form structure parts and field widgets to FTL macros > calls. > * Configures the FTL environment. > * Executes the FTL macro calls to generate HTML and write it to a caller > provided Appendable. > Implementing the above means that MacroFormRenderer does not meet the Single > Responsibility Principle. The current implementation of multiple > responsibilities makes unit testing difficult. > As discussed on the dev mailing list > https://markmail.org/message/adtkk6cb6o7mmy7f it is proposed that > MacroFormRenderer is refactored. > Refactoring should separate the rendering of form structure parts and field > widgets to FTL macro calls from the execution of those macros. > To support the refactoring effort JMockit is being introduced (OFBIZ-4035) to > allow test creation against the current implementation of MacroFormRenderer, > helping to ensure functionality is preserved once refactoring is complete. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12712) Refactor MacroFormRenderer to use RenderableFtlElements for date-find fields
[ https://issues.apache.org/jira/browse/OFBIZ-12712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635974#comment-17635974 ] ASF subversion and git services commented on OFBIZ-12712: - Commit c7bdaf160599187f87a8a90e9f39e6aa0dec800c in ofbiz-framework's branch refs/heads/trunk from Daniel Watford [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=c7bdaf1605 ] Improved: MacroFormRenderer refactoring of datefind fields (OFBIZ-12712) Part of the OFBIZ-11456 MacroFormRenderer refactoring effort. Rather than MacroFormRenderer producing and evaulating FTL strings, it now uses RenderableFtlElementsBuilder to create RenderableFtlMacroCall objects for datefind fields which are then passed to an FtlWriter for evaluation. Removed unused parameters from the renderDateFindField FTL macro definition. Set defaults for several parameters, simplifying generation of macro calls. Synchronised the parameter list of rendateDateFindField macros across all output types - i.e. html, xml, text, etc. > Refactor MacroFormRenderer to use RenderableFtlElements for date-find fields > > > Key: OFBIZ-12712 > URL: https://issues.apache.org/jira/browse/OFBIZ-12712 > Project: OFBiz > Issue Type: Sub-task > Components: framework/widget >Affects Versions: Upcoming Branch >Reporter: Daniel Watford >Assignee: Daniel Watford >Priority: Minor > > As part of refactoring MacroFormRenderer (OFBIZ-11456), the > renderDateFindField method should be refactored to create > RenderableFtlElements and pass them to an FtlWriter. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [ofbiz-framework] danwatford merged pull request #565: Improved: MacroFormRenderer refactoring of datefind fields (OFBIZ-12712)
danwatford merged PR #565: URL: https://github.com/apache/ofbiz-framework/pull/565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user danwatford (triggered by danwatford). Head commit for run: 307b80231af5905c7fa0c11cebba05bfaf4f1796 / Daniel Watford Fixed: Typo in javadoc tag for StaticContentUrlProvider Report URL: https://github.com/apache/ofbiz-framework/actions/runs/3498987733 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #565: Improved: MacroFormRenderer refactoring of datefind fields (OFBIZ-12712)
sonarcloud[bot] commented on PR #565: URL: https://github.com/apache/ofbiz-framework/pull/565#issuecomment-1320330521 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=565) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=565=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=565=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=565=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=565=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=565=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=565=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=565=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=565=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=565=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=565=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=565=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=565=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=565) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=565=new_duplicated_lines_density=list) [1.4% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=565=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (OFBIZ-12126) Refactor MacroFormRenderer to use RenderableFtlElements for datetime fields
[ https://issues.apache.org/jira/browse/OFBIZ-12126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Watford closed OFBIZ-12126. -- Fix Version/s: Upcoming Branch Resolution: Fixed > Refactor MacroFormRenderer to use RenderableFtlElements for datetime fields > --- > > Key: OFBIZ-12126 > URL: https://issues.apache.org/jira/browse/OFBIZ-12126 > Project: OFBiz > Issue Type: Sub-task > Components: framework/widget >Affects Versions: Trunk, Upcoming Branch >Reporter: Daniel Watford >Assignee: Daniel Watford >Priority: Minor > Fix For: Upcoming Branch > > > As part of refactoring MacroFormRenderer (OFBIZ-11456), the > renderDateTimeField method should be refactored to create > RenderableFtlElements and pass them to an FtlWriter. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user danwatford (triggered by danwatford). Head commit for run: 303a0402145740b038fdb09637c1e65073d05207 / Daniel Watford Improved: MacroFormRenderer refactoring of datefind fields (OFBIZ-12712) Part of the OFBIZ-11456 MacroFormRenderer refactoring effort. Rather than MacroFormRenderer producing and evaulating FTL strings, it now uses RenderableFtlElementsBuilder to create RenderableFtlMacroCall objects for datefind fields which are then passed to an FtlWriter for evaluation. Removed unused parameters from the renderDateFindField FTL macro definition. Set defaults for several parameters, simplifying generation of macro calls. Synchronised the parameter list of rendateDateFindField macros across all output types - i.e. html, xml, text, etc. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/3496041948 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #565: Improved: MacroFormRenderer refactoring of datefind fields (OFBIZ-12712)
sonarcloud[bot] commented on PR #565: URL: https://github.com/apache/ofbiz-framework/pull/565#issuecomment-1319806138 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=565) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=565=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=565=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=565=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=565=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=565=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=565=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=565=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=565=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=565=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=565=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=565=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=565=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=565) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=565=new_duplicated_lines_density=list) [1.4% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=565=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] danwatford opened a new pull request, #565: Improved: MacroFormRenderer refactoring of datefind fields (OFBIZ-12712)
danwatford opened a new pull request, #565: URL: https://github.com/apache/ofbiz-framework/pull/565 Part of the OFBIZ-11456 MacroFormRenderer refactoring effort. Rather than MacroFormRenderer producing and evaulating FTL strings, it now uses RenderableFtlElementsBuilder to create RenderableFtlMacroCall objects for datefind fields which are then passed to an FtlWriter for evaluation. Removed unused parameters from the renderDateFindField FTL macro definition. Set defaults for several parameters, simplifying generation of macro calls. Synchronised the parameter list of rendateDateFindField macros across all output types - i.e. html, xml, text, etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
