[jira] [Commented] (OFBIZ-12725) Cannot expand tree of accounts in Navigate Accounts screen with Helveticus theme
[ https://issues.apache.org/jira/browse/OFBIZ-12725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652462#comment-17652462 ] Florian Motteau commented on OFBIZ-12725: - Good catch [~priyasharma] ! I updated the PR with your third choice. Thanks ! > Cannot expand tree of accounts in Navigate Accounts screen with Helveticus > theme > > > Key: OFBIZ-12725 > URL: https://issues.apache.org/jira/browse/OFBIZ-12725 > Project: OFBiz > Issue Type: Sub-task > Components: accounting, themes/helveticus >Affects Versions: 22.01.01 >Reporter: Daniel Watford >Assignee: Nicolas Malin >Priority: Major > Fix For: 22.01.01 > > Attachments: helvetica-improved.png, helvetica.png, > image-2022-12-27-12-29-02-978.png, image-2022-12-27-12-32-26-819.png, > rainbow.png > > > Viewing [OFBiz: Accounting Manager: Navigate Accounts > (apache.org)|https://demo-next.ofbiz.apache.org/accounting/control/GlAccountNavigate?trail=null], > it is not possible to expand the chart-of-accounts tree when the Helveticus > visual theme is used. > The Helveticus theme is the default theme for new deployments. > A workaround is to switch to a non-Helveticus theme. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #574: Fixed: Add missing CSS for tree select in Helveticus
sonarcloud[bot] commented on PR #574: URL: https://github.com/apache/ofbiz-framework/pull/574#issuecomment-1366563804 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=574) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=574&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=574&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=574&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=574&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=574&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=574&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=574&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=574&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=574&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=574&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=574&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=574&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=574) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=574&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=574&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12730) Tooltip displayed incorrectly on Helvetica theme
[ https://issues.apache.org/jira/browse/OFBIZ-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652452#comment-17652452 ] Jacques Le Roux commented on OFBIZ-12730: - Thanks Priya, I took the initiative to make it a subtask of OFBIZ-12276 > Tooltip displayed incorrectly on Helvetica theme > > > Key: OFBIZ-12730 > URL: https://issues.apache.org/jira/browse/OFBIZ-12730 > Project: OFBiz > Issue Type: Sub-task > Components: product/catalog >Affects Versions: 18.12.06 >Reporter: Priya Sharma >Priority: Minor > Attachments: span-helvetica.png > > > Steps to generate : > 1. Select the Helvetica theme > 2. Navigate to [https://demo-next.ofbiz.apache.org/catalog/control/main] > 3. In the "Browse Catalog/Categories" section, select "Demo Default Search" > The rendered screen has a span for the "Detail Screen" field, which makes it > appear like an error. Please refer to the screenshot for more details. > Update: > Click on "Demo Catalog" to see more of such instances. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12730) Tooltip displayed incorrectly on Helvetica theme
[ https://issues.apache.org/jira/browse/OFBIZ-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-12730: Parent: OFBIZ-12276 Issue Type: Sub-task (was: Bug) > Tooltip displayed incorrectly on Helvetica theme > > > Key: OFBIZ-12730 > URL: https://issues.apache.org/jira/browse/OFBIZ-12730 > Project: OFBiz > Issue Type: Sub-task > Components: product/catalog >Affects Versions: 18.12.06 >Reporter: Priya Sharma >Priority: Minor > Attachments: span-helvetica.png > > > Steps to generate : > 1. Select the Helvetica theme > 2. Navigate to [https://demo-next.ofbiz.apache.org/catalog/control/main] > 3. In the "Browse Catalog/Categories" section, select "Demo Default Search" > The rendered screen has a span for the "Detail Screen" field, which makes it > appear like an error. Please refer to the screenshot for more details. > Update: > Click on "Demo Catalog" to see more of such instances. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12725) Cannot expand tree of accounts in Navigate Accounts screen with Helveticus theme
[ https://issues.apache.org/jira/browse/OFBIZ-12725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652430#comment-17652430 ] Nicolas Malin commented on OFBIZ-12725: --- Thanks [~priyasharma] we will check this > Cannot expand tree of accounts in Navigate Accounts screen with Helveticus > theme > > > Key: OFBIZ-12725 > URL: https://issues.apache.org/jira/browse/OFBIZ-12725 > Project: OFBiz > Issue Type: Sub-task > Components: accounting, themes/helveticus >Affects Versions: 22.01.01 >Reporter: Daniel Watford >Assignee: Nicolas Malin >Priority: Major > Fix For: 22.01.01 > > Attachments: helvetica-improved.png, helvetica.png, > image-2022-12-27-12-29-02-978.png, image-2022-12-27-12-32-26-819.png, > rainbow.png > > > Viewing [OFBiz: Accounting Manager: Navigate Accounts > (apache.org)|https://demo-next.ofbiz.apache.org/accounting/control/GlAccountNavigate?trail=null], > it is not possible to expand the chart-of-accounts tree when the Helveticus > visual theme is used. > The Helveticus theme is the default theme for new deployments. > A workaround is to switch to a non-Helveticus theme. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (OFBIZ-12725) Cannot expand tree of accounts in Navigate Accounts screen with Helveticus theme
[ https://issues.apache.org/jira/browse/OFBIZ-12725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-12725: - Assignee: Nicolas Malin (was: Jacques Le Roux) > Cannot expand tree of accounts in Navigate Accounts screen with Helveticus > theme > > > Key: OFBIZ-12725 > URL: https://issues.apache.org/jira/browse/OFBIZ-12725 > Project: OFBiz > Issue Type: Sub-task > Components: accounting, themes/helveticus >Affects Versions: 22.01.01 >Reporter: Daniel Watford >Assignee: Nicolas Malin >Priority: Major > Fix For: 22.01.01 > > Attachments: helvetica-improved.png, helvetica.png, > image-2022-12-27-12-29-02-978.png, image-2022-12-27-12-32-26-819.png, > rainbow.png > > > Viewing [OFBiz: Accounting Manager: Navigate Accounts > (apache.org)|https://demo-next.ofbiz.apache.org/accounting/control/GlAccountNavigate?trail=null], > it is not possible to expand the chart-of-accounts tree when the Helveticus > visual theme is used. > The Helveticus theme is the default theme for new deployments. > A workaround is to switch to a non-Helveticus theme. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12725) Cannot expand tree of accounts in Navigate Accounts screen with Helveticus theme
[ https://issues.apache.org/jira/browse/OFBIZ-12725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652429#comment-17652429 ] Nicolas Malin commented on OFBIZ-12725: --- [~jleroux] I will take it > Cannot expand tree of accounts in Navigate Accounts screen with Helveticus > theme > > > Key: OFBIZ-12725 > URL: https://issues.apache.org/jira/browse/OFBIZ-12725 > Project: OFBiz > Issue Type: Sub-task > Components: accounting, themes/helveticus >Affects Versions: 22.01.01 >Reporter: Daniel Watford >Assignee: Nicolas Malin >Priority: Major > Fix For: 22.01.01 > > Attachments: helvetica-improved.png, helvetica.png, > image-2022-12-27-12-29-02-978.png, image-2022-12-27-12-32-26-819.png, > rainbow.png > > > Viewing [OFBiz: Accounting Manager: Navigate Accounts > (apache.org)|https://demo-next.ofbiz.apache.org/accounting/control/GlAccountNavigate?trail=null], > it is not possible to expand the chart-of-accounts tree when the Helveticus > visual theme is used. > The Helveticus theme is the default theme for new deployments. > A workaround is to switch to a non-Helveticus theme. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12730) Tooltip displayed incorrectly on Helvetica theme
[ https://issues.apache.org/jira/browse/OFBIZ-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Priya Sharma updated OFBIZ-12730: - Description: Steps to generate : 1. Select the Helvetica theme 2. Navigate to [https://demo-next.ofbiz.apache.org/catalog/control/main] 3. In the "Browse Catalog/Categories" section, select "Demo Default Search" The rendered screen has a span for the "Detail Screen" field, which makes it appear like an error. Please refer to the screenshot for more details. Update: Click on "Demo Catalog" to see more of such instances. was: Steps to generate : 1. Select Helvetica theme 2. Navigate to [https://demo-next.ofbiz.apache.org/catalog/control/main] 3. In the "Browse Catalog/Categories" section, select "Demo Default Search" The rendered screen has a span for the "Detail Screen" field, which makes it appear like an error. Please refer to the screenshot for more details. > Tooltip displayed incorrectly on Helvetica theme > > > Key: OFBIZ-12730 > URL: https://issues.apache.org/jira/browse/OFBIZ-12730 > Project: OFBiz > Issue Type: Bug > Components: product/catalog >Affects Versions: 18.12.06 >Reporter: Priya Sharma >Priority: Minor > Attachments: span-helvetica.png > > > Steps to generate : > 1. Select the Helvetica theme > 2. Navigate to [https://demo-next.ofbiz.apache.org/catalog/control/main] > 3. In the "Browse Catalog/Categories" section, select "Demo Default Search" > The rendered screen has a span for the "Detail Screen" field, which makes it > appear like an error. Please refer to the screenshot for more details. > Update: > Click on "Demo Catalog" to see more of such instances. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12730) Tooltip displayed incorrectly on Helvetica theme
[ https://issues.apache.org/jira/browse/OFBIZ-12730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Priya Sharma updated OFBIZ-12730: - Description: Steps to generate : 1. Select Helvetica theme 2. Navigate to [https://demo-next.ofbiz.apache.org/catalog/control/main] 3. In the "Browse Catalog/Categories" section, select "Demo Default Search" The rendered screen has a span for the "Detail Screen" field, which makes it appear like an error. Please refer to the screenshot for more details. was: Steps to generate : 1. Navigate to [https://demo-next.ofbiz.apache.org/catalog/control/main] 2. In the "Browse Catalog/Categories" section, select "Demo Default Search" The rendered screen has a span for the "Detail Screen" field, which makes it appear like an error. Please refer to the screenshot for more details. > Tooltip displayed incorrectly on Helvetica theme > > > Key: OFBIZ-12730 > URL: https://issues.apache.org/jira/browse/OFBIZ-12730 > Project: OFBiz > Issue Type: Bug > Components: product/catalog >Affects Versions: 18.12.06 >Reporter: Priya Sharma >Priority: Minor > Attachments: span-helvetica.png > > > Steps to generate : > 1. Select Helvetica theme > 2. Navigate to [https://demo-next.ofbiz.apache.org/catalog/control/main] > 3. In the "Browse Catalog/Categories" section, select "Demo Default Search" > The rendered screen has a span for the "Detail Screen" field, which makes it > appear like an error. Please refer to the screenshot for more details. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12730) Tooltip displayed incorrectly on Helvetica theme
Priya Sharma created OFBIZ-12730: Summary: Tooltip displayed incorrectly on Helvetica theme Key: OFBIZ-12730 URL: https://issues.apache.org/jira/browse/OFBIZ-12730 Project: OFBiz Issue Type: Bug Components: product/catalog Affects Versions: 18.12.06 Reporter: Priya Sharma Attachments: span-helvetica.png Steps to generate : 1. Navigate to [https://demo-next.ofbiz.apache.org/catalog/control/main] 2. In the "Browse Catalog/Categories" section, select "Demo Default Search" The rendered screen has a span for the "Detail Screen" field, which makes it appear like an error. Please refer to the screenshot for more details. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12725) Cannot expand tree of accounts in Navigate Accounts screen with Helveticus theme
[
https://issues.apache.org/jira/browse/OFBIZ-12725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652418#comment-17652418
]
Priya Sharma commented on OFBIZ-12725:
--
Hello All,
Thanks, [~FloMo] for the PR, I verified and it works great.
1. The navigation tree is displayed correctly. (/)
2. Able to drill down across child nodes (/)
Although comparing the behavior with the Rainbow stone theme, it differs a bit
for leaf nodes.
However, this is an open question on how we would like the leaf nodes to be
displayed and if we really want them to be consistent across themes or not
(Please feel free to ignore otherwise)
Here are the three probable options:
1. Same as the current Helvetica theme
!helvetica.png!
2. Same as the current Rainbow theme
!rainbow.png!
3. A slightly modified version of the current Helvetica theme
!helvetica-improved.png!
#3 is my personal choice (you would just have to add this CSS in the PR)
{code:java}
.basic-tree li .leafnode {
padding-right: 1em;
margin-right: 4px;
}{code}
> Cannot expand tree of accounts in Navigate Accounts screen with Helveticus
> theme
>
>
> Key: OFBIZ-12725
> URL: https://issues.apache.org/jira/browse/OFBIZ-12725
> Project: OFBiz
> Issue Type: Sub-task
> Components: accounting, themes/helveticus
>Affects Versions: 22.01.01
>Reporter: Daniel Watford
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 22.01.01
>
> Attachments: helvetica-improved.png, helvetica.png,
> image-2022-12-27-12-29-02-978.png, image-2022-12-27-12-32-26-819.png,
> rainbow.png
>
>
> Viewing [OFBiz: Accounting Manager: Navigate Accounts
> (apache.org)|https://demo-next.ofbiz.apache.org/accounting/control/GlAccountNavigate?trail=null],
> it is not possible to expand the chart-of-accounts tree when the Helveticus
> visual theme is used.
> The Helveticus theme is the default theme for new deployments.
> A workaround is to switch to a non-Helveticus theme.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (OFBIZ-12725) Cannot expand tree of accounts in Navigate Accounts screen with Helveticus theme
[ https://issues.apache.org/jira/browse/OFBIZ-12725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Priya Sharma updated OFBIZ-12725: - Attachment: helvetica-improved.png > Cannot expand tree of accounts in Navigate Accounts screen with Helveticus > theme > > > Key: OFBIZ-12725 > URL: https://issues.apache.org/jira/browse/OFBIZ-12725 > Project: OFBiz > Issue Type: Sub-task > Components: accounting, themes/helveticus >Affects Versions: 22.01.01 >Reporter: Daniel Watford >Assignee: Jacques Le Roux >Priority: Major > Fix For: 22.01.01 > > Attachments: helvetica-improved.png, helvetica.png, > image-2022-12-27-12-29-02-978.png, image-2022-12-27-12-32-26-819.png, > rainbow.png > > > Viewing [OFBiz: Accounting Manager: Navigate Accounts > (apache.org)|https://demo-next.ofbiz.apache.org/accounting/control/GlAccountNavigate?trail=null], > it is not possible to expand the chart-of-accounts tree when the Helveticus > visual theme is used. > The Helveticus theme is the default theme for new deployments. > A workaround is to switch to a non-Helveticus theme. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12725) Cannot expand tree of accounts in Navigate Accounts screen with Helveticus theme
[ https://issues.apache.org/jira/browse/OFBIZ-12725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Priya Sharma updated OFBIZ-12725: - Attachment: rainbow.png > Cannot expand tree of accounts in Navigate Accounts screen with Helveticus > theme > > > Key: OFBIZ-12725 > URL: https://issues.apache.org/jira/browse/OFBIZ-12725 > Project: OFBiz > Issue Type: Sub-task > Components: accounting, themes/helveticus >Affects Versions: 22.01.01 >Reporter: Daniel Watford >Assignee: Jacques Le Roux >Priority: Major > Fix For: 22.01.01 > > Attachments: helvetica.png, image-2022-12-27-12-29-02-978.png, > image-2022-12-27-12-32-26-819.png, rainbow.png > > > Viewing [OFBiz: Accounting Manager: Navigate Accounts > (apache.org)|https://demo-next.ofbiz.apache.org/accounting/control/GlAccountNavigate?trail=null], > it is not possible to expand the chart-of-accounts tree when the Helveticus > visual theme is used. > The Helveticus theme is the default theme for new deployments. > A workaround is to switch to a non-Helveticus theme. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12725) Cannot expand tree of accounts in Navigate Accounts screen with Helveticus theme
[ https://issues.apache.org/jira/browse/OFBIZ-12725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Priya Sharma updated OFBIZ-12725: - Attachment: helvetica.png > Cannot expand tree of accounts in Navigate Accounts screen with Helveticus > theme > > > Key: OFBIZ-12725 > URL: https://issues.apache.org/jira/browse/OFBIZ-12725 > Project: OFBiz > Issue Type: Sub-task > Components: accounting, themes/helveticus >Affects Versions: 22.01.01 >Reporter: Daniel Watford >Assignee: Jacques Le Roux >Priority: Major > Fix For: 22.01.01 > > Attachments: helvetica.png, image-2022-12-27-12-29-02-978.png, > image-2022-12-27-12-32-26-819.png, rainbow.png > > > Viewing [OFBiz: Accounting Manager: Navigate Accounts > (apache.org)|https://demo-next.ofbiz.apache.org/accounting/control/GlAccountNavigate?trail=null], > it is not possible to expand the chart-of-accounts tree when the Helveticus > visual theme is used. > The Helveticus theme is the default theme for new deployments. > A workaround is to switch to a non-Helveticus theme. -- This message was sent by Atlassian Jira (v8.20.10#820010)
