[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #601: Fixed: Added accounting main action menu to Organization GL Settings screens (OFBIZ-12771)
sonarcloud[bot] commented on PR #601: URL: https://github.com/apache/ofbiz-framework/pull/601#issuecomment-1460548908 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=601) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=601=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=601=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=601=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=601=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=601=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=601=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=601=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=601=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=601=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=601=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=601=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=601=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=601) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=601=new_duplicated_lines_density=list) [1.4% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=601=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] danwatford opened a new pull request, #601: Fixed: Added accounting main action menu to Organization GL Settings screens (OFBIZ-12771)
danwatford opened a new pull request, #601: URL: https://github.com/apache/ofbiz-framework/pull/601 Clicking on the Create a Gl Transactions button navigates to a screen within the Organisation GL Settings group of screens. Within this context the main actions menu - which included the Create button - is not visible, meaning it is cumbersome for the user to add another transaction. This commit adds the main actions menu to the Organization GL Settings screens, matching the way the actions are displayed in all other Accountancy screens. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (OFBIZ-12771) Confusing steps to create multiple transactions
[ https://issues.apache.org/jira/browse/OFBIZ-12771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Watford reassigned OFBIZ-12771: -- Assignee: Daniel Watford > Confusing steps to create multiple transactions > --- > > Key: OFBIZ-12771 > URL: https://issues.apache.org/jira/browse/OFBIZ-12771 > Project: OFBiz > Issue Type: Bug >Affects Versions: 22.01.01 >Reporter: Daniel Watford >Assignee: Daniel Watford >Priority: Minor > Attachments: image-2023-03-07-14-38-39-731.png, > image-2023-03-07-14-39-48-134.png > > > OFBIZ-12447 removed the _Create an Accounting Transaction_ button from the > Accounting Transactions screens. > Compare the same screen on version 18 vs version 22: > [https://demo-stable.ofbiz.apache.org/accounting/control/FindAcctgTrans?organizationPartyId=Company] > [https://demo-next.ofbiz.apache.org/accounting/control/FindAcctgTrans?organizationPartyId=Company] > > !image-2023-03-07-14-38-39-731.png|width=512,height=247! > > !image-2023-03-07-14-39-48-134.png|width=464,height=239! > The button to create a GL Transaction has instead been made available in menu > MainActionMenu (AccountingMenus.xml). > To create a regular transaction (i.e. non-quick transaction) the user must > navigate to any of the Accounting application's screens via the app > navigation bar EXCEPT for the _Organization GL Settings_ screen. However, > clicking the _Create a Gl Transaction_ button in the menu will navigate the > user to the Organisation GL Settings screen (sub-application?). > The user can create their GL Transaction without issue. But if they then wish > to enter a second transaction, they must navigate away from the Organisation > GL Settings screen so they can once again click on the _Create a Gl > Transaction_ button. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12771) Confusing steps to create multiple transactions
[ https://issues.apache.org/jira/browse/OFBIZ-12771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698002#comment-17698002 ] Daniel Watford commented on OFBIZ-12771: Thanks, [~pierresmits] - I agree this should be a simple fix, but I feel it is patching a symptom rather than the root issue. I think there is a more general usability problem here where the user cannot easily tell what accounting organisation is currently set in their UserPreferences, and it may not be clear how to change the accounting organisation. Consider the case of adding a new person with a user login to the OFBiz instance and assigning them to the SUPER security group. If that user visits the accounting app (e.g. [https://localhost:8443/accounting/control/main] ) the _Create a Gl Transaction_ button will incorrectly assume their ORGANIZATION_PARTY is 'Company', the default value from general.properties. The 'Company' Party may not even exist. The user won't have an ORGANIZATION_PARTY set in UserPreferences until they enter the Organization GL Settings screen and select their company from the list shown. The above usability problem is probably something to discuss in a more broad ticket or the mailing list. In the meantime I'll implement the quick fix to make it easier for users to enter multiple transactions, an activity that might be undertaken by a bookkeeper. > Confusing steps to create multiple transactions > --- > > Key: OFBIZ-12771 > URL: https://issues.apache.org/jira/browse/OFBIZ-12771 > Project: OFBiz > Issue Type: Bug >Affects Versions: 22.01.01 >Reporter: Daniel Watford >Priority: Minor > Attachments: image-2023-03-07-14-38-39-731.png, > image-2023-03-07-14-39-48-134.png > > > OFBIZ-12447 removed the _Create an Accounting Transaction_ button from the > Accounting Transactions screens. > Compare the same screen on version 18 vs version 22: > [https://demo-stable.ofbiz.apache.org/accounting/control/FindAcctgTrans?organizationPartyId=Company] > [https://demo-next.ofbiz.apache.org/accounting/control/FindAcctgTrans?organizationPartyId=Company] > > !image-2023-03-07-14-38-39-731.png|width=512,height=247! > > !image-2023-03-07-14-39-48-134.png|width=464,height=239! > The button to create a GL Transaction has instead been made available in menu > MainActionMenu (AccountingMenus.xml). > To create a regular transaction (i.e. non-quick transaction) the user must > navigate to any of the Accounting application's screens via the app > navigation bar EXCEPT for the _Organization GL Settings_ screen. However, > clicking the _Create a Gl Transaction_ button in the menu will navigate the > user to the Organisation GL Settings screen (sub-application?). > The user can create their GL Transaction without issue. But if they then wish > to enter a second transaction, they must navigate away from the Organisation > GL Settings screen so they can once again click on the _Create a Gl > Transaction_ button. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12771) Confusing steps to create multiple transactions
[ https://issues.apache.org/jira/browse/OFBIZ-12771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697852#comment-17697852 ] Pierre Smits commented on OFBIZ-12771: -- Hi [~danwatford] So, MainActionMenu is missing in the decorator(s) used in GlSetupScreens.xml, GlScreens.xml, ReportFinancialSummaryScreens.xml. That seems to be easy to fix. Best regards, Pierre > Confusing steps to create multiple transactions > --- > > Key: OFBIZ-12771 > URL: https://issues.apache.org/jira/browse/OFBIZ-12771 > Project: OFBiz > Issue Type: Bug >Affects Versions: 22.01.01 >Reporter: Daniel Watford >Priority: Minor > Attachments: image-2023-03-07-14-38-39-731.png, > image-2023-03-07-14-39-48-134.png > > > OFBIZ-12447 removed the _Create an Accounting Transaction_ button from the > Accounting Transactions screens. > Compare the same screen on version 18 vs version 22: > [https://demo-stable.ofbiz.apache.org/accounting/control/FindAcctgTrans?organizationPartyId=Company] > [https://demo-next.ofbiz.apache.org/accounting/control/FindAcctgTrans?organizationPartyId=Company] > > !image-2023-03-07-14-38-39-731.png|width=512,height=247! > > !image-2023-03-07-14-39-48-134.png|width=464,height=239! > The button to create a GL Transaction has instead been made available in menu > MainActionMenu (AccountingMenus.xml). > To create a regular transaction (i.e. non-quick transaction) the user must > navigate to any of the Accounting application's screens via the app > navigation bar EXCEPT for the _Organization GL Settings_ screen. However, > clicking the _Create a Gl Transaction_ button in the menu will navigate the > user to the Organisation GL Settings screen (sub-application?). > The user can create their GL Transaction without issue. But if they then wish > to enter a second transaction, they must navigate away from the Organisation > GL Settings screen so they can once again click on the _Create a Gl > Transaction_ button. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
