[jira] [Updated] (OFBIZ-12823) Improve FileUtil to generate a zip fil with multiple entries
[ https://issues.apache.org/jira/browse/OFBIZ-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-12823: -- Attachment: OFBIZ-12823.patch > Improve FileUtil to generate a zip fil with multiple entries > > > Key: OFBIZ-12823 > URL: https://issues.apache.org/jira/browse/OFBIZ-12823 > Project: OFBiz > Issue Type: Improvement > Components: framework/base >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Labels: util, zip > Attachments: OFBIZ-12823.patch > > > At this time the function to generate a zip file : FileUtil::zipFileStream > (FileUtil:345) offert to possibility to add only one file. > I propose to improve this with a new function zipFileStreams that take a > input map with file name as key and inputStream as value. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12823) Improve FileUtil to generate a zip fil with multiple entries
Nicolas Malin created OFBIZ-12823: - Summary: Improve FileUtil to generate a zip fil with multiple entries Key: OFBIZ-12823 URL: https://issues.apache.org/jira/browse/OFBIZ-12823 Project: OFBiz Issue Type: Improvement Components: framework/base Reporter: Nicolas Malin Assignee: Nicolas Malin At this time the function to generate a zip file : FileUtil::zipFileStream (FileUtil:345) offert to possibility to add only one file. I propose to improve this with a new function zipFileStreams that take a input map with file name as key and inputStream as value. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-10480) Refactoring and Reducing scope of variables in org.apache.ofbiz.common package
[ https://issues.apache.org/jira/browse/OFBIZ-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724196#comment-17724196 ] ASF subversion and git services commented on OFBIZ-10480: - Commit 388139fe4cc6a8c81489f6ceac379a6cda4f8b0d in ofbiz-framework's branch refs/heads/release22.01 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=388139fe4c ] Fixed: Reducing scope of variables in common and base packages (OFBIZ-10477) (OFBIZ-10480) Following https://lists.apache.org/thread/g1z92gtlf9p1rxlc247yg2zqd6bczq7s conversation, this fixes SAFE util methods being transformed to private when obviously they should be public Thanks: Michael for spotting, reporting and confirming it's OK > Refactoring and Reducing scope of variables in org.apache.ofbiz.common package > -- > > Key: OFBIZ-10480 > URL: https://issues.apache.org/jira/browse/OFBIZ-10480 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Pradhan Yash Sharma >Assignee: Jacques Le Roux >Priority: Minor > Fix For: 22.01.01, Upcoming Branch > > Attachments: OFBIZ-10480.patch > > > Updated summary of this ticket to include any code refactoring that can be > done on this package. Not to limit this ticket for only variable/method > scoping. > Please let me know if anyone has any issue and I will revert the update. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-10477) Parent ticket for reducing scope of variables and methods
[
https://issues.apache.org/jira/browse/OFBIZ-10477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724195#comment-17724195
]
ASF subversion and git services commented on OFBIZ-10477:
-
Commit 388139fe4cc6a8c81489f6ceac379a6cda4f8b0d in ofbiz-framework's branch
refs/heads/release22.01 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=388139fe4c ]
Fixed: Reducing scope of variables in common and base packages (OFBIZ-10477)
(OFBIZ-10480)
Following https://lists.apache.org/thread/g1z92gtlf9p1rxlc247yg2zqd6bczq7s
conversation, this fixes SAFE util methods being transformed to private
when obviously they should be public
Thanks: Michael for spotting, reporting and confirming it's OK
> Parent ticket for reducing scope of variables and methods
> -
>
> Key: OFBIZ-10477
> URL: https://issues.apache.org/jira/browse/OFBIZ-10477
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: 22.01.01, Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> *Downsize Accessibility Scope*
> I've tried to downsize accessibility scope of classes, interfaces, abstract
> class, declared member variables, enumerations, methods, and constructors to
> as minimum as possible as per OFBIz current implementation, still there is a
> lot of scope for improvement but it would require changes at the granular
> level. I've used
> [this|https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html]
> as my reference point. example:
>
> {code:java}
> public void noteKeyRemoval(UtilCache cache, K key, V oldValue);{code}
> {code:java}
> void noteKeyRemoval(UtilCache cache, K key, V oldValue); {code}
> As per the current implementation, I will try to give minimum scope
> furthermore can be enhanced
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [ofbiz-framework]: Workflow run "Build and push docker images" is working again!
The GitHub Actions job "Build and push docker images" on ofbiz-framework.git has succeeded. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: b034edd2ab59cfbcf4e28400358c6cd30af5b2dd / Jacques Le Roux Fixed: Reducing scope of variables in common and base packages (OFBIZ-10477) (OFBIZ-10480) Following https://lists.apache.org/thread/g1z92gtlf9p1rxlc247yg2zqd6bczq7s conversation, this fixes SAFE util methods being transformed to private when obviously they should be public Thanks: Michael for spotting, reporting and confirming it's OK Report URL: https://github.com/apache/ofbiz-framework/actions/runs/5022359651 With regards, GitHub Actions via GitBox
[jira] [Updated] (OFBIZ-10480) Refactoring and Reducing scope of variables in org.apache.ofbiz.common package
[ https://issues.apache.org/jira/browse/OFBIZ-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-10480: Fix Version/s: 22.01.01 > Refactoring and Reducing scope of variables in org.apache.ofbiz.common package > -- > > Key: OFBIZ-10480 > URL: https://issues.apache.org/jira/browse/OFBIZ-10480 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Pradhan Yash Sharma >Assignee: Jacques Le Roux >Priority: Minor > Fix For: 22.01.01, Upcoming Branch > > Attachments: OFBIZ-10480.patch > > > Updated summary of this ticket to include any code refactoring that can be > done on this package. Not to limit this ticket for only variable/method > scoping. > Please let me know if anyone has any issue and I will revert the update. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-10478) Reducing scope of variables in org.apache.ofbiz.base package
[ https://issues.apache.org/jira/browse/OFBIZ-10478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-10478: Fix Version/s: 22.01.01 > Reducing scope of variables in org.apache.ofbiz.base package > > > Key: OFBIZ-10478 > URL: https://issues.apache.org/jira/browse/OFBIZ-10478 > Project: OFBiz > Issue Type: Sub-task > Components: base >Affects Versions: Trunk, Upcoming Branch >Reporter: Pradhan Yash Sharma >Assignee: Jacques Le Roux >Priority: Minor > Fix For: 22.01.01, Upcoming Branch > > Attachments: OFBIZ-10478-1.patch, OFBIZ-10478.patch > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-10478) Reducing scope of variables in org.apache.ofbiz.base package
[ https://issues.apache.org/jira/browse/OFBIZ-10478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-10478. --- Resolution: Fixed > Reducing scope of variables in org.apache.ofbiz.base package > > > Key: OFBIZ-10478 > URL: https://issues.apache.org/jira/browse/OFBIZ-10478 > Project: OFBiz > Issue Type: Sub-task > Components: base >Affects Versions: Trunk, Upcoming Branch >Reporter: Pradhan Yash Sharma >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10478-1.patch, OFBIZ-10478.patch > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: b034edd2ab59cfbcf4e28400358c6cd30af5b2dd / Jacques Le Roux Fixed: Reducing scope of variables in common and base packages (OFBIZ-10477) (OFBIZ-10480) Following https://lists.apache.org/thread/g1z92gtlf9p1rxlc247yg2zqd6bczq7s conversation, this fixes SAFE util methods being transformed to private when obviously they should be public Thanks: Michael for spotting, reporting and confirming it's OK Report URL: https://github.com/apache/ofbiz-framework/actions/runs/5022359652 With regards, GitHub Actions via GitBox
[jira] [Commented] (OFBIZ-10480) Refactoring and Reducing scope of variables in org.apache.ofbiz.common package
[ https://issues.apache.org/jira/browse/OFBIZ-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724189#comment-17724189 ] ASF subversion and git services commented on OFBIZ-10480: - Commit b034edd2ab59cfbcf4e28400358c6cd30af5b2dd in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b034edd2ab ] Fixed: Reducing scope of variables in common and base packages (OFBIZ-10477) (OFBIZ-10480) Following https://lists.apache.org/thread/g1z92gtlf9p1rxlc247yg2zqd6bczq7s conversation, this fixes SAFE util methods being transformed to private when obviously they should be public Thanks: Michael for spotting, reporting and confirming it's OK > Refactoring and Reducing scope of variables in org.apache.ofbiz.common package > -- > > Key: OFBIZ-10480 > URL: https://issues.apache.org/jira/browse/OFBIZ-10480 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Pradhan Yash Sharma >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10480.patch > > > Updated summary of this ticket to include any code refactoring that can be > done on this package. Not to limit this ticket for only variable/method > scoping. > Please let me know if anyone has any issue and I will revert the update. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-10477) Parent ticket for reducing scope of variables and methods
[
https://issues.apache.org/jira/browse/OFBIZ-10477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724188#comment-17724188
]
ASF subversion and git services commented on OFBIZ-10477:
-
Commit b034edd2ab59cfbcf4e28400358c6cd30af5b2dd in ofbiz-framework's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b034edd2ab ]
Fixed: Reducing scope of variables in common and base packages (OFBIZ-10477)
(OFBIZ-10480)
Following https://lists.apache.org/thread/g1z92gtlf9p1rxlc247yg2zqd6bczq7s
conversation, this fixes SAFE util methods being transformed to private
when obviously they should be public
Thanks: Michael for spotting, reporting and confirming it's OK
> Parent ticket for reducing scope of variables and methods
> -
>
> Key: OFBIZ-10477
> URL: https://issues.apache.org/jira/browse/OFBIZ-10477
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: 22.01.01, Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> *Downsize Accessibility Scope*
> I've tried to downsize accessibility scope of classes, interfaces, abstract
> class, declared member variables, enumerations, methods, and constructors to
> as minimum as possible as per OFBIz current implementation, still there is a
> lot of scope for improvement but it would require changes at the granular
> level. I've used
> [this|https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html]
> as my reference point. example:
>
> {code:java}
> public void noteKeyRemoval(UtilCache cache, K key, V oldValue);{code}
> {code:java}
> void noteKeyRemoval(UtilCache cache, K key, V oldValue); {code}
> As per the current implementation, I will try to give minimum scope
> furthermore can be enhanced
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [ofbiz-framework]: Workflow run "Build and push docker images" failed!
The GitHub Actions job "Build and push docker images" on ofbiz-framework.git has failed. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: 1786d92df3c1ab4d22d4e668307b5a5e1489293d / Jacques Le Roux Fixed: Reducing scope of variables in common and base packages (OFBIZ-10477) (OFBIZ-10480) Following https://lists.apache.org/thread/g1z92gtlf9p1rxlc247yg2zqd6bczq7s conversation, this fixes SAFE util methods being transformed to private when obviously they should be public Thanks: Michael for spotting, reporting and confirming it's OK Report URL: https://github.com/apache/ofbiz-framework/actions/runs/5022318372 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: 1786d92df3c1ab4d22d4e668307b5a5e1489293d / Jacques Le Roux Fixed: Reducing scope of variables in common and base packages (OFBIZ-10477) (OFBIZ-10480) Following https://lists.apache.org/thread/g1z92gtlf9p1rxlc247yg2zqd6bczq7s conversation, this fixes SAFE util methods being transformed to private when obviously they should be public Thanks: Michael for spotting, reporting and confirming it's OK Report URL: https://github.com/apache/ofbiz-framework/actions/runs/5022318349 With regards, GitHub Actions via GitBox
[jira] [Commented] (OFBIZ-10477) Parent ticket for reducing scope of variables and methods
[
https://issues.apache.org/jira/browse/OFBIZ-10477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724184#comment-17724184
]
ASF subversion and git services commented on OFBIZ-10477:
-
Commit 5ec3789ce1f99622a0373d51d7ad0faf3a09b21d in ofbiz-framework's branch
refs/heads/release22.01 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=5ec3789ce1 ]
Fixed: Reducing scope of variables in common and base packages (OFBIZ-10477)
(OFBIZ-10478)
Following https://lists.apache.org/thread/g1z92gtlf9p1rxlc247yg2zqd6bczq7s
conversation, this fixes SAFE util methods being transformed to private
when obviously they should be public
Thanks: Michael for spotting, reporting and confirming it's OK
# Conflicts:
# framework/base/src/main/java/org/apache/ofbiz/base/util/StringUtil.java
#
framework/base/src/main/java/org/apache/ofbiz/base/util/UtilFormatOut.java
> Parent ticket for reducing scope of variables and methods
> -
>
> Key: OFBIZ-10477
> URL: https://issues.apache.org/jira/browse/OFBIZ-10477
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: 22.01.01, Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> *Downsize Accessibility Scope*
> I've tried to downsize accessibility scope of classes, interfaces, abstract
> class, declared member variables, enumerations, methods, and constructors to
> as minimum as possible as per OFBIz current implementation, still there is a
> lot of scope for improvement but it would require changes at the granular
> level. I've used
> [this|https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html]
> as my reference point. example:
>
> {code:java}
> public void noteKeyRemoval(UtilCache cache, K key, V oldValue);{code}
> {code:java}
> void noteKeyRemoval(UtilCache cache, K key, V oldValue); {code}
> As per the current implementation, I will try to give minimum scope
> furthermore can be enhanced
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-10480) Refactoring and Reducing scope of variables in org.apache.ofbiz.common package
[ https://issues.apache.org/jira/browse/OFBIZ-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724187#comment-17724187 ] ASF subversion and git services commented on OFBIZ-10480: - Commit 1786d92df3c1ab4d22d4e668307b5a5e1489293d in ofbiz-framework's branch refs/heads/release22.01 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=1786d92df3 ] Fixed: Reducing scope of variables in common and base packages (OFBIZ-10477) (OFBIZ-10480) Following https://lists.apache.org/thread/g1z92gtlf9p1rxlc247yg2zqd6bczq7s conversation, this fixes SAFE util methods being transformed to private when obviously they should be public Thanks: Michael for spotting, reporting and confirming it's OK > Refactoring and Reducing scope of variables in org.apache.ofbiz.common package > -- > > Key: OFBIZ-10480 > URL: https://issues.apache.org/jira/browse/OFBIZ-10480 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Pradhan Yash Sharma >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10480.patch > > > Updated summary of this ticket to include any code refactoring that can be > done on this package. Not to limit this ticket for only variable/method > scoping. > Please let me know if anyone has any issue and I will revert the update. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-10478) Reducing scope of variables in org.apache.ofbiz.base package
[ https://issues.apache.org/jira/browse/OFBIZ-10478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724185#comment-17724185 ] ASF subversion and git services commented on OFBIZ-10478: - Commit 5ec3789ce1f99622a0373d51d7ad0faf3a09b21d in ofbiz-framework's branch refs/heads/release22.01 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=5ec3789ce1 ] Fixed: Reducing scope of variables in common and base packages (OFBIZ-10477) (OFBIZ-10478) Following https://lists.apache.org/thread/g1z92gtlf9p1rxlc247yg2zqd6bczq7s conversation, this fixes SAFE util methods being transformed to private when obviously they should be public Thanks: Michael for spotting, reporting and confirming it's OK # Conflicts: # framework/base/src/main/java/org/apache/ofbiz/base/util/StringUtil.java # framework/base/src/main/java/org/apache/ofbiz/base/util/UtilFormatOut.java > Reducing scope of variables in org.apache.ofbiz.base package > > > Key: OFBIZ-10478 > URL: https://issues.apache.org/jira/browse/OFBIZ-10478 > Project: OFBiz > Issue Type: Sub-task > Components: base >Affects Versions: Trunk, Upcoming Branch >Reporter: Pradhan Yash Sharma >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10478-1.patch, OFBIZ-10478.patch > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-10477) Parent ticket for reducing scope of variables and methods
[
https://issues.apache.org/jira/browse/OFBIZ-10477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724186#comment-17724186
]
ASF subversion and git services commented on OFBIZ-10477:
-
Commit 1786d92df3c1ab4d22d4e668307b5a5e1489293d in ofbiz-framework's branch
refs/heads/release22.01 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=1786d92df3 ]
Fixed: Reducing scope of variables in common and base packages (OFBIZ-10477)
(OFBIZ-10480)
Following https://lists.apache.org/thread/g1z92gtlf9p1rxlc247yg2zqd6bczq7s
conversation, this fixes SAFE util methods being transformed to private
when obviously they should be public
Thanks: Michael for spotting, reporting and confirming it's OK
> Parent ticket for reducing scope of variables and methods
> -
>
> Key: OFBIZ-10477
> URL: https://issues.apache.org/jira/browse/OFBIZ-10477
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: 22.01.01, Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> *Downsize Accessibility Scope*
> I've tried to downsize accessibility scope of classes, interfaces, abstract
> class, declared member variables, enumerations, methods, and constructors to
> as minimum as possible as per OFBIz current implementation, still there is a
> lot of scope for improvement but it would require changes at the granular
> level. I've used
> [this|https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html]
> as my reference point. example:
>
> {code:java}
> public void noteKeyRemoval(UtilCache cache, K key, V oldValue);{code}
> {code:java}
> void noteKeyRemoval(UtilCache cache, K key, V oldValue); {code}
> As per the current implementation, I will try to give minimum scope
> furthermore can be enhanced
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-10478) Reducing scope of variables in org.apache.ofbiz.base package
[ https://issues.apache.org/jira/browse/OFBIZ-10478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724159#comment-17724159 ] Michael Brohl commented on OFBIZ-10478: --- Thanks Jacques, just had a quick glance because I'm on my way to vacation but it looks good to me. I don't see a security issue with the mentioned method expandGeoGroup(GenericValue) from the type GeoWorker so it would be good to include it also. > Reducing scope of variables in org.apache.ofbiz.base package > > > Key: OFBIZ-10478 > URL: https://issues.apache.org/jira/browse/OFBIZ-10478 > Project: OFBiz > Issue Type: Sub-task > Components: base >Affects Versions: Trunk, Upcoming Branch >Reporter: Pradhan Yash Sharma >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10478-1.patch, OFBIZ-10478.patch > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
