[jira] [Closed] (OFBIZ-12813) Refactor groovy folder structure and add package declaration
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit closed OFBIZ-12813. Resolution: Fixed +1 for closing the task > Refactor groovy folder structure and add package declaration > > > Key: OFBIZ-12813 > URL: https://issues.apache.org/jira/browse/OFBIZ-12813 > Project: OFBiz > Issue Type: Bug >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Wiebke Paetzold >Assignee: Michael Brohl >Priority: Major > Fix For: Upcoming Branch > > > Due to the upgrade to jdk17 all groovy Classes need a package declaration. > To get a distinct package naming a consistent folder structure is needed. > For example, under framework -> base -> src there is a distinction between > main and test. Within the test folder there is again a distinction between > groovy and Java. > This scheme should be applied everywhere. So a src folder contains main, > test, ... within these folders there is again a distinction between groovy > and java. > > For more information visit: > [http://groovy-lang.org/releasenotes/groovy-3.0.html#Groovy3.0releasenotes-Splitpackages] > “The Java Platform Module System requires that classes in distinct modules > have distinct package names. Groovy has its own "modules" but these haven’t > historically been structured according to the above requirement. For this > reason, Groovy 2.x and 3.0 should be added to the classpath not module path > when using JDK9+. This places Groovy’s classes into the unnamed module where > the split package naming requirement is not enforced.“ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12813) Refactor groovy folder structure and add package declaration
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752138#comment-17752138 ] Michael Brohl commented on OFBIZ-12813: --- +1 for closing [~deepak] the dependency to the projectmgr is checked, the code checks if the projectmgr plugin is active and renders the screen if so. > Refactor groovy folder structure and add package declaration > > > Key: OFBIZ-12813 > URL: https://issues.apache.org/jira/browse/OFBIZ-12813 > Project: OFBiz > Issue Type: Bug >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Wiebke Paetzold >Assignee: Michael Brohl >Priority: Major > Fix For: Upcoming Branch > > > Due to the upgrade to jdk17 all groovy Classes need a package declaration. > To get a distinct package naming a consistent folder structure is needed. > For example, under framework -> base -> src there is a distinction between > main and test. Within the test folder there is again a distinction between > groovy and Java. > This scheme should be applied everywhere. So a src folder contains main, > test, ... within these folders there is again a distinction between groovy > and java. > > For more information visit: > [http://groovy-lang.org/releasenotes/groovy-3.0.html#Groovy3.0releasenotes-Splitpackages] > “The Java Platform Module System requires that classes in distinct modules > have distinct package names. Groovy has its own "modules" but these haven’t > historically been structured according to the above requirement. For this > reason, Groovy 2.x and 3.0 should be added to the classpath not module path > when using JDK9+. This places Groovy’s classes into the unnamed module where > the split package naming requirement is not enforced.“ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12400) Upgrade to gradle 7.6 - support JDK 11 -> 17
[ https://issues.apache.org/jira/browse/OFBIZ-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752135#comment-17752135 ] Michael Brohl commented on OFBIZ-12400: --- [~jleroux] there seem to be a mismatch between the ps1 and sh scripts functionality. The sh script not only downloads the wrapper jar file but also the corresponding properties file. For 7.6.0, it contains gradle-7.6-rc-4-bin.zip instead of gradle-7.6-bin.zip and therefore alters the content and checksums. I tried with 7.6.2, the latest 7.x version and found that the corresponding properties file states the 7.6.1 distribution instead of 7.6.2 which makes the shasum check fail. Looking though the distributions it seems that the properties file is often not correctly edited. I am not sure how much we need to check the file integrity and if we should make the shell script simpler. Any opinions? > Upgrade to gradle 7.6 - support JDK 11 -> 17 > > > Key: OFBIZ-12400 > URL: https://issues.apache.org/jira/browse/OFBIZ-12400 > Project: OFBiz > Issue Type: Task >Reporter: Ioan Eugen Stan >Assignee: Ioan Eugen Stan >Priority: Major > Attachments: OFBIZ-12400-windows-binary.patch > > > For working with Java 17, we need to upgrade to gradle 7.3 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12400) Upgrade to gradle 7.6 - support JDK 11 -> 17
[ https://issues.apache.org/jira/browse/OFBIZ-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752111#comment-17752111 ] Michael Brohl commented on OFBIZ-12400: --- Ah, thanks for the heads-up Jacques. Will provide a pr soon. > Upgrade to gradle 7.6 - support JDK 11 -> 17 > > > Key: OFBIZ-12400 > URL: https://issues.apache.org/jira/browse/OFBIZ-12400 > Project: OFBiz > Issue Type: Task >Reporter: Ioan Eugen Stan >Assignee: Ioan Eugen Stan >Priority: Major > Attachments: OFBIZ-12400-windows-binary.patch > > > For working with Java 17, we need to upgrade to gradle 7.3 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12400) Upgrade to gradle 7.6 - support JDK 11 -> 17
[ https://issues.apache.org/jira/browse/OFBIZ-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752109#comment-17752109 ] Jacques Le Roux commented on OFBIZ-12400: - Hi, What is the situation here? > Upgrade to gradle 7.6 - support JDK 11 -> 17 > > > Key: OFBIZ-12400 > URL: https://issues.apache.org/jira/browse/OFBIZ-12400 > Project: OFBiz > Issue Type: Task >Reporter: Ioan Eugen Stan >Assignee: Ioan Eugen Stan >Priority: Major > Attachments: OFBIZ-12400-windows-binary.patch > > > For working with Java 17, we need to upgrade to gradle 7.3 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12813) Refactor groovy folder structure and add package declaration
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751945#comment-17751945 ] Jacques Le Roux commented on OFBIZ-12813: - Hi, I think we should close here and open a Jira for the issue Deepak reported. Would you do it Deepak? > Refactor groovy folder structure and add package declaration > > > Key: OFBIZ-12813 > URL: https://issues.apache.org/jira/browse/OFBIZ-12813 > Project: OFBiz > Issue Type: Bug >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Wiebke Paetzold >Assignee: Michael Brohl >Priority: Major > Fix For: Upcoming Branch > > > Due to the upgrade to jdk17 all groovy Classes need a package declaration. > To get a distinct package naming a consistent folder structure is needed. > For example, under framework -> base -> src there is a distinction between > main and test. Within the test folder there is again a distinction between > groovy and Java. > This scheme should be applied everywhere. So a src folder contains main, > test, ... within these folders there is again a distinction between groovy > and java. > > For more information visit: > [http://groovy-lang.org/releasenotes/groovy-3.0.html#Groovy3.0releasenotes-Splitpackages] > “The Java Platform Module System requires that classes in distinct modules > have distinct package names. Groovy has its own "modules" but these haven’t > historically been structured according to the above requirement. For this > reason, Groovy 2.x and 3.0 should be added to the classpath not module path > when using JDK9+. This places Groovy’s classes into the unnamed module where > the split package naming requirement is not enforced.“ -- This message was sent by Atlassian Jira (v8.20.10#820010)
