[jira] [Created] (OFBIZ-12893) Screen Security in Party should not show create trigger to user with only VIEW permission.
Pierre Smits created OFBIZ-12893: Summary: Screen Security in Party should not show create trigger to user with only VIEW permission. Key: OFBIZ-12893 URL: https://issues.apache.org/jira/browse/OFBIZ-12893 Project: OFBiz Issue Type: Improvement Components: party Affects Versions: Upcoming Branch Reporter: Pierre Smits When accessing [https://demo-trunk.ofbiz.apache.org/partymgr/control/FindSecurityGroup] as a user with only VIEW permissions (e.g. userId = auditor) the action trigger to create something is shown. This should not be visible to such a user as it leads to an undesired effect and diminished user experience. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12892) Screen Classifications in Party should not show create trigger to user with only VIEW permission
Pierre Smits created OFBIZ-12892: Summary: Screen Classifications in Party should not show create trigger to user with only VIEW permission Key: OFBIZ-12892 URL: https://issues.apache.org/jira/browse/OFBIZ-12892 Project: OFBiz Issue Type: Improvement Components: party Affects Versions: Upcoming Branch Reporter: Pierre Smits When accessing [https://demo-trunk.ofbiz.apache.org/partymgr/control/showclassgroups] as a user with only VIEW permissions (e.g. userId = auditor) the action trigger to create a new Party Classification Group is shown. This should not be visible to such a user as it leads to an undesired effect and diminished user experience. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12891) Screen Communications in Party should not show create trigger to user with VIEW permissions
Pierre Smits created OFBIZ-12891: Summary: Screen Communications in Party should not show create trigger to user with VIEW permissions Key: OFBIZ-12891 URL: https://issues.apache.org/jira/browse/OFBIZ-12891 Project: OFBiz Issue Type: Improvement Components: party Affects Versions: Upcoming Branch Reporter: Pierre Smits When accessing [https://demo-trunk.ofbiz.apache.org/partymgr/control/FindCommunicationEvents] as a user with only VIEW permissions (.e.g. userId = auditor) the action trigger to create a new communication is shown. This should not be visible to such a user as it leads to an undesired effect and diminished user experience. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: e4514d2f54e558064ad4253e49db51b6f3502a9a / Jacques Le Roux Fixed: Missing package and syntax error in FixedAssetServices.groovy (OFBIZ-12890) Fixes Codenarc issues Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7785125884 With regards, GitHub Actions via GitBox
[jira] [Commented] (OFBIZ-12890) Missing package and syntax error in FixedAssetServices.groovy
[ https://issues.apache.org/jira/browse/OFBIZ-12890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814349#comment-17814349 ] ASF subversion and git services commented on OFBIZ-12890: - Commit e4514d2f54e558064ad4253e49db51b6f3502a9a in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=e4514d2f54 ] Fixed: Missing package and syntax error in FixedAssetServices.groovy (OFBIZ-12890) Fixes Codenarc issues > Missing package and syntax error in FixedAssetServices.groovy > - > > Key: OFBIZ-12890 > URL: https://issues.apache.org/jira/browse/OFBIZ-12890 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Upcoming Branch >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Major > Fix For: Upcoming Branch > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: c156ab44141ff166f6620e754ac01df00d5e8a1f / Michael Brohl Fixed: Missing package and syntax error in FixedAssetServices.groovy (OFBIZ-12890) Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7782161538 With regards, GitHub Actions via GitBox
[jira] [Commented] (OFBIZ-12890) Missing package and syntax error in FixedAssetServices.groovy
[ https://issues.apache.org/jira/browse/OFBIZ-12890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814289#comment-17814289 ] ASF subversion and git services commented on OFBIZ-12890: - Commit c156ab44141ff166f6620e754ac01df00d5e8a1f in ofbiz-framework's branch refs/heads/trunk from Michael Brohl [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=c156ab4414 ] Fixed: Missing package and syntax error in FixedAssetServices.groovy (OFBIZ-12890) > Missing package and syntax error in FixedAssetServices.groovy > - > > Key: OFBIZ-12890 > URL: https://issues.apache.org/jira/browse/OFBIZ-12890 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Upcoming Branch >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Major > Fix For: Upcoming Branch > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12890) Missing package and syntax error in FixedAssetServices.groovy
[ https://issues.apache.org/jira/browse/OFBIZ-12890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-12890. - Resolution: Fixed > Missing package and syntax error in FixedAssetServices.groovy > - > > Key: OFBIZ-12890 > URL: https://issues.apache.org/jira/browse/OFBIZ-12890 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Upcoming Branch >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Major > Fix For: Upcoming Branch > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12890) Missing package and syntax error in FixedAssetServices.groovy
Michael Brohl created OFBIZ-12890: - Summary: Missing package and syntax error in FixedAssetServices.groovy Key: OFBIZ-12890 URL: https://issues.apache.org/jira/browse/OFBIZ-12890 Project: OFBiz Issue Type: Bug Components: accounting Affects Versions: Upcoming Branch Reporter: Michael Brohl Assignee: Michael Brohl Fix For: Upcoming Branch -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12888) Gradle eclipse target produces duplicate build path entries in .classpath
[
https://issues.apache.org/jira/browse/OFBIZ-12888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl closed OFBIZ-12888.
-
Fix Version/s: Upcoming Branch
Resolution: Fixed
> Gradle eclipse target produces duplicate build path entries in .classpath
> -
>
> Key: OFBIZ-12888
> URL: https://issues.apache.org/jira/browse/OFBIZ-12888
> Project: OFBiz
> Issue Type: Bug
> Components: Gradle
>Affects Versions: Upcoming Branch
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Major
> Fix For: Upcoming Branch
>
>
> I'm currently working on a solution for this.
> Maybe someone can explain why we use the GroovyScripts source set for the
> codenarc checks in the pre-push hook:
>
> {code:java}
> gitHooks {
>hooks = ['pre-push': 'checkstyleMain codenarcGroovyScripts']
> }
> {code}
> That target seems to be automatically defined through the source set
> definition for groovyScripts.
> If I remove that source set and the following task configuration:
>
> {code:java}
> tasks.named('compileGroovyScriptsGroovy') {
> // We don't want to build groovyScripts as they should be considered as
> standalone elements executed in
> // isolation by ofbiz. Building them will result in numerous error due to
> duplicated classes.
> enabled = false
> }
> {code}
>
> And change the git hooks to
>
> {code:java}
> }
> gitHooks {
> hooks = ['pre-push': 'checkstyleMain codenarcMain codenarcTest']
> }
> {code}
>
> (which is accoring to the pre-push hook definition in .git/hooks/pre-push)
> everything seems to work fine, tests are working and the codenarc Main and
> Test reports are build.
> I provide a PR for it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (OFBIZ-12888) Gradle eclipse target produces duplicate build path entries in .classpath
[
https://issues.apache.org/jira/browse/OFBIZ-12888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814288#comment-17814288
]
Michael Brohl edited comment on OFBIZ-12888 at 2/5/24 9:10 AM:
---
[~jleroux] I appreciate you help but would also appreciate if you could take
your time when doing changes/reverts etc. on the work of others.
You could simply let me commit my work which was based upon the latest trunk
changes. Now it was incomplete/has errors (see my last commit) and I was not
able to merge my PR due to conflicts based on your changes. Also the history
now looks poor.
was (Author: mbrohl):
[~jleroux] I appreciate you help but would also appreciate if you could take
your time when doing changes/reverts etc. on the work of others.
You could simply let me commit my work which was based upon the latest trunk
changes. Now it was incomplete/has errors (see my last commit) and I was not
able to merge my PR due to conflicts based on your changes.
> Gradle eclipse target produces duplicate build path entries in .classpath
> -
>
> Key: OFBIZ-12888
> URL: https://issues.apache.org/jira/browse/OFBIZ-12888
> Project: OFBiz
> Issue Type: Bug
> Components: Gradle
>Affects Versions: Upcoming Branch
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Major
> Fix For: Upcoming Branch
>
>
> I'm currently working on a solution for this.
> Maybe someone can explain why we use the GroovyScripts source set for the
> codenarc checks in the pre-push hook:
>
> {code:java}
> gitHooks {
>hooks = ['pre-push': 'checkstyleMain codenarcGroovyScripts']
> }
> {code}
> That target seems to be automatically defined through the source set
> definition for groovyScripts.
> If I remove that source set and the following task configuration:
>
> {code:java}
> tasks.named('compileGroovyScriptsGroovy') {
> // We don't want to build groovyScripts as they should be considered as
> standalone elements executed in
> // isolation by ofbiz. Building them will result in numerous error due to
> duplicated classes.
> enabled = false
> }
> {code}
>
> And change the git hooks to
>
> {code:java}
> }
> gitHooks {
> hooks = ['pre-push': 'checkstyleMain codenarcMain codenarcTest']
> }
> {code}
>
> (which is accoring to the pre-push hook definition in .git/hooks/pre-push)
> everything seems to work fine, tests are working and the codenarc Main and
> Test reports are build.
> I provide a PR for it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12888) Gradle eclipse target produces duplicate build path entries in .classpath
[
https://issues.apache.org/jira/browse/OFBIZ-12888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814288#comment-17814288
]
Michael Brohl commented on OFBIZ-12888:
---
[~jleroux] I appreciate you help but would also appreciate if you could take
your time when doing changes/reverts etc. on the work of others.
You could simply let me commit my work which was based upon the latest trunk
changes. Now it was incomplete/has errors (see my last commit) and I was not
able to merge my PR due to conflicts based on your changes.
> Gradle eclipse target produces duplicate build path entries in .classpath
> -
>
> Key: OFBIZ-12888
> URL: https://issues.apache.org/jira/browse/OFBIZ-12888
> Project: OFBiz
> Issue Type: Bug
> Components: Gradle
>Affects Versions: Upcoming Branch
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Major
>
> I'm currently working on a solution for this.
> Maybe someone can explain why we use the GroovyScripts source set for the
> codenarc checks in the pre-push hook:
>
> {code:java}
> gitHooks {
>hooks = ['pre-push': 'checkstyleMain codenarcGroovyScripts']
> }
> {code}
> That target seems to be automatically defined through the source set
> definition for groovyScripts.
> If I remove that source set and the following task configuration:
>
> {code:java}
> tasks.named('compileGroovyScriptsGroovy') {
> // We don't want to build groovyScripts as they should be considered as
> standalone elements executed in
> // isolation by ofbiz. Building them will result in numerous error due to
> duplicated classes.
> enabled = false
> }
> {code}
>
> And change the git hooks to
>
> {code:java}
> }
> gitHooks {
> hooks = ['pre-push': 'checkstyleMain codenarcMain codenarcTest']
> }
> {code}
>
> (which is accoring to the pre-push hook definition in .git/hooks/pre-push)
> everything seems to work fine, tests are working and the codenarc Main and
> Test reports are build.
> I provide a PR for it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12888) Gradle eclipse target produces duplicate build path entries in .classpath
[
https://issues.apache.org/jira/browse/OFBIZ-12888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814286#comment-17814286
]
ASF subversion and git services commented on OFBIZ-12888:
-
Commit b39705474062afe91aec6a35a6311cc4a242e078 in ofbiz-framework's branch
refs/heads/trunk from Michael Brohl
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b397054740 ]
Fixed: Corrects improper/incomplete changes (OFBIZ-12888)
> Gradle eclipse target produces duplicate build path entries in .classpath
> -
>
> Key: OFBIZ-12888
> URL: https://issues.apache.org/jira/browse/OFBIZ-12888
> Project: OFBiz
> Issue Type: Bug
> Components: Gradle
>Affects Versions: Upcoming Branch
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Major
>
> I'm currently working on a solution for this.
> Maybe someone can explain why we use the GroovyScripts source set for the
> codenarc checks in the pre-push hook:
>
> {code:java}
> gitHooks {
>hooks = ['pre-push': 'checkstyleMain codenarcGroovyScripts']
> }
> {code}
> That target seems to be automatically defined through the source set
> definition for groovyScripts.
> If I remove that source set and the following task configuration:
>
> {code:java}
> tasks.named('compileGroovyScriptsGroovy') {
> // We don't want to build groovyScripts as they should be considered as
> standalone elements executed in
> // isolation by ofbiz. Building them will result in numerous error due to
> duplicated classes.
> enabled = false
> }
> {code}
>
> And change the git hooks to
>
> {code:java}
> }
> gitHooks {
> hooks = ['pre-push': 'checkstyleMain codenarcMain codenarcTest']
> }
> {code}
>
> (which is accoring to the pre-push hook definition in .git/hooks/pre-push)
> everything seems to work fine, tests are working and the codenarc Main and
> Test reports are build.
> I provide a PR for it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (OFBIZ-12888) Gradle eclipse target produces duplicate build path entries in .classpath
[
https://issues.apache.org/jira/browse/OFBIZ-12888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814281#comment-17814281
]
Jacques Le Roux edited comment on OFBIZ-12888 at 2/5/24 8:55 AM:
-
I have done all necessary changes, in BB too. The result will soon be available
on site at https://nightlies.apache.org/ofbiz/trunk/codenarc.html
Then we can close here.
was (Author: jacques.le.roux):
I have done all necessary changes, in BB too. The result will soon be available
on site at https://nightlies.apache.org/ofbiz/trunk/codenarc.html;
Then we can close here.
> Gradle eclipse target produces duplicate build path entries in .classpath
> -
>
> Key: OFBIZ-12888
> URL: https://issues.apache.org/jira/browse/OFBIZ-12888
> Project: OFBiz
> Issue Type: Bug
> Components: Gradle
>Affects Versions: Upcoming Branch
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Major
>
> I'm currently working on a solution for this.
> Maybe someone can explain why we use the GroovyScripts source set for the
> codenarc checks in the pre-push hook:
>
> {code:java}
> gitHooks {
>hooks = ['pre-push': 'checkstyleMain codenarcGroovyScripts']
> }
> {code}
> That target seems to be automatically defined through the source set
> definition for groovyScripts.
> If I remove that source set and the following task configuration:
>
> {code:java}
> tasks.named('compileGroovyScriptsGroovy') {
> // We don't want to build groovyScripts as they should be considered as
> standalone elements executed in
> // isolation by ofbiz. Building them will result in numerous error due to
> duplicated classes.
> enabled = false
> }
> {code}
>
> And change the git hooks to
>
> {code:java}
> }
> gitHooks {
> hooks = ['pre-push': 'checkstyleMain codenarcMain codenarcTest']
> }
> {code}
>
> (which is accoring to the pre-push hook definition in .git/hooks/pre-push)
> everything seems to work fine, tests are working and the codenarc Main and
> Test reports are build.
> I provide a PR for it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12888) Gradle eclipse target produces duplicate build path entries in .classpath
[
https://issues.apache.org/jira/browse/OFBIZ-12888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814281#comment-17814281
]
Jacques Le Roux commented on OFBIZ-12888:
-
I have done all necessary changes, in BB too. The result will soon be available
on site at https://nightlies.apache.org/ofbiz/trunk/codenarc.html;
Then we can close here.
> Gradle eclipse target produces duplicate build path entries in .classpath
> -
>
> Key: OFBIZ-12888
> URL: https://issues.apache.org/jira/browse/OFBIZ-12888
> Project: OFBiz
> Issue Type: Bug
> Components: Gradle
>Affects Versions: Upcoming Branch
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Major
>
> I'm currently working on a solution for this.
> Maybe someone can explain why we use the GroovyScripts source set for the
> codenarc checks in the pre-push hook:
>
> {code:java}
> gitHooks {
>hooks = ['pre-push': 'checkstyleMain codenarcGroovyScripts']
> }
> {code}
> That target seems to be automatically defined through the source set
> definition for groovyScripts.
> If I remove that source set and the following task configuration:
>
> {code:java}
> tasks.named('compileGroovyScriptsGroovy') {
> // We don't want to build groovyScripts as they should be considered as
> standalone elements executed in
> // isolation by ofbiz. Building them will result in numerous error due to
> duplicated classes.
> enabled = false
> }
> {code}
>
> And change the git hooks to
>
> {code:java}
> }
> gitHooks {
> hooks = ['pre-push': 'checkstyleMain codenarcMain codenarcTest']
> }
> {code}
>
> (which is accoring to the pre-push hook definition in .git/hooks/pre-push)
> everything seems to work fine, tests are working and the codenarc Main and
> Test reports are build.
> I provide a PR for it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Fixed: Gradle eclipse target produces duplicate build path entries in .classpath (OFBIZ-12888) [ofbiz-framework]
sonarcloud[bot] commented on PR #687: URL: https://github.com/apache/ofbiz-framework/pull/687#issuecomment-1926488584 ## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=687) **Quality Gate passed** Kudos, no new issues were introduced! [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=687=false=true) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=687=false=true) No data about Coverage No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=687) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12850) Duplicate class ... hot reload failed
[
https://issues.apache.org/jira/browse/OFBIZ-12850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814277#comment-17814277
]
Ingo Wolfmayr commented on OFBIZ-12850:
---
Hi [~danwatford] ,
as [~jleroux] mentioned, it seems to be related to OFBIZ-12888
I already managed to get it working by deleting ./build directory, create the
build and start ofbiz in debug mode. Also I added "Script" to any groovy file
name in my addons in order to avoid having duplicate class names. If I build
ofbiz without clearing the ./build directory the error will come up again.
*About the steps:*
I have gradle tasks in my IDE (I moved from eclipse to Intellj, but the setup
is almost the same).
Task 1: build (build -x distTar -x distZip)
Task 2: start (ofbiz --debug-jvm)
Task 3: debug (remote application)
> Duplicate class ... hot reload failed
> -
>
> Key: OFBIZ-12850
> URL: https://issues.apache.org/jira/browse/OFBIZ-12850
> Project: OFBiz
> Issue Type: Improvement
>Reporter: Ingo Wolfmayr
>Priority: Major
>
> I have the problem, that with the current trunk, hot-reloading java code
> failed.
> Sometimes (I have not clue by now why not every-time) building the project
> printed the following error and failed:
> {noformat}
> Entry org/apache/ofbiz/accounting/GlEvents.class is a duplicate but no
> duplicate handling strategy has been set. Please refer to
> https://docs.gradle.org/7.6/dsl/org.gradle.api.tasks.Copy.html#org.gradle.api.tasks.Copy:duplicatesStrategy
> for details.{noformat}
> There is no duplicate groovy or java that could lead to
> org/apache/ofbiz/accounting/GlEvents.class is a duplicate
> I have not finished my investigation yet. If someone has an idea, please let
> me know.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12888) Gradle eclipse target produces duplicate build path entries in .classpath
[
https://issues.apache.org/jira/browse/OFBIZ-12888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814257#comment-17814257
]
Michael Brohl commented on OFBIZ-12888:
---
It would have been better to leave the code base as is, because my PR is based
on latest trunk...
Anyway, I'll make a new one/amend the existing.
Thanks Daniel for the clear explanation.
> Gradle eclipse target produces duplicate build path entries in .classpath
> -
>
> Key: OFBIZ-12888
> URL: https://issues.apache.org/jira/browse/OFBIZ-12888
> Project: OFBiz
> Issue Type: Bug
> Components: Gradle
>Affects Versions: Upcoming Branch
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Major
>
> I'm currently working on a solution for this.
> Maybe someone can explain why we use the GroovyScripts source set for the
> codenarc checks in the pre-push hook:
>
> {code:java}
> gitHooks {
>hooks = ['pre-push': 'checkstyleMain codenarcGroovyScripts']
> }
> {code}
> That target seems to be automatically defined through the source set
> definition for groovyScripts.
> If I remove that source set and the following task configuration:
>
> {code:java}
> tasks.named('compileGroovyScriptsGroovy') {
> // We don't want to build groovyScripts as they should be considered as
> standalone elements executed in
> // isolation by ofbiz. Building them will result in numerous error due to
> duplicated classes.
> enabled = false
> }
> {code}
>
> And change the git hooks to
>
> {code:java}
> }
> gitHooks {
> hooks = ['pre-push': 'checkstyleMain codenarcMain codenarcTest']
> }
> {code}
>
> (which is accoring to the pre-push hook definition in .git/hooks/pre-push)
> everything seems to work fine, tests are working and the codenarc Main and
> Test reports are build.
> I provide a PR for it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (OFBIZ-12889) Expose runtime/logs directory to host for demo docker containers
Daniel Watford created OFBIZ-12889: -- Summary: Expose runtime/logs directory to host for demo docker containers Key: OFBIZ-12889 URL: https://issues.apache.org/jira/browse/OFBIZ-12889 Project: OFBiz Issue Type: Task Components: Demo Affects Versions: Upcoming Branch Reporter: Daniel Watford Assignee: Daniel Watford OFBiz writes to various log files at path runtime/logs. These log files are not easily* accessible by administrators on hosts running OFBiz in docker containers, such as the project's demo sites. Modify the demo sites configuration and the example docker configurations to make the various OFBiz logs accessible to administrators. * The log files can currently be accessed by exec'ing processes in a running container, but this is cumbersome and not something we should expect system administrators to do. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12888) Gradle eclipse target produces duplicate build path entries in .classpath
[
https://issues.apache.org/jira/browse/OFBIZ-12888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814228#comment-17814228
]
ASF subversion and git services commented on OFBIZ-12888:
-
Commit 6d31c0d3ebcffe62b2a0adc8af04564d4033d990 in ofbiz-framework's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=6d31c0d3eb ]
Improved: Gradle eclipse target produces duplicate build path entries in
.classpath
Damn forgot this one too
This completes previous commits by replacing now useless
compileGroovyScriptsGroovy by "codenarcMain codenarcTest" in gitHooks Gradle
task
The explanation is in OFBIZ-12888
I'll close INFRA-25456
> Gradle eclipse target produces duplicate build path entries in .classpath
> -
>
> Key: OFBIZ-12888
> URL: https://issues.apache.org/jira/browse/OFBIZ-12888
> Project: OFBiz
> Issue Type: Bug
> Components: Gradle
>Affects Versions: Upcoming Branch
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Major
>
> I'm currently working on a solution for this.
> Maybe someone can explain why we use the GroovyScripts source set for the
> codenarc checks in the pre-push hook:
>
> {code:java}
> gitHooks {
>hooks = ['pre-push': 'checkstyleMain codenarcGroovyScripts']
> }
> {code}
> That target seems to be automatically defined through the source set
> definition for groovyScripts.
> If I remove that source set and the following task configuration:
>
> {code:java}
> tasks.named('compileGroovyScriptsGroovy') {
> // We don't want to build groovyScripts as they should be considered as
> standalone elements executed in
> // isolation by ofbiz. Building them will result in numerous error due to
> duplicated classes.
> enabled = false
> }
> {code}
>
> And change the git hooks to
>
> {code:java}
> }
> gitHooks {
> hooks = ['pre-push': 'checkstyleMain codenarcMain codenarcTest']
> }
> {code}
>
> (which is accoring to the pre-push hook definition in .git/hooks/pre-push)
> everything seems to work fine, tests are working and the codenarc Main and
> Test reports are build.
> I provide a PR for it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
