[jira] [Commented] (OFBIZ-13005) Trunk demo errors in error.log
[
https://issues.apache.org/jira/browse/OFBIZ-13005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834986#comment-17834986
]
Jacques Le Roux commented on OFBIZ-13005:
-
Hi [~pierresmits],
There are some errors that seems related to your work with "Lists and grids"
like https://github.com/apache/ofbiz-framework/commit/c78c1f1 where you forgot
to remove {{}} now a grid
and I did not spot. Please have a look a the similar ones reported above.
ListWorkEfforts, the 1st error in description could be one of them... TIA
> Trunk demo errors in error.log
> --
>
> Key: OFBIZ-13005
> URL: https://issues.apache.org/jira/browse/OFBIZ-13005
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Priority: Major
>
> For 3 days now I have collected the trunk demo errors in error.log.
> I did check the value of them but some could still be minor.
> Here is the result to be better filterered:
> {noformat}
> 2024-04-04 12:31:19,135 |-0.0.0.0-8009-exec-9 |ModelSingleForm
> |E| Failed to load parent form definition 'ListWorkEfforts' at resource
> 'component://workeffort/widget/WorkEffortForms.xml'
> java.lang.NullPointerException: Cannot invoke
> "org.w3c.dom.Element.getAttribute(String)" because "formElement" is null
> 2024-04-04 12:35:00,432 |-0.0.0.0-8009-exec-8 |ControlServlet
> |E| Error in request handler:
> java.lang.RuntimeException: Error rendering included menu named
> [MainActionMenu] at location [component://myportal/widget/MyPortalMenus.xml]:
> java.lang.IllegalArgumentException: Could not find menu with name
> [MainActionMenu] in location [component://myportal/widget/MyPortalMenus.xml]
> 2024-04-04 12:34:49,329 |-0.0.0.0-8009-exec-5 |ControlServlet
> |E| Error in request handler:
> java.lang.RuntimeException: Error rendering included menu named
> [RequestScreenletMenu] at location
> [component://myportal/widget/MyPortalMenus.xml]:
> java.lang.IllegalArgumentException: Could not find menu with name
> [RequestScreenletMenu] in location
> [component://myportal/widget/MyPortalMenus.xml]
> at java.lang.Thread.run(Thread.java:840) [?:?]
> 2024-04-04 12:34:53,562 |0.0.0.0-8009-exec-10 |ControlServlet
> |E| Error in request handler:
> java.lang.RuntimeException: Error rendering included menu named
> [PersonUpdate] at location [component://myportal/widget/MyPortalMenus.xml]:
> java.lang.IllegalArgumentException: Could not find menu with name
> [PersonUpdate] in location [component://myportal/widget/MyPortalMenus.xml]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$Menu.getModelMenu(ModelScreenWidget.java:1648)
> ~[ofbiz.jar:?]
> 2024-04-05 12:53:05,232 |-0.0.0.0-8009-exec-5 |FreeMarkerWorker
> |E| null
> freemarker.core._MiscTemplateException: Macro "renderDateTimeField" has no
> parameter with name "dateType". Valid parameter names are: name, className,
> timeDropdownParamName, defaultDateTimeString, localizedIconTitle,
> timeHourName, timeMinutesName, ampmName, compositeType, alert, isTimeType,
> isDateType, amSelected, pmSelected, timeDropdown, classString, isTwelveHour,
> hour1, hour2, minutes, shortDateInput, title, value, size, maxlength, id,
> formName, mask, event, action, step, timeValues, tabindex, disabled,
> isXMLHttpRequest
>
> FTL stack trace ("~" means nesting-related):
> - Failed at: @htmlTemplate.renderDateTimeField eve... [in template
> "component://ecommerce/template/catalog/ProductDetail.ftl" at line 726,
> column 17]
> 2024-04-05 15:50:42,492 |-0.0.0.0-8009-exec-4 |UtilXml
> |E| XmlFileLoader: File
> file:/ofbiz/framework/common/widget/PortalPageScreens.xml process error.
> Line: 82. Error message: cvc-datatype-valid.1.2.1: '${parameters.confMode}'
> is not a valid value for 'boolean'.
> 2024-04-05 15:50:42,492 |-0.0.0.0-8009-exec-4 |UtilXml
> |E| XmlFileLoader: File
> file:/ofbiz/framework/common/widget/PortalPageScreens.xml process error.
> Line: 82. Error message: cvc-datatype-valid.1.2.1: '${parameters.usePrivate}'
> is not a valid value for 'boolean'.
> 2024-04-06 07:04:58,770 |-0.0.0.0-8009-exec-2 |UtilXml
> |E| XmlFileLoader: File
> file:/ofbiz/framework/common/widget/PortalPageScreens.xml process error.
> Line: 82. Error message: cvc-datatype-valid.1.2.1: '${parameters.confMode}'
> is not a valid value for 'boolean'.
> 2024-04-06 07:04:58,771 |-0.0.0.0-8009-exec-2 |UtilXml
> |E| XmlFileLoader: File
> file:/ofbiz/framework/common/widget/PortalPageScreens.xml process error.
> Line: 82. Error message: cvc-datatype-valid.1.2.1: '${parameters.usePrivate}'
> is not a valid value for 'boolean'.
>
[jira] [Commented] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834981#comment-17834981
]
Jacques Le Roux commented on OFBIZ-11067:
-
Hi [~pgil], would you mind handle it?
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch,
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch,
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch,
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch,
> OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch,
> OFBIZ-11067_0018-Turn-UtilObjectTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0019-Merge-UtilObjectUnitTest-into-UtilObjectTes.patch,
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests-1.patch,
>
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests-1.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-13005) Trunk demo errors in error.log
[
https://issues.apache.org/jira/browse/OFBIZ-13005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834960#comment-17834960
]
Jacques Le Roux commented on OFBIZ-13005:
-
Got these (new?) ones today:
2024-04-08 09:27:33,179 |-0.0.0.0-8009-exec-9 |ContentWorker
|E| No dataResourceId found for contentId: STORE_POLICIES
2024-04-08 09:28:21,703 |-0.0.0.0-8009-exec-2 |ServiceUtil
|E| {errorMessage=Product not found in the current category.,
responseMessage=fail}
2024-04-08 09:28:32,819 |-0.0.0.0-8009-exec-4 |FreeMarkerWorker
|E| null
freemarker.core._MiscTemplateException: Macro "renderDateTimeField" has no
parameter with name "dateType". Valid parameter names are: name, className,
timeDropdownParamName, defaultDateTimeString, localizedIconTitle, timeHourName,
timeMinutesName, ampmName, compositeType, alert, isTimeType, isDateType,
amSelected, pmSelected, timeDropdown, classString, isTwelveHour, hour1, hour2,
minutes, shortDateInput, title, value, size, maxlength, id, formName, mask,
event, action, step, timeValues, tabindex, disabled, isXMLHttpRequest
FTL stack trace ("~" means nesting-related):
- Failed at: @htmlTemplate.renderDateTimeField eve... [in template
"component://ecommerce/template/catalog/ProductDetail.ftl" at line 726, column
17]
MAYBE RELATED/
Caused by: java.lang.NullPointerException
at
java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197) ~[?:?]
at
java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625)
~[?:?]
at
java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509) ~[?:?]
at
java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
~[?:?]
at
java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
~[?:?]
at
java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[?:?]
at
java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682) ~[?:?]
at org.apache.ofbiz.base.util.StringUtil.join(StringUtil.java:110)
~[ofbiz.jar:?]
at org.apache.ofbiz.base.util.StringUtil$join$1.call(Unknown Source)
~[?:?]
at org.apache.ofbiz.order.entry.catalog.Product.run(Product.groovy:125)
~[ofbiz.jar:?]
2024-04-08 10:49:29,480 |-0.0.0.0-8009-exec-2 |ModelScreenWidget
|E| Error rendering included form named [ListEmployeeQualification] at location
[component://humanres/widget/forms/EmployeeForms.xml]:
java.lang.NullPointerException: Cannot invoke
"org.w3c.dom.Element.getAttribute(String)" because "formElement" is null
java.lang.NullPointerException: Cannot invoke
"org.w3c.dom.Element.getAttribute(String)" because "formElement" is null
> Trunk demo errors in error.log
> --
>
> Key: OFBIZ-13005
> URL: https://issues.apache.org/jira/browse/OFBIZ-13005
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Priority: Major
>
> For 3 days now I have collected the trunk demo errors in error.log.
> I did check the value of them but some could still be minor.
> Here is the result to be better filterered:
> {noformat}
> 2024-04-04 12:31:19,135 |-0.0.0.0-8009-exec-9 |ModelSingleForm
> |E| Failed to load parent form definition 'ListWorkEfforts' at resource
> 'component://workeffort/widget/WorkEffortForms.xml'
> java.lang.NullPointerException: Cannot invoke
> "org.w3c.dom.Element.getAttribute(String)" because "formElement" is null
> 2024-04-04 12:35:00,432 |-0.0.0.0-8009-exec-8 |ControlServlet
> |E| Error in request handler:
> java.lang.RuntimeException: Error rendering included menu named
> [MainActionMenu] at location [component://myportal/widget/MyPortalMenus.xml]:
> java.lang.IllegalArgumentException: Could not find menu with name
> [MainActionMenu] in location [component://myportal/widget/MyPortalMenus.xml]
> 2024-04-04 12:34:49,329 |-0.0.0.0-8009-exec-5 |ControlServlet
> |E| Error in request handler:
> java.lang.RuntimeException: Error rendering included menu named
> [RequestScreenletMenu] at location
> [component://myportal/widget/MyPortalMenus.xml]:
> java.lang.IllegalArgumentException: Could not find menu with name
> [RequestScreenletMenu] in location
> [component://myportal/widget/MyPortalMenus.xml]
> at java.lang.Thread.run(Thread.java:840) [?:?]
> 2024-04-04 12:34:53,562 |0.0.0.0-8009-exec-10 |ControlServlet
> |E| Error in request handler:
> java.lang.RuntimeException: Error rendering included menu named
> [PersonUpdate] at location [component://myportal/widget/MyPortalMenus.xml]:
> java.lang.IllegalArgumentException: Could not find menu with name
> [PersonUpdate] in
Re: [PR] Bump dompurify from 3.0.11 to 3.1.0 in /themes/common-theme/webapp/common-theme/js [ofbiz-framework]
JacquesLeRoux merged PR #747: URL: https://github.com/apache/ofbiz-framework/pull/747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gaetan Chaboussie updated OFBIZ-11067:
--
Attachment:
OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests-1.patch
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch,
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch,
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch,
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch,
> OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch,
> OFBIZ-11067_0018-Turn-UtilObjectTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0019-Merge-UtilObjectUnitTest-into-UtilObjectTes.patch,
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests-1.patch,
>
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests-1.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834946#comment-17834946
]
Gaetan Chaboussie commented on OFBIZ-11067:
---
Hi, during OFBIZ-12991 i stumbled upon two tests classes that escaped
migration, and that wil be necessary for the migration.
here are the two classes (and the patch that fixes tham). Thanks [~pgil] for
the help
[^OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests.patch]
[^OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests.patch]
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch,
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch,
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch,
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch,
> OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch,
> OFBIZ-11067_0018-Turn-UtilObjectTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0019-Merge-UtilObjectUnitTest-into-UtilObjectTes.patch,
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests-1.patch,
>
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests-1.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gaetan Chaboussie updated OFBIZ-11067:
--
Attachment:
OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests-1.patch
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch,
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch,
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch,
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch,
> OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch,
> OFBIZ-11067_0018-Turn-UtilObjectTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0019-Merge-UtilObjectUnitTest-into-UtilObjectTes.patch,
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests-1.patch,
>
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests-1.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gaetan Chaboussie updated OFBIZ-11067:
--
Attachment:
OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests.patch
OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests.patch
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch,
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch,
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch,
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch,
> OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch,
> OFBIZ-11067_0018-Turn-UtilObjectTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0019-Merge-UtilObjectUnitTest-into-UtilObjectTes.patch,
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Bump dompurify from 3.0.11 to 3.1.0 in /themes/common-theme/webapp/common-theme/js [ofbiz-framework]
sonarcloud[bot] commented on PR #747: URL: https://github.com/apache/ofbiz-framework/pull/747#issuecomment-2042803942 ## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=747) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=747=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=747=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=747=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=747=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=747) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump dompurify from 3.0.11 to 3.1.0 in /themes/common-theme/webapp/common-theme/js [ofbiz-framework]
dependabot[bot] opened a new pull request, #747: URL: https://github.com/apache/ofbiz-framework/pull/747 Bumps [dompurify](https://github.com/cure53/DOMPurify) from 3.0.11 to 3.1.0. Release notes Sourced from https://github.com/cure53/DOMPurify/releases;>dompurify's releases. DOMPurify 3.1.0 Added new setting SAFE_FOR_XML to enable better control over comment scrubbing Updated README to warn about happy-dom not being safe for use with DOMPurify yet Updated the LICENSE file to show the accurate year number Updated several build and test dependencies Commits https://github.com/cure53/DOMPurify/commit/db19269d8f9029cba78eabc9d6b52e73c31702ad;>db19269 Merge pull request https://redirect.github.com/cure53/DOMPurify/issues/936;>#936 from cure53/main https://github.com/cure53/DOMPurify/commit/3375f4c54f51b2f747e94eafdc671f1b514e68c4;>3375f4c docs: Updated the year in LICENSE file https://github.com/cure53/DOMPurify/commit/1c32a11a31a7bcd62ef852ca719380a0f27dd82e;>1c32a11 Merge pull request https://redirect.github.com/cure53/DOMPurify/issues/934;>#934 from cure53/main https://github.com/cure53/DOMPurify/commit/0cf9d2d7af39d1656e6fb278445e7b1ef6f571b1;>0cf9d2d chore: Preparing 3.1.0 release https://github.com/cure53/DOMPurify/commit/933b9dedc06fa48d174333f994db55f979a731e7;>933b9de See https://redirect.github.com/cure53/DOMPurify/issues/931;>#931 https://github.com/cure53/DOMPurify/commit/bf1f5cfcbc6c352e30742c5f63ac36779b31bc92;>bf1f5cf fix: Changed the SAFE_FOR_XML config assignment slightly https://github.com/cure53/DOMPurify/commit/e2c857e068f440325e2280aa99435be164fa1aed;>e2c857e docs: Modified the README slightly regarding the happy-dom warning https://github.com/cure53/DOMPurify/commit/3a009500981f0794668e8214e790ff3bc2a21306;>3a00950 feature: Added new config option to control comment sanitization https://github.com/cure53/DOMPurify/commit/1ebcfd480d2a4ff53a902a106018eef896e3681d;>1ebcfd4 fix: Removed the unnecessary clobbering check for elm.data https://github.com/cure53/DOMPurify/commit/fc3c781c74a68b2a00570092b8d55534d67ad874;>fc3c781 fix: Rolling back changes from previous fixes, trying more aggressive comment... Additional commits viewable in https://github.com/cure53/DOMPurify/compare/3.0.11...3.1.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-13005) Trunk demo errors in error.log
[
https://issues.apache.org/jira/browse/OFBIZ-13005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834847#comment-17834847
]
Jacques Le Roux commented on OFBIZ-13005:
-
I'll check few days again, but it seems there are no new errors so far.
> Trunk demo errors in error.log
> --
>
> Key: OFBIZ-13005
> URL: https://issues.apache.org/jira/browse/OFBIZ-13005
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Priority: Major
>
> For 3 days now I have collected the trunk demo errors in error.log.
> I did check the value of them but some could still be minor.
> Here is the result to be better filterered:
> {noformat}
> 2024-04-04 12:31:19,135 |-0.0.0.0-8009-exec-9 |ModelSingleForm
> |E| Failed to load parent form definition 'ListWorkEfforts' at resource
> 'component://workeffort/widget/WorkEffortForms.xml'
> java.lang.NullPointerException: Cannot invoke
> "org.w3c.dom.Element.getAttribute(String)" because "formElement" is null
> 2024-04-04 12:35:00,432 |-0.0.0.0-8009-exec-8 |ControlServlet
> |E| Error in request handler:
> java.lang.RuntimeException: Error rendering included menu named
> [MainActionMenu] at location [component://myportal/widget/MyPortalMenus.xml]:
> java.lang.IllegalArgumentException: Could not find menu with name
> [MainActionMenu] in location [component://myportal/widget/MyPortalMenus.xml]
> 2024-04-04 12:34:49,329 |-0.0.0.0-8009-exec-5 |ControlServlet
> |E| Error in request handler:
> java.lang.RuntimeException: Error rendering included menu named
> [RequestScreenletMenu] at location
> [component://myportal/widget/MyPortalMenus.xml]:
> java.lang.IllegalArgumentException: Could not find menu with name
> [RequestScreenletMenu] in location
> [component://myportal/widget/MyPortalMenus.xml]
> at java.lang.Thread.run(Thread.java:840) [?:?]
> 2024-04-04 12:34:53,562 |0.0.0.0-8009-exec-10 |ControlServlet
> |E| Error in request handler:
> java.lang.RuntimeException: Error rendering included menu named
> [PersonUpdate] at location [component://myportal/widget/MyPortalMenus.xml]:
> java.lang.IllegalArgumentException: Could not find menu with name
> [PersonUpdate] in location [component://myportal/widget/MyPortalMenus.xml]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$Menu.getModelMenu(ModelScreenWidget.java:1648)
> ~[ofbiz.jar:?]
> 2024-04-05 12:53:05,232 |-0.0.0.0-8009-exec-5 |FreeMarkerWorker
> |E| null
> freemarker.core._MiscTemplateException: Macro "renderDateTimeField" has no
> parameter with name "dateType". Valid parameter names are: name, className,
> timeDropdownParamName, defaultDateTimeString, localizedIconTitle,
> timeHourName, timeMinutesName, ampmName, compositeType, alert, isTimeType,
> isDateType, amSelected, pmSelected, timeDropdown, classString, isTwelveHour,
> hour1, hour2, minutes, shortDateInput, title, value, size, maxlength, id,
> formName, mask, event, action, step, timeValues, tabindex, disabled,
> isXMLHttpRequest
>
> FTL stack trace ("~" means nesting-related):
> - Failed at: @htmlTemplate.renderDateTimeField eve... [in template
> "component://ecommerce/template/catalog/ProductDetail.ftl" at line 726,
> column 17]
> 2024-04-05 15:50:42,492 |-0.0.0.0-8009-exec-4 |UtilXml
> |E| XmlFileLoader: File
> file:/ofbiz/framework/common/widget/PortalPageScreens.xml process error.
> Line: 82. Error message: cvc-datatype-valid.1.2.1: '${parameters.confMode}'
> is not a valid value for 'boolean'.
> 2024-04-05 15:50:42,492 |-0.0.0.0-8009-exec-4 |UtilXml
> |E| XmlFileLoader: File
> file:/ofbiz/framework/common/widget/PortalPageScreens.xml process error.
> Line: 82. Error message: cvc-datatype-valid.1.2.1: '${parameters.usePrivate}'
> is not a valid value for 'boolean'.
> 2024-04-06 07:04:58,770 |-0.0.0.0-8009-exec-2 |UtilXml
> |E| XmlFileLoader: File
> file:/ofbiz/framework/common/widget/PortalPageScreens.xml process error.
> Line: 82. Error message: cvc-datatype-valid.1.2.1: '${parameters.confMode}'
> is not a valid value for 'boolean'.
> 2024-04-06 07:04:58,771 |-0.0.0.0-8009-exec-2 |UtilXml
> |E| XmlFileLoader: File
> file:/ofbiz/framework/common/widget/PortalPageScreens.xml process error.
> Line: 82. Error message: cvc-datatype-valid.1.2.1: '${parameters.usePrivate}'
> is not a valid value for 'boolean'.
> 2024-04-06 07:05:10,041 |-0.0.0.0-8009-exec-7 |UtilXml
> |E| XmlFileLoader: File
> file:/ofbiz/framework/common/widget/PortalPageScreens.xml process error.
> Line: 82. Error message: cvc-datatype-valid.1.2.1: '${parameters.confMode}'
> is not a valid value for
[jira] [Created] (OFBIZ-13005) Trunk demo errors in error.log
Jacques Le Roux created OFBIZ-13005:
---
Summary: Trunk demo errors in error.log
Key: OFBIZ-13005
URL: https://issues.apache.org/jira/browse/OFBIZ-13005
Project: OFBiz
Issue Type: Bug
Components: ALL COMPONENTS
Affects Versions: Upcoming Branch
Reporter: Jacques Le Roux
For 3 days now I have collected the trunk demo errors in error.log.
I did check the value of them but some could still be minor.
Here is the result to be better filterered:
{noformat}
2024-04-04 12:31:19,135 |-0.0.0.0-8009-exec-9 |ModelSingleForm
|E| Failed to load parent form definition 'ListWorkEfforts' at resource
'component://workeffort/widget/WorkEffortForms.xml'
java.lang.NullPointerException: Cannot invoke
"org.w3c.dom.Element.getAttribute(String)" because "formElement" is null
2024-04-04 12:35:00,432 |-0.0.0.0-8009-exec-8 |ControlServlet
|E| Error in request handler:
java.lang.RuntimeException: Error rendering included menu named
[MainActionMenu] at location [component://myportal/widget/MyPortalMenus.xml]:
java.lang.IllegalArgumentException: Could not find menu with name
[MainActionMenu] in location [component://myportal/widget/MyPortalMenus.xml]
2024-04-04 12:34:49,329 |-0.0.0.0-8009-exec-5 |ControlServlet
|E| Error in request handler:
java.lang.RuntimeException: Error rendering included menu named
[RequestScreenletMenu] at location
[component://myportal/widget/MyPortalMenus.xml]:
java.lang.IllegalArgumentException: Could not find menu with name
[RequestScreenletMenu] in location
[component://myportal/widget/MyPortalMenus.xml]
at java.lang.Thread.run(Thread.java:840) [?:?]
2024-04-04 12:34:53,562 |0.0.0.0-8009-exec-10 |ControlServlet
|E| Error in request handler:
java.lang.RuntimeException: Error rendering included menu named [PersonUpdate]
at location [component://myportal/widget/MyPortalMenus.xml]:
java.lang.IllegalArgumentException: Could not find menu with name
[PersonUpdate] in location [component://myportal/widget/MyPortalMenus.xml]
at
org.apache.ofbiz.widget.model.ModelScreenWidget$Menu.getModelMenu(ModelScreenWidget.java:1648)
~[ofbiz.jar:?]
2024-04-05 12:53:05,232 |-0.0.0.0-8009-exec-5 |FreeMarkerWorker
|E| null
freemarker.core._MiscTemplateException: Macro "renderDateTimeField" has no
parameter with name "dateType". Valid parameter names are: name, className,
timeDropdownParamName, defaultDateTimeString, localizedIconTitle, timeHourName,
timeMinutesName, ampmName, compositeType, alert, isTimeType, isDateType,
amSelected, pmSelected, timeDropdown, classString, isTwelveHour, hour1, hour2,
minutes, shortDateInput, title, value, size, maxlength, id, formName, mask,
event, action, step, timeValues, tabindex, disabled, isXMLHttpRequest
FTL stack trace ("~" means nesting-related):
- Failed at: @htmlTemplate.renderDateTimeField eve... [in template
"component://ecommerce/template/catalog/ProductDetail.ftl" at line 726, column
17]
2024-04-05 15:50:42,492 |-0.0.0.0-8009-exec-4 |UtilXml
|E| XmlFileLoader: File
file:/ofbiz/framework/common/widget/PortalPageScreens.xml process error. Line:
82. Error message: cvc-datatype-valid.1.2.1: '${parameters.confMode}' is not a
valid value for 'boolean'.
2024-04-05 15:50:42,492 |-0.0.0.0-8009-exec-4 |UtilXml
|E| XmlFileLoader: File
file:/ofbiz/framework/common/widget/PortalPageScreens.xml process error. Line:
82. Error message: cvc-datatype-valid.1.2.1: '${parameters.usePrivate}' is not
a valid value for 'boolean'.
2024-04-06 07:04:58,770 |-0.0.0.0-8009-exec-2 |UtilXml
|E| XmlFileLoader: File
file:/ofbiz/framework/common/widget/PortalPageScreens.xml process error. Line:
82. Error message: cvc-datatype-valid.1.2.1: '${parameters.confMode}' is not a
valid value for 'boolean'.
2024-04-06 07:04:58,771 |-0.0.0.0-8009-exec-2 |UtilXml
|E| XmlFileLoader: File
file:/ofbiz/framework/common/widget/PortalPageScreens.xml process error. Line:
82. Error message: cvc-datatype-valid.1.2.1: '${parameters.usePrivate}' is not
a valid value for 'boolean'.
2024-04-06 07:05:10,041 |-0.0.0.0-8009-exec-7 |UtilXml
|E| XmlFileLoader: File
file:/ofbiz/framework/common/widget/PortalPageScreens.xml process error. Line:
82. Error message: cvc-datatype-valid.1.2.1: '${parameters.confMode}' is not a
valid value for 'boolean'.
2024-04-06 07:05:10,041 |-0.0.0.0-8009-exec-7 |UtilXml
|E| XmlFileLoader: File
file:/ofbiz/framework/common/widget/PortalPageScreens.xml process error. Line:
82. Error message: cvc-datatype-valid.1.2.1: '${parameters.usePrivate}' is not
a valid value for 'boolean'.
2024-04-06 07:06:08,649 |-0.0.0.0-8009-exec-2 |UtilXml
|E| XmlFileLoader: File
[jira] [Commented] (OFBIZ-13004) Ecommerce error message at login
[
https://issues.apache.org/jira/browse/OFBIZ-13004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834823#comment-17834823
]
Jacques Le Roux commented on OFBIZ-13004:
-
It's in ecommerce/minilang/customer/CustomerEvents.xml[417]
> Ecommerce error message at login
>
>
> Key: OFBIZ-13004
> URL: https://issues.apache.org/jira/browse/OFBIZ-13004
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Priority: Minor
>
> After registering an user I got this error:
> Error running the simple-method: Error running groovy script [
> org.apache.ofbiz.webapp.control.LoginWorker.doBasicLogin(createdUserLogin,
> request)
> org.apache.ofbiz.webapp.control.LoginWorker.autoLoginSet(request, response)
> session = request.getSession()
> cart = session.getAttribute("shoppingCart")
> if (cart != null) {
> cart.setOrderPartyId(tempMap.get("partyId"))
> }
> ]: javax.script.ScriptException: groovy.lang.MissingMethodException: No
> signature of method: static
> org.apache.ofbiz.webapp.control.LoginWorker.doBasicLogin() is applicable for
> argument types: (org.apache.ofbiz.entity.GenericValue,
> org.apache.catalina.connector.RequestFacade) values:
> [[lastUpdatedStamp:2024-04-08 08:11:34.503, successiveFailedLogins:null,
> ...], ...]
> Possible solutions: doBasicLogin(org.apache.ofbiz.entity.GenericValue,
> javax.servlet.http.HttpServletRequest,
> javax.servlet.http.HttpServletResponse),
> doBasicLogout(org.apache.ofbiz.entity.GenericValue,
> javax.servlet.http.HttpServletRequest,
> javax.servlet.http.HttpServletResponse), File#Method =
> CustomerEvents.xml#createCustomer, Element =
[jira] [Created] (OFBIZ-13004) Ecommerce error message at login
Jacques Le Roux created OFBIZ-13004:
---
Summary: Ecommerce error message at login
Key: OFBIZ-13004
URL: https://issues.apache.org/jira/browse/OFBIZ-13004
Project: OFBiz
Issue Type: Bug
Components: ecommerce
Affects Versions: Upcoming Branch
Reporter: Jacques Le Roux
After registering an user I got this error:
Error running the simple-method: Error running groovy script [
org.apache.ofbiz.webapp.control.LoginWorker.doBasicLogin(createdUserLogin,
request)
org.apache.ofbiz.webapp.control.LoginWorker.autoLoginSet(request, response)
session = request.getSession()
cart = session.getAttribute("shoppingCart")
if (cart != null) {
cart.setOrderPartyId(tempMap.get("partyId"))
}
]: javax.script.ScriptException: groovy.lang.MissingMethodException: No
signature of method: static
org.apache.ofbiz.webapp.control.LoginWorker.doBasicLogin() is applicable for
argument types: (org.apache.ofbiz.entity.GenericValue,
org.apache.catalina.connector.RequestFacade) values:
[[lastUpdatedStamp:2024-04-08 08:11:34.503, successiveFailedLogins:null, ...],
...]
Possible solutions: doBasicLogin(org.apache.ofbiz.entity.GenericValue,
javax.servlet.http.HttpServletRequest, javax.servlet.http.HttpServletResponse),
doBasicLogout(org.apache.ofbiz.entity.GenericValue,
javax.servlet.http.HttpServletRequest, javax.servlet.http.HttpServletResponse),
File#Method = CustomerEvents.xml#createCustomer, Element =
[jira] [Commented] (OFBIZ-12390) Order/Invoice: Item total result diff total result
[ https://issues.apache.org/jira/browse/OFBIZ-12390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834792#comment-17834792 ] Ingo Wolfmayr commented on OFBIZ-12390: --- Hi [~jleroux], I check and update the ticket. Best regards, Ingo > Order/Invoice: Item total result diff total result > -- > > Key: OFBIZ-12390 > URL: https://issues.apache.org/jira/browse/OFBIZ-12390 > Project: OFBiz > Issue Type: Improvement > Components: accounting, order >Affects Versions: Trunk, 17.12.08, 18.12.01, Upcoming Branch >Reporter: Ingo Wolfmayr >Assignee: Jacques Le Roux >Priority: Major > Attachments: Orders.xml, cartRounding.patch, > image-2021-11-19-09-44-18-759.png, image-2021-11-19-09-44-44-443.png, > image-2021-11-19-09-59-07-571.png, image-2022-09-16-16-43-38-897.png, > pricecheckData-1.xml > > > In some cases the order total is not correct: > net price: €1.273 > 10% sales tax: € 0.127 > quantity: 1 > grand total: € 1.40 > Now taking the same product and adding it with two order lines: > grand total: € 2.79 > Right now the grand total is calculated by total all item net prices, total > all adjustments and finally adding those two values together. > The following screenshots are taken from the orderview. Ofbiz request a > payment of € 2.80 but will create an invoice with a grand total of € 2.79. > !image-2021-11-19-09-44-18-759.png! > !image-2021-11-19-09-44-44-443.png! > Heres the result with just one orderline: > !image-2021-11-19-09-59-07-571.png! > > I have created a XML file for testing. Import the file via XML import and > create an order: > partyId: AUT_CUSTOMER > productStore: Test GmbH > product 1: AUT_PRODUCT (quantity 1) > product 1: AUT_PRODUCT_CP (quantity 1) > Checkout with default settings. > From my perspective the calculation should be changed to calculate the total > amount for each line and calculate the grand total from these results. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12780) Tax rate from shipping address when taxInPrice = "Y"
[ https://issues.apache.org/jira/browse/OFBIZ-12780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834789#comment-17834789 ] Ingo Wolfmayr commented on OFBIZ-12780: --- Hi Pierre, I have temporarily returned to taxInPrice = N as when it comes to adjustments like promotions it does not work as expected (for me with sales tax). Also the ShoppingCart price infos have problems showing the correct values in some of my cases. Unfortunately fixing this is not a quick hack as the price calculation service result does not provide enough details by now to allow further calculation (with the result as basis). I will work on this as soon as I have enough time. Best regards, Ingo > Tax rate from shipping address when taxInPrice = "Y" > > > Key: OFBIZ-12780 > URL: https://issues.apache.org/jira/browse/OFBIZ-12780 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Upcoming Branch >Reporter: Ingo Wolfmayr >Priority: Major > Fix For: Upcoming Branch > > Attachments: eutax-1.patch, taxexample.jpg > > > *Case:* shipment from AUT (20% sales tax) to DEU (19% sales tax). > *Now:* > Productprice with taxInPrice = "N": tax calculated according to > taxRateProduct definition --> ok > Productprice with taxInPrice = "Y": if productPrice for target country exists > --> ok, if not, the productStore tax setting is used. > *Goal:* > Calculate VAT for tax taken from shipment target + add price adjustment. > *Example:* > Gross price: € 14,80 (20% sales tax - default price) > Order: > Unit price: € 14,80 > Tax: € 2,47 (19%) > OrderAdjustment (item): € -0,127 > When done, the order result will be the same as when using taxInPrice = "N" > *Testing:* > # create product + productprice (taxInPrice="Y") > # create order with shipping address geoId different to productprice > taxAuthGeoId > # --> Ofbiz will then create the order item adjustments > Reason: > Administration of multiple prices due to different taxes may be quite time > consuming. For example selling from one country within the EU to another EU > country (27) will result in 27 listprices and 27 default prices for a single > product. EU law for example obligates the seller to apply the shipping target > tax rate on the invoice. -- This message was sent by Atlassian Jira (v8.20.10#820010)
