[jira] [Created] (OFBIZ-13027) New Themes don't show page title label
Pierre Smits created OFBIZ-13027: Summary: New Themes don't show page title label Key: OFBIZ-13027 URL: https://issues.apache.org/jira/browse/OFBIZ-13027 Project: OFBiz Issue Type: Improvement Components: themes/helveticus, themes/rainbow Reporter: Pierre Smits Attachments: Screenshot 2024-04-14 at 20.54.35.png, Screenshot 2024-04-14 at 20.55.21.png, Screenshot 2024-04-14 at 20.55.57.png The newer themes (RainbowStone and Helveticus) don't show the page title in the screen. See attached images compared to Bluelight. Is it the intention of the community to do away with the page titles labels in the screens of components and plugins? -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Improved: Have a Menu in SFA featuring actions to create the main objects (OFBIZ-12527) [ofbiz-framework]
sonarcloud[bot] commented on PR #760: URL: https://github.com/apache/ofbiz-framework/pull/760#issuecomment-2054127890 ## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=760) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=760&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=760&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=760&resolved=false&inNewCodePeriod=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=760&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=760) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Improved: Have a Menu in SFA featuring actions to create the main objects (OFBIZ-12527) [ofbiz-framework]
PierreSmits opened a new pull request, #760: URL: https://github.com/apache/ofbiz-framework/pull/760 Currently the create buttons for the main objects of the SFA application are located within find and profile widgets/templates of those objects. In order to improve the usability of this application, OFBiz and thus the appeal of it for adopters and users, these create buttons/links/etc. should be in a main action menu visible at all times when a user with CREATE permissions is working within the application modified: - SfaMenus.xml - Added menu MainActionMenu - included MainActionMenu in various screens to ensure that it is visible to user with CREATE permissions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: Have a Menu in SFA featuring actions to create the main objects (OFBIZ-12527) [ofbiz-framework]
PierreSmits commented on PR #479: URL: https://github.com/apache/ofbiz-framework/pull/479#issuecomment-2054121651 Due to conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: Have a Menu in SFA featuring actions to create the main objects (OFBIZ-12527) [ofbiz-framework]
PierreSmits closed pull request #479: Improved: Have a Menu in SFA featuring actions to create the main objects (OFBIZ-12527) URL: https://github.com/apache/ofbiz-framework/pull/479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: Have 'Tax Authority' menu item in GlobalGLSettingMenus (OFBIZ-13026) [ofbiz-framework]
sonarcloud[bot] commented on PR #759: URL: https://github.com/apache/ofbiz-framework/pull/759#issuecomment-2054120719 ## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=759) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=759&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=759&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=759&resolved=false&inNewCodePeriod=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=759&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=759) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Improved: Have 'Tax Authority' menu item in GlobalGLSettingMenus (OFBIZ-13026) [ofbiz-framework]
PierreSmits opened a new pull request, #759: URL: https://github.com/apache/ofbiz-framework/pull/759 In order to enhance the UX of users of the accounting application, the TaxAuthorities should move into the GlobalGLSettingMenus. The motivation for this are that: TaxAuthority functionality is applicable to all internal organisations with accounting set up, for which we have the GlobalGLSettingMenus; It reduces distractions for users that do day-to-day accounting activities regarding: search/finding gl transactions, invoices and payments creating, reviewing, updating gl transactions, invoices and payments modiified: AccountingMenus.xml - move menu-item 'TaxAuthorities' from menu AccountingAppBar to menu GlobalGLSettingMenus -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12994) Convert Invoice relation screen to dynamic Compound
[ https://issues.apache.org/jira/browse/OFBIZ-12994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836977#comment-17836977 ] Pierre Smits commented on OFBIZ-12994: -- Should this and similar not be done in a separate feature branch, given its impact on code, contributions and down-stream implementations? > Convert Invoice relation screen to dynamic Compound > --- > > Key: OFBIZ-12994 > URL: https://issues.apache.org/jira/browse/OFBIZ-12994 > Project: OFBiz > Issue Type: Improvement > Components: accounting/invoice >Affects Versions: Upcoming Branch >Reporter: Mekika Leila >Assignee: Mekika Leila >Priority: Minor > Fix For: Upcoming Branch > > > After the work on the task OFBIZ-11808, and the migration started for > workeffort screens on OFBIZ-12292, the purpose is to migrate all screen > linked to Invoice entity with idea to reduce the code and use widget > improvement developped last years > This migration cover invoice related screens from invoiceOverview to > managment screens and forms for each invoice sub item such as: > - Applications > - Attributes > - ContactMech > - Content > - Item > - Note > - Role > - Status > - Term > - TimeEntry > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12893) Screen Security in Party should not show create trigger to user with only VIEW permission.
[ https://issues.apache.org/jira/browse/OFBIZ-12893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836971#comment-17836971 ] Pierre Smits commented on OFBIZ-12893: -- Hi Jacques, bq. Sincerely I'll not backport to R18.12; and R20.01, like Zappa said, is not dead, it just smells funny. Indeed it does. Is r20.01 even a thing? When you delve into where this rabbit hole (the menu-item 'security') leads, you'll find that it does not pointto a screen in the party component, or even the webtools component (where it is totally appropriate to have), but to the common component in the framework folder. > Screen Security in Party should not show create trigger to user with only > VIEW permission. > -- > > Key: OFBIZ-12893 > URL: https://issues.apache.org/jira/browse/OFBIZ-12893 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Priority: Major > > When accessing > [https://demo-trunk.ofbiz.apache.org/partymgr/control/FindSecurityGroup] as a > user with only VIEW permissions (e.g. userId = auditor) the action trigger to > create something is shown. > This should not be visible to such a user as it leads to an undesired effect > and diminished user experience. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Reopened] (OFBIZ-12994) Convert Invoice relation screen to dynamic Compound
[ https://issues.apache.org/jira/browse/OFBIZ-12994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-12994: - Hi Leila, Sorry it seems that this issue broke OFBIZ-13017, I reopen for you to confirm and if it's the case fix the issue, TIA > Convert Invoice relation screen to dynamic Compound > --- > > Key: OFBIZ-12994 > URL: https://issues.apache.org/jira/browse/OFBIZ-12994 > Project: OFBiz > Issue Type: Improvement > Components: accounting/invoice >Affects Versions: Upcoming Branch >Reporter: Mekika Leila >Assignee: Mekika Leila >Priority: Minor > Fix For: Upcoming Branch > > > After the work on the task OFBIZ-11808, and the migration started for > workeffort screens on OFBIZ-12292, the purpose is to migrate all screen > linked to Invoice entity with idea to reduce the code and use widget > improvement developped last years > This migration cover invoice related screens from invoiceOverview to > managment screens and forms for each invoice sub item such as: > - Applications > - Attributes > - ContactMech > - Content > - Item > - Note > - Role > - Status > - Term > - TimeEntry > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13017) invoiceOverview generates an error
[ https://issues.apache.org/jira/browse/OFBIZ-13017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836969#comment-17836969 ] Jacques Le Roux commented on OFBIZ-13017: - As far as we know OFBIZ-12994 broke this issue, to be confirmed, TIA > invoiceOverview generates an error > -- > > Key: OFBIZ-13017 > URL: https://issues.apache.org/jira/browse/OFBIZ-13017 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Pierre Smits >Priority: Major > > see > https://demo-trunk.ofbiz.apache.org/accounting/control/invoiceOverview?invoiceId=demo10001 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-13026) Have 'Tax Authority' menu item in GlobalGLSettingMenus
Pierre Smits created OFBIZ-13026: Summary: Have 'Tax Authority' menu item in GlobalGLSettingMenus Key: OFBIZ-13026 URL: https://issues.apache.org/jira/browse/OFBIZ-13026 Project: OFBiz Issue Type: Improvement Components: accounting Reporter: Pierre Smits In order to enhance the UX of users of the accounting application, the TaxAuthorities should move into the GlobalGLSettingMenus. The motivation for this are that: * TaxAuthority functionality is applicable to all internal organisations with accounting set up; * It reduces distractions for users that do day-to-day accounting activities regarding: * search/finding gl transactions, invoices and payments * creating, reviewing, updating gl transactions, invoices and payments -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-13026) Have 'Tax Authority' menu item in GlobalGLSettingMenus
[ https://issues.apache.org/jira/browse/OFBIZ-13026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-13026: - Description: In order to enhance the UX of users of the accounting application, the TaxAuthorities should move into the GlobalGLSettingMenus. The motivation for this are that: * TaxAuthority functionality is applicable to all internal organisations with accounting set up, for which we have the GlobalGLSettingMenus; * It reduces distractions for users that do day-to-day accounting activities regarding: * search/finding gl transactions, invoices and payments * creating, reviewing, updating gl transactions, invoices and payments was: In order to enhance the UX of users of the accounting application, the TaxAuthorities should move into the GlobalGLSettingMenus. The motivation for this are that: * TaxAuthority functionality is applicable to all internal organisations with accounting set up; * It reduces distractions for users that do day-to-day accounting activities regarding: * search/finding gl transactions, invoices and payments * creating, reviewing, updating gl transactions, invoices and payments > Have 'Tax Authority' menu item in GlobalGLSettingMenus > -- > > Key: OFBIZ-13026 > URL: https://issues.apache.org/jira/browse/OFBIZ-13026 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Reporter: Pierre Smits >Priority: Major > > In order to enhance the UX of users of the accounting application, the > TaxAuthorities should move into the GlobalGLSettingMenus. > The motivation for this are that: > * TaxAuthority functionality is applicable to all internal organisations with > accounting set up, for which we have the GlobalGLSettingMenus; > * It reduces distractions for users that do day-to-day accounting activities > regarding: > * search/finding gl transactions, invoices and payments > * creating, reviewing, updating gl transactions, invoices and payments -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12893) Screen Security in Party should not show create trigger to user with only VIEW permission.
[ https://issues.apache.org/jira/browse/OFBIZ-12893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836968#comment-17836968 ] Jacques Le Roux commented on OFBIZ-12893: - Hi Pierre, Sincerely I'll not backport to R18.12; and R20.01, like Zappa said, is not dead, it just smells funny. > Screen Security in Party should not show create trigger to user with only > VIEW permission. > -- > > Key: OFBIZ-12893 > URL: https://issues.apache.org/jira/browse/OFBIZ-12893 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Priority: Major > > When accessing > [https://demo-trunk.ofbiz.apache.org/partymgr/control/FindSecurityGroup] as a > user with only VIEW permissions (e.g. userId = auditor) the action trigger to > create something is shown. > This should not be visible to such a user as it leads to an undesired effect > and diminished user experience. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-11808) Improve screen engine with decrease technology dependence
[ https://issues.apache.org/jira/browse/OFBIZ-11808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836966#comment-17836966 ] Pierre Smits commented on OFBIZ-11808: -- Unfortunately, the link presentation slides is not accessible: That points to https://s.apache.org/EmpowerOFBizScreen which redirects to https://labs.nereide.fr, where credentials are required. > Improve screen engine with decrease technology dependence > - > > Key: OFBIZ-11808 > URL: https://issues.apache.org/jira/browse/OFBIZ-11808 > Project: OFBiz > Issue Type: Improvement > Components: framework, framework/widget >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Major > Labels: screen, widget > > After different presentation on thinking about how improve the end user > experience on back office screen, we start a list of issues that cover the > minimum need. > [chapter > 1|https://lists.apache.org/thread.html/5dcc8cff9b5413070079d22833b6a10abee55bcfbfb0233019ed09b1%40%3Cdev.ofbiz.apache.org%3E] > > [chapter > 2|https://lists.apache.org/thread.html/r146f2814691e98e2cfc308ed3ac1db77fb6a356a2b73215517d300aa%40%3Cdev.ofbiz.apache.org%3E] > [chapter > 3|https://lists.apache.org/thread.html/ra5ed191eecbaf8096ddcdcf98048e70ea8c139fcab75c734ff30b6c0%40%3Cdev.ofbiz.apache.org%3E] > [Presentation slides|https://s.apache.org/EmpowerOFBizScreen] > Each improvement is designed to decrease the xml form definition, based on > functional concept out any technology (relaying to theme). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (OFBIZ-12994) Convert Invoice relation screen to dynamic Compound
[ https://issues.apache.org/jira/browse/OFBIZ-12994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836965#comment-17836965 ] Pierre Smits edited comment on OFBIZ-12994 at 4/14/24 2:57 PM: --- Hi [~mleila], Should this not be a subtask under OFBIZ-11808 ? Or under a new placeholder ticket, that captures the essence of why this is beneficial to the project, adopters, contributors and implementers (and their developers)? was (Author: pfm.smits): Hi [~mleila], Should this not be a subtask under OFBIZ-11808 ? > Convert Invoice relation screen to dynamic Compound > --- > > Key: OFBIZ-12994 > URL: https://issues.apache.org/jira/browse/OFBIZ-12994 > Project: OFBiz > Issue Type: Improvement > Components: accounting/invoice >Affects Versions: Upcoming Branch >Reporter: Mekika Leila >Assignee: Mekika Leila >Priority: Minor > Fix For: Upcoming Branch > > > After the work on the task OFBIZ-11808, and the migration started for > workeffort screens on OFBIZ-12292, the purpose is to migrate all screen > linked to Invoice entity with idea to reduce the code and use widget > improvement developped last years > This migration cover invoice related screens from invoiceOverview to > managment screens and forms for each invoice sub item such as: > - Applications > - Attributes > - ContactMech > - Content > - Item > - Note > - Role > - Status > - Term > - TimeEntry > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12994) Convert Invoice relation screen to dynamic Compound
[ https://issues.apache.org/jira/browse/OFBIZ-12994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836965#comment-17836965 ] Pierre Smits commented on OFBIZ-12994: -- Hi [~mleila], Should this not be a subtask under OFBIZ-11808 ? > Convert Invoice relation screen to dynamic Compound > --- > > Key: OFBIZ-12994 > URL: https://issues.apache.org/jira/browse/OFBIZ-12994 > Project: OFBiz > Issue Type: Improvement > Components: accounting/invoice >Affects Versions: Upcoming Branch >Reporter: Mekika Leila >Assignee: Mekika Leila >Priority: Minor > Fix For: Upcoming Branch > > > After the work on the task OFBIZ-11808, and the migration started for > workeffort screens on OFBIZ-12292, the purpose is to migrate all screen > linked to Invoice entity with idea to reduce the code and use widget > improvement developped last years > This migration cover invoice related screens from invoiceOverview to > managment screens and forms for each invoice sub item such as: > - Applications > - Attributes > - ContactMech > - Content > - Item > - Note > - Role > - Status > - Term > - TimeEntry > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Improved: Agreement Roles - VIEW permissions (OFBIZ-12518) [ofbiz-framework]
PierreSmits commented on PR #471: URL: https://github.com/apache/ofbiz-framework/pull/471#issuecomment-2054054946 Hi @JacquesLeRoux With your label corrections you neglected the aspect that in several other screens (and templates) CommonRole and CommonParty as labels already have been applied in various forms in the codebase. Are you with your corrections to this pull requests suggesting that contributors should favor archaic dogma over UX improvements? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: FACILITY- Move from hard-coded menu location to parameterized (OFBIZ-12976) [ofbiz-framework]
sonarcloud[bot] commented on PR #758: URL: https://github.com/apache/ofbiz-framework/pull/758#issuecomment-2054025768 ## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=758) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=758&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=758&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=758&resolved=false&inNewCodePeriod=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=758&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=758) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Improved: FACILITY- Move from hard-coded menu location to parameterized (OFBIZ-12976) [ofbiz-framework]
PierreSmits opened a new pull request, #758: URL: https://github.com/apache/ofbiz-framework/pull/758 Move the menu location in the various facility screens from hard-coded to parameterized. modified: ShipmentGatewayConfigScreens.xml changed menu location from hard-coded to parameterised. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: Reduce code complexity re marketing menus (OFBIZ-13025) [ofbiz-framework]
sonarcloud[bot] commented on PR #757: URL: https://github.com/apache/ofbiz-framework/pull/757#issuecomment-2054016439 ## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=757) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=757&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=757&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=757&resolved=false&inNewCodePeriod=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=757&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=757) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: Reduce code complexity re marketing menus (OFBIZ-13025) [ofbiz-framework]
sonarcloud[bot] commented on PR #757: URL: https://github.com/apache/ofbiz-framework/pull/757#issuecomment-2054016083 ## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=757) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=757&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=757&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=757&resolved=false&inNewCodePeriod=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=757&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=757) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Improved: Reduce code complexity re marketing menus (OFBIZ-13025) [ofbiz-framework]
PierreSmits opened a new pull request, #757: URL: https://github.com/apache/ofbiz-framework/pull/757 Currently, we have in the marketing component/application - besides the main menus (in MarketingMenus.xml, menus for specific screens/functions in: * ContactListMenus.xml: 2 menus, with resp. 5 and 2 menu-items; used in ContactListScreens.xml * DataSourcesMenus.xml: 1 menu, with 2 menu-items; used in DataSourceScreens.xml * MarketingCampaignMenus.xml: 1 menu, with 2 menu-items; used in MarketingCampaignScreens.xml *SegmentMenus.xml: 1 menu, with 4 menu-items; used in SegmentScreens.xml*TrackingCodeMenus.xml: 1 menu, with 4 menu-items, used in TrackingCodeScreens.xml We should move the menus in those menu xml file to MarketingMenus.xml (and adjust the location references in the appropriate screens) to reduce code complexity and enhance the developer experience. modified: * MarketingMenus.xml: added menus, ContactListTabBar, ContactListComBar, DataSourceTabBar, MarketingCampaignTabBar, SegmentGroupTabBar, TrackingCodeTabBar * CommonScreens.xml, ContactListScreens,xml, DataSoourceScreen.xml, MarketingCampaignScreens.xml, SegmentScreens.xml, TrackingCodeScreens.xml: changed menu location from hardcoded to parameterized deleted: ContactListMenus.xml, DataSourceMenus.xml, MarketingCampaignMenus.xml, SegmentMenus.xml, TrackingCodeMenus.xml -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (OFBIZ-13025) Reduce code complexity re marketing menus
[ https://issues.apache.org/jira/browse/OFBIZ-13025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-13025: - Parent: OFBIZ-12928 Issue Type: Sub-task (was: Improvement) > Reduce code complexity re marketing menus > - > > Key: OFBIZ-13025 > URL: https://issues.apache.org/jira/browse/OFBIZ-13025 > Project: OFBiz > Issue Type: Sub-task > Components: marketing/marketing >Reporter: Pierre Smits >Priority: Major > > Currently, we have in the marketing component/application - besides the main > menus (in MarketingMenus.xml, menus for specific screens/functions in: > * ContactListMenus.xml: 2 menus, with resp. 5 and 2 menu-items; used in > ContactListScreens.xml > * DataSourcesMenus.xml: 1 menu, with 2 menu-items; used in > DataSourceScreens.xml > * MarketingCampaignMenus.xml: 1 menu, with 2 menu-items; used in > MarketingCampaignScreens.xml > * SegmentMenus.xml: 1 menu, with 4 menu-items; used in SegmentScreens.xml > * TrackingCodeMenus.xml: 1 menu, with 4 menu-items, used in > TrackingCodeScreens.xml > We should move the menus in those menu xml file to MarketingMenus.xml (and > adjust the location references in the appropriate screens) to reduce code > complexity and enhance the developer experience. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-13025) Reduce code complexity re marketing menus
[ https://issues.apache.org/jira/browse/OFBIZ-13025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-13025: - Description: Currently, we have in the marketing component/application - besides the main menus (in MarketingMenus.xml, menus for specific screens/functions in: * ContactListMenus.xml: 2 menus, with resp. 5 and 2 menu-items; used in ContactListScreens.xml * DataSourcesMenus.xml: 1 menu, with 2 menu-items; used in DataSourceScreens.xml * MarketingCampaignMenus.xml: 1 menu, with 2 menu-items; used in MarketingCampaignScreens.xml * SegmentMenus.xml: 1 menu, with 4 menu-items; used in SegmentScreens.xml * TrackingCodeMenus.xml: 1 menu, with 4 menu-items, used in TrackingCodeScreens.xml We should move the menus in those menu xml file to MarketingMenus.xml (and adjust the location references in the appropriate screens) to reduce code complexity and enhance the developer experience. was: Currently, we have in the marketing component/application - besides the main menus (in MarketingMenus.xml, menus for specific screens/functions in: * DataSourcesMenus.xml: 1 menu, with 2 menu-items; used in DataSourceScreens.xml * MarketingCampaignMenus.xml: 1 menu, with 2 menu-items; used in MarketingCampaignScreens.xml * SegmentMenus.xml: 1 menu, with 4 menu-items; used in SegmentScreens.xml * TrackingCodeMenus.xml: 1 menu, with 4 menu-items, used in TrackingCodeScreens.xml We should move the menus in those menu xml file to MarketingMenus.xml (and adjust the location references in the appropriate screens) to reduce code complexity and enhance the developer experience. > Reduce code complexity re marketing menus > - > > Key: OFBIZ-13025 > URL: https://issues.apache.org/jira/browse/OFBIZ-13025 > Project: OFBiz > Issue Type: Improvement > Components: marketing/marketing >Reporter: Pierre Smits >Priority: Major > > Currently, we have in the marketing component/application - besides the main > menus (in MarketingMenus.xml, menus for specific screens/functions in: > * ContactListMenus.xml: 2 menus, with resp. 5 and 2 menu-items; used in > ContactListScreens.xml > * DataSourcesMenus.xml: 1 menu, with 2 menu-items; used in > DataSourceScreens.xml > * MarketingCampaignMenus.xml: 1 menu, with 2 menu-items; used in > MarketingCampaignScreens.xml > * SegmentMenus.xml: 1 menu, with 4 menu-items; used in SegmentScreens.xml > * TrackingCodeMenus.xml: 1 menu, with 4 menu-items, used in > TrackingCodeScreens.xml > We should move the menus in those menu xml file to MarketingMenus.xml (and > adjust the location references in the appropriate screens) to reduce code > complexity and enhance the developer experience. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-13025) Reduce code complexity re marketing menus
Pierre Smits created OFBIZ-13025: Summary: Reduce code complexity re marketing menus Key: OFBIZ-13025 URL: https://issues.apache.org/jira/browse/OFBIZ-13025 Project: OFBiz Issue Type: Improvement Components: marketing/marketing Reporter: Pierre Smits Currently, we have in the marketing component/application - besides the main menus (in MarketingMenus.xml, menus for specific screens/functions in: * DataSourcesMenus.xml: 1 menu, with 2 menu-items; used in DataSourceScreens.xml * MarketingCampaignMenus.xml: 1 menu, with 2 menu-items; used in MarketingCampaignScreens.xml * SegmentMenus.xml: 1 menu, with 4 menu-items; used in SegmentScreens.xml * TrackingCodeMenus.xml: 1 menu, with 4 menu-items, used in TrackingCodeScreens.xml We should move the menus in those menu xml file to MarketingMenus.xml (and adjust the location references in the appropriate screens) to reduce code complexity and enhance the developer experience. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13017) invoiceOverview generates an error
[ https://issues.apache.org/jira/browse/OFBIZ-13017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836938#comment-17836938 ] Jacques Le Roux commented on OFBIZ-13017: - OK, so OFBIZ-12994 broke it. > invoiceOverview generates an error > -- > > Key: OFBIZ-13017 > URL: https://issues.apache.org/jira/browse/OFBIZ-13017 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Pierre Smits >Priority: Major > > see > https://demo-trunk.ofbiz.apache.org/accounting/control/invoiceOverview?invoiceId=demo10001 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Improved: Make theme variants visible in demo sites (OFBIZ-13024) [ofbiz-framework]
sonarcloud[bot] commented on PR #756: URL: https://github.com/apache/ofbiz-framework/pull/756#issuecomment-2053998869 ## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=756) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=756&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=756&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=756&resolved=false&inNewCodePeriod=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=756&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=756) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Improved: Make theme variants visible in demo sites (OFBIZ-13024) [ofbiz-framework]
PierreSmits opened a new pull request, #756: URL: https://github.com/apache/ofbiz-framework/pull/756 Currently we have 58 UserLogin records in demo data, and 12 back-office VisualTheme records in our demo data sets. In order to have more visibilities of the various themes, we should set for various UserLogins the theme as a preference. modified: PartyDemoData.xml - added UserPreference records relating to themes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-13022) EBAY- Move from hard-coded menu location to parameterized
[ https://issues.apache.org/jira/browse/OFBIZ-13022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836936#comment-17836936 ] ASF subversion and git services commented on OFBIZ-13022: - Commit 33c3449350a6ac0ae94fc6e3b29009f0730d2010 in ofbiz-plugins's branch refs/heads/trunk from Pierre Smits [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=33c344935 ] Improved: EBAY- Move from hard-coded menu location to parameterized (OFBIZ-13022) (#109) Move the product menu location in various eBay screens to parameterized modified: - web.xml: added context-param productMenuLocation - CommonScreens.xml: changed location of ProductTabBar from hard coded to parameterized > EBAY- Move from hard-coded menu location to parameterized > - > > Key: OFBIZ-13022 > URL: https://issues.apache.org/jira/browse/OFBIZ-13022 > Project: OFBiz > Issue Type: Sub-task > Components: product/catalog >Reporter: Pierre Smits >Priority: Major > > Move the product menu location in various eBay screens to parameterized -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Improved: EBAY- Move from hard-coded menu location to parameterized (OFBIZ-13022) [ofbiz-plugins]
JacquesLeRoux merged PR #109: URL: https://github.com/apache/ofbiz-plugins/pull/109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-13017) invoiceOverview generates an error
[ https://issues.apache.org/jira/browse/OFBIZ-13017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836934#comment-17836934 ] Pierre Smits commented on OFBIZ-13017: -- History in GitHub shows that https://github.com/apache/ofbiz-framework/commit/c7333c0c93940a8bfeaab78e282a447755be8ab8 replaced working solution with led to the deterioration. I question such commits * without proper context in documentation, * without proper discussion regarding ** code changes required, its impact across applications, and ** benefits and drawbacks in ofbiz-dev as it present a paradigm shift for community members and those who have to do upgrades in their implementations. > invoiceOverview generates an error > -- > > Key: OFBIZ-13017 > URL: https://issues.apache.org/jira/browse/OFBIZ-13017 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Pierre Smits >Priority: Major > > see > https://demo-trunk.ofbiz.apache.org/accounting/control/invoiceOverview?invoiceId=demo10001 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12980) MFG- Move from hard-coded menu location to parameterized
[ https://issues.apache.org/jira/browse/OFBIZ-12980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-12980. --- Fix Version/s: Upcoming Branch Assignee: Jacques Le Roux Resolution: Implemented > MFG- Move from hard-coded menu location to parameterized > > > Key: OFBIZ-12980 > URL: https://issues.apache.org/jira/browse/OFBIZ-12980 > Project: OFBiz > Issue Type: Sub-task > Components: manufacturing >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > Move the menu location in various manufacturing screens to parameterized -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12980) MFG- Move from hard-coded menu location to parameterized
[ https://issues.apache.org/jira/browse/OFBIZ-12980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836933#comment-17836933 ] ASF subversion and git services commented on OFBIZ-12980: - Commit e2f7b7fcd468d9a46aa0a14f99187fb68b53d348 in ofbiz-framework's branch refs/heads/trunk from Pierre Smits [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=e2f7b7fcd4 ] Improved: MFG- Move from hard-coded menu location to parameterized (OFBIZ-12980) (#755) Move the menu location in various manufacturing screens to parameterized modified:BomScreens.xml, CalendarScreens.xml, CommonScreens.xml, JobshopScreens.xml, MrpScreens.xml, RoutingScreens.xml - changed location of menus from hard-coded too parameterized > MFG- Move from hard-coded menu location to parameterized > > > Key: OFBIZ-12980 > URL: https://issues.apache.org/jira/browse/OFBIZ-12980 > Project: OFBiz > Issue Type: Sub-task > Components: manufacturing >Reporter: Pierre Smits >Priority: Major > > Move the menu location in various manufacturing screens to parameterized -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Improved: MFG- Move from hard-coded menu location to parameterized (OFBIZ-12980) [ofbiz-framework]
JacquesLeRoux merged PR #755: URL: https://github.com/apache/ofbiz-framework/pull/755 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12518) Agreement Roles - VIEW permissions
[ https://issues.apache.org/jira/browse/OFBIZ-12518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836932#comment-17836932 ] Jacques Le Roux commented on OFBIZ-12518: - Sure, was done here: OFBIZ-13021 > Agreement Roles - VIEW permissions > -- > > Key: OFBIZ-12518 > URL: https://issues.apache.org/jira/browse/OFBIZ-12518 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: agreement(s), permissions, roles, trust, usability, ux > Fix For: Upcoming Branch > > > Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo > with userId = auditor, accessing the Agreement Roles screen, sees editable > fields and/or triggers (to requests) reserved for users with 'CREATE' or > 'UPDATE' permissions. > To see/test: > https://demo-trunk.ofbiz.apache.org/accounting/control/EditAgreement?agreementId=8000 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12971) ORDER - have requestMenuLocation
[ https://issues.apache.org/jira/browse/OFBIZ-12971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836930#comment-17836930 ] Jacques Le Roux commented on OFBIZ-12971: - Ah we crossed on wire (did not update).Will you reopen or create a new one? If you create a new one I prefer to put this one as abandoned, TIA > ORDER - have requestMenuLocation > > > Key: OFBIZ-12971 > URL: https://issues.apache.org/jira/browse/OFBIZ-12971 > Project: OFBiz > Issue Type: Sub-task >Reporter: Pierre Smits >Priority: Major > > Given that request screens are used as portal pages, the inclusion of such > portal pages in other applications leads to errors being thrown for the > associated menus (due to the use of the mainMenuLocation parameter in > web.xml). > Having a requestMenuLocation in web.xml solves this issue. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12969) MyPortal - Move from hard-coded menu location to parameterized
[ https://issues.apache.org/jira/browse/OFBIZ-12969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836931#comment-17836931 ] Jacques Le Roux commented on OFBIZ-12969: - OK, thanks > MyPortal - Move from hard-coded menu location to parameterized > -- > > Key: OFBIZ-12969 > URL: https://issues.apache.org/jira/browse/OFBIZ-12969 > Project: OFBiz > Issue Type: Sub-task > Components: myportal >Reporter: Pierre Smits >Priority: Major > > Move the menu location in the various my portal screens from hard-coded to > parameterized. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (OFBIZ-12969) MyPortal - Move from hard-coded menu location to parameterized
[ https://issues.apache.org/jira/browse/OFBIZ-12969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836917#comment-17836917 ] Jacques Le Roux edited comment on OFBIZ-12969 at 4/14/24 10:03 AM: --- Hi Pierre, I close I see no longer the problem above. But (maybe it's WIP?) ERROR MESSAGE java.lang.RuntimeException: Error rendering included menu named [PersonUpdate] at location []: java.lang.IllegalArgumentException: Could not find menu file in location [] java.lang.RuntimeException: Error rendering included menu named [TimesheetBar] at location [component://myportal/widget/MyPortalMenus.xml]: java.lang.IllegalArgumentException: Could not find menu with name [TimesheetBar] in location [component://myportal/widget/MyPortalMenus.xml] java.lang.RuntimeException: Error rendering screenlet in screen named [MyLeaveList]: java.io.IOException: java.lang.NullPointerException: Cannot invoke "org.w3c.dom.Element.getAttribute(String)" because "formElement" is null Also we have 2 main buttons. PLease create Jira issues for each pb above if it's not already known and WIP, TIA was (Author: jacques.le.roux): Hi Pierre, I close I see no longer a problem at But (maybe it's WIP?) ERROR MESSAGE java.lang.RuntimeException: Error rendering included menu named [PersonUpdate] at location []: java.lang.IllegalArgumentException: Could not find menu file in location [] java.lang.RuntimeException: Error rendering included menu named [TimesheetBar] at location [component://myportal/widget/MyPortalMenus.xml]: java.lang.IllegalArgumentException: Could not find menu with name [TimesheetBar] in location [component://myportal/widget/MyPortalMenus.xml] java.lang.RuntimeException: Error rendering screenlet in screen named [MyLeaveList]: java.io.IOException: java.lang.NullPointerException: Cannot invoke "org.w3c.dom.Element.getAttribute(String)" because "formElement" is null Also we have 2 main buttons. PLease create Jira issues for each pb above if it's not already known and WIP, TIA > MyPortal - Move from hard-coded menu location to parameterized > -- > > Key: OFBIZ-12969 > URL: https://issues.apache.org/jira/browse/OFBIZ-12969 > Project: OFBiz > Issue Type: Sub-task > Components: myportal >Reporter: Pierre Smits >Priority: Major > > Move the menu location in the various my portal screens from hard-coded to > parameterized. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Improved: ORDER - have requestMenuLocation (OFBIZ-12971) [ofbiz-framework]
JacquesLeRoux commented on PR #742: URL: https://github.com/apache/ofbiz-framework/pull/742#issuecomment-2053991509 Ah I think I got, it has been partially replaced by https://github.com/apache/ofbiz-framework/commit/6039526c744e1a75e5c40b553de964041f386531, nevermind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12971) ORDER - have requestMenuLocation
[ https://issues.apache.org/jira/browse/OFBIZ-12971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836929#comment-17836929 ] Jacques Le Roux commented on OFBIZ-12971: - Hi Pierre, Why has this been closed? We have no commit here. Has it been abandonned rather? > ORDER - have requestMenuLocation > > > Key: OFBIZ-12971 > URL: https://issues.apache.org/jira/browse/OFBIZ-12971 > Project: OFBiz > Issue Type: Sub-task >Reporter: Pierre Smits >Priority: Major > > Given that request screens are used as portal pages, the inclusion of such > portal pages in other applications leads to errors being thrown for the > associated menus (due to the use of the mainMenuLocation parameter in > web.xml). > Having a requestMenuLocation in web.xml solves this issue. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-13024) Make theme variants visible in demo sites
[ https://issues.apache.org/jira/browse/OFBIZ-13024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-13024: - Summary: Make theme variants visible in demo sites (was: Make all them variants visible in demo sites) > Make theme variants visible in demo sites > - > > Key: OFBIZ-13024 > URL: https://issues.apache.org/jira/browse/OFBIZ-13024 > Project: OFBiz > Issue Type: Bug > Components: datamodel >Reporter: Pierre Smits >Priority: Major > > Currently we have 58 UserLogin records in demo data, and 12 back-office > VisualTheme records in our demo data sets. > In order to have more visibilities of the various themes, we should set for > various UserLogins the theme as a preference. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-13024) Make all them variants visible in demo sites
Pierre Smits created OFBIZ-13024: Summary: Make all them variants visible in demo sites Key: OFBIZ-13024 URL: https://issues.apache.org/jira/browse/OFBIZ-13024 Project: OFBiz Issue Type: Bug Components: datamodel Reporter: Pierre Smits Currently we have 58 UserLogin records in demo data, and 12 VisualTheme records in our demo data sets. In order to have more visibilities of the various themes, we should set for various UserLogins the theme as a preference. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-13024) Make all them variants visible in demo sites
[ https://issues.apache.org/jira/browse/OFBIZ-13024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-13024: - Description: Currently we have 58 UserLogin records in demo data, and 12 back-office VisualTheme records in our demo data sets. In order to have more visibilities of the various themes, we should set for various UserLogins the theme as a preference. was: Currently we have 58 UserLogin records in demo data, and 12 VisualTheme records in our demo data sets. In order to have more visibilities of the various themes, we should set for various UserLogins the theme as a preference. > Make all them variants visible in demo sites > > > Key: OFBIZ-13024 > URL: https://issues.apache.org/jira/browse/OFBIZ-13024 > Project: OFBiz > Issue Type: Bug > Components: datamodel >Reporter: Pierre Smits >Priority: Major > > Currently we have 58 UserLogin records in demo data, and 12 back-office > VisualTheme records in our demo data sets. > In order to have more visibilities of the various themes, we should set for > various UserLogins the theme as a preference. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12969) MyPortal - Move from hard-coded menu location to parameterized
[ https://issues.apache.org/jira/browse/OFBIZ-12969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836923#comment-17836923 ] Pierre Smits commented on OFBIZ-12969: -- Hi Jacques, Indeed, MyPortal menu parameterization is still WIP, given that PortalPage screens references can be found in any component, and can be utilized anywhere. bq. Also we have 2 main buttons Ha. I remember we had this recently come up. > MyPortal - Move from hard-coded menu location to parameterized > -- > > Key: OFBIZ-12969 > URL: https://issues.apache.org/jira/browse/OFBIZ-12969 > Project: OFBiz > Issue Type: Sub-task > Components: myportal >Reporter: Pierre Smits >Priority: Major > > Move the menu location in the various my portal screens from hard-coded to > parameterized. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (OFBIZ-13017) invoiceOverview generates an error
[ https://issues.apache.org/jira/browse/OFBIZ-13017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836922#comment-17836922 ] Jacques Le Roux edited comment on OFBIZ-13017 at 4/14/24 9:24 AM: -- That error does not exist in next: https://demo-stable.ofbiz.apache.org/accounting/control/invoiceOverview?invoiceId=demo10001 was (Author: jacques.le.roux): That error does not exist in next > invoiceOverview generates an error > -- > > Key: OFBIZ-13017 > URL: https://issues.apache.org/jira/browse/OFBIZ-13017 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Pierre Smits >Priority: Major > > see > https://demo-trunk.ofbiz.apache.org/accounting/control/invoiceOverview?invoiceId=demo10001 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13017) invoiceOverview generates an error
[ https://issues.apache.org/jira/browse/OFBIZ-13017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836922#comment-17836922 ] Jacques Le Roux commented on OFBIZ-13017: - That error does not exist in next > invoiceOverview generates an error > -- > > Key: OFBIZ-13017 > URL: https://issues.apache.org/jira/browse/OFBIZ-13017 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Pierre Smits >Priority: Major > > see > https://demo-trunk.ofbiz.apache.org/accounting/control/invoiceOverview?invoiceId=demo10001 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (OFBIZ-13017) invoiceOverview generates an error
[ https://issues.apache.org/jira/browse/OFBIZ-13017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836922#comment-17836922 ] Jacques Le Roux edited comment on OFBIZ-13017 at 4/14/24 9:24 AM: -- That error does not exist in next: https://demo-next.ofbiz.apache.org/accounting/control/invoiceOverview?invoiceId=demo10001 was (Author: jacques.le.roux): That error does not exist in next: https://demo-stable.ofbiz.apache.org/accounting/control/invoiceOverview?invoiceId=demo10001 > invoiceOverview generates an error > -- > > Key: OFBIZ-13017 > URL: https://issues.apache.org/jira/browse/OFBIZ-13017 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Pierre Smits >Priority: Major > > see > https://demo-trunk.ofbiz.apache.org/accounting/control/invoiceOverview?invoiceId=demo10001 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (OFBIZ-12969) MyPortal - Move from hard-coded menu location to parameterized
[ https://issues.apache.org/jira/browse/OFBIZ-12969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-12969: --- Assignee: (was: Jacques Le Roux) > MyPortal - Move from hard-coded menu location to parameterized > -- > > Key: OFBIZ-12969 > URL: https://issues.apache.org/jira/browse/OFBIZ-12969 > Project: OFBiz > Issue Type: Sub-task > Components: myportal >Reporter: Pierre Smits >Priority: Major > > Move the menu location in the various my portal screens from hard-coded to > parameterized. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12969) MyPortal - Move from hard-coded menu location to parameterized
[ https://issues.apache.org/jira/browse/OFBIZ-12969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836917#comment-17836917 ] Jacques Le Roux commented on OFBIZ-12969: - Hi Pierre, I close I see no longer a problem at But (maybe it's WIP?) ERROR MESSAGE java.lang.RuntimeException: Error rendering included menu named [PersonUpdate] at location []: java.lang.IllegalArgumentException: Could not find menu file in location [] java.lang.RuntimeException: Error rendering included menu named [TimesheetBar] at location [component://myportal/widget/MyPortalMenus.xml]: java.lang.IllegalArgumentException: Could not find menu with name [TimesheetBar] in location [component://myportal/widget/MyPortalMenus.xml] java.lang.RuntimeException: Error rendering screenlet in screen named [MyLeaveList]: java.io.IOException: java.lang.NullPointerException: Cannot invoke "org.w3c.dom.Element.getAttribute(String)" because "formElement" is null Also we have 2 main buttons. PLease create Jira issues for each pb above if it's not already known and WIP, TIA > MyPortal - Move from hard-coded menu location to parameterized > -- > > Key: OFBIZ-12969 > URL: https://issues.apache.org/jira/browse/OFBIZ-12969 > Project: OFBiz > Issue Type: Sub-task > Components: myportal >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > > Move the menu location in the various my portal screens from hard-coded to > parameterized. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12969) MyPortal - Move from hard-coded menu location to parameterized
[ https://issues.apache.org/jira/browse/OFBIZ-12969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836919#comment-17836919 ] Jacques Le Roux commented on OFBIZ-12969: - I'll rather let open as long as no new JIra issues have been created > MyPortal - Move from hard-coded menu location to parameterized > -- > > Key: OFBIZ-12969 > URL: https://issues.apache.org/jira/browse/OFBIZ-12969 > Project: OFBiz > Issue Type: Sub-task > Components: myportal >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > > Move the menu location in the various my portal screens from hard-coded to > parameterized. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12971) ORDER - have requestMenuLocation
[ https://issues.apache.org/jira/browse/OFBIZ-12971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836912#comment-17836912 ] Pierre Smits commented on OFBIZ-12971: -- Hi [~jleroux] I had to do some decluttering. It can be reopened when it comes around > ORDER - have requestMenuLocation > > > Key: OFBIZ-12971 > URL: https://issues.apache.org/jira/browse/OFBIZ-12971 > Project: OFBiz > Issue Type: Sub-task >Reporter: Pierre Smits >Priority: Major > > Given that request screens are used as portal pages, the inclusion of such > portal pages in other applications leads to errors being thrown for the > associated menus (due to the use of the mainMenuLocation parameter in > web.xml). > Having a requestMenuLocation in web.xml solves this issue. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12518) Agreement Roles - VIEW permissions
[ https://issues.apache.org/jira/browse/OFBIZ-12518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836910#comment-17836910 ] Pierre Smits commented on OFBIZ-12518: -- [~jleroux] bq. Note that anyway even and admin could not create an agreement role, see https://issues.apache.org/jira/browse/OFBIZ-13021. I guess it's due to the change to entity-auto, did not dig deeper. Should that not warrant a new ticket? > Agreement Roles - VIEW permissions > -- > > Key: OFBIZ-12518 > URL: https://issues.apache.org/jira/browse/OFBIZ-12518 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: agreement(s), permissions, roles, trust, usability, ux > Fix For: Upcoming Branch > > > Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo > with userId = auditor, accessing the Agreement Roles screen, sees editable > fields and/or triggers (to requests) reserved for users with 'CREATE' or > 'UPDATE' permissions. > To see/test: > https://demo-trunk.ofbiz.apache.org/accounting/control/EditAgreement?agreementId=8000 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-13023) Have labels reflect the content of fields in forms and overviews
Pierre Smits created OFBIZ-13023: Summary: Have labels reflect the content of fields in forms and overviews Key: OFBIZ-13023 URL: https://issues.apache.org/jira/browse/OFBIZ-13023 Project: OFBiz Issue Type: Improvement Components: ALL APPLICATIONS Reporter: Pierre Smits Consistent application of labels in forms (edit and view) and overviews (grids) across components and plugins improve the appeal of OFBiz for potential adopters and the UX of those actually using the product. Currently, in various forms (edit and view) and overviews (grids), labels of fields don't reflect what the content of that field is. As examples: * various TypeId fields showing the description of the type, but the label does not reflect that * partyId fields having the name of the party shown, but labeled Party Id * roleTypeId fields in various forms having label CommonRole, and in others showing label Role Type Id (while the value shown is the description -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Improved: EBAY- Move from hard-coded menu location to parameterized (OFBIZ-13022) [ofbiz-plugins]
sonarcloud[bot] commented on PR #109: URL: https://github.com/apache/ofbiz-plugins/pull/109#issuecomment-2053965406 ## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-plugins&pullRequest=109) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=109&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=109&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins&pullRequest=109&resolved=false&inNewCodePeriod=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=109&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-plugins&pullRequest=109) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Improved: EBAY- Move from hard-coded menu location to parameterized (OFBIZ-13022) [ofbiz-plugins]
PierreSmits opened a new pull request, #109: URL: https://github.com/apache/ofbiz-plugins/pull/109 Move the product menu location in various eBay screens to parameterized modified: - web.xml: added context-param productMenuLocation - CommonScreens.xml: changed location of ProductTabBar from hard coded to parameterized -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (OFBIZ-13022) EBAY- Move from hard-coded menu location to parameterized
[ https://issues.apache.org/jira/browse/OFBIZ-13022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-13022: - Description: Move the product menu location in various eBay screens to parameterized (was: Move the catalog menu location in various eBay screens to parameterized) > EBAY- Move from hard-coded menu location to parameterized > - > > Key: OFBIZ-13022 > URL: https://issues.apache.org/jira/browse/OFBIZ-13022 > Project: OFBiz > Issue Type: Sub-task > Components: product/catalog >Reporter: Pierre Smits >Priority: Major > > Move the product menu location in various eBay screens to parameterized -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-13022) EBAY- Move from hard-coded menu location to parameterized
[ https://issues.apache.org/jira/browse/OFBIZ-13022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-13022: - Summary: EBAY- Move from hard-coded menu location to parameterized (was: CATALOG- Move from hard-coded menu location to parameterized) > EBAY- Move from hard-coded menu location to parameterized > - > > Key: OFBIZ-13022 > URL: https://issues.apache.org/jira/browse/OFBIZ-13022 > Project: OFBiz > Issue Type: Sub-task > Components: product/catalog >Reporter: Pierre Smits >Priority: Major > > Move the menu location in various catalog screens to parameterized -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-13022) EBAY- Move from hard-coded menu location to parameterized
[ https://issues.apache.org/jira/browse/OFBIZ-13022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-13022: - Description: Move the catalog menu location in various eBay screens to parameterized (was: Move the menu location in various catalog screens to parameterized) > EBAY- Move from hard-coded menu location to parameterized > - > > Key: OFBIZ-13022 > URL: https://issues.apache.org/jira/browse/OFBIZ-13022 > Project: OFBiz > Issue Type: Sub-task > Components: product/catalog >Reporter: Pierre Smits >Priority: Major > > Move the catalog menu location in various eBay screens to parameterized -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-13022) CATALOG- Move from hard-coded menu location to parameterized
Pierre Smits created OFBIZ-13022: Summary: CATALOG- Move from hard-coded menu location to parameterized Key: OFBIZ-13022 URL: https://issues.apache.org/jira/browse/OFBIZ-13022 Project: OFBiz Issue Type: Sub-task Components: product/catalog Reporter: Pierre Smits Move the menu location in various catalog screens to parameterized -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Improved: MFG- Move from hard-coded menu location to parameterized (OFBIZ-12980) [ofbiz-framework]
sonarcloud[bot] commented on PR #755: URL: https://github.com/apache/ofbiz-framework/pull/755#issuecomment-2053955812 ## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=755) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=755&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=755&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=755&resolved=false&inNewCodePeriod=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=755&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=755) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Improved: MFG- Move from hard-coded menu location to parameterized (OFBIZ-12980) [ofbiz-framework]
PierreSmits opened a new pull request, #755: URL: https://github.com/apache/ofbiz-framework/pull/755 Move the menu location in various manufacturing screens to parameterized modified:BomScreens.xml, CalendarScreens.xml, CommonScreens.xml, JobshopScreens.xml, MrpScreens.xml, RoutingScreens.xml - changed location of menus from hard-coded too parameterized -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12971) ORDER - have requestMenuLocation
[ https://issues.apache.org/jira/browse/OFBIZ-12971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836903#comment-17836903 ] Jacques Le Roux commented on OFBIZ-12971: - Hi Pierre, Why has this been closed? TIA > ORDER - have requestMenuLocation > > > Key: OFBIZ-12971 > URL: https://issues.apache.org/jira/browse/OFBIZ-12971 > Project: OFBiz > Issue Type: Sub-task >Reporter: Pierre Smits >Priority: Major > > Given that request screens are used as portal pages, the inclusion of such > portal pages in other applications leads to errors being thrown for the > associated menus (due to the use of the mainMenuLocation parameter in > web.xml). > Having a requestMenuLocation in web.xml solves this issue. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Improved: ORDER - have requestMenuLocation (OFBIZ-12971) [ofbiz-framework]
JacquesLeRoux commented on PR #742: URL: https://github.com/apache/ofbiz-framework/pull/742#issuecomment-2053946100 Hi @PierreSmits , Why has this been closed? TIA -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-13005) Trunk demo errors in error.log
[
https://issues.apache.org/jira/browse/OFBIZ-13005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836899#comment-17836899
]
Jacques Le Roux commented on OFBIZ-13005:
-
New ones for yesterday:
2024-04-13 06:40:29,923 |-0.0.0.0-8009-exec-9 |ServiceDispatcher
|E| Incoming context (in runSync : createSurveyResponse) does not match
expected requirements
org.apache.ofbiz.service.ServiceValidationException: The following required
parameter is missing: surveyIdRequired Field Missing : Answers.
java.lang.IllegalArgumentException: Could not find screen with name
[InvoiceOverview] in class resource
[component://accounting/widget/InvoiceScreens.xml]
freemarker.core.InvalidReferenceException: The following has evaluated to null
or missing:
==> parameters.SEARCH_STRING [in template
"component://order/template/entry/catalog/TagSearch.ftl" at line 20, column 47]
Tip: It's the step after the last dot that caused this error, not those before
it.
Tip: If the failing expression is known to legally refer to something that's
sometimes null or missing, either specify a default value like
myOptionalVar!myDefault, or use <#if
myOptionalVar??>when-present<#else>when-missing. (These only cover the
last step of the expression; to cover the whole expression, use parenthesis:
(myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??
FTL stack trace ("~" means nesting-related):
- Failed at: ${parameters.SEARCH_STRING} [in template
"component://order/template/entry/catalog/TagSearch.ftl" at line 20, column 45]
java.lang.IllegalArgumentException: Error running script at location
[component://product/src/main/groovy/org/apache/ofbiz/product/facility/facility/CountFacilityInventoryByProduct.groovy]:
groovy.lang.MissingMethodException: No signature of method:
org.apache.ofbiz.product.facility.facility.CountFacilityInventoryByProduct.from()
is applicable for argument types:
(org.apache.ofbiz.entity.model.DynamicViewEntity) values:
[org.apache.ofbiz.entity.model.DynamicViewEntity@2c3d4324]
Possible solutions: from(java.lang.String), run(), run(), find(), grep(),
error(java.lang.String)
java.lang.IllegalArgumentException: Error running script at location
[component://product/src/main/groovy/org/apache/ofbiz/product/facility/facility/ViewFacilityInventoryByProduct.groovy]:
groovy.lang.MissingMethodException: No signature of method:
org.apache.ofbiz.product.facility.facility.ViewFacilityInventoryByProduct.from()
is applicable for argument types:
(org.apache.ofbiz.entity.model.DynamicViewEntity) values:
[org.apache.ofbiz.entity.model.DynamicViewEntity@e03df4c]
Possible solutions: from(java.lang.String), run(), run(), find(), grep(),
error(java.lang.String)
> Trunk demo errors in error.log
> --
>
> Key: OFBIZ-13005
> URL: https://issues.apache.org/jira/browse/OFBIZ-13005
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Priority: Blocker
>
> For 3 days now I have collected the trunk demo errors in error.log. I believe
> we should try to fix as most as possible of them before freezing a new branch.
> I did check the value of them but some could still be minor.
> @All ([~ofbiz.user]?), I have changed the priority to blocker. Of course not
> all errors reported here are valid and some are surely not blocker. The idea
> is more to have a look at remaining issueg before freezing. I have also
> removed the no format, despite the place taken, to ease researches in the
> errors list.
> Here is the result to be better filterered:
> 2024-04-04 12:31:19,135 |-0.0.0.0-8009-exec-9 |ModelSingleForm
> |E| Failed to load parent form definition 'ListWorkEfforts' at resource
> 'component://workeffort/widget/WorkEffortForms.xml'
> java.lang.NullPointerException: Cannot invoke
> "org.w3c.dom.Element.getAttribute(String)" because "formElement" is null
> 2024-04-04 12:35:00,432 |-0.0.0.0-8009-exec-8 |ControlServlet
> |E| Error in request handler:
> java.lang.RuntimeException: Error rendering included menu named
> [MainActionMenu] at location [component://myportal/widget/MyPortalMenus.xml]:
> java.lang.IllegalArgumentException: Could not find menu with name
> [MainActionMenu] in location [component://myportal/widget/MyPortalMenus.xml]
> 2024-04-04 12:34:49,329 |-0.0.0.0-8009-exec-5 |ControlServlet
> |E| Error in request handler:
> java.lang.RuntimeException: Error rendering included menu named
> [RequestScreenletMenu] at location
> [component://myportal/widget/MyPortalMenus.xml]:
> java.lang.IllegalArgumentException: Could not find menu with name
> [RequestScreenletMenu] in location
> [component://myportal/widget/MyPortalMenus.xml]
> at java.
[jira] [Commented] (OFBIZ-13005) Trunk demo errors in error.log
[
https://issues.apache.org/jira/browse/OFBIZ-13005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836900#comment-17836900
]
Jacques Le Roux commented on OFBIZ-13005:
-
I will soon close here and start a new similar Jira. I wait for a replacement
solution to https://github.com/apache/ofbiz-plugins/pull/106
> Trunk demo errors in error.log
> --
>
> Key: OFBIZ-13005
> URL: https://issues.apache.org/jira/browse/OFBIZ-13005
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Priority: Blocker
>
> For 3 days now I have collected the trunk demo errors in error.log. I believe
> we should try to fix as most as possible of them before freezing a new branch.
> I did check the value of them but some could still be minor.
> @All ([~ofbiz.user]?), I have changed the priority to blocker. Of course not
> all errors reported here are valid and some are surely not blocker. The idea
> is more to have a look at remaining issueg before freezing. I have also
> removed the no format, despite the place taken, to ease researches in the
> errors list.
> Here is the result to be better filterered:
> 2024-04-04 12:31:19,135 |-0.0.0.0-8009-exec-9 |ModelSingleForm
> |E| Failed to load parent form definition 'ListWorkEfforts' at resource
> 'component://workeffort/widget/WorkEffortForms.xml'
> java.lang.NullPointerException: Cannot invoke
> "org.w3c.dom.Element.getAttribute(String)" because "formElement" is null
> 2024-04-04 12:35:00,432 |-0.0.0.0-8009-exec-8 |ControlServlet
> |E| Error in request handler:
> java.lang.RuntimeException: Error rendering included menu named
> [MainActionMenu] at location [component://myportal/widget/MyPortalMenus.xml]:
> java.lang.IllegalArgumentException: Could not find menu with name
> [MainActionMenu] in location [component://myportal/widget/MyPortalMenus.xml]
> 2024-04-04 12:34:49,329 |-0.0.0.0-8009-exec-5 |ControlServlet
> |E| Error in request handler:
> java.lang.RuntimeException: Error rendering included menu named
> [RequestScreenletMenu] at location
> [component://myportal/widget/MyPortalMenus.xml]:
> java.lang.IllegalArgumentException: Could not find menu with name
> [RequestScreenletMenu] in location
> [component://myportal/widget/MyPortalMenus.xml]
> at java.lang.Thread.run(Thread.java:840) [?:?]
> 2024-04-04 12:34:53,562 |0.0.0.0-8009-exec-10 |ControlServlet
> |E| Error in request handler:
> java.lang.RuntimeException: Error rendering included menu named
> [PersonUpdate] at location [component://myportal/widget/MyPortalMenus.xml]:
> java.lang.IllegalArgumentException: Could not find menu with name
> [PersonUpdate] in location [component://myportal/widget/MyPortalMenus.xml]
> at
> org.apache.ofbiz.widget.model.ModelScreenWidget$Menu.getModelMenu(ModelScreenWidget.java:1648)
> ~[ofbiz.jar:?]
> 2024-04-05 12:53:05,232 |-0.0.0.0-8009-exec-5 |FreeMarkerWorker
> |E| null
> freemarker.core._MiscTemplateException: Macro "renderDateTimeField" has no
> parameter with name "dateType". Valid parameter names are: name, className,
> timeDropdownParamName, defaultDateTimeString, localizedIconTitle,
> timeHourName, timeMinutesName, ampmName, compositeType, alert, isTimeType,
> isDateType, amSelected, pmSelected, timeDropdown, classString, isTwelveHour,
> hour1, hour2, minutes, shortDateInput, title, value, size, maxlength, id,
> formName, mask, event, action, step, timeValues, tabindex, disabled,
> isXMLHttpRequest
>
> FTL stack trace ("~" means nesting-related):
> - Failed at: @htmlTemplate.renderDateTimeField eve... [in template
> "component://ecommerce/template/catalog/ProductDetail.ftl" at line 726,
> column 17]
> 2024-04-05 15:50:42,492 |-0.0.0.0-8009-exec-4 |UtilXml
> |E| XmlFileLoader: File
> file:/ofbiz/framework/common/widget/PortalPageScreens.xml process error.
> Line: 82. Error message: cvc-datatype-valid.1.2.1: '${parameters.confMode}'
> is not a valid value for 'boolean'.
> 2024-04-05 15:50:42,492 |-0.0.0.0-8009-exec-4 |UtilXml
> |E| XmlFileLoader: File
> file:/ofbiz/framework/common/widget/PortalPageScreens.xml process error.
> Line: 82. Error message: cvc-datatype-valid.1.2.1: '${parameters.usePrivate}'
> is not a valid value for 'boolean'.
> 2024-04-06 07:04:58,770 |-0.0.0.0-8009-exec-2 |UtilXml
> |E| XmlFileLoader: File
> file:/ofbiz/framework/common/widget/PortalPageScreens.xml process error.
> Line: 82. Error message: cvc-datatype-valid.1.2.1: '${parameters.confMode}'
> is not a valid value for 'boolean'.
> 2024-04-06 07:04:58,771 |-0.0.0.0-8009-exec-2 |UtilXml
> |E| XmlFileLoader:
[jira] [Commented] (OFBIZ-12518) Agreement Roles - VIEW permissions
[ https://issues.apache.org/jira/browse/OFBIZ-12518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836898#comment-17836898 ] Jacques Le Roux commented on OFBIZ-12518: - Error in commit message, replace bq. Note that anyway even and admin could not create an agreement role, see https://issues.apache.org/jira/browse/OFBIZ-12518. I guess it's due to the change to entity-auto, did not dig deeper. by bq. Note that anyway even and admin could not create an agreement role, see https://issues.apache.org/jira/browse/OFBIZ-13021. I guess it's due to the change to entity-auto, did not dig deeper. > Agreement Roles - VIEW permissions > -- > > Key: OFBIZ-12518 > URL: https://issues.apache.org/jira/browse/OFBIZ-12518 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: agreement(s), permissions, roles, trust, usability, ux > Fix For: Upcoming Branch > > > Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo > with userId = auditor, accessing the Agreement Roles screen, sees editable > fields and/or triggers (to requests) reserved for users with 'CREATE' or > 'UPDATE' permissions. > To see/test: > https://demo-trunk.ofbiz.apache.org/accounting/control/EditAgreement?agreementId=8000 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12518) Agreement Roles - VIEW permissions
[ https://issues.apache.org/jira/browse/OFBIZ-12518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-12518. --- Fix Version/s: Upcoming Branch Resolution: Implemented > Agreement Roles - VIEW permissions > -- > > Key: OFBIZ-12518 > URL: https://issues.apache.org/jira/browse/OFBIZ-12518 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: agreement(s), permissions, roles, trust, usability, ux > Fix For: Upcoming Branch > > > Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo > with userId = auditor, accessing the Agreement Roles screen, sees editable > fields and/or triggers (to requests) reserved for users with 'CREATE' or > 'UPDATE' permissions. > To see/test: > https://demo-trunk.ofbiz.apache.org/accounting/control/EditAgreement?agreementId=8000 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12518) Agreement Roles - VIEW permissions
[ https://issues.apache.org/jira/browse/OFBIZ-12518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836896#comment-17836896 ] ASF subversion and git services commented on OFBIZ-12518: - Commit f6a2af5be6b3975d394352308d32368714d3621e in ofbiz-framework's branch refs/heads/trunk from Pierre Smits [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=f6a2af5be6 ] Improved: Agreement Roles - VIEW permissions (OFBIZ-12518) (#471) * Improved: Agreement Roles - VIEW permissions (OFBIZ-12518) Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo with userId = auditor, accessing the Agreement Roles screen, sees editable fields and/or triggers (to requests) reserved for users with 'CREATE' or 'UPDATE' permissions. To see/test: https://localhost:8443/accounting/control/EditAgreementRoles?agreementId=8000 modified: - AgreementScreens.xml - restructured screen EditAgreementRoles to work with permissions - AgreementForms.xml - added grid AgreementRoles for users with VIEW permissions additional cleanup * Update AgreementForms.xml - Co-authored-by: Jacques Le Roux Respectively replaces labels CommonParty and CommonRole by PartyPartyId and PartyRoleTypeId Note that anyway even and admin could not create an agreement role, see https://issues.apache.org/jira/browse/OFBIZ-12518. I guess it's due to the change to entity-auto, did not dig deeper. > Agreement Roles - VIEW permissions > -- > > Key: OFBIZ-12518 > URL: https://issues.apache.org/jira/browse/OFBIZ-12518 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: agreement(s), permissions, roles, trust, usability, ux > > Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo > with userId = auditor, accessing the Agreement Roles screen, sees editable > fields and/or triggers (to requests) reserved for users with 'CREATE' or > 'UPDATE' permissions. > To see/test: > https://demo-trunk.ofbiz.apache.org/accounting/control/EditAgreement?agreementId=8000 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Improved: Agreement Roles - VIEW permissions (OFBIZ-12518) [ofbiz-framework]
JacquesLeRoux merged PR #471: URL: https://github.com/apache/ofbiz-framework/pull/471 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improved: Agreement Roles - VIEW permissions (OFBIZ-12518) [ofbiz-framework]
sonarcloud[bot] commented on PR #471: URL: https://github.com/apache/ofbiz-framework/pull/471#issuecomment-2053939842 ## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=471) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=471&resolved=false&inNewCodePeriod=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=471&metric=new_accepted_issues&view=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=471&resolved=false&inNewCodePeriod=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=471&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=471) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
