[jira] [Closed] (OFBIZ-13042) Ecommerce-parameterized menu location

2024-05-10 Thread Jacques Le Roux (Jira) 


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-13042.
---
Fix Version/s: Upcoming Branch
 Assignee: Jacques Le Roux
   Resolution: Fixed

> Ecommerce-parameterized menu location
> -
>
> Key: OFBIZ-13042
> URL: https://issues.apache.org/jira/browse/OFBIZ-13042
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ecommerce
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> Move to  parameterized menu locations



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (OFBIZ-13042) Ecommerce-parameterized menu location

2024-05-10 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-13042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845451#comment-17845451
 ] 

ASF subversion and git services commented on OFBIZ-13042:
-

Commit 6b73cf1f065b9fdfb2b205bb04cad585cad4f737 in ofbiz-plugins's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=6b73cf1f0 ]

Improved: Ecommerce - parameterized menu location (OFBIZ-13042) (#115)

* Improved: Ecommerce - move to parameterized menu location

modified: web.xml - add mainMenuLocation

* Improved: Ecommerce - move to parameterized menu location (OFBIZ-13042)

added EcommerceMenus.xml

* Improved: Ecommerce - move to parameterized menu location (OFBIZ-13042)

BlogScreens.xml: changed menu location

* Improved: Ecommerce - move to parameterized menu location (OFBIZ-13042)

ecomseo/web.xml added mainMenuLocation

* Improved: Ecommerce parameterized menu location (OFBIZ-13042)

modified:
- BlogScreens.xml: corrected menu location - added missing }

removed: BlogMenus.xml

> Ecommerce-parameterized menu location
> -
>
> Key: OFBIZ-13042
> URL: https://issues.apache.org/jira/browse/OFBIZ-13042
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ecommerce
>Reporter: Pierre Smits
>Priority: Major
>
> Move to  parameterized menu locations



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] Improved: Ecommerce - parameterized menu location (OFBIZ-13042) [ofbiz-plugins]

2024-05-10 Thread via GitHub 


JacquesLeRoux merged PR #115:
URL: https://github.com/apache/ofbiz-plugins/pull/115


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Improved: Ecommerce - parameterized menu location (OFBIZ-13042) [ofbiz-plugins]

2024-05-10 Thread via GitHub 


JacquesLeRoux commented on PR #115:
URL: https://github.com/apache/ofbiz-plugins/pull/115#issuecomment-2105081507

   Hi Pierre,
   
   Test OK, your proposition sounds reasonable to me since only blog*.xml are 
apart


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (OFBIZ-13039) dateType parameter not existing in "renderDateTimeField" Macro

2024-05-10 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-13039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845431#comment-17845431
 ] 

ASF subversion and git services commented on OFBIZ-13039:
-

Commit c223de1a4dfae4fdd3702d765ebfef9fe887e6b7 in ofbiz-plugins's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=c223de1a4 ]

Fixed: dateType parameter not existing in "renderDateTimeField" Macro 
(OFBIZ-13039)

Previous commit (4de5d7bf7e3f077cc81bd1d62bb1848c83c9392b) was wrong. I put back
dateType="date" parameter when isDateType=true should have been used.
It was put in with OFBIZ-12126 but then not changed in templates plugins

It also fixes commit ba1b753ef6d653e6e7aeeca4add330c627cabf91 of OFBIZ-7949

So this replaces dateType="date" by isDateType=true in "renderDateTimeField"
Macro in:
ProductDetail.ftl
EditShoppingList.ftl
EditTaskAndAssoc.ftl
ListSurveys.ftl


> dateType parameter not existing in "renderDateTimeField" Macro 
> ---
>
> Key: OFBIZ-13039
> URL: https://issues.apache.org/jira/browse/OFBIZ-13039
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: 18.12.13
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.13
>
>
> freemarker.core._MiscTemplateException: Macro "renderDateTimeField" has no 
> parameter with name "dateType". Valid parameter names are: name, className, 
> timeDropdownParamName, defaultDateTimeString, localizedIconTitle, 
> timeHourName, timeMinutesName, ampmName, compositeType, alert, isTimeType, 
> isDateType, amSelected, pmSelected, timeDropdown, classString, isTwelveHour, 
> hour1, hour2, minutes, shortDateInput, title, value, size, maxlength, id, 
> formName, mask, event, action, step, timeValues, tabindex, disabled, 
> isXMLHttpRequest
> 
> FTL stack trace ("~" means nesting-related):
>   - Failed at: @htmlTemplate.renderDateTimeField eve...  [in template 
> "component://ecommerce/template/catalog/ProductDetail.ftl" at line 726, 
> column 17]
> 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (OFBIZ-7949) E-commerce : FTL formatting

2024-05-10 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-7949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845430#comment-17845430
 ] 

ASF subversion and git services commented on OFBIZ-7949:


Commit 7a709d6de39e8fdd6f5c374fecd2fc3945647797 in ofbiz-plugins's branch 
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=7a709d6de ]

Fixed: dateType parameter not existing in "renderDateTimeField" Macro 
(OFBIZ-13039)

Previous commit (4de5d7bf7e3f077cc81bd1d62bb1848c83c9392b) was wrong. I put back
dateType="date" parameter when isDateType=true should have been used.
It was put in with OFBIZ-12126 but then not changed in templates plugins

It also fixes commit ba1b753ef6d653e6e7aeeca4add330c627cabf91 of OFBIZ-7949

So this replaces dateType="date" by isDateType=true in "renderDateTimeField"
Macro in:
ProductDetail.ftl
EditShoppingList.ftl
EditTaskAndAssoc.ftl
ListSurveys.ftl


> E-commerce : FTL formatting
> ---
>
> Key: OFBIZ-7949
> URL: https://issues.apache.org/jira/browse/OFBIZ-7949
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ecommerce
>Affects Versions: 18.12.13
>Reporter: Vaibhav Jain
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.14
>
> Attachments: OFBIZ-7949.patch, OFBIZ-7949.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (OFBIZ-12126) Refactor MacroFormRenderer to use RenderableFtlElements for datetime fields

2024-05-10 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-12126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845432#comment-17845432
 ] 

ASF subversion and git services commented on OFBIZ-12126:
-

Commit c223de1a4dfae4fdd3702d765ebfef9fe887e6b7 in ofbiz-plugins's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=c223de1a4 ]

Fixed: dateType parameter not existing in "renderDateTimeField" Macro 
(OFBIZ-13039)

Previous commit (4de5d7bf7e3f077cc81bd1d62bb1848c83c9392b) was wrong. I put back
dateType="date" parameter when isDateType=true should have been used.
It was put in with OFBIZ-12126 but then not changed in templates plugins

It also fixes commit ba1b753ef6d653e6e7aeeca4add330c627cabf91 of OFBIZ-7949

So this replaces dateType="date" by isDateType=true in "renderDateTimeField"
Macro in:
ProductDetail.ftl
EditShoppingList.ftl
EditTaskAndAssoc.ftl
ListSurveys.ftl


> Refactor MacroFormRenderer to use RenderableFtlElements for datetime fields
> ---
>
> Key: OFBIZ-12126
> URL: https://issues.apache.org/jira/browse/OFBIZ-12126
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework/widget
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Daniel Watford
>Assignee: Daniel Watford
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> As part of refactoring MacroFormRenderer (OFBIZ-11456), the 
> renderDateTimeField method should be refactored to create 
> RenderableFtlElements and pass them to an FtlWriter.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (OFBIZ-7949) E-commerce : FTL formatting

2024-05-10 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-7949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845433#comment-17845433
 ] 

ASF subversion and git services commented on OFBIZ-7949:


Commit c223de1a4dfae4fdd3702d765ebfef9fe887e6b7 in ofbiz-plugins's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=c223de1a4 ]

Fixed: dateType parameter not existing in "renderDateTimeField" Macro 
(OFBIZ-13039)

Previous commit (4de5d7bf7e3f077cc81bd1d62bb1848c83c9392b) was wrong. I put back
dateType="date" parameter when isDateType=true should have been used.
It was put in with OFBIZ-12126 but then not changed in templates plugins

It also fixes commit ba1b753ef6d653e6e7aeeca4add330c627cabf91 of OFBIZ-7949

So this replaces dateType="date" by isDateType=true in "renderDateTimeField"
Macro in:
ProductDetail.ftl
EditShoppingList.ftl
EditTaskAndAssoc.ftl
ListSurveys.ftl


> E-commerce : FTL formatting
> ---
>
> Key: OFBIZ-7949
> URL: https://issues.apache.org/jira/browse/OFBIZ-7949
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ecommerce
>Affects Versions: 18.12.13
>Reporter: Vaibhav Jain
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.14
>
> Attachments: OFBIZ-7949.patch, OFBIZ-7949.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (OFBIZ-12126) Refactor MacroFormRenderer to use RenderableFtlElements for datetime fields

2024-05-10 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-12126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845429#comment-17845429
 ] 

ASF subversion and git services commented on OFBIZ-12126:
-

Commit 7a709d6de39e8fdd6f5c374fecd2fc3945647797 in ofbiz-plugins's branch 
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=7a709d6de ]

Fixed: dateType parameter not existing in "renderDateTimeField" Macro 
(OFBIZ-13039)

Previous commit (4de5d7bf7e3f077cc81bd1d62bb1848c83c9392b) was wrong. I put back
dateType="date" parameter when isDateType=true should have been used.
It was put in with OFBIZ-12126 but then not changed in templates plugins

It also fixes commit ba1b753ef6d653e6e7aeeca4add330c627cabf91 of OFBIZ-7949

So this replaces dateType="date" by isDateType=true in "renderDateTimeField"
Macro in:
ProductDetail.ftl
EditShoppingList.ftl
EditTaskAndAssoc.ftl
ListSurveys.ftl


> Refactor MacroFormRenderer to use RenderableFtlElements for datetime fields
> ---
>
> Key: OFBIZ-12126
> URL: https://issues.apache.org/jira/browse/OFBIZ-12126
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework/widget
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Daniel Watford
>Assignee: Daniel Watford
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> As part of refactoring MacroFormRenderer (OFBIZ-11456), the 
> renderDateTimeField method should be refactored to create 
> RenderableFtlElements and pass them to an FtlWriter.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (OFBIZ-13039) dateType parameter not existing in "renderDateTimeField" Macro

2024-05-10 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-13039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845428#comment-17845428
 ] 

ASF subversion and git services commented on OFBIZ-13039:
-

Commit 7a709d6de39e8fdd6f5c374fecd2fc3945647797 in ofbiz-plugins's branch 
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=7a709d6de ]

Fixed: dateType parameter not existing in "renderDateTimeField" Macro 
(OFBIZ-13039)

Previous commit (4de5d7bf7e3f077cc81bd1d62bb1848c83c9392b) was wrong. I put back
dateType="date" parameter when isDateType=true should have been used.
It was put in with OFBIZ-12126 but then not changed in templates plugins

It also fixes commit ba1b753ef6d653e6e7aeeca4add330c627cabf91 of OFBIZ-7949

So this replaces dateType="date" by isDateType=true in "renderDateTimeField"
Macro in:
ProductDetail.ftl
EditShoppingList.ftl
EditTaskAndAssoc.ftl
ListSurveys.ftl


> dateType parameter not existing in "renderDateTimeField" Macro 
> ---
>
> Key: OFBIZ-13039
> URL: https://issues.apache.org/jira/browse/OFBIZ-13039
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: 18.12.13
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.13
>
>
> freemarker.core._MiscTemplateException: Macro "renderDateTimeField" has no 
> parameter with name "dateType". Valid parameter names are: name, className, 
> timeDropdownParamName, defaultDateTimeString, localizedIconTitle, 
> timeHourName, timeMinutesName, ampmName, compositeType, alert, isTimeType, 
> isDateType, amSelected, pmSelected, timeDropdown, classString, isTwelveHour, 
> hour1, hour2, minutes, shortDateInput, title, value, size, maxlength, id, 
> formName, mask, event, action, step, timeValues, tabindex, disabled, 
> isXMLHttpRequest
> 
> FTL stack trace ("~" means nesting-related):
>   - Failed at: @htmlTemplate.renderDateTimeField eve...  [in template 
> "component://ecommerce/template/catalog/ProductDetail.ftl" at line 726, 
> column 17]
> 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (OFBIZ-12126) Refactor MacroFormRenderer to use RenderableFtlElements for datetime fields

2024-05-10 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-12126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845425#comment-17845425
 ] 

ASF subversion and git services commented on OFBIZ-12126:
-

Commit ff16d94669f6f6a3cc5f41df24bc5227ddf82bbe in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=ff16d94669 ]

Fixed: dateType parameter not existing in "renderDateTimeField" Macro 
(OFBIZ-13039)

This replaces dateType="date" by isDateType=true in "renderDateTimeField"
Macro in CommonMacros.ftl

isDateType=true was put in with OFBIZ-12126 but then not changed in this 
template


> Refactor MacroFormRenderer to use RenderableFtlElements for datetime fields
> ---
>
> Key: OFBIZ-12126
> URL: https://issues.apache.org/jira/browse/OFBIZ-12126
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework/widget
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Daniel Watford
>Assignee: Daniel Watford
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> As part of refactoring MacroFormRenderer (OFBIZ-11456), the 
> renderDateTimeField method should be refactored to create 
> RenderableFtlElements and pass them to an FtlWriter.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (OFBIZ-13039) dateType parameter not existing in "renderDateTimeField" Macro

2024-05-10 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-13039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845424#comment-17845424
 ] 

ASF subversion and git services commented on OFBIZ-13039:
-

Commit ff16d94669f6f6a3cc5f41df24bc5227ddf82bbe in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=ff16d94669 ]

Fixed: dateType parameter not existing in "renderDateTimeField" Macro 
(OFBIZ-13039)

This replaces dateType="date" by isDateType=true in "renderDateTimeField"
Macro in CommonMacros.ftl

isDateType=true was put in with OFBIZ-12126 but then not changed in this 
template


> dateType parameter not existing in "renderDateTimeField" Macro 
> ---
>
> Key: OFBIZ-13039
> URL: https://issues.apache.org/jira/browse/OFBIZ-13039
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: 18.12.13
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.13
>
>
> freemarker.core._MiscTemplateException: Macro "renderDateTimeField" has no 
> parameter with name "dateType". Valid parameter names are: name, className, 
> timeDropdownParamName, defaultDateTimeString, localizedIconTitle, 
> timeHourName, timeMinutesName, ampmName, compositeType, alert, isTimeType, 
> isDateType, amSelected, pmSelected, timeDropdown, classString, isTwelveHour, 
> hour1, hour2, minutes, shortDateInput, title, value, size, maxlength, id, 
> formName, mask, event, action, step, timeValues, tabindex, disabled, 
> isXMLHttpRequest
> 
> FTL stack trace ("~" means nesting-related):
>   - Failed at: @htmlTemplate.renderDateTimeField eve...  [in template 
> "component://ecommerce/template/catalog/ProductDetail.ftl" at line 726, 
> column 17]
> 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (OFBIZ-12126) Refactor MacroFormRenderer to use RenderableFtlElements for datetime fields

2024-05-10 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-12126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845423#comment-17845423
 ] 

ASF subversion and git services commented on OFBIZ-12126:
-

Commit 35b4b89f285d92445d6ade017c72b20fa4aa0a89 in ofbiz-framework's branch 
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=35b4b89f28 ]

Fixed: dateType parameter not existing in "renderDateTimeField" Macro 
(OFBIZ-13039)

This replaces dateType="date" by isDateType=true in "renderDateTimeField"
Macro in CommonMacros.ftl

isDateType=true was put in with OFBIZ-12126 but then not changed in this 
template

Conflicts handled by hand


> Refactor MacroFormRenderer to use RenderableFtlElements for datetime fields
> ---
>
> Key: OFBIZ-12126
> URL: https://issues.apache.org/jira/browse/OFBIZ-12126
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework/widget
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Daniel Watford
>Assignee: Daniel Watford
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> As part of refactoring MacroFormRenderer (OFBIZ-11456), the 
> renderDateTimeField method should be refactored to create 
> RenderableFtlElements and pass them to an FtlWriter.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (OFBIZ-13039) dateType parameter not existing in "renderDateTimeField" Macro

2024-05-10 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-13039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845422#comment-17845422
 ] 

ASF subversion and git services commented on OFBIZ-13039:
-

Commit 35b4b89f285d92445d6ade017c72b20fa4aa0a89 in ofbiz-framework's branch 
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=35b4b89f28 ]

Fixed: dateType parameter not existing in "renderDateTimeField" Macro 
(OFBIZ-13039)

This replaces dateType="date" by isDateType=true in "renderDateTimeField"
Macro in CommonMacros.ftl

isDateType=true was put in with OFBIZ-12126 but then not changed in this 
template

Conflicts handled by hand


> dateType parameter not existing in "renderDateTimeField" Macro 
> ---
>
> Key: OFBIZ-13039
> URL: https://issues.apache.org/jira/browse/OFBIZ-13039
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: 18.12.13
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.13
>
>
> freemarker.core._MiscTemplateException: Macro "renderDateTimeField" has no 
> parameter with name "dateType". Valid parameter names are: name, className, 
> timeDropdownParamName, defaultDateTimeString, localizedIconTitle, 
> timeHourName, timeMinutesName, ampmName, compositeType, alert, isTimeType, 
> isDateType, amSelected, pmSelected, timeDropdown, classString, isTwelveHour, 
> hour1, hour2, minutes, shortDateInput, title, value, size, maxlength, id, 
> formName, mask, event, action, step, timeValues, tabindex, disabled, 
> isXMLHttpRequest
> 
> FTL stack trace ("~" means nesting-related):
>   - Failed at: @htmlTemplate.renderDateTimeField eve...  [in template 
> "component://ecommerce/template/catalog/ProductDetail.ftl" at line 726, 
> column 17]
> 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (OFBIZ-13086) Convert SampleCommissionServices.xml from mini-lang to Groovy

2024-05-10 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-13086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845329#comment-17845329
 ] 

ASF subversion and git services commented on OFBIZ-13086:
-

Commit 86f89cdd855d45248493d1397ce7dcee232ef6da in ofbiz-framework's branch 
refs/heads/trunk from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=86f89cdd85 ]

Improved: Convert SampleCommissionServices.xml from mini-lang to Groovy 
(OFBIZ-13086)

Convert the service sampleInvoiceAffiliateCommission from minilang to groovy.

As is a sample service for example, I moved it to a dedicate file definition


> Convert SampleCommissionServices.xml from mini-lang to Groovy
> -
>
> Key: OFBIZ-13086
> URL: https://issues.apache.org/jira/browse/OFBIZ-13086
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Trivial
>  Labels: groovy, migration, mini-lang
>
> Convert the service sampleInvoiceAffiliateCommission, move it on dedicate 
> definition service file



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (OFBIZ-13076) PartyTypeAttr correction

2024-05-10 Thread Sebastian Tschikin (Jira) 


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sebastian Tschikin closed OFBIZ-13076.
--
Resolution: Not A Problem

> PartyTypeAttr correction
> 
>
> Key: OFBIZ-13076
> URL: https://issues.apache.org/jira/browse/OFBIZ-13076
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Sebastian Tschikin
>Assignee: Sebastian Tschikin
>Priority: Minor
>
> Correction of the PartyTypeAttr entity.
> At the moment there is no attrValue and attrDescription field in the entity. 
> I am going to provide a pull request for a fix.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (OFBIZ-13076) PartyTypeAttr correction

2024-05-10 Thread Sebastian Tschikin (Jira) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-13076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845324#comment-17845324
 ] 

Sebastian Tschikin commented on OFBIZ-13076:


|After re-evaluating the entire pull request, it looks like I have confused 
TypeAttr entities with Attribute entities. Attribute entities need a AttrValue, 
but TypeAttr do not.
I found out in Jira OFBIZ-294 that TypeAttr serve as an extension to Type 
entities and therefore PartyTypeAttr was defined correctly and does not need 
any fixing...|

> PartyTypeAttr correction
> 
>
> Key: OFBIZ-13076
> URL: https://issues.apache.org/jira/browse/OFBIZ-13076
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Sebastian Tschikin
>Assignee: Sebastian Tschikin
>Priority: Minor
>
> Correction of the PartyTypeAttr entity.
> At the moment there is no attrValue and attrDescription field in the entity. 
> I am going to provide a pull request for a fix.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] Fixed: PartyTypeAttr correction (OFBIZ-13076) [ofbiz-framework]

2024-05-10 Thread via GitHub 


stschikin closed pull request #793: Fixed: PartyTypeAttr correction 
(OFBIZ-13076)
URL: https://github.com/apache/ofbiz-framework/pull/793


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Fixed: PartyTypeAttr correction (OFBIZ-13076) [ofbiz-framework]

2024-05-10 Thread via GitHub 


JacquesLeRoux commented on PR #793:
URL: https://github.com/apache/ofbiz-framework/pull/793#issuecomment-2104502150

   Thanks for the clarification @stschikin 
   
   Please close your PR, TIA


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Closed] (OFBIZ-13086) Convert SampleCommissionServices.xml from mini-lang to Groovy

2024-05-10 Thread Nicolas Malin (Jira) 


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin closed OFBIZ-13086.
-
Resolution: Done

> Convert SampleCommissionServices.xml from mini-lang to Groovy
> -
>
> Key: OFBIZ-13086
> URL: https://issues.apache.org/jira/browse/OFBIZ-13086
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Trivial
>  Labels: groovy, migration, mini-lang
>
> Convert the service sampleInvoiceAffiliateCommission, move it on dedicate 
> definition service file



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] Fixed: PartyTypeAttr correction (OFBIZ-13076) [ofbiz-framework]

2024-05-10 Thread via GitHub 


stschikin commented on PR #793:
URL: https://github.com/apache/ofbiz-framework/pull/793#issuecomment-2104298510

   After re-evaluating the entire pull request, it looks like I have confused 
TypeAttr entities with Attribute entities. Attribute entities need a AttrValue, 
but TypeAttr do not. 
   
   I found out in Jira OFBIZ-294 that TypeAttr serve as an extension to Type 
entities and therefore PartyTypeAttr was defined correctly and does not need 
any fixing...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Improved: Ecommerce - parameterized menu location (OFBIZ-13042) [ofbiz-plugins]

2024-05-10 Thread via GitHub 


sonarcloud[bot] commented on PR #115:
URL: https://github.com/apache/ofbiz-plugins/pull/115#issuecomment-2104126667

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-plugins=115)
 **Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=115=false=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=115=new_accepted_issues=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=115=false=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png
 '') No data about Coverage  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=115=new_duplicated_lines_density=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-plugins=115)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (OFBIZ-13053) Manufacturing-Main page

2024-05-10 Thread Pierre Smits (Jira) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-13053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845230#comment-17845230
 ] 

Pierre Smits commented on OFBIZ-13053:
--

Hi [~jleroux] <

As with the PR re OFBIZ-13054, I found a trailing space one of the changes. I 
have corrected this.

> Manufacturing-Main page
> ---
>
> Key: OFBIZ-13053
> URL: https://issues.apache.org/jira/browse/OFBIZ-13053
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Pierre Smits
>Priority: Major
> Attachments: Screenshot MFG new main.png
>
>
> Currently the 'main' view-map points to the 'FindProductionRun' screen.
> In order to improve the user experience the main request-map and view-map 
> should show what is most pressing in manufacturing to address: the production 
> runs in progress. See attached image



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] Improved: Manufacturing-Main page (OFBIZ-13053) [ofbiz-framework]

2024-05-10 Thread via GitHub 


sonarcloud[bot] commented on PR #784:
URL: https://github.com/apache/ofbiz-framework/pull/784#issuecomment-2103979123

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=784)
 **Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=784=false=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=784=new_accepted_issues=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=784=false=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png
 '') No data about Coverage  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=784=new_duplicated_lines_density=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=784)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Improved: Marketing-Main page (OFBIZ-13054) [ofbiz-framework]

2024-05-10 Thread via GitHub 


sonarcloud[bot] commented on PR #785:
URL: https://github.com/apache/ofbiz-framework/pull/785#issuecomment-2103975317

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=785)
 **Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=785=false=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=785=new_accepted_issues=list)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=785=false=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png
 '') No data about Coverage  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=785=new_duplicated_lines_density=list)
  
 
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=785)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Improved: Marketing-Main page (OFBIZ-13054) [ofbiz-framework]

2024-05-10 Thread via GitHub 


PierreSmits commented on PR #785:
URL: https://github.com/apache/ofbiz-framework/pull/785#issuecomment-2103974953

   Hi @JacquesLeRoux ,
   
   I have updated the pull request.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org