[jira] [Commented] (OFBIZ-7949) E-commerce : FTL formatting

2024-05-07 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844242#comment-17844242
 ] 

ASF subversion and git services commented on OFBIZ-7949:


Commit ba1b753ef6d653e6e7aeeca4add330c627cabf91 in ofbiz-plugins's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=ba1b753ef ]

Fixed: E-commerce : FTL formatting (OFBIZ-7949)

Fixes a missing dateType found in stable demo error.log


> E-commerce : FTL formatting
> ---
>
> Key: OFBIZ-7949
> URL: https://issues.apache.org/jira/browse/OFBIZ-7949
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ecommerce
>Reporter: Vaibhav Jain
>Assignee: Vaibhav Jain
>Priority: Major
> Attachments: OFBIZ-7949.patch, OFBIZ-7949.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-7949) E-commerce : FTL formatting

2024-05-07 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844241#comment-17844241
 ] 

ASF subversion and git services commented on OFBIZ-7949:


Commit 2abe8cab363aa09b4ec13ab8f77ad24df119995b in ofbiz-plugins's branch 
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=2abe8cab3 ]

Fixed: E-commerce : FTL formatting (OFBIZ-7949)

Fixes a missing dateType found in stable demo error.log


> E-commerce : FTL formatting
> ---
>
> Key: OFBIZ-7949
> URL: https://issues.apache.org/jira/browse/OFBIZ-7949
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ecommerce
>Reporter: Vaibhav Jain
>Assignee: Vaibhav Jain
>Priority: Major
> Attachments: OFBIZ-7949.patch, OFBIZ-7949.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13083) Find Record buttons not working in Entity Data Maintenance

2024-05-06 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843747#comment-17843747
 ] 

ASF subversion and git services commented on OFBIZ-13083:
-

Commit fd97e48434b4696d3122f54a976cc038b071c6b1 in ofbiz-framework's branch 
refs/heads/trunk from Sebastian Tschikin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=fd97e48434 ]

Fixed: Find Record buttons not working in EDM (OFBIZ-13083) (#796)

Fixes Find Record Buttons A - Z in Entity Data Maintenance (EDM)

> Find Record buttons not working in Entity Data Maintenance
> --
>
> Key: OFBIZ-13083
> URL: https://issues.apache.org/jira/browse/OFBIZ-13083
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Sebastian Tschikin
>Assignee: Sebastian Tschikin
>Priority: Minor
>
> The Find Record buttons A - Z to jump to specific entities are not working 
> right now.
> I am going to provide a pull request for a fix.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13082) Convert TaxAuthority services mini-lang to groovyDSL

2024-05-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843242#comment-17843242
 ] 

ASF subversion and git services commented on OFBIZ-13082:
-

Commit fd554682d8420bee7c127d09d6a73579123e2e53 in ofbiz-framework's branch 
refs/heads/trunk from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=fd554682d8 ]

Improved: Convert TaxAuthority services mini-lang to groovyDSL (OFBIZ-13082)

Convert the following services:
   * createPartyTaxAuthInfo
   * updatePartyTaxAuthInfo
   * createCustomerTaxAuthInfo


> Convert TaxAuthority services mini-lang to groovyDSL
> 
>
> Key: OFBIZ-13082
> URL: https://issues.apache.org/jira/browse/OFBIZ-13082
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Reporter: Nicolas Malin
>Priority: Minor
>
> Convert the following services :
> * createPartyTaxAuthInfo
> * updatePartyTaxAuthInfo
> * createCustomerTaxAuthInfo



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13079) Error in ProductServicesScript.groovy: Cannot execute null+1

2024-05-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843218#comment-17843218
 ] 

ASF subversion and git services commented on OFBIZ-13079:
-

Commit bb3a69ee1a75befc28a6a46ca2568e7a75b46184 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=bb3a69ee1a ]

Fixed: Error in ProductServicesScript.groovy]:(Cannot execute null+1) 
(OFBIZ-13079)

Fixes an error in countProductView service.

There is still an error reproducible in 18.12 (summarised)

Error running Groovy method ProductServicesScript::countProductView :
org.apache.ofbiz.entity.GenericEntityException: Error while inserting:
[GenericEntity:ProductCalculatedInfo](INSERT on table 'PRODUCT_CALCULATED_INFO'
caused a violation of foreign key constraint 'PRODCI_PROD' for key (GS-1000).
The statement has been rolled back.

So another Jira is needed.


> Error in ProductServicesScript.groovy:  Cannot execute null+1
> -
>
> Key: OFBIZ-13079
> URL: https://issues.apache.org/jira/browse/OFBIZ-13079
> Project: OFBiz
>  Issue Type: Bug
>  Components: product/catalog
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> Easy fix:
> 2024-05-02 13:36:26,779 |OFBiz-JobQueue-1     |GenericServiceJob             
> |E| Async-Service failed.
> org.apache.ofbiz.service.GenericServiceException: Error running Groovy method 
> [countProductView] in Groovy file 
> [component://product/src/main/groovy/org/apache/ofbiz/product/product/product/ProductServicesScript.groovy]:
>   (Cannot execute null+1)
>     at 
> org.apache.ofbiz.service.engine.GroovyEngine.runSync(GroovyEngine.java:138) 
> ~[ofbiz.jar:?]
>     at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:429)
>  ~[ofbiz.jar:?]
>     at 
> org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:244)
>  ~[ofbiz.jar:?]
>     at 
> org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:93)
>  ~[ofbiz.jar:?]
>     at 
> org.apache.ofbiz.service.job.GenericServiceJob.exec(GenericServiceJob.java:77)
>  [ofbiz.jar:?]
>     at org.apache.ofbiz.service.job.AbstractJob.run(AbstractJob.java:106) 
> [ofbiz.jar:?]
>     at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
>  [?:?]
>     at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
>  [?:?]
>     at java.lang.Thread.run(Thread.java:840) [?:?]
> Caused by: java.lang.NullPointerException: Cannot execute null+1
>     at org.codehaus.groovy.runtime.NullObject.plus(NullObject.java:159) 
> ~[groovy-3.0.21.jar:3.0.21]
>     at org.codehaus.groovy.runtime.NullObject$plus$0.call(Unknown Source) 
> ~[?:?]
>     at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
>  ~[groovy-3.0.21.jar:3.0.21]
>     at 
> org.codehaus.groovy.runtime.callsite.NullCallSite.call(NullCallSite.java:34) 
> ~[groovy-3.0.21.jar:3.0.21]
>     at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
>  ~[groovy-3.0.21.jar:3.0.21]
>     at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125)
>  ~[groovy-3.0.21.jar:3.0.21]
>     at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:139)
>  ~[groovy-3.0.21.jar:3.0.21]
>     at 
> org.apache.ofbiz.product.product.product.ProductServicesScript.countProductView(ProductServicesScript.groovy:373)
>  ~[ofbiz.jar:?]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-05-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843194#comment-17843194
 ] 

ASF subversion and git services commented on OFBIZ-13035:
-

Commit e8b6d41e29ec2052da426c786912deffaca06691 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=e8b6d41e29 ]

Fixed: Fix cross-app menu location issues (OFBIZ-13035)

Fixes mainMenuLocation missing in AR and AP web.xml files hence error
java.lang.RuntimeException: Error rendering included menu named [MainActionMenu]
at location []: java.lang.IllegalArgumentException: Could not find menu file
in location []


> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13078) Convert ProjectServices.xml mini-lang to groovyDSL

2024-05-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843165#comment-17843165
 ] 

ASF subversion and git services commented on OFBIZ-13078:
-

Commit 46fcbd31614be4b99106452c8e0118d274572bd4 in ofbiz-plugins's branch 
refs/heads/trunk from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=46fcbd316 ]

Improved: Convert ProjectServices.xml mini-lang to groovyDSL (OFBIZ-13078)

Convert following services :
 * createTimeEntryInTimesheet
 * updateTimeEntryByWorkEffort
 * getProject
 * createProject
 * updateProject
 * updateProjectRole
 * createProjectTask
 * copyProject
 * copyProjectToTemplate
 * scheduleProject
 * getProjectPhaseList
 * getProjectTaskList
 * getProjectTask
 * getProjectsByParties
 * getTasksByParties
 * updateTaskAndRelatedInfo
 * updateTaskAssigment
 * addProjectTimeToNewInvoice
 * addProjectTimeToInvoice
 * addValidationPartiesToTask


> Convert ProjectServices.xml mini-lang to groovyDSL
> --
>
> Key: OFBIZ-13078
> URL: https://issues.apache.org/jira/browse/OFBIZ-13078
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: projectmgr
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
>  Labels: mini-lang
>
> Convert the following services :
> * createTimeEntryInTimesheet
> * updateTimeEntryByWorkEffort
> * getProject
> * createProject
> * updateProject
> * updateProjectRole
> * createProjectTask
> * copyProject
> * copyProjectToTemplate
> * scheduleProject
> * getProjectPhaseList
> * getProjectTaskList
> * getProjectTask
> * getProjectsByParties
> * getTasksByParties
> * updateTaskAndRelatedInfo
> * updateTaskAssigment
> * addProjectTimeToNewInvoice
> * addProjectTimeToInvoice
> * addValidationPartiesToTask



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13061) Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors

2024-05-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843162#comment-17843162
 ] 

ASF subversion and git services commented on OFBIZ-13061:
-

Commit 04f41f90322c5972317e4760cb3cdb3e45c9d8f3 in ofbiz-framework's branch 
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=04f41f9032 ]

Fixed: Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser 
errors (OFBIZ-13061)

Fixes the name of the invoked method for the SetTimeZoneFromBrowser service to
setTimeZoneFromBrowser instead of SetTimeZoneFromBrowser

It has been automatically changed because of the use of Map instead of def
in commmit ea54ceba47cceaec95b720995c269f2d5827125c

Few trailing blanks automatically removed also


> Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors
> 
>
> Key: OFBIZ-13061
> URL: https://issues.apache.org/jira/browse/OFBIZ-13061
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/common
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch, 18.12.14
>
>
> Currently the demo logs, and I guess the users production logs, are cluttered 
> up with very common and unique SetTimeZoneFromBrowser errors.
> We can easily prevent that by not returning an error from 
> SetTimeZoneFromBrowser.groovy, and so the never ending 
> bq. < message: User authorization is required for this service: 
> SetTimeZoneFromBrowser>>
> from RequestHandler.java



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13061) Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors

2024-05-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843016#comment-17843016
 ] 

ASF subversion and git services commented on OFBIZ-13061:
-

Commit 9443359e73a97bd2562265658332e1a097e805d9 in ofbiz-framework's branch 
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=9443359e73 ]

Fixed: Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser 
errors (OFBIZ-13061)

Fixes a bug put in with last commit.
-String uri = requestMap.getUri();
+String uri = requestMap.uri;

Also automatically (Eclipse) removes trailing blanks


> Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors
> 
>
> Key: OFBIZ-13061
> URL: https://issues.apache.org/jira/browse/OFBIZ-13061
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/common
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> Currently the demo logs, and I guess the users production logs, are cluttered 
> up with very common and unique SetTimeZoneFromBrowser errors.
> We can easily prevent that by not returning an error from 
> SetTimeZoneFromBrowser.groovy, and so the never ending 
> bq. < message: User authorization is required for this service: 
> SetTimeZoneFromBrowser>>
> from RequestHandler.java



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13061) Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors

2024-05-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842990#comment-17842990
 ] 

ASF subversion and git services commented on OFBIZ-13061:
-

Commit 486f2727316f659a4a659b97a3d323655f811685 in ofbiz-framework's branch 
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=486f272731 ]

Fixed: Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser 
errors (OFBIZ-13061)

The previous commit was not enough as I feared. It still shows in trunk demo
error.log today. So here comes the ugly but sure fix.

Conflicts handled by hand


> Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors
> 
>
> Key: OFBIZ-13061
> URL: https://issues.apache.org/jira/browse/OFBIZ-13061
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/common
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> Currently the demo logs, and I guess the users production logs, are cluttered 
> up with very common and unique SetTimeZoneFromBrowser errors.
> We can easily prevent that by not returning an error from 
> SetTimeZoneFromBrowser.groovy, and so the never ending 
> bq. < message: User authorization is required for this service: 
> SetTimeZoneFromBrowser>>
> from RequestHandler.java



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13061) Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors

2024-05-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842991#comment-17842991
 ] 

ASF subversion and git services commented on OFBIZ-13061:
-

Commit ea54ceba47cceaec95b720995c269f2d5827125c in ofbiz-framework's branch 
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=ea54ceba47 ]

Fixed: Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser 
errors (OFBIZ-13061)

Fixes this error found in trunk demo log.
SetTimeZoneFromBrowser.groovy]: (Cannot get property 'userLoginId' on null 
object)
It happens, at least with webpos/control/SetTimeZoneFromBrowser
It's just to prevents cluttering the logs.

Conflicts handled by hand


> Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors
> 
>
> Key: OFBIZ-13061
> URL: https://issues.apache.org/jira/browse/OFBIZ-13061
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/common
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> Currently the demo logs, and I guess the users production logs, are cluttered 
> up with very common and unique SetTimeZoneFromBrowser errors.
> We can easily prevent that by not returning an error from 
> SetTimeZoneFromBrowser.groovy, and so the never ending 
> bq. < message: User authorization is required for this service: 
> SetTimeZoneFromBrowser>>
> from RequestHandler.java



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13061) Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors

2024-05-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842989#comment-17842989
 ] 

ASF subversion and git services commented on OFBIZ-13061:
-

Commit 183a9a222c694c6dff53e43c6194641744d160bb in ofbiz-framework's branch 
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=183a9a222c ]

Fixed: Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser 
errors (OFBIZ-13061)

Currently the demo logs, and I guess users production logs, are cluttered up
with very common and unique SetTimeZoneFromBrowser error.
We can easily prevent that by not returning an error from
SetTimeZoneFromBrowser.groovy, and so the never ending
<>
from RequestHandler.java


> Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors
> 
>
> Key: OFBIZ-13061
> URL: https://issues.apache.org/jira/browse/OFBIZ-13061
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/common
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> Currently the demo logs, and I guess the users production logs, are cluttered 
> up with very common and unique SetTimeZoneFromBrowser errors.
> We can easily prevent that by not returning an error from 
> SetTimeZoneFromBrowser.groovy, and so the never ending 
> bq. < message: User authorization is required for this service: 
> SetTimeZoneFromBrowser>>
> from RequestHandler.java



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13061) Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors

2024-05-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842926#comment-17842926
 ] 

ASF subversion and git services commented on OFBIZ-13061:
-

Commit 3d0a1331e8ae75ae42f154df28c249721d481de3 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=3d0a1331e8 ]

Fixed: Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser 
errors (OFBIZ-13061)

Fixes this error found in trunk demo log.
SetTimeZoneFromBrowser.groovy]: (Cannot get property 'userLoginId' on null 
object)
It happens, at least with webpos/control/SetTimeZoneFromBrowser
It's just to prevents cluttering the logs.


> Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors
> 
>
> Key: OFBIZ-13061
> URL: https://issues.apache.org/jira/browse/OFBIZ-13061
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/common
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> Currently the demo logs, and I guess the users production logs, are cluttered 
> up with very common and unique SetTimeZoneFromBrowser errors.
> We can easily prevent that by not returning an error from 
> SetTimeZoneFromBrowser.groovy, and so the never ending 
> bq. < message: User authorization is required for this service: 
> SetTimeZoneFromBrowser>>
> from RequestHandler.java



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13072) Issue when caching a query with a selectField

2024-05-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842866#comment-17842866
 ] 

ASF subversion and git services commented on OFBIZ-13072:
-

Commit 0748e67e5eee689425bcb08f73024d659b7007a2 in ofbiz-framework's branch 
refs/heads/trunk from Mekika Leila
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=0748e67e5e ]

Fixed: Issue when caching a query with a selectField (OFBIZ-13072) (#787)

When a query with a field selection and a cache() option is done, the
result is put in cache with the incomplete genericValue (I mean without
all the fields).

Then when an other query with the same condition and cache option is
done, even whitout the field selection, the result returned is the
incomplete version of the GenericValue that has been stored in cache.

This prevent from adding in cache an incomplete genericValue and filter
the cached value when necessary


> Issue when caching a query with a selectField
> -
>
> Key: OFBIZ-13072
> URL: https://issues.apache.org/jira/browse/OFBIZ-13072
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Mekika Leila
>Priority: Minor
>
> When a query with a field selection and a cache() option is done, the result 
> is put in cache with the incomplete genericValue (I mean without all the 
> fields).
> Then when an other query with the same condition and cache option is done, 
> even whitout the field selection, the result returned is the incomplete 
> version of the GenericValue that has been stored in cache.
> The code in the PR prevent from adding in cache an incomplete genericValue 
> and filter the cached value when necessary
> *To test:*
> testCache has been added to entity-query-tests test case. It can be launched 
> with 
> ./gradlew 'ofbiz -t component=entity'
> or
> ./gradlew 'ofbiz -t component=entity -t suitename=entitytests -t 
> case=entity-query-tests'



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13071) Could not find PortalPage with portalPageId []

2024-05-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842652#comment-17842652
 ] 

ASF subversion and git services commented on OFBIZ-13071:
-

Commit 9ec6a618bc4dfac5fc2b7031d6c7805a4900b775 in ofbiz-framework's branch 
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=9ec6a618bc ]

Fixed: Could not find PortalPage with portalPageId []  (OFBIZ-13071)

Fixes a bug put in during backporting. MODULE is not used in this class module 
is


> Could not find PortalPage with portalPageId [] 
> ---
>
> Key: OFBIZ-13071
> URL: https://issues.apache.org/jira/browse/OFBIZ-13071
> Project: OFBiz
>  Issue Type: Bug
>  Components: sfa
>Affects Versions: 18.12.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.13
>
>
> This is a weird behaviour. Yet it's not really a bug but something that 
> spider bots do. They get to ListTimezones while not being signed in (hard for 
> spider bot). Here are 2 cases:
> {noformat}
> 18.224.149.242 - - [26/Apr/2024:03:20:05 +] "GET 
> /sfa/control/setSessionTimeZone?tzId=Australia/Melbourne HTTP/1.1" 200 42716 
> "-" "Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; 
> ClaudeBot/1.0; +claude...@anthropic.com)"
> 2024-04-26 03:20:05,254 |-0.0.0.0-8009-exec-4 |ModelScreenWidget 
> |E| Could not find PortalPage with portalPageId [] 
> 3.144.172.115 - - [26/Apr/2024:03:32:22 +] "GET 
> /sfa/control/setSessionTimeZone?tzId=Asia/Kuwait HTTP/1.1" 200 42716 "-" 
> "Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; 
> ClaudeBot/1.0; +claude...@anthropic.com)"
> 2024-04-26 03:32:22,395 |-0.0.0.0-8009-exec-7 |ModelScreenWidget 
> |E| Could not find PortalPage with portalPageId [] 
> {noformat}
> It happens only for SFA. [All the others| https://s.apache.org/gwyw2 ] are 
> not concerned
> Why only SFA is concerned is unclear but not really a problem. Because once 
> signed in the problem dissapears. The only problem is that if a spider bot 
> gets to your production server it will clutter the log. There is 636 possible 
> hours...
> Now that I know the reason, I'll try to find a workaround.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13061) Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors

2024-05-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842646#comment-17842646
 ] 

ASF subversion and git services commented on OFBIZ-13061:
-

Commit 9869bed35a9851d5574fd7df395f56c36713e84b in ofbiz-framework's branch 
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=9869bed35a ]

Revert "Fixed: Prevents to uselessly clutter the logs up with 
SetTimeZoneFromBrowser errors (OFBIZ-13061)"

This reverts commit 135d137a2483f94fe8e95fcdb39a18f1c0b95963.
This change should not have been backported


> Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors
> 
>
> Key: OFBIZ-13061
> URL: https://issues.apache.org/jira/browse/OFBIZ-13061
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/common
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> Currently the demo logs, and I guess the users production logs, are cluttered 
> up with very common and unique SetTimeZoneFromBrowser errors.
> We can easily prevent that by not returning an error from 
> SetTimeZoneFromBrowser.groovy, and so the never ending 
> bq. < message: User authorization is required for this service: 
> SetTimeZoneFromBrowser>>
> from RequestHandler.java



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-9804) Link in verification email for Newsletter gives security error

2024-05-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842644#comment-17842644
 ] 

ASF subversion and git services commented on OFBIZ-9804:


Commit 48534da103151f9858120e1438743bd5ed8516d1 in ofbiz-plugins's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=48534da10 ]

Fixed: Link in verification email for Newsletter gives security error 
(OFBIZ-9804)

It's a bit abused to reuse this Jira issue but as it's a really trivial fix...


> Link in verification email for Newsletter gives security error
> --
>
> Key: OFBIZ-9804
> URL: https://issues.apache.org/jira/browse/OFBIZ-9804
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ecommerce
>Affects Versions: Release Branch 16.11, Trunk
>Reporter: Aditya Sharma
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01, 18.12.01
>
> Attachments: screenshot-1.png
>
>
> Steps to generate:
> 1. Go to Ecommerce store https://localhost:8443/ecommerce/control/main
> 2. In "Sign Up For Contact List" panel from the left menu, select Newsletter, 
> provide email and click on subscribe button.(Here you should have email 
> configuration to receive email)
> 3.  Click on the verification link in the email.
> It gives following error message
> {quote}The Following Errors Occurred:
> Error calling event: org.apache.ofbiz.webapp.event.EventHandlerException: 
> Found URL parameter [contactListId] passed to secure (https) request-map with 
> uri [updateContactListPartyNoUserLogin] with an event that calls service 
> [updateContactListPartyNoUserLogin]; this is not allowed for security 
> reasons! The data should be encrypted by making it part of the request body 
> (a form field) instead of the request URL. Moreover it would be kind if you 
> could create a Jira sub-task of 
> https://issues.apache.org/jira/browse/OFBIZ-2330 (check before if a sub-task 
> for this error does not exist). If you are not sure how to create a Jira 
> issue please have a look before at 
> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices
>  Thank you in advance for your help.{quote}
> Try with the trunk link:
> https://demo-trunk.ofbiz.apache.org/ecommerce/control/updateContactListPartyNoUserLogin?contactListId=9000&partyId=_NA_&fromDate=2017-10-04%2010:48:46.531&statusId=CLPT_ACCEPTED&optInVerifyCode=9084207171&baseLocation=/ecommerce&preferredContactMechId=10010
> Stable 16 link:
> https://demo-stable.ofbiz.apache.org/ecommerce/control/updateContactListPartyNoUserLogin?contactListId=9000&partyId=_NA_&fromDate=2017-10-04%2010:48:46.531&statusId=CLPT_ACCEPTED&optInVerifyCode=9084207171&baseLocation=/ecommerce&preferredContactMechId=10010



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-9804) Link in verification email for Newsletter gives security error

2024-05-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842643#comment-17842643
 ] 

ASF subversion and git services commented on OFBIZ-9804:


Commit 2b08b865bce25cde5d55d1762d89c96bcaa92e95 in ofbiz-plugins's branch 
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=2b08b865b ]

Fixed: Link in verification email for Newsletter gives security error 
(OFBIZ-9804)

It's a bit abused to reuse this Jira issue but as it's a really trivial fix...


> Link in verification email for Newsletter gives security error
> --
>
> Key: OFBIZ-9804
> URL: https://issues.apache.org/jira/browse/OFBIZ-9804
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ecommerce
>Affects Versions: Release Branch 16.11, Trunk
>Reporter: Aditya Sharma
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01, 18.12.01
>
> Attachments: screenshot-1.png
>
>
> Steps to generate:
> 1. Go to Ecommerce store https://localhost:8443/ecommerce/control/main
> 2. In "Sign Up For Contact List" panel from the left menu, select Newsletter, 
> provide email and click on subscribe button.(Here you should have email 
> configuration to receive email)
> 3.  Click on the verification link in the email.
> It gives following error message
> {quote}The Following Errors Occurred:
> Error calling event: org.apache.ofbiz.webapp.event.EventHandlerException: 
> Found URL parameter [contactListId] passed to secure (https) request-map with 
> uri [updateContactListPartyNoUserLogin] with an event that calls service 
> [updateContactListPartyNoUserLogin]; this is not allowed for security 
> reasons! The data should be encrypted by making it part of the request body 
> (a form field) instead of the request URL. Moreover it would be kind if you 
> could create a Jira sub-task of 
> https://issues.apache.org/jira/browse/OFBIZ-2330 (check before if a sub-task 
> for this error does not exist). If you are not sure how to create a Jira 
> issue please have a look before at 
> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices
>  Thank you in advance for your help.{quote}
> Try with the trunk link:
> https://demo-trunk.ofbiz.apache.org/ecommerce/control/updateContactListPartyNoUserLogin?contactListId=9000&partyId=_NA_&fromDate=2017-10-04%2010:48:46.531&statusId=CLPT_ACCEPTED&optInVerifyCode=9084207171&baseLocation=/ecommerce&preferredContactMechId=10010
> Stable 16 link:
> https://demo-stable.ofbiz.apache.org/ecommerce/control/updateContactListPartyNoUserLogin?contactListId=9000&partyId=_NA_&fromDate=2017-10-04%2010:48:46.531&statusId=CLPT_ACCEPTED&optInVerifyCode=9084207171&baseLocation=/ecommerce&preferredContactMechId=10010



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13061) Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors

2024-05-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842637#comment-17842637
 ] 

ASF subversion and git services commented on OFBIZ-13061:
-

Commit 650284168de5976a502fa5e7af8a4685ded50ce9 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=650284168d ]

Fixed: Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser 
errors (OFBIZ-13061)

The previous commits were not enough as I feared. This time we should not see
useless "error" information while running services.


> Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors
> 
>
> Key: OFBIZ-13061
> URL: https://issues.apache.org/jira/browse/OFBIZ-13061
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/common
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> Currently the demo logs, and I guess the users production logs, are cluttered 
> up with very common and unique SetTimeZoneFromBrowser errors.
> We can easily prevent that by not returning an error from 
> SetTimeZoneFromBrowser.groovy, and so the never ending 
> bq. < message: User authorization is required for this service: 
> SetTimeZoneFromBrowser>>
> from RequestHandler.java



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13061) Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors

2024-05-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842636#comment-17842636
 ] 

ASF subversion and git services commented on OFBIZ-13061:
-

Commit 135d137a2483f94fe8e95fcdb39a18f1c0b95963 in ofbiz-framework's branch 
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=135d137a24 ]

Fixed: Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser 
errors (OFBIZ-13061)

The previous commits were not enough as I feared. This time we should not see
useless "error" information while running services.

Conflicts hanled by hands


> Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors
> 
>
> Key: OFBIZ-13061
> URL: https://issues.apache.org/jira/browse/OFBIZ-13061
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/common
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> Currently the demo logs, and I guess the users production logs, are cluttered 
> up with very common and unique SetTimeZoneFromBrowser errors.
> We can easily prevent that by not returning an error from 
> SetTimeZoneFromBrowser.groovy, and so the never ending 
> bq. < message: User authorization is required for this service: 
> SetTimeZoneFromBrowser>>
> from RequestHandler.java



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13071) Could not find PortalPage with portalPageId []

2024-05-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842571#comment-17842571
 ] 

ASF subversion and git services commented on OFBIZ-13071:
-

Commit 4fcccdb8208c9130c07bb16d8f3c63d7c2a6d26e in ofbiz-framework's branch 
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=4fcccdb820 ]

Improved: Could not find PortalPage with portalPageId []  (OFBIZ-13071)

No need to try to render a PortalPage when there is no PortalPage

Conflicts handled by hand in ModelScreenWidget.java


> Could not find PortalPage with portalPageId [] 
> ---
>
> Key: OFBIZ-13071
> URL: https://issues.apache.org/jira/browse/OFBIZ-13071
> Project: OFBiz
>  Issue Type: Bug
>  Components: sfa
>Affects Versions: 18.12.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.13
>
>
> This is a weird behaviour. Yet it's not really a bug but something that 
> spider bots do. They get to ListTimezones while not being signed in (hard for 
> spider bot). Here are 2 cases:
> {noformat}
> 18.224.149.242 - - [26/Apr/2024:03:20:05 +] "GET 
> /sfa/control/setSessionTimeZone?tzId=Australia/Melbourne HTTP/1.1" 200 42716 
> "-" "Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; 
> ClaudeBot/1.0; +claude...@anthropic.com)"
> 2024-04-26 03:20:05,254 |-0.0.0.0-8009-exec-4 |ModelScreenWidget 
> |E| Could not find PortalPage with portalPageId [] 
> 3.144.172.115 - - [26/Apr/2024:03:32:22 +] "GET 
> /sfa/control/setSessionTimeZone?tzId=Asia/Kuwait HTTP/1.1" 200 42716 "-" 
> "Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; 
> ClaudeBot/1.0; +claude...@anthropic.com)"
> 2024-04-26 03:32:22,395 |-0.0.0.0-8009-exec-7 |ModelScreenWidget 
> |E| Could not find PortalPage with portalPageId [] 
> {noformat}
> It happens only for SFA. [All the others| https://s.apache.org/gwyw2 ] are 
> not concerned
> Why only SFA is concerned is unclear but not really a problem. Because once 
> signed in the problem dissapears. The only problem is that if a spider bot 
> gets to your production server it will clutter the log. There is 636 possible 
> hours...
> Now that I know the reason, I'll try to find a workaround.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13071) Could not find PortalPage with portalPageId []

2024-05-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842572#comment-17842572
 ] 

ASF subversion and git services commented on OFBIZ-13071:
-

Commit 03291be883cb72315f1e93384ee4013392bc09c5 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=03291be883 ]

Improved: Could not find PortalPage with portalPageId []  (OFBIZ-13071)

No need to try to render a PortalPage when there is no PortalPage


> Could not find PortalPage with portalPageId [] 
> ---
>
> Key: OFBIZ-13071
> URL: https://issues.apache.org/jira/browse/OFBIZ-13071
> Project: OFBiz
>  Issue Type: Bug
>  Components: sfa
>Affects Versions: 18.12.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.13
>
>
> This is a weird behaviour. Yet it's not really a bug but something that 
> spider bots do. They get to ListTimezones while not being signed in (hard for 
> spider bot). Here are 2 cases:
> {noformat}
> 18.224.149.242 - - [26/Apr/2024:03:20:05 +] "GET 
> /sfa/control/setSessionTimeZone?tzId=Australia/Melbourne HTTP/1.1" 200 42716 
> "-" "Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; 
> ClaudeBot/1.0; +claude...@anthropic.com)"
> 2024-04-26 03:20:05,254 |-0.0.0.0-8009-exec-4 |ModelScreenWidget 
> |E| Could not find PortalPage with portalPageId [] 
> 3.144.172.115 - - [26/Apr/2024:03:32:22 +] "GET 
> /sfa/control/setSessionTimeZone?tzId=Asia/Kuwait HTTP/1.1" 200 42716 "-" 
> "Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; 
> ClaudeBot/1.0; +claude...@anthropic.com)"
> 2024-04-26 03:32:22,395 |-0.0.0.0-8009-exec-7 |ModelScreenWidget 
> |E| Could not find PortalPage with portalPageId [] 
> {noformat}
> It happens only for SFA. [All the others| https://s.apache.org/gwyw2 ] are 
> not concerned
> Why only SFA is concerned is unclear but not really a problem. Because once 
> signed in the problem dissapears. The only problem is that if a spider bot 
> gets to your production server it will clutter the log. There is 636 possible 
> hours...
> Now that I know the reason, I'll try to find a workaround.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13075) ${parameters.SEARCH_STRING} Failed in TagSearch.ftl[at line 20]

2024-04-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842436#comment-17842436
 ] 

ASF subversion and git services commented on OFBIZ-13075:
-

Commit 01a3277d7882e5c4c033ef5048d1bfe0405745b5 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=01a3277d78 ]

Fixed: ${parameters.SEARCH_STRING}  Failed in TagSearch.ftl[at line 20] 
(OFBIZ-13075)

The error appears when no products have been tagged (did not check how the
products are tagged )


> ${parameters.SEARCH_STRING}  Failed in TagSearch.ftl[at line 20]
> 
>
> Key: OFBIZ-13075
> URL: https://issues.apache.org/jira/browse/OFBIZ-13075
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: 18.12.14
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: 18.12.14
>
>
> Here is the error in log:
>  
> 2024-04-30 15:28:23,692 |-0.0.0.0-8009-exec-8 |FreeMarkerWorker              
> |E| null
> freemarker.core.InvalidReferenceException: The following has evaluated to 
> null or missing:
> ==> parameters.SEARCH_STRING  [in template 
> "component://order/template/entry/catalog/TagSearch.ftl" at line 20, column 
> 47]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13075) ${parameters.SEARCH_STRING} Failed in TagSearch.ftl[at line 20]

2024-04-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842435#comment-17842435
 ] 

ASF subversion and git services commented on OFBIZ-13075:
-

Commit 25f5692d10ffc47ad34168708490e651822dda8c in ofbiz-framework's branch 
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=25f5692d10 ]

Fixed: ${parameters.SEARCH_STRING}  Failed in TagSearch.ftl[at line 20] 
(OFBIZ-13075)

The error appears when no products have been tagged (did not check how the
products are tagged )


> ${parameters.SEARCH_STRING}  Failed in TagSearch.ftl[at line 20]
> 
>
> Key: OFBIZ-13075
> URL: https://issues.apache.org/jira/browse/OFBIZ-13075
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: 18.12.14
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: 18.12.14
>
>
> Here is the error in log:
>  
> 2024-04-30 15:28:23,692 |-0.0.0.0-8009-exec-8 |FreeMarkerWorker              
> |E| null
> freemarker.core.InvalidReferenceException: The following has evaluated to 
> null or missing:
> ==> parameters.SEARCH_STRING  [in template 
> "component://order/template/entry/catalog/TagSearch.ftl" at line 20, column 
> 47]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-869) French translation for Accounting module

2024-04-28 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841606#comment-17841606
 ] 

ASF subversion and git services commented on OFBIZ-869:
---

Commit bb325bdd106feb59520f06615b4e43d47ab1f4d8 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=bb325bdd10 ]

Improved: French translation for Accounting module (OFBIZ-869)

Replaces "Montant à enregistrer" by "Solde dû"


> French translation for Accounting module
> 
>
> Key: OFBIZ-869
> URL: https://issues.apache.org/jira/browse/OFBIZ-869
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Eric Jacolin
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Trunk
>
> Attachments: AccountingEntityLabels_fr.properties, 
> AccountingUiLabels_fr.properties
>
>
> French translation for Accounting module



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13073) Use new Tomcat 9 maxDays Access_Log_Valve Attribute

2024-04-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841589#comment-17841589
 ] 

ASF subversion and git services commented on OFBIZ-13073:
-

Commit b6e87fcfb4649b189f960ed7661eb57dedf65a29 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b6e87fcfb4 ]

Improved: Use new Tomcat 9 maxDays Access_Log_Valve Attribute (OFBIZ-13073)

https://tomcat.apache.org/tomcat-9.0-doc/config/valve.html#Access_Log_Valve


> Use new Tomcat 9 maxDays Access_Log_Valve Attribute
> ---
>
> Key: OFBIZ-13073
> URL: https://issues.apache.org/jira/browse/OFBIZ-13073
> Project: OFBiz
>  Issue Type: Improvement
>  Components: tomcat
>Affects Versions: Upcoming Branch, 18.12.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 18.12.13
>
>
> https://tomcat.apache.org/tomcat-9.0-doc/config/valve.html#Access_Log_Valve



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13059) Old error in showPortalPage screen

2024-04-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841584#comment-17841584
 ] 

ASF subversion and git services commented on OFBIZ-13059:
-

Commit 97564381288f0e6995b40fce01539d4083fea473 in ofbiz-framework's branch 
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=9756438128 ]

Fixed: Old error in showPortalPage screen (OFBIZ-13059)

There is no place where showPortalPage is used where parameters.confMode and
parameters.usePrivate have values, no need to keep this commented out.


> Old error in showPortalPage screen
> --
>
> Key: OFBIZ-13059
> URL: https://issues.apache.org/jira/browse/OFBIZ-13059
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/common
>Affects Versions: Upcoming Branch, 18.12.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 18.12.13
>
>
> I spotted this error in demo stable and trunk error.log. It's due to an old 
> commit: https://svn.apache.org/repos/asf/ofbiz/trunk@1023286 
> I tried a bit to understand what's the problem was but as it's a 13,5 years 
> old bug I eventually decided to simply remove the wrong parts. I'll not 
> backport.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12897) Rework the log4j2.xml configuration to limit the number of log files generated

2024-04-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841585#comment-17841585
 ] 

ASF subversion and git services commented on OFBIZ-12897:
-

Commit f3a07162d4a3327287085dc235facc612b46e7ec in ofbiz-framework's branch 
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=f3a07162d4 ]

Improved: Rework the log4j2.xml configuration to limit the number of log files 
generated (OFBIZ-12897)

Changes the log4j2 config to allow 30 rollover ofbiz and 10 error log files.
We have enough space and it's the same for any OFBIz user now.
>From my experience that can be useful to have a such backup sometimes.


> Rework the log4j2.xml configuration to limit the number of log files generated
> --
>
> Key: OFBIZ-12897
> URL: https://issues.apache.org/jira/browse/OFBIZ-12897
> Project: OFBiz
>  Issue Type: Task
>  Components: framework
>Affects Versions: Upcoming Branch, 18.12.11
>Reporter: Daniel Watford
>Assignee: Daniel Watford
>Priority: Minor
>
> File lo4j2.xml configure log file rolling, but it does not appear to function 
> as perhaps intended.
> Log file rolling is configured to keep up to 10 log files. But the log file 
> naming convention appears to cause a maximum of 10 logs files to be kept for 
> each day.
> Rework the log4j2.xml configuration file to ensure that only 10 log files are 
> kept (for each appender) regardless of the date.
> Also, a limit of 1MB is quite small these days, particularly as text editors 
> can easily search through larger files without a noticeable performance 
> penalty (YMMV). I recommend raising the log file size limit to 10MB as this 
> would keep more log entries around without a corresponding increase in the 
> number of file.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13073) Use new Tomcat 9 maxDays Access_Log_Valve Attribute

2024-04-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841586#comment-17841586
 ] 

ASF subversion and git services commented on OFBIZ-13073:
-

Commit 2f4d1acdb93c274eb94ead7890b64dd383cb3dad in ofbiz-framework's branch 
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=2f4d1acdb9 ]

Improved: Use new Tomcat 9 maxDays Access_Log_Valve Attribute (OFBIZ-13073)

https://tomcat.apache.org/tomcat-9.0-doc/config/valve.html#Access_Log_Valve

Conflict handled by hand framework/catalina/ofbiz-component.xml


> Use new Tomcat 9 maxDays Access_Log_Valve Attribute
> ---
>
> Key: OFBIZ-13073
> URL: https://issues.apache.org/jira/browse/OFBIZ-13073
> Project: OFBiz
>  Issue Type: Improvement
>  Components: tomcat
>Affects Versions: Upcoming Branch, 18.12.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 18.12.13
>
>
> https://tomcat.apache.org/tomcat-9.0-doc/config/valve.html#Access_Log_Valve



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13059) Old error in showPortalPage screen

2024-04-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841587#comment-17841587
 ] 

ASF subversion and git services commented on OFBIZ-13059:
-

Commit 8a3ba28e5a8e287c5f0fc5c0bcdc544c211e89e0 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=8a3ba28e5a ]

Fixed: Old error in showPortalPage screen (OFBIZ-13059)

There is no place where showPortalPage is used where parameters.confMode and
parameters.usePrivate have values, no need to keep this commented out.


> Old error in showPortalPage screen
> --
>
> Key: OFBIZ-13059
> URL: https://issues.apache.org/jira/browse/OFBIZ-13059
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/common
>Affects Versions: Upcoming Branch, 18.12.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 18.12.13
>
>
> I spotted this error in demo stable and trunk error.log. It's due to an old 
> commit: https://svn.apache.org/repos/asf/ofbiz/trunk@1023286 
> I tried a bit to understand what's the problem was but as it's a 13,5 years 
> old bug I eventually decided to simply remove the wrong parts. I'll not 
> backport.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13071) Could not find PortalPage with portalPageId []

2024-04-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841583#comment-17841583
 ] 

ASF subversion and git services commented on OFBIZ-13071:
-

Commit 146a20a0f109160e700f74a668c395523f1e1abe in ofbiz-framework's branch 
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=146a20a0f1 ]

Improved: Could not find PortalPage with portalPageId []  (OFBIZ-13071)

When a spider bot gets to certain non-sense URIs under sfa app (it seems only
for sfa, did not dig further it's non-sense anyway) like discovered in
trunk demo log today: <>
the <> error shows

Then we don't need to clutter the log with useless error information.
This keeps it ASAP by simply returning the portalPage if it's null.

Conflict handled by hand ModelScreenWidget.java


> Could not find PortalPage with portalPageId [] 
> ---
>
> Key: OFBIZ-13071
> URL: https://issues.apache.org/jira/browse/OFBIZ-13071
> Project: OFBiz
>  Issue Type: Bug
>  Components: sfa
>Affects Versions: 18.12.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.13
>
>
> This is a weird behaviour. Yet it's not really a bug but something that 
> spider bots do. They get to ListTimezones while not being signed in (hard for 
> spider bot). Here are 2 cases:
> {noformat}
> 18.224.149.242 - - [26/Apr/2024:03:20:05 +] "GET 
> /sfa/control/setSessionTimeZone?tzId=Australia/Melbourne HTTP/1.1" 200 42716 
> "-" "Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; 
> ClaudeBot/1.0; +claude...@anthropic.com)"
> 2024-04-26 03:20:05,254 |-0.0.0.0-8009-exec-4 |ModelScreenWidget 
> |E| Could not find PortalPage with portalPageId [] 
> 3.144.172.115 - - [26/Apr/2024:03:32:22 +] "GET 
> /sfa/control/setSessionTimeZone?tzId=Asia/Kuwait HTTP/1.1" 200 42716 "-" 
> "Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; 
> ClaudeBot/1.0; +claude...@anthropic.com)"
> 2024-04-26 03:32:22,395 |-0.0.0.0-8009-exec-7 |ModelScreenWidget 
> |E| Could not find PortalPage with portalPageId [] 
> {noformat}
> It happens only for SFA. [All the others| https://s.apache.org/gwyw2 ] are 
> not concerned
> Why only SFA is concerned is unclear but not really a problem. Because once 
> signed in the problem dissapears. The only problem is that if a spider bot 
> gets to your production server it will clutter the log. There is 636 possible 
> hours...
> Now that I know the reason, I'll try to find a workaround.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12897) Rework the log4j2.xml configuration to limit the number of log files generated

2024-04-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841588#comment-17841588
 ] 

ASF subversion and git services commented on OFBIZ-12897:
-

Commit 57acd94478ccceb0477596f911ccb583360d9074 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=57acd94478 ]

Improved: Rework the log4j2.xml configuration to limit the number of log files 
generated (OFBIZ-12897)

Changes the log4j2 config to allow 30 rollover ofbiz and 10 error log files.
We have enough space and it's the same for any OFBIz user now.
>From my experience that can be useful to have a such backup sometimes.


> Rework the log4j2.xml configuration to limit the number of log files generated
> --
>
> Key: OFBIZ-12897
> URL: https://issues.apache.org/jira/browse/OFBIZ-12897
> Project: OFBiz
>  Issue Type: Task
>  Components: framework
>Affects Versions: Upcoming Branch, 18.12.11
>Reporter: Daniel Watford
>Assignee: Daniel Watford
>Priority: Minor
>
> File lo4j2.xml configure log file rolling, but it does not appear to function 
> as perhaps intended.
> Log file rolling is configured to keep up to 10 log files. But the log file 
> naming convention appears to cause a maximum of 10 logs files to be kept for 
> each day.
> Rework the log4j2.xml configuration file to ensure that only 10 log files are 
> kept (for each appender) regardless of the date.
> Also, a limit of 1MB is quite small these days, particularly as text editors 
> can easily search through larger files without a noticeable performance 
> penalty (YMMV). I recommend raising the log file size limit to 10MB as this 
> would keep more log entries around without a corresponding increase in the 
> number of file.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13071) Could not find PortalPage with portalPageId []

2024-04-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841516#comment-17841516
 ] 

ASF subversion and git services commented on OFBIZ-13071:
-

Commit bc92ac06fab17186ca63b6e96adcf5037e87f796 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=bc92ac06fa ]

Improved: Could not find PortalPage with portalPageId []  (OFBIZ-13071)

When a spider bot gets to certain non-sense URIs under sfa app (it seems only
for sfa, did not dig further it's non-sense anyway) like discovered in
trunk demo log today: <>
the <> error shows

Then we don't need to clutter the log with useless error information.
This keeps it ASAP by simply returning the portalPage if it's null.


> Could not find PortalPage with portalPageId [] 
> ---
>
> Key: OFBIZ-13071
> URL: https://issues.apache.org/jira/browse/OFBIZ-13071
> Project: OFBiz
>  Issue Type: Bug
>  Components: sfa
>Affects Versions: 18.12.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.13
>
>
> This is a weird behaviour. Yet it's not really a bug but something that 
> spider bots do. They get to ListTimezones while not being signed in (hard for 
> spider bot). Here are 2 cases:
> {noformat}
> 18.224.149.242 - - [26/Apr/2024:03:20:05 +] "GET 
> /sfa/control/setSessionTimeZone?tzId=Australia/Melbourne HTTP/1.1" 200 42716 
> "-" "Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; 
> ClaudeBot/1.0; +claude...@anthropic.com)"
> 2024-04-26 03:20:05,254 |-0.0.0.0-8009-exec-4 |ModelScreenWidget 
> |E| Could not find PortalPage with portalPageId [] 
> 3.144.172.115 - - [26/Apr/2024:03:32:22 +] "GET 
> /sfa/control/setSessionTimeZone?tzId=Asia/Kuwait HTTP/1.1" 200 42716 "-" 
> "Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; 
> ClaudeBot/1.0; +claude...@anthropic.com)"
> 2024-04-26 03:32:22,395 |-0.0.0.0-8009-exec-7 |ModelScreenWidget 
> |E| Could not find PortalPage with portalPageId [] 
> {noformat}
> It happens only for SFA. [All the others| https://s.apache.org/gwyw2 ] are 
> not concerned
> Why only SFA is concerned is unclear but not really a problem. Because once 
> signed in the problem dissapears. The only problem is that if a spider bot 
> gets to your production server it will clutter the log. There is 636 possible 
> hours...
> Now that I know the reason, I'll try to find a workaround.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13071) Could not find PortalPage with portalPageId []

2024-04-26 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841126#comment-17841126
 ] 

ASF subversion and git services commented on OFBIZ-13071:
-

Commit 075fce1d652db3d0d8b8e6b2e07ec74cdb4659a3 in ofbiz-framework's branch 
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=075fce1d65 ]

Fixed: Could not find PortalPage with portalPageId [] (OFBIZ-13071)

Avoids spider bots to clutter the logs by forcing auth. Does not make sense
W/o anyway


> Could not find PortalPage with portalPageId [] 
> ---
>
> Key: OFBIZ-13071
> URL: https://issues.apache.org/jira/browse/OFBIZ-13071
> Project: OFBiz
>  Issue Type: Bug
>  Components: sfa
>Affects Versions: 18.12.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.13
>
>
> This is a weird behaviour. Yet it's not really a bug but something that 
> spider bots do. They get to ListTimezones while not being signed in (hard for 
> spider bot). Here are 2 cases:
> {noformat}
> 18.224.149.242 - - [26/Apr/2024:03:20:05 +] "GET 
> /sfa/control/setSessionTimeZone?tzId=Australia/Melbourne HTTP/1.1" 200 42716 
> "-" "Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; 
> ClaudeBot/1.0; +claude...@anthropic.com)"
> 2024-04-26 03:20:05,254 |-0.0.0.0-8009-exec-4 |ModelScreenWidget 
> |E| Could not find PortalPage with portalPageId [] 
> 3.144.172.115 - - [26/Apr/2024:03:32:22 +] "GET 
> /sfa/control/setSessionTimeZone?tzId=Asia/Kuwait HTTP/1.1" 200 42716 "-" 
> "Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; 
> ClaudeBot/1.0; +claude...@anthropic.com)"
> 2024-04-26 03:32:22,395 |-0.0.0.0-8009-exec-7 |ModelScreenWidget 
> |E| Could not find PortalPage with portalPageId [] 
> {noformat}
> It happens only for SFA. [All the others| https://s.apache.org/gwyw2 ] are 
> not concerned
> Why only SFA is concerned is unclear but not really a problem. Because once 
> signed in the problem dissapears. The only problem is that if a spider bot 
> gets to your production server it will clutter the log. There is 636 possible 
> hours...
> Now that I know the reason, I'll try to find a workaround.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13071) Could not find PortalPage with portalPageId []

2024-04-26 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841123#comment-17841123
 ] 

ASF subversion and git services commented on OFBIZ-13071:
-

Commit 6fa3a5dc27ce65375b64fa66afaf9ef6934dfdc0 in ofbiz-plugins's branch 
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=6fa3a5dc2 ]

Fixed: Could not find PortalPage with portalPageId [] (OFBIZ-13071)

Avoids spider bots to clutter the logs by forcing auth. Does not make sense
W/o anyway


> Could not find PortalPage with portalPageId [] 
> ---
>
> Key: OFBIZ-13071
> URL: https://issues.apache.org/jira/browse/OFBIZ-13071
> Project: OFBiz
>  Issue Type: Bug
>  Components: sfa
>Affects Versions: 18.12.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.13
>
>
> This is a weird behaviour. Yet it's not really a bug but something that 
> spider bots do. They get to ListTimezones while not being signed in (hard for 
> spider bot). Here are 2 cases:
> {noformat}
> 18.224.149.242 - - [26/Apr/2024:03:20:05 +] "GET 
> /sfa/control/setSessionTimeZone?tzId=Australia/Melbourne HTTP/1.1" 200 42716 
> "-" "Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; 
> ClaudeBot/1.0; +claude...@anthropic.com)"
> 2024-04-26 03:20:05,254 |-0.0.0.0-8009-exec-4 |ModelScreenWidget 
> |E| Could not find PortalPage with portalPageId [] 
> 3.144.172.115 - - [26/Apr/2024:03:32:22 +] "GET 
> /sfa/control/setSessionTimeZone?tzId=Asia/Kuwait HTTP/1.1" 200 42716 "-" 
> "Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; 
> ClaudeBot/1.0; +claude...@anthropic.com)"
> 2024-04-26 03:32:22,395 |-0.0.0.0-8009-exec-7 |ModelScreenWidget 
> |E| Could not find PortalPage with portalPageId [] 
> {noformat}
> It happens only for SFA. [All the others| https://s.apache.org/gwyw2 ] are 
> not concerned
> Why only SFA is concerned is unclear but not really a problem. Because once 
> signed in the problem dissapears. The only problem is that if a spider bot 
> gets to your production server it will clutter the log. There is 636 possible 
> hours...
> Now that I know the reason, I'll try to find a workaround.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13071) Could not find PortalPage with portalPageId []

2024-04-26 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841089#comment-17841089
 ] 

ASF subversion and git services commented on OFBIZ-13071:
-

Commit 97b499195315453d1ca00fc9b19e04fde25420f6 in ofbiz-plugins's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=97b499195 ]

Fixed: Could not find PortalPage with portalPageId []  (OFBIZ-13071)

Avoids spider bots to clutter the logs by forcing auth. Does not make sense
W/o anyway


> Could not find PortalPage with portalPageId [] 
> ---
>
> Key: OFBIZ-13071
> URL: https://issues.apache.org/jira/browse/OFBIZ-13071
> Project: OFBiz
>  Issue Type: Bug
>  Components: sfa
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> This is a weird behaviour. Yet it's not really a bug but something that 
> spider bots do. They get to ListTimezones while not being signed in (hard for 
> spider bot). Here are 2 cases:
> {noformat}
> 18.224.149.242 - - [26/Apr/2024:03:20:05 +] "GET 
> /sfa/control/setSessionTimeZone?tzId=Australia/Melbourne HTTP/1.1" 200 42716 
> "-" "Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; 
> ClaudeBot/1.0; +claude...@anthropic.com)"
> 2024-04-26 03:20:05,254 |-0.0.0.0-8009-exec-4 |ModelScreenWidget 
> |E| Could not find PortalPage with portalPageId [] 
> 3.144.172.115 - - [26/Apr/2024:03:32:22 +] "GET 
> /sfa/control/setSessionTimeZone?tzId=Asia/Kuwait HTTP/1.1" 200 42716 "-" 
> "Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; 
> ClaudeBot/1.0; +claude...@anthropic.com)"
> 2024-04-26 03:32:22,395 |-0.0.0.0-8009-exec-7 |ModelScreenWidget 
> |E| Could not find PortalPage with portalPageId [] 
> {noformat}
> It happens only for SFA. [All the others| https://s.apache.org/gwyw2 ] are 
> not concerned
> Why only SFA is concerned is unclear but not really a problem. Because once 
> signed in the problem dissapears. The only problem is that if a spider bot 
> gets to your production server it will clutter the log. There is 636 possible 
> hours...
> Now that I know the reason, I'll try to find a workaround.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13071) Could not find PortalPage with portalPageId []

2024-04-26 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841088#comment-17841088
 ] 

ASF subversion and git services commented on OFBIZ-13071:
-

Commit 0b9cc3b85a3aed00244e058bd2a2299a55fb9292 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=0b9cc3b85a ]

Fixed: Could not find PortalPage with portalPageId []  (OFBIZ-13071)

Avoids spider bots to clutter the logs by forcing auth. Does not make sense
W/o anyway


> Could not find PortalPage with portalPageId [] 
> ---
>
> Key: OFBIZ-13071
> URL: https://issues.apache.org/jira/browse/OFBIZ-13071
> Project: OFBiz
>  Issue Type: Bug
>  Components: sfa
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> This is a weird behaviour. Yet it's not really a bug but something that 
> spider bots do. They get to ListTimezones while not being signed in (hard for 
> spider bot). Here are 2 cases:
> {noformat}
> 18.224.149.242 - - [26/Apr/2024:03:20:05 +] "GET 
> /sfa/control/setSessionTimeZone?tzId=Australia/Melbourne HTTP/1.1" 200 42716 
> "-" "Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; 
> ClaudeBot/1.0; +claude...@anthropic.com)"
> 2024-04-26 03:20:05,254 |-0.0.0.0-8009-exec-4 |ModelScreenWidget 
> |E| Could not find PortalPage with portalPageId [] 
> 3.144.172.115 - - [26/Apr/2024:03:32:22 +] "GET 
> /sfa/control/setSessionTimeZone?tzId=Asia/Kuwait HTTP/1.1" 200 42716 "-" 
> "Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; 
> ClaudeBot/1.0; +claude...@anthropic.com)"
> 2024-04-26 03:32:22,395 |-0.0.0.0-8009-exec-7 |ModelScreenWidget 
> |E| Could not find PortalPage with portalPageId [] 
> {noformat}
> It happens only for SFA. [All the others| https://s.apache.org/gwyw2 ] are 
> not concerned
> Why only SFA is concerned is unclear but not really a problem. Because once 
> signed in the problem dissapears. The only problem is that if a spider bot 
> gets to your production server it will clutter the log. There is 636 possible 
> hours...
> Now that I know the reason, I'll try to find a workaround.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13060) quickInitDataWarehouse fails

2024-04-25 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840886#comment-17840886
 ] 

ASF subversion and git services commented on OFBIZ-13060:
-

Commit 4511f5e6f69d0bd19df3ce3baecb8a8e23f8d54e in ofbiz-plugins's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=4511f5e6f ]

Fixed: quickInitDataWarehouse fails (OFBIZ-13060)

There were 2 reasons.

I thought initially that it was only my bad in BiSystemPropertyData.xml where I
set the thruDate value for bi.property to 2133-09-01 instead of 2033-09-01

But it turned out that I had also to increase the quickInitDataWarehouse and
loadInventoryFact service timeouts to 300. I picked 300, I guess it's a bit 
much,
to follow loadDateDimension service.


> quickInitDataWarehouse fails
> 
>
> Key: OFBIZ-13060
> URL: https://issues.apache.org/jira/browse/OFBIZ-13060
> Project: OFBiz
>  Issue Type: Bug
>  Components: bi
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> The error is:
> org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error 
> (Could not commit transaction for service [quickInitDataWarehouse] call: Roll 
> back error (with no rollbackOnly cause found), could not commit transaction, 
> was rolled back instead: java.lang.Exception: Transaction has timed out 
> (Transaction has timed out))
> It works in next demo, so it's due to a "recent" changes. It seems the 
> conversion from XML of DimensionServices to groovy is the reason. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-1659) Improve usability of Employment Screen

2024-04-25 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840803#comment-17840803
 ] 

ASF subversion and git services commented on OFBIZ-1659:


Commit 39c8abf135b63004981f1d4d68577cf16edd5dbf in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=39c8abf135 ]

Fixed: Error in PayGradeForms.xml Line: 65 (OFBIZ-13062)

Remove the line 65. It was put in by OFBIZ-1659. It's useless (tested)


> Improve usability of Employment Screen
> --
>
> Key: OFBIZ-1659
> URL: https://issues.apache.org/jira/browse/OFBIZ-1659
> Project: OFBiz
>  Issue Type: New Feature
>  Components: humanres
>Reporter: Anil K Patel
>Assignee: Ashish Vijaywargiya
>Priority: Minor
> Attachments: CreateEmployee.patch, HREmployee.patch, 
> HREmployee.patch, Improvements.patch, Improvements.patch, Improvements.patch, 
> Improvements.patch, Improvements.patch, Improvements.patch, 
> Improvements.patch, Improvements.patch, Improvements.patch, 
> Improvements.patch, Improvements.patch, Improvements.patch, 
> Improvements.patch, Improvements.patch, Improvements.patch, 
> Improvements.patch, Improvements.patch, Improvements.patch, 
> Improvements.patch, improvements.patch
>
>
> Following things can be done to improve usability of Employment screen.
> Rename the Employment app menu to Employees
> 1) Add Find/List form to find employees in system. 
> 2) [Create New Employee] This should give a form where we user can input 
> Person and Contact details and few fields from Employment table.
> 3) Employment is a Party Relationship between Party Roles FROM EMPLOYEE TO 
> INTERNAL ORGANIZATION. To make it easy, values of these two fields should be 
> Defaulted to these values and I don't see need to show these fields on form.
> 4) The Employment.FromPartyId field should have a Party look up that shows 
> only the Person.
> 5) The Employment.ToPartyId field should be a drop down of Parties in 
> Internal Organization role.
> 6) Do not show Termination type and reason fields on Create Employment forms.
> 7) Add Terminate Employment button on Update Employment form. On click of 
> button show a Sub Form that has fields Termination type, Reason and comments 
> fields.
> 8) The Edit form should have FromPartyId read only.
> 9) Edit employee screens should have, Summary tab, Employee tab, Employment 
> and other tabs defined in other jira issue.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13062) Error in PayGradeForms.xml Line: 65

2024-04-25 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840802#comment-17840802
 ] 

ASF subversion and git services commented on OFBIZ-13062:
-

Commit 39c8abf135b63004981f1d4d68577cf16edd5dbf in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=39c8abf135 ]

Fixed: Error in PayGradeForms.xml Line: 65 (OFBIZ-13062)

Remove the line 65. It was put in by OFBIZ-1659. It's useless (tested)


> Error in PayGradeForms.xml Line: 65
> ---
>
> Key: OFBIZ-13062
> URL: https://issues.apache.org/jira/browse/OFBIZ-13062
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres
>Affects Versions: 18.12.13
>Reporter: Jacques Le Roux
>Priority: Major
>
> XmlFileLoader: File 
> file:/ofbiz/applications/humanres/widget/forms/PayGradeForms.xml process 
> error. Line: 65. Error message: cvc-complex-type.4: Attribute 'value-field' 
> must appear on element 'entity-one'.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13068) Accounts Payable Past Due Invoices doesn't show outstanding amount

2024-04-25 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840763#comment-17840763
 ] 

ASF subversion and git services commented on OFBIZ-13068:
-

Commit c7230e1006ee18a8c55e8295e57725d78c355e13 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=c7230e1006 ]

Improved: Accounts Payable Past Due Invoices doesn't show outstanding amount 
(OFBIZ-13068)

There is a subtle difference between "Accounts Receivable" and "Accounts 
Payable"

It's reflected in current AR and AP applications (currently replaced by the main
accounting page, WIP)

For a receivable payment we use "Outstanding amount", for payable payment
we use "Amount to apply"

This fixes it again and for a last time!-


> Accounts Payable Past Due Invoices doesn't show outstanding amount
> --
>
> Key: OFBIZ-13068
> URL: https://issues.apache.org/jira/browse/OFBIZ-13068
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Reporter: Pierre Smits
>Priority: Major
>
> With recent changes via commit ec0adc02f102d75be15e1ee04062b75621219f0d 
> [ec0adc02f1] the field outstanding got replaced with amountToApply in grid 
> ListApReport.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13068) Accounts Payable Past Due Invoices doesn't show outstanding amount

2024-04-25 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840757#comment-17840757
 ] 

ASF subversion and git services commented on OFBIZ-13068:
-

Commit 0c7823c3bf0f2359f14bab5d7d574847002649f2 in ofbiz-framework's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=0c7823c3bf ]

Fixed: Accounts Payable Past Due Invoices doesn't show outstanding amount 
(OFBIZ-13068) (#786)

With recent changes via commit ec0adc02f102d75be15e1ee04062b75621219f0d 
[ec0adc02f1] the field outstanding got replaced with amountToApply in grid 
ListApReport.

modified: InvoiceForms.xml
- replaced field amountToApply with outstanding in grid ListApReport
- corrected style of field total and outstanding in grid ListArReport
- corrected style of field total and outstanding in grid ListApReport

> Accounts Payable Past Due Invoices doesn't show outstanding amount
> --
>
> Key: OFBIZ-13068
> URL: https://issues.apache.org/jira/browse/OFBIZ-13068
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Reporter: Pierre Smits
>Priority: Major
>
> With recent changes via commit ec0adc02f102d75be15e1ee04062b75621219f0d 
> [ec0adc02f1] the field outstanding got replaced with amountToApply in grid 
> ListApReport.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13065) userLogin null or missing in customer/ViewProfile.ftl

2024-04-24 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840337#comment-17840337
 ] 

ASF subversion and git services commented on OFBIZ-13065:
-

Commit 5eea336a62fa302aab3765bd756d0ee896230171 in ofbiz-plugins's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=5eea336a6 ]

Fixed: userLogin  null or missing in customer/ViewProfile.ftl (OFBIZ-13065)

This was found trunk demo error.log. A rare case I guess (party does not exist 
too)

I also globally indented the code from start to make it more legible.
It makes the commit a bit hard to read. That's only once...


> userLogin  null or missing in customer/ViewProfile.ftl
> --
>
> Key: OFBIZ-13065
> URL: https://issues.apache.org/jira/browse/OFBIZ-13065
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Jacques Le Roux
>Priority: Minor
>
> The complete error is
> freemarker.core.InvalidReferenceException: The following has evaluated to 
> null or missing:
> ==> userLogin  [in template 
> "component://ecommerce/template/customer/ViewProfile.ftl" at line 637, column 
> 57]
> A rare case I guess (party does not exist too)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-24 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840330#comment-17840330
 ] 

ASF subversion and git services commented on OFBIZ-13035:
-

Commit b376ddfb7ca1702f20b665737aa084ae278d60a6 in ofbiz-plugins's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=b376ddfb7 ]

Fixed: Fix cross-app menu location issues (OFBIZ-13035)

Fixes
Error rendering included menu named [ExampleAppBar] at location
[component://exampleext/widget/example/ExampleMenus.xml]:
java.lang.IllegalArgumentException: Could not find menu with name 
[ExampleAppBar]
 in location [component://exampleext/widget/example/ExampleMenus.xml]


> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13061) Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors

2024-04-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840151#comment-17840151
 ] 

ASF subversion and git services commented on OFBIZ-13061:
-

Commit b12f2779e6fd90662baad3fee0f51dfb11215ee8 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b12f2779e6 ]

Fixed: Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser 
errors (OFBIZ-13061)

The previous commit was not enough as I feared. It still shows in trunk demo
error.log today. So here comes the ugly but sure fix.


> Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors
> 
>
> Key: OFBIZ-13061
> URL: https://issues.apache.org/jira/browse/OFBIZ-13061
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/common
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> Currently the demo logs, and I guess the users production logs, are cluttered 
> up with very common and unique SetTimeZoneFromBrowser errors.
> We can easily prevent that by not returning an error from 
> SetTimeZoneFromBrowser.groovy, and so the never ending 
> bq. < message: User authorization is required for this service: 
> SetTimeZoneFromBrowser>>
> from RequestHandler.java



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13063) Wrong partyId Accounts Payable

2024-04-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840138#comment-17840138
 ] 

ASF subversion and git services commented on OFBIZ-13063:
-

Commit ec0adc02f102d75be15e1ee04062b75621219f0d in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=ec0adc02f1 ]

Fixed: Wrong partyId Accounts Payable (OFBIZ-13063)

In previous commit I removed AccountingOutstanding added by Pierre (just en and
nl translations) then used anywhere.

Pierre contacted me and rightly mentioned that the English translation of
property key="" was wrong.
It should logically have been "Amount to apply" (an old wrong change of
revision 775580 put in the mistake)

So I changed that and re-added AccountingOutstanding though using
FormFieldTitle_outstanding to replace in right places in both
accounting and ar InvoiceForms.xml.

Pfew...


> Wrong partyId Accounts Payable
> --
>
> Key: OFBIZ-13063
> URL: https://issues.apache.org/jira/browse/OFBIZ-13063
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> The Accounts Payable Past Due and Due Soon overviews in the Main page shows 
> the wrong partyId of the creditor.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13063) Wrong partyId Accounts Payable

2024-04-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840012#comment-17840012
 ] 

ASF subversion and git services commented on OFBIZ-13063:
-

Commit be7231e2d5a78b1294b56c6603d7744a2eb494a9 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=be7231e2d5 ]

Fixed: Wrong partyId Accounts Payable (OFBIZ-13063)

Fixes partyId to partyIdFrom for the link to the creditor profile in
ListApReport form

Also uses FormFieldTitle_amountToApply that have foreign translations while
removing AccountingOutstanding added by Pierre (just en and  nl translations)
then used anywhere


> Wrong partyId Accounts Payable
> --
>
> Key: OFBIZ-13063
> URL: https://issues.apache.org/jira/browse/OFBIZ-13063
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Reporter: Pierre Smits
>Priority: Major
>
> The Accounts Payable Past Due and Due Soon overviews in the Main page shows 
> the wrong partyId of the creditor.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13063) Wrong partyId Accounts Payable

2024-04-23 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839997#comment-17839997
 ] 

ASF subversion and git services commented on OFBIZ-13063:
-

Commit 0863258e104c57721a6a0cf9d37564646e425ebf in ofbiz-framework's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=0863258e10 ]

Improved: Wrong partyId Accounts Payable (OFBIZ-13063) (#781)

The Accounts Payable Past Due and Due Soon overviews in the Main page shows the 
wrong partyId of the creditor.

modified: InvoiceForms.xml
- adjusted grid ListArReport

> Wrong partyId Accounts Payable
> --
>
> Key: OFBIZ-13063
> URL: https://issues.apache.org/jira/browse/OFBIZ-13063
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Reporter: Pierre Smits
>Priority: Major
>
> The Accounts Payable Past Due and Due Soon overviews in the Main page shows 
> the wrong partyId of the creditor.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12966) Integrate AR Past Due into accounting- main

2024-04-22 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839972#comment-17839972
 ] 

ASF subversion and git services commented on OFBIZ-12966:
-

Commit edcf41917c3e6fbeaa832f63cd98daf78d3fd34a in ofbiz-framework's branch 
refs/heads/trunk from Mekika Leila
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=edcf41917c ]

Fixed: invoiceOverview generates an error (OFBIZ-13017) (#780)

Update fix to combine  OFBIZ-12966 and OFBIZ-13011 updates with
modifications brought by jira OFBIZ-12994

It brings back the changes introduced by OFBIZ-12994 and adapt it with
the change of invoiceOverview screen name

> Integrate AR Past Due into accounting- main
> ---
>
> Key: OFBIZ-12966
> URL: https://issues.apache.org/jira/browse/OFBIZ-12966
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> Integrate the overview of invoices past due date of accounts receivable as a 
> portal page into the main screen of the accounting application.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13017) invoiceOverview generates an error

2024-04-22 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839971#comment-17839971
 ] 

ASF subversion and git services commented on OFBIZ-13017:
-

Commit edcf41917c3e6fbeaa832f63cd98daf78d3fd34a in ofbiz-framework's branch 
refs/heads/trunk from Mekika Leila
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=edcf41917c ]

Fixed: invoiceOverview generates an error (OFBIZ-13017) (#780)

Update fix to combine  OFBIZ-12966 and OFBIZ-13011 updates with
modifications brought by jira OFBIZ-12994

It brings back the changes introduced by OFBIZ-12994 and adapt it with
the change of invoiceOverview screen name

> invoiceOverview generates an error
> --
>
> Key: OFBIZ-13017
> URL: https://issues.apache.org/jira/browse/OFBIZ-13017
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> see 
> https://demo-trunk.ofbiz.apache.org/accounting/control/invoiceOverview?invoiceId=demo10001



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12994) Convert Invoice relation screen to dynamic Compound

2024-04-22 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839974#comment-17839974
 ] 

ASF subversion and git services commented on OFBIZ-12994:
-

Commit edcf41917c3e6fbeaa832f63cd98daf78d3fd34a in ofbiz-framework's branch 
refs/heads/trunk from Mekika Leila
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=edcf41917c ]

Fixed: invoiceOverview generates an error (OFBIZ-13017) (#780)

Update fix to combine  OFBIZ-12966 and OFBIZ-13011 updates with
modifications brought by jira OFBIZ-12994

It brings back the changes introduced by OFBIZ-12994 and adapt it with
the change of invoiceOverview screen name

> Convert Invoice relation screen to dynamic Compound
> ---
>
> Key: OFBIZ-12994
> URL: https://issues.apache.org/jira/browse/OFBIZ-12994
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting/invoice
>Affects Versions: Upcoming Branch
>Reporter: Mekika Leila
>Assignee: Mekika Leila
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> After the work on the task OFBIZ-11808, and the migration started for 
> workeffort screens on OFBIZ-12292, the purpose is to migrate all screen 
> linked to Invoice entity with idea to reduce the code and use widget 
> improvement developped last years
> This migration cover invoice related screens from invoiceOverview to 
> managment screens and forms for each invoice sub item such as:
>  - Applications
>  - Attributes
>  - ContactMech
>  - Content
>  - Item
>  - Note
>  - Role
>  - Status
>  - Term
>  - TimeEntry
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13011) Integrate Invoice Due Soon and Past Due into accounting main

2024-04-22 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839973#comment-17839973
 ] 

ASF subversion and git services commented on OFBIZ-13011:
-

Commit edcf41917c3e6fbeaa832f63cd98daf78d3fd34a in ofbiz-framework's branch 
refs/heads/trunk from Mekika Leila
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=edcf41917c ]

Fixed: invoiceOverview generates an error (OFBIZ-13017) (#780)

Update fix to combine  OFBIZ-12966 and OFBIZ-13011 updates with
modifications brought by jira OFBIZ-12994

It brings back the changes introduced by OFBIZ-12994 and adapt it with
the change of invoiceOverview screen name

> Integrate Invoice Due Soon and Past Due into accounting main
> 
>
> Key: OFBIZ-13011
> URL: https://issues.apache.org/jira/browse/OFBIZ-13011
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> Further integrate overviews regarding Invoice Past Due and Due Soon into the 
> main screen of the accounting application as portal pages.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-22 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839760#comment-17839760
 ] 

ASF subversion and git services commented on OFBIZ-13035:
-

Commit 740512a4e6ad2297fe24dc4878f447e41074665d in ofbiz-plugins's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=740512a4e ]

Improved: Fix cross-app menu location issues (OFBIZ-13035) (#121)

address cross application menu-location issues.

modified: assetmaint/web.xml
- added context-param calendarMenuLocation (re calendar screen of a fixed asset)

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13047) SOLR-parameterized menu location

2024-04-22 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839718#comment-17839718
 ] 

ASF subversion and git services commented on OFBIZ-13047:
-

Commit 2cf4d898128b1c4582aaee3c962e5bd6ecade938 in ofbiz-plugins's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=2cf4d8981 ]

improved: SOLR - parameterized menu location (OFBIZ-13047) (#120)

modified: CommonScreens.xml - change menu location

> SOLR-parameterized menu location
> 
>
> Key: OFBIZ-13047
> URL: https://issues.apache.org/jira/browse/OFBIZ-13047
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Pierre Smits
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13046) ExampleExt- parameterized menu location

2024-04-22 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839715#comment-17839715
 ] 

ASF subversion and git services commented on OFBIZ-13046:
-

Commit d460f2beadebdd5af47395c40a35b0b278dbcfec in ofbiz-plugins's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=d460f2bea ]

Improved: ExampleExt - move to parameterized menu location (OFBIZ-13046) (#119)

CommonScreens.xml: change menu location

> ExampleExt- parameterized menu location
> ---
>
> Key: OFBIZ-13046
> URL: https://issues.apache.org/jira/browse/OFBIZ-13046
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: exampleext
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13046) ExampleExt- parameterized menu location

2024-04-22 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839682#comment-17839682
 ] 

ASF subversion and git services commented on OFBIZ-13046:
-

Commit b48f71ebdd072b28bd52d80065bfb81cc79facea in ofbiz-plugins's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=b48f71ebd ]

Improved: FIRST - move to parameterized menu location (OFBIZ-13046) (#118)

CommonScreens.xml: change menu location

> ExampleExt- parameterized menu location
> ---
>
> Key: OFBIZ-13046
> URL: https://issues.apache.org/jira/browse/OFBIZ-13046
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: exampleext
>Reporter: Pierre Smits
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13043) MSG-parameterized menu location

2024-04-22 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839677#comment-17839677
 ] 

ASF subversion and git services commented on OFBIZ-13043:
-

Commit e43d5253b4e36416f8eb8233620d995f7a3ae075 in ofbiz-plugins's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=e43d5253b ]

Improved: PRI - move to parameterized menu location (OFBIZ-13044) (#117)

* Improved: PRI - move to parameterized menu location (OFBIZ-13043)

CommonScreens.xml: change menu location

* correcting typo

> MSG-parameterized menu location
> ---
>
> Key: OFBIZ-13043
> URL: https://issues.apache.org/jira/browse/OFBIZ-13043
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> Move the various menu locations in content screens to parameterized



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13044) PRI- parameterized menu location

2024-04-22 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839676#comment-17839676
 ] 

ASF subversion and git services commented on OFBIZ-13044:
-

Commit e43d5253b4e36416f8eb8233620d995f7a3ae075 in ofbiz-plugins's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=e43d5253b ]

Improved: PRI - move to parameterized menu location (OFBIZ-13044) (#117)

* Improved: PRI - move to parameterized menu location (OFBIZ-13043)

CommonScreens.xml: change menu location

* correcting typo

> PRI- parameterized menu location
> 
>
> Key: OFBIZ-13044
> URL: https://issues.apache.org/jira/browse/OFBIZ-13044
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: pricat
>Reporter: Pierre Smits
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13061) Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors

2024-04-22 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839559#comment-17839559
 ] 

ASF subversion and git services commented on OFBIZ-13061:
-

Commit 822b031600475d570f43b1d76b7ac5921acd0892 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=822b031600 ]

Fixed: Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser 
errors (OFBIZ-13061)

Currently the demo logs, and I guess users production logs, are cluttered up
with very common and unique SetTimeZoneFromBrowser error.
We can easily prevent that by not returning an error from
SetTimeZoneFromBrowser.groovy, and so the never ending
<>
from RequestHandler.java


> Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors
> 
>
> Key: OFBIZ-13061
> URL: https://issues.apache.org/jira/browse/OFBIZ-13061
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/common
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> Currently the demo logs, and I guess the users production logs, are cluttered 
> up with very common and unique SetTimeZoneFromBrowser errors.
> We can easily prevent that by not returning an error from 
> SetTimeZoneFromBrowser.groovy, and so the never ending 
> bq. < message: User authorization is required for this service: 
> SetTimeZoneFromBrowser>>
> from RequestHandler.java



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13059) Old error in showPortalPage screen

2024-04-22 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839513#comment-17839513
 ] 

ASF subversion and git services commented on OFBIZ-13059:
-

Commit 3662f40f697113a95406b78a6bd8c6380823c2f8 in ofbiz-framework's branch 
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=3662f40f69 ]

Fixed: Old error in showPortalPage screen (OFBIZ-13059)

I spotted this error in demo stable and trunk error.log. It's due to an old
commit: https://svn.apache.org/repos/asf/ofbiz/trunk@1023286

I tried a bit to understand what's the problem was but as it's a 13,5 years old
bug I eventually decided to simply remove the wrong parts. I'll not backport.


> Old error in showPortalPage screen
> --
>
> Key: OFBIZ-13059
> URL: https://issues.apache.org/jira/browse/OFBIZ-13059
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/common
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> I spotted this error in demo stable and trunk error.log. It's due to an old 
> commit: https://svn.apache.org/repos/asf/ofbiz/trunk@1023286 
> I tried a bit to understand what's the problem was but as it's a 13,5 years 
> old bug I eventually decided to simply remove the wrong parts. I'll not 
> backport.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13059) Old error in showPortalPage screen

2024-04-21 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839371#comment-17839371
 ] 

ASF subversion and git services commented on OFBIZ-13059:
-

Commit b212e0f5f0f9041e5ce84fec99fb4fa46d50d910 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b212e0f5f0 ]

Fixed: Old error in showPortalPage screen (OFBIZ-13059)

I spotted this error in demo stable and trunk error.log. It's due to an old
commit: https://svn.apache.org/repos/asf/ofbiz/trunk@1023286

I tried a bit to understand what's the problem was but as it's a 13,5 years old
bug I eventually decided to simply remove the wrong parts. I'll not backport.


> Old error in showPortalPage screen
> --
>
> Key: OFBIZ-13059
> URL: https://issues.apache.org/jira/browse/OFBIZ-13059
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/common
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> I spotted this error in demo stable and trunk error.log. It's due to an old 
> commit: https://svn.apache.org/repos/asf/ofbiz/trunk@1023286 
> I tried a bit to understand what's the problem was but as it's a 13,5 years 
> old bug I eventually decided to simply remove the wrong parts. I'll not 
> backport.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13040) BI-Move from hard-coded menu location to parameterized

2024-04-20 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839330#comment-17839330
 ] 

ASF subversion and git services commented on OFBIZ-13040:
-

Commit b0260c00bf63109744e1973c902fb6eefa989ad6 in ofbiz-plugins's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=b0260c00b ]

Improved: BI-Move from hard-coded menu location to parameterized (OFBIZ-13040) 
(#113)

Move the various menu locations in content screens to parameterized

modified: BiScreens.xml: change menu location

> BI-Move from hard-coded menu location to parameterized
> --
>
> Key: OFBIZ-13040
> URL: https://issues.apache.org/jira/browse/OFBIZ-13040
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Reporter: Pierre Smits
>Priority: Major
>
> Move the various menu locations in content screens to parameterized



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13041) EbayStore-menu location to parameterized

2024-04-20 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839331#comment-17839331
 ] 

ASF subversion and git services commented on OFBIZ-13041:
-

Commit a0531e89a027f78a12d77b92bd5598d8e53415d7 in ofbiz-plugins's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=a0531e89a ]

Improved: EbayStore-menu location to parameterized (OFBIZ-13041) (#114)

* Improved: EbayStore-menu location to parameterized (OFBIZ-13041)

Move the various menu locations in content screens to parameterized

modified: CommonScreens.xml: change menu location

* Improved: EbayStore-menu location to parameterized (OFBIZ-13041)

Move the various menu locations in content screens to parameterized

modified: web.xml added ebayMenuLocation

> EbayStore-menu location to parameterized
> 
>
> Key: OFBIZ-13041
> URL: https://issues.apache.org/jira/browse/OFBIZ-13041
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ebaystore
>Reporter: Pierre Smits
>Priority: Major
>
> Move the various menu locations in content screens to parameterized



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13043) MSG-parameterized menu location

2024-04-20 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839332#comment-17839332
 ] 

ASF subversion and git services commented on OFBIZ-13043:
-

Commit be63ed6c727c341a5ef4679b225092f821ccd453 in ofbiz-plugins's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=be63ed6c7 ]

Improved: MSG - move to parameterized menu location (OFBIZ-13043) (#116)

* Improved: MSG - move to parameterized menu location (OFBIZ-13043)

CommonScreens.xml: change menu location

* correcting typo

> MSG-parameterized menu location
> ---
>
> Key: OFBIZ-13043
> URL: https://issues.apache.org/jira/browse/OFBIZ-13043
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Pierre Smits
>Priority: Major
>
> Move the various menu locations in content screens to parameterized



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12997) Reduce logo size BlueLight theme

2024-04-20 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839201#comment-17839201
 ] 

ASF subversion and git services commented on OFBIZ-12997:
-

Commit 92920c4e8c118181cc4d38533d5b6f120b8ddb8b in ofbiz-framework's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=92920c4e8c ]

Improved: Reduce logo size BlueLight theme (OFBIZ-12997) (#777)

When using the Bluelight theme the size of the default logo is greater than the 
visible 'system notes' lines.
Reducing the height of the logo displayed, increases the visibility of the 
pages useful to user and thus enhance the user experience (less vertical 
scrolling).

modified: header.ftl - added height value

> Reduce logo size BlueLight theme
> 
>
> Key: OFBIZ-12997
> URL: https://issues.apache.org/jira/browse/OFBIZ-12997
> Project: OFBiz
>  Issue Type: Improvement
>  Components: theme/bluelight
>Reporter: Pierre Smits
>Priority: Major
>
> When using the Bluelight theme the size of the default logo is greater than 
> the visible 'system notes' lines.
> Reducing the height of the logo displayed, increases the visibility of the 
> pages useful to user and thus enhance the user experience (less vertical 
> scrolling).
> The height of the OFBiz logo is 117 px, reducing the visibility height to 
> about 60px would do the trick.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12994) Convert Invoice relation screen to dynamic Compound

2024-04-19 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839200#comment-17839200
 ] 

ASF subversion and git services commented on OFBIZ-12994:
-

Commit 4f1bde0540495b80cef25c9cf88c05a294af3800 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=4f1bde0540 ]

Fixed: invoiceOverview generates an error (OFBIZ-13017)

Fixes the problem by replacing replacing all invoiceOverview occurrences in
OFBiz by ViewInvoice. There are no longer other occurrences of "invoiceOverview"

This is a maybe temporary workaround. Possibly more is needed as we want to use
AccountingInvoiceCpd.xml and related changes that were introduced with
OFBIZ-12994. I suppose it's enough for the moment since it does not introduce
other changes.

As she proposed me, I have asked Leïla to have a look because she knows that
more than me having worked on OFBIZ-12994. Maybe a complete refactor is needed.


> Convert Invoice relation screen to dynamic Compound
> ---
>
> Key: OFBIZ-12994
> URL: https://issues.apache.org/jira/browse/OFBIZ-12994
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting/invoice
>Affects Versions: Upcoming Branch
>Reporter: Mekika Leila
>Assignee: Mekika Leila
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> After the work on the task OFBIZ-11808, and the migration started for 
> workeffort screens on OFBIZ-12292, the purpose is to migrate all screen 
> linked to Invoice entity with idea to reduce the code and use widget 
> improvement developped last years
> This migration cover invoice related screens from invoiceOverview to 
> managment screens and forms for each invoice sub item such as:
>  - Applications
>  - Attributes
>  - ContactMech
>  - Content
>  - Item
>  - Note
>  - Role
>  - Status
>  - Term
>  - TimeEntry
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13017) invoiceOverview generates an error

2024-04-19 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839199#comment-17839199
 ] 

ASF subversion and git services commented on OFBIZ-13017:
-

Commit 4f1bde0540495b80cef25c9cf88c05a294af3800 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=4f1bde0540 ]

Fixed: invoiceOverview generates an error (OFBIZ-13017)

Fixes the problem by replacing replacing all invoiceOverview occurrences in
OFBiz by ViewInvoice. There are no longer other occurrences of "invoiceOverview"

This is a maybe temporary workaround. Possibly more is needed as we want to use
AccountingInvoiceCpd.xml and related changes that were introduced with
OFBIZ-12994. I suppose it's enough for the moment since it does not introduce
other changes.

As she proposed me, I have asked Leïla to have a look because she knows that
more than me having worked on OFBIZ-12994. Maybe a complete refactor is needed.


> invoiceOverview generates an error
> --
>
> Key: OFBIZ-13017
> URL: https://issues.apache.org/jira/browse/OFBIZ-13017
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Reporter: Pierre Smits
>Priority: Major
>
> see 
> https://demo-trunk.ofbiz.apache.org/accounting/control/invoiceOverview?invoiceId=demo10001



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-10111) The child event added is not listed in the Child Work Efforts. While if we add an existing event it is listed in the WorkEffort component

2024-04-18 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838685#comment-17838685
 ] 

ASF subversion and git services commented on OFBIZ-10111:
-

Commit 99a7c0c265a50b42df64b0b31de692903fa30ee3 in ofbiz-framework's branch 
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=99a7c0c265 ]

Fixed: The child event added is not listed in the Child Work Efforts. 
(OFBIZ-10111)
While if we add an existing event it is listed in the WorkEffort component

Quick-fix patch of the duplicate banner issue. Since the banner is somehow
printed twice due to nesting forms, which needs some deeper analysis

Thanks: Priya Sharma


> The child event added is not listed in the Child Work Efforts. While if we 
> add an existing event it is listed in the WorkEffort component
> -
>
> Key: OFBIZ-10111
> URL: https://issues.apache.org/jira/browse/OFBIZ-10111
> Project: OFBiz
>  Issue Type: Bug
>  Components: workeffort
>Reporter: Rubia Elza Joshep
>Assignee: Priya Sharma
>Priority: Major
> Fix For: 18.12.13
>
> Attachments: OFBIZ-10111.patch, OFBIZ-10111.patch, child-2.png, 
> child.png, screenshot-1.png
>
>
> Steps to regenerate:
> 1) Open URL [https://demo-trunk.ofbiz.apache.org/sfa/control/Events]
> 2) Click on the event created.
> 3) To create the child events, click on the "Children" button.
> 4) Click on "Add New WorkEffort Child" button. Create a new child event. Fill 
> in the details of the child events. Click on the Save button.
> Actual: The child event added is not listed in the Child Work Efforts. While 
> if we add an existing event it is listed.
> 5) Open URL 
> [https://demo-trunk.ofbiz.apache.org/workeffort/control/AddWorkEffortAndAssoc?workEffortIdFrom=10001]
> 6) "Enter an existing workEffortId below, OR enter the WorkEffort Details 
> below" label is repeated twice.
> Note: ScreenShot Attached.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13039) dateType parameter not existing in "renderDateTimeField" Macro

2024-04-18 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838686#comment-17838686
 ] 

ASF subversion and git services commented on OFBIZ-13039:
-

Commit dbb945a4291599221cc12ced290d10f865d58557 in ofbiz-framework's branch 
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=dbb945a429 ]

Fixed: dateType parameter not existing in "renderDateTimeField" Macro  
(OFBIZ-13039)

Removes dateType parameter from "renderDateTimeField" Macro in
TextFormMacroLibrary.ftl


> dateType parameter not existing in "renderDateTimeField" Macro 
> ---
>
> Key: OFBIZ-13039
> URL: https://issues.apache.org/jira/browse/OFBIZ-13039
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: 18.12.13
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.13
>
>
> freemarker.core._MiscTemplateException: Macro "renderDateTimeField" has no 
> parameter with name "dateType". Valid parameter names are: name, className, 
> timeDropdownParamName, defaultDateTimeString, localizedIconTitle, 
> timeHourName, timeMinutesName, ampmName, compositeType, alert, isTimeType, 
> isDateType, amSelected, pmSelected, timeDropdown, classString, isTwelveHour, 
> hour1, hour2, minutes, shortDateInput, title, value, size, maxlength, id, 
> formName, mask, event, action, step, timeValues, tabindex, disabled, 
> isXMLHttpRequest
> 
> FTL stack trace ("~" means nesting-related):
>   - Failed at: @htmlTemplate.renderDateTimeField eve...  [in template 
> "component://ecommerce/template/catalog/ProductDetail.ftl" at line 726, 
> column 17]
> 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13039) dateType parameter not existing in "renderDateTimeField" Macro

2024-04-18 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838681#comment-17838681
 ] 

ASF subversion and git services commented on OFBIZ-13039:
-

Commit 0362c1917cf7f8d68c5b73e30ad1be0efbbfac90 in ofbiz-plugins's branch 
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=0362c1917 ]

Fixed: dateType parameter not existing in "renderDateTimeField" Macro  
(OFBIZ-13039)

Removes dateType parameter from "renderDateTimeField" Macro in
ProductDetail.ftl
EditShoppingList.ftl
EditTaskAndAssoc.ftl
ListSurveys.ftl


> dateType parameter not existing in "renderDateTimeField" Macro 
> ---
>
> Key: OFBIZ-13039
> URL: https://issues.apache.org/jira/browse/OFBIZ-13039
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: 18.12.13
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.13
>
>
> freemarker.core._MiscTemplateException: Macro "renderDateTimeField" has no 
> parameter with name "dateType". Valid parameter names are: name, className, 
> timeDropdownParamName, defaultDateTimeString, localizedIconTitle, 
> timeHourName, timeMinutesName, ampmName, compositeType, alert, isTimeType, 
> isDateType, amSelected, pmSelected, timeDropdown, classString, isTwelveHour, 
> hour1, hour2, minutes, shortDateInput, title, value, size, maxlength, id, 
> formName, mask, event, action, step, timeValues, tabindex, disabled, 
> isXMLHttpRequest
> 
> FTL stack trace ("~" means nesting-related):
>   - Failed at: @htmlTemplate.renderDateTimeField eve...  [in template 
> "component://ecommerce/template/catalog/ProductDetail.ftl" at line 726, 
> column 17]
> 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13039) dateType parameter not existing in "renderDateTimeField" Macro

2024-04-18 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838679#comment-17838679
 ] 

ASF subversion and git services commented on OFBIZ-13039:
-

Commit bf39374c0a0086e7a29e7d7b8bf0056dd90b4e8b in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=bf39374c0a ]

Fixed: dateType parameter not existing in "renderDateTimeField" Macro  
(OFBIZ-13039)

Removes dateType parameter from "renderDateTimeField" Macro in
TextFormMacroLibrary.ftl


> dateType parameter not existing in "renderDateTimeField" Macro 
> ---
>
> Key: OFBIZ-13039
> URL: https://issues.apache.org/jira/browse/OFBIZ-13039
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: 18.12.13
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.13
>
>
> freemarker.core._MiscTemplateException: Macro "renderDateTimeField" has no 
> parameter with name "dateType". Valid parameter names are: name, className, 
> timeDropdownParamName, defaultDateTimeString, localizedIconTitle, 
> timeHourName, timeMinutesName, ampmName, compositeType, alert, isTimeType, 
> isDateType, amSelected, pmSelected, timeDropdown, classString, isTwelveHour, 
> hour1, hour2, minutes, shortDateInput, title, value, size, maxlength, id, 
> formName, mask, event, action, step, timeValues, tabindex, disabled, 
> isXMLHttpRequest
> 
> FTL stack trace ("~" means nesting-related):
>   - Failed at: @htmlTemplate.renderDateTimeField eve...  [in template 
> "component://ecommerce/template/catalog/ProductDetail.ftl" at line 726, 
> column 17]
> 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13039) dateType parameter not existing in "renderDateTimeField" Macro

2024-04-18 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838677#comment-17838677
 ] 

ASF subversion and git services commented on OFBIZ-13039:
-

Commit 4de5d7bf7e3f077cc81bd1d62bb1848c83c9392b in ofbiz-plugins's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=4de5d7bf7 ]

Fixed: dateType parameter not existing in "renderDateTimeField" Macro  
(OFBIZ-13039)

Removes dateType parameter from "renderDateTimeField" Macro in
ProductDetail.ftl
EditShoppingList.ftl
EditTaskAndAssoc.ftl
ListSurveys.ftl


> dateType parameter not existing in "renderDateTimeField" Macro 
> ---
>
> Key: OFBIZ-13039
> URL: https://issues.apache.org/jira/browse/OFBIZ-13039
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: 18.12.13
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.13
>
>
> freemarker.core._MiscTemplateException: Macro "renderDateTimeField" has no 
> parameter with name "dateType". Valid parameter names are: name, className, 
> timeDropdownParamName, defaultDateTimeString, localizedIconTitle, 
> timeHourName, timeMinutesName, ampmName, compositeType, alert, isTimeType, 
> isDateType, amSelected, pmSelected, timeDropdown, classString, isTwelveHour, 
> hour1, hour2, minutes, shortDateInput, title, value, size, maxlength, id, 
> formName, mask, event, action, step, timeValues, tabindex, disabled, 
> isXMLHttpRequest
> 
> FTL stack trace ("~" means nesting-related):
>   - Failed at: @htmlTemplate.renderDateTimeField eve...  [in template 
> "component://ecommerce/template/catalog/ProductDetail.ftl" at line 726, 
> column 17]
> 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13038) HUMANRES- PersonTrainingScreens

2024-04-18 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838670#comment-17838670
 ] 

ASF subversion and git services commented on OFBIZ-13038:
-

Commit b059bc2769b8f87f9433d3a33c19eda45b9eebf4 in ofbiz-framework's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b059bc2769 ]

Improved: HUMANRES-PersonTrainingScreens (OFBIZ-13038) (#776)

modified:
PersonTrainingScreens.xml. changed menu location from hard-coded to 
parameterized

> HUMANRES- PersonTrainingScreens
> ---
>
> Key: OFBIZ-13038
> URL: https://issues.apache.org/jira/browse/OFBIZ-13038
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: humanres
>Reporter: Pierre Smits
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-10111) The child event added is not listed in the Child Work Efforts. While if we add an existing event it is listed in the WorkEffort component

2024-04-18 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838650#comment-17838650
 ] 

ASF subversion and git services commented on OFBIZ-10111:
-

Commit c881db6b70a49312d4b894f609ef628b112c783b in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=c881db6b70 ]

Fixed: The child event added is not listed in the Child Work Efforts. 
(OFBIZ-10111)
While if we add an existing event it is listed in the WorkEffort component

Quick-fix patch of the duplicate banner issue. Since the banner is somehow
printed twice due to nesting forms, which needs some deeper analysis

Thanks: Priya Sharma


> The child event added is not listed in the Child Work Efforts. While if we 
> add an existing event it is listed in the WorkEffort component
> -
>
> Key: OFBIZ-10111
> URL: https://issues.apache.org/jira/browse/OFBIZ-10111
> Project: OFBiz
>  Issue Type: Bug
>  Components: workeffort
>Reporter: Rubia Elza Joshep
>Assignee: Priya Sharma
>Priority: Major
> Attachments: OFBIZ-10111.patch, OFBIZ-10111.patch, child-2.png, 
> child.png, screenshot-1.png
>
>
> Steps to regenerate:
> 1) Open URL [https://demo-trunk.ofbiz.apache.org/sfa/control/Events]
> 2) Click on the event created.
> 3) To create the child events, click on the "Children" button.
> 4) Click on "Add New WorkEffort Child" button. Create a new child event. Fill 
> in the details of the child events. Click on the Save button.
> Actual: The child event added is not listed in the Child Work Efforts. While 
> if we add an existing event it is listed.
> 5) Open URL 
> [https://demo-trunk.ofbiz.apache.org/workeffort/control/AddWorkEffortAndAssoc?workEffortIdFrom=10001]
> 6) "Enter an existing workEffortId below, OR enter the WorkEffort Details 
> below" label is repeated twice.
> Note: ScreenShot Attached.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-18 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838641#comment-17838641
 ] 

ASF subversion and git services commented on OFBIZ-13035:
-

Commit ae3ac360bbeedc064668e85de80c2e2228417e85 in ofbiz-plugins's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=ae3ac360b ]

Improved: fix cross-app menu location issues (OFBIZ-13035) (#112)

modified: projectmgr/web.xml
added profileMenuLocation

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-18 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838521#comment-17838521
 ] 

ASF subversion and git services commented on OFBIZ-13035:
-

Commit ab35d4a751345956a6299f511053771c174ae351 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=ab35d4a751 ]

Revert "Fixed: Fix cross-app menu location issues (OFBIZ-13035)"

This reverts wrong commit 0af9b20422d13d6d2641ad344779fc73dd8cd266.


> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-18 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838515#comment-17838515
 ] 

ASF subversion and git services commented on OFBIZ-13035:
-

Commit 0af9b20422d13d6d2641ad344779fc73dd8cd266 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=0af9b20422 ]

Fixed: Fix cross-app menu location issues (OFBIZ-13035)

The GroupUpdate menu was missing in SfaMenus.xm. This adds it


> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13024) Make theme variants visible in demo sites

2024-04-18 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838497#comment-17838497
 ] 

ASF subversion and git services commented on OFBIZ-13024:
-

Commit b63b3e8a6602c40d3ffb863733e9eb9d546240ad in ofbiz-framework's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b63b3e8a66 ]

Improved: Make theme variants visible in demo sites (OFBIZ-13024) (#756)

* Improved: Make theme variants visible in demo sites (OFBIZ-13024)

Currently we have 58 UserLogin records in demo data, and 12 back-office 
VisualTheme records in our demo data sets.
In order to have more visibilities of the various themes, we should set for 
various UserLogins the theme as a preference.

modified: PartyDemoData.xml
- added UserPreference records relating to themes

* Update PartyDemoData.xml

Removes one of the bizadmin duplicates.

-

Co-authored-by: Jacques Le Roux 

> Make theme variants visible in demo sites
> -
>
> Key: OFBIZ-13024
> URL: https://issues.apache.org/jira/browse/OFBIZ-13024
> Project: OFBiz
>  Issue Type: Bug
>  Components: datamodel
>Reporter: Pierre Smits
>Priority: Major
>
> Currently we have 58 UserLogin records in demo data, and 12 back-office 
> VisualTheme records in our demo data sets.
> In order to have more visibilities of the various themes, we should set for 
> various UserLogins   the theme as a preference.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13034) ACC- have TaxAuthorityMenus parameterized

2024-04-17 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838258#comment-17838258
 ] 

ASF subversion and git services commented on OFBIZ-13034:
-

Commit 0249185d539bd7b057542de09005da3a3723742d in ofbiz-framework's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=0249185d53 ]

Improved: ACC- have TaxAuthorityMenus parameterized (OFBIZ-13034) (#767)

Move the menus from hard-coded to parameterized

modified:
- AccountingMenus.xml: added TaxAuthority men(s)
- TaxAuthorityScreens.xml: changed menu location from hard-coded to 
parameterized

deleted:
- TaxAuthorityMenus.xml

> ACC- have TaxAuthorityMenus parameterized
> -
>
> Key: OFBIZ-13034
> URL: https://issues.apache.org/jira/browse/OFBIZ-13034
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> Move the menus from hard-coded to parameterized



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12947) CATALOG - Move from hard-code menu location to parameterized

2024-04-17 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838254#comment-17838254
 ] 

ASF subversion and git services commented on OFBIZ-12947:
-

Commit d46cac29c03088326c0d050ae187d16f436229fc in ofbiz-framework's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=d46cac29c0 ]

Improved: CATALOG - Move from hard-code menu location to parameterized 
(OFBIZ-12947) (#766)

CATALOG - Move from hard-code menu location to parameterized
modified:
CatalogMenus.xml: added subscription menus
SubscriptionScreens.xml: changed menu location(s) from hard-coded to 
parameterized

deleted:
SubscriptionMenus.xml

> CATALOG - Move from hard-code menu location to parameterized
> 
>
> Key: OFBIZ-12947
> URL: https://issues.apache.org/jira/browse/OFBIZ-12947
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> Move the menu location in the various catalog screens from hard-coded to 
> parameterized.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12976) FACILITY- Move from hard-coded menu location to parameterized

2024-04-17 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838253#comment-17838253
 ] 

ASF subversion and git services commented on OFBIZ-12976:
-

Commit 98d2b78bece10ac2ddea7e75bcb66dd4aa7276fc in ofbiz-framework's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=98d2b78bec ]

Improved: FACILITY- Move from hard-coded menu location to parameterized 
(OFBIZ-12976) (#758)

Improved: FACILITY- Move from hard-coded menu location to parameterized 
(OFBIZ-12976)

Move the menu location in the various facility screens from hard-coded to 
parameterized.

modified: CommonScreens.xml, FacilityGroupScreens.xml, FacilityScreens.xml
changed location of various menus from hard-coded to parameterized

modified:
- FacilitiesMenus.xml: added menus re shipment
- ShipmentScreens.xml: changed location of menus from hard-coded to 
parameterized

Improved: Move the menu location in the various facility screens from 
hard-coded to parameterized. (OFBIZ-12976)

removed: ShipmentMenus.xml

> FACILITY- Move from hard-coded menu location to parameterized
> -
>
> Key: OFBIZ-12976
> URL: https://issues.apache.org/jira/browse/OFBIZ-12976
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product/facility
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> Move the menu location in the various facility screens from hard-coded to 
> parameterized.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12943) SFA - Move from hard-code menu location to parameterized

2024-04-17 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838207#comment-17838207
 ] 

ASF subversion and git services commented on OFBIZ-12943:
-

Commit a5e3c75abcf4e0dd0f7cf99cbcb2ce086c82d648 in ofbiz-framework's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a5e3c75abc ]

Improved: SFA - Move from hard-code menu location to parameterized 
(OFBIZ-12943) (#775)

Move the menu location in the various sfa screens from hardcoded to 
parameterized.

modified:
menu location from hard-coded to parameterized in AccountScreens.xml, 
CommonScreens.xml, ContactScreens.xml, ForecastScreens.xml, LeadScreens.xml

> SFA - Move from hard-code menu location to parameterized
> 
>
> Key: OFBIZ-12943
> URL: https://issues.apache.org/jira/browse/OFBIZ-12943
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: marketing/sfa
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> Move the menu location in the various sfa screens from hardcoded to 
> parameterized.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13037) SFA - labels

2024-04-17 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838012#comment-17838012
 ] 

ASF subversion and git services commented on OFBIZ-13037:
-

Commit f6208bcbcb7d09ed032683116166aab063c94425 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=f6208bcbcb ]

Improved: SFA MainActionMenu and labels (OFBIZ-13037)

Adds few French labels


> SFA - labels
> 
>
> Key: OFBIZ-13037
> URL: https://issues.apache.org/jira/browse/OFBIZ-13037
> Project: OFBiz
>  Issue Type: Improvement
>  Components: marketing/sfa
>Reporter: Pierre Smits
>Priority: Major
>
> improve sfa labels



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13037) SFA - labels

2024-04-17 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838008#comment-17838008
 ] 

ASF subversion and git services commented on OFBIZ-13037:
-

Commit 6a8595347b123fe8ab8c264058b00bfe4aed8278 in ofbiz-framework's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=6a8595347b ]

Improved: SFA MainActionMenu and labels (OFBIZ-13037) (#772)

modified:
MarketingUiLabels.xml: improved dutch translations, added SfaNewLead
SfaMenus.xml: added menu-item NewLead, corrected titles
PartyUiLabels.xml: improved dutch translation

correcting typo

> SFA - labels
> 
>
> Key: OFBIZ-13037
> URL: https://issues.apache.org/jira/browse/OFBIZ-13037
> Project: OFBiz
>  Issue Type: Improvement
>  Components: marketing/sfa
>Reporter: Pierre Smits
>Priority: Major
>
> improve sfa labels



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13036) Fix form/grid issues in screens

2024-04-17 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837994#comment-17837994
 ] 

ASF subversion and git services commented on OFBIZ-13036:
-

Commit 718da0a50d8c3d834f27726a92bd80716f84400d in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=718da0a50d ]

Fixed: Fix form/grid issues in screens (OFBIZ-13036)

modified: EventScreens.xml: MyTasks is a grid not a form


> Fix form/grid issues in screens
> ---
>
> Key: OFBIZ-13036
> URL: https://issues.apache.org/jira/browse/OFBIZ-13036
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> 18.12 is not affected



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12969) MyPortal - Move from hard-coded menu location to parameterized

2024-04-16 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837815#comment-17837815
 ] 

ASF subversion and git services commented on OFBIZ-12969:
-

Commit 72b14dd39d9334aa10b50a1731fa416b8d3735c9 in ofbiz-plugins's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=72b14dd39 ]

Implemented: MyPortal - Move from hard-coded menu location to parameterized 
(OFBIZ-12969)

Adds missing timesheetMenuLocation in web.xml


> MyPortal - Move from hard-coded menu location to parameterized
> --
>
> Key: OFBIZ-12969
> URL: https://issues.apache.org/jira/browse/OFBIZ-12969
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: myportal
>Reporter: Pierre Smits
>Priority: Major
>
> Move the menu location in the various my portal screens from hard-coded to 
> parameterized.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-16 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837758#comment-17837758
 ] 

ASF subversion and git services commented on OFBIZ-13035:
-

Commit a9d7857c5e1b94b3066debaa6365ee2f1209b115 in ofbiz-plugins's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=a9d7857c5 ]

Improved:cross-app memu location issues (OFBIZ-13035) (#110)

* Improved:cross-app memu location issues (OFBIZ-13035)

address cross application menu-location issues.

modified:
in SCRUM: web.xml - add context-param for profileMenuLocation

* Improved:cross-app memu location issues (OFBIZ-13035)

address cross application menu-location issues.

modified:
in PROJECT: web.xml - add context-param for requestMenuLocation

* Improved:cross-app memu location issues (OFBIZ-13035)

address cross application menu-location issues.

modified:
in MYPORTAL: web.xml - add context-param for profiletMenuLocation

* Improved: Fix cross-app menu location issues (FBIZ-13035)

address cross application menu-location issues.

Plugins use the timesheet functionality from the workeffort component. Given 
that base approval should be in the workeffort component, duplicate menus in 
plugins should reside in workeffort

modified:
- Project/web.xml: added context-param timesheetMenuLocation
- Project/TimeSheetScreens.xml: changed ref and location  regarding timesheet 
actions
- Scrum/web.xml: added context-param timesheetMenuLocation

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Reporter: Pierre Smits
>Priority: Major
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12973) Have timesheetMenuLocation

2024-04-16 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837725#comment-17837725
 ] 

ASF subversion and git services commented on OFBIZ-12973:
-

Commit 2721a78b4d1544e6035098ef1f7d277eb0a7d7f1 in ofbiz-framework's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=2721a78b4d ]

Improved: Have timesheetMenuLocation (OFBIZ-12973) (#768)

* Improved: Have timesheetMenuLocation (OFBIZ-12973)

Timesheet screens are used in other components c.q. applications as 
PortalPagePortlets. Thus requiring a separate MenuLocation in web.xml

modified: in WORKEFFORT
- web.xml: added context-param timesheetMenuLocation
- CommonScreens.xml: changed menu location from hard-coded to parameterized
- WorkEffoortMenus.xml: added TimeSheetTabBar

removed: TimesheetMenus.xml

* correcting typo

> Have timesheetMenuLocation
> --
>
> Key: OFBIZ-12973
> URL: https://issues.apache.org/jira/browse/OFBIZ-12973
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: workeffort
>Reporter: Pierre Smits
>Priority: Major
>
> Timesheet screens are used in other components c.q. applications as 
> PortalPagePortlets. Thus requiring a separate MenuLocation in web.xml



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12527) Have a Menu in SFA featuring actions to create the main objects

2024-04-16 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837572#comment-17837572
 ] 

ASF subversion and git services commented on OFBIZ-12527:
-

Commit ece6bd7b343c3a8eb9329e09ec5702a700ffca1c in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=ece6bd7b34 ]

Improved: Have a Menu in SFA featuring actions to create the main objects 
(OFBIZ-12527)

Adds 2 French labels


> Have a Menu in SFA featuring actions to create the main objects
> ---
>
> Key: OFBIZ-12527
> URL: https://issues.apache.org/jira/browse/OFBIZ-12527
> Project: OFBiz
>  Issue Type: Improvement
>  Components: marketing/sfa
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: consistency, menus, sfa, usability, ux
>
> Currently the create buttons for the main objects of the SFA application are 
> located within find and profile widgets/templates of those objects.
> In order to improve the usability of this application, OFBiz and thus the 
> appeal of it for adopters and users, these create buttons/links/etc. should 
> be in a main action menu visible at all times when a user with CREATE 
> permissions is working within the application



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12527) Have a Menu in SFA featuring actions to create the main objects

2024-04-16 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837549#comment-17837549
 ] 

ASF subversion and git services commented on OFBIZ-12527:
-

Commit 929a66c054b2b0f9246d58473cc9d9f354d735c6 in ofbiz-framework's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=929a66c054 ]

Improved: Have a Menu in SFA featuring actions to create the main objects 
(OFBIZ-12527) (#760)

Currently the create buttons for the main objects of the SFA application are 
located within find and profile widgets/templates of those objects.
In order to improve the usability of this application, OFBiz and thus the 
appeal of it for adopters and users, these create buttons/links/etc. should be 
in a main action menu visible at all times when a user with CREATE permissions 
is working within the application

modified:
- SfaMenus.xml - Added menu MainActionMenu
- included MainActionMenu in various screens to ensure that it is visible to 
user with CREATE permissions

> Have a Menu in SFA featuring actions to create the main objects
> ---
>
> Key: OFBIZ-12527
> URL: https://issues.apache.org/jira/browse/OFBIZ-12527
> Project: OFBiz
>  Issue Type: Improvement
>  Components: marketing/sfa
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: consistency, menus, sfa, usability, ux
>
> Currently the create buttons for the main objects of the SFA application are 
> located within find and profile widgets/templates of those objects.
> In order to improve the usability of this application, OFBiz and thus the 
> appeal of it for adopters and users, these create buttons/links/etc. should 
> be in a main action menu visible at all times when a user with CREATE 
> permissions is working within the application



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13025) Reduce code complexity re marketing menus

2024-04-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837407#comment-17837407
 ] 

ASF subversion and git services commented on OFBIZ-13025:
-

Commit 1f5ac53afc3feb8b671b1c9df27fef317dce7156 in ofbiz-framework's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=1f5ac53afc ]

Improved: Reduce code complexity re marketing menus (OFBIZ-13025) (#757)

* Improved: Reduce code complexity re marketing menus (OFBIZ-13025)

Currently, we have in the marketing component/application - besides the main 
menus (in MarketingMenus.xml, menus for specific screens/functions in:
* ContactListMenus.xml: 2 menus, with resp. 5 and 2 menu-items; used in 
ContactListScreens.xml
* DataSourcesMenus.xml: 1 menu, with 2 menu-items; used in DataSourceScreens.xml
* MarketingCampaignMenus.xml: 1 menu, with 2 menu-items; used in 
MarketingCampaignScreens.xml
*SegmentMenus.xml: 1 menu, with 4 menu-items; used in 
SegmentScreens.xml*TrackingCodeMenus.xml: 1 menu, with 4 menu-items, used in 
TrackingCodeScreens.xml

We should move the menus in those menu xml file to MarketingMenus.xml (and 
adjust the location references in the appropriate screens) to reduce code 
complexity and enhance the developer experience.

modified:
* MarketingMenus.xml: added menus, ContactListTabBar, ContactListComBar, 
DataSourceTabBar, MarketingCampaignTabBar, SegmentGroupTabBar, 
TrackingCodeTabBar
* CommonScreens.xml, ContactListScreens,xml, DataSoourceScreen.xml, 
MarketingCampaignScreens.xml, SegmentScreens.xml, TrackingCodeScreens.xml: 
changed menu location from hardcoded to parameterized

deleted: ContactListMenus.xml, DataSourceMenus.xml, MarketingCampaignMenus.xml, 
SegmentMenus.xml, TrackingCodeMenus.xml

* correcting typo

> Reduce code complexity re marketing menus
> -
>
> Key: OFBIZ-13025
> URL: https://issues.apache.org/jira/browse/OFBIZ-13025
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: marketing/marketing
>Reporter: Pierre Smits
>Priority: Major
>
> Currently, we have in the marketing component/application - besides the main 
> menus (in MarketingMenus.xml, menus for specific screens/functions in:
> * ContactListMenus.xml: 2 menus, with resp. 5 and 2 menu-items; used in 
> ContactListScreens.xml
> * DataSourcesMenus.xml: 1 menu, with 2 menu-items; used in 
> DataSourceScreens.xml
> * MarketingCampaignMenus.xml: 1 menu, with 2 menu-items; used in 
> MarketingCampaignScreens.xml
> * SegmentMenus.xml: 1 menu, with 4 menu-items; used in SegmentScreens.xml
> * TrackingCodeMenus.xml: 1 menu, with 4 menu-items, used in 
> TrackingCodeScreens.xml
> We should move the menus in those menu xml file to MarketingMenus.xml (and 
> adjust the location references in the appropriate screens) to reduce code 
> complexity and enhance the developer experience.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13032) Improve dutch labels

2024-04-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837346#comment-17837346
 ] 

ASF subversion and git services commented on OFBIZ-13032:
-

Commit e740f56701a9e0a970f89415c962ac37ae2d5570 in ofbiz-framework's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=e740f56701 ]

Improved: improve Dutch labels (OFBIZ-13032) (#765)

* Improved: Improve dutch label (OFBIZ-13032)

modified AccountingUiLabels.xml, CommonUiLabels.xml
- AccountingInvoicesDueSoon
- WebTools

* Improved: improve Dutch labels (OFBIZ-13032)

AccountingOutstanding added

modified: AccountingUiLabels.xml, InvoiceForrms.xml

> Improve dutch labels
> 
>
> Key: OFBIZ-13032
> URL: https://issues.apache.org/jira/browse/OFBIZ-13032
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting, webtools
>Reporter: Pierre Smits
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13032) Improve dutch labels

2024-04-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837309#comment-17837309
 ] 

ASF subversion and git services commented on OFBIZ-13032:
-

Commit c9d15e5af7cbb77c5dbe135b5e319d0def0bebdb in ofbiz-framework's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=c9d15e5af7 ]

Improved: Improve dutch label (OFBIZ-13032) (#764)

modified AccountingUiLabels.xml, CommonUiLabels.xml
- AccountingInvoicesDueSoon
- WebTools

> Improve dutch labels
> 
>
> Key: OFBIZ-13032
> URL: https://issues.apache.org/jira/browse/OFBIZ-13032
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting, webtools
>Reporter: Pierre Smits
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-11067) Migrate integration tests to unit tests when possible

2024-04-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837285#comment-17837285
 ] 

ASF subversion and git services commented on OFBIZ-11067:
-

Commit 739c02563fdadb00df0849521a82eca5c13449c4 in ofbiz-framework's branch 
refs/heads/trunk from Gil Portenseigne
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=739c02563f ]

Fixed: Migrate integration tests to unit tests when possible (OFBIZ-11067)

Move unit test that are not currently running.
Make those tests pass, adding a TODO, where an object reference
comparison was done.

Thanks Gaëtan for your contribution


> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Mathieu Lirzin
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: 
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch, 
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch, 
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch, 
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch, 
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch, 
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch, 
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch, 
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch, 
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch, 
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch, 
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch, 
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch, 
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch, 
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch, 
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch, 
> OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch, 
> OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch, 
> OFBIZ-11067_0018-Turn-UtilObjectTests-into-a-unit-test-class.patch, 
> OFBIZ-11067_0019-Merge-UtilObjectUnitTest-into-UtilObjectTes.patch, 
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests-1.patch,
>  
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests.patch,
>  
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests-1.patch,
>  
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests.patch,
>  
> Patch_with_FlexibleMapAccessorTests_included_that_was_forgotten_in_the_previous_patch.patch
>
>
> In OFBiz there are both unit tests and integration tests which are 
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}. 
> However some integration tests are in fact unit tests that doesn't depend on 
> the entity and service engines. Those unit tests should run on the their 
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3 
> which is what is done for the integration test suite.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13031) MyCommSubTabBar is missing in SFA

2024-04-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837267#comment-17837267
 ] 

ASF subversion and git services commented on OFBIZ-13031:
-

Commit a0bf0d99e05ea51f40898ebfbb72dd293dd61ebe in ofbiz-framework's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a0bf0d99e0 ]

FIxed: MyCommSubTabBar is missing in SFA (OFBIZ-13031) (#763)

* FIxed: MyCommSubTabBar is missing in SFA (OFBIZ-13031)

Party CommunicationEventScreens are also referenced in SFA

modified: CommunicationEventScreens.xml
changed menu location from mainMenuLocation to communicationMenuLocation

* FIxed: MyCommSubTabBar is missing in SFA (OFBIZ-13031)

Party CommunicationEventScreens are also referenced in SFA

modified: CommunicationEventScreens.xml OpportunityScreens.xml
- changed menu location from mainMenuLocation to communicationMenuLocation

> MyCommSubTabBar is missing in SFA
> -
>
> Key: OFBIZ-13031
> URL: https://issues.apache.org/jira/browse/OFBIZ-13031
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: sfa
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> java.lang.RuntimeException: Error rendering included menu named 
> [MyCommSubTabBar] at location 
> [component://marketing/widget/sfa/SfaMenus.xml]: 
> java.lang.IllegalArgumentException: Could not find menu with name 
> [MyCommSubTabBar] in location [component://marketing/widget/sfa/SfaMenus.xml]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13030) TAX - set correct decorator

2024-04-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837154#comment-17837154
 ] 

ASF subversion and git services commented on OFBIZ-13030:
-

Commit 2fc7302f4310029d617ebcb4e5c2e882f9eb578a in ofbiz-framework's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=2fc7302f43 ]

Improved: TAX - set correct decorator (OFBIZ-13030) (#762)

With the move of the tax authorities menu-item (OFBIZ-13026), the decorator 
needs modification

modified: TaxAuthorityScreens.xml
- changed decorator-screen name

> TAX - set correct decorator
> ---
>
> Key: OFBIZ-13030
> URL: https://issues.apache.org/jira/browse/OFBIZ-13030
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Reporter: Pierre Smits
>Priority: Major
>
> With the move of the tax authorities menu-item (OFBIZ-13026), the decorator 
> needs modification



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13026) Have 'Tax Authority' menu item in GlobalGLSettingMenus

2024-04-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837155#comment-17837155
 ] 

ASF subversion and git services commented on OFBIZ-13026:
-

Commit 2fc7302f4310029d617ebcb4e5c2e882f9eb578a in ofbiz-framework's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=2fc7302f43 ]

Improved: TAX - set correct decorator (OFBIZ-13030) (#762)

With the move of the tax authorities menu-item (OFBIZ-13026), the decorator 
needs modification

modified: TaxAuthorityScreens.xml
- changed decorator-screen name

> Have 'Tax Authority' menu item in GlobalGLSettingMenus
> --
>
> Key: OFBIZ-13026
> URL: https://issues.apache.org/jira/browse/OFBIZ-13026
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> In order to enhance the UX of users of the accounting application, the 
> TaxAuthorities should move into the GlobalGLSettingMenus.
> The motivation for this are that:
> * TaxAuthority functionality is applicable to all internal organisations with 
> accounting set up, for which we have the GlobalGLSettingMenus;
> * It reduces distractions for users that do day-to-day accounting activities 
> regarding:
> * search/finding gl transactions, invoices and payments
> * creating, reviewing, updating gl transactions, invoices and payments



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13029) MFG - fix path mainMenuLocation

2024-04-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837151#comment-17837151
 ] 

ASF subversion and git services commented on OFBIZ-13029:
-

Commit 3dffe0f9652838aeb1b4479d9d7414b88907cee3 in ofbiz-framework's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=3dffe0f965 ]

Improved: MFG - fix mainMenuLocation (OFBIZ-13029 (#761)

Manufacturing menus are in a subfolder under widgeet

modified: web.xml
- corrected param value of mainMenuLocation

> MFG - fix path mainMenuLocation
> ---
>
> Key: OFBIZ-13029
> URL: https://issues.apache.org/jira/browse/OFBIZ-13029
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing
>Reporter: Pierre Smits
>Priority: Major
>
> menus are in a subfolder under widgets. That tricked me.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13026) Have 'Tax Authority' menu item in GlobalGLSettingMenus

2024-04-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837129#comment-17837129
 ] 

ASF subversion and git services commented on OFBIZ-13026:
-

Commit 6bdf9fb67063cb60a8faa95fc354c3efb110 in ofbiz-framework's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=6bdf9f ]

Improved: Have 'Tax Authority' menu item in GlobalGLSettingMenus (OFBIZ-13026) 
(#759)

In order to enhance the UX of users of the accounting application, the 
TaxAuthorities should move into the GlobalGLSettingMenus.
The motivation for this are that:
TaxAuthority functionality is applicable to all internal organisations with 
accounting set up, for which we have the GlobalGLSettingMenus;
It reduces distractions for users that do day-to-day accounting activities 
regarding:
search/finding gl transactions, invoices and payments
creating, reviewing, updating gl transactions, invoices and payments

modiified: AccountingMenus.xml
- move menu-item 'TaxAuthorities' from menu AccountingAppBar to menu 
GlobalGLSettingMenus

> Have 'Tax Authority' menu item in GlobalGLSettingMenus
> --
>
> Key: OFBIZ-13026
> URL: https://issues.apache.org/jira/browse/OFBIZ-13026
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Reporter: Pierre Smits
>Priority: Major
>
> In order to enhance the UX of users of the accounting application, the 
> TaxAuthorities should move into the GlobalGLSettingMenus.
> The motivation for this are that:
> * TaxAuthority functionality is applicable to all internal organisations with 
> accounting set up, for which we have the GlobalGLSettingMenus;
> * It reduces distractions for users that do day-to-day accounting activities 
> regarding:
> * search/finding gl transactions, invoices and payments
> * creating, reviewing, updating gl transactions, invoices and payments



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13022) EBAY- Move from hard-coded menu location to parameterized

2024-04-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836936#comment-17836936
 ] 

ASF subversion and git services commented on OFBIZ-13022:
-

Commit 33c3449350a6ac0ae94fc6e3b29009f0730d2010 in ofbiz-plugins's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=33c344935 ]

Improved: EBAY- Move from hard-coded menu location to parameterized 
(OFBIZ-13022) (#109)

Move the product menu location in various eBay screens to parameterized

modified:
- web.xml: added context-param productMenuLocation
- CommonScreens.xml:  changed location of ProductTabBar from hard coded to 
parameterized

> EBAY- Move from hard-coded menu location to parameterized
> -
>
> Key: OFBIZ-13022
> URL: https://issues.apache.org/jira/browse/OFBIZ-13022
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product/catalog
>Reporter: Pierre Smits
>Priority: Major
>
> Move the product menu location in various eBay screens to parameterized



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


<    1   2   3   4   5   6   7   8   9   10   >