[jira] [Commented] (OFBIZ-11796) Unnecessary iterations for all productFacilities in setLastInventoryCount

2020-06-08 Thread Arun Patidar (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128210#comment-17128210
 ] 

Arun Patidar commented on OFBIZ-11796:
--

Good catch Suraj !!!



> Unnecessary iterations for all productFacilities in setLastInventoryCount
> -
>
> Key: OFBIZ-11796
> URL: https://issues.apache.org/jira/browse/OFBIZ-11796
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11796.patch
>
>
> In the service setLastInventoryCount, which updates lastInventoryCount for 
> product facility records, it works on inventoryItemDetail changes on 
> availableToPromiseDiff.
> In parameter: InventoryItemId
> So it should be updating productFacilities entertaining both productId and 
> facilityId of same inventoryItemId.
> Currently, it it unnecessary updating all the facilities inventory on a 
> single inventory item update.
> It can be major performance factor on a production system working highly on 
> inventory updates.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11679) OFBiz - Shopify integration plugin

2020-05-26 Thread Arun Patidar (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116553#comment-17116553
 ] 

Arun Patidar commented on OFBIZ-11679:
--

After reading all the details given in task, It seems that all the efforts are 
well planned and designed. Also, If we do any third party integration then it 
always come with defined scope and processes. 
There are rare chances of any changes in existing tables, plugins always comes 
with tables specific to it. There can be various way to plan and design a new 
feature. Not necessary that each feature will go with same strategy.

I did similar efforts for OFBiz-Magento integration in which we properly 
discussed on ML and proceed further after getting approval on some concerns.  

So IMO, there is no need to do additional effort on design phase as all these 
details already came from various discussions within ML and team.

Apart from this, Can we also plan to push existing OFBIZ-Magento integration as 
it is so that we can have atleast running integration that can be upgrade in 
future.

> OFBiz - Shopify integration plugin
> --
>
> Key: OFBIZ-11679
> URL: https://issues.apache.org/jira/browse/OFBIZ-11679
> Project: OFBiz
>  Issue Type: New Feature
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
>
> Here is the reference of ML discussion: 
> [https://markmail.org/thread/pktfygbz44a7z5kk]
> This integration can be used to provide Order and Fulfillment Management to 
> the orders placed via Shopify store.
> We are taking reference from available Magento plugin and planning to built 
> the same features as MVP. As an MVP, minimal features to implement are:
> – Import locations
> – Import products
> – Import pending orders
> – Create fulfillment on Shopify ie push shipment details and tracking code to 
> Shopify
> After MVP, we will further move with other features like:
> – Edit Order
> – Order Cancellation
> – Returns
> Reference Shopify API documents:
> [https://shopify.dev/docs/admin-api/rest/reference|https://shopify.dev/docs/admin-api/rest/reference]
> We are planning to manage all the configurations in SystemProperty.
> Thanks [~surajk] and [~ritesh.kumar] for discussing things.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11678) Make Shipment services loosely coupled with work-effort generation

2020-05-23 Thread Arun Patidar (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114596#comment-17114596
 ] 

Arun Patidar commented on OFBIZ-11678:
--

Changes looks good to me. Thanks Suraj.

> Make Shipment services loosely coupled with work-effort generation
> --
>
> Key: OFBIZ-11678
> URL: https://issues.apache.org/jira/browse/OFBIZ-11678
> Project: OFBiz
>  Issue Type: Improvement
>  Components: workeffort
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
>  Labels: Refactoring
>
> Currently, createShipment and updateShipment services creates/updates 
> work-effort and related code is written inside the same service, this should 
> not be tightly coupled with each other.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10952) Add support of applying price rule to the selected options during the configurable product ordering workflow

2019-04-28 Thread Arun Patidar (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827836#comment-16827836
 ] 

Arun Patidar commented on OFBIZ-10952:
--

I assume that it is related to price rule not working for config options 
products. If this is case then reason suggested by [~rehan.khan] makes sense.

This was only data related issue. We can close this issue as per above comment.

> Add support of applying price rule to the selected options during the 
> configurable product ordering workflow
> 
>
> Key: OFBIZ-10952
> URL: https://issues.apache.org/jira/browse/OFBIZ-10952
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Assignee: Mohammed Rehan Khan
>Priority: Major
>
> Add the support for setting and apply the price rules on a configurable item 
> based on other sets of opted configurable items.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10950) Having ability to make Configurable options date controlled

2019-04-28 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-10950.


> Having ability to make Configurable options date controlled
> ---
>
> Key: OFBIZ-10950
> URL: https://issues.apache.org/jira/browse/OFBIZ-10950
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Assignee: Arun Patidar
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10950.patch
>
>
> Have the ability to make the Configurable Option Date Controlled while 
> setting up the Configurable Good
> We can add fromDate (not nullable) and thruDate fields to ProductConfigOption 
> entity to achieve that. So while building ProductConfigWrapper object we can 
> filter all those options which are expired. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-10950) Having ability to make Configurable options date controlled

2019-04-28 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar resolved OFBIZ-10950.
--
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Committed revision 1858305.

Thanks Pritam Kute for reporting and Mohammed Rehan Khan for patch.

> Having ability to make Configurable options date controlled
> ---
>
> Key: OFBIZ-10950
> URL: https://issues.apache.org/jira/browse/OFBIZ-10950
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Assignee: Arun Patidar
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10950.patch
>
>
> Have the ability to make the Configurable Option Date Controlled while 
> setting up the Configurable Good
> We can add fromDate (not nullable) and thruDate fields to ProductConfigOption 
> entity to achieve that. So while building ProductConfigWrapper object we can 
> filter all those options which are expired. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10950) Having ability to make Configurable options date controlled

2019-04-28 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-10950:


Assignee: Arun Patidar  (was: Mohammed Rehan Khan)

> Having ability to make Configurable options date controlled
> ---
>
> Key: OFBIZ-10950
> URL: https://issues.apache.org/jira/browse/OFBIZ-10950
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Assignee: Arun Patidar
>Priority: Major
> Attachments: OFBIZ-10950.patch
>
>
> Have the ability to make the Configurable Option Date Controlled while 
> setting up the Configurable Good
> We can add fromDate (not nullable) and thruDate fields to ProductConfigOption 
> entity to achieve that. So while building ProductConfigWrapper object we can 
> filter all those options which are expired. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-9490) Update UtilMisc.formatRuleBasedAmount() method to take rules and ruleSet and formatting can be done, rather than system providing all ruleset support.

2019-03-30 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-9490.
---
Resolution: Fixed

Not applying second patch as its not required and can be manage by existing 
method. Closing task.

 

Thanks [~deepak.dixit] and [~PradhanYashSharma]

> Update UtilMisc.formatRuleBasedAmount() method to take rules and ruleSet and 
> formatting can be done, rather than system providing all ruleset support.
> --
>
> Key: OFBIZ-9490
> URL: https://issues.apache.org/jira/browse/OFBIZ-9490
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: 16.11.03
>Reporter: Pradhan Yash Sharma
>Assignee: Arun Patidar
>Priority: Minor
> Fix For: 17.12.01
>
> Attachments: OFBIZ-9490.patch, OFBIZ_9490.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9474) Set default value of max-retry to zero.

2019-03-09 Thread Arun Patidar (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788589#comment-16788589
 ] 

Arun Patidar commented on OFBIZ-9474:
-

Changes has been committed under ticket: 
https://issues.apache.org/jira/browse/OFBIZ-10557

 

Closing this ticket.

> Set default value of max-retry to zero.
> ---
>
> Key: OFBIZ-9474
> URL: https://issues.apache.org/jira/browse/OFBIZ-9474
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Ritesh Kumar
>Assignee: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-9474.patch
>
>
> Currently, the default value of the max-retry attribute (sets the max number 
> of times this service will retry when failed - persisted async only) of 
> service element is -1 which makes the service to retry unlimited times when 
> failed.
> This has to be set to zero, so when the service fails, it does not retry. 
> However, it can be manually set to any value.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-9474) Set default value of max-retry to zero.

2019-03-09 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-9474.
---
Resolution: Duplicate

Fixed under https://issues.apache.org/jira/browse/OFBIZ-10557

> Set default value of max-retry to zero.
> ---
>
> Key: OFBIZ-9474
> URL: https://issues.apache.org/jira/browse/OFBIZ-9474
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Ritesh Kumar
>Assignee: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-9474.patch
>
>
> Currently, the default value of the max-retry attribute (sets the max number 
> of times this service will retry when failed - persisted async only) of 
> service element is -1 which makes the service to retry unlimited times when 
> failed.
> This has to be set to zero, so when the service fails, it does not retry. 
> However, it can be manually set to any value.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10818) Fix the EntitySync Push and Pull functionality

2019-02-13 Thread Arun Patidar (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767101#comment-16767101
 ] 

Arun Patidar commented on OFBIZ-10818:
--

Hello [~jacques.le.roux]

I have created an [example 
document|[https://cwiki.apache.org/confluence/x/vwglBg]] to show the Pull and 
Push functionality with data sync between OFBiz servers. Currently, it is in 
WIP. 

Please have a look whenever you get chance and let me know if it looks good to 
you in form of basic details.

> Fix the EntitySync Push and Pull functionality
> --
>
> Key: OFBIZ-10818
> URL: https://issues.apache.org/jira/browse/OFBIZ-10818
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk, 16.11.05
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Major
> Fix For: 16.11.06
>
>
> Pull and Push functionality of EntitySync is breaking on various places. Need 
> to test and fix the work flow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10390) New documentation for EntitySync

2019-02-13 Thread Arun Patidar (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767102#comment-16767102
 ] 

Arun Patidar commented on OFBIZ-10390:
--

Copying comments here as well from OFBIZ-10818

Hello [~jacques.le.roux]

I have created an [example 
document|[https://cwiki.apache.org/confluence/x/vwglBg]] to show the Pull and 
Push functionality with data sync between OFBiz servers. Currently, it is in 
WIP. 

Please have a look whenever you get chance and let me know if it looks good to 
you in form of basic details.

> New documentation for EntitySync
> 
>
> Key: OFBIZ-10390
> URL: https://issues.apache.org/jira/browse/OFBIZ-10390
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> The [current EntitySync documentation in 
> wiki|https://cwiki.apache.org/confluence/display/OFBIZ/Sync+Setup+Notes+and+Example]
>  is POS oriented so somehow deprecated.
> I have recently worked on a project with EntitySync and collected as much 
> possible information. I also got David E. Jones's agreement to reuse the part 
> on EntitySync in his 2006 "Apache OFBiz Advanced Framework -  Training Video 
> Transcription" document.
> So I'll create an Asciidoc file: 
> framework/entityext/src/doc/asciidoc/EntitySync-manual.adoc and will fill it 
> with all the available information I have.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10818) Fix the EntitySync Push and Pull functionality

2019-02-07 Thread Arun Patidar (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762574#comment-16762574
 ] 

Arun Patidar commented on OFBIZ-10818:
--

Hi [~jacques.le.roux],

Please let me know if you need more details to update document mentioned in 
OFBIZ-10390. 

 

> Fix the EntitySync Push and Pull functionality
> --
>
> Key: OFBIZ-10818
> URL: https://issues.apache.org/jira/browse/OFBIZ-10818
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk, 16.11.05
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Major
> Fix For: 16.11.06
>
>
> Pull and Push functionality of EntitySync is breaking on various places. Need 
> to test and fix the work flow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-10818) Fix the EntitySync Push and Pull functionality

2019-02-07 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar resolved OFBIZ-10818.
--
Resolution: Fixed

All is working fine now. Closing this ticket.

 

> Fix the EntitySync Push and Pull functionality
> --
>
> Key: OFBIZ-10818
> URL: https://issues.apache.org/jira/browse/OFBIZ-10818
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk, 16.11.05
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Major
> Fix For: 16.11.06
>
>
> Pull and Push functionality of EntitySync is breaking on various places. Need 
> to test and fix the work flow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10818) Fix the EntitySync Push and Pull functionality

2019-02-01 Thread Arun Patidar (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758127#comment-16758127
 ] 

Arun Patidar commented on OFBIZ-10818:
--

Back-ported changes to

release 18.12 at r1852680
release 17.12 at r1852684
release 16.11 at r1852681

 

Commit log message:

Set transaction timeout of 2hrs for the actual data transmission services.
Removed unwanted service updateEntitySyncRunning
Called the tracking and status update services in new transaction so that 
record can be maintain after current transaction rollback.

 

> Fix the EntitySync Push and Pull functionality
> --
>
> Key: OFBIZ-10818
> URL: https://issues.apache.org/jira/browse/OFBIZ-10818
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk, 16.11.05
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Major
> Fix For: 17.12.01, 16.11.06, 18.12.01
>
>
> Pull and Push functionality of EntitySync is breaking on various places. Need 
> to test and fix the work flow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10818) Fix the EntitySync Push and Pull functionality

2019-01-31 Thread Arun Patidar (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757170#comment-16757170
 ] 

Arun Patidar commented on OFBIZ-10818:
--

Committed changes in trunk at r1852587. I will back-port changes once 
functionality get stable on trunk.

> Fix the EntitySync Push and Pull functionality
> --
>
> Key: OFBIZ-10818
> URL: https://issues.apache.org/jira/browse/OFBIZ-10818
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk, 16.11.05
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Major
> Fix For: 17.12.01, 16.11.06, 18.12.01
>
>
> Pull and Push functionality of EntitySync is breaking on various places. Need 
> to test and fix the work flow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (OFBIZ-10818) Fix the EntitySync Push and Pull functionality

2019-01-31 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reopened OFBIZ-10818:
--

I am observing some more issues while doing testing on real data. Re-opening 
ticket and will commit fix soon. All issues are similar to previous issue so 
not creating separate ticket.

> Fix the EntitySync Push and Pull functionality
> --
>
> Key: OFBIZ-10818
> URL: https://issues.apache.org/jira/browse/OFBIZ-10818
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk, 16.11.05
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Major
> Fix For: 17.12.01, 16.11.06, 18.12.01
>
>
> Pull and Push functionality of EntitySync is breaking on various places. Need 
> to test and fix the work flow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10818) Fix the EntitySync Push and Pull functionality

2019-01-22 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-10818.


> Fix the EntitySync Push and Pull functionality
> --
>
> Key: OFBIZ-10818
> URL: https://issues.apache.org/jira/browse/OFBIZ-10818
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk, 16.11.05
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Major
> Fix For: 17.12.01, 16.11.06, 18.12.01
>
>
> Pull and Push functionality of EntitySync is breaking on various places. Need 
> to test and fix the work flow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-10818) Fix the EntitySync Push and Pull functionality

2019-01-22 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar resolved OFBIZ-10818.
--
   Resolution: Fixed
Fix Version/s: 18.12.01

Changes has been committed in trunk at r1851805

in release 18.12 at r1851881

in release 17.12 at r1851812

in release 16.11 at r1851882

 

 

> Fix the EntitySync Push and Pull functionality
> --
>
> Key: OFBIZ-10818
> URL: https://issues.apache.org/jira/browse/OFBIZ-10818
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk, 16.11.05
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Major
> Fix For: 17.12.01, 16.11.06, 18.12.01
>
>
> Pull and Push functionality of EntitySync is breaking on various places. Need 
> to test and fix the work flow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10818) Fix the EntitySync Push and Pull functionality

2019-01-21 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar updated OFBIZ-10818:
-
Issue Type: Bug  (was: Improvement)

> Fix the EntitySync Push and Pull functionality
> --
>
> Key: OFBIZ-10818
> URL: https://issues.apache.org/jira/browse/OFBIZ-10818
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk, 16.11.05
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Major
> Fix For: 17.12.01, 16.11.06
>
>
> Pull and Push functionality of EntitySync is breaking on various places. Need 
> to test and fix the work flow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10818) Fix the EntitySync Push and Pull functionality

2019-01-21 Thread Arun Patidar (JIRA)
Arun Patidar created OFBIZ-10818:


 Summary: Fix the EntitySync Push and Pull functionality
 Key: OFBIZ-10818
 URL: https://issues.apache.org/jira/browse/OFBIZ-10818
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: 16.11.05, Trunk
Reporter: Arun Patidar
Assignee: Arun Patidar
 Fix For: 17.12.01, 16.11.06


Pull and Push functionality of EntitySync is breaking on various places. Need 
to test and fix the work flow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-6740) Issue in 'X Product on Y% Discount' promo action.

2019-01-11 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-6740:
---

Assignee: Lalit Dashora  (was: Arun Patidar)

> Issue in 'X Product on Y% Discount' promo action.
> -
>
> Key: OFBIZ-6740
> URL: https://issues.apache.org/jira/browse/OFBIZ-6740
> Project: OFBiz
>  Issue Type: Bug
>  Components: order, product
>Affects Versions: Release Branch 14.12, Trunk
>Reporter: Arun Patidar
>Assignee: Lalit Dashora
>Priority: Major
>
> Issue in 'X Product on Y% Discount' promo action. System is calculating total 
> discounted amount of promotion and distributing it all over cart items. This 
> is more confusing for end user. 
> Expected Result: User will expect to show the discount on actual cart item on 
> which he/she got the discount.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-7357) OFBIZ-6964: Prepare Demo Data based on the propsed design to support replenishment planning through any inter-company facility

2018-12-22 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-7357.
---
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Committed revision 1849547

Thanks Swapnil, Yashwant and Pawan for your contribution.

 

> OFBIZ-6964: Prepare Demo Data based on the propsed design to support 
> replenishment planning through any inter-company facility
> --
>
> Key: OFBIZ-7357
> URL: https://issues.apache.org/jira/browse/OFBIZ-7357
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing, order, product
>Affects Versions: 15.12.01
>Reporter: Swapnil Shah
>Assignee: Arun Patidar
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7357.patch, OFBIZ-7357.patch, OFBIZ-7357.patch
>
>
> We can start preparing demo data for implementation and testing purpose based 
> on requirement and design details shared over OFBIZ-7355 & OFBIZ-7356



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10518) Inventory (Supply) Allocation Planning

2018-09-26 Thread Arun Patidar (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628419#comment-16628419
 ] 

Arun Patidar edited comment on OFBIZ-10518 at 9/26/18 8:45 AM:
---

Thanks [~deepak.nigam] for considering my suggestions. 

IMO, Inventory reservation should run after allocation plan approval. WDYT?

 


was (Author: arunpati):
Thanks [~deepak.nigam] for considering my suggestions. 

I am thinking that there should run reservation whenever an allocation plan get 
approved to assign inventory from available.

> Inventory (Supply) Allocation Planning
> --
>
> Key: OFBIZ-10518
> URL: https://issues.apache.org/jira/browse/OFBIZ-10518
> Project: OFBiz
>  Issue Type: New Feature
>  Components: order, product
>Reporter: Deepak Nigam
>Assignee: Deepak Nigam
>Priority: Major
> Fix For: Trunk
>
> Attachments: CreateAllocationPlan-Step1.png, 
> CreateAllocationPlan-Step2.png, CreateAllocationPlanEditMode-Step2.png, 
> EditAllocationPlan.png, FindAllocationPlan.png, OFBiz-10518.patch, 
> OFBiz-10518.patch, ViewAllocationPlan.png
>
>
> In the current implementation of inventory reservation flow, inventory gets 
> reserved for the order based on the reservation algorithm (FIFO, LIFO etc). 
> Many times, the fulfilment cycle of the order is too long or due to some 
> unexpected circumstances, the order holds the inventory for a long time. In 
> such scenarios, inventory availability becomes one of the major bottlenecks 
> in fulfilling the other sales order and businesses often remains short 
> supplied against the demand.
>   
>  We can provide a feature (Create, Find and Edit supply allocation screen) to 
> allocate the available and any future supply judiciously amongst existing 
> customers orders by considering different factors like estimated delivery 
> dates, order priority, customer preference etc.
>  
> Following are the details design notes for the same:
>  
> An order in the approved status will be considered as ‘Eligible for 
> Allocation’. The proposed supply allocation planning will have the following 
> set of features:
>  
> *Create Allocation Plan:*
> The authorized user will be able to initiate the process by setting the 
> desired product. 
>  
> *View/Edit Allocation Plan:*
> 1) The system would search and list all the order lines which are eligible 
> for allocation for that particular product.
> 2) The user can filter and sort the orders by various parameters like Sale 
> Channel, Customer, Order Id, Estimated Ship Date etc.
> 3) The user can then prioritize the order by moving up or down the given 
> order in the priority ranking. Higher is the order in display result list, 
> higher will be the priority it would get during reservations.
> 4) The user can set the ‘Allocated Quantity’ against ordered quantity at 
> order item line level.
> 5) Once the Allocation Plan is submitted, the system would auto-assign the 
> priority and set the allocated quantity for each of the submitted orders to 
> be honoured during order reservations at any point in time.
> 7) Incoming shipments would be reserved by honouring the same allocation plan 
> during order promising cycle.
> 8) After allocating supply as per the allocation plan, any excess stock 
> should be reserved based on the standard FIFO method.
> 9) If any of the items of an order is not planned via the Allocation Plan, 
> then also it should be reserved based on default FIFO criteria.
> 10) The allocation for all the sales orders should be allowed for revision 
> unless the Shipment Plan is created against them.
>  
> *Find Allocation Plan:*
> The authorized user can search allocation plan(s) with filters like Plan Id, 
> Order Id, Product Id, Plan Method, Status etc.
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10518) Inventory (Supply) Allocation Planning

2018-09-26 Thread Arun Patidar (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628419#comment-16628419
 ] 

Arun Patidar commented on OFBIZ-10518:
--

Thanks [~deepak.nigam] for considering my suggestions. 

I am thinking that there should run reservation whenever an allocation plan get 
approved to assign inventory from available.

> Inventory (Supply) Allocation Planning
> --
>
> Key: OFBIZ-10518
> URL: https://issues.apache.org/jira/browse/OFBIZ-10518
> Project: OFBiz
>  Issue Type: New Feature
>  Components: order, product
>Reporter: Deepak Nigam
>Assignee: Deepak Nigam
>Priority: Major
> Fix For: Trunk
>
> Attachments: CreateAllocationPlan-Step1.png, 
> CreateAllocationPlan-Step2.png, CreateAllocationPlanEditMode-Step2.png, 
> EditAllocationPlan.png, FindAllocationPlan.png, OFBiz-10518.patch, 
> OFBiz-10518.patch, ViewAllocationPlan.png
>
>
> In the current implementation of inventory reservation flow, inventory gets 
> reserved for the order based on the reservation algorithm (FIFO, LIFO etc). 
> Many times, the fulfilment cycle of the order is too long or due to some 
> unexpected circumstances, the order holds the inventory for a long time. In 
> such scenarios, inventory availability becomes one of the major bottlenecks 
> in fulfilling the other sales order and businesses often remains short 
> supplied against the demand.
>   
>  We can provide a feature (Create, Find and Edit supply allocation screen) to 
> allocate the available and any future supply judiciously amongst existing 
> customers orders by considering different factors like estimated delivery 
> dates, order priority, customer preference etc.
>  
> Following are the details design notes for the same:
>  
> An order in the approved status will be considered as ‘Eligible for 
> Allocation’. The proposed supply allocation planning will have the following 
> set of features:
>  
> *Create Allocation Plan:*
> The authorized user will be able to initiate the process by setting the 
> desired product. 
>  
> *View/Edit Allocation Plan:*
> 1) The system would search and list all the order lines which are eligible 
> for allocation for that particular product.
> 2) The user can filter and sort the orders by various parameters like Sale 
> Channel, Customer, Order Id, Estimated Ship Date etc.
> 3) The user can then prioritize the order by moving up or down the given 
> order in the priority ranking. Higher is the order in display result list, 
> higher will be the priority it would get during reservations.
> 4) The user can set the ‘Allocated Quantity’ against ordered quantity at 
> order item line level.
> 5) Once the Allocation Plan is submitted, the system would auto-assign the 
> priority and set the allocated quantity for each of the submitted orders to 
> be honoured during order reservations at any point in time.
> 7) Incoming shipments would be reserved by honouring the same allocation plan 
> during order promising cycle.
> 8) After allocating supply as per the allocation plan, any excess stock 
> should be reserved based on the standard FIFO method.
> 9) If any of the items of an order is not planned via the Allocation Plan, 
> then also it should be reserved based on default FIFO criteria.
> 10) The allocation for all the sales orders should be allowed for revision 
> unless the Shipment Plan is created against them.
>  
> *Find Allocation Plan:*
> The authorized user can search allocation plan(s) with filters like Plan Id, 
> Order Id, Product Id, Plan Method, Status etc.
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10518) Inventory (Supply) Allocation Planning

2018-09-25 Thread Arun Patidar (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627036#comment-16627036
 ] 

Arun Patidar commented on OFBIZ-10518:
--

[~deepak.nigam]

 

For auto reserved, inventory will be allocated as same as item qty along with 
auto approve of Allocation Plan, correct?

> Inventory (Supply) Allocation Planning
> --
>
> Key: OFBIZ-10518
> URL: https://issues.apache.org/jira/browse/OFBIZ-10518
> Project: OFBiz
>  Issue Type: New Feature
>  Components: order, product
>Reporter: Deepak Nigam
>Assignee: Deepak Nigam
>Priority: Major
> Fix For: Trunk
>
> Attachments: CreateAllocationPlan-Step1.png, 
> CreateAllocationPlan-Step2.png, CreateAllocationPlanEditMode-Step2.png, 
> EditAllocationPlan.png, FindAllocationPlan.png, OFBiz-10518.patch, 
> ViewAllocationPlan.png
>
>
> In the current implementation of inventory reservation flow, inventory gets 
> reserved for the order based on the reservation algorithm (FIFO, LIFO etc). 
> Many times, the fulfilment cycle of the order is too long or due to some 
> unexpected circumstances, the order holds the inventory for a long time. In 
> such scenarios, inventory availability becomes one of the major bottlenecks 
> in fulfilling the other sales order and businesses often remains short 
> supplied against the demand.
>   
>  We can provide a feature (Create, Find and Edit supply allocation screen) to 
> allocate the available and any future supply judiciously amongst existing 
> customers orders by considering different factors like estimated delivery 
> dates, order priority, customer preference etc.
>  
> Following are the details design notes for the same:
>  
> An order in the approved status will be considered as ‘Eligible for 
> Allocation’. The proposed supply allocation planning will have the following 
> set of features:
>  
> *Create Allocation Plan:*
> The authorized user will be able to initiate the process by setting the 
> desired product. 
>  
> *View/Edit Allocation Plan:*
> 1) The system would search and list all the order lines which are eligible 
> for allocation for that particular product.
> 2) The user can filter and sort the orders by various parameters like Sale 
> Channel, Customer, Order Id, Estimated Ship Date etc.
> 3) The user can then prioritize the order by moving up or down the given 
> order in the priority ranking. Higher is the order in display result list, 
> higher will be the priority it would get during reservations.
> 4) The user can set the ‘Allocated Quantity’ against ordered quantity at 
> order item line level.
> 5) Once the Allocation Plan is submitted, the system would auto-assign the 
> priority and set the allocated quantity for each of the submitted orders to 
> be honoured during order reservations at any point in time.
> 7) Incoming shipments would be reserved by honouring the same allocation plan 
> during order promising cycle.
> 8) After allocating supply as per the allocation plan, any excess stock 
> should be reserved based on the standard FIFO method.
> 9) If any of the items of an order is not planned via the Allocation Plan, 
> then also it should be reserved based on default FIFO criteria.
> 10) The allocation for all the sales orders should be allowed for revision 
> unless the Shipment Plan is created against them.
>  
> *Find Allocation Plan:*
> The authorized user can search allocation plan(s) with filters like Plan Id, 
> Order Id, Product Id, Plan Method, Status etc.
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10518) Inventory (Supply) Allocation Planning

2018-09-25 Thread Arun Patidar (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626996#comment-16626996
 ] 

Arun Patidar commented on OFBIZ-10518:
--

[~deepak.nigam] , is it configurable to use Allocation or not?

This will help to control additional load on DB if we do not want to entertain 
Allocation plan.

> Inventory (Supply) Allocation Planning
> --
>
> Key: OFBIZ-10518
> URL: https://issues.apache.org/jira/browse/OFBIZ-10518
> Project: OFBiz
>  Issue Type: New Feature
>  Components: order, product
>Reporter: Deepak Nigam
>Assignee: Deepak Nigam
>Priority: Major
> Fix For: Trunk
>
> Attachments: CreateAllocationPlan-Step1.png, 
> CreateAllocationPlan-Step2.png, CreateAllocationPlanEditMode-Step2.png, 
> EditAllocationPlan.png, FindAllocationPlan.png, OFBiz-10518.patch, 
> ViewAllocationPlan.png
>
>
> In the current implementation of inventory reservation flow, inventory gets 
> reserved for the order based on the reservation algorithm (FIFO, LIFO etc). 
> Many times, the fulfilment cycle of the order is too long or due to some 
> unexpected circumstances, the order holds the inventory for a long time. In 
> such scenarios, inventory availability becomes one of the major bottlenecks 
> in fulfilling the other sales order and businesses often remains short 
> supplied against the demand.
>   
>  We can provide a feature (Create, Find and Edit supply allocation screen) to 
> allocate the available and any future supply judiciously amongst existing 
> customers orders by considering different factors like estimated delivery 
> dates, order priority, customer preference etc.
>  
> Following are the details design notes for the same:
>  
> An order in the approved status will be considered as ‘Eligible for 
> Allocation’. The proposed supply allocation planning will have the following 
> set of features:
>  
> *Create Allocation Plan:*
> The authorized user will be able to initiate the process by setting the 
> desired product. 
>  
> *View/Edit Allocation Plan:*
> 1) The system would search and list all the order lines which are eligible 
> for allocation for that particular product.
> 2) The user can filter and sort the orders by various parameters like Sale 
> Channel, Customer, Order Id, Estimated Ship Date etc.
> 3) The user can then prioritize the order by moving up or down the given 
> order in the priority ranking. Higher is the order in display result list, 
> higher will be the priority it would get during reservations.
> 4) The user can set the ‘Allocated Quantity’ against ordered quantity at 
> order item line level.
> 5) Once the Allocation Plan is submitted, the system would auto-assign the 
> priority and set the allocated quantity for each of the submitted orders to 
> be honoured during order reservations at any point in time.
> 7) Incoming shipments would be reserved by honouring the same allocation plan 
> during order promising cycle.
> 8) After allocating supply as per the allocation plan, any excess stock 
> should be reserved based on the standard FIFO method.
> 9) If any of the items of an order is not planned via the Allocation Plan, 
> then also it should be reserved based on default FIFO criteria.
> 10) The allocation for all the sales orders should be allowed for revision 
> unless the Shipment Plan is created against them.
>  
> *Find Allocation Plan:*
> The authorized user can search allocation plan(s) with filters like Plan Id, 
> Order Id, Product Id, Plan Method, Status etc.
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-9490) Update UtilMisc.formatRuleBasedAmount() method to take rules and ruleSet and formatting can be done, rather than system providing all ruleset support.

2018-09-21 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-9490:
---

Assignee: Arun Patidar  (was: Pradhan Yash Sharma)

> Update UtilMisc.formatRuleBasedAmount() method to take rules and ruleSet and 
> formatting can be done, rather than system providing all ruleset support.
> --
>
> Key: OFBIZ-9490
> URL: https://issues.apache.org/jira/browse/OFBIZ-9490
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: 16.11.03
>Reporter: Pradhan Yash Sharma
>Assignee: Arun Patidar
>Priority: Minor
> Fix For: 17.12.01
>
> Attachments: OFBIZ-9490.patch, OFBIZ_9490.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10442) Blank field appears in drop-down where the fields are not pre-populated

2018-07-10 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-10442.


> Blank field appears in drop-down where the fields are not pre-populated
> ---
>
> Key: OFBIZ-10442
> URL: https://issues.apache.org/jira/browse/OFBIZ-10442
> Project: OFBiz
>  Issue Type: Bug
> Environment: 
> https://demo-trunk.ofbiz.apache.org/catalog/control/FindSubscription
>Reporter: Archana Asthana
>Assignee: Arun Patidar
>Priority: Major
> Attachments: Highlighter.png, PopulatedHighlighter.png
>
>
> Steps to regenerate:
> 1. Open https://demo-trunk.ofbiz.apache.org/catalog/control/FindSubscription
> 2. On Find Subscription screen, check all the dropdowns one by one.
> Actual: 
> The highlighter in the drop-down is not consistent.
> If the fields are prepopulated, they are highlighted in blue.
> If the field is not prepopulated the blank field is highlighted in the 
> drop-down.
> Check Subscription Resource ID, Subscription Type, and Automatic Extend
> Images are attached for reference.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10442) Blank field appears in drop-down where the fields are not pre-populated

2018-07-10 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-10442:


Assignee: Arun Patidar

> Blank field appears in drop-down where the fields are not pre-populated
> ---
>
> Key: OFBIZ-10442
> URL: https://issues.apache.org/jira/browse/OFBIZ-10442
> Project: OFBiz
>  Issue Type: Bug
> Environment: 
> https://demo-trunk.ofbiz.apache.org/catalog/control/FindSubscription
>Reporter: Archana Asthana
>Assignee: Arun Patidar
>Priority: Major
> Attachments: Highlighter.png, PopulatedHighlighter.png
>
>
> Steps to regenerate:
> 1. Open https://demo-trunk.ofbiz.apache.org/catalog/control/FindSubscription
> 2. On Find Subscription screen, check all the dropdowns one by one.
> Actual: 
> The highlighter in the drop-down is not consistent.
> If the fields are prepopulated, they are highlighted in blue.
> If the field is not prepopulated the blank field is highlighted in the 
> drop-down.
> Check Subscription Resource ID, Subscription Type, and Automatic Extend
> Images are attached for reference.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-10441) Exception Error renders while removing the Shipment Method

2018-07-10 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar resolved OFBIZ-10441.
--
Resolution: Not A Problem

+1 [~aman.agrawal]

This screen is to manage(add/update) the Shipment Method type records. 'Remove' 
option will useful during business setup. Once a business start we cannot 
remove.

So this is not a valid issue. Closing ticket.

 

> Exception Error renders while removing the Shipment Method
> --
>
> Key: OFBIZ-10441
> URL: https://issues.apache.org/jira/browse/OFBIZ-10441
> Project: OFBiz
>  Issue Type: Bug
> Environment: Open 
> https://demo-trunk.ofbiz.apache.org/catalog/control/deleteShipmentMethodType
>Reporter: Archana Asthana
>Assignee: Arun Patidar
>Priority: Major
> Attachments: ShipmentMethodRemovalError.png
>
>
> Steps to Regenerate:
> 1. Open 
> https://demo-trunk.ofbiz.apache.org/catalog/control/deleteShipmentMethodType
> 2. Select any Shipment Method Type ID
> 3. Click Remove button 
> Actual: 
> Exception Error is rendered on the screen.
> Image is attached for reference



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10441) Exception Error renders while removing the Shipment Method

2018-07-10 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-10441:


Assignee: Arun Patidar

> Exception Error renders while removing the Shipment Method
> --
>
> Key: OFBIZ-10441
> URL: https://issues.apache.org/jira/browse/OFBIZ-10441
> Project: OFBiz
>  Issue Type: Bug
> Environment: Open 
> https://demo-trunk.ofbiz.apache.org/catalog/control/deleteShipmentMethodType
>Reporter: Archana Asthana
>Assignee: Arun Patidar
>Priority: Major
> Attachments: ShipmentMethodRemovalError.png
>
>
> Steps to Regenerate:
> 1. Open 
> https://demo-trunk.ofbiz.apache.org/catalog/control/deleteShipmentMethodType
> 2. Select any Shipment Method Type ID
> 3. Click Remove button 
> Actual: 
> Exception Error is rendered on the screen.
> Image is attached for reference



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10355) Define generic types in `ProductStoreEvents`

2018-06-23 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-10355:


Assignee: Arun Patidar

> Define generic types in `ProductStoreEvents`
> 
>
> Key: OFBIZ-10355
> URL: https://issues.apache.org/jira/browse/OFBIZ-10355
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Mathieu Lirzin
>Assignee: Arun Patidar
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: 
> 0001-improved-Define-generic-types-in-ProductStoreEvents.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10362) Improve Hindi UiLables

2018-06-23 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-10362:


Assignee: Arun Patidar

> Improve Hindi UiLables
> --
>
> Key: OFBIZ-10362
> URL: https://issues.apache.org/jira/browse/OFBIZ-10362
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-10362.patch
>
>
> There are some uiLables available in PartyErrorUiLabels.xml which have wrong 
> translation of English uiLables to Hindi.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-6964) Support for replenishment of a secondary warehouse from a main warehouse

2018-06-23 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-6964:
---

Assignee: Arun Patidar  (was: Pawan Verma)

> Support for replenishment of a secondary warehouse from a main warehouse
> 
>
> Key: OFBIZ-6964
> URL: https://issues.apache.org/jira/browse/OFBIZ-6964
> Project: OFBiz
>  Issue Type: New Feature
>  Components: manufacturing, product
>Reporter: Shrenik Bhura
>Assignee: Arun Patidar
>Priority: Major
>  Labels: features
> Fix For: 17.12.01
>
> Attachments: screenshot-1.png
>
>
> At the onset let me define a few terms clearly as I mean it in the story 
> description below :
> Requirement - A request generated for a particular product for a specific 
> quantity that needs to be purchased from a supplier for satisfying certain 
> inventory needs of a particular facility.
> Replenishment - A request generated for a particular product for a specific 
> quantity that needs to be transferred from a "backup facility" for satisfying 
> certain inventory needs of a particular facility.
> Fulfilment - The process of reserving, picking, packing and shipping the 
> ordered quantity of product(s) as per a sales order.
> Terms 'warehouse' and 'facility' have been used interchangeably.
> *The Use Case:*
> Consider a scenario wherein there is a website and a physical retail store of 
> the same Company.
> Each having its own facility i.e. 1:1 mapping.
> {{Store A (webstore) -> associated with facility 1 (webstore facility)}}
> {{Store B (retailstore) -> associated with facility 2 (retailstore facility)}}
> However, both the stores share the same catalog/products. But both have 
> independent inventory requirement and replenishment rules for the same 
> product. 
> There is a Requirement Method Enum ID (RMEI) of each product which is 
> applicable irrespective of the store and supersedes the RMEI defined, if any, 
> on a store. 
> A product's inventory thresholds (Minimum Stock, Reorder Quantity) are 
> independently managed via the facilities tab for the product. A product has 
> its ATP and QOH levels on a per facility basis. _Do note that all these 
> inventory numbers are at a facility level and has no bearing at a store 
> level._
> Where the difficulty crops up with the current implementation is the way 
> requirements are generated. A product can have only one RMEI. When an order 
> is placed from any store, then based on the combination of a product's RMEI 
> and the store mapped facility's inventory threshold, requirements are 
> generated. This is without consideration of the inventory status (surplus or 
> otherwise) at another facility of the same Company. If a store has multiple 
> facilities associated with it then the one defined in the ProductStore entity 
> -> inventoryFacilityId field would be considered for picking the inventory 
> threshold values and thus for requirement generation. 
> Most typical real-world facility arrangements: 
>   1. Usually an organisation would have a main facility/warehouse where 
> all the purchases are received and sub-facilities which are replenished from 
> the main facility after QA, internal processes, etc. OR 
>   2. For each product there would be a primary facility where the product 
> is received from the supplier (to derive benefits of demographic convenience 
> and consumption patterns) and then replenished to other facilities on a 
> demand based pull basis.
> To drive efficiencies across an organisation they need methods to consider 
> open fulfilment needs, in process purchase orders and inventory levels across 
> multiple facilities and thereafter propose inventory transfers across them to 
> facilitate better stocking and thus order fulfilment.
> Coming back to our use case, the webstore warehouse is the main facility at 
> which incoming shipments from suppliers are received for the entire Company 
> but sales order fulfilment happens only for the webstore. The retail 
> warehouse is primarily 're-stocked' via replenishment requests raised upon 
> the webstore warehouse and thus need not issue direct purchase orders to 
> suppliers. However, if the need be, requirement generated based on the 
> product's RMEI and the retail facility's inventory thresholds can also be 
> approved, converted into Purchase order and issued.
> *Proposed Solution:*
> There doesn't seem to be an out of the box solution for this in OFBiz. This 
> could work if either we think of -
> Approach A: Setting RMEI at a ProductFacility level as well which shall 
> supersede the Product level RMEI setting OR 
> Approach B: Build in support for a solution that I have encountered in 
> Opentaps (a system built atop OFBiz) i.e. implement support 

[jira] [Commented] (OFBIZ-10368) Implement Depends on support for Component Loading.

2018-06-23 Thread Arun Patidar (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521039#comment-16521039
 ] 

Arun Patidar commented on OFBIZ-10368:
--

+1, nice idea. But did not tested the feature locally.

> Implement Depends on support for Component Loading.
> ---
>
> Key: OFBIZ-10368
> URL: https://issues.apache.org/jira/browse/OFBIZ-10368
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10368.patch
>
>
> Components are loaded in the order they are found (i.e. alphabetic or 
> creation date). This can be altered. We have a pending feature support for 
> ofbiz-component, for creating a series of dependency for component loading, 
> before loading a particular component.
>  
> Here we can define dependency for a component like Component ebaystore is 
> dependent on Component ebay (even multiple dependencies for a single 
> component is also supported). We can declare it in this fashion in 
> ofbiz-component.xml file.
>  
> {code:java}
>  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/ofbiz-component.xsd;>
> {code}
>  
> Now we can declare dependency and if any anomaly is found loading of 
> components will stop.  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10391) Make accounting entry configurable

2018-06-23 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-10391.


> Make accounting entry configurable
> --
>
> Key: OFBIZ-10391
> URL: https://issues.apache.org/jira/browse/OFBIZ-10391
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Aman Agrawal
>Assignee: Arun Patidar
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10391.patch
>
>
> In current flow, if we want to disable the accounting then we need to disable 
> the set of seca's. We don't have any configurable setting to disable 
> accounting.
> We can manage this by adding a new field 'enableAccounting' in the 
> 'PartyAcctgPreference' entity. Accounting transaction entries will be 
> entertained accordingly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-10391) Make accounting entry configurable

2018-06-23 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar resolved OFBIZ-10391.
--
   Resolution: Fixed
Fix Version/s: (was: Trunk)
   Upcoming Branch

Committed revision 1834186.

 

Thanks Aman Agrawal for your contribution.

> Make accounting entry configurable
> --
>
> Key: OFBIZ-10391
> URL: https://issues.apache.org/jira/browse/OFBIZ-10391
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Aman Agrawal
>Assignee: Arun Patidar
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10391.patch
>
>
> In current flow, if we want to disable the accounting then we need to disable 
> the set of seca's. We don't have any configurable setting to disable 
> accounting.
> We can manage this by adding a new field 'enableAccounting' in the 
> 'PartyAcctgPreference' entity. Accounting transaction entries will be 
> entertained accordingly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10391) Make accounting entry configurable

2018-06-23 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar updated OFBIZ-10391:
-
Affects Version/s: Trunk

> Make accounting entry configurable
> --
>
> Key: OFBIZ-10391
> URL: https://issues.apache.org/jira/browse/OFBIZ-10391
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Aman Agrawal
>Assignee: Arun Patidar
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10391.patch
>
>
> In current flow, if we want to disable the accounting then we need to disable 
> the set of seca's. We don't have any configurable setting to disable 
> accounting.
> We can manage this by adding a new field 'enableAccounting' in the 
> 'PartyAcctgPreference' entity. Accounting transaction entries will be 
> entertained accordingly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10391) Make accounting entry configurable

2018-06-23 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-10391:


Assignee: Arun Patidar

> Make accounting entry configurable
> --
>
> Key: OFBIZ-10391
> URL: https://issues.apache.org/jira/browse/OFBIZ-10391
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Reporter: Aman Agrawal
>Assignee: Arun Patidar
>Priority: Major
> Fix For: Trunk
>
> Attachments: OFBIZ-10391.patch
>
>
> In current flow, if we want to disable the accounting then we need to disable 
> the set of seca's. We don't have any configurable setting to disable 
> accounting.
> We can manage this by adding a new field 'enableAccounting' in the 
> 'PartyAcctgPreference' entity. Accounting transaction entries will be 
> entertained accordingly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-9987) Enable drop ship PO if 'Drop-ship Only' property is set at Product Store level.

2018-06-23 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-9987:
---

Assignee: Arun Patidar

> Enable drop ship PO if 'Drop-ship Only' property is set at Product Store 
> level.
> ---
>
> Key: OFBIZ-9987
> URL: https://issues.apache.org/jira/browse/OFBIZ-9987
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Ankit Joshi
>Assignee: Arun Patidar
>Priority: Major
> Fix For: Trunk
>
> Attachments: OFBIZ-9987.patch, OFBIZ-9987.patch
>
>
> Current:
> For drop shipment process, cart method 'createDropShipGroups' only check 
> requirementMethodEnumId at Facility Level and Product level. Also, found the 
> unhandled case of not considering requirementMethodEnumId at Product Level if 
> this property found at Facility level.
> Expected : 
> RequirementMethodEnumId should be decided in the order of property set at 
> ProductStore -> Facility -> Product.
> Check and enable drop ship PO if 'Drop-ship Only' property is set at Store 
> level. Also, this property should be checked and override at Facility level 
> if exists to consider the case when Facility does not allow drop ship Order. 
> Finally, it should be checked at Product level to consider the case when 
> Store and Facility allow for drop ship but the product does not.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-7357) OFBIZ-6964: Prepare Demo Data based on the propsed design to support replenishment planning through any inter-company facility

2018-06-23 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-7357:
---

Assignee: Arun Patidar  (was: Pawan Verma)

> OFBIZ-6964: Prepare Demo Data based on the propsed design to support 
> replenishment planning through any inter-company facility
> --
>
> Key: OFBIZ-7357
> URL: https://issues.apache.org/jira/browse/OFBIZ-7357
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing, order, product
>Affects Versions: 15.12.01
>Reporter: Swapnil Shah
>Assignee: Arun Patidar
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: OFBIZ-7357.patch, OFBIZ-7357.patch, OFBIZ-7357.patch
>
>
> We can start preparing demo data for implementation and testing purpose based 
> on requirement and design details shared over OFBIZ-7355 & OFBIZ-7356



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-9506) OFBIZ-6964: Implementation to support replenishment planning through any inter-company facility

2018-06-23 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-9506:
---

Assignee: Arun Patidar  (was: Pawan Verma)

> OFBIZ-6964: Implementation to support replenishment planning through any 
> inter-company facility
> ---
>
> Key: OFBIZ-9506
> URL: https://issues.apache.org/jira/browse/OFBIZ-9506
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing, order, product
>Reporter: Swapnil M Mane
>Assignee: Arun Patidar
>Priority: Major
> Attachments: OFBIZ-9506.patch, OFBIZ-9506.patch, OFBIZ-9506.patch
>
>
> For support of replenishment planning through any inter-company facility, 
> This task is for the code implementation on the basis of design/information 
> shared in the ticket https://issues.apache.org/jira/browse/OFBIZ-7356.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-9898) Incorrect success message after creating customer

2018-06-23 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar updated OFBIZ-9898:

Fix Version/s: 16.11.05

> Incorrect success message after creating customer
> -
>
> Key: OFBIZ-9898
> URL: https://issues.apache.org/jira/browse/OFBIZ-9898
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, 16.11.04
>Reporter: Anushi Gupta
>Assignee: Arun Patidar
>Priority: Major
> Fix For: 16.11.05, Upcoming Branch
>
> Attachments: OFBIZ-9898.patch
>
>
> Steps to regenerate 
> 1) Open link https://demo-trunk.ofbiz.apache.org/webtools/control/main
> 2) Go to party component.
> 2) Click on Create new customer.
> 3) Fill in the mandatory fields and click on save button.
> Actual :
> 'ProductStoreRole created successfully' message is displayed after successful 
> creation of customer.
> Expected :
> 'Customer created successfully' message should be displayed after successful 
> creation of customer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-9898) Incorrect success message after creating customer

2018-06-23 Thread Arun Patidar (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520983#comment-16520983
 ] 

Arun Patidar edited comment on OFBIZ-9898 at 6/23/18 7:04 AM:
--

Committed in trunk at revision 1834181

Committed in 17.12 at  revision 1834182.

Committed in 16.11 at revision 1834183

 

Thanks Anushi Gupta for your contribution.


was (Author: arunpati):
Committed in trunk at revision 1834181

Committed in 17.12 at  revision 1834182.

 

Thanks Anushi Gupta for your contribution.

> Incorrect success message after creating customer
> -
>
> Key: OFBIZ-9898
> URL: https://issues.apache.org/jira/browse/OFBIZ-9898
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, 16.11.04
>Reporter: Anushi Gupta
>Assignee: Arun Patidar
>Priority: Major
> Fix For: 16.11.05, Upcoming Branch
>
> Attachments: OFBIZ-9898.patch
>
>
> Steps to regenerate 
> 1) Open link https://demo-trunk.ofbiz.apache.org/webtools/control/main
> 2) Go to party component.
> 2) Click on Create new customer.
> 3) Fill in the mandatory fields and click on save button.
> Actual :
> 'ProductStoreRole created successfully' message is displayed after successful 
> creation of customer.
> Expected :
> 'Customer created successfully' message should be displayed after successful 
> creation of customer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-9898) Incorrect success message after creating customer

2018-06-23 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar updated OFBIZ-9898:

Affects Version/s: 16.11.04

> Incorrect success message after creating customer
> -
>
> Key: OFBIZ-9898
> URL: https://issues.apache.org/jira/browse/OFBIZ-9898
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, 16.11.04
>Reporter: Anushi Gupta
>Assignee: Arun Patidar
>Priority: Major
> Fix For: 16.11.05, Upcoming Branch
>
> Attachments: OFBIZ-9898.patch
>
>
> Steps to regenerate 
> 1) Open link https://demo-trunk.ofbiz.apache.org/webtools/control/main
> 2) Go to party component.
> 2) Click on Create new customer.
> 3) Fill in the mandatory fields and click on save button.
> Actual :
> 'ProductStoreRole created successfully' message is displayed after successful 
> creation of customer.
> Expected :
> 'Customer created successfully' message should be displayed after successful 
> creation of customer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-9898) Incorrect success message after creating customer

2018-06-23 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-9898.
---

> Incorrect success message after creating customer
> -
>
> Key: OFBIZ-9898
> URL: https://issues.apache.org/jira/browse/OFBIZ-9898
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, 16.11.04
>Reporter: Anushi Gupta
>Assignee: Arun Patidar
>Priority: Major
> Fix For: 16.11.05, Upcoming Branch
>
> Attachments: OFBIZ-9898.patch
>
>
> Steps to regenerate 
> 1) Open link https://demo-trunk.ofbiz.apache.org/webtools/control/main
> 2) Go to party component.
> 2) Click on Create new customer.
> 3) Fill in the mandatory fields and click on save button.
> Actual :
> 'ProductStoreRole created successfully' message is displayed after successful 
> creation of customer.
> Expected :
> 'Customer created successfully' message should be displayed after successful 
> creation of customer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-9898) Incorrect success message after creating customer

2018-06-23 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar updated OFBIZ-9898:

Affects Version/s: (was: 17.12.01)

> Incorrect success message after creating customer
> -
>
> Key: OFBIZ-9898
> URL: https://issues.apache.org/jira/browse/OFBIZ-9898
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Anushi Gupta
>Assignee: Arun Patidar
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-9898.patch
>
>
> Steps to regenerate 
> 1) Open link https://demo-trunk.ofbiz.apache.org/webtools/control/main
> 2) Go to party component.
> 2) Click on Create new customer.
> 3) Fill in the mandatory fields and click on save button.
> Actual :
> 'ProductStoreRole created successfully' message is displayed after successful 
> creation of customer.
> Expected :
> 'Customer created successfully' message should be displayed after successful 
> creation of customer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-9898) Incorrect success message after creating customer

2018-06-23 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar updated OFBIZ-9898:

Fix Version/s: (was: 17.12.01)

> Incorrect success message after creating customer
> -
>
> Key: OFBIZ-9898
> URL: https://issues.apache.org/jira/browse/OFBIZ-9898
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Anushi Gupta
>Assignee: Arun Patidar
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-9898.patch
>
>
> Steps to regenerate 
> 1) Open link https://demo-trunk.ofbiz.apache.org/webtools/control/main
> 2) Go to party component.
> 2) Click on Create new customer.
> 3) Fill in the mandatory fields and click on save button.
> Actual :
> 'ProductStoreRole created successfully' message is displayed after successful 
> creation of customer.
> Expected :
> 'Customer created successfully' message should be displayed after successful 
> creation of customer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-9898) Incorrect success message after creating customer

2018-06-23 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar resolved OFBIZ-9898.
-
   Resolution: Fixed
Fix Version/s: Upcoming Branch
   17.12.01

Committed in trunk at revision 1834181

Committed in 17.12 at  revision 1834182.

 

Thanks Anushi Gupta for your contribution.

> Incorrect success message after creating customer
> -
>
> Key: OFBIZ-9898
> URL: https://issues.apache.org/jira/browse/OFBIZ-9898
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, 17.12.01
>Reporter: Anushi Gupta
>Assignee: Arun Patidar
>Priority: Major
> Fix For: 17.12.01, Upcoming Branch
>
> Attachments: OFBIZ-9898.patch
>
>
> Steps to regenerate 
> 1) Open link https://demo-trunk.ofbiz.apache.org/webtools/control/main
> 2) Go to party component.
> 2) Click on Create new customer.
> 3) Fill in the mandatory fields and click on save button.
> Actual :
> 'ProductStoreRole created successfully' message is displayed after successful 
> creation of customer.
> Expected :
> 'Customer created successfully' message should be displayed after successful 
> creation of customer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-9898) Incorrect success message after creating customer

2018-06-23 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar updated OFBIZ-9898:

Summary: Incorrect success message after creating customer  (was: Incorrect 
succes mesage after creating customer)

> Incorrect success message after creating customer
> -
>
> Key: OFBIZ-9898
> URL: https://issues.apache.org/jira/browse/OFBIZ-9898
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, 17.12.01
>Reporter: Anushi Gupta
>Assignee: Arun Patidar
>Priority: Major
> Attachments: OFBIZ-9898.patch
>
>
> Steps to regenerate 
> 1) Open link https://demo-trunk.ofbiz.apache.org/webtools/control/main
> 2) Go to party component.
> 2) Click on Create new customer.
> 3) Fill in the mandatory fields and click on save button.
> Actual :
> 'ProductStoreRole created successfully' message is displayed after successful 
> creation of customer.
> Expected :
> 'Customer created successfully' message should be displayed after successful 
> creation of customer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-9898) Incorrect succes mesage after creating customer

2018-06-23 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar updated OFBIZ-9898:

Affects Version/s: 17.12.01

> Incorrect succes mesage after creating customer
> ---
>
> Key: OFBIZ-9898
> URL: https://issues.apache.org/jira/browse/OFBIZ-9898
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, 17.12.01
>Reporter: Anushi Gupta
>Assignee: Arun Patidar
>Priority: Major
> Attachments: OFBIZ-9898.patch
>
>
> Steps to regenerate 
> 1) Open link https://demo-trunk.ofbiz.apache.org/webtools/control/main
> 2) Go to party component.
> 2) Click on Create new customer.
> 3) Fill in the mandatory fields and click on save button.
> Actual :
> 'ProductStoreRole created successfully' message is displayed after successful 
> creation of customer.
> Expected :
> 'Customer created successfully' message should be displayed after successful 
> creation of customer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-9898) Incorrect succes mesage after creating customer

2018-06-23 Thread Arun Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-9898:
---

Assignee: Arun Patidar  (was: Anushi Gupta)

> Incorrect succes mesage after creating customer
> ---
>
> Key: OFBIZ-9898
> URL: https://issues.apache.org/jira/browse/OFBIZ-9898
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Anushi Gupta
>Assignee: Arun Patidar
>Priority: Major
> Attachments: OFBIZ-9898.patch
>
>
> Steps to regenerate 
> 1) Open link https://demo-trunk.ofbiz.apache.org/webtools/control/main
> 2) Go to party component.
> 2) Click on Create new customer.
> 3) Fill in the mandatory fields and click on save button.
> Actual :
> 'ProductStoreRole created successfully' message is displayed after successful 
> creation of customer.
> Expected :
> 'Customer created successfully' message should be displayed after successful 
> creation of customer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10391) Make accounting entry configurable

2018-05-22 Thread Arun Patidar (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483657#comment-16483657
 ] 

Arun Patidar commented on OFBIZ-10391:
--

[~aman.agrawal] your patch looks good. But it would be good if the default 
accounting set to enabled. So for disable accounting, the user should set 'N' 
in flag field.

> Make accounting entry configurable
> --
>
> Key: OFBIZ-10391
> URL: https://issues.apache.org/jira/browse/OFBIZ-10391
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Reporter: Aman Agrawal
>Priority: Major
> Fix For: Trunk
>
> Attachments: OFBIZ-10391.patch
>
>
> In current flow, if we want to disable the accounting then we need to disable 
> the set of seca's. We don't have any configurable setting to disable 
> accounting.
> We can manage this by adding a new field 'enableAccounting' in the 
> 'PartyAcctgPreference' entity. Accounting transaction entries will be 
> entertained accordingly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10400) Replace deleteRequirement service by entity-auto

2018-05-14 Thread Arun Patidar (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473883#comment-16473883
 ] 

Arun Patidar commented on OFBIZ-10400:
--

Hi [~jacques.le.roux]

This contribution is from Suraj, I think you made a typo in your comment and 
commit log. :)

> Replace deleteRequirement service by entity-auto
> 
>
> Key: OFBIZ-10400
> URL: https://issues.apache.org/jira/browse/OFBIZ-10400
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Suraj Khurana
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10400.patch, OFBIZ-10400.patch
>
>
> Also, introduce deleteRequirementAndRelated service which will delete all 
> related entity records before deleting requirement.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10282) Remove empty field values from xml data files so that it will not override existing data with empty values

2018-04-29 Thread Arun Patidar (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458331#comment-16458331
 ] 

Arun Patidar commented on OFBIZ-10282:
--

Patch looks good to me, Thanks [~suraj.khurana] and [~rishisolankii]

> Remove empty field values from xml data files so that it will not override 
> existing data with empty values
> --
>
> Key: OFBIZ-10282
> URL: https://issues.apache.org/jira/browse/OFBIZ-10282
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Rishi Solanki
>Priority: Major
> Attachments: OFBIZ-10282-plugins.patch, OFBIZ-10282.patch
>
>
> Remove empty systemPropertyValue field values from SystemProperty xml data 
> files.
> Current system overrides  value with empty value if it is mentioned in XML 
> data tag. So need to remove empty field values to override data on the 
> existing instance. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10282) Remove empty field values from xml data files so that it will not override existing data with empty values

2018-04-04 Thread Arun Patidar (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425159#comment-16425159
 ] 

Arun Patidar commented on OFBIZ-10282:
--

Hello [~jacques.le.roux]

I agree with your comments and suggestion. I am aware of that implementation 
and change.

We can keep the SystemProperty entity record with empty values where we 
intentionally want to set field value as empty so that it will not read from 
the property file.

In this ticket, I was suggesting to remove the xml data records that have empty 
values just to show as a placeholder. Due to recent changes in XML data import 
in which empty value overrides the value of database with empty. We need to 
clean the existing XML data because it is possible that user change/add data on 
the instance after launch and does not make any change in the data file. The 
issue will generate if the user runs data load command on existing database.

 

 

 

 

 

 

> Remove empty field values from xml data files so that it will not override 
> existing data with empty values
> --
>
> Key: OFBIZ-10282
> URL: https://issues.apache.org/jira/browse/OFBIZ-10282
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Major
>
> Remove empty systemPropertyValue field values from SystemProperty xml data 
> files.
> Current system overrides  value with empty value if it is mentioned in XML 
> data tag. So need to remove empty field values to override data on the 
> existing instance. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10282) Remove empty field values from xml data files so that it will not override existing data with empty values

2018-04-03 Thread Arun Patidar (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425049#comment-16425049
 ] 

Arun Patidar commented on OFBIZ-10282:
--

Hi [~jacques.le.roux]

I have changed ticket title to make it more generic. 

+1 for backporting this change in 17.12 release. I am working to prepare a 
patch for removing all occurrences of the empty entity field values in data XML 
files.

 

 

 

> Remove empty field values from xml data files so that it will not override 
> existing data with empty values
> --
>
> Key: OFBIZ-10282
> URL: https://issues.apache.org/jira/browse/OFBIZ-10282
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Major
>
> Remove empty systemPropertyValue field values from SystemProperty xml data 
> files.
> Current system overrides  value with empty value if it is mentioned in XML 
> data tag. So need to remove empty field values to override data on the 
> existing instance. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10282) Remove empty field values from xml data files so that it will not override existing data with empty values

2018-04-03 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar updated OFBIZ-10282:
-
Summary: Remove empty field values from xml data files so that it will not 
override existing data with empty values  (was: Remove empty 
systemPropertyValue field values from SystemProperty xml data files.)

> Remove empty field values from xml data files so that it will not override 
> existing data with empty values
> --
>
> Key: OFBIZ-10282
> URL: https://issues.apache.org/jira/browse/OFBIZ-10282
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Major
>
> Remove empty systemPropertyValue field values from SystemProperty xml data 
> files.
> Current system overrides  value with empty value if it is mentioned in XML 
> data tag. So need to remove empty field values to override data on the 
> exisitng instance. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10282) Remove empty field values from xml data files so that it will not override existing data with empty values

2018-04-03 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar updated OFBIZ-10282:
-
Description: 
Remove empty systemPropertyValue field values from SystemProperty xml data 
files.

Current system overrides  value with empty value if it is mentioned in XML data 
tag. So need to remove empty field values to override data on the existing 
instance. 

 

  was:
Remove empty systemPropertyValue field values from SystemProperty xml data 
files.

Current system overrides  value with empty value if it is mentioned in XML data 
tag. So need to remove empty field values to override data on the exisitng 
instance. 

 


> Remove empty field values from xml data files so that it will not override 
> existing data with empty values
> --
>
> Key: OFBIZ-10282
> URL: https://issues.apache.org/jira/browse/OFBIZ-10282
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Major
>
> Remove empty systemPropertyValue field values from SystemProperty xml data 
> files.
> Current system overrides  value with empty value if it is mentioned in XML 
> data tag. So need to remove empty field values to override data on the 
> existing instance. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10282) Remove empty systemPropertyValue field values from SystemProperty xml data files.

2018-03-16 Thread Arun Patidar (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401596#comment-16401596
 ] 

Arun Patidar edited comment on OFBIZ-10282 at 3/16/18 9:13 AM:
---

Here, I am suggesting to remove empty field value from SystemProperty xml data 
to prevent data overridden.

Like change from



to 



 

This applies to all entities empty field values, here I took SystemProperty at 
first glance.  

 


was (Author: arunpati):
Here, I am suggesting to remove empty field value from SystemProperty xml data 
to prevent data overridden.

Like change from



to 



 

> Remove empty systemPropertyValue field values from SystemProperty xml data 
> files.
> -
>
> Key: OFBIZ-10282
> URL: https://issues.apache.org/jira/browse/OFBIZ-10282
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Major
>
> Remove empty systemPropertyValue field values from SystemProperty xml data 
> files.
> Current system overrides  value with empty value if it is mentioned in XML 
> data tag. So need to remove empty field values to override data on the 
> exisitng instance. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10282) Remove empty systemPropertyValue field values from SystemProperty xml data files.

2018-03-16 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-10282:


Assignee: Arun Patidar

> Remove empty systemPropertyValue field values from SystemProperty xml data 
> files.
> -
>
> Key: OFBIZ-10282
> URL: https://issues.apache.org/jira/browse/OFBIZ-10282
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Major
>
> Remove empty systemPropertyValue field values from SystemProperty xml data 
> files.
> Current system overrides  value with empty value if it is mentioned in XML 
> data tag. So need to remove empty field values to override data on the 
> exisitng instance. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10282) Remove empty systemPropertyValue field values from SystemProperty xml data files.

2018-03-16 Thread Arun Patidar (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401596#comment-16401596
 ] 

Arun Patidar commented on OFBIZ-10282:
--

Here, I am suggesting to remove empty field value from SystemProperty xml data 
to prevent data overridden.

Like change from



to 



 

> Remove empty systemPropertyValue field values from SystemProperty xml data 
> files.
> -
>
> Key: OFBIZ-10282
> URL: https://issues.apache.org/jira/browse/OFBIZ-10282
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Arun Patidar
>Priority: Major
>
> Remove empty systemPropertyValue field values from SystemProperty xml data 
> files.
> Current system overrides  value with empty value if it is mentioned in XML 
> data tag. So need to remove empty field values to override data on the 
> exisitng instance. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10282) Remove empty systemPropertyValue field values from SystemProperty xml data files.

2018-03-15 Thread Arun Patidar (JIRA)
Arun Patidar created OFBIZ-10282:


 Summary: Remove empty systemPropertyValue field values from 
SystemProperty xml data files.
 Key: OFBIZ-10282
 URL: https://issues.apache.org/jira/browse/OFBIZ-10282
 Project: OFBiz
  Issue Type: Improvement
Affects Versions: Trunk
Reporter: Arun Patidar


Remove empty systemPropertyValue field values from SystemProperty xml data 
files.

Current system overrides  value with empty value if it is mentioned in XML data 
tag. So need to remove empty field values to override data on the exisitng 
instance. 

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7738) OFBIZ-7471: Improve all the service level error messages for missing required field for workeffort component

2018-02-28 Thread Arun Patidar (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379975#comment-16379975
 ] 

Arun Patidar commented on OFBIZ-7738:
-

Committed changes at revision 1825537

Thanks [~bartlett.dc.1] for reporting and Dhaval Wagela for providing patch.

 

> OFBIZ-7471: Improve all the service level error messages for missing required 
> field for workeffort component
> 
>
> Key: OFBIZ-7738
> URL: https://issues.apache.org/jira/browse/OFBIZ-7738
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: workeffort
>Affects Versions: 16.11.01
>Reporter: Ratnesh Upadhyay
>Assignee: Arun Patidar
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7738.patch, OFBIZ-7738.patch, OFBIZ-7738.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10121) Incorrect Party profile view redirection in SFA due to missing roleType

2018-02-24 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-10121.

   Resolution: Fixed
Fix Version/s: 16.11.05
   17.12.01

Committed changes in trunk at rev: 1825233

in 17.12 at rev: 1825234

in 16.111 at rev: 1825235

Thanks Ankit Joshi for your contribution.

 

> Incorrect Party profile view redirection in SFA due to missing roleType
> ---
>
> Key: OFBIZ-10121
> URL: https://issues.apache.org/jira/browse/OFBIZ-10121
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing
>Affects Versions: Trunk
>Reporter: Ankit Joshi
>Assignee: Arun Patidar
>Priority: Major
> Fix For: 17.12.01, 16.11.05
>
> Attachments: OFBIZ-10121.patch, OFBIZ-10121.patch, OFBIZ-10121.patch
>
>
> Currently, a single screen is using in SFA to view the profile of parties 
> like Account, Lead, Contact, and Account-Lead on the basis of their roles. It 
> requires roleTypeId to pass as a request parameter on each action initiates 
> from the profile to render the details on the profile correctly after 
> completing the request.
> *Issue:* Various actions on the profile screen does not include roleTypeId as 
> a request parameter. It results in redirecting to the empty profile screen 
> after completing the request.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-9761) Update regex used for validating credit cards

2018-02-24 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-9761:
---

Assignee: Amit Gadaley  (was: Arun Patidar)

> Update regex used for validating credit cards 
> --
>
> Key: OFBIZ-9761
> URL: https://issues.apache.org/jira/browse/OFBIZ-9761
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Amit Gadaley
>Assignee: Amit Gadaley
>Priority: Major
>  Labels: backport-needed
> Fix For: Trunk
>
> Attachments: OFBIZ-9761.patch
>
>
> Update regex used for validating credit cards:
> MasterCard numbers either start with the numbers 51 through 55 or with the 
> numbers 2221 through 2720. All have 16 digits.
> Discover card numbers begin with 6011 or 65. All have 16 digits.
> JCB cards beginning with 2131 or 1800 have 15 digits. JCB cards beginning 
> with 35 have 16 digits.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9761) Update regex used for validating credit cards

2018-02-24 Thread Arun Patidar (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375521#comment-16375521
 ] 

Arun Patidar commented on OFBIZ-9761:
-

Committed changes in trunk at rev: 1825216

in 17.12 at rev: 1825217

There are some conflicts while applying the patch on 16.11 so will commit in 
16.11 after resolving conflicts.

 

Thanks [~amit.gadaley] for your contribution and [~mbrohl] for reviewing and 
suggestions.

> Update regex used for validating credit cards 
> --
>
> Key: OFBIZ-9761
> URL: https://issues.apache.org/jira/browse/OFBIZ-9761
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Amit Gadaley
>Assignee: Arun Patidar
>Priority: Major
>  Labels: backport-needed
> Fix For: Trunk
>
> Attachments: OFBIZ-9761.patch
>
>
> Update regex used for validating credit cards:
> MasterCard numbers either start with the numbers 51 through 55 or with the 
> numbers 2221 through 2720. All have 16 digits.
> Discover card numbers begin with 6011 or 65. All have 16 digits.
> JCB cards beginning with 2131 or 1800 have 15 digits. JCB cards beginning 
> with 35 have 16 digits.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-9761) Update regex used for validating credit cards

2018-02-24 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar updated OFBIZ-9761:

Labels: backport-needed  (was: )

> Update regex used for validating credit cards 
> --
>
> Key: OFBIZ-9761
> URL: https://issues.apache.org/jira/browse/OFBIZ-9761
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Amit Gadaley
>Assignee: Arun Patidar
>Priority: Major
>  Labels: backport-needed
> Fix For: Trunk
>
> Attachments: OFBIZ-9761.patch
>
>
> Update regex used for validating credit cards:
> MasterCard numbers either start with the numbers 51 through 55 or with the 
> numbers 2221 through 2720. All have 16 digits.
> Discover card numbers begin with 6011 or 65. All have 16 digits.
> JCB cards beginning with 2131 or 1800 have 15 digits. JCB cards beginning 
> with 35 have 16 digits.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9761) Update regex used for validating credit cards

2018-02-24 Thread Arun Patidar (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375506#comment-16375506
 ] 

Arun Patidar commented on OFBIZ-9761:
-

Hi [~mbrohl] , 

JCB checks looks good to me as per details in document - 
[https://www.regular-expressions.info/creditcard.html]

For now, I am committing changes. Please let me know if you have any 
suggestions here.

 

> Update regex used for validating credit cards 
> --
>
> Key: OFBIZ-9761
> URL: https://issues.apache.org/jira/browse/OFBIZ-9761
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Amit Gadaley
>Assignee: Arun Patidar
>Priority: Major
> Fix For: Trunk
>
> Attachments: OFBIZ-9761.patch
>
>
> Update regex used for validating credit cards:
> MasterCard numbers either start with the numbers 51 through 55 or with the 
> numbers 2221 through 2720. All have 16 digits.
> Discover card numbers begin with 6011 or 65. All have 16 digits.
> JCB cards beginning with 2131 or 1800 have 15 digits. JCB cards beginning 
> with 35 have 16 digits.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-7738) OFBIZ-7471: Improve all the service level error messages for missing required field for workeffort component

2018-02-24 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-7738.
---
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Committed in trunk at revision 1825209

Thanks Ratnesh Upadhyay and Dhaval Wagela for your contribution.

 

> OFBIZ-7471: Improve all the service level error messages for missing required 
> field for workeffort component
> 
>
> Key: OFBIZ-7738
> URL: https://issues.apache.org/jira/browse/OFBIZ-7738
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: workeffort
>Affects Versions: 16.11.01
>Reporter: Ratnesh Upadhyay
>Assignee: Arun Patidar
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7738.patch, OFBIZ-7738.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-9761) Update regex used for validating credit cards

2018-02-24 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-9761:
---

Assignee: Arun Patidar  (was: Amit Gadaley)

> Update regex used for validating credit cards 
> --
>
> Key: OFBIZ-9761
> URL: https://issues.apache.org/jira/browse/OFBIZ-9761
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Amit Gadaley
>Assignee: Arun Patidar
>Priority: Major
> Fix For: Trunk
>
> Attachments: OFBIZ-9761.patch
>
>
> Update regex used for validating credit cards:
> MasterCard numbers either start with the numbers 51 through 55 or with the 
> numbers 2221 through 2720. All have 16 digits.
> Discover card numbers begin with 6011 or 65. All have 16 digits.
> JCB cards beginning with 2131 or 1800 have 15 digits. JCB cards beginning 
> with 35 have 16 digits.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10235) Update org.ofbiz package to org.apache.ofbiz in some missing entity def

2018-02-24 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar updated OFBIZ-10235:
-
Affects Version/s: Trunk

> Update org.ofbiz package to org.apache.ofbiz  in some missing entity def
> 
>
> Key: OFBIZ-10235
> URL: https://issues.apache.org/jira/browse/OFBIZ-10235
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk, 16.11.04
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Major
> Fix For: 17.12.01, 16.11.05
>
>
> Observed that there are still some org.ofbiz package used in entity 
> defination. Replace org.ofbiz with org.apache.ofbiz package in missing cases.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-7738) OFBIZ-7471: Improve all the service level error messages for missing required field for workeffort component

2018-02-24 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar updated OFBIZ-7738:

Affects Version/s: Trunk

> OFBIZ-7471: Improve all the service level error messages for missing required 
> field for workeffort component
> 
>
> Key: OFBIZ-7738
> URL: https://issues.apache.org/jira/browse/OFBIZ-7738
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: workeffort
>Affects Versions: Trunk, 16.11.01
>Reporter: Ratnesh Upadhyay
>Assignee: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7738.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-7738) OFBIZ-7471: Improve all the service level error messages for missing required field for workeffort component

2018-02-24 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-7738:
---

Assignee: Arun Patidar  (was: Ashish Vijaywargiya)

> OFBIZ-7471: Improve all the service level error messages for missing required 
> field for workeffort component
> 
>
> Key: OFBIZ-7738
> URL: https://issues.apache.org/jira/browse/OFBIZ-7738
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: workeffort
>Affects Versions: 16.11.01
>Reporter: Ratnesh Upadhyay
>Assignee: Arun Patidar
>Priority: Minor
> Attachments: OFBIZ-7738.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10235) Update org.ofbiz package to org.apache.ofbiz in some missing entity def

2018-02-24 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar updated OFBIZ-10235:
-
Affects Version/s: 16.11.04

> Update org.ofbiz package to org.apache.ofbiz  in some missing entity def
> 
>
> Key: OFBIZ-10235
> URL: https://issues.apache.org/jira/browse/OFBIZ-10235
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk, 16.11.04
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Major
> Fix For: 17.12.01, 16.11.05
>
>
> Observed that there are still some org.ofbiz package used in entity 
> defination. Replace org.ofbiz with org.apache.ofbiz package in missing cases.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10235) Update org.ofbiz package to org.apache.ofbiz in some missing entity def

2018-02-24 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-10235.

   Resolution: Fixed
Fix Version/s: 16.11.05
   17.12.01

Committed in trunk at revision 1825199

in 17.12 at rev: 1825200

in 16.11 at rev: 1825201

> Update org.ofbiz package to org.apache.ofbiz  in some missing entity def
> 
>
> Key: OFBIZ-10235
> URL: https://issues.apache.org/jira/browse/OFBIZ-10235
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Major
> Fix For: 17.12.01, 16.11.05
>
>
> Observed that there are still some org.ofbiz package used in entity 
> defination. Replace org.ofbiz with org.apache.ofbiz package in missing cases.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10235) Update org.ofbiz package to org.apache.ofbiz in some missing entity def

2018-02-24 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-10235:


Assignee: Arun Patidar

> Update org.ofbiz package to org.apache.ofbiz  in some missing entity def
> 
>
> Key: OFBIZ-10235
> URL: https://issues.apache.org/jira/browse/OFBIZ-10235
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>Priority: Major
>
> Observed that there are still some org.ofbiz package used in entity 
> defination. Replace org.ofbiz with org.apache.ofbiz package in missing cases.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10235) Update org.ofbiz package to org.apache.ofbiz in some missing entity def

2018-02-24 Thread Arun Patidar (JIRA)
Arun Patidar created OFBIZ-10235:


 Summary: Update org.ofbiz package to org.apache.ofbiz  in some 
missing entity def
 Key: OFBIZ-10235
 URL: https://issues.apache.org/jira/browse/OFBIZ-10235
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL COMPONENTS
Reporter: Arun Patidar


Observed that there are still some org.ofbiz package used in entity defination. 
Replace org.ofbiz with org.apache.ofbiz package in missing cases.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10232) Survey response data lost on loadCartFromOrder service

2018-02-24 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar updated OFBIZ-10232:
-
Affects Version/s: Release Branch 16.11

> Survey response data lost on loadCartFromOrder service
> --
>
> Key: OFBIZ-10232
> URL: https://issues.apache.org/jira/browse/OFBIZ-10232
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Suraj Khurana
>Assignee: Arun Patidar
>Priority: Major
> Fix For: 17.12.01, 16.11.05
>
> Attachments: OFBIZ-10232.patch
>
>
> When quotes are being converted to orders it appears that we are losing the 
> survey data that is provided in the Quote.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10232) Survey response data lost on loadCartFromOrder service

2018-02-24 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-10232.

   Resolution: Fixed
Fix Version/s: 16.11.05
   17.12.01

Committed changes in the trunk at rev: 1825192.

at 16.11 at rev: 1825194

and at 17.122 at rev: 1825193.

 

Thanks Mr. Khurana for your contribution.

> Survey response data lost on loadCartFromOrder service
> --
>
> Key: OFBIZ-10232
> URL: https://issues.apache.org/jira/browse/OFBIZ-10232
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Suraj Khurana
>Assignee: Arun Patidar
>Priority: Major
> Fix For: 17.12.01, 16.11.05
>
> Attachments: OFBIZ-10232.patch
>
>
> When quotes are being converted to orders it appears that we are losing the 
> survey data that is provided in the Quote.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10232) Survey response data lost on loadCartFromOrder service

2018-02-23 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-10232:


Assignee: Arun Patidar  (was: Suraj Khurana)

> Survey response data lost on loadCartFromOrder service
> --
>
> Key: OFBIZ-10232
> URL: https://issues.apache.org/jira/browse/OFBIZ-10232
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Arun Patidar
>Priority: Major
> Attachments: OFBIZ-10232.patch
>
>
> When quotes are being converted to orders it appears that we are losing the 
> survey data that is provided in the Quote.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10220) Introduce support for condition-service for entity eca's as well

2018-02-23 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar updated OFBIZ-10220:
-
Affects Version/s: Trunk

> Introduce support for condition-service for entity eca's as well
> 
>
> Key: OFBIZ-10220
> URL: https://issues.apache.org/jira/browse/OFBIZ-10220
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Arun Patidar
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10220.patch
>
>
> Currently, condition-service tag works for service eca's only, extend this 
> support for entity eca's as well.
> Here is the discussion on dev list for reference:
> http://markmail.org/message/roqhaqsdbcycrwj2



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10220) Introduce support for condition-service for entity eca's as well

2018-02-23 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-10220:


Assignee: Arun Patidar  (was: Suraj Khurana)

> Introduce support for condition-service for entity eca's as well
> 
>
> Key: OFBIZ-10220
> URL: https://issues.apache.org/jira/browse/OFBIZ-10220
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Reporter: Suraj Khurana
>Assignee: Arun Patidar
>Priority: Major
> Attachments: OFBIZ-10220.patch
>
>
> Currently, condition-service tag works for service eca's only, extend this 
> support for entity eca's as well.
> Here is the discussion on dev list for reference:
> http://markmail.org/message/roqhaqsdbcycrwj2



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-8411) popup image takes full width of browser window for ecommerce multiflex theme

2018-02-01 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar resolved OFBIZ-8411.
-
Resolution: Fixed

> popup image takes full width of browser window for ecommerce multiflex theme
> 
>
> Key: OFBIZ-8411
> URL: https://issues.apache.org/jira/browse/OFBIZ-8411
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk, 16.11.04
>Reporter: Wai
>Assignee: Arun Patidar
>Priority: Major
> Fix For: 17.12.01, 16.11.05
>
> Attachments: OFBIZ-8411.patch
>
>
> go to https://localhost:8443/catalog/control/FindProductStore
> select multiflex theme
> go to ecommerce
> hover mouse over an image.
> notice that the width of popup image take width of browser window



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-8411) popup image takes full width of browser window for ecommerce multiflex theme

2018-02-01 Thread Arun Patidar (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349837#comment-16349837
 ] 

Arun Patidar edited comment on OFBIZ-8411 at 2/2/18 6:51 AM:
-

Thanks [~jacques.le.roux] for reporting.

 

Committed missing changes in release branches

16.11 at rev: 1822926

17.12 at rev: 1822925


was (Author: arunpati):
Thanks [~jacques.le.roux] for reporting. I will check this and push remaining 
changes.

> popup image takes full width of browser window for ecommerce multiflex theme
> 
>
> Key: OFBIZ-8411
> URL: https://issues.apache.org/jira/browse/OFBIZ-8411
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk, 16.11.04
>Reporter: Wai
>Assignee: Arun Patidar
>Priority: Major
> Fix For: 17.12.01, 16.11.05
>
> Attachments: OFBIZ-8411.patch
>
>
> go to https://localhost:8443/catalog/control/FindProductStore
> select multiflex theme
> go to ecommerce
> hover mouse over an image.
> notice that the width of popup image take width of browser window



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-8411) popup image takes full width of browser window for ecommerce multiflex theme

2018-02-01 Thread Arun Patidar (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349837#comment-16349837
 ] 

Arun Patidar commented on OFBIZ-8411:
-

Thanks [~jacques.le.roux] for reporting. I will check this and push remaining 
changes.

> popup image takes full width of browser window for ecommerce multiflex theme
> 
>
> Key: OFBIZ-8411
> URL: https://issues.apache.org/jira/browse/OFBIZ-8411
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk, 16.11.04
>Reporter: Wai
>Assignee: Arun Patidar
>Priority: Major
> Fix For: 17.12.01, 16.11.05
>
> Attachments: OFBIZ-8411.patch
>
>
> go to https://localhost:8443/catalog/control/FindProductStore
> select multiflex theme
> go to ecommerce
> hover mouse over an image.
> notice that the width of popup image take width of browser window



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-8411) popup image takes full width of browser window for ecommerce multiflex theme

2018-01-27 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar updated OFBIZ-8411:

Fix Version/s: (was: Upcoming Branch)

> popup image takes full width of browser window for ecommerce multiflex theme
> 
>
> Key: OFBIZ-8411
> URL: https://issues.apache.org/jira/browse/OFBIZ-8411
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk, 16.11.04
>Reporter: Wai
>Assignee: Arun Patidar
>Priority: Major
> Fix For: 16.11.05
>
> Attachments: OFBIZ-8411.patch
>
>
> go to https://localhost:8443/catalog/control/FindProductStore
> select multiflex theme
> go to ecommerce
> hover mouse over an image.
> notice that the width of popup image take width of browser window



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-7183) Completed Service Order Items are being allowed to be received along with finished goods over Approved PO

2018-01-27 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar updated OFBIZ-7183:

Affects Version/s: Trunk

> Completed Service Order Items are being allowed to be received along with 
> finished goods over Approved PO 
> --
>
> Key: OFBIZ-7183
> URL: https://issues.apache.org/jira/browse/OFBIZ-7183
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk, 17.12.01
>Reporter: Swapnil Shah
>Assignee: Arun Patidar
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: COMP_REC_1.png, OFBIZ-7183.patch, OrderItem.png, 
> RecceiveInventory.png
>
>
> Whenever a PO has both service type and finished good products then order 
> items having service type products get completed on Order approval itself. 
> But when such PO is received the service type items (despite being completed) 
> are listed along with finished goods to be received and eventually get 
> received as well if done so. 
> We could try preventing service type items to be listed like we do for any 
> regular finished good items when they get completed.
> Please refer to attached screenshot for reference.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-7183) Completed Service Order Items are being allowed to be received along with finished goods over Approved PO

2018-01-27 Thread Arun Patidar (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342098#comment-16342098
 ] 

Arun Patidar edited comment on OFBIZ-7183 at 1/27/18 11:48 AM:
---

Committed changes in trunk at rev: 1822393

in 17.12 at rev: 1822394

Thanks Ankush Upadhyay and Swapnil Shah for your contribution.

 


was (Author: arunpati):
Committed changes in trunk at rev: 1822393

in 17.12 at rev: 1822394

> Completed Service Order Items are being allowed to be received along with 
> finished goods over Approved PO 
> --
>
> Key: OFBIZ-7183
> URL: https://issues.apache.org/jira/browse/OFBIZ-7183
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: 17.12.01
>Reporter: Swapnil Shah
>Assignee: Arun Patidar
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: COMP_REC_1.png, OFBIZ-7183.patch, OrderItem.png, 
> RecceiveInventory.png
>
>
> Whenever a PO has both service type and finished good products then order 
> items having service type products get completed on Order approval itself. 
> But when such PO is received the service type items (despite being completed) 
> are listed along with finished goods to be received and eventually get 
> received as well if done so. 
> We could try preventing service type items to be listed like we do for any 
> regular finished good items when they get completed.
> Please refer to attached screenshot for reference.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-7183) Completed Service Order Items are being allowed to be received along with finished goods over Approved PO

2018-01-27 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-7183.
---
   Resolution: Fixed
Fix Version/s: 17.12.01

Committed changes in trunk at rev: 1822393

in 17.12 at rev: 1822394

> Completed Service Order Items are being allowed to be received along with 
> finished goods over Approved PO 
> --
>
> Key: OFBIZ-7183
> URL: https://issues.apache.org/jira/browse/OFBIZ-7183
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: 17.12.01
>Reporter: Swapnil Shah
>Assignee: Arun Patidar
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: COMP_REC_1.png, OFBIZ-7183.patch, OrderItem.png, 
> RecceiveInventory.png
>
>
> Whenever a PO has both service type and finished good products then order 
> items having service type products get completed on Order approval itself. 
> But when such PO is received the service type items (despite being completed) 
> are listed along with finished goods to be received and eventually get 
> received as well if done so. 
> We could try preventing service type items to be listed like we do for any 
> regular finished good items when they get completed.
> Please refer to attached screenshot for reference.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-8411) popup image takes full width of browser window for ecommerce multiflex theme

2018-01-27 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar updated OFBIZ-8411:

Affects Version/s: (was: 17.12.01)

> popup image takes full width of browser window for ecommerce multiflex theme
> 
>
> Key: OFBIZ-8411
> URL: https://issues.apache.org/jira/browse/OFBIZ-8411
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk, 16.11.04
>Reporter: Wai
>Assignee: Arun Patidar
>Priority: Major
> Fix For: 16.11.05, Upcoming Branch
>
> Attachments: OFBIZ-8411.patch
>
>
> go to https://localhost:8443/catalog/control/FindProductStore
> select multiflex theme
> go to ecommerce
> hover mouse over an image.
> notice that the width of popup image take width of browser window



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-8411) popup image takes full width of browser window for ecommerce multiflex theme

2018-01-27 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar updated OFBIZ-8411:

Fix Version/s: (was: 17.12.01)

> popup image takes full width of browser window for ecommerce multiflex theme
> 
>
> Key: OFBIZ-8411
> URL: https://issues.apache.org/jira/browse/OFBIZ-8411
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk, 16.11.04
>Reporter: Wai
>Assignee: Arun Patidar
>Priority: Major
> Fix For: 16.11.05, Upcoming Branch
>
> Attachments: OFBIZ-8411.patch
>
>
> go to https://localhost:8443/catalog/control/FindProductStore
> select multiflex theme
> go to ecommerce
> hover mouse over an image.
> notice that the width of popup image take width of browser window



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-8411) popup image takes full width of browser window for ecommerce multiflex theme

2018-01-27 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-8411.
---
   Resolution: Fixed
Fix Version/s: Upcoming Branch
   16.11.05
   17.12.01

Committed changes in trunk at rev: 1822377

 17.12 at rev: 1822387

16.11 at rev: 1822388

 

Thanks Wai and  Aishwary for your contribution.

 

> popup image takes full width of browser window for ecommerce multiflex theme
> 
>
> Key: OFBIZ-8411
> URL: https://issues.apache.org/jira/browse/OFBIZ-8411
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk, 17.12.01, 16.11.04
>Reporter: Wai
>Assignee: Arun Patidar
>Priority: Major
> Fix For: 17.12.01, 16.11.05, Upcoming Branch
>
> Attachments: OFBIZ-8411.patch
>
>
> go to https://localhost:8443/catalog/control/FindProductStore
> select multiflex theme
> go to ecommerce
> hover mouse over an image.
> notice that the width of popup image take width of browser window



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-8411) popup image takes full width of browser window for ecommerce multiflex theme

2018-01-27 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar updated OFBIZ-8411:

Affects Version/s: 17.12.01
   16.11.04

> popup image takes full width of browser window for ecommerce multiflex theme
> 
>
> Key: OFBIZ-8411
> URL: https://issues.apache.org/jira/browse/OFBIZ-8411
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk, 17.12.01, 16.11.04
>Reporter: Wai
>Assignee: Arun Patidar
>Priority: Major
> Fix For: 17.12.01, 16.11.05, Upcoming Branch
>
> Attachments: OFBIZ-8411.patch
>
>
> go to https://localhost:8443/catalog/control/FindProductStore
> select multiflex theme
> go to ecommerce
> hover mouse over an image.
> notice that the width of popup image take width of browser window



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-8411) popup image takes full width of browser window for ecommerce multiflex theme

2018-01-27 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-8411:
---

Assignee: Arun Patidar  (was: Aishwary Shrivastava)

> popup image takes full width of browser window for ecommerce multiflex theme
> 
>
> Key: OFBIZ-8411
> URL: https://issues.apache.org/jira/browse/OFBIZ-8411
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Wai
>Assignee: Arun Patidar
>Priority: Major
> Attachments: OFBIZ-8411.patch
>
>
> go to https://localhost:8443/catalog/control/FindProductStore
> select multiflex theme
> go to ecommerce
> hover mouse over an image.
> notice that the width of popup image take width of browser window



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-7183) Completed Service Order Items are being allowed to be received along with finished goods over Approved PO

2018-01-27 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-7183:
---

Assignee: Arun Patidar  (was: Ankush Upadhyay)

> Completed Service Order Items are being allowed to be received along with 
> finished goods over Approved PO 
> --
>
> Key: OFBIZ-7183
> URL: https://issues.apache.org/jira/browse/OFBIZ-7183
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: 17.12.01
>Reporter: Swapnil Shah
>Assignee: Arun Patidar
>Priority: Major
> Attachments: COMP_REC_1.png, OFBIZ-7183.patch, OrderItem.png, 
> RecceiveInventory.png
>
>
> Whenever a PO has both service type and finished good products then order 
> items having service type products get completed on Order approval itself. 
> But when such PO is received the service type items (despite being completed) 
> are listed along with finished goods to be received and eventually get 
> received as well if done so. 
> We could try preventing service type items to be listed like we do for any 
> regular finished good items when they get completed.
> Please refer to attached screenshot for reference.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-9915) Error printing Return PDF

2017-12-23 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar closed OFBIZ-9915.
---
   Resolution: Fixed
Fix Version/s: 16.11.04
   Upcoming Release

Committed in trunk at revision 1819144 and in 16.11 at revision 1819144

Thanks Priya Sharma and Ankush Upadhyay for your contribution.

> Error printing Return PDF
> -
>
> Key: OFBIZ-9915
> URL: https://issues.apache.org/jira/browse/OFBIZ-9915
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk, Release Branch 16.11
> Environment: https://demo-trunk.ofbiz.apache.org/ordermgr/
>Reporter: Priya Sharma
>Assignee: Arun Patidar
> Fix For: Upcoming Release, 16.11.04
>
> Attachments: OFBIZ-9915.patch, return-pdf.png
>
>
> 1) Navigate to view return screen 
> [https://demo-trunk.ofbiz.apache.org/ordermgr/control/returnMain?returnId=10007]
> 2) Select any return.
> 3) Click on the PDF button, redirected to another tab but error message is 
> returned.
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/return.pdf?returnId=10007



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9915) Error printing Return PDF

2017-12-23 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar updated OFBIZ-9915:

Affects Version/s: Trunk
   Release Branch 16.11

> Error printing Return PDF
> -
>
> Key: OFBIZ-9915
> URL: https://issues.apache.org/jira/browse/OFBIZ-9915
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk, Release Branch 16.11
> Environment: https://demo-trunk.ofbiz.apache.org/ordermgr/
>Reporter: Priya Sharma
>Assignee: Ankush Upadhyay
> Attachments: OFBIZ-9915.patch, return-pdf.png
>
>
> 1) Navigate to view return screen 
> [https://demo-trunk.ofbiz.apache.org/ordermgr/control/returnMain?returnId=10007]
> 2) Select any return.
> 3) Click on the PDF button, redirected to another tab but error message is 
> returned.
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/return.pdf?returnId=10007



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9915) Error printing Return PDF

2017-12-23 Thread Arun Patidar (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arun Patidar reassigned OFBIZ-9915:
---

Assignee: Arun Patidar  (was: Ankush Upadhyay)

> Error printing Return PDF
> -
>
> Key: OFBIZ-9915
> URL: https://issues.apache.org/jira/browse/OFBIZ-9915
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk, Release Branch 16.11
> Environment: https://demo-trunk.ofbiz.apache.org/ordermgr/
>Reporter: Priya Sharma
>Assignee: Arun Patidar
> Attachments: OFBIZ-9915.patch, return-pdf.png
>
>
> 1) Navigate to view return screen 
> [https://demo-trunk.ofbiz.apache.org/ordermgr/control/returnMain?returnId=10007]
> 2) Select any return.
> 3) Click on the PDF button, redirected to another tab but error message is 
> returned.
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/return.pdf?returnId=10007



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


  1   2   3   4   5   6   7   >