[jira] [Commented] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837143#comment-17837143
]
Gaetan Chaboussie commented on OFBIZ-11067:
---
New patch including the FlexibleMapAccessor test file that was forgotten in
previous patch
[^Patch_with_FlexibleMapAccessorTests_included_that_was_forgotten_in_the_previous_patch.patch]
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Mathieu Lirzin
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch,
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch,
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch,
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch,
> OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch,
> OFBIZ-11067_0018-Turn-UtilObjectTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0019-Merge-UtilObjectUnitTest-into-UtilObjectTes.patch,
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests-1.patch,
>
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests-1.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests.patch,
>
> Patch_with_FlexibleMapAccessorTests_included_that_was_forgotten_in_the_previous_patch.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gaetan Chaboussie updated OFBIZ-11067:
--
Attachment:
Patch_with_FlexibleMapAccessorTests_included_that_was_forgotten_in_the_previous_patch.patch
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Mathieu Lirzin
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch,
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch,
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch,
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch,
> OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch,
> OFBIZ-11067_0018-Turn-UtilObjectTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0019-Merge-UtilObjectUnitTest-into-UtilObjectTes.patch,
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests-1.patch,
>
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests-1.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests.patch,
>
> Patch_with_FlexibleMapAccessorTests_included_that_was_forgotten_in_the_previous_patch.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (OFBIZ-12935) Test 2.3.33 FreeMarker release
[
https://issues.apache.org/jira/browse/OFBIZ-12935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835627#comment-17835627
]
Gaetan Chaboussie edited comment on OFBIZ-12935 at 4/10/24 7:39 AM:
Hi, new issue detected i think :
{code:java}
freemarker.core.BugException: A bug was detected in FreeMarker; please report
it with stack-trace
at
freemarker.template.Configuration.setServletContextForTemplateLoading(Configuration.java:1667)
~[freemarker-2.3.33-SNAPSHOT.jar:2.3.32.97]
at
org.apache.ofbiz.webapp.ftl.FreeMarkerViewHandler.init(FreeMarkerViewHandler.java:52)
~[main/:?]
at org.apache.ofbiz.webapp.view.ViewFactory.(ViewFactory.java:51)
[main/:?]
at
org.apache.ofbiz.webapp.control.RequestHandler.(RequestHandler.java:103)
[main/:?]
at
org.apache.ofbiz.webapp.control.RequestHandler.getRequestHandler(RequestHandler.java:115)
[main/:?]
at
org.apache.ofbiz.webapp.control.ControlServlet.init(ControlServlet.java:76)
[main/:?]
at jakarta.servlet.GenericServlet.init(GenericServlet.java:143)
[tomcat-servlet-api-10.1.19.jar:6.0]
at jakarta.servlet.http.HttpServlet.init(HttpServlet.java:121)
[tomcat-servlet-api-10.1.19.jar:6.0]
at
org.apache.catalina.core.StandardWrapper.initServlet(StandardWrapper.java:944)
[tomcat-catalina-10.1.19.jar:10.1.19]
at
org.apache.catalina.core.StandardWrapper.loadServlet(StandardWrapper.java:901)
[tomcat-catalina-10.1.19.jar:10.1.19]
at org.apache.catalina.core.StandardWrapper.load(StandardWrapper.java:805)
[tomcat-catalina-10.1.19.jar:10.1.19]
at
org.apache.catalina.core.StandardContext.loadOnStartup(StandardContext.java:4617)
[tomcat-catalina-10.1.19.jar:10.1.19]
at
org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:4910)
[tomcat-catalina-10.1.19.jar:10.1.19]
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:171)
[tomcat-catalina-10.1.19.jar:10.1.19]
at
org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1332)
[tomcat-catalina-10.1.19.jar:10.1.19]
at
org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1322)
[tomcat-catalina-10.1.19.jar:10.1.19]
at java.util.concurrent.FutureTask.run(FutureTask.java:264) [?:?]
at
org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
[tomcat-util-10.1.19.jar:10.1.19]
at
java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:145)
[?:?]
at
org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:866)
[tomcat-catalina-10.1.19.jar:10.1.19]
at
org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:845)
[tomcat-catalina-10.1.19.jar:10.1.19]
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:171)
[tomcat-catalina-10.1.19.jar:10.1.19]
at
org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1332)
[tomcat-catalina-10.1.19.jar:10.1.19]
at
org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1322)
[tomcat-catalina-10.1.19.jar:10.1.19]
at java.util.concurrent.FutureTask.run(FutureTask.java:264) [?:?]
at
org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
[tomcat-util-10.1.19.jar:10.1.19]
at
java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:145)
[?:?]
at
org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:866)
[tomcat-catalina-10.1.19.jar:10.1.19]
at
org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:240)
[tomcat-catalina-10.1.19.jar:10.1.19]
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:171)
[tomcat-catalina-10.1.19.jar:10.1.19]
at
org.apache.catalina.core.StandardService.startInternal(StandardService.java:433)
[tomcat-catalina-10.1.19.jar:10.1.19]
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:171)
[tomcat-catalina-10.1.19.jar:10.1.19]
at
org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:921)
[tomcat-catalina-10.1.19.jar:10.1.19]
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:171)
[tomcat-catalina-10.1.19.jar:10.1.19]
at org.apache.catalina.startup.Tomcat.start(Tomcat.java:437)
[tomcat-catalina-10.1.19.jar:10.1.19]
at
org.apache.ofbiz.catalina.container.CatalinaContainer.start(CatalinaContainer.java:136)
[main/:?]
at
org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:153)
[main/:?]
at
org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:77)
[main/:?]
at
org.apache.ofbiz.base.start.StartupControlPanel.loadContainers(StartupControlPanel.java:146)
[main/:?]
at
org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:70)
[main/:?]
[jira] [Commented] (OFBIZ-12935) Test 2.3.33 FreeMarker release
[
https://issues.apache.org/jira/browse/OFBIZ-12935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835627#comment-17835627
]
Gaetan Chaboussie commented on OFBIZ-12935:
---
Hi, new issue detected i think :
{code:java}
freemarker.core.BugException: A bug was detected in FreeMarker; please report
it with stack-trace
at
freemarker.template.Configuration.setServletContextForTemplateLoading(Configuration.java:1667)
~[freemarker-2.3.33-SNAPSHOT.jar:2.3.32.97]
at
org.apache.ofbiz.webapp.ftl.FreeMarkerViewHandler.init(FreeMarkerViewHandler.java:52)
~[main/:?]
at org.apache.ofbiz.webapp.view.ViewFactory.(ViewFactory.java:51)
[main/:?]
at
org.apache.ofbiz.webapp.control.RequestHandler.(RequestHandler.java:103)
[main/:?]
at
org.apache.ofbiz.webapp.control.RequestHandler.getRequestHandler(RequestHandler.java:115)
[main/:?]
at
org.apache.ofbiz.webapp.control.ControlServlet.init(ControlServlet.java:76)
[main/:?]
at jakarta.servlet.GenericServlet.init(GenericServlet.java:143)
[tomcat-servlet-api-10.1.19.jar:6.0]
at jakarta.servlet.http.HttpServlet.init(HttpServlet.java:121)
[tomcat-servlet-api-10.1.19.jar:6.0]
at
org.apache.catalina.core.StandardWrapper.initServlet(StandardWrapper.java:944)
[tomcat-catalina-10.1.19.jar:10.1.19]
at
org.apache.catalina.core.StandardWrapper.loadServlet(StandardWrapper.java:901)
[tomcat-catalina-10.1.19.jar:10.1.19]
at org.apache.catalina.core.StandardWrapper.load(StandardWrapper.java:805)
[tomcat-catalina-10.1.19.jar:10.1.19]
at
org.apache.catalina.core.StandardContext.loadOnStartup(StandardContext.java:4617)
[tomcat-catalina-10.1.19.jar:10.1.19]
at
org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:4910)
[tomcat-catalina-10.1.19.jar:10.1.19]
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:171)
[tomcat-catalina-10.1.19.jar:10.1.19]
at
org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1332)
[tomcat-catalina-10.1.19.jar:10.1.19]
at
org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1322)
[tomcat-catalina-10.1.19.jar:10.1.19]
at java.util.concurrent.FutureTask.run(FutureTask.java:264) [?:?]
at
org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
[tomcat-util-10.1.19.jar:10.1.19]
at
java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:145)
[?:?]
at
org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:866)
[tomcat-catalina-10.1.19.jar:10.1.19]
at
org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:845)
[tomcat-catalina-10.1.19.jar:10.1.19]
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:171)
[tomcat-catalina-10.1.19.jar:10.1.19]
at
org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1332)
[tomcat-catalina-10.1.19.jar:10.1.19]
at
org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1322)
[tomcat-catalina-10.1.19.jar:10.1.19]
at java.util.concurrent.FutureTask.run(FutureTask.java:264) [?:?]
at
org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
[tomcat-util-10.1.19.jar:10.1.19]
at
java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:145)
[?:?]
at
org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:866)
[tomcat-catalina-10.1.19.jar:10.1.19]
at
org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:240)
[tomcat-catalina-10.1.19.jar:10.1.19]
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:171)
[tomcat-catalina-10.1.19.jar:10.1.19]
at
org.apache.catalina.core.StandardService.startInternal(StandardService.java:433)
[tomcat-catalina-10.1.19.jar:10.1.19]
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:171)
[tomcat-catalina-10.1.19.jar:10.1.19]
at
org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:921)
[tomcat-catalina-10.1.19.jar:10.1.19]
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:171)
[tomcat-catalina-10.1.19.jar:10.1.19]
at org.apache.catalina.startup.Tomcat.start(Tomcat.java:437)
[tomcat-catalina-10.1.19.jar:10.1.19]
at
org.apache.ofbiz.catalina.container.CatalinaContainer.start(CatalinaContainer.java:136)
[main/:?]
at
org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:153)
[main/:?]
at
org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:77)
[main/:?]
at
org.apache.ofbiz.base.start.StartupControlPanel.loadContainers(StartupControlPanel.java:146)
[main/:?]
at
org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:70)
[main/:?]
at
[jira] [Updated] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gaetan Chaboussie updated OFBIZ-11067:
--
Attachment:
OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests-1.patch
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch,
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch,
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch,
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch,
> OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch,
> OFBIZ-11067_0018-Turn-UtilObjectTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0019-Merge-UtilObjectUnitTest-into-UtilObjectTes.patch,
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests-1.patch,
>
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests-1.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834946#comment-17834946
]
Gaetan Chaboussie commented on OFBIZ-11067:
---
Hi, during OFBIZ-12991 i stumbled upon two tests classes that escaped
migration, and that wil be necessary for the migration.
here are the two classes (and the patch that fixes tham). Thanks [~pgil] for
the help
[^OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests.patch]
[^OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests.patch]
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch,
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch,
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch,
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch,
> OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch,
> OFBIZ-11067_0018-Turn-UtilObjectTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0019-Merge-UtilObjectUnitTest-into-UtilObjectTes.patch,
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests-1.patch,
>
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests-1.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gaetan Chaboussie updated OFBIZ-11067:
--
Attachment:
OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests-1.patch
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch,
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch,
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch,
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch,
> OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch,
> OFBIZ-11067_0018-Turn-UtilObjectTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0019-Merge-UtilObjectUnitTest-into-UtilObjectTes.patch,
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests-1.patch,
>
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests-1.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gaetan Chaboussie updated OFBIZ-11067:
--
Attachment:
OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests.patch
OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests.patch
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch,
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch,
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch,
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch,
> OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch,
> OFBIZ-11067_0018-Turn-UtilObjectTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0019-Merge-UtilObjectUnitTest-into-UtilObjectTes.patch,
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12989) Update Tomcat Version to 10.1.20
[ https://issues.apache.org/jira/browse/OFBIZ-12989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833921#comment-17833921 ] Gaetan Chaboussie commented on OFBIZ-12989: --- Yeah i just saw that. It will be a large task. > Update Tomcat Version to 10.1.20 > > > Key: OFBIZ-12989 > URL: https://issues.apache.org/jira/browse/OFBIZ-12989 > Project: OFBiz > Issue Type: Improvement > Components: framework/catalina >Affects Versions: Upcoming Branch >Reporter: Gaetan Chaboussie >Priority: Major > > It would be good to upgrade embedded tomcat version to Latest stable 10.1.20. > It implies switching from `javax` package to `jakarta`. So it's no small > change. > > https://tomcat.apache.org/migration-10.html -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12989) Update Tomcat Version to 10.1.20
[ https://issues.apache.org/jira/browse/OFBIZ-12989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833869#comment-17833869 ] Gaetan Chaboussie commented on OFBIZ-12989: --- During the migration work, i noticed that the Juel dependency is not up to date because it uses javax and has not been updated in 10 years. So we should consider migrating it to an other juel implementation, i created an other ticket : OFBIZ-12991 > Update Tomcat Version to 10.1.20 > > > Key: OFBIZ-12989 > URL: https://issues.apache.org/jira/browse/OFBIZ-12989 > Project: OFBiz > Issue Type: Improvement > Components: framework/catalina >Affects Versions: Upcoming Branch >Reporter: Gaetan Chaboussie >Priority: Major > > It would be good to upgrade embedded tomcat version to Latest stable 10.1.20. > It implies switching from `javax` package to `jakarta`. So it's no small > change. > > https://tomcat.apache.org/migration-10.html -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12991) juel upgrade
Gaetan Chaboussie created OFBIZ-12991: - Summary: juel upgrade Key: OFBIZ-12991 URL: https://issues.apache.org/jira/browse/OFBIZ-12991 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Upcoming Branch Reporter: Gaetan Chaboussie During the migration to tomcat 10, i noticed that the JUEL version used in trunk (de.odysseus.juel:juel-spi:2.2.7) has not been updated in 10 years [1] Maybe we should replace it by it's apache-common equivalent ? [2] [1][https://mvnrepository.com/artifact/de.odysseus.juel/juel-impl] [2]https://commons.apache.org/proper/commons-jexl/index.html -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12990) Prometheus connector plugin
Gaetan Chaboussie created OFBIZ-12990: - Summary: Prometheus connector plugin Key: OFBIZ-12990 URL: https://issues.apache.org/jira/browse/OFBIZ-12990 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: Upcoming Branch Reporter: Gaetan Chaboussie We had to make a Prometheus exporter and would like to contribute it. But it requires Tomcat 10 version (see linked ticket) to be cleaner. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12989) Update Tomcat Version to 10.1.20
Gaetan Chaboussie created OFBIZ-12989: - Summary: Update Tomcat Version to 10.1.20 Key: OFBIZ-12989 URL: https://issues.apache.org/jira/browse/OFBIZ-12989 Project: OFBiz Issue Type: Improvement Components: framework/catalina Affects Versions: Upcoming Branch Reporter: Gaetan Chaboussie It would be good to upgrade embedded tomcat version to Latest stable 10.1.20. It implies switching from `javax` package to `jakarta`. So it's no small change. https://tomcat.apache.org/migration-10.html -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12934) Test next FreeMarker release
[
https://issues.apache.org/jira/browse/OFBIZ-12934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831681#comment-17831681
]
Gaetan Chaboussie commented on OFBIZ-12934:
---
Right, i'll be carefull on next issue Jacques. And it seems fixed Daniel !
> Test next FreeMarker release
> -
>
> Key: OFBIZ-12934
> URL: https://issues.apache.org/jira/browse/OFBIZ-12934
> Project: OFBiz
> Issue Type: Task
> Components: Freemarker
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-12934-1.patch
>
>
> h1. {color:#FF8B00}This issue is a "reusable" one, not to be closed...{color}
> It's intended to test next FreeMarker releases [as, for instance, requested
> by the FreeMarker
> team|https://lists.apache.org/thread/t4c9z7wkcp3dbdokmnjd32fcptq8h9tz]
> As it's not an as simple change, here I attach a patch as an exemple based on
> the test requested above: [^OFBIZ-12934-1.patch]
> If you use Eclipse, you also need to update it with the "gradlew eclipse"
> Gradle task
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12934) Test next FreeMarker release
[
https://issues.apache.org/jira/browse/OFBIZ-12934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831365#comment-17831365
]
Gaetan Chaboussie commented on OFBIZ-12934:
---
Sure, here is the relevant code :
The java code is as follows :
https://github.com/apache/ofbiz-framework/blob/65f90adf868701e4420877fe98aba58007315b2a/framework/base/src/main/java/org/apache/ofbiz/base/component/ComponentConfig.java#L1271
So the return type of the method would be an array.
And the FTL code is as follows :
https://github.com/apache/ofbiz-framework/blob/65f90adf868701e4420877fe98aba58007315b2a/themes/rainbowstone/template/includes/TopAppBar.ftl#L57
So there is a non null checker in the beginnig of the block.
With the Freemarker version in patch on top of this ticket I get this error :
{{2024-03-27 14:51:59,697 |jsse-nio-8443-exec-9 |FreeMarkerWorker
|E| null}}
{{{}freemarker.core._TemplateModelException: Java method
"org.apache.ofbiz.base.component.ComponentConfig$WebappInfo.getBasePermission()"
threw an exception when invoked on
org.apache.ofbiz.base.component.ComponentConfig$WebappInfo object
"org.apache.ofbiz.base.component.ComponentConfig$WebappInfo@6127dd1f"; see
cause exception in the Java stack trace.{}}}{{{}{}}}
{{FTL stack trace ("~" means nesting-related):}}
{{ - Failed at: #assign permissions = display.getBase... [in template
"component://rainbowstone/template/includes/TopAppBar.ftl" at line 57, column
21]}}
{{}}
{{ at
freemarker.ext.beans._MethodUtil.newInvocationTemplateModelException(_MethodUtil.java:292)
~[freemarker-2.3.33-SNAPSHOT.jar:2.3.32.97]}}
{{ at
freemarker.ext.beans._MethodUtil.newInvocationTemplateModelException(_MethodUtil.java:255)
~[freemarker-2.3.33-SNAPSHOT.jar:2.3.32.97]}}
{{ at freemarker.ext.beans.SimpleMethodModel.exec(SimpleMethodModel.java:78)
~[freemarker-2.3.33-SNAPSHOT.jar:2.3.32.97]}}
{{ at freemarker.core.MethodCall._eval(MethodCall.java:62)
~[freemarker-2.3.33-SNAPSHOT.jar:2.3.32.97]}}
{{ at freemarker.core.Expression.eval(Expression.java:101)
~[freemarker-2.3.33-SNAPSHOT.jar:2.3.32.97]}}
{{ at freemarker.core.Assignment.accept(Assignment.java:134)
~[freemarker-2.3.33-SNAPSHOT.jar:2.3.32.97]}}
{{ at freemarker.core.Environment.visit(Environment.java:380)
[freemarker-2.3.33-SNAPSHOT.jar:2.3.32.97]}}
{{ at
freemarker.core.IteratorBlock$IterationContext.executedNestedContentForCollOrSeqListing(IteratorBlock.java:291)
[freemarker-2.3.33-SNAPSHOT.jar:2.3.32.97]}}
{{ at
freemarker.core.IteratorBlock$IterationContext.executeNestedContent(IteratorBlock.java:271)
[freemarker-2.3.33-SNAPSHOT.jar:2.3.32.97]}}
{{ at
freemarker.core.IteratorBlock$IterationContext.accept(IteratorBlock.java:244)
[freemarker-2.3.33-SNAPSHOT.jar:2.3.32.97]}}
{{ at freemarker.core.Environment.visitIteratorBlock(Environment.java:654)
[freemarker-2.3.33-SNAPSHOT.jar:2.3.32.97]}}
{{ at freemarker.core.IteratorBlock.acceptWithResult(IteratorBlock.java:108)
[freemarker-2.3.33-SNAPSHOT.jar:2.3.32.97]}}
{{ at freemarker.core.IteratorBlock.accept(IteratorBlock.java:94)
[freemarker-2.3.33-SNAPSHOT.jar:2.3.32.97]}}
{{ at freemarker.core.Environment.visit(Environment.java:344)
[freemarker-2.3.33-SNAPSHOT.jar:2.3.32.97]}}
{{ at freemarker.core.Environment.visit(Environment.java:350)
[freemarker-2.3.33-SNAPSHOT.jar:2.3.32.97]}}
{{ at freemarker.core.Environment.visit(Environment.java:350)
[freemarker-2.3.33-SNAPSHOT.jar:2.3.32.97]}}
{{ at freemarker.core.Environment.visit(Environment.java:350)
[freemarker-2.3.33-SNAPSHOT.jar:2.3.32.97]}}
{{ at freemarker.core.Environment.process(Environment.java:323)
[freemarker-2.3.33-SNAPSHOT.jar:2.3.32.97]}}
{{ at
org.apache.ofbiz.base.util.template.FreeMarkerWorker.renderTemplate(FreeMarkerWorker.java:244)
[main/:?]}}
{{ at
org.apache.ofbiz.widget.model.HtmlWidget.renderHtmlTemplate(HtmlWidget.java:196)
[main/:?]}}
{{ at
org.apache.ofbiz.widget.model.HtmlWidget$HtmlTemplate.renderWidgetString(HtmlWidget.java:266)
[main/:?]}}
{{ at
org.apache.ofbiz.widget.model.HtmlWidget.renderWidgetString(HtmlWidget.java:165)
[main/:?]}}
{{ at
org.apache.ofbiz.widget.model.ModelScreenWidget$PlatformSpecific.renderWidgetString(ModelScreenWidget.java:1371)
[main/:?]}}
{{ at
org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
[main/:?]}}
{{ at
org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:312)
[main/:?]}}
{{ at
org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
[main/:?]}}
{{ at
org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:297)
[main/:?]}}
{{ at
org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:109)
[main/:?]}}
{{ at
[jira] [Commented] (OFBIZ-12934) Test next FreeMarker release
[
https://issues.apache.org/jira/browse/OFBIZ-12934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831211#comment-17831211
]
Gaetan Chaboussie commented on OFBIZ-12934:
---
Hi, i made some tests and have a question. I tried to send it to the [thread
|https://lists.apache.org/thread/t4c9z7wkcp3dbdokmnjd32fcptq8h9tz]but it
doesn't seem to have reach the thread.
so i'm going to make mu return here as well :
While testing i stumbled upon an issue with a list.
Before the version update we had no error doing for example
`<#assign permissions = display.getBasePermissionList()>`
Where `getBasePermissionList` would return an array.
With the new version an error is thrown and we must change the `permission`
from an array to a list.
So my understanding is that a List is required now. Is this a wanted change ?
> Test next FreeMarker release
> -
>
> Key: OFBIZ-12934
> URL: https://issues.apache.org/jira/browse/OFBIZ-12934
> Project: OFBiz
> Issue Type: Task
> Components: Freemarker
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-12934-1.patch
>
>
> h1. {color:#FF8B00}This issue is a "reusable" one, not to be closed...{color}
> It's intended to test next FreeMarker releases [as, for instance, requested
> by the FreeMarker
> team|https://lists.apache.org/thread/t4c9z7wkcp3dbdokmnjd32fcptq8h9tz]
> As it's not an as simple change, here I attach a patch as an exemple based on
> the test requested above: [^OFBIZ-12934-1.patch]
> If you use Eclipse, you also need to update it with the "gradlew eclipse"
> Gradle task
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (OFBIZ-12761) Multi Param Model Service Map
Gaetan Chaboussie created OFBIZ-12761: - Summary: Multi Param Model Service Map Key: OFBIZ-12761 URL: https://issues.apache.org/jira/browse/OFBIZ-12761 Project: OFBiz Issue Type: Improvement Components: framework/service Affects Versions: 22.01.01, Upcoming Branch Reporter: Gaetan Chaboussie Attachments: MultiParamServiceMapAndTest.patch Hello community. We had a use case with the need for validation of IN params of services. For example we had to check that the following service definition was correctly filled. ```xml Service example use case with internal attributes to validate ``` As is, the framework doesn't offer any clean way of doing this, so we implemented some modification to ModelService. So we used TDD to develop the improvement we needed and that may prove a valuable improvement for the framework. Using these tests, we took the opportunity to refactor outdated code using java streams. Please see the patch attached to the ticket containing code and tests. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12679) RuntimeData and RecurrenceInfo not cleaned after job purge
Gaetan Chaboussie created OFBIZ-12679: - Summary: RuntimeData and RecurrenceInfo not cleaned after job purge Key: OFBIZ-12679 URL: https://issues.apache.org/jira/browse/OFBIZ-12679 Project: OFBiz Issue Type: Bug Components: framework/service Affects Versions: 22.01.01, Upcoming Branch Reporter: Gaetan Chaboussie Attachments: Mutualisation_et_correction.patch, Test.patch We noticed that the purging of jobs doesn't clean the related RuntimeData and RecurrenceInfo We created an integration test for development and reproduction of bug, provided in the first patch For the fix, we get the relevant runtimeDataId and recurrenceInfoId to pass to the delegator in getRelatedOne method. See the second patch We also offer a small code rework/ mutualization of the Job related object. Thanks to [~pgil] for his help -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12289) bug on button from catalog to party associated
[ https://issues.apache.org/jira/browse/OFBIZ-12289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386062#comment-17386062 ] Gaetan Chaboussie commented on OFBIZ-12289: --- Here is the patch i suggest : [^OFBIZ-12289.patch] > bug on button from catalog to party associated > -- > > Key: OFBIZ-12289 > URL: https://issues.apache.org/jira/browse/OFBIZ-12289 > Project: OFBiz > Issue Type: Bug > Components: product/catalog >Affects Versions: Trunk >Reporter: Gaetan Chaboussie >Priority: Minor > Attachments: Capture d’écran de 2021-07-23 09-52-58.png, > OFBIZ-12289.patch > > > Problem when trying to access Party linked to Catalog. > When you click on a user associated with a catalog, the framework sends you > to party manager, but it's the currently logged in user that shows up in the > party manager, not the party that you want to see. > To reproduce, just go in the Catalog app, then on Catalogs, add a user to a > catalog, and try to access it via the button. > It comes from the fact that the parameter sent to the party manager via the > link doesn't have the right syntax. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12289) bug on button from catalog to party associated
[ https://issues.apache.org/jira/browse/OFBIZ-12289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gaetan Chaboussie updated OFBIZ-12289: -- Attachment: OFBIZ-12289.patch > bug on button from catalog to party associated > -- > > Key: OFBIZ-12289 > URL: https://issues.apache.org/jira/browse/OFBIZ-12289 > Project: OFBiz > Issue Type: Bug > Components: product/catalog >Affects Versions: Trunk >Reporter: Gaetan Chaboussie >Priority: Minor > Attachments: Capture d’écran de 2021-07-23 09-52-58.png, > OFBIZ-12289.patch > > > Problem when trying to access Party linked to Catalog. > When you click on a user associated with a catalog, the framework sends you > to party manager, but it's the currently logged in user that shows up in the > party manager, not the party that you want to see. > To reproduce, just go in the Catalog app, then on Catalogs, add a user to a > catalog, and try to access it via the button. > It comes from the fact that the parameter sent to the party manager via the > link doesn't have the right syntax. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12289) bug on button from catalog to party associated
Gaetan Chaboussie created OFBIZ-12289: - Summary: bug on button from catalog to party associated Key: OFBIZ-12289 URL: https://issues.apache.org/jira/browse/OFBIZ-12289 Project: OFBiz Issue Type: Bug Components: product/catalog Affects Versions: Trunk Reporter: Gaetan Chaboussie Attachments: Capture d’écran de 2021-07-23 09-52-58.png Problem when trying to access Party linked to Catalog. When you click on a user associated with a catalog, the framework sends you to party manager, but it's the currently logged in user that shows up in the party manager, not the party that you want to see. To reproduce, just go in the Catalog app, then on Catalogs, add a user to a catalog, and try to access it via the button. It comes from the fact that the parameter sent to the party manager via the link doesn't have the right syntax. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12233) Plugin not showing in menu due to permission
[
https://issues.apache.org/jira/browse/OFBIZ-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340884#comment-17340884
]
Gaetan Chaboussie commented on OFBIZ-12233:
---
Here is the correction i suggest, wich is obviously open to review.
> Plugin not showing in menu due to permission
> -
>
> Key: OFBIZ-12233
> URL: https://issues.apache.org/jira/browse/OFBIZ-12233
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Upcoming
> Branch
> Environment: openjdk 11.0.11 2021-04-20
> OpenJDK Runtime Environment (build 11.0.11+9-Ubuntu-0ubuntu2.20.04)
> OpenJDK 64-Bit Server VM (build 11.0.11+9-Ubuntu-0ubuntu2.20.04, mixed mode,
> sharing)
> Ubuntu 20.04.2 LTS
>Reporter: Gaetan Chaboussie
>Priority: Minor
> Attachments: OFBIZ-12233.patch
>
>
> When creating a plugin via gradle :
> {code}
> ./gradlew createPlugin -PpluginId=plugin-test -PpluginResourceName=PluginTest
> -PwebappName=plugin-test -PbasePermission=PLUGIN_TEST
> {code}
> and loading all the required data and permissions, the plugin doesn"t appear
> in the menu.
> I think it comes from the ComponentConfig.java file, L1229, when the
> permissions gets trimmed and modified. Are those lines still useful ?
> I tried removing it locally and it fixed the problem.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-12233) Plugin not showing in menu due to permission
[
https://issues.apache.org/jira/browse/OFBIZ-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gaetan Chaboussie updated OFBIZ-12233:
--
Attachment: OFBIZ-12233.patch
> Plugin not showing in menu due to permission
> -
>
> Key: OFBIZ-12233
> URL: https://issues.apache.org/jira/browse/OFBIZ-12233
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Upcoming
> Branch
> Environment: openjdk 11.0.11 2021-04-20
> OpenJDK Runtime Environment (build 11.0.11+9-Ubuntu-0ubuntu2.20.04)
> OpenJDK 64-Bit Server VM (build 11.0.11+9-Ubuntu-0ubuntu2.20.04, mixed mode,
> sharing)
> Ubuntu 20.04.2 LTS
>Reporter: Gaetan Chaboussie
>Priority: Minor
> Attachments: OFBIZ-12233.patch
>
>
> When creating a plugin via gradle :
> {code}
> ./gradlew createPlugin -PpluginId=plugin-test -PpluginResourceName=PluginTest
> -PwebappName=plugin-test -PbasePermission=PLUGIN_TEST
> {code}
> and loading all the required data and permissions, the plugin doesn"t appear
> in the menu.
> I think it comes from the ComponentConfig.java file, L1229, when the
> permissions gets trimmed and modified. Are those lines still useful ?
> I tried removing it locally and it fixed the problem.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-12233) Plugin not showing in menu due to permission
[
https://issues.apache.org/jira/browse/OFBIZ-12233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gaetan Chaboussie updated OFBIZ-12233:
--
Description:
When creating a plugin via gradle :
{code}
./gradlew createPlugin -PpluginId=plugin-test -PpluginResourceName=PluginTest
-PwebappName=plugin-test -PbasePermission=PLUGIN_TEST
{code}
and loading all the required data and permissions, the plugin doesn"t appear in
the menu.
I think it comes from the ComponentConfig.java file, L1229, when the
permissions gets trimmed and modified. Are those lines still useful ?
I tried removing it locally and it fixed the problem.
was:
When creating a plugin via gradle :
```bash
./gradlew createPlugin -PpluginId=plugin-test -PpluginResourceName=PluginTest
-PwebappName=plugin-test -PbasePermission=PLUGIN_TEST
```
and loading all the required data and permissions, the plugin doesn"t appear in
the menu.
I think it comes from the ComponentConfig.java file, L1229, when the
permissions gets trimmed and modified. Are those lines still useful ?
I tried removing it locally and it fixed the problem.
> Plugin not showing in menu due to permission
> -
>
> Key: OFBIZ-12233
> URL: https://issues.apache.org/jira/browse/OFBIZ-12233
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Upcoming
> Branch
> Environment: openjdk 11.0.11 2021-04-20
> OpenJDK Runtime Environment (build 11.0.11+9-Ubuntu-0ubuntu2.20.04)
> OpenJDK 64-Bit Server VM (build 11.0.11+9-Ubuntu-0ubuntu2.20.04, mixed mode,
> sharing)
> Ubuntu 20.04.2 LTS
>Reporter: Gaetan Chaboussie
>Priority: Minor
>
> When creating a plugin via gradle :
> {code}
> ./gradlew createPlugin -PpluginId=plugin-test -PpluginResourceName=PluginTest
> -PwebappName=plugin-test -PbasePermission=PLUGIN_TEST
> {code}
> and loading all the required data and permissions, the plugin doesn"t appear
> in the menu.
> I think it comes from the ComponentConfig.java file, L1229, when the
> permissions gets trimmed and modified. Are those lines still useful ?
> I tried removing it locally and it fixed the problem.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (OFBIZ-12233) Plugin not showing in menu due to permission
Gaetan Chaboussie created OFBIZ-12233: - Summary: Plugin not showing in menu due to permission Key: OFBIZ-12233 URL: https://issues.apache.org/jira/browse/OFBIZ-12233 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 18.12, Release Branch 17.12, Upcoming Branch Environment: openjdk 11.0.11 2021-04-20 OpenJDK Runtime Environment (build 11.0.11+9-Ubuntu-0ubuntu2.20.04) OpenJDK 64-Bit Server VM (build 11.0.11+9-Ubuntu-0ubuntu2.20.04, mixed mode, sharing) Ubuntu 20.04.2 LTS Reporter: Gaetan Chaboussie When creating a plugin via gradle : ```bash ./gradlew createPlugin -PpluginId=plugin-test -PpluginResourceName=PluginTest -PwebappName=plugin-test -PbasePermission=PLUGIN_TEST ``` and loading all the required data and permissions, the plugin doesn"t appear in the menu. I think it comes from the ComponentConfig.java file, L1229, when the permissions gets trimmed and modified. Are those lines still useful ? I tried removing it locally and it fixed the problem. -- This message was sent by Atlassian Jira (v8.3.4#803005)
