[jira] [Updated] (OFBIZ-12038) Open Screen file from browser
[ https://issues.apache.org/jira/browse/OFBIZ-12038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong updated OFBIZ-12038: --- Attachment: OFBIZ-12038.patch > Open Screen file from browser > - > > Key: OFBIZ-12038 > URL: https://issues.apache.org/jira/browse/OFBIZ-12038 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-12038.patch > > > User can choose to open screen definition file from the browser by clicking > on the named border. Server will send a command to open the source file. > Save time looking for the screen definition file. > This feature depends on setting the following properties correctly > widget.dev.namedBorder > widget.dev.cmd.openSourceFile -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12038) Open Screen file from browser
James Yong created OFBIZ-12038: -- Summary: Open Screen file from browser Key: OFBIZ-12038 URL: https://issues.apache.org/jira/browse/OFBIZ-12038 Project: OFBiz Issue Type: Improvement Components: base Affects Versions: Upcoming Branch Reporter: James Yong Assignee: James Yong Fix For: Upcoming Branch User can choose to open screen definition file from the browser by clicking on the named border. Server will send a command to open the source file. Save time looking for the screen definition file. This feature depends on setting the following properties correctly widget.dev.namedBorder widget.dev.cmd.openSourceFile -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-12018) Open FTL File from browser
[
https://issues.apache.org/jira/browse/OFBIZ-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Yong closed OFBIZ-12018.
--
Resolution: Fixed
> Open FTL File from browser
> ---
>
> Key: OFBIZ-12018
> URL: https://issues.apache.org/jira/browse/OFBIZ-12018
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12018.patch, OFBIZ-12018.patch, OFBIZ-12018.patch
>
>
> Allow developer to open FTL file from the browser by clicking on the filename
> on the named border.
> There are 2 properties involved:
> {code:java}
> # Enable widget named border for development
> # NONE - For production where no named border will be shown.
> # LABEL - Show named border
> # SOURCE - Show named border with link to open the source code
> widget.dev.namedBorder=SOURCE
> # Command template to open file with editor
> # For intellij IDEA use: idea ${sourceLocation}
> widget.dev.cmd.openSourceFile=idea ${sourceLocation}{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12018) Open FTL File from browser
[
https://issues.apache.org/jira/browse/OFBIZ-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206628#comment-17206628
]
James Yong commented on OFBIZ-12018:
Hi Jacques,
Good to know that. Thanks for the testing.
> Open FTL File from browser
> ---
>
> Key: OFBIZ-12018
> URL: https://issues.apache.org/jira/browse/OFBIZ-12018
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12018.patch, OFBIZ-12018.patch, OFBIZ-12018.patch
>
>
> Allow developer to open FTL file from the browser by clicking on the filename
> on the named border.
> There are 2 properties involved:
> {code:java}
> # Enable widget named border for development
> # NONE - For production where no named border will be shown.
> # LABEL - Show named border
> # SOURCE - Show named border with link to open the source code
> widget.dev.namedBorder=SOURCE
> # Command template to open file with editor
> # For intellij IDEA use: idea ${sourceLocation}
> widget.dev.cmd.openSourceFile=idea ${sourceLocation}{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-12031) Move SeoConfigUtil.java from Product to Widget component
[ https://issues.apache.org/jira/browse/OFBIZ-12031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong closed OFBIZ-12031. -- Resolution: Fixed > Move SeoConfigUtil.java from Product to Widget component > > > Key: OFBIZ-12031 > URL: https://issues.apache.org/jira/browse/OFBIZ-12031 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > > SeoConfigUtil contains helper methods for SEO Configuration. > When constructing links like getJs, need to use SeoConfigUtil to check > whether to exclude control path to avoid redirection in ecomseo. > Propose to move SeoConfigUtil from product to widget component. > 2020-10-02 > Webapp component seems a better home for SeoConfigUtil.java than Widget > component. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12018) Open FTL File from browser
[
https://issues.apache.org/jira/browse/OFBIZ-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206579#comment-17206579
]
James Yong commented on OFBIZ-12018:
Hi Jacques,
The request to open file is now stored in data-target attribute which points to
*/ecomseo/openSourceFile* in ecomseo application. Can check if the browser's
*Disable Cache* is enabled?
> Open FTL File from browser
> ---
>
> Key: OFBIZ-12018
> URL: https://issues.apache.org/jira/browse/OFBIZ-12018
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12018.patch, OFBIZ-12018.patch, OFBIZ-12018.patch
>
>
> Allow developer to open FTL file from the browser by clicking on the filename
> on the named border.
> There are 2 properties involved:
> {code:java}
> # Enable widget named border for development
> # NONE - For production where no named border will be shown.
> # LABEL - Show named border
> # SOURCE - Show named border with link to open the source code
> widget.dev.namedBorder=SOURCE
> # Command template to open file with editor
> # For intellij IDEA use: idea ${sourceLocation}
> widget.dev.cmd.openSourceFile=idea ${sourceLocation}{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-12031) Move SeoConfigUtil.java from Product to Widget component
[ https://issues.apache.org/jira/browse/OFBIZ-12031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong updated OFBIZ-12031: --- Description: SeoConfigUtil contains helper methods for SEO Configuration. When constructing links like getJs, need to use SeoConfigUtil to check whether to exclude control path to avoid redirection in ecomseo. Propose to move SeoConfigUtil from product to widget component. 2020-10-02 Webapp component seems a better home for SeoConfigUtil.java than Widget component. was: SeoConfigUtil contains helper methods for SEO Configuration. When constructing links like getJs, need to use SeoConfigUtil to check whether to exclude control path to avoid redirection in ecomseo. Propose to move SeoConfigUtil from product to widget component. > Move SeoConfigUtil.java from Product to Widget component > > > Key: OFBIZ-12031 > URL: https://issues.apache.org/jira/browse/OFBIZ-12031 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > > SeoConfigUtil contains helper methods for SEO Configuration. > When constructing links like getJs, need to use SeoConfigUtil to check > whether to exclude control path to avoid redirection in ecomseo. > Propose to move SeoConfigUtil from product to widget component. > 2020-10-02 > Webapp component seems a better home for SeoConfigUtil.java than Widget > component. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12031) Move SeoConfigUtil.java from Product to Widget component
[ https://issues.apache.org/jira/browse/OFBIZ-12031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206156#comment-17206156 ] James Yong commented on OFBIZ-12031: Hi Jacques, No worry. Thanks. > Move SeoConfigUtil.java from Product to Widget component > > > Key: OFBIZ-12031 > URL: https://issues.apache.org/jira/browse/OFBIZ-12031 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > > SeoConfigUtil contains helper methods for SEO Configuration. > When constructing links like getJs, need to use SeoConfigUtil to check > whether to exclude control path to avoid redirection in ecomseo. > Propose to move SeoConfigUtil from product to widget component. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12018) Open FTL File from browser
[
https://issues.apache.org/jira/browse/OFBIZ-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206142#comment-17206142
]
James Yong commented on OFBIZ-12018:
Hi Jacques,
Thanks for the access.log.
I think the problem should be resolved now.
> Open FTL File from browser
> ---
>
> Key: OFBIZ-12018
> URL: https://issues.apache.org/jira/browse/OFBIZ-12018
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12018.patch, OFBIZ-12018.patch, OFBIZ-12018.patch
>
>
> Allow developer to open FTL file from the browser by clicking on the filename
> on the named border.
> There are 2 properties involved:
> {code:java}
> # Enable widget named border for development
> # NONE - For production where no named border will be shown.
> # LABEL - Show named border
> # SOURCE - Show named border with link to open the source code
> widget.dev.namedBorder=SOURCE
> # Command template to open file with editor
> # For intellij IDEA use: idea ${sourceLocation}
> widget.dev.cmd.openSourceFile=idea ${sourceLocation}{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12018) Open FTL File from browser
[
https://issues.apache.org/jira/browse/OFBIZ-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205443#comment-17205443
]
James Yong commented on OFBIZ-12018:
Hi Jacques,
I believe it is a cache issue, since js file is updated.
If you are using Chrome, can go to Developer Tools -> Network tab and set
"Disable cache" to true?
> Open FTL File from browser
> ---
>
> Key: OFBIZ-12018
> URL: https://issues.apache.org/jira/browse/OFBIZ-12018
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12018.patch, OFBIZ-12018.patch, OFBIZ-12018.patch
>
>
> Allow developer to open FTL file from the browser by clicking on the filename
> on the named border.
> There are 2 properties involved:
> {code:java}
> # Enable widget named border for development
> # NONE - For production where no named border will be shown.
> # LABEL - Show named border
> # SOURCE - Show named border with link to open the source code
> widget.dev.namedBorder=SOURCE
> # Command template to open file with editor
> # For intellij IDEA use: idea ${sourceLocation}
> widget.dev.cmd.openSourceFile=idea ${sourceLocation}{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12031) Move SeoConfigUtil.java from Product to Widget component
[ https://issues.apache.org/jira/browse/OFBIZ-12031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17204698#comment-17204698 ] James Yong commented on OFBIZ-12031: Hi Jacques, I introduced a dependency on SeoConfigUtil.java for HtmlWidget.java at commit 91d8a2f02ab9b7366a722e29feaeba7661468614. Moving SeoConfigUtil to Widget component will fix this issue. > Move SeoConfigUtil.java from Product to Widget component > > > Key: OFBIZ-12031 > URL: https://issues.apache.org/jira/browse/OFBIZ-12031 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > > SeoConfigUtil contains helper methods for SEO Configuration. > When constructing links like getJs, need to use SeoConfigUtil to check > whether to exclude control path to avoid redirection in ecomseo. > Propose to move SeoConfigUtil from product to widget component. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12018) Open FTL File from browser
[
https://issues.apache.org/jira/browse/OFBIZ-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17204676#comment-17204676
]
James Yong commented on OFBIZ-12018:
Hi Jacques,
I believe the named border for ecomseo should be ok now.
> Open FTL File from browser
> ---
>
> Key: OFBIZ-12018
> URL: https://issues.apache.org/jira/browse/OFBIZ-12018
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12018.patch, OFBIZ-12018.patch, OFBIZ-12018.patch
>
>
> Allow developer to open FTL file from the browser by clicking on the filename
> on the named border.
> There are 2 properties involved:
> {code:java}
> # Enable widget named border for development
> # NONE - For production where no named border will be shown.
> # LABEL - Show named border
> # SOURCE - Show named border with link to open the source code
> widget.dev.namedBorder=SOURCE
> # Command template to open file with editor
> # For intellij IDEA use: idea ${sourceLocation}
> widget.dev.cmd.openSourceFile=idea ${sourceLocation}{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-12031) Move SeoConfigUtil.java from Product to Widget component
[ https://issues.apache.org/jira/browse/OFBIZ-12031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong updated OFBIZ-12031: --- Description: SeoConfigUtil contains helper methods for SEO Configuration. When constructing links like getJs, need to use SeoConfigUtil to check whether to exclude control path to avoid redirection in ecomseo. Propose to move SeoConfigUtil from product to widget component. was: SeoConfigUtil contains helper methods for SEO Configuration. When constructing links like getJs, need to use SeoConfigUtil to check whether to include control path to avoid redirection in ecomseo. Propose to move SeoConfigUtil from product to widget component. > Move SeoConfigUtil.java from Product to Widget component > > > Key: OFBIZ-12031 > URL: https://issues.apache.org/jira/browse/OFBIZ-12031 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > > SeoConfigUtil contains helper methods for SEO Configuration. > When constructing links like getJs, need to use SeoConfigUtil to check > whether to exclude control path to avoid redirection in ecomseo. > Propose to move SeoConfigUtil from product to widget component. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12031) Move SeoConfigUtil.java from Product to Widget component
James Yong created OFBIZ-12031: -- Summary: Move SeoConfigUtil.java from Product to Widget component Key: OFBIZ-12031 URL: https://issues.apache.org/jira/browse/OFBIZ-12031 Project: OFBiz Issue Type: Improvement Components: base Affects Versions: Upcoming Branch Reporter: James Yong Assignee: James Yong Fix For: Upcoming Branch SeoConfigUtil contains helper methods for SEO Configuration. When constructing links like getJs, need to use SeoConfigUtil to check whether to include control path to avoid redirection in ecomseo. Propose to move SeoConfigUtil from product to widget component. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12018) Open FTL File from browser
[
https://issues.apache.org/jira/browse/OFBIZ-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17203252#comment-17203252
]
James Yong commented on OFBIZ-12018:
Hi Jacques,
Still WIP for named borders in ecomseo.
Regards,
James
> Open FTL File from browser
> ---
>
> Key: OFBIZ-12018
> URL: https://issues.apache.org/jira/browse/OFBIZ-12018
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12018.patch, OFBIZ-12018.patch, OFBIZ-12018.patch
>
>
> Allow developer to open FTL file from the browser by clicking on the filename
> on the named border.
> There are 2 properties involved:
> {code:java}
> # Enable widget named border for development
> # NONE - For production where no named border will be shown.
> # LABEL - Show named border
> # SOURCE - Show named border with link to open the source code
> widget.dev.namedBorder=SOURCE
> # Command template to open file with editor
> # For intellij IDEA use: idea ${sourceLocation}
> widget.dev.cmd.openSourceFile=idea ${sourceLocation}{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12018) Open FTL File from browser
[
https://issues.apache.org/jira/browse/OFBIZ-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202491#comment-17202491
]
James Yong commented on OFBIZ-12018:
Hi Jacques,
Can you find
{code:java}
{code}
in
{code:java}
plugins/ecommerce/webapp/ecommerce/WEB-INF/controller.xml{code}
file ?
> Open FTL File from browser
> ---
>
> Key: OFBIZ-12018
> URL: https://issues.apache.org/jira/browse/OFBIZ-12018
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12018.patch, OFBIZ-12018.patch, OFBIZ-12018.patch
>
>
> Allow developer to open FTL file from the browser by clicking on the filename
> on the named border.
> There are 2 properties involved:
> {code:java}
> # Enable widget named border for development
> # NONE - For production where no named border will be shown.
> # LABEL - Show named border
> # SOURCE - Show named border with link to open the source code
> widget.dev.namedBorder=SOURCE
> # Command template to open file with editor
> # For intellij IDEA use: idea ${sourceLocation}
> widget.dev.cmd.openSourceFile=idea ${sourceLocation}{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12018) Open FTL File from browser
[
https://issues.apache.org/jira/browse/OFBIZ-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202221#comment-17202221
]
James Yong commented on OFBIZ-12018:
Hi Jacques,
Didn't encountered StringIndexOutOfBoundsException error after commit
d7a5d601bd9c07fa26f4f0d737841f651d749bff. Let me know what is value of the path
variable before the error hits.
Updated both OFBIZ-FRAMEWORK and OFBIZ-PLUGINS projects.
Kindly try again.
Regards,
James
> Open FTL File from browser
> ---
>
> Key: OFBIZ-12018
> URL: https://issues.apache.org/jira/browse/OFBIZ-12018
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12018.patch, OFBIZ-12018.patch, OFBIZ-12018.patch
>
>
> Allow developer to open FTL file from the browser by clicking on the filename
> on the named border.
> There are 2 properties involved:
> {code:java}
> # Enable widget named border for development
> # NONE - For production where no named border will be shown.
> # LABEL - Show named border
> # SOURCE - Show named border with link to open the source code
> widget.dev.namedBorder=SOURCE
> # Command template to open file with editor
> # For intellij IDEA use: idea ${sourceLocation}
> widget.dev.cmd.openSourceFile=idea ${sourceLocation}{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12018) Open FTL File from browser
[
https://issues.apache.org/jira/browse/OFBIZ-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201874#comment-17201874
]
James Yong commented on OFBIZ-12018:
Hi Jacques,
Sorry, will check with a Windows machine soonest.
Regards,
James
> Open FTL File from browser
> ---
>
> Key: OFBIZ-12018
> URL: https://issues.apache.org/jira/browse/OFBIZ-12018
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12018.patch, OFBIZ-12018.patch, OFBIZ-12018.patch
>
>
> Allow developer to open FTL file from the browser by clicking on the filename
> on the named border.
> There are 2 properties involved:
> {code:java}
> # Enable widget named border for development
> # NONE - For production where no named border will be shown.
> # LABEL - Show named border
> # SOURCE - Show named border with link to open the source code
> widget.dev.namedBorder=SOURCE
> # Command template to open file with editor
> # For intellij IDEA use: idea ${sourceLocation}
> widget.dev.cmd.openSourceFile=idea ${sourceLocation}{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12018) Open FTL File from browser
[
https://issues.apache.org/jira/browse/OFBIZ-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199695#comment-17199695
]
James Yong commented on OFBIZ-12018:
Hi Jacques,
As mentioned in OFBIZ-12002, this property will be disabled.
> Open FTL File from browser
> ---
>
> Key: OFBIZ-12018
> URL: https://issues.apache.org/jira/browse/OFBIZ-12018
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12018.patch, OFBIZ-12018.patch, OFBIZ-12018.patch
>
>
> Allow developer to open FTL file from the browser by clicking on the filename
> on the named border.
> There are 2 properties involved:
> {code:java}
> # Enable widget named border for development
> # NONE - For production where no named border will be shown.
> # LABEL - Show named border
> # SOURCE - Show named border with link to open the source code
> widget.dev.namedBorder=SOURCE
> # Command template to open file with editor
> # For intellij IDEA use: idea ${sourceLocation}
> widget.dev.cmd.openSourceFile=idea ${sourceLocation}{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-12018) Open FTL File from browser
[
https://issues.apache.org/jira/browse/OFBIZ-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Yong updated OFBIZ-12018:
---
Attachment: OFBIZ-12018.patch
> Open FTL File from browser
> ---
>
> Key: OFBIZ-12018
> URL: https://issues.apache.org/jira/browse/OFBIZ-12018
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12018.patch, OFBIZ-12018.patch, OFBIZ-12018.patch
>
>
> Allow developer to open FTL file from the browser by clicking on the filename
> on the named border.
> There are 2 properties involved:
> {code:java}
> # Enable widget named border for development
> # NONE - For production where no named border will be shown.
> # LABEL - Show named border
> # SOURCE - Show named border with link to open the source code
> widget.dev.namedBorder=SOURCE
> # Command template to open file with editor
> # For intellij IDEA use: idea ${sourceLocation}
> widget.dev.cmd.openSourceFile=idea ${sourceLocation}{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-12002) Show border and file name for content rendered from ftl
[ https://issues.apache.org/jira/browse/OFBIZ-12002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong updated OFBIZ-12002: --- Description: Currently there are before and after comments in the page source to mark the begin and end of FTL template. Easier for development to display FTL file name and boundary on screen for a short time. Only works for FTL files outside of theme folders, and when -1) print.verbose=true and- widget.dev.namedBorder=true -2) widget.verbose=true- Note: After OFBIZ-12018, widget.dev.namedBorder = NONE | LABEL | SOURCE was: Currently there are before and after comments in the page source to mark the begin and end of FTL template. Easier for development to display FTL file name and boundary on screen for a short time. Only works for FTL files outside of theme folders, and when -1) print.verbose=true and- widget.dev.namedBorder=true -2) widget.verbose=true- > Show border and file name for content rendered from ftl > --- > > Key: OFBIZ-12002 > URL: https://issues.apache.org/jira/browse/OFBIZ-12002 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-12002.patch > > > Currently there are before and after comments in the page source to mark the > begin and end of FTL template. Easier for development to display FTL file > name and boundary on screen for a short time. > Only works for FTL files outside of theme folders, and when > -1) print.verbose=true and- widget.dev.namedBorder=true > -2) widget.verbose=true- > Note: > After OFBIZ-12018, widget.dev.namedBorder = NONE | LABEL | SOURCE -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12002) Show border and file name for content rendered from ftl
[ https://issues.apache.org/jira/browse/OFBIZ-12002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199319#comment-17199319 ] James Yong commented on OFBIZ-12002: Hi Jacques, Will disable the property at OFBIZ-12018. After OFBIZ-12018, widget.dev.namedBorder will be NONE | LABEL | SOURCE > Show border and file name for content rendered from ftl > --- > > Key: OFBIZ-12002 > URL: https://issues.apache.org/jira/browse/OFBIZ-12002 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-12002.patch > > > Currently there are before and after comments in the page source to mark the > begin and end of FTL template. Easier for development to display FTL file > name and boundary on screen for a short time. > Only works for FTL files outside of theme folders, and when > -1) print.verbose=true and- widget.dev.namedBorder=true > -2) widget.verbose=true- -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12002) Show border and file name for content rendered from ftl
[ https://issues.apache.org/jira/browse/OFBIZ-12002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong updated OFBIZ-12002: --- Description: Currently there are before and after comments in the page source to mark the begin and end of FTL template. Easier for development to display FTL file name and boundary on screen for a short time. Only works for FTL files outside of theme folders, and when -1) print.verbose=true and- widget.dev.namedBorder=true -2) widget.verbose=true- was: Currently there are before and after comments in the page source to mark the begin and end of FTL template. Easier for development to display FTL file name and boundary on screen for a short time. Only works for FTL files outside of theme folders, and when 1) print.verbose=true and 2) widget.verbose=true > Show border and file name for content rendered from ftl > --- > > Key: OFBIZ-12002 > URL: https://issues.apache.org/jira/browse/OFBIZ-12002 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-12002.patch > > > Currently there are before and after comments in the page source to mark the > begin and end of FTL template. Easier for development to display FTL file > name and boundary on screen for a short time. > Only works for FTL files outside of theme folders, and when > -1) print.verbose=true and- widget.dev.namedBorder=true > -2) widget.verbose=true- -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12018) Open FTL File from browser
[
https://issues.apache.org/jira/browse/OFBIZ-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Yong updated OFBIZ-12018:
---
Attachment: OFBIZ-12018.patch
> Open FTL File from browser
> ---
>
> Key: OFBIZ-12018
> URL: https://issues.apache.org/jira/browse/OFBIZ-12018
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12018.patch, OFBIZ-12018.patch
>
>
> Allow developer to open FTL file from the browser by clicking on the filename
> on the named border.
> There are 2 properties involved:
> {code:java}
> # Enable widget named border for development
> # NONE - For production where no named border will be shown.
> # LABEL - Show named border
> # SOURCE - Show named border with link to open the source code
> widget.dev.namedBorder=SOURCE
> # Command template to open file with editor
> # For intellij IDEA use: idea ${sourceLocation}
> widget.dev.cmd.openSourceFile=idea ${sourceLocation}{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12018) Open FTL File from browser
[
https://issues.apache.org/jira/browse/OFBIZ-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198673#comment-17198673
]
James Yong commented on OFBIZ-12018:
Discussion started at
https://lists.apache.org/thread.html/r5f206626c321a7bd2ea2bc51b8f2fe72aef021b61d0e61d5cce53197%40%3Cdev.ofbiz.apache.org%3E
> Open FTL File from browser
> ---
>
> Key: OFBIZ-12018
> URL: https://issues.apache.org/jira/browse/OFBIZ-12018
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12018.patch
>
>
> Allow developer to open FTL file from the browser by clicking on the filename
> on the named border.
> There are 2 properties involved:
> {code:java}
> # Enable widget named border for development
> # NONE - For production where no named border will be shown.
> # LABEL - Show named border
> # SOURCE - Show named border with link to open the source code
> widget.dev.namedBorder=SOURCE
> # Command template to open file with editor
> # For intellij IDEA use: idea ${sourceLocation}
> widget.dev.cmd.openSourceFile=idea ${sourceLocation}{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-12018) Open FTL File from browser
[
https://issues.apache.org/jira/browse/OFBIZ-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198671#comment-17198671
]
James Yong edited comment on OFBIZ-12018 at 9/19/20, 7:14 AM:
--
References:
https://www.jetbrains.com/help/idea/opening-files-from-command-line.html
https://www.cnet.com/news/prevent-an-applications-dock-icons-from-showing-in-os-x/
to prevent multiple Dock icons of the same application.
https://wiki.eclipse.org/Eclipse/OpenFileFeature
was (Author: jamesyong):
References:
https://www.jetbrains.com/help/idea/opening-files-from-command-line.html
https://www.cnet.com/news/prevent-an-applications-dock-icons-from-showing-in-os-x/
> Open FTL File from browser
> ---
>
> Key: OFBIZ-12018
> URL: https://issues.apache.org/jira/browse/OFBIZ-12018
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12018.patch
>
>
> Allow developer to open FTL file from the browser by clicking on the filename
> on the named border.
> There are 2 properties involved:
> {code:java}
> # Enable widget named border for development
> # NONE - For production where no named border will be shown.
> # LABEL - Show named border
> # SOURCE - Show named border with link to open the source code
> widget.dev.namedBorder=SOURCE
> # Command template to open file with editor
> # For intellij IDEA use: idea ${sourceLocation}
> widget.dev.cmd.openSourceFile=idea ${sourceLocation}{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12018) Open FTL File from browser
[
https://issues.apache.org/jira/browse/OFBIZ-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198671#comment-17198671
]
James Yong commented on OFBIZ-12018:
References:
https://www.jetbrains.com/help/idea/opening-files-from-command-line.html
https://www.cnet.com/news/prevent-an-applications-dock-icons-from-showing-in-os-x/
> Open FTL File from browser
> ---
>
> Key: OFBIZ-12018
> URL: https://issues.apache.org/jira/browse/OFBIZ-12018
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12018.patch
>
>
> Allow developer to open FTL file from the browser by clicking on the filename
> on the named border.
> There are 2 properties involved:
> {code:java}
> # Enable widget named border for development
> # NONE - For production where no named border will be shown.
> # LABEL - Show named border
> # SOURCE - Show named border with link to open the source code
> widget.dev.namedBorder=SOURCE
> # Command template to open file with editor
> # For intellij IDEA use: idea ${sourceLocation}
> widget.dev.cmd.openSourceFile=idea ${sourceLocation}{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-12018) Open FTL File from browser
[
https://issues.apache.org/jira/browse/OFBIZ-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Yong updated OFBIZ-12018:
---
Attachment: OFBIZ-12018.patch
> Open FTL File from browser
> ---
>
> Key: OFBIZ-12018
> URL: https://issues.apache.org/jira/browse/OFBIZ-12018
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12018.patch
>
>
> Allow developer to open FTL file from the browser by clicking on the filename
> on the named border.
> There are 2 properties involved:
> {code:java}
> # Enable widget named border for development
> # NONE - For production where no named border will be shown.
> # LABEL - Show named border
> # SOURCE - Show named border with link to open the source code
> widget.dev.namedBorder=SOURCE
> # Command template to open file with editor
> # For intellij IDEA use: idea ${sourceLocation}
> widget.dev.cmd.openSourceFile=idea ${sourceLocation}{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (OFBIZ-12018) Open FTL File from browser
James Yong created OFBIZ-12018:
--
Summary: Open FTL File from browser
Key: OFBIZ-12018
URL: https://issues.apache.org/jira/browse/OFBIZ-12018
Project: OFBiz
Issue Type: Improvement
Components: base
Affects Versions: Upcoming Branch
Reporter: James Yong
Assignee: James Yong
Fix For: Upcoming Branch
Allow developer to open FTL file from the browser by clicking on the filename
on the named border.
There are 2 properties involved:
{code:java}
# Enable widget named border for development
# NONE - For production where no named border will be shown.
# LABEL - Show named border
# SOURCE - Show named border with link to open the source code
widget.dev.namedBorder=SOURCE
# Command template to open file with editor
# For intellij IDEA use: idea ${sourceLocation}
widget.dev.cmd.openSourceFile=idea ${sourceLocation}{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12017) Replaces moment.js with a newer librairy
[ https://issues.apache.org/jira/browse/OFBIZ-12017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198667#comment-17198667 ] James Yong commented on OFBIZ-12017: +1 Use of moment js library in OFBiz is also minimum at present. > Replaces moment.js with a newer librairy > > > Key: OFBIZ-12017 > URL: https://issues.apache.org/jira/browse/OFBIZ-12017 > Project: OFBiz > Issue Type: Improvement > Components: themes >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > This [article, from moment.js team itself, explains why > |https://momentjs.com/docs/#/-project-status/]and suggest this: > https://twitter.com/addyosmani/status/1304676118822174721/photo/1 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11686) multi-block attribute for html-template tag
[
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Yong closed OFBIZ-11686.
--
Resolution: Fixed
> multi-block attribute for html-template tag
> ---
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
> Issue Type: Improvement
> Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new widget tag that adds an external script after
> body tag.
> The external script will contain the rendered result of the specified
> template file location.
> e.g.
> {code:xml}
>
>
> {code}
>
> will render as:
> {code:xml}
>
> type="application/javascript"/>
>
> {code}
> This will allow inline script from a freemarker file, to be rendered as
> external script in html.
>
> Discussion was started at
> [https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]
>
> *15th May 2020*
> While extracting the scripts from html-template to script-template and
> testing the changes, I found the process to be cumbersome.
> So I made a change not to use script-template tag but add a multi-block
> attribute to html-template tag.
> When *multi-block=true*, inline scripts will be extracted automatically from
> script tag and converted to external script.
> So no need to manually extract script from the existing freemarker template.
> Coding for script-template tag is removed
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-12002) Show border and file name for content rendered from ftl
[ https://issues.apache.org/jira/browse/OFBIZ-12002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong closed OFBIZ-12002. -- Resolution: Fixed > Show border and file name for content rendered from ftl > --- > > Key: OFBIZ-12002 > URL: https://issues.apache.org/jira/browse/OFBIZ-12002 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-12002.patch > > > Currently there are before and after comments in the page source to mark the > begin and end of FTL template. Easier for development to display FTL file > name and boundary on screen for a short time. > Only works for FTL files outside of theme folders, and when > 1) print.verbose=true and > 2) widget.verbose=true -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-12015) Remove formatBoundaryComment function in HtmlWidgetRenderer class
[ https://issues.apache.org/jira/browse/OFBIZ-12015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong closed OFBIZ-12015. -- Resolution: Fixed > Remove formatBoundaryComment function in HtmlWidgetRenderer class > - > > Key: OFBIZ-12015 > URL: https://issues.apache.org/jira/browse/OFBIZ-12015 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-12015.patch > > > Both *buildBoundaryComment* (instance) and *formatBoundaryComment* (static) > functions in HtmlWidgetRenderer class, do the same thing. > Simplify code by changing *buildBoundaryComment* function to static, and > remove *formatBoundaryComment* function. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12015) Remove formatBoundaryComment function in HtmlWidgetRenderer class
[ https://issues.apache.org/jira/browse/OFBIZ-12015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong updated OFBIZ-12015: --- Attachment: OFBIZ-12015.patch > Remove formatBoundaryComment function in HtmlWidgetRenderer class > - > > Key: OFBIZ-12015 > URL: https://issues.apache.org/jira/browse/OFBIZ-12015 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-12015.patch > > > Both *buildBoundaryComment* (instance) and *formatBoundaryComment* (static) > functions in HtmlWidgetRenderer class, do the same thing. > Simplify code by changing *buildBoundaryComment* function to static, and > remove *formatBoundaryComment* function. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12015) Remove formatBoundaryComment function in HtmlWidgetRenderer class
James Yong created OFBIZ-12015: -- Summary: Remove formatBoundaryComment function in HtmlWidgetRenderer class Key: OFBIZ-12015 URL: https://issues.apache.org/jira/browse/OFBIZ-12015 Project: OFBiz Issue Type: Improvement Components: base Affects Versions: Upcoming Branch Reporter: James Yong Assignee: James Yong Fix For: Upcoming Branch Both *buildBoundaryComment* (instance) and *formatBoundaryComment* (static) functions in HtmlWidgetRenderer class, do the same thing. Simplify code by changing *buildBoundaryComment* function to static, and remove *formatBoundaryComment* function. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12002) Show border and file name for content rendered from ftl
[ https://issues.apache.org/jira/browse/OFBIZ-12002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong updated OFBIZ-12002: --- Summary: Show border and file name for content rendered from ftl (was: Add border and file name to content rendered from ftl) > Show border and file name for content rendered from ftl > --- > > Key: OFBIZ-12002 > URL: https://issues.apache.org/jira/browse/OFBIZ-12002 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-12002.patch > > > Currently there are before and after comments in the page source to mark the > begin and end of FTL template. Easier for development to display FTL file > name and boundary on screen for a short time. > Only works for FTL files outside of theme folders, and when > 1) print.verbose=true and > 2) widget.verbose=true -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12002) Add border and file name to content rendered from ftl
[ https://issues.apache.org/jira/browse/OFBIZ-12002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194642#comment-17194642 ] James Yong commented on OFBIZ-12002: Hi Jacques, Added getThemeXmlFiles method yesterday. Can try update from trunk? > Add border and file name to content rendered from ftl > - > > Key: OFBIZ-12002 > URL: https://issues.apache.org/jira/browse/OFBIZ-12002 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-12002.patch > > > Currently there are before and after comments in the page source to mark the > begin and end of FTL template. Easier for development to display FTL file > name and boundary on screen for a short time. > Only works for FTL files outside of theme folders, and when > 1) print.verbose=true and > 2) widget.verbose=true -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12002) Add border and file name to content rendered from ftl
[ https://issues.apache.org/jira/browse/OFBIZ-12002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194317#comment-17194317 ] James Yong commented on OFBIZ-12002: Started discussion at https://lists.apache.org/thread.html/rbb58ffcfef401cc6692f5964156883c1e540bc432a8fdc01789efc78%40%3Cdev.ofbiz.apache.org%3E > Add border and file name to content rendered from ftl > - > > Key: OFBIZ-12002 > URL: https://issues.apache.org/jira/browse/OFBIZ-12002 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-12002.patch > > > Currently there are before and after comments in the page source to mark the > begin and end of FTL template. Easier for development to display FTL file > name and boundary on screen for a short time. > Only works for FTL files outside of theme folders, and when > 1) print.verbose=true and > 2) widget.verbose=true -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12002) Add border and file name to content rendered from ftl
[ https://issues.apache.org/jira/browse/OFBIZ-12002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong updated OFBIZ-12002: --- Summary: Add border and file name to content rendered from ftl (was: Labelling of FTL file name on screen) > Add border and file name to content rendered from ftl > - > > Key: OFBIZ-12002 > URL: https://issues.apache.org/jira/browse/OFBIZ-12002 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-12002.patch > > > Currently there are before and after comments in the page source to mark the > begin and end of FTL template. Easier for development to display FTL file > name and boundary on screen for a short time. > Only works for FTL files outside of theme folders, and when > 1) print.verbose=true and > 2) widget.verbose=true -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12002) Labelling of FTL file name on screen
[ https://issues.apache.org/jira/browse/OFBIZ-12002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong updated OFBIZ-12002: --- Attachment: OFBIZ-12002.patch > Labelling of FTL file name on screen > > > Key: OFBIZ-12002 > URL: https://issues.apache.org/jira/browse/OFBIZ-12002 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-12002.patch > > > Currently there are before and after comments in the page source to mark the > begin and end of FTL template. Easier for development to display FTL file > name and boundary on screen for a short time. > Only works for FTL files outside of theme folders, and when > 1) print.verbose=true and > 2) widget.verbose=true -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11996) Well-formed html in ftl template
[ https://issues.apache.org/jira/browse/OFBIZ-11996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong updated OFBIZ-11996: --- Description: Check for well-formed html in ftl templates to catch programming errors. To test, set print.verbose=true and start up ofbiz. Misformed HTML fragments are logged as warnings. was: Check for well-formed html in ftl templates to catch programming errors. To test, set print.verbose=true and start up ofbiz. Then navigate to the page and search for ^^^ in the log console. > Well-formed html in ftl template > > > Key: OFBIZ-11996 > URL: https://issues.apache.org/jira/browse/OFBIZ-11996 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11996.patch > > > Check for well-formed html in ftl templates to catch programming errors. > To test, set print.verbose=true and start up ofbiz. > Misformed HTML fragments are logged as warnings. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-7004) Allow to accept CDATA
[ https://issues.apache.org/jira/browse/OFBIZ-7004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong reassigned OFBIZ-7004: - Assignee: James Yong (was: Jacques Le Roux) > Allow to accept CDATA > - > > Key: OFBIZ-7004 > URL: https://issues.apache.org/jira/browse/OFBIZ-7004 > Project: OFBiz > Issue Type: Improvement > Components: framework/widget >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Attachments: OFBIZ-7004.patch, OFBIZ-7004.patch > > > Currently, html-template tag accepts a location attribute. > Propose that the html-template tag also accepts CDATA content. > OFBiz will look for CDATA content if the location attribute is empty. > > The advantage is that we need not create a .ftl file whenever we add some > html contents into the screen widget. > I need some opinions before starting work on this. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-7004) Allow to accept CDATA
[ https://issues.apache.org/jira/browse/OFBIZ-7004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong closed OFBIZ-7004. - Fix Version/s: Upcoming Branch Resolution: Fixed > Allow to accept CDATA > - > > Key: OFBIZ-7004 > URL: https://issues.apache.org/jira/browse/OFBIZ-7004 > Project: OFBiz > Issue Type: Improvement > Components: framework/widget >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-7004.patch, OFBIZ-7004.patch > > > Currently, html-template tag accepts a location attribute. > Propose that the html-template tag also accepts CDATA content. > OFBiz will look for CDATA content if the location attribute is empty. > > The advantage is that we need not create a .ftl file whenever we add some > html contents into the screen widget. > I need some opinions before starting work on this. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12002) Labelling of FTL file name on screen
James Yong created OFBIZ-12002: -- Summary: Labelling of FTL file name on screen Key: OFBIZ-12002 URL: https://issues.apache.org/jira/browse/OFBIZ-12002 Project: OFBiz Issue Type: Improvement Components: base Affects Versions: Upcoming Branch Reporter: James Yong Assignee: James Yong Fix For: Upcoming Branch Currently there are before and after comments in the page source to mark the begin and end of FTL template. Easier for development to display FTL file name and boundary on screen for a short time. Only works for FTL files outside of theme folders, and when 1) print.verbose=true and 2) widget.verbose=true -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11996) Well-formed html in ftl template
[ https://issues.apache.org/jira/browse/OFBIZ-11996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191758#comment-17191758 ] James Yong commented on OFBIZ-11996: Agree parameterized list is better. Thanks Jacques. > Well-formed html in ftl template > > > Key: OFBIZ-11996 > URL: https://issues.apache.org/jira/browse/OFBIZ-11996 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11996.patch > > > Check for well-formed html in ftl templates to catch programming errors. > To test, set print.verbose=true and start up ofbiz. > Then navigate to the page and search for ^^^ in the log console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11996) Well-formed html in ftl template
[
https://issues.apache.org/jira/browse/OFBIZ-11996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191237#comment-17191237
]
James Yong commented on OFBIZ-11996:
Hi Jacques,
Thanks for letting me know about SpotBugs.
I am using Intellij which indicates the casting is redundant.
{code:java}
ParseErrorList list = (ParseErrorList) parser.getErrors();
{code}
> Well-formed html in ftl template
>
>
> Key: OFBIZ-11996
> URL: https://issues.apache.org/jira/browse/OFBIZ-11996
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11996.patch
>
>
> Check for well-formed html in ftl templates to catch programming errors.
> To test, set print.verbose=true and start up ofbiz.
> Then navigate to the page and search for ^^^ in the log console.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11996) Well-formed html in ftl template
[ https://issues.apache.org/jira/browse/OFBIZ-11996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong updated OFBIZ-11996: --- Description: Check for well-formed html in ftl templates to catch programming errors. To test, set print.verbose=true and start up ofbiz. Then navigate to the page and search for ^^^ in the log console. was:When print.verbose=true, check for well-formed html in ftl templates to catch programming errors. > Well-formed html in ftl template > > > Key: OFBIZ-11996 > URL: https://issues.apache.org/jira/browse/OFBIZ-11996 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11996.patch > > > Check for well-formed html in ftl templates to catch programming errors. > To test, set print.verbose=true and start up ofbiz. > Then navigate to the page and search for ^^^ in the log console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11996) Well-formed html in ftl template
[ https://issues.apache.org/jira/browse/OFBIZ-11996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong updated OFBIZ-11996: --- Description: When print.verbose=true, check for well-formed html in ftl templates to catch programming errors. (was: Check for well-formed html in ftl templates to catch programming errors.) > Well-formed html in ftl template > > > Key: OFBIZ-11996 > URL: https://issues.apache.org/jira/browse/OFBIZ-11996 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11996.patch > > > When print.verbose=true, check for well-formed html in ftl templates to catch > programming errors. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11996) Well-formed html in ftl template
[ https://issues.apache.org/jira/browse/OFBIZ-11996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191031#comment-17191031 ] James Yong commented on OFBIZ-11996: Hi Jacques, Thanks for the review. Forgot to mention that the check is only done when print.verbose=true Regards, James > Well-formed html in ftl template > > > Key: OFBIZ-11996 > URL: https://issues.apache.org/jira/browse/OFBIZ-11996 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11996.patch > > > Check for well-formed html in ftl templates to catch programming errors. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11996) Well-formed html in ftl template
[ https://issues.apache.org/jira/browse/OFBIZ-11996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong updated OFBIZ-11996: --- Attachment: OFBIZ-11996.patch > Well-formed html in ftl template > > > Key: OFBIZ-11996 > URL: https://issues.apache.org/jira/browse/OFBIZ-11996 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11996.patch > > > Check for well-formed html in ftl templates to catch programming errors. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11996) Well-formed html in ftl template
James Yong created OFBIZ-11996: -- Summary: Well-formed html in ftl template Key: OFBIZ-11996 URL: https://issues.apache.org/jira/browse/OFBIZ-11996 Project: OFBiz Issue Type: Improvement Components: base Affects Versions: Upcoming Branch Reporter: James Yong Assignee: James Yong Fix For: Upcoming Branch Check for well-formed html in ftl templates to catch programming errors. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11686) multi-block attribute for html-template tag
[
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187800#comment-17187800
]
James Yong commented on OFBIZ-11686:
Hi Jacques,
Can check track-serverhit="false" for uri="getJs" at
plugins/ecommerce/webapp/ecommerce/WEB-INF/controller.xml?
{code:java}
{code}
Regards,
James
> multi-block attribute for html-template tag
> ---
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
> Issue Type: Improvement
> Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new widget tag that adds an external script after
> body tag.
> The external script will contain the rendered result of the specified
> template file location.
> e.g.
> {code:xml}
>
>
> {code}
>
> will render as:
> {code:xml}
>
> type="application/javascript"/>
>
> {code}
> This will allow inline script from a freemarker file, to be rendered as
> external script in html.
>
> Discussion was started at
> [https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]
>
> *15th May 2020*
> While extracting the scripts from html-template to script-template and
> testing the changes, I found the process to be cumbersome.
> So I made a change not to use script-template tag but add a multi-block
> attribute to html-template tag.
> When *multi-block=true*, inline scripts will be extracted automatically from
> script tag and converted to external script.
> So no need to manually extract script from the existing freemarker template.
> Coding for script-template tag is removed
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-11980) Allow logging to be disabled for getJs request
[ https://issues.apache.org/jira/browse/OFBIZ-11980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong closed OFBIZ-11980. -- Resolution: Fixed > Allow logging to be disabled for getJs request > -- > > Key: OFBIZ-11980 > URL: https://issues.apache.org/jira/browse/OFBIZ-11980 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11980.patch, OFBIZ-11980.patch, OFBIZ-11980.patch > > > Hide logs related to getJs request as it doesn't provide meaningful data. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11980) Allow logging to be disabled for getJs request
[ https://issues.apache.org/jira/browse/OFBIZ-11980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187182#comment-17187182 ] James Yong commented on OFBIZ-11980: Updated the patch so that any error log from getJs will not be hidden > Allow logging to be disabled for getJs request > -- > > Key: OFBIZ-11980 > URL: https://issues.apache.org/jira/browse/OFBIZ-11980 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11980.patch, OFBIZ-11980.patch, OFBIZ-11980.patch > > > Hide logs related to getJs request as it doesn't provide meaningful data. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11980) Allow logging to be disabled for getJs request
[ https://issues.apache.org/jira/browse/OFBIZ-11980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong updated OFBIZ-11980: --- Attachment: OFBIZ-11980.patch > Allow logging to be disabled for getJs request > -- > > Key: OFBIZ-11980 > URL: https://issues.apache.org/jira/browse/OFBIZ-11980 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11980.patch, OFBIZ-11980.patch, OFBIZ-11980.patch > > > Hide logs related to getJs request as it doesn't provide meaningful data. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11686) multi-block attribute for html-template tag
[
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186581#comment-17186581
]
James Yong commented on OFBIZ-11686:
Hi Jacques,
I didn't get any rollback error after removing the OFBIZ-11980 patch.
Still working on that patch.
Regards,
James
> multi-block attribute for html-template tag
> ---
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
> Issue Type: Improvement
> Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new widget tag that adds an external script after
> body tag.
> The external script will contain the rendered result of the specified
> template file location.
> e.g.
> {code:xml}
>
>
> {code}
>
> will render as:
> {code:xml}
>
> type="application/javascript"/>
>
> {code}
> This will allow inline script from a freemarker file, to be rendered as
> external script in html.
>
> Discussion was started at
> [https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]
>
> *15th May 2020*
> While extracting the scripts from html-template to script-template and
> testing the changes, I found the process to be cumbersome.
> So I made a change not to use script-template tag but add a multi-block
> attribute to html-template tag.
> When *multi-block=true*, inline scripts will be extracted automatically from
> script tag and converted to external script.
> So no need to manually extract script from the existing freemarker template.
> Coding for script-template tag is removed
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11686) multi-block attribute for html-template tag
[
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185111#comment-17185111
]
James Yong commented on OFBIZ-11686:
Hi Jacques,
I didn't encounter any rollback error.
Have you also updated the ofbiz-plugins code?
Regards,
James
> multi-block attribute for html-template tag
> ---
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
> Issue Type: Improvement
> Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new widget tag that adds an external script after
> body tag.
> The external script will contain the rendered result of the specified
> template file location.
> e.g.
> {code:xml}
>
>
> {code}
>
> will render as:
> {code:xml}
>
> type="application/javascript"/>
>
> {code}
> This will allow inline script from a freemarker file, to be rendered as
> external script in html.
>
> Discussion was started at
> [https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]
>
> *15th May 2020*
> While extracting the scripts from html-template to script-template and
> testing the changes, I found the process to be cumbersome.
> So I made a change not to use script-template tag but add a multi-block
> attribute to html-template tag.
> When *multi-block=true*, inline scripts will be extracted automatically from
> script tag and converted to external script.
> So no need to manually extract script from the existing freemarker template.
> Coding for script-template tag is removed
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11980) Allow logging to be disabled for getJs request
[ https://issues.apache.org/jira/browse/OFBIZ-11980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185109#comment-17185109 ] James Yong commented on OFBIZ-11980: The latest patch should fix the issue > Allow logging to be disabled for getJs request > -- > > Key: OFBIZ-11980 > URL: https://issues.apache.org/jira/browse/OFBIZ-11980 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11980.patch, OFBIZ-11980.patch > > > Hide logs related to getJs request as it doesn't provide meaningful data. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11980) Allow logging to be disabled for getJs request
[ https://issues.apache.org/jira/browse/OFBIZ-11980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185109#comment-17185109 ] James Yong edited comment on OFBIZ-11980 at 8/26/20, 11:16 AM: --- Added another patch which should fix the issue was (Author: jamesyong): The latest patch should fix the issue > Allow logging to be disabled for getJs request > -- > > Key: OFBIZ-11980 > URL: https://issues.apache.org/jira/browse/OFBIZ-11980 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11980.patch, OFBIZ-11980.patch > > > Hide logs related to getJs request as it doesn't provide meaningful data. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11980) Allow logging to be disabled for getJs request
[ https://issues.apache.org/jira/browse/OFBIZ-11980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong updated OFBIZ-11980: --- Attachment: OFBIZ-11980.patch > Allow logging to be disabled for getJs request > -- > > Key: OFBIZ-11980 > URL: https://issues.apache.org/jira/browse/OFBIZ-11980 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11980.patch, OFBIZ-11980.patch > > > Hide logs related to getJs request as it doesn't provide meaningful data. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11980) Allow logging to be disabled for getJs request
[ https://issues.apache.org/jira/browse/OFBIZ-11980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong updated OFBIZ-11980: --- Attachment: (was: OFBIZ-11980.patch) > Allow logging to be disabled for getJs request > -- > > Key: OFBIZ-11980 > URL: https://issues.apache.org/jira/browse/OFBIZ-11980 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11980.patch, OFBIZ-11980.patch > > > Hide logs related to getJs request as it doesn't provide meaningful data. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11980) Allow logging to be disabled for getJs request
[ https://issues.apache.org/jira/browse/OFBIZ-11980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184082#comment-17184082 ] James Yong commented on OFBIZ-11980: Hi Jacques, Ok, will find another time to check. Thanks, James > Allow logging to be disabled for getJs request > -- > > Key: OFBIZ-11980 > URL: https://issues.apache.org/jira/browse/OFBIZ-11980 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11980.patch, OFBIZ-11980.patch > > > Hide logs related to getJs request as it doesn't provide meaningful data. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11686) multi-block attribute for html-template tag
[
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184071#comment-17184071
]
James Yong commented on OFBIZ-11686:
Yes, some concurrency issue.
I will set track-serverhit="false" for getJs request, as not important to track
this request.
> multi-block attribute for html-template tag
> ---
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
> Issue Type: Improvement
> Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new widget tag that adds an external script after
> body tag.
> The external script will contain the rendered result of the specified
> template file location.
> e.g.
> {code:xml}
>
>
> {code}
>
> will render as:
> {code:xml}
>
> type="application/javascript"/>
>
> {code}
> This will allow inline script from a freemarker file, to be rendered as
> external script in html.
>
> Discussion was started at
> [https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]
>
> *15th May 2020*
> While extracting the scripts from html-template to script-template and
> testing the changes, I found the process to be cumbersome.
> So I made a change not to use script-template tag but add a multi-block
> attribute to html-template tag.
> When *multi-block=true*, inline scripts will be extracted automatically from
> script tag and converted to external script.
> So no need to manually extract script from the existing freemarker template.
> Coding for script-template tag is removed
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11686) multi-block attribute for html-template tag
[
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184003#comment-17184003
]
James Yong commented on OFBIZ-11686:
Hi Jacques,
No problem.
The last commit should fix the missing tree issue in ecommerce.
Regards,
James
> multi-block attribute for html-template tag
> ---
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
> Issue Type: Improvement
> Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new widget tag that adds an external script after
> body tag.
> The external script will contain the rendered result of the specified
> template file location.
> e.g.
> {code:xml}
>
>
> {code}
>
> will render as:
> {code:xml}
>
> type="application/javascript"/>
>
> {code}
> This will allow inline script from a freemarker file, to be rendered as
> external script in html.
>
> Discussion was started at
> [https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]
>
> *15th May 2020*
> While extracting the scripts from html-template to script-template and
> testing the changes, I found the process to be cumbersome.
> So I made a change not to use script-template tag but add a multi-block
> attribute to html-template tag.
> When *multi-block=true*, inline scripts will be extracted automatically from
> script tag and converted to external script.
> So no need to manually extract script from the existing freemarker template.
> Coding for script-template tag is removed
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11980) Allow logging to be disabled for getJs request
[ https://issues.apache.org/jira/browse/OFBIZ-11980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong updated OFBIZ-11980: --- Attachment: OFBIZ-11980.patch > Allow logging to be disabled for getJs request > -- > > Key: OFBIZ-11980 > URL: https://issues.apache.org/jira/browse/OFBIZ-11980 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11980.patch, OFBIZ-11980.patch > > > Hide logs related to getJs request as it doesn't provide meaningful data. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11686) multi-block attribute for html-template tag
[
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182878#comment-17182878
]
James Yong commented on OFBIZ-11686:
Hi Jacques,
The last commit should fixed it.
Thanks,
James
> multi-block attribute for html-template tag
> ---
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
> Issue Type: Improvement
> Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new widget tag that adds an external script after
> body tag.
> The external script will contain the rendered result of the specified
> template file location.
> e.g.
> {code:xml}
>
>
> {code}
>
> will render as:
> {code:xml}
>
> type="application/javascript"/>
>
> {code}
> This will allow inline script from a freemarker file, to be rendered as
> external script in html.
>
> Discussion was started at
> [https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]
>
> *15th May 2020*
> While extracting the scripts from html-template to script-template and
> testing the changes, I found the process to be cumbersome.
> So I made a change not to use script-template tag but add a multi-block
> attribute to html-template tag.
> When *multi-block=true*, inline scripts will be extracted automatically from
> script tag and converted to external script.
> So no need to manually extract script from the existing freemarker template.
> Coding for script-template tag is removed
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11980) Allow logging to be disabled for getJs request
[ https://issues.apache.org/jira/browse/OFBIZ-11980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong updated OFBIZ-11980: --- Attachment: OFBIZ-11980.patch > Allow logging to be disabled for getJs request > -- > > Key: OFBIZ-11980 > URL: https://issues.apache.org/jira/browse/OFBIZ-11980 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11980.patch > > > Hide logs related to getJs request as it doesn't provide meaningful data. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11686) multi-block attribute for html-template tag
[
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182661#comment-17182661
]
James Yong commented on OFBIZ-11686:
Created OFBIZ-11980 to hide getJs logs
> multi-block attribute for html-template tag
> ---
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
> Issue Type: Improvement
> Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new widget tag that adds an external script after
> body tag.
> The external script will contain the rendered result of the specified
> template file location.
> e.g.
> {code:xml}
>
>
> {code}
>
> will render as:
> {code:xml}
>
> type="application/javascript"/>
>
> {code}
> This will allow inline script from a freemarker file, to be rendered as
> external script in html.
>
> Discussion was started at
> [https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]
>
> *15th May 2020*
> While extracting the scripts from html-template to script-template and
> testing the changes, I found the process to be cumbersome.
> So I made a change not to use script-template tag but add a multi-block
> attribute to html-template tag.
> When *multi-block=true*, inline scripts will be extracted automatically from
> script tag and converted to external script.
> So no need to manually extract script from the existing freemarker template.
> Coding for script-template tag is removed
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11980) Allow logging to be disabled for getJs request
[ https://issues.apache.org/jira/browse/OFBIZ-11980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182660#comment-17182660 ] James Yong commented on OFBIZ-11980: Example of getJs request logs ||Time||Thread||Class||Level||Message|| |2020-08-23 19:18:04,800|jsse-nio-8443-exec-6|ControlServlet|T|[[[example::getJs (Domain:https://localhost)] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]| |2020-08-23 19:18:04,802|jsse-nio-8443-exec-6|RequestHandler|I|[RequestHandler.doRequest]: Response is a chained request. Hidden sessionId by default.| |2020-08-23 19:18:04,803|jsse-nio-8443-exec-6|RequestHandler|I|[RequestHandler]: Chain in place: requestUri=js overrideViewUri=null Hidden sessionId by default.| |2020-08-23 19:18:04,804|jsse-nio-8443-exec-6|RequestHandler|I|Ran Event [java:org.apache.ofbiz.common.CommonEvents#jsResponseFromRequest|#jsResponseFromRequest] from [request], result is [success]| |2020-08-23 19:18:04,806|jsse-nio-8443-exec-6|ServerHitBin|I|Visit delegatorName=default, ServerHitBin delegatorName=default| |2020-08-23 19:18:04,809|jsse-nio-8443-exec-6|ControlServlet|T|[[[example::getJs (Domain:https://localhost)] Request Done- total:0.009,since last([example::getJs (...):0.009]]| > Allow logging to be disabled for getJs request > -- > > Key: OFBIZ-11980 > URL: https://issues.apache.org/jira/browse/OFBIZ-11980 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > > Hide logs related to getJs request as it doesn't provide meaningful data. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11980) Allow logging to be disabled for getJs request
James Yong created OFBIZ-11980: -- Summary: Allow logging to be disabled for getJs request Key: OFBIZ-11980 URL: https://issues.apache.org/jira/browse/OFBIZ-11980 Project: OFBiz Issue Type: Improvement Components: base Affects Versions: Upcoming Branch Reporter: James Yong Assignee: James Yong Fix For: Upcoming Branch Hide logs related to getJs request as it doesn't provide meaningful data. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11686) multi-block attribute for html-template tag
[
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182637#comment-17182637
]
James Yong commented on OFBIZ-11686:
Hi Jacques,
Thanks for the clarification.
I checked those log statements relating to getJs request aren't useful.
Will create a JIRA issue for it
Regards,
James
> multi-block attribute for html-template tag
> ---
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
> Issue Type: Improvement
> Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new widget tag that adds an external script after
> body tag.
> The external script will contain the rendered result of the specified
> template file location.
> e.g.
> {code:xml}
>
>
> {code}
>
> will render as:
> {code:xml}
>
> type="application/javascript"/>
>
> {code}
> This will allow inline script from a freemarker file, to be rendered as
> external script in html.
>
> Discussion was started at
> [https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]
>
> *15th May 2020*
> While extracting the scripts from html-template to script-template and
> testing the changes, I found the process to be cumbersome.
> So I made a change not to use script-template tag but add a multi-block
> attribute to html-template tag.
> When *multi-block=true*, inline scripts will be extracted automatically from
> script tag and converted to external script.
> So no need to manually extract script from the existing freemarker template.
> Coding for script-template tag is removed
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11686) multi-block attribute for html-template tag
[
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182367#comment-17182367
]
James Yong commented on OFBIZ-11686:
Hi Jacques,
Sorry I don't understand your point.
Regards,
James
> multi-block attribute for html-template tag
> ---
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
> Issue Type: Improvement
> Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new widget tag that adds an external script after
> body tag.
> The external script will contain the rendered result of the specified
> template file location.
> e.g.
> {code:xml}
>
>
> {code}
>
> will render as:
> {code:xml}
>
> type="application/javascript"/>
>
> {code}
> This will allow inline script from a freemarker file, to be rendered as
> external script in html.
>
> Discussion was started at
> [https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]
>
> *15th May 2020*
> While extracting the scripts from html-template to script-template and
> testing the changes, I found the process to be cumbersome.
> So I made a change not to use script-template tag but add a multi-block
> attribute to html-template tag.
> When *multi-block=true*, inline scripts will be extracted automatically from
> script tag and converted to external script.
> So no need to manually extract script from the existing freemarker template.
> Coding for script-template tag is removed
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Reopened] (OFBIZ-11968) Error when rendering renderSubmitField macro
[
https://issues.apache.org/jira/browse/OFBIZ-11968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Yong reopened OFBIZ-11968:
> Error when rendering renderSubmitField macro
>
>
> Key: OFBIZ-11968
> URL: https://issues.apache.org/jira/browse/OFBIZ-11968
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: FindSkillsPageError.png, Image 001.png
>
>
> Error shown on page when accessing /humanres/control/FindPartySkills page
> {code:java}
> When calling macro "renderSubmitField", required parameter "id" (parameter
> #8) was not specified{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-11968) Error when rendering renderSubmitField macro
[
https://issues.apache.org/jira/browse/OFBIZ-11968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Yong closed OFBIZ-11968.
--
Resolution: Cannot Reproduce
> Error when rendering renderSubmitField macro
>
>
> Key: OFBIZ-11968
> URL: https://issues.apache.org/jira/browse/OFBIZ-11968
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: FindSkillsPageError.png, Image 001.png
>
>
> Error shown on page when accessing /humanres/control/FindPartySkills page
> {code:java}
> When calling macro "renderSubmitField", required parameter "id" (parameter
> #8) was not specified{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11968) Error when rendering renderSubmitField macro
[
https://issues.apache.org/jira/browse/OFBIZ-11968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Yong updated OFBIZ-11968:
---
Sprint: (was: OFBiz Community Day (Aug 2020))
> Error when rendering renderSubmitField macro
>
>
> Key: OFBIZ-11968
> URL: https://issues.apache.org/jira/browse/OFBIZ-11968
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: FindSkillsPageError.png, Image 001.png
>
>
> Error shown on page when accessing /humanres/control/FindPartySkills page
> {code:java}
> When calling macro "renderSubmitField", required parameter "id" (parameter
> #8) was not specified{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11968) Error when rendering renderSubmitField macro
[
https://issues.apache.org/jira/browse/OFBIZ-11968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181728#comment-17181728
]
James Yong commented on OFBIZ-11968:
Yes, I m using trunk HEAD to test and commit the change.
> Error when rendering renderSubmitField macro
>
>
> Key: OFBIZ-11968
> URL: https://issues.apache.org/jira/browse/OFBIZ-11968
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: FindSkillsPageError.png
>
>
> Error shown on page when accessing /humanres/control/FindPartySkills page
> {code:java}
> When calling macro "renderSubmitField", required parameter "id" (parameter
> #8) was not specified{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11968) Error when rendering renderSubmitField macro
[
https://issues.apache.org/jira/browse/OFBIZ-11968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181715#comment-17181715
]
James Yong commented on OFBIZ-11968:
Hi Jacques,
I uploaded a screenshot of the error.
Regards,
James
> Error when rendering renderSubmitField macro
>
>
> Key: OFBIZ-11968
> URL: https://issues.apache.org/jira/browse/OFBIZ-11968
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: FindSkillsPageError.png
>
>
> Error shown on page when accessing /humanres/control/FindPartySkills page
> {code:java}
> When calling macro "renderSubmitField", required parameter "id" (parameter
> #8) was not specified{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11968) Error when rendering renderSubmitField macro
[
https://issues.apache.org/jira/browse/OFBIZ-11968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Yong updated OFBIZ-11968:
---
Attachment: FindSkillsPageError.png
> Error when rendering renderSubmitField macro
>
>
> Key: OFBIZ-11968
> URL: https://issues.apache.org/jira/browse/OFBIZ-11968
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: FindSkillsPageError.png
>
>
> Error shown on page when accessing /humanres/control/FindPartySkills page
> {code:java}
> When calling macro "renderSubmitField", required parameter "id" (parameter
> #8) was not specified{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-11968) Error when rendering renderSubmitField macro
[
https://issues.apache.org/jira/browse/OFBIZ-11968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Yong closed OFBIZ-11968.
--
Resolution: Fixed
> Error when rendering renderSubmitField macro
>
>
> Key: OFBIZ-11968
> URL: https://issues.apache.org/jira/browse/OFBIZ-11968
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Error shown on page when accessing /humanres/control/FindPartySkills page
> {code:java}
> When calling macro "renderSubmitField", required parameter "id" (parameter
> #8) was not specified{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (OFBIZ-11968) Error when rendering renderSubmitField macro
James Yong created OFBIZ-11968:
--
Summary: Error when rendering renderSubmitField macro
Key: OFBIZ-11968
URL: https://issues.apache.org/jira/browse/OFBIZ-11968
Project: OFBiz
Issue Type: Bug
Components: framework/widget
Affects Versions: Upcoming Branch
Reporter: James Yong
Assignee: James Yong
Fix For: Upcoming Branch
Error shown on page when accessing /humanres/control/FindPartySkills page
{code:java}
When calling macro "renderSubmitField", required parameter "id" (parameter #8)
was not specified{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11964) Replace Mask Js
[ https://issues.apache.org/jira/browse/OFBIZ-11964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong updated OFBIZ-11964: --- Sprint: (was: OFBiz Community Day (Aug 2020)) > Replace Mask Js > --- > > Key: OFBIZ-11964 > URL: https://issues.apache.org/jira/browse/OFBIZ-11964 > Project: OFBiz > Issue Type: Improvement > Components: framework/widget >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > > To allow using the importLibrary function in ofbizUtil.js. > Replace library from > [https://github.com/igorescobar/jQuery-Mask-Plugin] > to > [https://github.com/RobinHerbots/Inputmask] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11964) Replace Mask Js
[ https://issues.apache.org/jira/browse/OFBIZ-11964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong updated OFBIZ-11964: --- Sprint: OFBiz Community Day (Aug 2020) > Replace Mask Js > --- > > Key: OFBIZ-11964 > URL: https://issues.apache.org/jira/browse/OFBIZ-11964 > Project: OFBiz > Issue Type: Improvement > Components: framework/widget >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > > To allow using the importLibrary function in ofbizUtil.js. > Replace library from > [https://github.com/igorescobar/jQuery-Mask-Plugin] > to > [https://github.com/RobinHerbots/Inputmask] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11964) Replace Mask Js
[ https://issues.apache.org/jira/browse/OFBIZ-11964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong closed OFBIZ-11964. -- Resolution: Implemented > Replace Mask Js > --- > > Key: OFBIZ-11964 > URL: https://issues.apache.org/jira/browse/OFBIZ-11964 > Project: OFBiz > Issue Type: Improvement > Components: framework/widget >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > > To allow using the importLibrary function in ofbizUtil.js. > Replace library from > [https://github.com/igorescobar/jQuery-Mask-Plugin] > to > [https://github.com/RobinHerbots/Inputmask] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11964) Replace Mask Js
[ https://issues.apache.org/jira/browse/OFBIZ-11964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180171#comment-17180171 ] James Yong commented on OFBIZ-11964: Discussion at [https://lists.apache.org/thread.html/rb1909e26a5f54347791b658512e069d33daadbde65dfed44f979aece%40%3Cdev.ofbiz.apache.org%3E] > Replace Mask Js > --- > > Key: OFBIZ-11964 > URL: https://issues.apache.org/jira/browse/OFBIZ-11964 > Project: OFBiz > Issue Type: Improvement > Components: framework/widget >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > > To allow using the importLibrary function in ofbizUtil.js. > Replace library from > [https://github.com/igorescobar/jQuery-Mask-Plugin] > to > [https://github.com/RobinHerbots/Inputmask] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11964) Replace Mask Js
James Yong created OFBIZ-11964: -- Summary: Replace Mask Js Key: OFBIZ-11964 URL: https://issues.apache.org/jira/browse/OFBIZ-11964 Project: OFBiz Issue Type: Improvement Components: framework/widget Affects Versions: Upcoming Branch Reporter: James Yong Assignee: James Yong Fix For: Upcoming Branch To allow using the importLibrary function in ofbizUtil.js. Replace library from [https://github.com/igorescobar/jQuery-Mask-Plugin] to [https://github.com/RobinHerbots/Inputmask] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11958) Freemarker macro for JsLanguageFilesMapping
[ https://issues.apache.org/jira/browse/OFBIZ-11958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong closed OFBIZ-11958. -- Resolution: Implemented > Freemarker macro for JsLanguageFilesMapping > --- > > Key: OFBIZ-11958 > URL: https://issues.apache.org/jira/browse/OFBIZ-11958 > Project: OFBiz > Issue Type: New Feature > Components: ALL APPLICATIONS, ALL PLUGINS >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11958.patch > > > Need to get the js library language filepath in ftl via > JsLanguageFilesMapping class. > But not able to access the static classes in JsLanguageFilesMapping. > Moreover the output contains / which is automatically encoded when rendered. > So a macro is needed to get info from JsLanguageFilesMapping class . > Proposing something like > <@jsLangFilesMap>select2 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11686) multi-block attribute for html-template tag
[
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17179300#comment-17179300
]
James Yong commented on OFBIZ-11686:
Hi Jacques,
Looks normal. I can put the external script tag within body tag if you prefer.
From
[https://www.digitalocean.com/community/tutorials/how-to-add-javascript-to-html]:
{code}
The tag can be placed in the section of your HTML, in the
section, or after the close tag, depending on when you want the
JavaScript to load.
{code}
Regards,
James
> multi-block attribute for html-template tag
> ---
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
> Issue Type: Improvement
> Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new widget tag that adds an external script after
> body tag.
> The external script will contain the rendered result of the specified
> template file location.
> e.g.
> {code:xml}
>
>
> will render as:
> {code:xml}
>
>