[jira] [Closed] (OFBIZ-12210) orderStatus.changeReason not set when orderItem is cancelled
[ https://issues.apache.org/jira/browse/OFBIZ-12210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-12210. - Fix Version/s: 17.12.06 18.12.01 Resolution: Fixed Thanks: [~lalit.dashora] > orderStatus.changeReason not set when orderItem is cancelled > > > Key: OFBIZ-12210 > URL: https://issues.apache.org/jira/browse/OFBIZ-12210 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Lalit Dashora >Assignee: Suraj Khurana >Priority: Major > Fix For: 18.12.01, 17.12.06 > > Attachments: 17-12.patch, 18-12.patch, TRUNK.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-12210) orderStatus.changeReason not set when orderItem is cancelled
[ https://issues.apache.org/jira/browse/OFBIZ-12210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana reassigned OFBIZ-12210: - Assignee: Suraj Khurana > orderStatus.changeReason not set when orderItem is cancelled > > > Key: OFBIZ-12210 > URL: https://issues.apache.org/jira/browse/OFBIZ-12210 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Lalit Dashora >Assignee: Suraj Khurana >Priority: Major > Attachments: 17-12.patch, 18-12.patch, TRUNK.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12210) orderStatus.changeReason not set when orderItem is cancelled
[ https://issues.apache.org/jira/browse/OFBIZ-12210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-12210: -- Component/s: order > orderStatus.changeReason not set when orderItem is cancelled > > > Key: OFBIZ-12210 > URL: https://issues.apache.org/jira/browse/OFBIZ-12210 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Lalit Dashora >Assignee: Lalit Dashora >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12210) orderStatus.changeReason not set when orderItem is cancelled
[ https://issues.apache.org/jira/browse/OFBIZ-12210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-12210: -- Affects Version/s: Release Branch 17.12 Release Branch 18.12 > orderStatus.changeReason not set when orderItem is cancelled > > > Key: OFBIZ-12210 > URL: https://issues.apache.org/jira/browse/OFBIZ-12210 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Lalit Dashora >Assignee: Lalit Dashora >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12210) orderStatus.changeReason not set when orderItem is cancelled
[ https://issues.apache.org/jira/browse/OFBIZ-12210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309894#comment-17309894 ] Suraj Khurana commented on OFBIZ-12210: --- I checked on demo-trunk order, by canceling and item after EditItem and selecting change reason. It doesn't saved to OrderStatus.changeReason. [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=Demo1002] I think this is a Bug rather than an improvement, changing type. > orderStatus.changeReason not set when orderItem is cancelled > > > Key: OFBIZ-12210 > URL: https://issues.apache.org/jira/browse/OFBIZ-12210 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Lalit Dashora >Assignee: Lalit Dashora >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12210) orderStatus.changeReason not set when orderItem is cancelled
[ https://issues.apache.org/jira/browse/OFBIZ-12210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-12210: -- Issue Type: Bug (was: Improvement) > orderStatus.changeReason not set when orderItem is cancelled > > > Key: OFBIZ-12210 > URL: https://issues.apache.org/jira/browse/OFBIZ-12210 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Lalit Dashora >Assignee: Lalit Dashora >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12204) WebPos: Impossible to checkout when product is paid in multiple cash amounts
[ https://issues.apache.org/jira/browse/OFBIZ-12204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17309876#comment-17309876 ] Suraj Khurana commented on OFBIZ-12204: --- HI [~sa_james], Current behaviour is like if $50 is pending and you paid $15 first by cash and tried to add $20 more using cash, system overrides the $15 and make it $20 instead. It is intentionally done currently. // clear cash payments first; so there is only one org/apache/ofbiz/webpos/transaction/WebPosTransaction.java:370 HTH > WebPos: Impossible to checkout when product is paid in multiple cash amounts > > > Key: OFBIZ-12204 > URL: https://issues.apache.org/jira/browse/OFBIZ-12204 > Project: OFBiz > Issue Type: Bug > Components: webpos >Affects Versions: Trunk >Reporter: Woyce Batkins >Priority: Major > > * Go to the WebPos > * Search for a product > * Select "Pay Cash" in Keyboard shortcut > * Enter less than the total amount due > * confirm > * Select "Pay Cash" again > * Enter the "Total Due" > * Confirm > * There is no way to checkout -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-8717) Improve all the service level error messages for missing required field for webtools component
[ https://issues.apache.org/jira/browse/OFBIZ-8717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-8717. Fix Version/s: Upcoming Branch Resolution: Fixed This has been pushed to latest trunk. Thanks Ritesh Kumar for providing the patch. > Improve all the service level error messages for missing required field for > webtools component > -- > > Key: OFBIZ-8717 > URL: https://issues.apache.org/jira/browse/OFBIZ-8717 > Project: OFBiz > Issue Type: Sub-task > Components: framework/webtools >Affects Versions: 16.11.01, Trunk >Reporter: Jagpreet Kaur >Assignee: Suraj Khurana >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8717.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-8717) Improve all the service level error messages for missing required field for webtools component
[ https://issues.apache.org/jira/browse/OFBIZ-8717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-8717: - Affects Version/s: Trunk > Improve all the service level error messages for missing required field for > webtools component > -- > > Key: OFBIZ-8717 > URL: https://issues.apache.org/jira/browse/OFBIZ-8717 > Project: OFBiz > Issue Type: Sub-task > Components: framework/webtools >Affects Versions: 16.11.01, Trunk >Reporter: Jagpreet Kaur >Assignee: Suraj Khurana >Priority: Minor > Attachments: OFBIZ-8717.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12177) Possibly currency display bug in "Find Invoices"
[ https://issues.apache.org/jira/browse/OFBIZ-12177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17293634#comment-17293634 ] Suraj Khurana commented on OFBIZ-12177: --- +1, patch looks good to me. > Possibly currency display bug in "Find Invoices" > > > Key: OFBIZ-12177 > URL: https://issues.apache.org/jira/browse/OFBIZ-12177 > Project: OFBiz > Issue Type: Bug >Reporter: Andrei Stan >Assignee: Priya Sharma >Priority: Minor > Attachments: Captură de ecran de la 2021-02-15 17-31-06.png, Captură > de ecran de la 2021-02-15 17-33-34.png, OFBIZ-12177.patch > > > h4. - in the page with the "Invoices List", the numbers are wrong for "Total: > EUR 820.2773" of "demo11001". > h4. Steps to generate: > Open https://demo-trunk.ofbiz.apache.org/accounting/control/findInvoices > - see that invoice "demo11001" has the Total of *EUR* 820.2773. > - click on the Invoice id "demo11001" > - if you look at payments, we can see that a payment of *EUR* 543.23 was made > and applied. > * in the invoice Overview we can see the correct currency $ is with the > amount of 820.2773 -> > https://demo-trunk.ofbiz.apache.org/accounting/control/paymentOverview?paymentId=demo10001 > I think the bug is this: > * it should display USD 820.2773 or *EUR* 543.23 in the "Invoices List (find > invoieces)" page ?!? > * in the project file > "../applications/datamodel/data/demo/AccountingDemoData.xml" you > * can see the converting factor: > ** > > 00:00:00.0"conversionFactor="1.5"/> => *EUR 543.23 = $ 820.2773* > > * as an enhancement for the payments in other currencies i think it would be > usefull to display the Total amount of the invoice with it's currency > alogside the amount of total payments in other currency, applied. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11680) ViewQuoteProfit shows fields in wrong order
[ https://issues.apache.org/jira/browse/OFBIZ-11680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-11680. - Fix Version/s: 17.12.05 18.12.01 Resolution: Fixed Thanks [~mbrohl] for reminder. Done from my side. > ViewQuoteProfit shows fields in wrong order > --- > > Key: OFBIZ-11680 > URL: https://issues.apache.org/jira/browse/OFBIZ-11680 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Pierre Smits >Assignee: Suraj Khurana >Priority: Major > Labels: quote > Fix For: 18.12.01, 17.12.05 > > Attachments: OFBIZ-11680.patch, Screen Shot 2020-05-09 at 10.40.39.png > > > See attached image. > Total amount (of the quote) should be before total cost. > On line items, the quoteUnitPrice should be before averageCost -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11901) Provide OOTB support to calculate distance between two geo points
[ https://issues.apache.org/jira/browse/OFBIZ-11901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-11901. - Fix Version/s: Upcoming Branch Resolution: Implemented This has been pushed to trunk. > Provide OOTB support to calculate distance between two geo points > - > > Key: OFBIZ-11901 > URL: https://issues.apache.org/jira/browse/OFBIZ-11901 > Project: OFBiz > Issue Type: New Feature >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-11901.patch > > > Though there are many third party capabilities available in the form of > API's, this can easily be calculated within OFBiz as well. > This method will be providing direct spatial distance between two geo points. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11728) Create new component, data configuration and connection request
[ https://issues.apache.org/jira/browse/OFBIZ-11728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17261796#comment-17261796 ] Suraj Khurana commented on OFBIZ-11728: --- The first initial PR seems ready to merge, I will proceed soon. > Create new component, data configuration and connection request > --- > > Key: OFBIZ-11728 > URL: https://issues.apache.org/jira/browse/OFBIZ-11728 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Shikha Jaiswal >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11728.patch > > > We will be doing following tasks in this ticket: > # Create a new component named *shopify* > # Basic configuration data setup > # Implement a method for HTTP connection request with Shopify > To store configuration details we will create entity *ShopifyConfig* -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12078) Remove hardcoded product cateogy on CategoryWorker.getCatalogTopCategory
[ https://issues.apache.org/jira/browse/OFBIZ-12078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17243734#comment-17243734 ] Suraj Khurana commented on OFBIZ-12078: --- +1, LGTM > Remove hardcoded product cateogy on CategoryWorker.getCatalogTopCategory > > > Key: OFBIZ-12078 > URL: https://issues.apache.org/jira/browse/OFBIZ-12078 > Project: OFBiz > Issue Type: Improvement > Components: product/catalog >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Attachments: OFBIZ-12078.patch > > > When you call the java function > _org.apache.ofbiz.product.category.CategoryWorker.getCatalogTopCategory()_ > the catalog returned if the system failed found it is hardcoded and don't use > an existing property : _catalog->top.category.default_ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12053) Promising against Future Supply of Inventory
[ https://issues.apache.org/jira/browse/OFBIZ-12053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17230025#comment-17230025 ] Suraj Khurana commented on OFBIZ-12053: --- This is a good idea, this will a shinning new feather in the cap. Thanks [~swash78] for adding all the requirements. > Promising against Future Supply of Inventory > > > Key: OFBIZ-12053 > URL: https://issues.apache.org/jira/browse/OFBIZ-12053 > Project: OFBiz > Issue Type: New Feature > Components: order >Reporter: Swapnil Shah >Priority: Major > Fix For: Upcoming Branch > > > *Requirement Elicitation:* > Promising delivery of any product or SKU to a customer out of On Hand > inventory against any firm or forecasted demand arising in the form of Sales > Order in the system has been now been a established practice and well > supported to a great extent within Ofbiz. > However, there is a strong need felt to have a solution that can address the > problem in making promises to customer for any product or SKU out of any > future or expected supply of inventory through inbound shipments from vendors > or suppliers. There may be different natures of demand for which such kind of > solution capability can serve well like: > * Demand from orders which couldn't get any commitment out of on hand > inventory and thus are often termed as Backordered (BO) > * Demand from Advanced or Pre-booked orders while launching new product line > as inventory is yet to arrive at fulfilment locations > * Demand from booked orders against limited edition version of existing > product line as inventory is yet to arrive at fulfilment locations > * Demand from sample lines booked during pre-launch event > * and so on... > While attempting to promise customer from future supply for a product/SKU > then from solutioning stand point, anything that can try to address the > following questions should be a good start to begin with: > * How to promise (i.e., what should be the rules or constraints or basis for > promising order) > * How much to promise (i.e. how many units out of ordered units need to be > promised for any given order) > * How much is Available to Promise (i.e. how many promisable units available > from different sources or inbound shipments for a given product/SKU) > * Where to Promise from (i.e. from which source or inbound shipment the > order can be promised) > * When to promise (i.e. on what date a given order can be promised) > Let's use this space to add on to it with more such real time use scenarios > or questions that needs the right answer. > We could try writing the design to solve for it in a separate linked ticket > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11971) Incorrect data for InvoiceItemTypeMap and ReturnItemTypeMap
[ https://issues.apache.org/jira/browse/OFBIZ-11971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-11971. - Fix Version/s: (was: Trunk) 17.12.05 18.12.01 Resolution: Fixed Thanks Amit Gadaley for your contribution. > Incorrect data for InvoiceItemTypeMap and ReturnItemTypeMap > --- > > Key: OFBIZ-11971 > URL: https://issues.apache.org/jira/browse/OFBIZ-11971 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Amit Gadaley >Assignee: Suraj Khurana >Priority: Major > Fix For: 18.12.01, 17.12.05 > > Attachments: OFBIZ-11971.patch > > > 'RET_MISC_CHARGE_ADJ' is used as returnItemTypeId in ReturnItemTypeMap data > and it also used as invoiceItemMapKey in InvoiceItemTypeMap data but its type > data does not exists. > The following data exist for miscellaneous charges in data files: > returnAdjustmentTypeId="RET_MISC_ADJ"/> -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11965) Improve service name as per best practices
[ https://issues.apache.org/jira/browse/OFBIZ-11965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202610#comment-17202610 ] Suraj Khurana commented on OFBIZ-11965: --- Hello Vaibhav, Thanks for providing the patch. We are using deprecated tags currently for older services and they will be removed in next release. Please explore deprecated tag used in service definition and do the required changes in the patch. Also, please move tickets to Patch Provided status once you have uploaded the complete patch, so that more reviewers can review and committers can approach it. Let me know in case some more info required from my side. TIA. > Improve service name as per best practices > -- > > Key: OFBIZ-11965 > URL: https://issues.apache.org/jira/browse/OFBIZ-11965 > Project: OFBiz > Issue Type: Improvement > Components: ALL PLUGINS >Affects Versions: Trunk >Reporter: Suraj Khurana >Priority: Minor > Attachments: OFBIZ-11965-NamingConventionFix.patch > > > Following service names should be corrected as per naming convention best > practices: > * SagePayPaymentAuthorisation > * SagePayPaymentRefund > * SagePayPaymentRelease > * SagePayPaymentVoid > * SetTimeZoneFromBrowser > * SagePayPaymentAuthentication -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11680) ViewQuoteProfit shows fields in wrong order
[ https://issues.apache.org/jira/browse/OFBIZ-11680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana reassigned OFBIZ-11680: - Assignee: Suraj Khurana > ViewQuoteProfit shows fields in wrong order > --- > > Key: OFBIZ-11680 > URL: https://issues.apache.org/jira/browse/OFBIZ-11680 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Pierre Smits >Assignee: Suraj Khurana >Priority: Major > Labels: quote > Attachments: OFBIZ-11680.patch, Screen Shot 2020-05-09 at 10.40.39.png > > > See attached image. > Total amount (of the quote) should be before total cost. > On line items, the quoteUnitPrice should be before averageCost -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11971) Incorrect data for InvoiceItemTypeMap and ReturnItemTypeMap
[ https://issues.apache.org/jira/browse/OFBIZ-11971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11971: -- Affects Version/s: Release Branch 17.12 Release Branch 18.12 > Incorrect data for InvoiceItemTypeMap and ReturnItemTypeMap > --- > > Key: OFBIZ-11971 > URL: https://issues.apache.org/jira/browse/OFBIZ-11971 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Amit Gadaley >Assignee: Suraj Khurana >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-11971.patch > > > 'RET_MISC_CHARGE_ADJ' is used as returnItemTypeId in ReturnItemTypeMap data > and it also used as invoiceItemMapKey in InvoiceItemTypeMap data but its type > data does not exists. > The following data exist for miscellaneous charges in data files: > returnAdjustmentTypeId="RET_MISC_ADJ"/> -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11185) OrderReadHelper.getAvailableOrderHeaderAdjustments improvements
[ https://issues.apache.org/jira/browse/OFBIZ-11185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-11185. - Fix Version/s: Upcoming Branch Resolution: Implemented Thanks Amit Gadaley for providing the patch. > OrderReadHelper.getAvailableOrderHeaderAdjustments improvements > --- > > Key: OFBIZ-11185 > URL: https://issues.apache.org/jira/browse/OFBIZ-11185 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-11185.patch > > > We have a helper method in OrderReadHelper named as > getAvailableOrderHeaderAdjustments which is used to fetch order header > adjustments available for return. > It should also check for amount, it might possible, orderHeader adjustment > was of $100 and once a return is created for $20, then available $80 would > not render while creating second return for the same order. > So instead of checking only for orderAdjustmentId in ReturnAdjustment, it > should also check for adjustment amount. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11728) Create new component, data configuration and connection request
[ https://issues.apache.org/jira/browse/OFBIZ-11728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana reassigned OFBIZ-11728: - Assignee: Suraj Khurana (was: Shikha Jaiswal) > Create new component, data configuration and connection request > --- > > Key: OFBIZ-11728 > URL: https://issues.apache.org/jira/browse/OFBIZ-11728 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Shikha Jaiswal >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11728.patch > > > We will be doing following tasks in this ticket: > # Create a new component named *shopify* > # Basic configuration data setup > # Implement a method for HTTP connection request with Shopify > To store configuration details we will create entity *ShopifyConfig* -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11901) Provide OOTB support to calculate distance between two geo points
[ https://issues.apache.org/jira/browse/OFBIZ-11901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202558#comment-17202558 ] Suraj Khurana commented on OFBIZ-11901: --- Hello [~lodhiravi], I have attached a patch, could you please review it. TIA. > Provide OOTB support to calculate distance between two geo points > - > > Key: OFBIZ-11901 > URL: https://issues.apache.org/jira/browse/OFBIZ-11901 > Project: OFBiz > Issue Type: New Feature >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11901.patch > > > Though there are many third party capabilities available in the form of > API's, this can easily be calculated within OFBiz as well. > This method will be providing direct spatial distance between two geo points. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11901) Provide OOTB support to calculate distance between two geo points
[ https://issues.apache.org/jira/browse/OFBIZ-11901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11901: -- Attachment: OFBIZ-11901.patch > Provide OOTB support to calculate distance between two geo points > - > > Key: OFBIZ-11901 > URL: https://issues.apache.org/jira/browse/OFBIZ-11901 > Project: OFBiz > Issue Type: New Feature >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11901.patch > > > Though there are many third party capabilities available in the form of > API's, this can easily be calculated within OFBiz as well. > This method will be providing direct spatial distance between two geo points. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-12022) Extra whitespace in code
[ https://issues.apache.org/jira/browse/OFBIZ-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-12022. - Fix Version/s: Upcoming Branch Resolution: Implemented This fixed around *42* checkstyle issues. > Extra whitespace in code > > > Key: OFBIZ-12022 > URL: https://issues.apache.org/jira/browse/OFBIZ-12022 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Trivial > Fix For: Upcoming Branch > > Attachments: OFBIZ-12022.patch > > > Found some code occurences where there are some extra spaces, need to correct > them for checkstyle -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12022) Extra whitespace in code
[ https://issues.apache.org/jira/browse/OFBIZ-12022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-12022: -- Attachment: OFBIZ-12022.patch > Extra whitespace in code > > > Key: OFBIZ-12022 > URL: https://issues.apache.org/jira/browse/OFBIZ-12022 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Trivial > Attachments: OFBIZ-12022.patch > > > Found some code occurences where there are some extra spaces, need to correct > them for checkstyle -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12022) Extra whitespace in code
Suraj Khurana created OFBIZ-12022: - Summary: Extra whitespace in code Key: OFBIZ-12022 URL: https://issues.apache.org/jira/browse/OFBIZ-12022 Project: OFBiz Issue Type: Sub-task Components: ALL COMPONENTS Reporter: Suraj Khurana Assignee: Suraj Khurana Found some code occurences where there are some extra spaces, need to correct them for checkstyle -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11926) Checkstyle: Variable name must match pattern
[ https://issues.apache.org/jira/browse/OFBIZ-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202526#comment-17202526 ] Suraj Khurana commented on OFBIZ-11926: --- Hi Jacques, I think we can close this one. > Checkstyle: Variable name must match pattern > > > Key: OFBIZ-11926 > URL: https://issues.apache.org/jira/browse/OFBIZ-11926 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: JsLanguageFilesMapping.patch, OFBIZ-11926-plugins.patch, > OFBIZ-11926.patch > > > All final data members of the class must match this naming pattern > '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$' -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11926) Checkstyle: Variable name must match pattern
[ https://issues.apache.org/jira/browse/OFBIZ-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195909#comment-17195909 ] Suraj Khurana commented on OFBIZ-11926: --- Yes, +1 to have this for all "do nothing" kind of code occurences. It should be atleast logged properly. > Checkstyle: Variable name must match pattern > > > Key: OFBIZ-11926 > URL: https://issues.apache.org/jira/browse/OFBIZ-11926 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: JsLanguageFilesMapping.patch, OFBIZ-11926-plugins.patch, > OFBIZ-11926.patch > > > All final data members of the class must match this naming pattern > '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$' -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11926) Checkstyle: Variable name must match pattern
[ https://issues.apache.org/jira/browse/OFBIZ-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195444#comment-17195444 ] Suraj Khurana commented on OFBIZ-11926: --- Hi Jacques, Please check build/reports/checkstyle/main.html, and search for 'Must have at least one'. Some of them can be staright forward to handle, some others needs a defined pattern. HTH. > Checkstyle: Variable name must match pattern > > > Key: OFBIZ-11926 > URL: https://issues.apache.org/jira/browse/OFBIZ-11926 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: JsLanguageFilesMapping.patch, OFBIZ-11926-plugins.patch, > OFBIZ-11926.patch > > > All final data members of the class must match this naming pattern > '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$' -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12014) Error while decoding url parameters with percent character
[ https://issues.apache.org/jira/browse/OFBIZ-12014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-12014: -- Priority: Major (was: Trivial) > Error while decoding url parameters with percent character > -- > > Key: OFBIZ-12014 > URL: https://issues.apache.org/jira/browse/OFBIZ-12014 > Project: OFBiz > Issue Type: Bug > Components: base >Affects Versions: Release Branch 17.12, Trunk >Reporter: Pradeep Choudhary >Priority: Major > Attachments: Screenshot from 2020-09-14 12-02-00.png > > > When we pass any URL parameter with a percent character, it throws an > exception stating the following message: > "java.lang.IllegalArgumentException: URLDecoder: Illegal hex characters in > escape (%) pattern - For input string: " > Steps to regenerate: > 1. Open web tools. > 2. Navigate to Order Manager component > [https://localhost:8443/ordermgr/control/findorders] > 3. Search order by entering order Id like %Test%. > 4. It will show an error message "java.lang.IllegalArgumentException: > URLDecoder: Illegal hex characters in escape (%) pattern - For input string: > "Te" -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11947) Checkstyle: Add Javadoc for classes designed for extension
[ https://issues.apache.org/jira/browse/OFBIZ-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-11947. - Fix Version/s: Upcoming Branch Resolution: Implemented Last pair of patches fixed around *45* checkstyle issues. > Checkstyle: Add Javadoc for classes designed for extension > -- > > Key: OFBIZ-11947 > URL: https://issues.apache.org/jira/browse/OFBIZ-11947 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-11947-2.patch, OFBIZ-11947-3.patch, > OFBIZ-11947-plugins-3.patch, OFBIZ-11947-plugins.patch, OFBIZ-11947.patch > > > For checkstyle errors: > Class 'ResourceInfo' looks like designed for extension (can be subclassed), > but the method 'createResourceHandler' does not have javadoc that explains > how to do that safely. If class is not designed for extension consider making > the class 'ResourceInfo' final or making the method 'createResourceHandler' > static/final/abstract/empty, or adding allowed annotation for the method. > We need to add missing javadocs for all such methods -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11947) Checkstyle: Add Javadoc for classes designed for extension
[ https://issues.apache.org/jira/browse/OFBIZ-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11947: -- Attachment: OFBIZ-11947-plugins-3.patch OFBIZ-11947-3.patch > Checkstyle: Add Javadoc for classes designed for extension > -- > > Key: OFBIZ-11947 > URL: https://issues.apache.org/jira/browse/OFBIZ-11947 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11947-2.patch, OFBIZ-11947-3.patch, > OFBIZ-11947-plugins-3.patch, OFBIZ-11947-plugins.patch, OFBIZ-11947.patch > > > For checkstyle errors: > Class 'ResourceInfo' looks like designed for extension (can be subclassed), > but the method 'createResourceHandler' does not have javadoc that explains > how to do that safely. If class is not designed for extension consider making > the class 'ResourceInfo' final or making the method 'createResourceHandler' > static/final/abstract/empty, or adding allowed annotation for the method. > We need to add missing javadocs for all such methods -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11963) Checkstyle: Variable must be private and have accessor methods
[ https://issues.apache.org/jira/browse/OFBIZ-11963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-11963. - Fix Version/s: Upcoming Branch Resolution: Implemented These pair of last patches fixed around *160* checkstyle issues. > Checkstyle: Variable must be private and have accessor methods > -- > > Key: OFBIZ-11963 > URL: https://issues.apache.org/jira/browse/OFBIZ-11963 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-11963-2.patch, OFBIZ-11963-plugins-2.patch, > OFBIZ-11963-plugins.patch, OFBIZ-11963.patch, Screenshot 2020-08-20 at > 5.42.17 PM.png > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11963) Checkstyle: Variable must be private and have accessor methods
[ https://issues.apache.org/jira/browse/OFBIZ-11963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194631#comment-17194631 ] Suraj Khurana commented on OFBIZ-11963: --- All test passed in testIntegration for last uploaded patches. > Checkstyle: Variable must be private and have accessor methods > -- > > Key: OFBIZ-11963 > URL: https://issues.apache.org/jira/browse/OFBIZ-11963 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11963-2.patch, OFBIZ-11963-plugins-2.patch, > OFBIZ-11963-plugins.patch, OFBIZ-11963.patch, Screenshot 2020-08-20 at > 5.42.17 PM.png > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11963) Checkstyle: Variable must be private and have accessor methods
[ https://issues.apache.org/jira/browse/OFBIZ-11963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11963: -- Attachment: OFBIZ-11963-plugins-2.patch OFBIZ-11963-2.patch > Checkstyle: Variable must be private and have accessor methods > -- > > Key: OFBIZ-11963 > URL: https://issues.apache.org/jira/browse/OFBIZ-11963 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11963-2.patch, OFBIZ-11963-plugins-2.patch, > OFBIZ-11963-plugins.patch, OFBIZ-11963.patch, Screenshot 2020-08-20 at > 5.42.17 PM.png > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters
[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-11921. - Fix Version/s: Upcoming Branch Resolution: Implemented Last pair of patches fixed around *1250* checkstyle issues. > Checkstyle: Line is longer than 150 characters > -- > > Key: OFBIZ-11921 > URL: https://issues.apache.org/jira/browse/OFBIZ-11921 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-11921-2.patch, OFBIZ-11921-3.patch, > OFBIZ-11921-plugins-2.patch, OFBIZ-11921-plugins-3.patch, OFBIZ-11921.patch, > OFBIZ-plugins-11921.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters
[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190167#comment-17190167 ] Suraj Khurana commented on OFBIZ-11921: --- Build successful. All tests passed in testIntegration. > Checkstyle: Line is longer than 150 characters > -- > > Key: OFBIZ-11921 > URL: https://issues.apache.org/jira/browse/OFBIZ-11921 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11921-2.patch, OFBIZ-11921-3.patch, > OFBIZ-11921-plugins-2.patch, OFBIZ-11921-plugins-3.patch, OFBIZ-11921.patch, > OFBIZ-plugins-11921.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters
[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189929#comment-17189929 ] Suraj Khurana commented on OFBIZ-11921: --- Last patch for this ticket attached. > Checkstyle: Line is longer than 150 characters > -- > > Key: OFBIZ-11921 > URL: https://issues.apache.org/jira/browse/OFBIZ-11921 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11921-2.patch, OFBIZ-11921-3.patch, > OFBIZ-11921-plugins-2.patch, OFBIZ-11921-plugins-3.patch, OFBIZ-11921.patch, > OFBIZ-plugins-11921.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters
[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11921: -- Attachment: OFBIZ-11921-plugins-3.patch OFBIZ-11921-3.patch > Checkstyle: Line is longer than 150 characters > -- > > Key: OFBIZ-11921 > URL: https://issues.apache.org/jira/browse/OFBIZ-11921 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11921-2.patch, OFBIZ-11921-3.patch, > OFBIZ-11921-plugins-2.patch, OFBIZ-11921-plugins-3.patch, OFBIZ-11921.patch, > OFBIZ-plugins-11921.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11978) "cart" should be "card"
[ https://issues.apache.org/jira/browse/OFBIZ-11978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-11978. - Fix Version/s: 17.12.05 18.12.01 Resolution: Fixed Thanks Alex Bodnaru. > "cart" should be "card" > --- > > Key: OFBIZ-11978 > URL: https://issues.apache.org/jira/browse/OFBIZ-11978 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Suraj Khurana >Priority: Trivial > Fix For: 18.12.01, 17.12.05 > > Attachments: p-card-typo.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters
[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187776#comment-17187776 ] Suraj Khurana commented on OFBIZ-11921: --- Thanks Jacques for review. Both the patches are loaded into trunk and this fixed around *1020* checkstyle issues. > Checkstyle: Line is longer than 150 characters > -- > > Key: OFBIZ-11921 > URL: https://issues.apache.org/jira/browse/OFBIZ-11921 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11921-2.patch, OFBIZ-11921-plugins-2.patch, > OFBIZ-11921.patch, OFBIZ-plugins-11921.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters
[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187661#comment-17187661 ] Suraj Khurana commented on OFBIZ-11921: --- Yes, this one of plugins is kind of mixed and thus small, nothing major of same kind left in plugins. :) > Checkstyle: Line is longer than 150 characters > -- > > Key: OFBIZ-11921 > URL: https://issues.apache.org/jira/browse/OFBIZ-11921 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11921-2.patch, OFBIZ-11921-plugins-2.patch, > OFBIZ-11921.patch, OFBIZ-plugins-11921.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11954) Expiring Daemon because JVM heap space is exhausted
[
https://issues.apache.org/jira/browse/OFBIZ-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187630#comment-17187630
]
Suraj Khurana commented on OFBIZ-11954:
---
Hi Jacques,
I faced it on both, Linux (18.04) as well as Mac OS (Catalina).
HTH.
> Expiring Daemon because JVM heap space is exhausted
> ---
>
> Key: OFBIZ-11954
> URL: https://issues.apache.org/jira/browse/OFBIZ-11954
> Project: OFBiz
> Issue Type: Bug
> Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.01
>
>
> Today I got this in log out of the blue:
> {quote}
> Daemon will be stopped at the end of the build after running out of JVM
> memory
> Expiring Daemon because JVM heap space is exhausted
> {quote}
> I checked there was no OutOfMemoryError exception. And apart that in log the
> applications were running well
> The most relevant articles I found on the Net were:
> https://stackoverflow.com/questions/56075455/expiring-daemon-because-jvm-heap-space-is-exhausted
> https://medium.com/@tiwarishani/expiring-daemon-because-jvm-heap-space-is-exhausted-in-react-native-e17c2248c8af
> I'm not sure this issue will reproduce (why just now?). I'll discuss this on
> dev ML before increasing
> org.gradle.jvmargs
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters
[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11921: -- Attachment: OFBIZ-11921-plugins-2.patch OFBIZ-11921-2.patch > Checkstyle: Line is longer than 150 characters > -- > > Key: OFBIZ-11921 > URL: https://issues.apache.org/jira/browse/OFBIZ-11921 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11921-2.patch, OFBIZ-11921-plugins-2.patch, > OFBIZ-11921.patch, OFBIZ-plugins-11921.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11926) Checkstyle: Variable name must match pattern
[ https://issues.apache.org/jira/browse/OFBIZ-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186892#comment-17186892 ] Suraj Khurana commented on OFBIZ-11926: --- Hello Jacques, This is an interesting case that you fixed and I found some other refactoring oppotunities similar code patterns in codebase. How do you suggest to handle such cases? One option is to add Debug.log for these unhandled condition code block. We can add a verbose to avoid any unnecessary load on logging unwanted things. Please share your thoughts on this. > Checkstyle: Variable name must match pattern > > > Key: OFBIZ-11926 > URL: https://issues.apache.org/jira/browse/OFBIZ-11926 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: JsLanguageFilesMapping.patch, OFBIZ-11926-plugins.patch, > OFBIZ-11926.patch > > > All final data members of the class must match this naming pattern > '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$' -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11947) Checkstyle: Add Javadoc for classes designed for extension
[ https://issues.apache.org/jira/browse/OFBIZ-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186483#comment-17186483 ] Suraj Khurana commented on OFBIZ-11947: --- This patch fixed around *1180* checkstyle issues. > Checkstyle: Add Javadoc for classes designed for extension > -- > > Key: OFBIZ-11947 > URL: https://issues.apache.org/jira/browse/OFBIZ-11947 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11947-2.patch, OFBIZ-11947-plugins.patch, > OFBIZ-11947.patch > > > For checkstyle errors: > Class 'ResourceInfo' looks like designed for extension (can be subclassed), > but the method 'createResourceHandler' does not have javadoc that explains > how to do that safely. If class is not designed for extension consider making > the class 'ResourceInfo' final or making the method 'createResourceHandler' > static/final/abstract/empty, or adding allowed annotation for the method. > We need to add missing javadocs for all such methods -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11970) Add to cart is not working for products with selectable features
[ https://issues.apache.org/jira/browse/OFBIZ-11970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186324#comment-17186324 ] Suraj Khurana edited comment on OFBIZ-11970 at 8/28/20, 7:19 AM: - Thanks [~lodhiravi], Could you please confirm if this exist for release branch as well and update the *Affects Version/s:* accordingly? was (Author: suraj.khurana): Thanks [~lodhiravi], Could you please confirm if this exist for release version as well and update the *Affects Version/s:* accordingly? > Add to cart is not working for products with selectable features > > > Key: OFBIZ-11970 > URL: https://issues.apache.org/jira/browse/OFBIZ-11970 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Ravi Lodhi >Priority: Major > Attachments: addToCartProductWithVariantExplosionError.png > > > Steps to regenerate: > 1. Visit the [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]. > 2. Select the "Giant Widget with feature explosion" from the Popular > Categories section on home page. You will be redirected to product detail > page. > 3. Select color and size from the respective dropdowns and click on Add To > Cart button. > 4. Product is not getting added in cart. > > Expected: Product should be added successfully. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11970) Add to cart is not working for products with selectable features
[ https://issues.apache.org/jira/browse/OFBIZ-11970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186324#comment-17186324 ] Suraj Khurana commented on OFBIZ-11970: --- Thanks [~lodhiravi], Could you please confirm if this exist for release version as well and update the *Affects Version/s:* accordingly? > Add to cart is not working for products with selectable features > > > Key: OFBIZ-11970 > URL: https://issues.apache.org/jira/browse/OFBIZ-11970 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Ravi Lodhi >Priority: Major > Attachments: addToCartProductWithVariantExplosionError.png > > > Steps to regenerate: > 1. Visit the [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]. > 2. Select the "Giant Widget with feature explosion" from the Popular > Categories section on home page. You will be redirected to product detail > page. > 3. Select color and size from the respective dropdowns and click on Add To > Cart button. > 4. Product is not getting added in cart. > > Expected: Product should be added successfully. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11928) Explode items not handling tax and adjustments properly
[ https://issues.apache.org/jira/browse/OFBIZ-11928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186310#comment-17186310 ] Suraj Khurana commented on OFBIZ-11928: --- Hello [~ankush.upadhyay], These are all valid points that you have mentioned. Let's create a parent ticket and make child ticket of these enhancements we are finding, in this manner I think we can easily manage this effort of streamlining these explode item flow. Could you please create a parent ticket and report this issues as child tickets, this one can be its child and one more I have reported earlier related to explode item. TIA. > Explode items not handling tax and adjustments properly > --- > > Key: OFBIZ-11928 > URL: https://issues.apache.org/jira/browse/OFBIZ-11928 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Suraj Khurana >Assignee: Ankush Upadhyay >Priority: Major > Attachments: OFBIZ-11928.patch, image-2020-08-22-14-54-06-042.png > > > Steps to re-generate: > 1) Create order with 4 qty of purple Gizmo and 3 qty of GZ-1000 - Tiny Gizmo > 2) Now change explode item to Y > 3) Again create same order with same products and same quantity > 4) Notice difference in item subtotal and grand total > I see two issues here: > - item subtotal is 191.93 and 191.94, this should be addressed 191.94 is > correct when explode is set to N (default order) > Code reference: It should be handled inside ShoppingCartItem.java#explodeItem > - Total sales tax is different in both orders: > 10.72 and -0.03 which can be checked if this is any configuration issue, or > taxes are not being handled while exploding items. > Demo orders on trunk (will not last for long): > explode: N > > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO10001 > ]explode: Y > > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO1] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11928) Explode items not handling tax and adjustments properly
[ https://issues.apache.org/jira/browse/OFBIZ-11928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186309#comment-17186309 ] Suraj Khurana commented on OFBIZ-11928: --- Thanks [~ankush.upadhyay] for the patch. I will wait for couple of days in case of anyone has some inputs on this fix. LGTM. [~pradeep.choudhary1994] and [~rohit.koushal], in case you got a chance, you guys can also verify the patch and confirm. TIA. > Explode items not handling tax and adjustments properly > --- > > Key: OFBIZ-11928 > URL: https://issues.apache.org/jira/browse/OFBIZ-11928 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Suraj Khurana >Assignee: Ankush Upadhyay >Priority: Major > Attachments: OFBIZ-11928.patch, image-2020-08-22-14-54-06-042.png > > > Steps to re-generate: > 1) Create order with 4 qty of purple Gizmo and 3 qty of GZ-1000 - Tiny Gizmo > 2) Now change explode item to Y > 3) Again create same order with same products and same quantity > 4) Notice difference in item subtotal and grand total > I see two issues here: > - item subtotal is 191.93 and 191.94, this should be addressed 191.94 is > correct when explode is set to N (default order) > Code reference: It should be handled inside ShoppingCartItem.java#explodeItem > - Total sales tax is different in both orders: > 10.72 and -0.03 which can be checked if this is any configuration issue, or > taxes are not being handled while exploding items. > Demo orders on trunk (will not last for long): > explode: N > > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO10001 > ]explode: Y > > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO1] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11978) "cart" should be "card"
[ https://issues.apache.org/jira/browse/OFBIZ-11978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11978: -- Affects Version/s: Release Branch 17.12 Release Branch 18.12 > "cart" should be "card" > --- > > Key: OFBIZ-11978 > URL: https://issues.apache.org/jira/browse/OFBIZ-11978 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Suraj Khurana >Priority: Trivial > Attachments: p-card-typo.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11947) Checkstyle: Add Javadoc for classes designed for extension
[ https://issues.apache.org/jira/browse/OFBIZ-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186275#comment-17186275 ] Suraj Khurana commented on OFBIZ-11947: --- Attached next patch consisting further enhancements of similar type. > Checkstyle: Add Javadoc for classes designed for extension > -- > > Key: OFBIZ-11947 > URL: https://issues.apache.org/jira/browse/OFBIZ-11947 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11947-2.patch, OFBIZ-11947-plugins.patch, > OFBIZ-11947.patch > > > For checkstyle errors: > Class 'ResourceInfo' looks like designed for extension (can be subclassed), > but the method 'createResourceHandler' does not have javadoc that explains > how to do that safely. If class is not designed for extension consider making > the class 'ResourceInfo' final or making the method 'createResourceHandler' > static/final/abstract/empty, or adding allowed annotation for the method. > We need to add missing javadocs for all such methods -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11947) Checkstyle: Add Javadoc for classes designed for extension
[ https://issues.apache.org/jira/browse/OFBIZ-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11947: -- Attachment: OFBIZ-11947-2.patch > Checkstyle: Add Javadoc for classes designed for extension > -- > > Key: OFBIZ-11947 > URL: https://issues.apache.org/jira/browse/OFBIZ-11947 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11947-2.patch, OFBIZ-11947-plugins.patch, > OFBIZ-11947.patch > > > For checkstyle errors: > Class 'ResourceInfo' looks like designed for extension (can be subclassed), > but the method 'createResourceHandler' does not have javadoc that explains > how to do that safely. If class is not designed for extension consider making > the class 'ResourceInfo' final or making the method 'createResourceHandler' > static/final/abstract/empty, or adding allowed annotation for the method. > We need to add missing javadocs for all such methods -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11926) Checkstyle: Variable name must match pattern
[ https://issues.apache.org/jira/browse/OFBIZ-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185777#comment-17185777 ] Suraj Khurana commented on OFBIZ-11926: --- Hello [~jleroux], I got your point. Could you please verify the attached patch. TIA. > Checkstyle: Variable name must match pattern > > > Key: OFBIZ-11926 > URL: https://issues.apache.org/jira/browse/OFBIZ-11926 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: JsLanguageFilesMapping.patch, OFBIZ-11926-plugins.patch, > OFBIZ-11926.patch > > > All final data members of the class must match this naming pattern > '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$' -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11926) Checkstyle: Variable name must match pattern
[ https://issues.apache.org/jira/browse/OFBIZ-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11926: -- Attachment: JsLanguageFilesMapping.patch > Checkstyle: Variable name must match pattern > > > Key: OFBIZ-11926 > URL: https://issues.apache.org/jira/browse/OFBIZ-11926 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: JsLanguageFilesMapping.patch, OFBIZ-11926-plugins.patch, > OFBIZ-11926.patch > > > All final data members of the class must match this naming pattern > '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$' -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11926) Checkstyle: Variable name must match pattern
[ https://issues.apache.org/jira/browse/OFBIZ-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185310#comment-17185310 ] Suraj Khurana commented on OFBIZ-11926: --- Thanks Jacques, corrected inner class names as per naming convention at JsLanguageFilesMapping.java and related occurrences. Currently these patches have fixed around *1200* checkstyle issues. Now need to update method names (UPPER, UPPER_FIELD, TRIM etc) on EntityFunction.java and related occurrences. > Checkstyle: Variable name must match pattern > > > Key: OFBIZ-11926 > URL: https://issues.apache.org/jira/browse/OFBIZ-11926 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11926-plugins.patch, OFBIZ-11926.patch > > > All final data members of the class must match this naming pattern > '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$' -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11978) "cart" should be "card"
[ https://issues.apache.org/jira/browse/OFBIZ-11978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana reassigned OFBIZ-11978: - Assignee: Suraj Khurana > "cart" should be "card" > --- > > Key: OFBIZ-11978 > URL: https://issues.apache.org/jira/browse/OFBIZ-11978 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Alex Bodnaru >Assignee: Suraj Khurana >Priority: Trivial > Attachments: p-card-typo.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11978) "cart" should be "card"
[ https://issues.apache.org/jira/browse/OFBIZ-11978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183212#comment-17183212 ] Suraj Khurana commented on OFBIZ-11978: --- Hi Alex, Will you please confirm if this if for trunk only or update affect/s version accordingly. TIA. > "cart" should be "card" > --- > > Key: OFBIZ-11978 > URL: https://issues.apache.org/jira/browse/OFBIZ-11978 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Alex Bodnaru >Priority: Trivial > Attachments: p-card-typo.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11954) Expiring Daemon because JVM heap space is exhausted
[
https://issues.apache.org/jira/browse/OFBIZ-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183205#comment-17183205
]
Suraj Khurana commented on OFBIZ-11954:
---
I also faced this few days ago while working on an issue, didn't got a chance
to look deeper.
> Expiring Daemon because JVM heap space is exhausted
> ---
>
> Key: OFBIZ-11954
> URL: https://issues.apache.org/jira/browse/OFBIZ-11954
> Project: OFBiz
> Issue Type: Bug
> Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.01
>
>
> Today I got this in log out of the blue:
> {quote}
> Daemon will be stopped at the end of the build after running out of JVM
> memory
> Expiring Daemon because JVM heap space is exhausted
> {quote}
> I checked there was no OutOfMemoryError exception. And apart that in log the
> applications were running well
> The most relevant articles I found on the Net were:
> https://stackoverflow.com/questions/56075455/expiring-daemon-because-jvm-heap-space-is-exhausted
> https://medium.com/@tiwarishani/expiring-daemon-because-jvm-heap-space-is-exhausted-in-react-native-e17c2248c8af
> I'm not sure this issue will reproduce (why just now?). I'll discuss this on
> dev ML before increasing
> org.gradle.jvmargs
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11686) multi-block attribute for html-template tag
[
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183203#comment-17183203
]
Suraj Khurana commented on OFBIZ-11686:
---
Hi [~jleroux],
I remember we have enabled git pre-hook for direct commits to repo and we were
working to enable same for github PR's as well. Wasn't it done for PR's yet? So
that anyone won't be able to add code into repo violating checkstyle rules.
> multi-block attribute for html-template tag
> ---
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
> Issue Type: Improvement
> Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new widget tag that adds an external script after
> body tag.
> The external script will contain the rendered result of the specified
> template file location.
> e.g.
> {code:xml}
>
>
> {code}
>
> will render as:
> {code:xml}
>
> type="application/javascript"/>
>
> {code}
> This will allow inline script from a freemarker file, to be rendered as
> external script in html.
>
> Discussion was started at
> [https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]
>
> *15th May 2020*
> While extracting the scripts from html-template to script-template and
> testing the changes, I found the process to be cumbersome.
> So I made a change not to use script-template tag but add a multi-block
> attribute to html-template tag.
> When *multi-block=true*, inline scripts will be extracted automatically from
> script tag and converted to external script.
> So no need to manually extract script from the existing freemarker template.
> Coding for script-template tag is removed
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11926) Checkstyle: Variable name must match pattern
[ https://issues.apache.org/jira/browse/OFBIZ-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182719#comment-17182719 ] Suraj Khurana commented on OFBIZ-11926: --- All class names, method names, data members of class and local variables names are corrected, except following: EntityFunction.java, Line 53 to 85 (UPPER, LOWER, TRIM, LENGTH etc methods) Some class names in JsLanguageFilesMapping.java, as there was a note in the file: DO NOT EDIT THIS FILE! THIS IS AUTO GENERATED AND WILL GET WRITTEN OVER PERIODICALLY WHEN THE DATA CHANGE > Checkstyle: Variable name must match pattern > > > Key: OFBIZ-11926 > URL: https://issues.apache.org/jira/browse/OFBIZ-11926 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11926-plugins.patch, OFBIZ-11926.patch > > > All final data members of the class must match this naming pattern > '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$' -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11926) Checkstyle: Variable name must match pattern
[ https://issues.apache.org/jira/browse/OFBIZ-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11926: -- Attachment: OFBIZ-11926-plugins.patch OFBIZ-11926.patch > Checkstyle: Variable name must match pattern > > > Key: OFBIZ-11926 > URL: https://issues.apache.org/jira/browse/OFBIZ-11926 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11926-plugins.patch, OFBIZ-11926.patch > > > All final data members of the class must match this naming pattern > '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$' -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11928) Explode items not handling tax and adjustments properly
[ https://issues.apache.org/jira/browse/OFBIZ-11928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182585#comment-17182585 ] Suraj Khurana commented on OFBIZ-11928: --- +1 Ankush, It looks good to me. Please verify all the order level data and provide a patch for this solution. > Explode items not handling tax and adjustments properly > --- > > Key: OFBIZ-11928 > URL: https://issues.apache.org/jira/browse/OFBIZ-11928 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Suraj Khurana >Assignee: Pradeep Choudhary >Priority: Major > Attachments: image-2020-08-22-14-54-06-042.png > > > Steps to re-generate: > 1) Create order with 4 qty of purple Gizmo and 3 qty of GZ-1000 - Tiny Gizmo > 2) Now change explode item to Y > 3) Again create same order with same products and same quantity > 4) Notice difference in item subtotal and grand total > I see two issues here: > - item subtotal is 191.93 and 191.94, this should be addressed 191.94 is > correct when explode is set to N (default order) > Code reference: It should be handled inside ShoppingCartItem.java#explodeItem > - Total sales tax is different in both orders: > 10.72 and -0.03 which can be checked if this is any configuration issue, or > taxes are not being handled while exploding items. > Demo orders on trunk (will not last for long): > explode: N > > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO10001 > ]explode: Y > > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO1] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11944) Replace .size() == 0 with isEmpty() in Java files
[ https://issues.apache.org/jira/browse/OFBIZ-11944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182390#comment-17182390 ] Suraj Khurana edited comment on OFBIZ-11944 at 8/22/20, 2:15 PM: - I was about to review this, though it is committed pretty soon (less than 2 hours), will review it later. was (Author: suraj.khurana): I was about to reviw this, though it is committed pretty soon (less than 2 hours), will review it later. > Replace .size() == 0 with isEmpty() in Java files > - > > Key: OFBIZ-11944 > URL: https://issues.apache.org/jira/browse/OFBIZ-11944 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Reporter: Priya Sharma >Assignee: Pawan Verma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11944-plugin.patch, OFBIZ-11944.patch > > > For a better understanding of how it may be helpful, this article puts some > light > https://rb.gy/mhpuzg -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11944) Replace .size() == 0 with isEmpty() in Java files
[ https://issues.apache.org/jira/browse/OFBIZ-11944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182390#comment-17182390 ] Suraj Khurana commented on OFBIZ-11944: --- I was about to reviw this, though it is committed pretty soon (less than 2 hours), will review it later. > Replace .size() == 0 with isEmpty() in Java files > - > > Key: OFBIZ-11944 > URL: https://issues.apache.org/jira/browse/OFBIZ-11944 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Reporter: Priya Sharma >Assignee: Pawan Verma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11944-plugin.patch, OFBIZ-11944.patch > > > For a better understanding of how it may be helpful, this article puts some > light > https://rb.gy/mhpuzg -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11971) Incorrect data for InvoiceItemTypeMap and ReturnItemTypeMap
[ https://issues.apache.org/jira/browse/OFBIZ-11971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11971: -- Sprint: OFBiz Community Day (Aug 2020) > Incorrect data for InvoiceItemTypeMap and ReturnItemTypeMap > --- > > Key: OFBIZ-11971 > URL: https://issues.apache.org/jira/browse/OFBIZ-11971 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Suraj Khurana >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-11971.patch > > > 'RET_MISC_CHARGE_ADJ' is used as returnItemTypeId in ReturnItemTypeMap data > and it also used as invoiceItemMapKey in InvoiceItemTypeMap data but its type > data does not exists. > The following data exist for miscellaneous charges in data files: > returnAdjustmentTypeId="RET_MISC_ADJ"/> -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11963) Checkstyle: Variable must be private and have accessor methods
[ https://issues.apache.org/jira/browse/OFBIZ-11963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182271#comment-17182271 ] Suraj Khurana commented on OFBIZ-11963: --- Thanks Jacques. I committed slightly modified patches, this fixed around *2800* checkstyle issues. There are more occurrences, so keeping it open for now. Gradually, we will catch up with Javadoc consistency in overall codebase as well. > Checkstyle: Variable must be private and have accessor methods > -- > > Key: OFBIZ-11963 > URL: https://issues.apache.org/jira/browse/OFBIZ-11963 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11963-plugins.patch, OFBIZ-11963.patch, Screenshot > 2020-08-20 at 5.42.17 PM.png > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11350) Checkstyle improvements
[ https://issues.apache.org/jira/browse/OFBIZ-11350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11350: -- Sprint: OFBiz Community Day (May 2020), OFBiz Community Day (Aug 2020) (was: OFBiz Community Day (May 2020)) > Checkstyle improvements > --- > > Key: OFBIZ-11350 > URL: https://issues.apache.org/jira/browse/OFBIZ-11350 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > > This is an umbrella task for checkstyle improvements. > See related discussion on the dev mailinglist: > https://lists.apache.org/thread.html/rf417d7b136eda217916483592f7e072184a0687babfe7f0b74bf820e%40%3Cdev.ofbiz.apache.org%3E -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11963) Checkstyle: Variable must be private and have accessor methods
[ https://issues.apache.org/jira/browse/OFBIZ-11963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181666#comment-17181666 ] Suraj Khurana commented on OFBIZ-11963: --- +1 for the first one, same thought and thus adding new javadocs in the same pattern, also, I noticed at some places this one is already in use. Also, it is not consistent as of now in the codebase. > Checkstyle: Variable must be private and have accessor methods > -- > > Key: OFBIZ-11963 > URL: https://issues.apache.org/jira/browse/OFBIZ-11963 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11963-plugins.patch, OFBIZ-11963.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11963) Checkstyle: Variable must be private and have accessor methods
[ https://issues.apache.org/jira/browse/OFBIZ-11963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181043#comment-17181043 ] Suraj Khurana commented on OFBIZ-11963: --- Right Jacques, used IntelliJ plugin to generate getter/setter and another Javadoc plugin to auto create Javadocs for the generated methods. Also, I don't like empty lines in Javadocs, so usually I find/replace it. :) > Checkstyle: Variable must be private and have accessor methods > -- > > Key: OFBIZ-11963 > URL: https://issues.apache.org/jira/browse/OFBIZ-11963 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11963-plugins.patch, OFBIZ-11963.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11963) Checkstyle: Variable must be private and have accessor methods
[ https://issues.apache.org/jira/browse/OFBIZ-11963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180981#comment-17180981 ] Suraj Khurana commented on OFBIZ-11963: --- ./gradlew testIntegration working fine. All tests passed. > Checkstyle: Variable must be private and have accessor methods > -- > > Key: OFBIZ-11963 > URL: https://issues.apache.org/jira/browse/OFBIZ-11963 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11963-plugins.patch, OFBIZ-11963.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11963) Checkstyle: Variable must be private and have accessor methods
[ https://issues.apache.org/jira/browse/OFBIZ-11963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180629#comment-17180629 ] Suraj Khurana commented on OFBIZ-11963: --- Attached initial patches, these are tend to fix around 2k checkstyle issues, more on the way. As some getter/setter methods are introduced, I am still testing these patches. Currently, build success and webtools, service reference working fine (this area is majorly worked upon). Please review and let me know in case of something comes up. TIA. > Checkstyle: Variable must be private and have accessor methods > -- > > Key: OFBIZ-11963 > URL: https://issues.apache.org/jira/browse/OFBIZ-11963 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11963-plugins.patch, OFBIZ-11963.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11965) Improve service name as per best practices
[ https://issues.apache.org/jira/browse/OFBIZ-11965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180627#comment-17180627 ] Suraj Khurana commented on OFBIZ-11965: --- This was discovered while working upon https://issues.apache.org/jira/browse/OFBIZ-11963 > Improve service name as per best practices > -- > > Key: OFBIZ-11965 > URL: https://issues.apache.org/jira/browse/OFBIZ-11965 > Project: OFBiz > Issue Type: Improvement > Components: ALL PLUGINS >Affects Versions: Trunk >Reporter: Suraj Khurana >Priority: Minor > > Following service names should be corrected as per naming convention best > practices: > * SagePayPaymentAuthorisation > * SagePayPaymentRefund > * SagePayPaymentRelease > * SagePayPaymentVoid > * SetTimeZoneFromBrowser > * SagePayPaymentAuthentication -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11963) Checkstyle: Variable must be private and have accessor methods
[ https://issues.apache.org/jira/browse/OFBIZ-11963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11963: -- Attachment: OFBIZ-11963.patch OFBIZ-11963-plugins.patch > Checkstyle: Variable must be private and have accessor methods > -- > > Key: OFBIZ-11963 > URL: https://issues.apache.org/jira/browse/OFBIZ-11963 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11963-plugins.patch, OFBIZ-11963.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11965) Improve service name as per best practices
Suraj Khurana created OFBIZ-11965: - Summary: Improve service name as per best practices Key: OFBIZ-11965 URL: https://issues.apache.org/jira/browse/OFBIZ-11965 Project: OFBiz Issue Type: Improvement Components: ALL PLUGINS Affects Versions: Trunk Reporter: Suraj Khurana Following service names should be corrected as per naming convention best practices: * SagePayPaymentAuthorisation * SagePayPaymentRefund * SagePayPaymentRelease * SagePayPaymentVoid * SetTimeZoneFromBrowser * SagePayPaymentAuthentication -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11963) Checkstyle: Variable must be private and have accessor methods
Suraj Khurana created OFBIZ-11963: - Summary: Checkstyle: Variable must be private and have accessor methods Key: OFBIZ-11963 URL: https://issues.apache.org/jira/browse/OFBIZ-11963 Project: OFBiz Issue Type: Sub-task Components: ALL COMPONENTS Affects Versions: Trunk Reporter: Suraj Khurana Assignee: Suraj Khurana -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11947) Checkstyle: Add Javadoc for classes designed for extension
[ https://issues.apache.org/jira/browse/OFBIZ-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178780#comment-17178780 ] Suraj Khurana commented on OFBIZ-11947: --- This commit has fixed around *1960* checkstyle issues, more on the way. > Checkstyle: Add Javadoc for classes designed for extension > -- > > Key: OFBIZ-11947 > URL: https://issues.apache.org/jira/browse/OFBIZ-11947 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11947-plugins.patch, OFBIZ-11947.patch > > > For checkstyle errors: > Class 'ResourceInfo' looks like designed for extension (can be subclassed), > but the method 'createResourceHandler' does not have javadoc that explains > how to do that safely. If class is not designed for extension consider making > the class 'ResourceInfo' final or making the method 'createResourceHandler' > static/final/abstract/empty, or adding allowed annotation for the method. > We need to add missing javadocs for all such methods -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11947) Checkstyle: Add Javadoc for classes designed for extension
[ https://issues.apache.org/jira/browse/OFBIZ-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178718#comment-17178718 ] Suraj Khurana commented on OFBIZ-11947: --- Oops, thanks Jacques, I will take care of it while commit. > Checkstyle: Add Javadoc for classes designed for extension > -- > > Key: OFBIZ-11947 > URL: https://issues.apache.org/jira/browse/OFBIZ-11947 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11947-plugins.patch, OFBIZ-11947.patch > > > For checkstyle errors: > Class 'ResourceInfo' looks like designed for extension (can be subclassed), > but the method 'createResourceHandler' does not have javadoc that explains > how to do that safely. If class is not designed for extension consider making > the class 'ResourceInfo' final or making the method 'createResourceHandler' > static/final/abstract/empty, or adding allowed annotation for the method. > We need to add missing javadocs for all such methods -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11947) Checkstyle: Add Javadoc for classes designed for extension
[ https://issues.apache.org/jira/browse/OFBIZ-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11947: -- Attachment: OFBIZ-11947.patch OFBIZ-11947-plugins.patch > Checkstyle: Add Javadoc for classes designed for extension > -- > > Key: OFBIZ-11947 > URL: https://issues.apache.org/jira/browse/OFBIZ-11947 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11947-plugins.patch, OFBIZ-11947.patch > > > For checkstyle errors: > Class 'ResourceInfo' looks like designed for extension (can be subclassed), > but the method 'createResourceHandler' does not have javadoc that explains > how to do that safely. If class is not designed for extension consider making > the class 'ResourceInfo' final or making the method 'createResourceHandler' > static/final/abstract/empty, or adding allowed annotation for the method. > We need to add missing javadocs for all such methods -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11947) Checkstyle: Add Javadoc for classes designed for extension
Suraj Khurana created OFBIZ-11947: - Summary: Checkstyle: Add Javadoc for classes designed for extension Key: OFBIZ-11947 URL: https://issues.apache.org/jira/browse/OFBIZ-11947 Project: OFBiz Issue Type: Sub-task Components: ALL COMPONENTS Affects Versions: Trunk Reporter: Suraj Khurana Assignee: Suraj Khurana For checkstyle errors: Class 'ResourceInfo' looks like designed for extension (can be subclassed), but the method 'createResourceHandler' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ResourceInfo' final or making the method 'createResourceHandler' static/final/abstract/empty, or adding allowed annotation for the method. We need to add missing javadocs for all such methods -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11941) Checkstyle: Add override property in DesignForExtension module
[ https://issues.apache.org/jira/browse/OFBIZ-11941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-11941. - Fix Version/s: Upcoming Branch Resolution: Implemented This fixed around *1925* checkstyle issues. > Checkstyle: Add override property in DesignForExtension module > -- > > Key: OFBIZ-11941 > URL: https://issues.apache.org/jira/browse/OFBIZ-11941 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-11941.patch > > > While performing checks for class design it is mandatory to provide javadoc, > we can skip override methods from this checkstyle check. > Sample error: > Class 'ABC' looks like designed for extension (can be subclassed), but the > method 'xyz' does not have javadoc that explains how to do that safely. If > class is not designed for extension consider making the class 'ABC' final or > making the method 'xyz' static/final/abstract/empty, or adding allowed > annotation for the method. > >value="After, AfterClass, Before, BeforeClass, Test, Property, *Override*"/> > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11931) ParameterNumber checkstyle rule
[ https://issues.apache.org/jira/browse/OFBIZ-11931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-11931. - Fix Version/s: Upcoming Branch Resolution: Implemented This fixed around *110* checkstyle issues. > ParameterNumber checkstyle rule > --- > > Key: OFBIZ-11931 > URL: https://issues.apache.org/jira/browse/OFBIZ-11931 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-11931.patch > > > ML discussion: https://markmail.org/message/uyzaxwskrkwovyod -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11930) Remove unused imports from Java files
[ https://issues.apache.org/jira/browse/OFBIZ-11930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-11930. - Fix Version/s: Upcoming Branch Resolution: Implemented This fixed around *54* checkstyle issues. Thanks: Priya Sharma for your contribution. > Remove unused imports from Java files > - > > Key: OFBIZ-11930 > URL: https://issues.apache.org/jira/browse/OFBIZ-11930 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Priya Sharma >Assignee: Suraj Khurana >Priority: Minor > Fix For: Upcoming Branch > > > Unused package imports can be removed for code optimization. > Similar effort was done previously for groovy files > https://issues.apache.org/jira/browse/OFBIZ-7334 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11930) Remove unused imports from Java files
[ https://issues.apache.org/jira/browse/OFBIZ-11930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172409#comment-17172409 ] Suraj Khurana commented on OFBIZ-11930: --- Hello Priya, I guess apart from those covered in PR, there are few more occurrences of unused imports. You can check it on 'ofbiz/build/reports/checkstyle/main.html' after latest build. Search string 'unused import' in main.html in browser to get the remaining unused imports. TIA. > Remove unused imports from Java files > - > > Key: OFBIZ-11930 > URL: https://issues.apache.org/jira/browse/OFBIZ-11930 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Priya Sharma >Assignee: Suraj Khurana >Priority: Minor > > Unused package imports can be removed for code optimization. > Similar effort was done previously for groovy files > https://issues.apache.org/jira/browse/OFBIZ-7334 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11930) Remove unused imports from Java files
[ https://issues.apache.org/jira/browse/OFBIZ-11930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana reassigned OFBIZ-11930: - Assignee: Suraj Khurana (was: Priya Sharma) > Remove unused imports from Java files > - > > Key: OFBIZ-11930 > URL: https://issues.apache.org/jira/browse/OFBIZ-11930 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Priya Sharma >Assignee: Suraj Khurana >Priority: Minor > > Unused package imports can be removed for code optimization. > Similar effort was done previously for groovy files > https://issues.apache.org/jira/browse/OFBIZ-7334 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11915) Handle MethodLength checkstyle rule
[ https://issues.apache.org/jira/browse/OFBIZ-11915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-11915. - Fix Version/s: Upcoming Branch Resolution: Implemented As of now, this configuration fixed around 200 checkstyle issues. > Handle MethodLength checkstyle rule > --- > > Key: OFBIZ-11915 > URL: https://issues.apache.org/jira/browse/OFBIZ-11915 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-11915.patch > > > ML discussion: > https://markmail.org/message/y4uuqrjsu5mtztwz -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11915) Handle MethodLength checkstyle rule
[ https://issues.apache.org/jira/browse/OFBIZ-11915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172372#comment-17172372 ] Suraj Khurana commented on OFBIZ-11915: --- +1, agreed. > Handle MethodLength checkstyle rule > --- > > Key: OFBIZ-11915 > URL: https://issues.apache.org/jira/browse/OFBIZ-11915 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11915.patch > > > ML discussion: > https://markmail.org/message/y4uuqrjsu5mtztwz -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11925) Checkstyle: Redundant modifiers
[
https://issues.apache.org/jira/browse/OFBIZ-11925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Suraj Khurana closed OFBIZ-11925.
-
Fix Version/s: Upcoming Branch
Resolution: Implemented
Thanks Jacques.
> Checkstyle: Redundant modifiers
> ---
>
> Key: OFBIZ-11925
> URL: https://issues.apache.org/jira/browse/OFBIZ-11925
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11925.patch
>
>
> {color:#172b4d}Redundant 'static' modifier.{color}
> {color:#172b4d}Redundant 'final' modifier.{color}
> {color:#172b4d}Redundant 'public' modifier.
> Need to fix all these checkstyle occurences{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11925) Checkstyle: Redundant modifiers
[
https://issues.apache.org/jira/browse/OFBIZ-11925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172370#comment-17172370
]
Suraj Khurana commented on OFBIZ-11925:
---
This ticket fixed around 325 checkstyle issues.
> Checkstyle: Redundant modifiers
> ---
>
> Key: OFBIZ-11925
> URL: https://issues.apache.org/jira/browse/OFBIZ-11925
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11925.patch
>
>
> {color:#172b4d}Redundant 'static' modifier.{color}
> {color:#172b4d}Redundant 'final' modifier.{color}
> {color:#172b4d}Redundant 'public' modifier.
> Need to fix all these checkstyle occurences{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11925) Checkstyle: Redundant modifiers
[
https://issues.apache.org/jira/browse/OFBIZ-11925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Suraj Khurana updated OFBIZ-11925:
--
Attachment: OFBIZ-11925.patch
> Checkstyle: Redundant modifiers
> ---
>
> Key: OFBIZ-11925
> URL: https://issues.apache.org/jira/browse/OFBIZ-11925
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11925.patch
>
>
> {color:#172b4d}Redundant 'static' modifier.{color}
> {color:#172b4d}Redundant 'final' modifier.{color}
> {color:#172b4d}Redundant 'public' modifier.
> Need to fix all these checkstyle occurences{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11941) Checkstyle: Add override property in DesignForExtension module
[ https://issues.apache.org/jira/browse/OFBIZ-11941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11941: -- Attachment: OFBIZ-11941.patch > Checkstyle: Add override property in DesignForExtension module > -- > > Key: OFBIZ-11941 > URL: https://issues.apache.org/jira/browse/OFBIZ-11941 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11941.patch > > > While performing checks for class design it is mandatory to provide javadoc, > we can skip override methods from this checkstyle check. > Sample error: > Class 'ABC' looks like designed for extension (can be subclassed), but the > method 'xyz' does not have javadoc that explains how to do that safely. If > class is not designed for extension consider making the class 'ABC' final or > making the method 'xyz' static/final/abstract/empty, or adding allowed > annotation for the method. > >value="After, AfterClass, Before, BeforeClass, Test, Property, *Override*"/> > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11941) Checkstyle: Add override property in DesignForExtension module
Suraj Khurana created OFBIZ-11941: - Summary: Checkstyle: Add override property in DesignForExtension module Key: OFBIZ-11941 URL: https://issues.apache.org/jira/browse/OFBIZ-11941 Project: OFBiz Issue Type: Sub-task Components: ALL COMPONENTS Affects Versions: Trunk Reporter: Suraj Khurana Assignee: Suraj Khurana While performing checks for class design it is mandatory to provide javadoc, we can skip override methods from this checkstyle check. Sample error: Class 'ABC' looks like designed for extension (can be subclassed), but the method 'xyz' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ABC' final or making the method 'xyz' static/final/abstract/empty, or adding allowed annotation for the method. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11931) ParameterNumber checkstyle rule
[ https://issues.apache.org/jira/browse/OFBIZ-11931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11931: -- Attachment: OFBIZ-11931.patch > ParameterNumber checkstyle rule > --- > > Key: OFBIZ-11931 > URL: https://issues.apache.org/jira/browse/OFBIZ-11931 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11931.patch > > > ML discussion: https://markmail.org/message/uyzaxwskrkwovyod -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11915) Handle MethodLength checkstyle rule
[ https://issues.apache.org/jira/browse/OFBIZ-11915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11915: -- Attachment: OFBIZ-11915.patch > Handle MethodLength checkstyle rule > --- > > Key: OFBIZ-11915 > URL: https://issues.apache.org/jira/browse/OFBIZ-11915 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11915.patch > > > ML discussion: > https://markmail.org/message/y4uuqrjsu5mtztwz -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters
[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169312#comment-17169312 ] Suraj Khurana commented on OFBIZ-11921: --- Attached initial patch, there will be some more for this changes. This patch fixes around *2150* checkstyle issues. Few general issues are also being take care in this patch > Checkstyle: Line is longer than 150 characters > -- > > Key: OFBIZ-11921 > URL: https://issues.apache.org/jira/browse/OFBIZ-11921 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11921.patch, OFBIZ-plugins-11921.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters
[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11921: -- Attachment: OFBIZ-plugins-11921.patch OFBIZ-11921.patch > Checkstyle: Line is longer than 150 characters > -- > > Key: OFBIZ-11921 > URL: https://issues.apache.org/jira/browse/OFBIZ-11921 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11921.patch, OFBIZ-plugins-11921.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11930) Remove unused imports from Java files
[ https://issues.apache.org/jira/browse/OFBIZ-11930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169291#comment-17169291 ] Suraj Khurana commented on OFBIZ-11930: --- Hi Priya, Thanks for creating this ticket. This is a small part of checkstyle improvement, I think we can convert it to sub-task of https://issues.apache.org/jira/browse/OFBIZ-11350. WDYT? > Remove unused imports from Java files > - > > Key: OFBIZ-11930 > URL: https://issues.apache.org/jira/browse/OFBIZ-11930 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Reporter: Priya Sharma >Assignee: Priya Sharma >Priority: Minor > > Unused package imports can be removed for code optimization. > Similar effort was done previously for groovy files > https://issues.apache.org/jira/browse/OFBIZ-7334 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11915) Handle MethodLength checkstyle rule
[ https://issues.apache.org/jira/browse/OFBIZ-11915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11915: -- Description: ML discussion: https://markmail.org/message/y4uuqrjsu5mtztwz > Handle MethodLength checkstyle rule > --- > > Key: OFBIZ-11915 > URL: https://issues.apache.org/jira/browse/OFBIZ-11915 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > > ML discussion: > https://markmail.org/message/y4uuqrjsu5mtztwz -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11931) ParameterNumber checkstyle rule
[ https://issues.apache.org/jira/browse/OFBIZ-11931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11931: -- Parent: OFBIZ-11350 Issue Type: Sub-task (was: Improvement) > ParameterNumber checkstyle rule > --- > > Key: OFBIZ-11931 > URL: https://issues.apache.org/jira/browse/OFBIZ-11931 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > > ML discussion: https://markmail.org/message/uyzaxwskrkwovyod -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11931) ParameterNumber checkstyle rule
Suraj Khurana created OFBIZ-11931: - Summary: ParameterNumber checkstyle rule Key: OFBIZ-11931 URL: https://issues.apache.org/jira/browse/OFBIZ-11931 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: Trunk Reporter: Suraj Khurana Assignee: Suraj Khurana ML discussion: https://markmail.org/message/uyzaxwskrkwovyod -- This message was sent by Atlassian Jira (v8.3.4#803005)
