[jira] [Commented] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal
[
https://issues.apache.org/jira/browse/OFBIZ-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126706#comment-17126706
]
Ulrich Heidfeld commented on OFBIZ-11743:
-
Hi [~nmalin],
i have spotted this issue only in menu items. For example this can be tested by
applying following changes:
{code:java}
diff --git a/framework/webtools/widget/Menus.xml
b/framework/webtools/widget/Menus.xml
index 0dab587..02f4a24 100644
--- a/framework/webtools/widget/Menus.xml
+++ b/framework/webtools/widget/Menus.xml
@@ -112,7 +112,7 @@
-
+
diff --git a/framework/webtools/widget/ServiceScreens.xml
b/framework/webtools/widget/ServiceScreens.xml
index 38f7266..d03c1ab 100644
--- a/framework/webtools/widget/ServiceScreens.xml
+++ b/framework/webtools/widget/ServiceScreens.xml
@@ -263,6 +263,8 @@
+
+
{code}
The second parameter is not available in opening modal.
> Multiple menu item link parameters get lost if link type is layered-modal
> -
>
> Key: OFBIZ-11743
> URL: https://issues.apache.org/jira/browse/OFBIZ-11743
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Release Branch 18.12, 17.12.03, Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Labels: Modal, link, menu, menu-item
> Attachments: Capture d’écran de 2020-05-29 17-11-58.png
>
>
> I got problems by opening a modal via menu link with two parameters. Only the
> first parameter is successfully accessible in modal's screens definition.
> Investigation revealed that for a menu link of type 'layered-modal' inline
> JS-Code get created with defined action-String. This String is used to set
> following context parameters.
> The problem is, that parameter concatenating expression '&' is not encoded
> like
> {code:java}
> // .../control/uri?param1=1param2=2
> {code}
>
> My solution for this problem was to extend MacroMenuRenderer#renderLink by
> replacing
> {code:java}
> {code}
> by '&'.
> Furthermore, this method shows that submitted parameters, defined between
> menus link tags, will be ignored, if link type is 'layered-modal'. So, within
> action-String, we have to submit parameters.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Issue Comment Deleted] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal
[
https://issues.apache.org/jira/browse/OFBIZ-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ulrich Heidfeld updated OFBIZ-11743:
Comment: was deleted
(was: Hi [~nmalin],
i have created a [GitHub pull
request|https://github.com/apache/ofbiz-framework/pull/163].)
> Multiple menu item link parameters get lost if link type is layered-modal
> -
>
> Key: OFBIZ-11743
> URL: https://issues.apache.org/jira/browse/OFBIZ-11743
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Release Branch 18.12, 17.12.03, Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Labels: Modal, link, menu, menu-item
>
> I got problems by opening a modal via menu link with two parameters. Only the
> first parameter is successfully accessible in modal's screens definition.
> Investigation revealed that for a menu link of type 'layered-modal' inline
> JS-Code get created with defined action-String. This String is used to set
> following context parameters.
> The problem is, that parameter concatenating expression '&' is not encoded
> like
> {code:java}
> // .../control/uri?param1=1param2=2
> {code}
>
> My solution for this problem was to extend MacroMenuRenderer#renderLink by
> replacing
> {code:java}
> {code}
> by '&'.
> Furthermore, this method shows that submitted parameters, defined between
> menus link tags, will be ignored, if link type is 'layered-modal'. So, within
> action-String, we have to submit parameters.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal
[
https://issues.apache.org/jira/browse/OFBIZ-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116716#comment-17116716
]
Ulrich Heidfeld commented on OFBIZ-11743:
-
Hi [~nmalin],
i have created a [GitHub pull
request|https://github.com/apache/ofbiz-framework/pull/163].
> Multiple menu item link parameters get lost if link type is layered-modal
> -
>
> Key: OFBIZ-11743
> URL: https://issues.apache.org/jira/browse/OFBIZ-11743
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Release Branch 18.12, 17.12.03, Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Labels: Modal, link, menu, menu-item
>
> I got problems by opening a modal via menu link with two parameters. Only the
> first parameter is successfully accessible in modal's screens definition.
> Investigation revealed that for a menu link of type 'layered-modal' inline
> JS-Code get created with defined action-String. This String is used to set
> following context parameters.
> The problem is, that parameter concatenating expression '&' is not encoded
> like
> {code:java}
> // .../control/uri?param1=1param2=2
> {code}
>
> My solution for this problem was to extend MacroMenuRenderer#renderLink by
> replacing
> {code:java}
> {code}
> by '&'.
> Furthermore, this method shows that submitted parameters, defined between
> menus link tags, will be ignored, if link type is 'layered-modal'. So, within
> action-String, we have to submit parameters.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal
[
https://issues.apache.org/jira/browse/OFBIZ-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ulrich Heidfeld updated OFBIZ-11743:
Affects Version/s: Release Branch 17.12
Release Branch 18.12
> Multiple menu item link parameters get lost if link type is layered-modal
> -
>
> Key: OFBIZ-11743
> URL: https://issues.apache.org/jira/browse/OFBIZ-11743
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Labels: Modal, link, menu, menu-item
>
> I got problems by opening a modal via menu link with two parameters. Only the
> first parameter is successfully accessible in modal's screens definition.
> Investigation revealed that for a menu link of type 'layered-modal' inline
> JS-Code get created with defined action-String. This String is used to set
> following context parameters.
> The problem is, that parameter concatenating expression '&' is not encoded
> like
> {code:java}
> // .../control/uri?param1=1param2=2
> {code}
>
> My solution for this problem was to extend MacroMenuRenderer#renderLink by
> replacing
> {code:java}
> {code}
> by '&'.
> Furthermore, this method shows that submitted parameters, defined between
> menus link tags, will be ignored, if link type is 'layered-modal'. So, within
> action-String, we have to submit parameters.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal
[
https://issues.apache.org/jira/browse/OFBIZ-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116649#comment-17116649
]
Ulrich Heidfeld commented on OFBIZ-11743:
-
Hi [~pierresmits],
this bug appears in 17.12.1, 17.12.3 and 18.12 too. It would be nice, if this
versions also get fixed.
> Multiple menu item link parameters get lost if link type is layered-modal
> -
>
> Key: OFBIZ-11743
> URL: https://issues.apache.org/jira/browse/OFBIZ-11743
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Labels: Modal, link, menu, menu-item
>
> I got problems by opening a modal via menu link with two parameters. Only the
> first parameter is successfully accessible in modal's screens definition.
> Investigation revealed that for a menu link of type 'layered-modal' inline
> JS-Code get created with defined action-String. This String is used to set
> following context parameters.
> The problem is, that parameter concatenating expression '&' is not encoded
> like
> {code:java}
> // .../control/uri?param1=1param2=2
> {code}
>
> My solution for this problem was to extend MacroMenuRenderer#renderLink by
> replacing
> {code:java}
> {code}
> by '&'.
> Furthermore, this method shows that submitted parameters, defined between
> menus link tags, will be ignored, if link type is 'layered-modal'. So, within
> action-String, we have to submit parameters.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal
[
https://issues.apache.org/jira/browse/OFBIZ-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ulrich Heidfeld updated OFBIZ-11743:
Labels: Modal link menu (was: )
> Multiple menu item link parameters get lost if link type is layered-modal
> -
>
> Key: OFBIZ-11743
> URL: https://issues.apache.org/jira/browse/OFBIZ-11743
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Labels: Modal, link, menu
>
> I got problems by opening a modal via menu link with two parameters. Only the
> first parameter is successfully accessible in modal's screens definition.
> Investigation revealed that for a menu link of type 'layered-modal' inline
> JS-Code get created with defined action-String. This String is used to set
> following context parameters.
> The problem is, that parameter concatenating expression '&' is not encoded
> like
> {code:java}
> // .../control/uri?param1=1param2=2
> {code}
>
> My solution for this problem was to extend MacroMenuRenderer#renderLink by
> replacing
> {code:java}
> {code}
> by '&'.
> Furthermore, this method shows that submitted parameters, defined between
> menus link tags, will be ignored, if link type is 'layered-modal'. So, within
> action-String, we have to submit parameters.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal
[
https://issues.apache.org/jira/browse/OFBIZ-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ulrich Heidfeld updated OFBIZ-11743:
Component/s: framework/widget
> Multiple menu item link parameters get lost if link type is layered-modal
> -
>
> Key: OFBIZ-11743
> URL: https://issues.apache.org/jira/browse/OFBIZ-11743
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
>
> I got problems by opening a modal via menu link with two parameters. Only the
> first parameter is successfully accessible in modal's screens definition.
> Investigation revealed that for a menu link of type 'layered-modal' inline
> JS-Code get created with defined action-String. This String is used to set
> following context parameters.
> The problem is, that parameter concatenating expression '&' is not encoded
> like
> {code:java}
> // .../control/uri?param1=1param2=2
> {code}
>
> My solution for this problem was to extend MacroMenuRenderer#renderLink by
> replacing
> {code:java}
> {code}
> by '&'.
> Furthermore, this method shows that submitted parameters, defined between
> menus link tags, will be ignored, if link type is 'layered-modal'. So, within
> action-String, we have to submit parameters.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal
Ulrich Heidfeld created OFBIZ-11743:
---
Summary: Multiple menu item link parameters get lost if link type
is layered-modal
Key: OFBIZ-11743
URL: https://issues.apache.org/jira/browse/OFBIZ-11743
Project: OFBiz
Issue Type: Bug
Affects Versions: Trunk
Reporter: Ulrich Heidfeld
Assignee: Ulrich Heidfeld
I got problems by opening a modal via menu link with two parameters. Only the
first parameter is successfully accessible in modal's screens definition.
Investigation revealed that for a menu link of type 'layered-modal' inline
JS-Code get created with defined action-String. This String is used to set
following context parameters.
The problem is, that parameter concatenating expression '&' is not encoded like
{code:java}
// .../control/uri?param1=1param2=2
{code}
My solution for this problem was to extend MacroMenuRenderer#renderLink by
replacing
{code:java}
{code}
by '&'.
Furthermore, this method shows that submitted parameters, defined between menus
link tags, will be ignored, if link type is 'layered-modal'. So, within
action-String, we have to submit parameters.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (OFBIZ-11475) AjaxAutocompleteOptions should be able to decode return values
Ulrich Heidfeld created OFBIZ-11475: --- Summary: AjaxAutocompleteOptions should be able to decode return values Key: OFBIZ-11475 URL: https://issues.apache.org/jira/browse/OFBIZ-11475 Project: OFBiz Issue Type: Improvement Affects Versions: Trunk Reporter: Ulrich Heidfeld Assignee: Ulrich Heidfeld I got the following problem. I used a lookup to find an userLoginId that is, in our project, in most cases user's email address. By clicking one of porposed entries, the filed userLoginId was filled by an crypted email address like pete.parkerrofbiz.org. I recommend to use StringUtil's wrapString to decode selected option's return value in 'AjaxAutocompleteOptions.ftl'. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10879) updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients from mail subject for general redirected mails
[
https://issues.apache.org/jira/browse/OFBIZ-10879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17025770#comment-17025770
]
Ulrich Heidfeld commented on OFBIZ-10879:
-
Hi [~deepak],
we have explict updated parameters toString, ccString and bccString, because in
our integration testing system with some non-demo data, in value
communicationEvent.toString is not the original sendTo mail address set. If we
have redirectTo active, in communicationEvent.toString will set redirections
mail address. Techicaly, this is correct, but to simulated a productive system,
this is not correct.
> updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients
> from mail subject for general redirected mails
> ---
>
> Key: OFBIZ-10879
> URL: https://issues.apache.org/jira/browse/OFBIZ-10879
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Attachments: OFBIZ-10879.patch, OFBIZ-10879.patch
>
>
> "updateCommEventAfterEmail" method in CommunicationEventServices.java could
> generate wrong result. If general.properties value
> "mail.notifications.redirectTo" is used, it is possible that the subject
> string has more than 255 character.
> Now:
> {code:java}
> Original subject [To: , Cc: , Bcc: ]
> {code}
> Solution:
> {code:java}
> Original subject [RedirectedTo: recipi...@example.com]
> {code}
> In this way we have fixed this in one of our OFBiz forks.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11309) Styles some clickable fields of backend tables as buttons
[ https://issues.apache.org/jira/browse/OFBIZ-11309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16997430#comment-16997430 ] Ulrich Heidfeld commented on OFBIZ-11309: - Hi, i have set widget-style="buttontext" in following tables, if a hyperlink is used in fields: AccountForms.xml#ListAccounts BlogForms.xml#ListBlogs CategoryForms.xml#ListCategory CMSForms.xml#ListFindContent PartyForms.xml#ListParty PartyForms.xml#ListPartyRelationships ProdCatalogForms.xml#ListCatalog ReviewForms.xml#ListReviews ProductForms.xml#ListProducts > Styles some clickable fields of backend tables as buttons > - > > Key: OFBIZ-11309 > URL: https://issues.apache.org/jira/browse/OFBIZ-11309 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Ulrich Heidfeld >Assignee: Ulrich Heidfeld >Priority: Minor > Attachments: > OFBIZ-11309_Styles_some_clickable_fields_of_backend_tables_as_buttons.patch > > > In some tables of OFBiz backend are clickable fields that are not styled as > buttons. To improve UI, i would reccommend to style them as buttons. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11309) Styles some clickable fields of backend tables as buttons
Ulrich Heidfeld created OFBIZ-11309: --- Summary: Styles some clickable fields of backend tables as buttons Key: OFBIZ-11309 URL: https://issues.apache.org/jira/browse/OFBIZ-11309 Project: OFBiz Issue Type: Improvement Affects Versions: Trunk Reporter: Ulrich Heidfeld Assignee: Ulrich Heidfeld In some tables of OFBiz backend are clickable fields that are not styled as buttons. To improve UI, i would reccommend to style them as buttons. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11286) Usage of 'include-form' instead of 'include-grid' in PartyScreens.xml for grid elements
[ https://issues.apache.org/jira/browse/OFBIZ-11286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ulrich Heidfeld updated OFBIZ-11286: Attachment: OFBIZ-11286_usage_of_include-form_instead_of_include-grid_in_PartyScreens_for_grid_elements.patch > Usage of 'include-form' instead of 'include-grid' in PartyScreens.xml for > grid elements > --- > > Key: OFBIZ-11286 > URL: https://issues.apache.org/jira/browse/OFBIZ-11286 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Ulrich Heidfeld >Assignee: Ulrich Heidfeld >Priority: Minor > Attachments: > OFBIZ-11286_usage_of_include-form_instead_of_include-grid_in_PartyScreens_for_grid_elements.patch > > > In PartyScreens.xml there were 'ListInvoicesApplPayments', > 'ListUnAppliedInvoices' and 'ListUnAppliedPayments' include as form instead > of grid but in PartyForms.xml they are defined as grids. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11286) Usage of 'include-form' instead of 'include-grid' in PartyScreens.xml for grid elements
Ulrich Heidfeld created OFBIZ-11286: --- Summary: Usage of 'include-form' instead of 'include-grid' in PartyScreens.xml for grid elements Key: OFBIZ-11286 URL: https://issues.apache.org/jira/browse/OFBIZ-11286 Project: OFBiz Issue Type: Improvement Affects Versions: Trunk Reporter: Ulrich Heidfeld Assignee: Ulrich Heidfeld In PartyScreens.xml there were 'ListInvoicesApplPayments', 'ListUnAppliedInvoices' and 'ListUnAppliedPayments' include as form instead of grid but in PartyForms.xml they are defined as grids. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11281) Possible Nullpointer in StringUtil#strToMap
[
https://issues.apache.org/jira/browse/OFBIZ-11281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974979#comment-16974979
]
Ulrich Heidfeld commented on OFBIZ-11281:
-
Hello [~mthl],
thanks for your teaching words.
In our project, we are using something like:
StringUtil.strToMap(UtilProperties.getPropertyValue(...))
If there is no according property value, an empty string will be returned.
I would prefer null instead of Collections.emptyMap as return value because we
don't need to initiate a map if it has no informations in it. In addition, if a
date time isn't set in properties, an empty value could be take as wrong date.
> Possible Nullpointer in StringUtil#strToMap
> ---
>
> Key: OFBIZ-11281
> URL: https://issues.apache.org/jira/browse/OFBIZ-11281
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Nicolas Malin
>Priority: Critical
> Fix For: 17.12.01, Upcoming Branch, 18.12.01
>
> Attachments:
> OFBIZ-11281_Possible_Nullpointer_in_StringUtil#strToMap.patch
>
>
> StringUtil#strToMap(String, String, boolean, String) throws Nullpointer for
> StringUtil.strToMap("", false).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11281) Possible Nullpointer in StringUtil#strToMap
[
https://issues.apache.org/jira/browse/OFBIZ-11281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973484#comment-16973484
]
Ulrich Heidfeld commented on OFBIZ-11281:
-
I have fixed this issue and added a corresponding test case in
StringUtilTests#testStrToMap.
> Possible Nullpointer in StringUtil#strToMap
> ---
>
> Key: OFBIZ-11281
> URL: https://issues.apache.org/jira/browse/OFBIZ-11281
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Critical
> Attachments:
> OFBIZ-11281_Possible_Nullpointer_in_StringUtil#strToMap.patch
>
>
> StringUtil#strToMap(String, String, boolean, String) throws Nullpointer for
> StringUtil.strToMap("", false).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (OFBIZ-11281) Possible Nullpointer in StringUtil#strToMap
Ulrich Heidfeld created OFBIZ-11281:
---
Summary: Possible Nullpointer in StringUtil#strToMap
Key: OFBIZ-11281
URL: https://issues.apache.org/jira/browse/OFBIZ-11281
Project: OFBiz
Issue Type: Bug
Affects Versions: Trunk
Reporter: Ulrich Heidfeld
Assignee: Ulrich Heidfeld
StringUtil#strToMap(String, String, boolean, String) throws Nullpointer for
StringUtil.strToMap("", false).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11209) Serbian CommonEntityLabels for geo entity
[ https://issues.apache.org/jira/browse/OFBIZ-11209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ulrich Heidfeld updated OFBIZ-11209: Attachment: OFBIZ-11209_Serbian_CommonEntityLabels_for_geo_entity.patch > Serbian CommonEntityLabels for geo entity > - > > Key: OFBIZ-11209 > URL: https://issues.apache.org/jira/browse/OFBIZ-11209 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Ulrich Heidfeld >Assignee: Ulrich Heidfeld >Priority: Minor > Fix For: Trunk > > Attachments: > OFBIZ-11209_Serbian_CommonEntityLabels_for_geo_entity.patch > > > There is no entry 'Geo.geoName.SRB' in CommonEntityLabels.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11209) Serbian CommonEntityLabels for geo entity
Ulrich Heidfeld created OFBIZ-11209: --- Summary: Serbian CommonEntityLabels for geo entity Key: OFBIZ-11209 URL: https://issues.apache.org/jira/browse/OFBIZ-11209 Project: OFBiz Issue Type: Improvement Affects Versions: Trunk Reporter: Ulrich Heidfeld Assignee: Ulrich Heidfeld Fix For: Trunk There is no entry 'Geo.geoName.SRB' in CommonEntityLabels.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10322) Add Asciidoc template for plugin creation task
[ https://issues.apache.org/jira/browse/OFBIZ-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16879170#comment-16879170 ] Ulrich Heidfeld commented on OFBIZ-10322: - My new patch adds a few lines in gradle task 'creatPlugin' so files README.adoc and HELP.adoc (stubs) will be added to root folder of new created plugin. > Add Asciidoc template for plugin creation task > -- > > Key: OFBIZ-10322 > URL: https://issues.apache.org/jira/browse/OFBIZ-10322 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Trivial > Attachments: > OFBIZ-10322_Asciidoc_templates_for_plugin_creation_task.patch > > > Create a README.adoc stub and help file stub in the new format under > framework/resources/templates and use in the plugin creation task. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10322) Add Asciidoc template for plugin creation task
[ https://issues.apache.org/jira/browse/OFBIZ-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ulrich Heidfeld updated OFBIZ-10322: Attachment: OFBIZ-10322_Asciidoc_templates_for_plugin_creation_task.patch > Add Asciidoc template for plugin creation task > -- > > Key: OFBIZ-10322 > URL: https://issues.apache.org/jira/browse/OFBIZ-10322 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Trivial > Attachments: > OFBIZ-10322_Asciidoc_templates_for_plugin_creation_task.patch > > > Create a README.adoc stub and help file stub in the new format under > framework/resources/templates and use in the plugin creation task. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10322) Add Asciidoc template for plugin creation task
[ https://issues.apache.org/jira/browse/OFBIZ-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ulrich Heidfeld updated OFBIZ-10322: Attachment: (was: OFBIZ-10322_README_HELP_Stubs.patch) > Add Asciidoc template for plugin creation task > -- > > Key: OFBIZ-10322 > URL: https://issues.apache.org/jira/browse/OFBIZ-10322 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Trivial > Attachments: > OFBIZ-10322_Asciidoc_templates_for_plugin_creation_task.patch > > > Create a README.adoc stub and help file stub in the new format under > framework/resources/templates and use in the plugin creation task. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11134) Adds a few german translation improvements in HumanResUiLabels
[ https://issues.apache.org/jira/browse/OFBIZ-11134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ulrich Heidfeld updated OFBIZ-11134: Attachment: OFBIZ-11134.patch > Adds a few german translation improvements in HumanResUiLabels > -- > > Key: OFBIZ-11134 > URL: https://issues.apache.org/jira/browse/OFBIZ-11134 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Ulrich Heidfeld >Assignee: Ulrich Heidfeld >Priority: Trivial > Attachments: OFBIZ-11134.patch > > > In our project we have some german translation improvements in > HumanResUiLabels. So I'll provide a small patch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-11134) Adds a few german translation improvements in HumanResUiLabels
Ulrich Heidfeld created OFBIZ-11134: --- Summary: Adds a few german translation improvements in HumanResUiLabels Key: OFBIZ-11134 URL: https://issues.apache.org/jira/browse/OFBIZ-11134 Project: OFBiz Issue Type: Improvement Affects Versions: Trunk Reporter: Ulrich Heidfeld Assignee: Ulrich Heidfeld In our project we have some german translation improvements in HumanResUiLabels. So I'll provide a small patch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10958) Service createProductFeature ignores passed productFeatureId
[
https://issues.apache.org/jira/browse/OFBIZ-10958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ulrich Heidfeld updated OFBIZ-10958:
Attachment: OFBIZ-10958_Fix_createProductFeature.patch
> Service createProductFeature ignores passed productFeatureId
>
>
> Key: OFBIZ-10958
> URL: https://issues.apache.org/jira/browse/OFBIZ-10958
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Attachments: OFBIZ-10958_Fix_createProductFeature.patch
>
>
> Service "createProductFeature" ignores passed productFeatureId caused by
> overwritten output parameter. If I do following changes, this problem
> disappears.
> original:
> {code:xml}
> default-entity-name="ProductFeature" auth="true">
> Create a ProductFeature record
>
> optional="false"/>
>
>
>
> {code}
> Fix:
> {code:xml}
> default-entity-name="ProductFeature" auth="true">
> Create a ProductFeature record
>
> optional="true"/>
>
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-10958) Service createProductFeature ignores passed productFeatureId
Ulrich Heidfeld created OFBIZ-10958:
---
Summary: Service createProductFeature ignores passed
productFeatureId
Key: OFBIZ-10958
URL: https://issues.apache.org/jira/browse/OFBIZ-10958
Project: OFBiz
Issue Type: Bug
Affects Versions: Trunk
Reporter: Ulrich Heidfeld
Assignee: Ulrich Heidfeld
Service "createProductFeature" ignores passed productFeatureId caused by
overwritten output parameter. If I do following changes, this problem
disappears.
original:
{code:xml}
Create a ProductFeature record
{code}
Fix:
{code:xml}
Create a ProductFeature record
{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10879) updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients from mail subject for general redirected mails
[
https://issues.apache.org/jira/browse/OFBIZ-10879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806483#comment-16806483
]
Ulrich Heidfeld commented on OFBIZ-10879:
-
Hi, i have updated the affected version
> updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients
> from mail subject for general redirected mails
> ---
>
> Key: OFBIZ-10879
> URL: https://issues.apache.org/jira/browse/OFBIZ-10879
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Attachments: OFBIZ-10879.patch, OFBIZ-10879.patch
>
>
> "updateCommEventAfterEmail" method in CommunicationEventServices.java could
> generate wrong result. If general.properties value
> "mail.notifications.redirectTo" is used, it is possible that the subject
> string has more than 255 character.
> Now:
> {code:java}
> Original subject [To: , Cc: , Bcc: ]
> {code}
> Solution:
> {code:java}
> Original subject [RedirectedTo: recipi...@example.com]
> {code}
> In this way we have fixed this in one of our OFBiz forks.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10879) updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients from mail subject for general redirected mails
[
https://issues.apache.org/jira/browse/OFBIZ-10879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ulrich Heidfeld updated OFBIZ-10879:
Affects Version/s: Trunk
> updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients
> from mail subject for general redirected mails
> ---
>
> Key: OFBIZ-10879
> URL: https://issues.apache.org/jira/browse/OFBIZ-10879
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Attachments: OFBIZ-10879.patch, OFBIZ-10879.patch
>
>
> "updateCommEventAfterEmail" method in CommunicationEventServices.java could
> generate wrong result. If general.properties value
> "mail.notifications.redirectTo" is used, it is possible that the subject
> string has more than 255 character.
> Now:
> {code:java}
> Original subject [To: , Cc: , Bcc: ]
> {code}
> Solution:
> {code:java}
> Original subject [RedirectedTo: recipi...@example.com]
> {code}
> In this way we have fixed this in one of our OFBiz forks.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10879) updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients from mail subject for general redirected mails
[
https://issues.apache.org/jira/browse/OFBIZ-10879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805045#comment-16805045
]
Ulrich Heidfeld commented on OFBIZ-10879:
-
Hi, this patch cuts subject string in three parts (To, Cc, Bcc). Each part will
be respectively put in string (To in toString, Cc in ccString, Bcc in
bccString) to prevent an error.
> updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients
> from mail subject for general redirected mails
> ---
>
> Key: OFBIZ-10879
> URL: https://issues.apache.org/jira/browse/OFBIZ-10879
> Project: OFBiz
> Issue Type: Bug
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Attachments: OFBIZ-10879.patch
>
>
> "updateCommEventAfterEmail" method in CommunicationEventServices.java could
> generate wrong result. If general.properties value
> "mail.notifications.redirectTo" is used, it is possible that the subject
> string has more than 255 character.
> Now:
> {code:java}
> Original subject [To: , Cc: , Bcc: ]
> {code}
> Solution:
> {code:java}
> Original subject [RedirectedTo: recipi...@example.com]
> {code}
> In this way we have fixed this in one of our OFBiz forks.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10879) updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients from mail subject for general redirected mails
[
https://issues.apache.org/jira/browse/OFBIZ-10879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ulrich Heidfeld updated OFBIZ-10879:
Attachment: OFBIZ-10879.patch
> updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients
> from mail subject for general redirected mails
> ---
>
> Key: OFBIZ-10879
> URL: https://issues.apache.org/jira/browse/OFBIZ-10879
> Project: OFBiz
> Issue Type: Bug
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Attachments: OFBIZ-10879.patch
>
>
> "updateCommEventAfterEmail" method in CommunicationEventServices.java could
> generate wrong result. If general.properties value
> "mail.notifications.redirectTo" is used, it is possible that the subject
> string has more than 255 character.
> Now:
> {code:java}
> Original subject [To: , Cc: , Bcc: ]
> {code}
> Solution:
> {code:java}
> Original subject [RedirectedTo: recipi...@example.com]
> {code}
> In this way we have fixed this in one of our OFBiz forks.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-10879) updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients from mail subject for general redirected mails
Ulrich Heidfeld created OFBIZ-10879:
---
Summary: updateCommEventAfterEmail: Restore original
sendTo/sendCc/sendBcc recipients from mail subject for general redirected mails
Key: OFBIZ-10879
URL: https://issues.apache.org/jira/browse/OFBIZ-10879
Project: OFBiz
Issue Type: Bug
Reporter: Ulrich Heidfeld
Assignee: Ulrich Heidfeld
"updateCommEventAfterEmail" method in CommunicationEventServices.java could
generate wrong result. If general.properties value
"mail.notifications.redirectTo" is used, it is possible that the subject string
has more than 255 character.
Now:
{code:java}
Original subject [To: , Cc: , Bcc: ]
{code}
Solution:
{code:java}
Original subject [RedirectedTo: recipi...@example.com]
{code}
In this way we have fixed this in one of our OFBiz forks.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10841) findGlAccountReconciliation(s) providing not associated glAccounts
[ https://issues.apache.org/jira/browse/OFBIZ-10841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777083#comment-16777083 ] Ulrich Heidfeld commented on OFBIZ-10841: - Hi, I changed some code of GlForms.xml#FindGlAccountReconciliation and GlForms.xml#FindGlAccountReconciliations. GlAccount was used to provide possible accounts for reconciliation via drop down menu. Because of that a user was able to select accounts that wasn't associated to users company. GlAccountOrganizationAndClass connects GlAccount and OrganizationGlAccount so we are able to filter accounts from drop down menu. > findGlAccountReconciliation(s) providing not associated glAccounts > -- > > Key: OFBIZ-10841 > URL: https://issues.apache.org/jira/browse/OFBIZ-10841 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Ulrich Heidfeld >Assignee: Ulrich Heidfeld >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10841_GlFroms.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > By using the drop down menu in > [findGlAccountReconciliation|https://demo-stable.ofbiz.apache.org/accounting/control/findGlAccountReconciliation?organizationPartyId=Company] > and > [findGlAccountReconciliations|https://demo-stable.ofbiz.apache.org/accounting/control/findGlAccountReconciliations?organizationPartyId=Company] > you are able to select any account of GlAccounts. So it doesn't matter which > account is associated to the company. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10841) findGlAccountReconciliation(s) providing not associated glAccounts
[ https://issues.apache.org/jira/browse/OFBIZ-10841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ulrich Heidfeld updated OFBIZ-10841: Attachment: OFBIZ-10841_GlFroms.patch > findGlAccountReconciliation(s) providing not associated glAccounts > -- > > Key: OFBIZ-10841 > URL: https://issues.apache.org/jira/browse/OFBIZ-10841 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Ulrich Heidfeld >Assignee: Ulrich Heidfeld >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10841_GlFroms.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > By using the drop down menu in > [findGlAccountReconciliation|https://demo-stable.ofbiz.apache.org/accounting/control/findGlAccountReconciliation?organizationPartyId=Company] > and > [findGlAccountReconciliations|https://demo-stable.ofbiz.apache.org/accounting/control/findGlAccountReconciliations?organizationPartyId=Company] > you are able to select any account of GlAccounts. So it doesn't matter which > account is associated to the company. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10841) findGlAccountReconciliation(s) providing not associated glAccounts
Ulrich Heidfeld created OFBIZ-10841: --- Summary: findGlAccountReconciliation(s) providing not associated glAccounts Key: OFBIZ-10841 URL: https://issues.apache.org/jira/browse/OFBIZ-10841 Project: OFBiz Issue Type: Improvement Affects Versions: Upcoming Branch Reporter: Ulrich Heidfeld Assignee: Ulrich Heidfeld Fix For: Upcoming Branch By using the drop down menu in [findGlAccountReconciliation|https://demo-stable.ofbiz.apache.org/accounting/control/findGlAccountReconciliation?organizationPartyId=Company] and [findGlAccountReconciliations|https://demo-stable.ofbiz.apache.org/accounting/control/findGlAccountReconciliations?organizationPartyId=Company] you are able to select any account of GlAccounts. So it doesn't matter which account is associated to the company. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10322) Add Asciidoc template for plugin creation task
[ https://issues.apache.org/jira/browse/OFBIZ-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737021#comment-16737021 ] Ulrich Heidfeld commented on OFBIZ-10322: - Hi, I provide a patch which creates stubs for README.txt and HELP.xml in framework/resource/templates folder. > Add Asciidoc template for plugin creation task > -- > > Key: OFBIZ-10322 > URL: https://issues.apache.org/jira/browse/OFBIZ-10322 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Trivial > Attachments: OFBIZ-10322_README_HELP_Stubs.patch > > > Create a README.adoc stub and help file stub in the new format under > framework/resources/templates and use in the plugin creation task. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10322) Add Asciidoc template for plugin creation task
[ https://issues.apache.org/jira/browse/OFBIZ-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ulrich Heidfeld updated OFBIZ-10322: Attachment: OFBIZ-10322_README_HELP_Stubs.patch > Add Asciidoc template for plugin creation task > -- > > Key: OFBIZ-10322 > URL: https://issues.apache.org/jira/browse/OFBIZ-10322 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Trivial > Attachments: OFBIZ-10322_README_HELP_Stubs.patch > > > Create a README.adoc stub and help file stub in the new format under > framework/resources/templates and use in the plugin creation task. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10698) Improve german translations for the hr component
[ https://issues.apache.org/jira/browse/OFBIZ-10698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ulrich Heidfeld updated OFBIZ-10698: Attachment: OFBIZ-10698_HR_translation_de.patch > Improve german translations for the hr component > > > Key: OFBIZ-10698 > URL: https://issues.apache.org/jira/browse/OFBIZ-10698 > Project: OFBiz > Issue Type: Improvement > Components: humanres >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > Attachments: OFBIZ-10698_HR_translation_de.patch > > > During the tests for OFBIZ-10326 I noticed several UI labels which were not > translated. This should be improved. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
