[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-05-02 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user asfgit (triggered by asfgit).

Head commit for run:
ea54ceba47cceaec95b720995c269f2d5827125c / Jacques Le Roux 

Fixed: Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser 
errors (OFBIZ-13061)

Fixes this error found in trunk demo log.
SetTimeZoneFromBrowser.groovy]: (Cannot get property 'userLoginId' on null 
object)
It happens, at least with webpos/control/SetTimeZoneFromBrowser
It's just to prevents cluttering the logs.

Conflicts handled by hand

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8925650122

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-05-01 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user asfgit (triggered by asfgit).

Head commit for run:
9869bed35a9851d5574fd7df395f56c36713e84b / Jacques Le Roux 

Revert "Fixed: Prevents to uselessly clutter the logs up with 
SetTimeZoneFromBrowser errors (OFBIZ-13061)"

This reverts commit 135d137a2483f94fe8e95fcdb39a18f1c0b95963.
This change should not have been backported

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8910078650

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-05-01 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user asfgit (triggered by asfgit).

Head commit for run:
135d137a2483f94fe8e95fcdb39a18f1c0b95963 / Jacques Le Roux 

Fixed: Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser 
errors (OFBIZ-13061)

The previous commits were not enough as I feared. This time we should not see
useless "error" information while running services.

Conflicts hanled by hands

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8909902397

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-05-01 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user asfgit (triggered by asfgit).

Head commit for run:
4fcccdb8208c9130c07bb16d8f3c63d7c2a6d26e / Jacques Le Roux 

Improved: Could not find PortalPage with portalPageId []  (OFBIZ-13071)

No need to try to render a PortalPage when there is no PortalPage

Conflicts handled by hand in ModelScreenWidget.java

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8906782707

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-04-11 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user asfgit (triggered by asfgit).

Head commit for run:
d1eb4773550aee43ca18166791332e6e516a469f / Jacques Le Roux 

Fixed: Reject wrong URLs (OFBIZ-13006)

Some URLs need to be rejected before they create problems

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8647176586

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-04-11 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user asfgit (triggered by asfgit).

Head commit for run:
b3b87d98ddb1997965f23e2c8356243dbf81dec3 / Jacques Le Roux 

Fixed: Reject wrong URLs (OFBIZ-13006)

Some URLs need to be rejected before they create problems

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8647113368

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-04-05 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user gilPts (triggered by gilPts).

Head commit for run:
687bb364d60307a17f8ec8af27c856ebb4037bf7 / Gil Portenseigne 

Fixed: Partymgr Groovy tests (OFBIZ-12998)

Fix error that make test unable to be loaded.

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8570022455

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-04-05 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user gtchaboussie (triggered by JacquesLeRoux).

Head commit for run:
418161cce7edf20ae47361e5012a0a636e5f9765 / cgaetan 

WIP tomcat 10 migration

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8556655225

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-03-28 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user nmalin (triggered by nmalin).

Head commit for run:
55d33436d87950c7623536b70d297ca770ff5bc9 / Nicolas Malin 

Improved: Convert WorkEffortServices.xml mini-lang to groovyDSL (OFBIZ-12968)

Convert the following services :
   * assignPartyToWorkEffort
   * updatePartyToWorkEffortAssignment
   * deletePartyToWorkEffortAssignment -> deprecated suggest to use 
expireWorkEffortPartyAssignment
   * quickAssignPartyToWorkEffort
   * quickAssignPartyToWorkEffortRole
   * duplicateWorkEffort
   * createWorkEffortContactMech
   * updateWorkEffortContactMech
   * createWorkEffortPostalAddress
   * updateWorkEffortPostalAddress
   * createWorkEffortTelecomNumber
   * updateWorkEffortTelecomNumber
   * createWorkEffortEmailAddress
   * updateWorkEffortEmailAddress

For all WorkEffortContactMech service like, use only two generic functions.

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8465122934

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-03-26 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user nmalin (triggered by nmalin).

Head commit for run:
2c370a6c356776f0098ab815185978ef44433d58 / Nicolas Malin 

Improved: Convert WorkEffortServices.xml mini-lang to groovyDSL (OFBIZ-12965)

Convert the following service :
   * createWorkEffort
   * updateWorkEffort
   * deleteWorkEffort
   * copyWorkEffort
   * createWorkEffortAndPartyAssign

createWorkEffort contains too functionnal logic on the base code so split it on 
different services and introduce :
   * assocAcceptedCustRequestToWorkEffort, run throught seca
   * createWorkEffortStatus

createWorkEffortAndPartyAssign use the entity-auto logic so create services 
createWorkEffortPartyAssignment, updateWorkEffortPartyAssignment and 
expireWorkEffortPartyAssignment to make them more generic

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8441931356

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-03-17 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user PierreSmits (triggered by PierreSmits).

Head commit for run:
7f4ffb21298a9d2132a831550323c437f2d07507 / Pierre Smits 

Improved: CATALOG - Move from hard-code menu location to parameterized 
(OFBIZ-12947)

Move the menu location in the various catalog screens from hard-coded to 
parameterized.

modified:
- CatalogScreens.xml
- CategoryScreens.xml
- CommonScreens.xml
- ConfigScreens.xml
- FeatureScreens.xml
- PriceScreens.xml
- ProductScreens.xml
- PromoScreens.xml
- ReviewScreens.xml
- StoreScreens.xml
- SubscriptionScreens.xml
- ThesaurusScreens.xml

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8318465943

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-03-17 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user JacquesLeRoux (triggered by JacquesLeRoux).

Head commit for run:
1785a60d67380e83502d2278d7d5916813d920f0 / Pierre Smits 

Improved: WorkEffort - Move from hard-code menu location to parameterized 
(OFBIZ-12946) (#731)

Move the menu location in the various workeffort screens from hard-coded to 
parameterized.

modified:
- CalendarScreens.xml
- CommonScreens.xml
- TimesheetScreens.xml
- WorkEffortForms.xml
- WorkEffortScreens.xml

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8317002651

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-03-16 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user PierreSmits (triggered by JacquesLeRoux).

Head commit for run:
10d08bb9b32e33302f36df95ebd915d85af40e16 / Pierre Smits 

Improved: ORDER - Move from hard-code menu location to parameterized 
(OFBIZ-12944)

Move the menu location in the various order screens from hard-coded to 
parameterized.

modified:
- AllocationPlanScreens.xml
- CommonScreens.xml
- CustRequestScreens.xml
- OrderEntryCommonScreens.xml
- OrderViewScreens.xml
- QuoteScreens.xml
- QuoteWorkEffortScreens.xml
- RequirementScreens.xml

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8306279611

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-03-16 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user PierreSmits (triggered by JacquesLeRoux).

Head commit for run:
10d08bb9b32e33302f36df95ebd915d85af40e16 / Pierre Smits 

Improved: ORDER - Move from hard-code menu location to parameterized 
(OFBIZ-12944)

Move the menu location in the various order screens from hard-coded to 
parameterized.

modified:
- AllocationPlanScreens.xml
- CommonScreens.xml
- CustRequestScreens.xml
- OrderEntryCommonScreens.xml
- OrderViewScreens.xml
- QuoteScreens.xml
- QuoteWorkEffortScreens.xml
- RequirementScreens.xml

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8306279611

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-03-16 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user asfgit (triggered by asfgit).

Head commit for run:
b71503e386d531a301428d2c50f9437dda7a94cd / Jacques Le Roux 

Fixed: pullAllPluginsSource.sh deleted local .git directory (OFBIZ-12927)

Last commit did not work either, uses a more traditional way, ie not set -e

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8306615621

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-03-16 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user PierreSmits (triggered by JacquesLeRoux).

Head commit for run:
10d08bb9b32e33302f36df95ebd915d85af40e16 / Pierre Smits 

Improved: ORDER - Move from hard-code menu location to parameterized 
(OFBIZ-12944)

Move the menu location in the various order screens from hard-coded to 
parameterized.

modified:
- AllocationPlanScreens.xml
- CommonScreens.xml
- CustRequestScreens.xml
- OrderEntryCommonScreens.xml
- OrderViewScreens.xml
- QuoteScreens.xml
- QuoteWorkEffortScreens.xml
- RequirementScreens.xml

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8306279611

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-03-16 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user PierreSmits (triggered by JacquesLeRoux).

Head commit for run:
10d08bb9b32e33302f36df95ebd915d85af40e16 / Pierre Smits 

Improved: ORDER - Move from hard-code menu location to parameterized 
(OFBIZ-12944)

Move the menu location in the various order screens from hard-coded to 
parameterized.

modified:
- AllocationPlanScreens.xml
- CommonScreens.xml
- CustRequestScreens.xml
- OrderEntryCommonScreens.xml
- OrderViewScreens.xml
- QuoteScreens.xml
- QuoteWorkEffortScreens.xml
- RequirementScreens.xml

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8306279611

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-03-16 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user PierreSmits (triggered by PierreSmits).

Head commit for run:
10d08bb9b32e33302f36df95ebd915d85af40e16 / Pierre Smits 

Improved: ORDER - Move from hard-code menu location to parameterized 
(OFBIZ-12944)

Move the menu location in the various order screens from hard-coded to 
parameterized.

modified:
- AllocationPlanScreens.xml
- CommonScreens.xml
- CustRequestScreens.xml
- OrderEntryCommonScreens.xml
- OrderViewScreens.xml
- QuoteScreens.xml
- QuoteWorkEffortScreens.xml
- RequirementScreens.xml

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8306279611

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-03-15 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user JacquesLeRoux (triggered by JacquesLeRoux).

Head commit for run:
da53eb706bb60c620a83f5893661b7853b714518 / Pierre Smits 

Improved: Marketing - Move from hard-code menu location to parameterized 
(OFBIZ-12941) (#727)

Move the menu location in the various marketing screens from hardcoded to 
parameterized.

modified:
- CommonScreens.xml
- ContactListScreens.xml
- DataSourceScreens.xml
- MarketingCampaignScreens.xml
- MarketingReportScreens.xml
- SegmentScreen.xml
- TrackingCodeScreens.xml

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8292895753

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-03-15 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user mleila37 (triggered by mleila37).

Head commit for run:
7b24e2baa5010e588d40c5f537788441451df31b / MLeila 
Improved: display Run Service forms with dynamic fields (OFBIZ-12869) (#675)

With this PR the run service forms will display service parameters
fields dynamically (for example a field for a Timestamp parameter will
be displayed as a datetime picker)

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8292748837

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-03-15 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user mleila37 (triggered by mleila37).

Head commit for run:
7b24e2baa5010e588d40c5f537788441451df31b / MLeila 
Improved: display Run Service forms with dynamic fields (OFBIZ-12869) (#675)

With this PR the run service forms will display service parameters
fields dynamically (for example a field for a Timestamp parameter will
be displayed as a datetime picker)

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8292748837

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-03-12 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user asfgit (triggered by asfgit).

Head commit for run:
c3653d51ae88e6a0069bb750d8d36c7fa0e4e1a7 / Jacques Le Roux 

Improved: Make sure no pdf files containing unwanted attachments can be uploaded
(OFBIZ-12926)

Puts in the allowZUGFeRDnotSecure as a "true" security property.
For now it allows to accept PDF files with only 1 XML attachment.

This is a near definitive configuration, still an improvement rather than a fix

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8247009005

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-03-12 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user asfgit (triggered by asfgit).

Head commit for run:
773c2b2455bcf887ae22efcafce2f619955834e0 / Jacques Le Roux 

Fixed: ‎SecuredUpload‎::checkMaxLinesLength put in a regression for PDF files 
(OFBIZ-12936)

As commented at https://s.apache.org/wpkuj, while working on OFBIZ-12926
I realised that checkMaxLinesLength put in a possible regression for PDF files.

As a summary: we can't use checkMaxLinesLength for PDF files because they may
contain several CharSet encodings. Hence no possibility to use
Files::readAllLines that needs a sole CharSet. So we need to bypass this check.

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8246522802

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-02-29 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user asfgit (triggered by asfgit).

Head commit for run:
4783d52a5ed085f84d68ca511d96495d0b9ef0ba / Jacques Le Roux 

Improved: Update build.gradle to the latest dependencies (OFBIZ-12921)

I did the last update with OFBIZ-12658 in June 2022.
IIRW I did not speak about the reason I did not update since.

It's simple. We encounter more and more conflicts when upgrading.
Often it's hard work to resolve these conflicts for a disputable benefit.

After all, it's working why upgrading?
As the famous meme "if it ain’t broke, don’t fix it" says.

So I decided to only upgrade dependencies when security issues make it 
necessary.
Few weeks ago I finally decided to though have a look at the situation.

Clearly it confirms what I thought. If it's not a trivial upgrade that does not
bring much, most of the time it's conflicts.

So I'll now rather upgrade only in case of security necessity.
Of course you are welcome to continue to upgrade as much as possible.
Maybe sometimes issues crossed with previous versions will resolved with newer
libraries, but that must be very rare...if ever...

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8107757631

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-02-28 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user PierreSmits (triggered by PierreSmits).

Head commit for run:
eb0d5cbe33568dc6c7834876496fedcea4f0c8fe / Pierre Smits 

reverting back to the original:

implementation 'com.googlecode.ez-vcard:ez-vcard as build failed with 0.12.1

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8081243685

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-02-25 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user PierreSmits (triggered by PierreSmits).

Head commit for run:
5ac5376daf4a88b26a60d776e87ba773b1641c9f / Pierre Smits 

Improved: entity references wrong package (OFBIZ-12913)

The ShoppingLiistItemAttribute references the wrong package
modified: order-entitymodel.xml
- change package of ShoppingLiistItemAttribute

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8037421841

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-02-25 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user asfgit (triggered by asfgit).

Head commit for run:
ce2d4177dcd8fedc9877e2c561fa3cfad3be4658 / Jacques Le Roux 

Improved: Clean code according to SpotBugs in Eclipse (OFBIZ-12912)

FlexibleServletAccessor::equals
  removes useless "this."
  removes useless check if not String since check on flexibleServletAccessor is
  already done, if not OK simply returns false
ConfigXMLReader
  removes not used viewMap and getViewMap()
CommonWidgetModels::Link
  Fixes a possible NPE
ModelForm::UpdateArea
  Fixes a possible NPE

Adds 3 false positives to spotbugs/exclude.xml

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8037393066

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-02-22 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user asfgit (triggered by asfgit).

Head commit for run:
0e657234cf59da498c5365760096a0c3fec63c95 / Jacques Le Roux 

Improved: Migrate integration tests to unit tests when possible (OFBIZ-11067)

According to Mathieu, this closes the Jira. As he mentioned:

The remaining classes to convert to unit test before closing this ticket are:

FlexibleStringExpanderTests
FlexibleMapAccessorTests

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/8003970804

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-02-17 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user danwatford (triggered by danwatford).

Head commit for run:
60b0f6b1cc379d3ddf4bb8337b367a9a32bdea00 / Daniel Watford 

Implemented: Upgrade GitHub Actions to verions dependent on Node.js v20 
(OFBIZ-12901)

Use newer versions of GitHub Actions in the various workflows to avoid
those that are dependent on Node.js v16, instead preferring versions
that use Node.js v20.

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7942591106

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-02-16 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user asfgit (triggered by asfgit).

Head commit for run:
e200ed30dfb6e7e4a3fe44b5f2be21c0a6e7b185 / Jacques Le Roux 

Improved: Improvement of the Check xml tag (OFBIZ-12821)

Did not spot this useless line, removed.

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7931062952

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-02-16 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user asfgit (triggered by asfgit).

Head commit for run:
3b923ad9231dfa799440ba5507b0abe0246c8c86 / Jacques Le Roux 

Improved: Improvement of the Check xml tag (OFBIZ-12821)

The approach for pre-checking variables is as follows: if a variable with the
same name as the field exists, its value will be used to determine the pre-check
status. There is an example in QuoteForms.xml

Thanks: Maxime Flammang and Nereide team

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7930937433

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-02-16 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user asfgit (triggered by asfgit).

Head commit for run:
362538d18fa456a7d5565410cb1c2c47b35bcaf2 / Florian Motteau 

Fixed: pagination, jump to page with AJAX enabled is broken (OFBIZ-12817 - #637)

Jump to page with AJAX enabled fetches the wrong page.
We need to decrement the value entered by the user by one (page numbers are 
zero-indexed)

Thanks: Néréide Team :)

Conflict handled by hand

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7928259455

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-02-05 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user asfgit (triggered by asfgit).

Head commit for run:
c156ab44141ff166f6620e754ac01df00d5e8a1f / Michael Brohl 
Fixed: Missing package and syntax error in FixedAssetServices.groovy
(OFBIZ-12890)

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7782161538

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-01-04 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user asfgit (triggered by asfgit).

Head commit for run:
6da924da5aaddeaafa02e031160d79afe93bfd34 / Jacques Le Roux 

Fixed: Replace SvnCheckout in Gradle (OFBIZ-12868)

Removes definitely SvnCheckout, pullPluginSource and pullAllPluginsSource tasks
from Gradle (in build.gradle)

Fixes both pullPluginSource scripts, notably uses a shallow clone rather than a
blobless clone as suggested by Eugen, less space, faster

Conflict handled by hand in build.gradle

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7407472787

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-01-03 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user asfgit (triggered by asfgit).

Head commit for run:
fad2ea9e7dcac2221bfba0d1eea99795096a7542 / Jacques Le Roux 

Fixed: Replace SvnCheckout in Gradle (OFBIZ-12868)

Updates the documentation for pullAllPluginsSource.sh and pullPluginSource.sh

Uses
git switch -C "$branch"
instead of
git switch "$branch"
in both scripts

There is something weird with pullPluginSource.sh. It works perfectly on Windows
using git-bash, but in Ubuntu 20.04 it does not add but replaces plugins.
I tested using current last Git version in both OS
(respectively 2.43.0.windows.1 and 2.43.0). It's a minor issue as it does not
block the CI so I'll review that later...

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7397017263

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-01-03 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user asfgit (triggered by asfgit).

Head commit for run:
a37191e4b54916223610b41bdcf84bbae58fc408 / Jacques Le Roux 

Fixed: Replace SvnCheckout in Gradle (OFBIZ-12868)

Updates the documentation for pullAllPluginsSource.sh and pullPluginSource.sh

Uses
git switch -C "$branch"
instead of
git switch "$branch"
in both scripts

There is something weird with pullPluginSource.sh. It works perfectly on Windows
using git-bash, but in Ubuntu 20.04 it does not add but replaces plugins.
I tested using current last Git version in both OS
(respectively 2.43.0.windows.1 and 2.43.0). It's a minor issue as it does not
block the CI so I'll review that later...

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7397017525

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-01-01 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user asfgit (triggered by asfgit).

Head commit for run:
11c207c6a1419710ceb46a3fee83d671cf33aedb / Jacques Le Roux 

Fixed: removes "cache: 'gradle'" which was not there before

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7382553452

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-01-01 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user asfgit (triggered by asfgit).

Head commit for run:
085776316687618ad14eb30f6fab952535317573 / Jacques Le Roux 

Improved: Replace SvnCheckout in Gradle (OFBIZ-12868

Comments out the pullPluginSource and pullAllPluginsSource Gradle tasks and
updates the documentation to use the pullPluginSource and pullAllPluginsSource
OS scripts

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7379739278

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2024-01-01 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user asfgit (triggered by asfgit).

Head commit for run:
0ba2011f26d561e08683cc5cb521dfa68a93fa0c / Jacques Le Roux 

Improved: Replace SvnCheckout in Gradle (OFBIZ-12868

Comments out the pullPluginSource and pullAllPluginsSource Gradle tasks and
updates the documentation to use the pullPluginSource and pullAllPluginsSource
OS scripts

Conflicts handled by hand in README.adoc

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7379739058

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2023-12-08 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user ieugen (triggered by ieugen).

Head commit for run:
0d92afd6431f46620eec6c9749457a2da41be579 / Eugen Stan 
Improvement: Exploratory work to make entity engine as a library (OFBIZ-3500)

* I had to comment some (marked with TODO: migration) because of dependency 
issues
- ScriptHandlerImpl and another.

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7147023930

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2023-12-08 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user ieugen (triggered by ieugen).

Head commit for run:
c308eb9f2d91eee24b1e5a8191d1455723840979 / Eugen Stan 
Improvement: Extract datafile component, base/util and base/crypt (OFBIZ-3500)

* There are a LOT of circular dependencies !!!
* I had to split some files to be able to shuffle code around:
  UtilPropertiesRuntime, etc.
* A lot of code changes are related to CheckStyle
* We should consider spotbugs for code formatting via gradle

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7145637195

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2023-12-05 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user asfgit (triggered by asfgit).

Head commit for run:
565d8a37f75448eca89c345887970f7d51c08f14 / Eugen Stan 
Fixed: Test package name ref for UtilObjectTests (OFBIZ-12726) (#677)

UtilObjectTests was rererenced with a wrong package name.

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7100107017

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2023-12-05 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user JacquesLeRoux (triggered by JacquesLeRoux).

Head commit for run:
afe62e2d7cdcf753bf44e53a3426529bac869fce / Eugen Stan 
Fixed: Test package name ref for UtilObjectTests (OFBIZ-12726) (#677)

UtilObjectTests was rererenced with a wrong package name.

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7099874291

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2023-12-05 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user asfgit (triggered by asfgit).

Head commit for run:
5013c3df661470b4bf2c5e7d0e2f9e40da6c49c2 / Eugen Stan 
Fixed: Time zone display for JDK17+ (OFBIZ-12721) (#676)

Use ZoneId API to get time zone display name

Thanks Ioan Eugen

jleroux: I did not find any timeZone.getDisplayName in in Java and Groovy files 
so I guess it's OK to close.

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7099653866

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2023-12-05 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user JacquesLeRoux (triggered by JacquesLeRoux).

Head commit for run:
ca0433d0e40ed9ac1cb73ad53be4a555ca9a3542 / Eugen Stan 
Fixed: Time zone display for JDK17+ (OFBIZ-12721) (#676)

Use ZoneId API to get time zone display name

Thanks Ioan Eugen

jleroux: I did not find any timeZone.getDisplayName in in Java and Groovy files 
so I guess it's OK to close.

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7099626824

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2023-11-13 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user asfgit (triggered by asfgit).

Head commit for run:
85e8627f36f974747bae4d5a69f752dbaf4cbd17 / Jacques Le Roux 

Fixed: Upgrade Apache Shiro to 1.13.0 to fix CVE-2023-46750 (OFBIZ-12866)

See https://lists.apache.org/thread/ff0rq7rykh6zxb7l4dronowpoxrcqkr8 for details

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/6854123501

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2023-11-13 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user asfgit (triggered by asfgit).

Head commit for run:
854b3225befa62f6cce694dbaab4dd3953fa9906 / Jacques Le Roux 

Fixed: Upgrade Apache Shiro to 1.13.0 to fix CVE-2023-46750 (OFBIZ-12866)

See https://lists.apache.org/thread/ff0rq7rykh6zxb7l4dronowpoxrcqkr8 for details

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/6854123245

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2023-11-13 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user asfgit (triggered by asfgit).

Head commit for run:
bfda8a6770eb0dcc1b6644d8639339fb8e44f40b / Jacques Le Roux 

Fixed: Upgrade Apache Shiro to 1.13.0 to fix CVE-2023-46750 (OFBIZ-12866)

See https://lists.apache.org/thread/ff0rq7rykh6zxb7l4dronowpoxrcqkr8 for details

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/6853954214

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2023-10-11 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user florianMo (triggered by JacquesLeRoux).

Head commit for run:
1c51998542d79aadaedc55f29e8a9f59225a938d / Florian Motteau 

Improved: Support HTML textarea placeholder attribute

OF-12859

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/6480278970

With regards,
GitHub Actions via GitBox