[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user wpaetzold (triggered by wpaetzold). Head commit for run: 88eaa5fc88cd75ce26a094aaef0544bb5173f5a9 / Wiebke Pätzold Fixed: Fixes a reference for GetLocaleList.groovy (OFBIZ-12813) Report URL: https://github.com/apache/ofbiz-framework/actions/runs/5486762711 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user MaximeFlame (triggered by JacquesLeRoux). Head commit for run: 598e343475195c9c46024665aef74c6dce05b0dd / MaximeFlame Patch ? Report URL: https://github.com/apache/ofbiz-framework/actions/runs/5054704849 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: 1786d92df3c1ab4d22d4e668307b5a5e1489293d / Jacques Le Roux Fixed: Reducing scope of variables in common and base packages (OFBIZ-10477) (OFBIZ-10480) Following https://lists.apache.org/thread/g1z92gtlf9p1rxlc247yg2zqd6bczq7s conversation, this fixes SAFE util methods being transformed to private when obviously they should be public Thanks: Michael for spotting, reporting and confirming it's OK Report URL: https://github.com/apache/ofbiz-framework/actions/runs/5022318349 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user mbrohl (triggered by mbrohl). Head commit for run: dc1f64b008fb8f07563b1152798cb9549dcf3295 / Michael Brohl Fixed: Eclipse build problems and proper dependency setup (OFBIZ-12808) Due to improper dependency configurations and the JPMS (Java Plattform Module System) which was introduced to Java since version 9, the Eclipse build and running/debugging is not working with JDK 17 (trunk and release22.01). The reason is that there are dependencies to libraries which are also shipped with the JDK which causes a conflict leading to ignore those packages/classes in the build. This commit fixes the problems for trunk without plugins, they have to be modified separately. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/4753311144 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: 450195921698a35c5cba22325af315b510764dfe / Jacques Le Roux Fixed: We have build problems in branches with plugins (OFBIZ-11284) Fixes using Subversion over Github in build.gradle to avoid hard coded branches and rather uses the real current branch While at it, replaces curled double and single quotes by straight ones Report URL: https://github.com/apache/ofbiz-framework/actions/runs/4166196614 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user cshan-ecomify (triggered by cshan-ecomify). Head commit for run: 1088db036b2f8ef2b61dfa3d36ac8d69845d910e / Cheng Hu Shan Implemented: Show used promotion codes (OFBIZ-12756) Added a feature to display how many times a certain promotion code has been used. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/4135589042 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: c592382f57f50d0d671e657b24b16e1a9a61d77a / Jacques Le Roux Fixed: Product Image PNG - Black Background (OFBIZ-12750) When uploading a png image to a product via product/content, transparent background becomes black. Uploading the same image via content component or image management works. Thanks: Ingo jleroux: in 22.01 I also made the file the same than in trunk. There were no reasons it should no be (no functional change but for transparent background and Windows usage). This will also make future possible backports easier Report URL: https://github.com/apache/ofbiz-framework/actions/runs/4091444174 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user nmalin (triggered by nmalin). Head commit for run: aaee98002e34b68da214a16d35ffc4372979b18d / Nicolas Malin Fixed: Use non string parameters on a update-area failed when comme from a JWToken (OFBIZ-12749) When define a update-area with some parameters as List or Map the conversion failed due to a bad management of this case when the creation come from a JWToken. The link generate for the callback contains the variable myField with the class name and not serialized List "['myCase']" Report URL: https://github.com/apache/ofbiz-framework/actions/runs/4026312359 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user gilPts (triggered by gilPts). Head commit for run: c80896ea7ec0db2956aa9f6fdda52039589f3ba1 / Gil Portenseigne Revert "Add commented text report type for codenarc" This reverts commit d2396ea601cc8deacbb5c8f351fabdb4b1fcabc9. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/4025837603 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user gilPts (triggered by gilPts). Head commit for run: 7ee3e840600aea5b5545b4ce47a5cdb302a5f6df / Gil Portenseigne CodenarcMigration : remove old test that has never been active since it was bad named. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/3913311099 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user gilPts (triggered by gilPts). Head commit for run: 19d86337dd830a27b55bd902f3d540f09949ea80 / Gil Portenseigne CodenarcMigration : fix old migrated test, that was enabled during migration Report URL: https://github.com/apache/ofbiz-framework/actions/runs/3912720486 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user gilPts (triggered by gilPts). Head commit for run: 7ed609c7a8607a857acdb85255be59549f1ef728 / Gil Portenseigne Fix codenarc UnnecessaryPublicModifier rules : The 'public' modifier is not required on methods or classes. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/3912271940 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user gilPts (triggered by gilPts). Head commit for run: 84113086d2d71ba59ac8eaa4c36e888ff7b81003 / Gil Portenseigne Fix codenarc UnnecessaryPublicModifier rules : The 'public' modifier is not required on methods or classes. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/3912011534 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user gilPts (triggered by gilPts). Head commit for run: 12f2c9e55cb484089bf9da2ea85747e02c079d4d / Gil Portenseigne Fix codenarc UnnecessaryPublicModifier rules : The 'public' modifier is not required on methods or classes. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/3910871234 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user gilPts (triggered by gilPts). Head commit for run: 5db94e1e70bae7be40ba9c3c9c10344129382a55 / Gil Portenseigne Fix codenarc UnnecessaryPublicModifier rules : The 'public' modifier is not required on methods or classes. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/3910825595 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user gilPts (triggered by gilPts). Head commit for run: ba1e2427905ebe4e34923daa10d73670b8dd7a43 / Gil Portenseigne Fix codenarc UnnecessaryPublicModifier rules : The 'public' modifier is not required on methods or classes. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/3904324426 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: 2712a75ec25e8e6452232cc0e1377309ce6f9bba / Jacques Le Roux Improved: Upgrade to gradle 7.6 - support jdk 11 -> 17 (OFBIZ-12400) Eugen made some changes for checkstyle in his PR. I did not apply those because they did not appear with Java 11. Now that I'm using Java 17 I got some checkstyle issues, I guess the same than Eugen fixed. Here they are fixed with some other formatting changes Conflicts handled by hand Report URL: https://github.com/apache/ofbiz-framework/actions/runs/3903566889 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: 30a0ef12f4931067bb8d637bf8daf44dabfaf3dd / Jacques Le Roux Improved: Use JDK 17 in GitHub Action, BuildBot (ie OFBiz CI) and demos (OFBIZ-12729) This is only the GH actions file Report URL: https://github.com/apache/ofbiz-framework/actions/runs/3902695332 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user gilPts (triggered by gilPts). Head commit for run: ad4efa42868ee3521a021ca4625357d69ef7ce10 / Gil Portenseigne Fix codenarc SpaceAfterCatch rules : Check that there is exactly one space (blank) after the catch keyword and before the opening parenthesis. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/3856935587 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user gilPts (triggered by gilPts).
Head commit for run:
a421c61c06323b5a6b8865157cf3001fc6dbbe6a / Gil Portenseigne
Fix codenarc UnusedVariable rules : Checks for variables that are never
referenced. The ignoreVariableNames property (null) specifies one or more
variable names that should be ignored, optionally containing wildcard
characters ('*' or '?').
Report URL: https://github.com/apache/ofbiz-framework/actions/runs/3829990783
With regards,
GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user gilPts (triggered by gilPts). Head commit for run: 3ae4036a17f73599cc78e8ef880e1b7d7ec111e5 / Gil Portenseigne LineLength rule implementation Report URL: https://github.com/apache/ofbiz-framework/actions/runs/3711733778 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: 4044b86460894d6d1dcea6e374c1b18c63054c7b / Jacques Le Roux Improved: Upgrade to gradle 7.6 - support jdk 11 -> 17 (OFBIZ-12400) Upgrades Groovy from 2.5.18 to 3.0.13 (no longer compile issue, UI tests OK) Thanks: Ioan Eugen Stan for testing Report URL: https://github.com/apache/ofbiz-framework/actions/runs/3583764562 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user ieugen (triggered by ieugen). Head commit for run: 1fecd3a5088cc059af6db32cb3bedca40b277fbd / Eugen Stan Improved: Upgrade to asciidoctorj 3.3.2 - Windows build issue (OFBIZ-12400) * Opted out of PDF generation on Windows - does not work Report URL: https://github.com/apache/ofbiz-framework/actions/runs/3573158394 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user gsperi (triggered by gsperi). Head commit for run: a8d2138448e3ec544df20f574fe0da92a016433d / Giulio Speri Fixed: newsletter multiple subscript. w same email address (OFBIZ-9361) It was possible to be subscribed to the newsletter with the same email address multiple time. Added a check for already ACCEPTED requests in order to refuse new incoming subscription with the same email address. For existing PENDING requests instead, has been added the deletion of all the existing records for the same email address, before adding a new one. Thanks Aditya Sharma for your feedback on this. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/3553612200 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: fa900a478c85592ea04d22326dd029e2cf98fc15 / Jacques Le Roux Fixed: Update Apache Shiro to 1.10.1 (OFBIZ-12713) This security release contains 5 fixes since the 1.10.0 release Report URL: https://github.com/apache/ofbiz-framework/actions/runs/3507567322 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user danwatford (triggered by danwatford). Head commit for run: 303a0402145740b038fdb09637c1e65073d05207 / Daniel Watford Improved: MacroFormRenderer refactoring of datefind fields (OFBIZ-12712) Part of the OFBIZ-11456 MacroFormRenderer refactoring effort. Rather than MacroFormRenderer producing and evaulating FTL strings, it now uses RenderableFtlElementsBuilder to create RenderableFtlMacroCall objects for datefind fields which are then passed to an FtlWriter for evaluation. Removed unused parameters from the renderDateFindField FTL macro definition. Set defaults for several parameters, simplifying generation of macro calls. Synchronised the parameter list of rendateDateFindField macros across all output types - i.e. html, xml, text, etc. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/3496041948 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user danwatford (triggered by danwatford). Head commit for run: 6162697438942853264a7130dc9a9bb53f63dd9d / Daniel Watford Improved: Remove redundant code which enabled/disabled encoding of date-time field output (OFBIZ-12126) Rendering code was rebuilding a ModelFormField for a date-time field when time-dropdown was used in order to control whether field values were encoded. Code was removed as it did not have any effect. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/3461187358 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: 21a06477638113435ff2ad6dbcdfb2fbaabb7c1a / Jacques Le Roux Improved: Update build.gradle to the latest dependencies (OFBIZ-10213) Back to complete asciidoc "set", ie 'org.asciidoctor.convert' version '2.4.0' (last change here, below previously committed) 'org.asciidoctor:asciidoctorj-pdf:1.5.3' 'org.jruby:jruby-complete:9.2.19.0' Hopefully there are no other conflicts, I don't see how it could Report URL: https://github.com/apache/ofbiz-framework/actions/runs/3392821664 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user dixitdeepak (triggered by dixitdeepak). Head commit for run: 09dccc9d588dcf4d9379cefbdbdb96409bbb6b27 / Deepak Dixit Improved: Replaced zapodot jackson-databind dependency with jackson-databind Report URL: https://github.com/apache/ofbiz-framework/actions/runs/3359219815 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: a7637037cc6338f8b1ed0eb3d342bb9a64342e37 / Jacques Le Roux Fixed: EntityPerformanceTest.groovy shows error in log (OFBIZ-12706) propNames String Array can be empty of the 1st element can be null. In the case of the calling by EntityPerformanceTest the 1st element is null. Conflict handled by hand Report URL: https://github.com/apache/ofbiz-framework/actions/runs/3272371979 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user danwatford (triggered by danwatford). Head commit for run: ac6b728d831fe668802c5f05b949b4a744eea6a5 / Daniel Watford Improved: MacroFormRenderer refactoring of textarea fields (OFBIZ-12125) Part of the OFBIZ-11456 MacroFormRenderer refactoring effort. Rather than MacroFormRenderer producing and evaulating FTL strings, it now uses RenderableFtlElementsBuilder to create RenderableFtlMacroCall objects which are then passed to an FtlWriter for evaluation. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/3180885206 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user dixitdeepak (triggered by dixitdeepak). Head commit for run: a6aa9d205e729787f6dc77ebebfb047005ceb06b / Deepak Dixit Improved: Updated apache tika library to 2.4.1 (OFBIZ-12572) Included common csv and apache cxf dependency as they were removed from tika 2.4 Report URL: https://github.com/apache/ofbiz-framework/actions/runs/3060475494 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: c005971e4be56ef7928a6f7d0b7f438e4aa64765 / Jacques Le Roux Improved: Extend HTML Sanitizer - style attribute (OFBIZ-12691) This is a no functional changes. It makes things clearer. I initially wanted to rather do that and forgot. The idea is to no change the sanitization done by HtmlSanitizer.Policy(). We just need to be sure that the comparison with unescapeEcmaScriptAndHtml4 works. Maybe later we will figure out that some more HTML entities will need to be added to "" and ""... Report URL: https://github.com/apache/ofbiz-framework/actions/runs/3059581836 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: 71cf2a8b8d9a0beea5960442706320561351f1f6 / Jacques Le Roux Improved: Extend HTML Sanitizer - style attribute (OFBIZ-12691) This is a no functional changes. It makes things clearer. I initially wanted to rather do that and forgot. The idea is to no change the sanitization done by HtmlSanitizer.Policy(). We just need to be sure that the comparison with unescapeEcmaScriptAndHtml4 works. Maybe later we will figure out that some more HTML entities will need to be added to "" and ""... Report URL: https://github.com/apache/ofbiz-framework/actions/runs/3059581722 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: 56c3fa8807fb73b31068c781baeac7a3fa9f1184 / Jacques Le Roux Fixed: Extend HTML Sanitizer - style attribute (OFBIZ-12691) While backporting previous trunk commit (to a0d829f770) a test error showed in 22.01 (not in trunk, the same was just in log). Then if today you try to put a quote (single or double) at https://demo-trunk.ofbiz.apache.org/content/control/WebSiteCms?webSiteId=CmsSite you won't be able to, because of: <> This is due to the use of HtmlSanitizer.Policy() on value in checkStringForHtmlSafe The solution is to put back quotes (single or double) before comparing. While at it, I also modified checkStringForHtmlSafe to return safe HTML entities for ' and " This also adds comments about why we have <> in several places: labels are not available in testClasses Gradle task. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/3043826402 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: eb0419fdfb048e7d42f91d391b76fae480ac0b0c / Jacques Le Roux Fixed: Extend HTML Sanitizer - style attribute (OFBIZ-12691) While backporting previous trunk commit (to a0d829f770) a test error showed in 22.01 (not in trunk, the same was just in log). Then if today you try to put a quote (single or double) at https://demo-trunk.ofbiz.apache.org/content/control/WebSiteCms?webSiteId=CmsSite you won't be able to, because of: <> This is due to the use of HtmlSanitizer.Policy() on value in checkStringForHtmlSafe The solution is to put back quotes (single or double) before comparing. While at it, I also modified checkStringForHtmlSafe to return safe HTML entities for ' and " This also adds comments about why we have <> in several places: labels are not available in testClasses Gradle task. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/3043826247 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user gilPts (triggered by gilPts). Head commit for run: 18ff65274bc9ac7592658e8c85077da040c996eb / Gil Portenseigne LineLength rule implementation Report URL: https://github.com/apache/ofbiz-framework/actions/runs/3023586568 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user gilPts (triggered by gilPts). Head commit for run: f9b633aa2d784258f741f700e71c921758ad424b / Gil Portenseigne LineLength rule implementation Report URL: https://github.com/apache/ofbiz-framework/actions/runs/2890458616 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user gilPts (triggered by gilPts). Head commit for run: 254b16aa05f31e5da2154445b384c27c5e639756 / Gil Portenseigne NoDef rule implementation : remains 5 occurrence in GroovyBaseScript, need to fix that. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/2847447761 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user nmalin (triggered by nmalin). Head commit for run: a130a054750222ae5d4e413b66b009f3dd970444 / Nicolas Malin Improved: Convert SupplierProductServices.xml mini-lang to groovyDSL (OFBIZ-9350) (OFBIZ-12667) Convert the service getSupplierProductFeatures from mini-lang to groovyDSL Thanks to Tom Gibert for the help Report URL: https://github.com/apache/ofbiz-framework/actions/runs/2675393557 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user gilPts (triggered by gilPts). Head commit for run: 340701a06a7fa5af21f0d41f0007caff7c914de1 / Gil Portenseigne Customize SpaceAroundMapEntryColon rule to respect community opinion Map in OFBiz groovy should respect [key: value] syntax Report URL: https://github.com/apache/ofbiz-framework/actions/runs/2659199349 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user nmalin (triggered by nmalin). Head commit for run: f158685cebbd5c11eeb3f0333fd5a8ed132208e3 / Nicolas Malin Improved: Allow DynamicView use in standard performFind services (OFBIZ-12663) Extend standard find services (prepareFind, executeFind and performFind) to use a built dynamicView instead of just an entityName. With this, you can prepare a dedicated dynamicView and call the performFind with on result a database optimisation. Thanks to Leila Mekika for this proposal and patch Report URL: https://github.com/apache/ofbiz-framework/actions/runs/2637094445 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user gilPts (triggered by gilPts). Head commit for run: 156881ee4e9df7dc13cbb0937f2115d52d2783b9 / Gil Portenseigne Add groovy parser script to get infracted rules ordered by number of occurence. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/2606238725 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user nmalin (triggered by nmalin). Head commit for run: 6e2b9bd08894c1eb659ba44112f26743e42e22da / Nicolas Malin Improved: Add missing parameter on xsd for widget-form:on-field-event-update-area (OFBIZ-12586) On the widget-form.xsd definition, the element on-field-event-update-area haven't possibility to define some parameters. But on java code, the on-field-event-update-area is read like on-event-update-area. If you put some parameters on your code, your editor raise a syntax error but OFBiz analyse and execute it well. By the way we can synchronize the on-field-event-update-area xsd on on-event-update-area. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/2597908155 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user nmalin (triggered by nmalin). Head commit for run: 8cccb4b586e120d5e550beeec820e72b73102455 / Nicolas Malin Improved: Convert a display-entity to hyperlink if subhyperlink this empty (OFBIZ-12547) When you define a display-entity you have the possibility to add a sub-hyperlink related to the element displayed. ... This display the party name with a link "view" connected. When you use the name as link without a dedicate sub link, you need to change all the form to resolve the information to display for creating an hyperlink .. We lost the advantage of the display-entity. With this case, we improve display-entity with the following rule : If the display-entity has a subhyperlink and the subhyperlink haven't description, the description of the link is the display-entity description. In the code, if a sub-hyperlink has an empty description, we convert the display entity as a hyperlink Report URL: https://github.com/apache/ofbiz-framework/actions/runs/2597875871 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user nmalin (triggered by nmalin). Head commit for run: 4c0773e53172b8fa45d4a8abab7b19fd684650b6 / Nicolas Malin Improved: Refactoring service resenquence (OFBIZ-12624) The service "resequence" compute for a content all sequenceNum for linked content assoc. The code is very old (before apache) so apply a slim refactor and migrate the service name resequence to resequenceContentAssocChildren. By the way I kept the service definition resequence to move it as deprecated. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/2597800762 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user gilPts (triggered by gilPts). Head commit for run: 2f1d026a849946db48a858f03e54cb7262436aea / Gil Portenseigne Fix codenarc ForStatementBraces rule Use braces for for statements, even for a single statement. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/2597616299 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user gilPts (triggered by gilPts). Head commit for run: 6f05f1b36a86aa3e98d2a049698647ed94ec3f53 / Gil Portenseigne Document all Basic rules while fixing it. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/2597174880 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: 18d0d75f439c07329d3ac6209cdb9b3553635d5e / Jacques Le Roux Improved: Update build.gradle to the latest dependencies (OFBIZ-12658) I noticed that JpegImageParser from Apache Commons Imaging never had a write option. So I commented it out. I tested uploading, it's OK org.apache.axiom.om.impl.builder.StAXOMBuilder has been replaced by org.apache.axiom.om.OMXMLParserWrapper in SOAPEventHandler.java The rest of information is in the main build.gradle I got 2 test errors on Win7. I'll see how it goes on GH and BB. Maybe it's write.lock issues with Lucene or/and Solr indexes Report URL: https://github.com/apache/ofbiz-framework/actions/runs/2569589022 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: 1bbb80c4250ef51695b6862744f07f4f798215c8 / Jacques Le Roux Fixed: [SECURITY] Upgrade Tika to 1.28.4 (OFBIZ-12657) Mentionned at https://tika.apache.org/ Apache Tika 1.28.4 has been released! This release includes security related fixes and dependency upgrades Note: The Apache Tika PMC has set September 30, 2022 as the End Of Life for the Tika 1.x branch. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/2542072041 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user JacquesLeRoux (triggered by JacquesLeRoux). Head commit for run: 4caa0dce1297b4cc0e1a1d8e1a751373169a593b / Pierre Smits Fixed: GlSetupScreens.xml - MainActionMenu not shown (OFBIZ-12559) (#507) The MainActionMenu of the Accounting component is intended to provide the users with CREATE permissions a direct way to create the main objects of the Accounting components (Gl transaction, invoice, payment), instead of - as such a user - have to go through multiple screens to get to the action trigger to create such objects. The MainActionMenu is applied in various decorator screens. It is, however, not applied in the GlSetupScreen.xml file. Modified: GlSetupScreens.xml added pre-body decorator section, including ref to MainActionMenu, to: - screen ListCompanies - screen AddCompany - screen ImportExport Report URL: https://github.com/apache/ofbiz-framework/actions/runs/2270933397 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user JacquesLeRoux (triggered by JacquesLeRoux). Head commit for run: 6244ad93ce88f05390a506fec6109e14fcc5107e / Pierre Smits Fixed: Party Main: duplicate action trigger (Person/Group) (OFBIZ-12560) (#508) When accessing https://localhost:8443/partymgr/control/main the screen shows duplicate action triggers for the creation of a new party of type=PERSON or of type=PARTYGROUP. These action triggers come from the MainActionMenu for the a component, and from the 'CreateNewParty' menu. modified: PartyMenus.xml removed from menu CreateNewParty: - menu-item for the creation of a PartyGroup - menu-item for the creation of a Person as these already exists in the MainActionMenu of the component. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/2270786334 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user nmalin (triggered by nmalin). Head commit for run: 59fdc4081b543455cc9d734c173717b5a14e701a / Nicolas Malin Fixed: RequestMap.event with type service multi doesn't work with dynamic url (OFBIZ-12604) When you define a controller request-map with an event of type 'service-multi', if your uri contains multiple allocation like 'MyWay/MyAction' the class ServiceMultiEventHandler failed to execute with an EventHandlerException * ... ... * The reason comes from the necessary to resolve the attribute global-transaction on event definition, and to do that a call to ConfigXMLReader is realized. But unnecessary because we already have the event element on the context. Use it directly, simplify the code and fix this issue Report URL: https://github.com/apache/ofbiz-framework/actions/runs/2208253100 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user nmalin (triggered by nmalin). Head commit for run: 6f7f03b74206833ca51bc0529636f3288c71e897 / Nicolas Malin Fixed: RequestMap.event with type service multi doesn't work with dynamic url (OFBIZ-12604) When you define a controller request-map with an event of type 'service-multi', if your uri contains multiple allocation like 'MyWay/MyAction' the class ServiceMultiEventHandler failed to execute with an EventHandlerException * ... ... * The reason comes from the necessary to resolve the attribute global-transaction on event definition, and to do that a call to ConfigXMLReader is realized. But unnecessary because we already have the event element on the context. Use it directly, simplify the code and fix this issue Report URL: https://github.com/apache/ofbiz-framework/actions/runs/2208252933 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: b7b2d1fd6fa56305713d75b60a925bc245104a38 / Jacques Le Roux Improved: Prevent possible DOS attack done using Java deserialisation (OFBIZ-12592) The previous commit was twice wrong: 1. System properties in gradle.properties are not defined using -D but using systemProp. 2. Anyway systemProp. is defining system properties only available in JVM where Gradle is running, not the application you run. For that you need to use applicationDefaultJvmArgs in application in the main build.gradle. Here is the system property for jdk.serialFilter Conflicts handled by hand in build.gradle Report URL: https://github.com/apache/ofbiz-framework/actions/runs/2200514622 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: ce84fdb3ca7782ac7130ea973e396c23ee546521 / Jacques Le Roux Improved: GH Actions and Buildbot Builders are not consistent (INFRA-23076) It's now 2 weeks that INFRA-23076 is open, so like 3 weeks that BuildBot is not working for OFBiz at all. So far I did not run the integration tests on GH because * we have it on BuildBot * it's complicated to show the results Hopefully BuildBot will soon run the OFBiz builds again. But it does not hurt to run the integration tests on GH, even w/o the results, because at least it's easier than running them for each commit locally (takes time) and we can run them locally once we know there is a problem demonstrated with GH actions. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/2182733453 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: f616bb1fd2bc57ddae3a11c6ddfc332b05dc8312 / Jacques Le Roux Improved: GH Actions and Buildbot Builders are not consistent (INFRA-23076) It's now 2 weeks that INFRA-23076 is open, so like 3 weeks that BuildBot is not working for OFBiz at all. So far I did not run the integration tests on GH because * we have it on BuildBot * it's complicated to show the results Hopefully BuildBot will soon run the OFBiz builds again. But it does not hurt to run the integration tests on GH, even w/o the results, because at least it's easier than running them for each commit locally (takes time) and we can run them locally once we know there is a problem demonstrated with GH actions. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/2182717289 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: fa9a94ecf8f0a4a7ea16a1a37a4d9b5f4f1b7140 / Jacques Le Roux Improved: GH Actions and Buildbot Builders are not consistent (INFRA-23076) It's now 2 weeks that INFRA-23076 is open, so like 3 weeks that BuildBot is not working for OFBiz at all. So far I did not run the integration tests on GH because * we have it on BuildBot * it's complicated to show the results Hopefully BuildBot will soon run the OFBiz builds again. But it does not hurt to run the integration tests on GH, even w/o the results, because at least it's easier than running them for each commit locally (takes time) and we can run them locally once we know there is a problem demonstrated with GH actions. Report URL: https://github.com/apache/ofbiz-framework/actions/runs/2182686879 With regards, GitHub Actions via GitBox
[GitHub] [ofbiz-framework]: Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: 843b1c7e71aa046dc8205cb1cdf14011ca17aaa8 / Jacques Le Roux Improved: Prevent Freemarker interpolation in fields (OFBIZ-12594) OFBIZ_12587 is a definitive solution to prevent any kind of Freemarker exploits. But it's hard to realise because OFBiz exposes objects, like attributes from the Servlet scopes. So in the meantime preventing Freemarker interpolation in fields is a pragmatic solution. This is an improvement but needs to be backported because it kinda affects security Conflicts handled by hand SeoContextFilter.java ControlFilter.java When I worked with Mathieu I did not measure how it will be hard sometimes to backport later :/ Report URL: https://github.com/apache/ofbiz-framework/actions/runs/2088308287 With regards, GitHub Actions via GitBox
