[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #230: WIP: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)
JacquesLeRoux commented on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-723606142 Hi Aditya, Just noticed that we are no longer using date.format in trunk, ie this line: I'll remove it from the LICENSE file This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #230: WIP: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)
JacquesLeRoux commented on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-695823882 Hi Aditya, I just checked and we are still in the same situation, TIA This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #230: WIP: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)
JacquesLeRoux commented on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-695823882 Hi Aditya, I just checked and we are still in the same situation, TIA This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #230: WIP: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)
JacquesLeRoux commented on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-682383890 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #230: WIP: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)
JacquesLeRoux commented on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-682381137 THanks Suraj, It's ok here, but can't apply locally: C:\projectsASF\Git\ofbiz-framework>git pull Already up to date. C:\projectsASF\Git\ofbiz-framework>git apply 230.patch error: patch failed: framework/common/src/main/java/org/apache/ofbiz/common/JsLanguageFilesMapping.java:31 error: framework/common/src/main/java/org/apache/ofbiz/common/JsLanguageFilesMapping.java: patch does not apply error: patch failed: themes/common-theme/template/JsLanguageFilesMapping.ftl:74 error: themes/common-theme/template/JsLanguageFilesMapping.ftl: patch does not apply C:\projectsASF\Git\ofbiz-framework> This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #230: WIP: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)
JacquesLeRoux commented on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-682351106 Hi Suraj, You need to merge trunk HEAD, conflicts here and locally: C:\projectsASF\Git\ofbiz-framework>git apply 230.patch error: patch failed: framework/common/src/main/java/org/apache/ofbiz/common/JsLanguageFilesMapping.java:31 error: framework/common/src/main/java/org/apache/ofbiz/common/JsLanguageFilesMapping.java: patch does not apply error: patch failed: themes/common-theme/template/JsLanguageFilesMapping.ftl:74 error: themes/common-theme/template/JsLanguageFilesMapping.ftl: patch does not apply Else after review sounds good to me TIA This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
