[jira] [Closed] (OFBIZ-11275) bug in depends-on in ofbiz-component.xml

2019-11-25 Thread Mathieu Lirzin (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mathieu Lirzin closed OFBIZ-11275.
--
Resolution: Fixed

Applied with an extra XXX comment to describe why we need a linkedhashmap.

Thanks [~stregouet] for the fix.

> bug in depends-on in ofbiz-component.xml
> 
>
> Key: OFBIZ-11275
> URL: https://issues.apache.org/jira/browse/OFBIZ-11275
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk, 18.12.01
>Reporter: Samuel Trégouët
>Assignee: Mathieu Lirzin
>Priority: Major
> Fix For: Trunk
>
> Attachments: 
> 0001-Implemented-Show-dependency-resolution-algorithm-pro.patch, 
> 0002-Implemented-Add-a-generic-directed-graph-utilitary-c.patch, 
> 0003-Fixed-Remove-dependency-management-from-ComponentCon.patch, 
> 0004-Fixed-graphSpec-should-be-a-LinkedHashMap-to-preserv.patch
>
>
> when using `depends-on` tag in obfiz-component.xml one should expect ofbiz to 
> load component (and in particular container listed in ofbiz-component.xml) in 
> particular order.
> I mean if component `accounting` has this line in its ofbiz-component.xml
> {noformat}
> {noformat}
> ofbiz should load order component first and then accounting. This is not the 
> case. Only classpath is modified according to depends-on declaration (and 
> this is not really a usefull/used feature but we'll see this in another issue 
> ;) )
> So here are patches to fix this issue. First one is only a test (which is 
> skipped to allow ./gradlew test to be ok, so if one need to be convinced one 
> should comment Ignore annotation) to illustrate issue, the two others are 
> actual fixes
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11275) bug in depends-on in ofbiz-component.xml

2019-11-08 Thread Mathieu Lirzin (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mathieu Lirzin closed OFBIZ-11275.
--
Fix Version/s: Trunk
   Resolution: Fixed

Fix in commits 1317703c9a, 7044af8a6f and 3d3533cf5e.

Those commits has not been backported in 18.12 where the bug is present because 
since many things have changed between 18.12 and trunk in 
{{ComponentContainer}}. If someone is motivated by investing some time in the 
backport work. Feel free to reopen the ticket.

> bug in depends-on in ofbiz-component.xml
> 
>
> Key: OFBIZ-11275
> URL: https://issues.apache.org/jira/browse/OFBIZ-11275
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk, 18.12.01
>Reporter: Samuel Trégouët
>Assignee: Mathieu Lirzin
>Priority: Major
> Fix For: Trunk
>
> Attachments: 
> 0001-Implemented-Show-dependency-resolution-algorithm-pro.patch, 
> 0002-Implemented-Add-a-generic-directed-graph-utilitary-c.patch, 
> 0003-Fixed-Remove-dependency-management-from-ComponentCon.patch
>
>
> when using `depends-on` tag in obfiz-component.xml one should expect ofbiz to 
> load component (and in particular container listed in ofbiz-component.xml) in 
> particular order.
> I mean if component `accounting` has this line in its ofbiz-component.xml
> {noformat}
> {noformat}
> ofbiz should load order component first and then accounting. This is not the 
> case. Only classpath is modified according to depends-on declaration (and 
> this is not really a usefull/used feature but we'll see this in another issue 
> ;) )
> So here are patches to fix this issue. First one is only a test (which is 
> skipped to allow ./gradlew test to be ok, so if one need to be convinced one 
> should comment Ignore annotation) to illustrate issue, the two others are 
> actual fixes
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)