[jira] [Comment Edited] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903813#comment-16903813
]
Swapnil M Mane edited comment on OFBIZ-10145 at 8/9/19 11:26 AM:
-
Hi [~jacopoc],
Thanks for the patch.
I followed the steps mentioned above with patch applied, and everything works
well (got no error) for me.
Although I got this 'default JVM option' in my gradlew file
{code:java}
DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'
{code}
But it don't create any issue.
I am using Gradle 5.5.1 and Mac OS X 10.14.3.
Thanks!
was (Author: swapnilmmane):
Hi [~jacopoc],
Thanks for the patch.
I followed the steps mentioned above with patch applied, and everything works
well (got no error) for me.
Although I got this 'default JVM option' in my gradlew file
{code:java}
DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'
{code}
But it don't create any issue.
I am using Gradle 5.5.1 and Mac OS X 10.14.3.
Thanks!
> Remove the Gradle wrapper from our release packages and add a step to our
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch,
> OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch,
> gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch,
> init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-with-backup-and-checksum.sh, init-gradle-wrapper.bat,
> init-gradle-wrapper.ps1, init-gradle-wrapper.ps1, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch,
> init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch,
> init-gradlew-readme.patch, release-16.11-without-gradlew.patch,
> release-16.11-without-gradlew.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to
> remove the gradle-wrapper.jar file from the next packaged releases and use
> [~jacopoc]'s related proposition to document how to have Gradle working in
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the
> gradle-wrapper.jar. This might change in the future (versions, etc.), so
> indeed maybe simply asking to download is enough, cf
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Comment Edited] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903813#comment-16903813
]
Swapnil M Mane edited comment on OFBIZ-10145 at 8/9/19 11:26 AM:
-
Hi [~jacopoc],
Thanks for the patch.
I followed the steps mentioned above with patch applied, and everything works
well (got no error) for me.
Although I got this 'default JVM option' in my gradlew file
{code:java}
DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'
{code}
But it don't create any issue.
I am using Gradle 5.5.1 and Mac OS X 10.14.3.
Thanks!
was (Author: swapnilmmane):
Hi [~jacopoc],
Thanks for the patch.
I followed the steps mentioned above with patch applied, and everything works
well (got no error) for me.
Thanks!
> Remove the Gradle wrapper from our release packages and add a step to our
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch,
> OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch,
> gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch,
> init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-with-backup-and-checksum.sh, init-gradle-wrapper.bat,
> init-gradle-wrapper.ps1, init-gradle-wrapper.ps1, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch,
> init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch,
> init-gradlew-readme.patch, release-16.11-without-gradlew.patch,
> release-16.11-without-gradlew.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to
> remove the gradle-wrapper.jar file from the next packaged releases and use
> [~jacopoc]'s related proposition to document how to have Gradle working in
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the
> gradle-wrapper.jar. This might change in the future (versions, etc.), so
> indeed maybe simply asking to download is enough, cf
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Comment Edited] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903150#comment-16903150
]
Nicolas Malin edited comment on OFBIZ-10145 at 8/8/19 5:10 PM:
---
I tried to load new gradle wrapper version in current bintray repository
without success [1] so I continued with open I new account and load needed
version.
This work fine [2] but is under my name (during my test :) )
Now if no opposition, I can open a real account for Apache OFBiz (managed by
PMC) and terminate this task adter loading all wrapper used \o/
[1] https://bintray.com/bintray/jcenter/org.gradle:gradle-wrapper
[2] https://bintray.com/nicolasmalin/GradleWrapper/org.gradle.gradle-wrapper
With this test, I use these variables on script
{code:sh}
GRADLE_WRAPPER_URI="https://github.com/gradle/gradle/raw/v$RELEASE/gradle/wrapper/;
GRADLE_WRAPPER_URI_BACKUP="https://bintray.com/api/ui/download/nicolasmalin/GradleWrapper/v$RELEASE/;
{code}
was (Author: soledad):
I tried to load new gradle wrapper version in current bintray repository
without success [1] so I continued with open I new account and load needed
version.
This work fine [2] but is under my name (during my test :) )
Now if no opposition, I can open a real account for Apache OFBiz (managed by
PMC) and terminate this task adter loading all wrapper used \o/
[1] https://bintray.com/bintray/jcenter/org.gradle:gradle-wrapper
[2] https://bintray.com/nicolasmalin/GradleWrapper/org.gradle.gradle-wrapper
> Remove the Gradle wrapper from our release packages and add a step to our
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch,
> OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch,
> gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch,
> init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-with-backup-and-checksum.sh, init-gradle-wrapper.bat,
> init-gradle-wrapper.ps1, init-gradle-wrapper.ps1, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch,
> init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch,
> init-gradlew-readme.patch, release-16.11-without-gradlew.patch,
> release-16.11-without-gradlew.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to
> remove the gradle-wrapper.jar file from the next packaged releases and use
> [~jacopoc]'s related proposition to document how to have Gradle working in
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the
> gradle-wrapper.jar. This might change in the future (versions, etc.), so
> indeed maybe simply asking to download is enough, cf
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Comment Edited] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896189#comment-16896189
]
Jacques Le Roux edited comment on OFBIZ-10145 at 7/30/19 2:42 PM:
--
Hi Jacopo,
[As proposed
Nicolas|https://lists.apache.org/thread.html/54a5fa80f9b0e4186498f76b62a9d6adc9fd23e8a350fa2e1c702f83@%3Cdev.ofbiz.apache.org%3E]:
{quote}I'm in favor to keep an init-gradle-wrapper to help first discovery
without complex preparation and the script maintenance is really easy.
So we can have on documentation advisable part with install gradle from
official source and other part for unfamiliar people with quick start through
init-gradle-wrapper.
{quote}
I suggest we put the last init-gradle-wrapper scripts (both *nix and Windows)
in OFBIz root, to allow and easy UX. Though init-gradle-wrapper.sh should be
simplified as is the init-gradle-wrapper.bat is (simply load the wrapper from
the branch repo) to catch with the README.MD content where I'd use
{quote}[Installing Gradle
manually]([https://docs.gradle.org/current/userguide/installation.html])
Alternatively you might run the init-gradle-wrapper script (either *nix or
Windows).
{quote}
I have updated [^release-16.11-without-gradlew.patch] for that.
was (Author: jacques.le.roux):
Hi Jacopo,
[As proposed
Nicolas|https://lists.apache.org/thread.html/54a5fa80f9b0e4186498f76b62a9d6adc9fd23e8a350fa2e1c702f83@%3Cdev.ofbiz.apache.org%3E]:
{quote}I'm in favor to keep an init-gradle-wrapper to help first discovery
without complex preparation and the script maintenance is really easy.
So we can have on documentation advisable part with install gradle from
official source and other part for unfamiliar people with quick start through
init-gradle-wrapper.
{quote}
I suggest we put the last init-gradle-wrapper scripts (both *nix and Windows)
in OFBIz root, to allow and easy UX. Though I believe init-gradle-wrapper.sh
should be simplified as is the init-gradle-wrapper.bat is to catch with the
README.MD content where I'd use
{quote}[Installing Gradle
manually]([https://docs.gradle.org/current/userguide/installation.html])
Alternatively you might run the init-gradle-wrapper script (either *nix or
Windows).
{quote}
I have updated [^release-16.11-without-gradlew.patch] for that.
> Remove the Gradle wrapper from our release packages and add a step to our
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch,
> OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch,
> gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch,
> init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.bat,
> init-gradle-wrapper.ps1, init-gradle-wrapper.ps1, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch,
> init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch,
> init-gradlew-readme.patch, release-16.11-without-gradlew.patch,
> release-16.11-without-gradlew.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to
> remove the gradle-wrapper.jar file from the next packaged releases and use
> [~jacopoc]'s related proposition to document how to have Gradle working in
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the
> gradle-wrapper.jar. This might change in the future (versions, etc.), so
> indeed maybe simply asking to download is enough, cf
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Comment Edited] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871164#comment-16871164 ] Jacques Le Roux edited comment on OFBIZ-10145 at 6/24/19 12:50 PM: --- [^gradlew.bat.patch] is the last and simplest solution corresponding to my last proposition. It answers to Swapnil's concern about Gradle updates on trunk. I'll wait a community agreement before writing a wiki page explaining what to do when updating Gradle. If we agree I'll also update the [release management page|https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz]. We need to create entries in [https://svn.apache.org/repos/asf/ofbiz/tools/Buildbot/Gradle/Wrapper] for each new release branch, and to update the trunk one when we upgrade Gradle. was (Author: jacques.le.roux): [^gradlew.bat.patch] is the last and simplest solution corresponding to my last proposition. It answers to Swapnil's concern about Gradle updates on trunk. I'll wait a community agreement before writing a wiki page explaining what to do when updating Gradle. If we agree I'll also update the [release management page|https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz]. We need to create entries in https://svn.apache.org/repos/asf/ofbiz/tools/Buildbot/Gradle/Wrapper for each new release branch, and to update the trunk one when we upgrade Gradle. > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, > gradlew.bat.patch, gradlew.bat.patch, gradlew.bat.patch, > init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.ps1, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871164#comment-16871164 ] Jacques Le Roux edited comment on OFBIZ-10145 at 6/24/19 12:49 PM: --- [^gradlew.bat.patch] is the last and simplest solution corresponding to my last proposition. It answers to Swapnil's concern about Gradle updates on trunk. I'll wait a community agreement before writing a wiki page explaining what to do when updating Gradle. If we agree I'll also update the [release management page|https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz]. We need to create entries in https://svn.apache.org/repos/asf/ofbiz/tools/Buildbot/Gradle/Wrapper for each new release branch, and to update the trunk one when we upgrade Gradle. was (Author: jacques.le.roux): [^gradlew.bat.patch] is the last and simplest solution corresponding to my last proposition. It answers to Swapnil's concern about Gradle updates on trunk. I'll wait a community agreement before writing a wiki page explaining what to do when updating Gradle. If we agree I'll also update the [release management page|https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz]. We need to create entries in https://svn.apache.org/repos/asf/ofbiz/tools/Buildbot/Gradle/Wrapper for each new release branch, and to update the trunk one when we upgrade Gradle. > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, > gradlew.bat.patch, gradlew.bat.patch, init-gradle-wrapper-R16.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradlew-readme-R16.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme.patch, init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871164#comment-16871164 ] Jacques Le Roux edited comment on OFBIZ-10145 at 6/24/19 12:42 PM: --- [^gradlew.bat.patch] is the last and simplest solution corresponding to my last proposition. It answers to Swapnil's concern about Gradle updates on trunk. I'll wait a community agreement before writing a wiki page explaining what to do when updating Gradle. If we agree I'll also update the [release management page|https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz]. We need to create entries in https://svn.apache.org/repos/asf/ofbiz/tools/Buildbot/Gradle/Wrapper for each new release branch, and to update the trunk one when we upgrade Gradle. was (Author: jacques.le.roux): [^gradlew.bat.patch] is the last and simplest solution corresponding to my last proposition. It answers to Swapnil's concern about Gradle updates on trunk. I'll wait a community agreement before writing a wiki page explaining what to do when updating Gradle. If we agree I'll also update the [release management page|https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz]. We need to create entries in https://svn.apache.org/repos/asf/ofbiz/tools/Buildbot/Gradle/Wrapper for each new release branch and to update the trunk one. > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, > gradlew.bat.patch, gradlew.bat.patch, init-gradle-wrapper-R16.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradlew-readme-R16.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme.patch, init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871164#comment-16871164 ] Jacques Le Roux edited comment on OFBIZ-10145 at 6/24/19 12:41 PM: --- [^gradlew.bat.patch] is the last and simplest solution corresponding to my last proposition. It answers to Swapnil's concern about Gradle updates on trunk. I'll wait a community agreement before writing a wiki page explaining what to do when updating Gradle. If we agree I'll also update the [release management page|https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz]. We need to create entries in https://svn.apache.org/repos/asf/ofbiz/tools/Buildbot/Gradle/Wrapper for each new release branch and to update the trunk one. was (Author: jacques.le.roux): [^gradlew.bat.patch] is the last and simplest solution corresponding to my last proposition. It answers to Swapnil's concern about Gradle updates on trunk. I'll wait a community agreement before writing a wiki page explaining what to do when updating Gradle. If we agree I'll also update the [release management page|https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz]. We need to create entries in https://svn.apache.org/repos/asf/ofbiz/tools/Buildbot/Gradle/Wrapper for each new release branch. > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, > gradlew.bat.patch, gradlew.bat.patch, init-gradle-wrapper-R16.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradlew-readme-R16.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme.patch, init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869382#comment-16869382 ] Swapnil M Mane edited comment on OFBIZ-10145 at 6/21/19 10:56 AM: -- Thanks so much [~jacques.le.roux] and [~soledad], this work is going in great direction :) I think, we should also have existance check for gradle-wrapper.properties file. Here is the patch [^OFBIZ-10145_wrapper_properties_check.patch] for same, please have a look. Also, I am thinking about the use case, how we will change the gradle-wrapper.jar and gradle-wrapper.properties on user's machine when we upgrade our Gradle version in trunk. E.g. currently we are using Gradle v5.0 on the trunk, in future when we upgrade the Gradle to next version let say v5.4.1. In this case, the gradle-wrapper.jar and gradle-wrapper.properties will be not be updated on user's machine because as per our script it will only check the files with name (gradle-wrapper.jar and gradle-wrapper.properties) should exist in OFBiz_Root/gradle/wrapper directory. And the script will found the old files in OFBiz_Root/gradle/wrapper directory, thus will not download the new jar and properties files. Please let me know if I am missing anything. Thanks! was (Author: swapnilmmane): Thanks so much [~jacques.le.roux] and [~soledad], this work is going in great direction :) I think, we should also have existance check for gradle-wrapper.properties file. Here is the patch [^OFBIZ-10145_wrapper_properties_check.patch] for same, please have a look. Thanks! > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, > OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, > init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.ps1, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868307#comment-16868307 ] Jacques Le Roux edited comment on OFBIZ-10145 at 6/20/19 8:58 AM: -- With [^gradlew.bat.patch] there is now a new way to handle a missing Gradle w/o the user noticing. So for Windows we don't need to change the documentation. I propose to do the same for *nix, et voilà. was (Author: jacques.le.roux): With [^gradlew.bat.patch] there is now a new to handle a missing Gradle w/o the user noticing. So for Windows we don't need to change the documentation. I propose to do the same for *nix, et voilà. > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, gradlew.bat.patch, > init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.ps1, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866330#comment-16866330 ] Nicolas Malin edited comment on OFBIZ-10145 at 6/18/19 7:48 AM: Nice :) I will work today on was (Author: soledad): Nice :) I will work today today on > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, init-gradle-wrapper-R16.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859169#comment-16859169 ] Swapnil M Mane edited comment on OFBIZ-10145 at 6/8/19 10:05 AM: - Thank you [~jacques.le.roux], I like the suggestion of calling init-gradle-wrapper script from both gradlew and gradlew.bat script. In this way, life our users will became easy, no action will be required from their side. And as you nicely mentioned we need to make sure we are handling the 'init-gradle-wrapper' script always while upgrading the gradle. Just I am not sure about recommendation for customizing the Gradle Wrapper file. Let's see what are the thoughts our fellow team members. Thanks! was (Author: swapnilmmane): Thank you [~jacques.le.roux], I like the suggestion of calling init-gradle-wrapper script from both gradlew and gradlew.bat script. In this way, life our users will became easy, no action will be required from their side. And as you nicely mentioned we need to make sure we are handling the 'init-gradle-wrapper' script always while upgrading the gradle. Let's see what are the thoughts our fellow team members. Thanks! > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, init-gradle-wrapper-R16.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858650#comment-16858650
]
Jacques Le Roux edited comment on OFBIZ-10145 at 6/7/19 1:37 PM:
-
Thanks Swapnil,
Yes this is what I thought about, your script looks good to me. Previouysly I
wrote:
bq. I even thought about hacking the gradlew scripts, then we would not need
init-gradle-wrapper at all. But those are generated with Gradle installation
and better keep them as delivered by Gradle.
I thought about it a bit more. We have those 2 scripts in our repo. When we
will update Gradle (using something like {{gradlew wrapper --gradle-version
5.4.1}}) Gradle may change those scripts. So if we put a call to our
init-gradle-wrapper scripts in them they will be removed. But it's then very
easy to put them again notably because we have a copy of the preceding version
in our repo.
So I finally suggest that we call our init-gradle-wrapper scripts from both
gradlew and gradlew.bat script if the Wrapper is not present. Then no need to
ask our users to run the init-gradle-wrapper by hand. Using the starting script
(gradlew or gradlew.bat) would be enough.
I even suggest that we keep the message from init-gradle-wrapper.sh
bq. "Gradle is not found in your system, downloading it to instantiate the
wrapper."
to reassure the users about what's going on. The download can be long before
you can really use OFBiz, I'd even add a message explaining that.
was (Author: jacques.le.roux):
Thanks Swapnil,
Yes this is what I thought about, your script looks good to me. Previouysly I
wrote:
bq. I even thought about hacking the gradlew scripts, then we would not need
init-gradle-wrapper at all. But those are generated with Gradle installation
and better keep them as delivered by Gradle.
I thought about it a bit more. We have those 2 scripts in our repo. When we
will update Gradle (using something like {{gradlew wrapper --gradle-version
5.4.1}}) Gradle may change those scripts. So if we put a call to our
init-gradle-wrapper scripts in them they will be removed. But it's then very
easy to put them again notably because we will have a copy of the preceding
version in our repo.
So I finally suggest that we call our init-gradle-wrapper scripts from both
gradlew and gradlew.bat script if the Wrapper is not present. Then no need to
ask our users to run the init-gradle-wrapper by hand using the starting script
(gradlew or gradlew.bat) would be enough.
I even suggest that we keep the message from init-gradle-wrapper.sh
bq. "Gradle is not found in your system, downloading it to instantiate the
wrapper."
to reassure the users about what's going on. The download can be long before
you can really use OFBiz, I'd even add a message explaining that.
> Remove the Gradle wrapper from our release packages and add a step to our
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch, init-gradle-wrapper-R16.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch,
> init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch,
> init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to
> remove the gradle-wrapper.jar file from the next packaged releases and use
> [~jacopoc]'s related proposition to document how to have Gradle working in
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the
> gradle-wrapper.jar. This might change in the future (versions, etc.), so
> indeed maybe simply asking to download is enough, cf
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851710#comment-16851710 ] Jacques Le Roux edited comment on OFBIZ-10145 at 5/30/19 10:19 AM: --- Thinking about it, I don't remember if we have access to Internet from Buildbot. Also it would be a pity to have to dowload Gradle for EACH build. I created INFRA-18530 for that... was (Author: jacques.le.roux): Thinking about it, I don't remember if we have access to Internet from Buildbot. Also it would be a pity to have to dowload Gradle for EACH build. I creaed INFRA-18530 for that... > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850722#comment-16850722 ] Jacques Le Roux edited comment on OFBIZ-10145 at 5/29/19 10:16 AM: --- OK, I have updated [^init-gradlew-readme.patch] and created [^init-gradlew-readme-R17.1.patch] . For now it's the official way for Windows as long as nobody provides an init-gradle-wrapper.bat (or init-gradle-wrapper.ps1) file I think we are ready, aren't we? was (Author: jacques.le.roux): OK, I have updated [^init-gradlew-readme.patch] and created [^init-gradlew-readme-R17.1.patch] . For now it's the official way for Windows as long as nobody provides a init-gradle-wrapper.bat (or init-gradle-wrapper.ps1) file I think we are ready, aren't we? > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradlew-readme-R17.1.patch, > init-gradlew-readme.patch, init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848625#comment-16848625
]
Swapnil M Mane edited comment on OFBIZ-10145 at 5/27/19 5:41 AM:
-
Thanks [~jacques.le.roux], you are correct for R17 Gradle release should be
3.2.1 (I have done the suggested change in script and uploaded it again)
Hello [~soledad] and team,
I have done the following changes in script, please have a look
For R17 - [^init-gradle-wrapper.sh]
For R18 and trunk - [^init-gradle-wrapper-trunk-and-18.sh]
1.) Since we are putting the script at location $OFBIZ_HOME/gradle, I have
changed the GRADLE_WRAPPER_OFBIZ_PATH from
{code:java}
$OFBIZ_HOME/gradle/wrapper/{code}
to
{code:java}
$OFBIZ_HOME/gradle/{code}
otherwise script was giving the message "Location seems to be incorrect",
even when run from OFBiz root.
2.) Changed the Gradle release to 3.2.1 for R17.
3.) Done some improvements in messages which is to be shown to the user.
Please have a look and let me know your thoughts.
Thanks!
was (Author: swapnilmmane):
Thanks [~jacques.le.roux], you are correct for R17 Gradle release should be
3.2.1 (I have done the suggested change in script and uploaded it again)
Hello [~soledad] and team,
I have done the following changes in script, please have a look
1.) Since we are putting the script at location $OFBIZ_HOME/gradle, I have
changed the GRADLE_WRAPPER_OFBIZ_PATH from
{code:java}
$OFBIZ_HOME/gradle/wrapper/{code}
to
{code:java}
$OFBIZ_HOME/gradle/{code}
otherwise script was giving the message "Location seems to be incorrect",
even when run from OFBiz root.
2.) Changed the Gradle release to 3.2.1 for R17.
3.) Done some improvements in messages which is to be shown to the user.
Please have a look and let me know your thoughts.
Thanks!
> Remove the Gradle wrapper from our release packages and add a step to our
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to
> remove the gradle-wrapper.jar file from the next packaged releases and use
> [~jacopoc]'s related proposition to document how to have Gradle working in
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the
> gradle-wrapper.jar. This might change in the future (versions, etc.), so
> indeed maybe simply asking to download is enough, cf
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847571#comment-16847571 ] Swapnil M Mane edited comment on OFBIZ-10145 at 5/24/19 2:02 PM: - As discussed over the OFBiz Slack chat group, documented the process to initializing gradle wrapper in README.adoc for Linux based OS, please refer [^init-gradlew-readme.patch] file. Added TODO note for MS Windows OS, as time allows [~jacques.le.roux] will help us here, thanks so much Jacques! :) Thanks! was (Author: swapnilmmane): As discussed over the OFBiz Slack chat group, documented the process to initializing gradle wrapper in README.adoc for Linux based OS, please refer init-gradlew-readme.patch file. Added TODO note for MS Windows OS, as time allows [~jacques.le.roux] will help us here, thanks so much Jacques! :) Thanks! > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315362#comment-16315362 ] Michael Brohl edited comment on OFBIZ-10145 at 1/7/18 4:17 PM: --- Let's hope that someone using Windows will provide something similar as a batch file :-) We should do as much as possible to make it easy for users to get started. So we should provide proper documentation for a manual download/install as well as convenience scripts where possible. was (Author: mbrohl): Let's hope that someone using windows will provide something similar as a batch file :-) We should do as much as possible to make it easy for users to get started. So we should provide proper documentation for a manual download/install as well as convenience scripts where possible. > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: Trunk >Reporter: Jacques Le Roux > Fix For: 17.12.01 > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v6.4.14#64029)
