[jira] [Comment Edited] (OFBIZ-11882) rename a few map files
[
https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160690#comment-17160690
]
Jacques Le Roux edited comment on OFBIZ-11882 at 7/19/20, 1:59 PM:
---
I checked minified files with sourceMappingURL: are
bootstrap-4.3.1.min.js
7: //# sourceMappingURL=bootstrap.min.js.map
bootstrap.bundle-4.3.1.min.js
7: //# sourceMappingURL=bootstrap.bundle.min.js.map
jquery.jgrowl-1.4.6.min.js
2: //# sourceMappingURL=jquery.jgrowl.map
jquery.form.min.js
23: //# sourceMappingURL=jquery.form.min.js.map
imagemanagement
sizzle.min.js
3: //# sourceMappingURL=dist/sizzle.min.map
less.min.js
14: ... rn a?"/*# sourceMappingURL="+a+"
*/":""},c.prototype.getExternalSourceMap=function()\{return
this.sourceMap},c.prototype.setExternalSourceMap=function(a ...
bootstrap-4.3.1.min.css
7: /*# sourceMappingURL=bootstrap.min.css.map */
bootstrap-grid.min.css
7: /*# sourceMappingURL=bootstrap-grid.min.css.map */
bootstrap-reboot.min.css
8: /*# sourceMappingURL=bootstrap-reboot.min.css.map */
So only bootstrap CSS minified files have sourceMappingURL, normal? And BTW the
sourceMappingURL are wrong has [^ecommerce-js2.patch] shows
was (Author: jacques.le.roux):
I checked minified files with sourceMappingURL: are
bootstrap-4.3.1.min.js
7: //# sourceMappingURL=bootstrap.min.js.map
bootstrap.bundle-4.3.1.min.js
7: //# sourceMappingURL=bootstrap.bundle.min.js.map
jquery.jgrowl-1.4.6.min.js
2: //# sourceMappingURL=jquery.jgrowl.map
jquery.form.min.js
23: //# sourceMappingURL=jquery.form.min.js.map
imagemanagement
sizzle.min.js
3: //# sourceMappingURL=dist/sizzle.min.map
less.min.js
14: ... rn a?"/*# sourceMappingURL="+a+"
*/":""},c.prototype.getExternalSourceMap=function()\{return
this.sourceMap},c.prototype.setExternalSourceMap=function(a ...
bootstrap-4.3.1.min.css
7: /*# sourceMappingURL=bootstrap.min.css.map */
bootstrap-grid.min.css
7: /*# sourceMappingURL=bootstrap-grid.min.css.map */
bootstrap-reboot.min.css
8: /*# sourceMappingURL=bootstrap-reboot.min.css.map */
So only bootstrap CSS minified files have sourceMappingURL, normal?
> rename a few map files
> --
>
> Key: OFBIZ-11882
> URL: https://issues.apache.org/jira/browse/OFBIZ-11882
> Project: OFBiz
> Issue Type: Improvement
> Components: ecommerce
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Assignee: Jacques Le Roux
>Priority: Trivial
> Attachments: ecommerce-js.patch, ecommerce-js2.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> tells a few files to be renamed, to suppress warnings in the browser console.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11882) rename a few map files
[
https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160690#comment-17160690
]
Jacques Le Roux edited comment on OFBIZ-11882 at 7/19/20, 1:54 PM:
---
I checked minified files with sourceMappingURL: are
bootstrap-4.3.1.min.js
7: //# sourceMappingURL=bootstrap.min.js.map
bootstrap.bundle-4.3.1.min.js
7: //# sourceMappingURL=bootstrap.bundle.min.js.map
jquery.jgrowl-1.4.6.min.js
2: //# sourceMappingURL=jquery.jgrowl.map
jquery.form.min.js
23: //# sourceMappingURL=jquery.form.min.js.map
imagemanagement
sizzle.min.js
3: //# sourceMappingURL=dist/sizzle.min.map
less.min.js
14: ... rn a?"/*# sourceMappingURL="+a+"
*/":""},c.prototype.getExternalSourceMap=function()\{return
this.sourceMap},c.prototype.setExternalSourceMap=function(a ...
bootstrap-4.3.1.min.css
7: /*# sourceMappingURL=bootstrap.min.css.map */
bootstrap-grid.min.css
7: /*# sourceMappingURL=bootstrap-grid.min.css.map */
bootstrap-reboot.min.css
8: /*# sourceMappingURL=bootstrap-reboot.min.css.map */
So only bootstrap CSS minified files have sourceMappingURL, normal?
was (Author: jacques.le.roux):
I checked minified files with sourceMappingURL: are
bootstrap-4.3.1.min.js
7: //# sourceMappingURL=bootstrap.min.js.map
bootstrap.bundle-4.3.1.min.js
7: //# sourceMappingURL=bootstrap.bundle.min.js.map
jquery.jgrowl-1.4.6.min.js
2: //# sourceMappingURL=jquery.jgrowl.map
jquery.form.min.js
23: //# sourceMappingURL=jquery.form.min.js.map
imagemanagement
sizzle.min.js
3: //# sourceMappingURL=dist/sizzle.min.map
less.min.js
14: ... rn a?"/*# sourceMappingURL="+a+"
*/":""},c.prototype.getExternalSourceMap=function()\{return
this.sourceMap},c.prototype.setExternalSourceMap=function(a ...
bootstrap-4.3.1.min.css
7: /*# sourceMappingURL=bootstrap.min.css.map */
bootstrap-grid.min.css
7: /*# sourceMappingURL=bootstrap-grid.min.css.map */
bootstrap-reboot.min.css
8: /*# sourceMappingURL=bootstrap-reboot.min.css.map */
So only bootstrap minified files have sourceMappingURL, normal?
> rename a few map files
> --
>
> Key: OFBIZ-11882
> URL: https://issues.apache.org/jira/browse/OFBIZ-11882
> Project: OFBiz
> Issue Type: Improvement
> Components: ecommerce
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Assignee: Jacques Le Roux
>Priority: Trivial
> Attachments: ecommerce-js.patch, ecommerce-js2.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> tells a few files to be renamed, to suppress warnings in the browser console.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11882) rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160360#comment-17160360 ] Jacques Le Roux edited comment on OFBIZ-11882 at 7/18/20, 7:46 AM: --- Thanks Aditya, This confirms what I supposed initially. It's a CI and ultimately production thing. Users downstream will have to handle their part if they use a CDN or whatnot. [~alexbodn] will you handle that as you suggested above?: bq. there's a much shorter way to fix for the mean time. changing only the map file name in each min file. would you accept that? Could you then provide a patch for all the maps I listed above? TIA :) BTW I have created an alert at [https://cwiki.apache.org/confluence/display/OFBIZ/About+retire.js]. was (Author: jacques.le.roux): Thanks Aditya, This confirms what I supposed initially. It's a CI and ultimately production thing. Users downstream will have to handle their part if they use a CDN or whatnot. [~alexbodn] will you handle that as you suggested above?: bq. there's a much shorter way to fix for the mean time. changing only the map file name in each min file. would you accept that? Could you then provide a patch for all the maps I listed above? TIA :) I guess the effect will be the same than what is suggested by [https://developer.mozilla.org/en-US/docs/Tools/Debugger/How_to/Use_a_source_map], quoting developer.mozilla.org) bq. include a comment in the transformed file, that points to the source map (?) BTW I have created an alert at [https://cwiki.apache.org/confluence/display/OFBIZ/About+retire.js]. We can update it to have only one simple way: * to comment in our map; * or in the the transformed (for us minified) file. > rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch, ecommerce-js2.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11882) rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160360#comment-17160360 ] Jacques Le Roux edited comment on OFBIZ-11882 at 7/18/20, 7:32 AM: --- Thanks Aditya, This confirms what I supposed initially. It's a CI and ultimately production thing. Users downstream will have to handle their part if they use a CDN or whatnot. [~alexbodn] will you handle that as you suggested above?: bq. there's a much shorter way to fix for the mean time. changing only the map file name in each min file. would you accept that? Could you then provide a patch for all the maps I listed above? TIA :) I guess the effect will be the same than what is suggested by [https://developer.mozilla.org/en-US/docs/Tools/Debugger/How_to/Use_a_source_map], quoting developer.mozilla.org) bq. include a comment in the transformed file, that points to the source map (?) BTW I have created an alert at [https://cwiki.apache.org/confluence/display/OFBIZ/About+retire.js]. We can update it to have only one simple way: * to comment in our map; * or in the the transformed (for us minified) file. was (Author: jacques.le.roux): Thanks Aditya, This confirms what I supposed initially. It's a CI and ultimately production thing. Users downstream will have to handle their part if they use a CDN or whatnot. [~alexbodn] will you handle that as you suggested above?: bq. there's a much shorter way to fix for the mean time. changing only the map file name in each min file. would you accept that? Could you then provide a patch for all the maps I listed above? TIA :) I guess the effect will be the same than what is suggested by [https://developer.mozilla.org/en-US/docs/Tools/Debugger/How_to/Use_a_source_map] and (quoting developer.mozilla.org): bq. include a comment in the transformed file, that points to the source map (?) BTW I have created an alert at [https://cwiki.apache.org/confluence/display/OFBIZ/About+retire.js]. We can update it to have only one simple way: * to comment in our map * or in the the transformed (for us minified) file > rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch, ecommerce-js2.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11882) rename a few map files
[
https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159040#comment-17159040
]
Jacques Le Roux edited comment on OFBIZ-11882 at 7/16/20, 9:10 AM:
---
Alex,
You asked me:
{quote}how are the js/css files getting into ofbiz repository?
there may be a flaw somewhere.
{quote}
And I did not give you the righ answer. I was thinking about code when you
asked about the repo.
As you may have seen since, the js/css/map files are modified when we decide to
use retire.js:
[https://cwiki.apache.org/confluence/display/OFBIZ/About+retire.js]
It started with OFBIZ-9269 OFBIZ-9978 is also related, and there have been few
more since:
[https://issues.apache.org/jira/issues/?jql=project%20%3D%20OFBIZ%20AND%20text%20~%20%22retire.js%22]
As you can see, most of the work was done by Aditya (thank you again Aditya!
:)). So we need to know how you did the minification [~adityasharma].
I had a look at the map files we have (same in all supported branches, ie R17,
R18 and trunk, thanks to our security work with retire.s)
{noformat}
plugins\ecommerce\webapp\ecommerce\js\bootstrap\css
bootstrap-4.3.1.css.map
bootstrap-4.3.1.min.css.map
bootstrap-grid.css.map
bootstrap-grid.min.css.map
bootstrap-reboot.css.map
bootstrap-reboot.min.css.map
plugins\ecommerce\webapp\ecommerce\js\bootstrap\js
bootstrap-4.3.1.js.map
bootstrap-4.3.1.min.js.map
bootstrap.bundle-4.3.1.js.map
bootstrap.bundle-4.3.1.min.js.map
themes\common-theme\webapp\common\js\jquery\plugins\validate\lib
jquery.form.min.js.map
themes\common-theme\webapp\common\js\plugins\imagemanagement
sizzle.min.map
{noformat}
BTW, if we have the maps, should we not get rid of the source files?
was (Author: jacques.le.roux):
Alex,
You asked me:
{quote}how are the js/css files getting into ofbiz repository?
there may be a flaw somewhere.
{quote}
And I did not give you the righ answer. I was thinking about code when you
asked about the repo.
As you may have seen since, the js/css/map files are modified when we decide to
use retire.js:
[https://cwiki.apache.org/confluence/display/OFBIZ/About+retire.js]
It started with OFBIZ-9269 OFBIZ-9978 is also related, and there have been few
more since:
[https://issues.apache.org/jira/issues/?jql=project%20%3D%20OFBIZ%20AND%20text%20~%20%22retire.js%22]
As you can see, most of the work was done by Aditya (thank you again Aditya!
:)). So we need to know how you did the minification [~adityasharma].
I had a look at the map files we have
{noformat}
plugins\ecommerce\webapp\ecommerce\js\bootstrap\css
bootstrap-4.3.1.css.map
bootstrap-4.3.1.min.css.map
bootstrap-grid.css.map
bootstrap-grid.min.css.map
bootstrap-reboot.css.map
bootstrap-reboot.min.css.map
plugins\ecommerce\webapp\ecommerce\js\bootstrap\js
bootstrap-4.3.1.js.map
bootstrap-4.3.1.min.js.map
bootstrap.bundle-4.3.1.js.map
bootstrap.bundle-4.3.1.min.js.map
themes\common-theme\webapp\common\js\jquery\plugins\validate\lib
jquery.form.min.js.map
themes\common-theme\webapp\common\js\plugins\imagemanagement
sizzle.min.map
{noformat}
BTW, if we have the maps, should we not get rid of the source files?
> rename a few map files
> --
>
> Key: OFBIZ-11882
> URL: https://issues.apache.org/jira/browse/OFBIZ-11882
> Project: OFBiz
> Issue Type: Improvement
> Components: ecommerce
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Assignee: Jacques Le Roux
>Priority: Trivial
> Attachments: ecommerce-js.patch, ecommerce-js2.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> tells a few files to be renamed, to suppress warnings in the browser console.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11882) rename a few map files
[
https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158071#comment-17158071
]
Jacques Le Roux edited comment on OFBIZ-11882 at 7/15/20, 10:51 AM:
There will be 2 methods, the later should replace the older
# Look for "layoutSettings" in {noformat}*een*.xml{noformat} files
# OFBIZ-11799 is a WIP, nothing done yet, you may participate...
was (Author: jacques.le.roux):
There will be 2 methods, the later should replace the older
# Look for "layoutSettings" in *een*.xml files
# OFBIZ-11799 is a WIP, nothing done yet, you may participate...
> rename a few map files
> --
>
> Key: OFBIZ-11882
> URL: https://issues.apache.org/jira/browse/OFBIZ-11882
> Project: OFBiz
> Issue Type: Improvement
> Components: ecommerce
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Assignee: Jacques Le Roux
>Priority: Trivial
> Attachments: ecommerce-js.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> tells a few files to be renamed, to suppress warnings in the browser console.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11882) rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158010#comment-17158010 ] Jacques Le Roux edited comment on OFBIZ-11882 at 7/15/20, 9:26 AM: --- Hi Alex, We were using yuicompressor. It was conflicting with BIRT reporting tool, see: https://markmail.org/message/7kscgfexnldo2oyw. I don't think this has changed. BIRT is not evolving much nowadays. Here are links to possible BIRT current situation: https://www.eclipse.org/birt/ https://www.eclipse.org/forums/index.php/t/1089223/ was (Author: jacques.le.roux): Hi Alex, We were using yuicompressor. It was conflicting with BIRT reporting tool, see: https://markmail.org/message/7kscgfexnldo2oyw. I don't think this has changed. BIRT is not evolving much nowadays. Here are links to possibler BIRT current situation: https://www.eclipse.org/birt/ https://www.eclipse.org/forums/index.php/t/1089223/ > rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11882) rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157885#comment-17157885 ] Jacques Le Roux edited comment on OFBIZ-11882 at 7/15/20, 5:06 AM: --- Hi Alex, What's the rationale behind that? We intentionally keep the real names for security reason: to easily update when necessary using retire.js was (Author: jacques.le.roux): Hi Alex, What's the rationale for that? We intentionally keep the real names for security reason: to easily update when necessary using retire.js > rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
