[jira] [Comment Edited] (OFBIZ-13035) Fix cross-app menu location issues
[ https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840165#comment-17840165 ] Pierre Smits edited comment on OFBIZ-13035 at 4/23/24 5:22 PM: --- HI [~jleroux] In which application was this happening? Without more information this is hard to address. was (Author: pfm.smits): HI @jacques, In which application was this happening? Without more information this is hard to address. > Fix cross-app menu location issues > -- > > Key: OFBIZ-13035 > URL: https://issues.apache.org/jira/browse/OFBIZ-13035 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Priority: Major > Fix For: Upcoming Branch > > > address cross application menu-location issues. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (OFBIZ-13035) Fix cross-app menu location issues
[ https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838517#comment-17838517 ] Jacques Le Roux edited comment on OFBIZ-13035 at 4/18/24 8:13 AM: -- Hi [~pierresmits], For PRs 774 and 112, would you mind put in place the future implementations before, or does it take much time? was (Author: jacques.le.roux): Hi [~pierresmits], For PRs 774 and 112, would you mind put in place the future implementations before, or does it make much time? > Fix cross-app menu location issues > -- > > Key: OFBIZ-13035 > URL: https://issues.apache.org/jira/browse/OFBIZ-13035 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Priority: Major > Fix For: Upcoming Branch > > > address cross application menu-location issues. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (OFBIZ-13035) Fix cross-app menu location issues
[ https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838517#comment-17838517 ] Jacques Le Roux edited comment on OFBIZ-13035 at 4/18/24 8:13 AM: -- Hi [~pierresmits], For PRs 774 and 112, would you mind put in place the future implementations before, or does it make much time? was (Author: jacques.le.roux): For PRs 774 and 112, would you mind put in place the future implementations before, or does it make much time? > Fix cross-app menu location issues > -- > > Key: OFBIZ-13035 > URL: https://issues.apache.org/jira/browse/OFBIZ-13035 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Priority: Major > Fix For: Upcoming Branch > > > address cross application menu-location issues. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (OFBIZ-13035) Fix cross-app menu location issues
[ https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838520#comment-17838520 ] Jacques Le Roux edited comment on OFBIZ-13035 at 4/18/24 8:12 AM: -- OK, something is wrong with my commit above. It already works with PR773 on trunk demo without this commit. I have several tabs open and this morning I was using localhost when it was trunk demo. Also the commit is not only useless but wrong. I picked the menu from ofbizsetup/Menus.xml. It's not the same than in PartyMenus.xml provided by PR773. I'll revert this commit and try to understand what's wrong with my local instance that has no diff for framework nor plugins, so maybe data, weird. was (Author: jacques.le.roux): OK, something is wrong with my commit above. It already works with PR773 on trunk demo without this commit. I have several tabs open and thought. This morning I was using localhost when it was trunk demo. And the commit is not only useless but wrong. I picked it from ofbizsetup/Menus.xml it's not the same than in PartyMenus.xml provided by PR773. I'll revert this commit and try to understand what's wrong with my local instance that has no diff for framework nor plugins, so maybe data, weird. > Fix cross-app menu location issues > -- > > Key: OFBIZ-13035 > URL: https://issues.apache.org/jira/browse/OFBIZ-13035 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Priority: Major > Fix For: Upcoming Branch > > > address cross application menu-location issues. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (OFBIZ-13035) Fix cross-app menu location issues
[ https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838025#comment-17838025 ] Pierre Smits edited comment on OFBIZ-13035 at 4/17/24 8:53 AM: --- HI [~jleroux] , PRs * [https://github.com/apache/ofbiz-framework/pull/773] (in ofbiz-framework) * [https://github.com/apache/ofbiz-framework/pull/774] (in ofbiz-framework) * [https://github.com/apache/ofbiz-plugins/pull/112] (in ofbiz-puggins) Should fix stuff was (Author: pfm.smits): HI [~jleroux] , PRs * [https://github.com/apache/ofbiz-framework/pull/773] (in ofbiz-framework) * [https://github.com/apache/ofbiz-plugins/pull/112] (in ofbiz-puggins) Should fix stuff > Fix cross-app menu location issues > -- > > Key: OFBIZ-13035 > URL: https://issues.apache.org/jira/browse/OFBIZ-13035 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Upcoming Branch >Reporter: Pierre Smits >Priority: Major > Fix For: Upcoming Branch > > > address cross application menu-location issues. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (OFBIZ-13035) Fix cross-app menu location issues
[ https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837774#comment-17837774 ] Jacques Le Roux edited comment on OFBIZ-13035 at 4/16/24 4:02 PM: -- Yes (#769) works Not sure why https://github.com/apache/ofbiz-framework/commit/9c7c27d839b8d51217779321d5742597f504f43f does not appear here. We already have a such issue that Infra fixed. Ha got it, I saw it before pushing but forgot to fix the comment: (FBIZ-13035) is no (OFBIZ-13035) ;) was (Author: jacques.le.roux): Yes (#769) works Not sure why https://github.com/apache/ofbiz-framework/commit/9c7c27d839b8d51217779321d5742597f504f43f does not appear here. We already have a such issue that Infra fixed. > Fix cross-app menu location issues > -- > > Key: OFBIZ-13035 > URL: https://issues.apache.org/jira/browse/OFBIZ-13035 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Reporter: Pierre Smits >Priority: Major > > address cross application menu-location issues. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (OFBIZ-13035) Fix cross-app menu location issues
[ https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837774#comment-17837774 ] Jacques Le Roux edited comment on OFBIZ-13035 at 4/16/24 4:01 PM: -- Yes (#769) works Not sure why https://github.com/apache/ofbiz-framework/commit/9c7c27d839b8d51217779321d5742597f504f43f does not appear here. We already have a such issue that Infra fixed. was (Author: jacques.le.roux): Yes it's works Not sure why https://github.com/apache/ofbiz-framework/commit/9c7c27d839b8d51217779321d5742597f504f43f does not appear here. We already have a such issue that Infra fixed. > Fix cross-app menu location issues > -- > > Key: OFBIZ-13035 > URL: https://issues.apache.org/jira/browse/OFBIZ-13035 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Reporter: Pierre Smits >Priority: Major > > address cross application menu-location issues. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (OFBIZ-13035) Fix cross-app menu location issues
[ https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837772#comment-17837772 ] Pierre Smits edited comment on OFBIZ-13035 at 4/16/24 3:45 PM: --- Hi [~jleroux] I believe I caught them all. And set the status to patch provided. see PR#111 bq. Seems that this i addressed by https://github.com/apache/ofbiz-framework/pull/769. Indeed. PR#769 (in ofbiz-framework) should have gotten in first was (Author: pfm.smits): Hi [~jleroux] I believe I caught them all. And set the status to patch provided. bq. Seems that this i addressed by https://github.com/apache/ofbiz-framework/pull/769. Indeed. PR#769 (in ofbiz-framework) should have gotten in first > Fix cross-app menu location issues > -- > > Key: OFBIZ-13035 > URL: https://issues.apache.org/jira/browse/OFBIZ-13035 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Reporter: Pierre Smits >Priority: Major > > address cross application menu-location issues. -- This message was sent by Atlassian Jira (v8.20.10#820010)
