[jira] [Comment Edited] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144904#comment-16144904 ] Jacques Le Roux edited comment on OFBIZ-9138 at 8/29/17 8:20 AM: - Ha another one is that you can't select a line in autocomplete list (anyone) see OFBIZ-9657. Both cases works at r1806036 (tested locally where OFBIZ-9645 does not work in trunk HEAD) was (Author: jacques.le.roux): Ha another one is that you can't select a line in autocomplete list (anyone) see OFBIZ-9657. Both cases works at r1806036 (tested locally where OFBIZ-9138 does not work in trunk HEAD) > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > Fix For: Upcoming Release > > Attachments: common-theme-macro.svg, common-theme-screen.svg > > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144904#comment-16144904 ] Jacques Le Roux edited comment on OFBIZ-9138 at 8/29/17 8:19 AM: - Ha another one is that you can't select a line in autocomplete list (anyone) see OFBIZ-9657. Both cases works at r1806036 (tested locally where OFBIZ-9138 does not work in trunk HEAD) was (Author: jacques.le.roux): Ha another one, is that you can't select a line in autocomplete list (anyone). I can't find a Jira for that, but I think one exists. Both cases works at r1806036 > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > Fix For: Upcoming Release > > Attachments: common-theme-macro.svg, common-theme-screen.svg > > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (OFBIZ-9138) Create a common theme
[
https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144868#comment-16144868
]
Nicolas Malin edited comment on OFBIZ-9138 at 8/29/17 7:36 AM:
---
Hello Wei, can you explain me what is this code and what the relation with the
common-theme ?
Because if I check the entity view :
{code}
~/workspace/apache-svn/ofbiz-trunk
nemo$ grep ExampleTypeView * -R
~/workspace/apache-svn/ofbiz-trunk
nemo$ cd ../ofbiz-plugins/
~/workspace/apache-svn/ofbiz-plugins
nemo$ grep ExampleTypeView * -R
~/workspace/apache-svn/ofbiz-plugins
{code}
So I have no idea this the error
was (Author: soledad):
Hello Wai, can you explain me what is this code and what the relation with the
common-theme ?
Because if I check the entity view :
{code}
~/workspace/apache-svn/ofbiz-trunk
nemo$ grep ExampleTypeView * -R
~/workspace/apache-svn/ofbiz-trunk
nemo$ cd ../ofbiz-plugins/
~/workspace/apache-svn/ofbiz-plugins
nemo$ grep ExampleTypeView * -R
~/workspace/apache-svn/ofbiz-plugins
{code}
So I have no idea this the error
> Create a common theme
> -
>
> Key: OFBIZ-9138
> URL: https://issues.apache.org/jira/browse/OFBIZ-9138
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
> Fix For: Upcoming Release
>
> Attachments: common-theme-macro.svg, common-theme-screen.svg
>
>
> A first task to UI Improvement would be create a common that receive the
> existent code.
> The benefice would be have a framework/common who list all screens that
> available for theme surcharge, so without technology information (css/html or
> something like that)
> Different task to do :
> * move all ftl template from framework/common to themes/common
> * move framework/images to themes/common (this directory contains unlogical
> element for theme but will be manage at a second time)
> * move default macro ftl template from framework/widget to themes/common
> After the realization on this task, all current themes call theme/common for
> html rendering instead of framework/common, framework/images and
> framework/widget. Just pave the way for the next
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144870#comment-16144870 ] Jacques Le Roux edited comment on OFBIZ-9138 at 8/29/17 7:35 AM: - BTW I will do a check out of https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk at the revision just before (r1806036) to check for OFBIZ-9645 was (Author: jacques.le.roux): BTW I will do a check out of https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk at the revision just before to check for OFBIZ-9645 > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > Fix For: Upcoming Release > > Attachments: common-theme-macro.svg, common-theme-screen.svg > > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142046#comment-16142046 ] Deepak Dixit edited comment on OFBIZ-9138 at 8/25/17 7:06 PM: -- Fixed COMMON theme id display issue, removed the visualThemeSetId from COMMON theme at r#1806216 was (Author: deepak.dixit): Fixed COMMON theme id display issue, removed the visualThemeSetId from COMMON theme. > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > Attachments: common-theme-macro.svg, common-theme-screen.svg > > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140515#comment-16140515 ] Nicolas Malin edited comment on OFBIZ-9138 at 8/24/17 7:02 PM: --- I commited a first step (engine and documentation) at 1806075 and 1806076 (^^ I selected only one file to commit) on trunk. I will continue to separate my commits to help the code review was (Author: soledad): I commited a first step (engine and documentation) at 1806075 on trunk. I will continue to separate my commits to help the code review > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > Attachments: common-theme-macro.svg, common-theme-screen.svg > > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16105634#comment-16105634 ] Nicolas Malin edited comment on OFBIZ-9138 at 7/28/17 8:44 PM: --- It's now done, the common theme support the common screen redirection to the theme. For the session problem, I force to load the user pref at the looking. The single problem with that, if you change your theme on a webapp, it's currently not change in your others open sessions. In other word, if you have a browser tab in party and an other in product, if you change your theme the tab open with a party session, your product session keep your old preference. To reset it you need to logout from product. At this time I consider this as minor. So we can by theme surcharge : * widget properties * ftl template macro * common screen And I detect no regression. So if you want to play with it, it's the time ! :) source code: https://github.com/nmalin/ofbiz-framework/tree/common-theme compare with trunk: https://github.com/apache/ofbiz-framework/compare/trunk...nmalin:common-theme?expand=1 was (Author: soledad): It's now done, the common theme support the common screen redirection to the theme. For the session problem, I force to load the user pref at the looking. The single problem with that, if you change your theme on a webapp, it's currently not change in your others open sessions. In other word, if you have a browser tab in party and an other in product, if you change your theme the tab open with a party session, your product session keep your old preference. To reset it you need to logout from product. At this time I consider this as minor. So we can by theme surcharge : * widget properties * ftl template macro * common screen And I detect no regression. So if you want to play with it, it's the time ! :) > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732136#comment-15732136 ] Nicolas Malin edited comment on OFBIZ-9138 at 7/28/17 8:43 PM: --- I continue the work with : * with move macro ftl on common-theme * move uneeded properties from widget.properties commonWidget.properties present on common-theme to keep on first properties file only property related to widget model and not widget rendering * review some code on FindAutocompleteOptions.groovy and MacroFormRenderer.java to move rendering property use to FtlMacro or decorator screen POC available on https://github.com/nmalin/ofbiz-framework/tree/common-theme was (Author: soledad): I continue the work with : * with move macro ftl on common-theme * move uneeded properties from widget.properties commonWidget.properties present on common-theme to keep on first properties file only property related to widget model and not widget rendering * review some code on FindAutocompleteOptions.groovy and MacroFormRenderer.java to move rendering property use to FtlMacro or decorator screen POC available on https://github.com/nmalin/ApacheOFBiz/tree/common-theme > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840280#comment-15840280 ] Nicolas Malin edited comment on OFBIZ-9138 at 1/26/17 7:34 PM: --- Hi Deepak sorry for the latency, my concentration move on an other task :) After sharing with Taher, Julien and Gil on the apachecon eu , we oriented own mind to move all rendering system out framework and keep only the model on the framework. But if you have some arguments to defend your idea, I'm yours was (Author: soledad): Hi Deepak sorry for the latency, my concentration move on an other task :) After sharing with Taher, Julien and Gil on the apachecon eu , we oriented own mind to move all rendering system out framework and keep only the model on the framework. But if you have some arguments to defend you idea, I'm yours > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-9138) Create a common theme
[ https://issues.apache.org/jira/browse/OFBIZ-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840280#comment-15840280 ] Nicolas Malin edited comment on OFBIZ-9138 at 1/26/17 7:32 PM: --- Hi Deepak sorry for the latency, my concentration move on an other task :) After sharing with Taher, Julien and Gil on the apachecon eu , we oriented own mind to move all rendering system out framework and keep only the model on the framework. But if you have some arguments to defend you idea, I'm yours was (Author: soledad): Hi Deepak sorry for the latency, my concentration move on an other task :) After sharing with Taher, Julien and Gil on the apachecon eu , we prefer to move all rendering system out framework and keep only the model on the framework. But if you have some arguments to defend you idea, I'm yours > Create a common theme > - > > Key: OFBIZ-9138 > URL: https://issues.apache.org/jira/browse/OFBIZ-9138 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Reporter: Nicolas Malin >Assignee: Nicolas Malin > > A first task to UI Improvement would be create a common that receive the > existent code. > The benefice would be have a framework/common who list all screens that > available for theme surcharge, so without technology information (css/html or > something like that) > Different task to do : > * move all ftl template from framework/common to themes/common > * move framework/images to themes/common (this directory contains unlogical > element for theme but will be manage at a second time) > * move default macro ftl template from framework/widget to themes/common > After the realization on this task, all current themes call theme/common for > html rendering instead of framework/common, framework/images and > framework/widget. Just pave the way for the next -- This message was sent by Atlassian JIRA (v6.3.4#6332)
