[jira] [Comment Edited] (OFBIZ-9981) Handle service response effectively

[Jacques Le Roux (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307204#comment-16307204
 ] 

Jacques Le Roux edited comment on OFBIZ-9981 at 1/1/18 12:21 PM:
-

Anushi,

Your patch for the plugins part is in at revision: 1819735  

I made some slight changes:
* hhfacility no longer exists
* some changes were already in BirtWorker.java and I had to do 2 changes in 
EbayStoreAutoPreferences.java by hand

Guys, I let you decide if you want to close now or if we need to complete this 
work, happy new year :)


was (Author: jacques.le.roux):
Anushi,

Your patch for the plugins part is in at revision: 1819735  

I made some slight changes:
* hhfacility no longer exists
* some changes were already in BirtWorker.java and I add to do 2 changes in 
EbayStoreAutoPreferences.java by hand

Guys, I let you decide if you want to close now or if we need to complete this 
work, happy new year :)

> Handle service response effectively
> ---
>
> Key: OFBIZ-9981
> URL: https://issues.apache.org/jira/browse/OFBIZ-9981
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Suraj Khurana
>Assignee: Jacques Le Roux
> Attachments: OFBIZ-9981-MAR-SECEXT-WE.patch, 
> OFBIZ-9981-content.patch, OFBIZ-9981-manufacturing.patch, 
> OFBIZ-9981-order.patch, OFBIZ-9981-party.patch, OFBIZ-9981-plugins.patch, 
> OFBIZ-9981-product.patch, OFBIZ-9981.patch
>
>
> [As per discussion on Dev ML|http://markmail.org/message/dfriai337uxlx5mo]: 
> ==
> Every service calling from java/groovy must handle errors by service util 
> methods such as isError, reutrnError etc. and similarly in case of XML 
>  executed successfully.
> Apart from this, one suggestion is to include *Debug.logError* in 
> *_ServiceUtil.returnProblem_* so that in case of any error occurred and 
> handled, it will always be logged on the console.
> ==



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (OFBIZ-9981) Handle service response effectively

[Suraj Khurana (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266425#comment-16266425
 ] 

Suraj Khurana edited comment on OFBIZ-9981 at 11/27/17 6:28 AM:


Here is the patch in which Debug.logError is added on ServiceUtil.returnProblem 
so that every return error will be also logged on the console.


was (Author: suraj.khurana):
Here is the patch in which Deb.logError is added on ServiceUtil.returnProblem 
so that every return error will be also logged on the console.

> Handle service response effectively
> ---
>
> Key: OFBIZ-9981
> URL: https://issues.apache.org/jira/browse/OFBIZ-9981
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
> Attachments: OFBIZ-9981.patch
>
>
> As per discussion on Dev ML:
> ==
> Every service calling from java/groovy must handle errors by service util 
> methods such as isError, reutrnError etc. and similarly in case of XML 
>  executed successfully.
> Apart from this, one suggestion is to include *Debug.logError* in 
> *_ServiceUtil.returnProblem_* so that in case of any error occurred and 
> handled, it will always be logged on the console.
> ==



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)