[jira] [Commented] (OFBIZ-10377) Missing oldStatusId in error when no status valid change record found

[Swapnil M Mane (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-10377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805645#comment-16805645
 ] 

Swapnil M Mane commented on OFBIZ-10377:


Thanks [~lalit.dashora] for your contibution.

You patch is committed in

trunk at rev 1856598
release18.12 at rev 1856599
release17.12 at rev 1856600
release16.11 at rev 1856601

I also face the similar issue and debug it, here are few notes on issue and 
steps to test (commenting for futur reference)
Issue: In the case of entity auto service, when an invalid status change is 
performed, the error message doesn't show the current status of the item from 
which the user is changing the status.

e.g. 
Change the status of 'In Progress' marketing campaign to 'Planned'

1.) Navigate to 
https://demo-trunk.ofbiz.apache.org/marketing/control/FindMarketingCampaign
2.) Select any 'In Progress' marketing campaign
3.) Change status to 'Planned'

The error shown is: 
Error: status change from [] to [MKTG_CAMP_PLANNED] is not allowed.

After the above commits, this issue is fixed.
Thanks!

> Missing oldStatusId in error when no status valid change record found
> -
>
> Key: OFBIZ-10377
> URL: https://issues.apache.org/jira/browse/OFBIZ-10377
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Lalit Dashora
>Assignee: Swapnil M Mane
>Priority: Major
> Attachments: StatusIssue.patch
>
>
> If no transaction for status valid change is found, OldStatusId is missing on 
> the console while showing error.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OFBIZ-10377) missing oldStatusId in error when no status valid change record found

[Lalit Dashora (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-10377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16665939#comment-16665939
 ] 

Lalit Dashora commented on OFBIZ-10377:
---

Hello,

Please find the provided patch. This will fix the issue in logs shown when 
invalid statusvalidchange is found in the system.

When status change is not allowed from one state to other then system will 
return error from 

CommonErrorNoStatusValidChange label. This label tries to find lookedup value 
but localContext doesnot have this value. Added the lookedupValue in 
localContext to fix the issue.

Thanks!

> missing oldStatusId in error when no status valid change record found
> -
>
> Key: OFBIZ-10377
> URL: https://issues.apache.org/jira/browse/OFBIZ-10377
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Lalit Dashora
>Assignee: Lalit Dashora
>Priority: Major
> Attachments: OldStatusIdMissingPatch.patch
>
>
> If no transaction for status valid change is found, OldStatusId is missing on 
> the console while showing error.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)