[jira] [Commented] (OFBIZ-10489) Unnecessary ship groups in orders
[ https://issues.apache.org/jira/browse/OFBIZ-10489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032429#comment-17032429 ] Jacques Le Roux commented on OFBIZ-10489: - Ha, I see now what you asked about. I have no ideas :) > Unnecessary ship groups in orders > - > > Key: OFBIZ-10489 > URL: https://issues.apache.org/jira/browse/OFBIZ-10489 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Oleg Andreyev >Assignee: Akash Jain >Priority: Minor > Fix For: 17.12.01, 18.12.01 > > Attachments: OFBIZ-10489.patch, empty_ship_group.diff > > > Under some conditions, checkout creates extra ship groups in the order. > Steps to reproduce: > # create a couple of products P1 and P2 (just to get clear results). > # create a new order and add 1 P1 and 1 P2 > # change quantity P1 to 2 (or both) and Recalculate Order (key step really) > # finish checkout > You will see 2 order items linked with ship group 1 and another ship > group 2 that should not have been created. You may see in the patch that > the code address a ship group using index of the order item and the shopping > cart creates new ship group if the index is greater than the number of > existing groups. > In one of my projects based on 16.11, I noticed even more serious trouble > that takes place if both products are drop-shipping order but don't explain > it here because it seems do not appear in the trunk. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10489) Unnecessary ship groups in orders
[ https://issues.apache.org/jira/browse/OFBIZ-10489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032400#comment-17032400 ] Pierre Smits commented on OFBIZ-10489: -- [~jleroux] IMO that is not the correct answer to my question. I am not asking about the need for backporting to r16, nor about potential difficulties as a result of the self-inflicted flaws due to partial migration. > Unnecessary ship groups in orders > - > > Key: OFBIZ-10489 > URL: https://issues.apache.org/jira/browse/OFBIZ-10489 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Oleg Andreyev >Assignee: Akash Jain >Priority: Minor > Fix For: 17.12.01, 18.12.01 > > Attachments: OFBIZ-10489.patch, empty_ship_group.diff > > > Under some conditions, checkout creates extra ship groups in the order. > Steps to reproduce: > # create a couple of products P1 and P2 (just to get clear results). > # create a new order and add 1 P1 and 1 P2 > # change quantity P1 to 2 (or both) and Recalculate Order (key step really) > # finish checkout > You will see 2 order items linked with ship group 1 and another ship > group 2 that should not have been created. You may see in the patch that > the code address a ship group using index of the order item and the shopping > cart creates new ship group if the index is greater than the number of > existing groups. > In one of my projects based on 16.11, I noticed even more serious trouble > that takes place if both products are drop-shipping order but don't explain > it here because it seems do not appear in the trunk. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10489) Unnecessary ship groups in orders
[ https://issues.apache.org/jira/browse/OFBIZ-10489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032395#comment-17032395 ] Jacques Le Roux commented on OFBIZ-10489: - Hi Pierre, It's hard to bacport from Git to Svn all would be manual and R16 should be considered to be no longer supported. At least security will not... > Unnecessary ship groups in orders > - > > Key: OFBIZ-10489 > URL: https://issues.apache.org/jira/browse/OFBIZ-10489 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Oleg Andreyev >Assignee: Akash Jain >Priority: Minor > Fix For: 17.12.01, 18.12.01 > > Attachments: OFBIZ-10489.patch, empty_ship_group.diff > > > Under some conditions, checkout creates extra ship groups in the order. > Steps to reproduce: > # create a couple of products P1 and P2 (just to get clear results). > # create a new order and add 1 P1 and 1 P2 > # change quantity P1 to 2 (or both) and Recalculate Order (key step really) > # finish checkout > You will see 2 order items linked with ship group 1 and another ship > group 2 that should not have been created. You may see in the patch that > the code address a ship group using index of the order item and the shopping > cart creates new ship group if the index is greater than the number of > existing groups. > In one of my projects based on 16.11, I noticed even more serious trouble > that takes place if both products are drop-shipping order but don't explain > it here because it seems do not appear in the trunk. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10489) Unnecessary ship groups in orders
[ https://issues.apache.org/jira/browse/OFBIZ-10489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032366#comment-17032366 ] Pierre Smits commented on OFBIZ-10489: -- Can we expect this issue also to exist in pre r17 branches? > Unnecessary ship groups in orders > - > > Key: OFBIZ-10489 > URL: https://issues.apache.org/jira/browse/OFBIZ-10489 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Oleg Andreyev >Assignee: Akash Jain >Priority: Minor > Fix For: 17.12.01, 18.12.01 > > Attachments: OFBIZ-10489.patch, empty_ship_group.diff > > > Under some conditions, checkout creates extra ship groups in the order. > Steps to reproduce: > # create a couple of products P1 and P2 (just to get clear results). > # create a new order and add 1 P1 and 1 P2 > # change quantity P1 to 2 (or both) and Recalculate Order (key step really) > # finish checkout > You will see 2 order items linked with ship group 1 and another ship > group 2 that should not have been created. You may see in the patch that > the code address a ship group using index of the order item and the shopping > cart creates new ship group if the index is greater than the number of > existing groups. > In one of my projects based on 16.11, I noticed even more serious trouble > that takes place if both products are drop-shipping order but don't explain > it here because it seems do not appear in the trunk. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10489) Unnecessary ship groups in orders
[ https://issues.apache.org/jira/browse/OFBIZ-10489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032358#comment-17032358 ] Akash Jain commented on OFBIZ-10489: This issue has been fixed at: Trunk: 701ec7f3ea66e6e3cff50516a8a30897136a58a7 R18: 37b8e5b0e89e5ce332bee396bc3ccb705e6875d2 R17: 8de770f701189522d8910f5f6592c5cf94c4fd12 Thanks, [~redcat] and [~Mohammad K] for your contribution. > Unnecessary ship groups in orders > - > > Key: OFBIZ-10489 > URL: https://issues.apache.org/jira/browse/OFBIZ-10489 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Oleg Andreyev >Assignee: Akash Jain >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10489.patch, empty_ship_group.diff > > > Under some conditions, checkout creates extra ship groups in the order. > Steps to reproduce: > # create a couple of products P1 and P2 (just to get clear results). > # create a new order and add 1 P1 and 1 P2 > # change quantity P1 to 2 (or both) and Recalculate Order (key step really) > # finish checkout > You will see 2 order items linked with ship group 1 and another ship > group 2 that should not have been created. You may see in the patch that > the code address a ship group using index of the order item and the shopping > cart creates new ship group if the index is greater than the number of > existing groups. > In one of my projects based on 16.11, I noticed even more serious trouble > that takes place if both products are drop-shipping order but don't explain > it here because it seems do not appear in the trunk. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10489) Unnecessary ship groups in orders
[ https://issues.apache.org/jira/browse/OFBIZ-10489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032355#comment-17032355 ] ASF subversion and git services commented on OFBIZ-10489: - Commit 8de770f701189522d8910f5f6592c5cf94c4fd12 in ofbiz-framework's branch refs/heads/release17.12 from akash [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=8de770f ] Fixed: Unnecessary ship groups in orders. (OFBIZ-10489) Thanks, Oleg Andreyev and Mohammad Kathawala for your contribution. > Unnecessary ship groups in orders > - > > Key: OFBIZ-10489 > URL: https://issues.apache.org/jira/browse/OFBIZ-10489 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Oleg Andreyev >Assignee: Akash Jain >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10489.patch, empty_ship_group.diff > > > Under some conditions, checkout creates extra ship groups in the order. > Steps to reproduce: > # create a couple of products P1 and P2 (just to get clear results). > # create a new order and add 1 P1 and 1 P2 > # change quantity P1 to 2 (or both) and Recalculate Order (key step really) > # finish checkout > You will see 2 order items linked with ship group 1 and another ship > group 2 that should not have been created. You may see in the patch that > the code address a ship group using index of the order item and the shopping > cart creates new ship group if the index is greater than the number of > existing groups. > In one of my projects based on 16.11, I noticed even more serious trouble > that takes place if both products are drop-shipping order but don't explain > it here because it seems do not appear in the trunk. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10489) Unnecessary ship groups in orders
[ https://issues.apache.org/jira/browse/OFBIZ-10489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032354#comment-17032354 ] ASF subversion and git services commented on OFBIZ-10489: - Commit 37b8e5b0e89e5ce332bee396bc3ccb705e6875d2 in ofbiz-framework's branch refs/heads/release18.12 from akash [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=37b8e5b ] Fixed: Unnecessary ship groups in orders. (OFBIZ-10489) Thanks, Oleg Andreyev and Mohammad Kathawala for your contribution. > Unnecessary ship groups in orders > - > > Key: OFBIZ-10489 > URL: https://issues.apache.org/jira/browse/OFBIZ-10489 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Oleg Andreyev >Assignee: Akash Jain >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10489.patch, empty_ship_group.diff > > > Under some conditions, checkout creates extra ship groups in the order. > Steps to reproduce: > # create a couple of products P1 and P2 (just to get clear results). > # create a new order and add 1 P1 and 1 P2 > # change quantity P1 to 2 (or both) and Recalculate Order (key step really) > # finish checkout > You will see 2 order items linked with ship group 1 and another ship > group 2 that should not have been created. You may see in the patch that > the code address a ship group using index of the order item and the shopping > cart creates new ship group if the index is greater than the number of > existing groups. > In one of my projects based on 16.11, I noticed even more serious trouble > that takes place if both products are drop-shipping order but don't explain > it here because it seems do not appear in the trunk. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10489) Unnecessary ship groups in orders
[ https://issues.apache.org/jira/browse/OFBIZ-10489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032353#comment-17032353 ] ASF subversion and git services commented on OFBIZ-10489: - Commit 701ec7f3ea66e6e3cff50516a8a30897136a58a7 in ofbiz-framework's branch refs/heads/trunk from akash [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=701ec7f ] Fixed: Unnecessary ship groups in orders. (OFBIZ-10489) Thanks, Oleg Andreyev and Mohammad Kathawala for your contribution. > Unnecessary ship groups in orders > - > > Key: OFBIZ-10489 > URL: https://issues.apache.org/jira/browse/OFBIZ-10489 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Oleg Andreyev >Assignee: Akash Jain >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10489.patch, empty_ship_group.diff > > > Under some conditions, checkout creates extra ship groups in the order. > Steps to reproduce: > # create a couple of products P1 and P2 (just to get clear results). > # create a new order and add 1 P1 and 1 P2 > # change quantity P1 to 2 (or both) and Recalculate Order (key step really) > # finish checkout > You will see 2 order items linked with ship group 1 and another ship > group 2 that should not have been created. You may see in the patch that > the code address a ship group using index of the order item and the shopping > cart creates new ship group if the index is greater than the number of > existing groups. > In one of my projects based on 16.11, I noticed even more serious trouble > that takes place if both products are drop-shipping order but don't explain > it here because it seems do not appear in the trunk. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10489) Unnecessary ship groups in orders
[ https://issues.apache.org/jira/browse/OFBIZ-10489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16874808#comment-16874808 ] Jacques Le Roux commented on OFBIZ-10489: - Thanks Mohammad, That sounds legit to me, could you pleas try and confirm it fixes your issues Oleg? > Unnecessary ship groups in orders > - > > Key: OFBIZ-10489 > URL: https://issues.apache.org/jira/browse/OFBIZ-10489 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Oleg Andreyev >Assignee: Mohammad Kathawala >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10489.patch, empty_ship_group.diff > > > Under some conditions, checkout creates extra ship groups in the order. > Steps to reproduce: > # create a couple of products P1 and P2 (just to get clear results). > # create a new order and add 1 P1 and 1 P2 > # change quantity P1 to 2 (or both) and Recalculate Order (key step really) > # finish checkout > You will see 2 order items linked with ship group 1 and another ship > group 2 that should not have been created. You may see in the patch that > the code address a ship group using index of the order item and the shopping > cart creates new ship group if the index is greater than the number of > existing groups. > In one of my projects based on 16.11, I noticed even more serious trouble > that takes place if both products are drop-shipping order but don't explain > it here because it seems do not appear in the trunk. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10489) Unnecessary ship groups in orders
[ https://issues.apache.org/jira/browse/OFBIZ-10489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16870233#comment-16870233 ] Mohammad Kathawala commented on OFBIZ-10489: The issue is generated because of the code committed in the patch from the ticket https://issues.apache.org/jira/browse/OFBIZ-5416. Here the code was properly handled in _ShoppingCartEvents.java_ but not in _ShoppingCartHelper.java._ Did the same handling in _ShoppingCartHelper.java_ in the patch *OFBIZ-10489.patch*. > Unnecessary ship groups in orders > - > > Key: OFBIZ-10489 > URL: https://issues.apache.org/jira/browse/OFBIZ-10489 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Oleg Andreyev >Assignee: Mohammad Kathawala >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10489.patch, empty_ship_group.diff > > > Under some conditions, checkout creates extra ship groups in the order. > Steps to reproduce: > # create a couple of products P1 and P2 (just to get clear results). > # create a new order and add 1 P1 and 1 P2 > # change quantity P1 to 2 (or both) and Recalculate Order (key step really) > # finish checkout > You will see 2 order items linked with ship group 1 and another ship > group 2 that should not have been created. You may see in the patch that > the code address a ship group using index of the order item and the shopping > cart creates new ship group if the index is greater than the number of > existing groups. > In one of my projects based on 16.11, I noticed even more serious trouble > that takes place if both products are drop-shipping order but don't explain > it here because it seems do not appear in the trunk. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
