[jira] [Commented] (OFBIZ-10501) Unable to create new facility when DB has no facility

2018-08-01 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565497#comment-16565497
 ] 

Jacques Le Roux commented on OFBIZ-10501:
-

Good news, looking forward... in future :) ...

> Unable to create new facility when DB has no facility
> -
>
> Key: OFBIZ-10501
> URL: https://issues.apache.org/jira/browse/OFBIZ-10501
> Project: OFBiz
>  Issue Type: Bug
>  Components: hhfacility
>Affects Versions: Trunk
>Reporter: Julien NICOLAS
>Assignee: Julien NICOLAS
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10501.patch
>
>
> The "Create new facility" button is not visible until at least one facility 
> is selected.
> When the database is empty, impossible to create the first facility.
> After reading source code, I see some other mistake in the screen design like 
> a menu that is not using menu renderer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10501) Unable to create new facility when DB has no facility

2018-08-01 Thread Julien NICOLAS (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565484#comment-16565484
 ] 

Julien NICOLAS commented on OFBIZ-10501:


Hé hé hé, ok.

I was very closed to modify this screen to a better OFBiz standard. But, as 
always, not enough time and want-to-make-it-works-first. Maybe later but 
probably not with this theme ;)

Julien.

> Unable to create new facility when DB has no facility
> -
>
> Key: OFBIZ-10501
> URL: https://issues.apache.org/jira/browse/OFBIZ-10501
> Project: OFBiz
>  Issue Type: Bug
>  Components: hhfacility
>Affects Versions: Trunk
>Reporter: Julien NICOLAS
>Assignee: Julien NICOLAS
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10501.patch
>
>
> The "Create new facility" button is not visible until at least one facility 
> is selected.
> When the database is empty, impossible to create the first facility.
> After reading source code, I see some other mistake in the screen design like 
> a menu that is not using menu renderer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10501) Unable to create new facility when DB has no facility

2018-08-01 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565469#comment-16565469
 ] 

Jacques Le Roux commented on OFBIZ-10501:
-

Oops, it was only because I did not get the label locally. I guess a merge 
quick rather. It's OK, forget it :)

> Unable to create new facility when DB has no facility
> -
>
> Key: OFBIZ-10501
> URL: https://issues.apache.org/jira/browse/OFBIZ-10501
> Project: OFBiz
>  Issue Type: Bug
>  Components: hhfacility
>Affects Versions: Trunk
>Reporter: Julien NICOLAS
>Assignee: Julien NICOLAS
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10501.patch
>
>
> The "Create new facility" button is not visible until at least one facility 
> is selected.
> When the database is empty, impossible to create the first facility.
> After reading source code, I see some other mistake in the screen design like 
> a menu that is not using menu renderer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10501) Unable to create new facility when DB has no facility

2018-08-01 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565462#comment-16565462
 ] 

Jacques Le Roux commented on OFBIZ-10501:
-

Hého Julien,

Sorry to disspoint you but I found a little quirk :). As you said in your 
commit comment

bq. I don't know why it doesn't respect OFBiz screen list standard. I only 
fixed the problem with the creation button, some flying condition and add a new 
menu action for facility

we don't have a search and list on this screen (bad legacy). So I'll put back 
the ProductOnlyOneFacility label above the creation button, waiting for a real 
and definitive standard solution


> Unable to create new facility when DB has no facility
> -
>
> Key: OFBIZ-10501
> URL: https://issues.apache.org/jira/browse/OFBIZ-10501
> Project: OFBiz
>  Issue Type: Bug
>  Components: hhfacility
>Affects Versions: Trunk
>Reporter: Julien NICOLAS
>Assignee: Julien NICOLAS
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10501.patch
>
>
> The "Create new facility" button is not visible until at least one facility 
> is selected.
> When the database is empty, impossible to create the first facility.
> After reading source code, I see some other mistake in the screen design like 
> a menu that is not using menu renderer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10501) Unable to create new facility when DB has no facility

2018-07-31 Thread Julien NICOLAS (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563845#comment-16563845
 ] 

Julien NICOLAS commented on OFBIZ-10501:


What a day ! I should to do more community stuff, I feel very good !

By now, nothing could darken my day B)

Julien.

> Unable to create new facility when DB has no facility
> -
>
> Key: OFBIZ-10501
> URL: https://issues.apache.org/jira/browse/OFBIZ-10501
> Project: OFBiz
>  Issue Type: Bug
>  Components: hhfacility
>Affects Versions: Trunk
>Reporter: Julien NICOLAS
>Assignee: Julien NICOLAS
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10501.patch
>
>
> The "Create new facility" button is not visible until at least one facility 
> is selected.
> When the database is empty, impossible to create the first facility.
> After reading source code, I see some other mistake in the screen design like 
> a menu that is not using menu renderer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10501) Unable to create new facility when DB has no facility

2018-07-31 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563837#comment-16563837
 ] 

Jacques Le Roux commented on OFBIZ-10501:
-

Thanks indeed Julien and Gil,

I began to work on this in February but did not finalize, I like your solution 
:)

> Unable to create new facility when DB has no facility
> -
>
> Key: OFBIZ-10501
> URL: https://issues.apache.org/jira/browse/OFBIZ-10501
> Project: OFBiz
>  Issue Type: Bug
>  Components: hhfacility
>Affects Versions: Trunk
>Reporter: Julien NICOLAS
>Assignee: Julien NICOLAS
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10501.patch
>
>
> The "Create new facility" button is not visible until at least one facility 
> is selected.
> When the database is empty, impossible to create the first facility.
> After reading source code, I see some other mistake in the screen design like 
> a menu that is not using menu renderer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10501) Unable to create new facility when DB has no facility

2018-07-31 Thread Julien NICOLAS (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563795#comment-16563795
 ] 

Julien NICOLAS commented on OFBIZ-10501:


Hello [~sharan] !

It's cool that this fix help you already :) I think it's a bug that very few 
people encountered. You must start from scratch to see it.

Today, I made a bugfix and receive a thanks by you, it's a very nice day :)

Have a nice day too,

Julien.

> Unable to create new facility when DB has no facility
> -
>
> Key: OFBIZ-10501
> URL: https://issues.apache.org/jira/browse/OFBIZ-10501
> Project: OFBiz
>  Issue Type: Bug
>  Components: hhfacility
>Affects Versions: Trunk
>Reporter: Julien NICOLAS
>Assignee: Julien NICOLAS
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10501.patch
>
>
> The "Create new facility" button is not visible until at least one facility 
> is selected.
> When the database is empty, impossible to create the first facility.
> After reading source code, I see some other mistake in the screen design like 
> a menu that is not using menu renderer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10501) Unable to create new facility when DB has no facility

2018-07-31 Thread Sharan Foga (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563790#comment-16563790
 ] 

Sharan Foga commented on OFBIZ-10501:
-

Thanks for the fix [~julien.nicolas]! I came across this while I was doing some 
testing last week. I managed to get around it by using the ofbizsetup 
application but having a permanent solution in the code is a lot better :)

> Unable to create new facility when DB has no facility
> -
>
> Key: OFBIZ-10501
> URL: https://issues.apache.org/jira/browse/OFBIZ-10501
> Project: OFBiz
>  Issue Type: Bug
>  Components: hhfacility
>Affects Versions: Trunk
>Reporter: Julien NICOLAS
>Assignee: Julien NICOLAS
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10501.patch
>
>
> The "Create new facility" button is not visible until at least one facility 
> is selected.
> When the database is empty, impossible to create the first facility.
> After reading source code, I see some other mistake in the screen design like 
> a menu that is not using menu renderer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10501) Unable to create new facility when DB has no facility

2018-07-31 Thread Julien NICOLAS (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563728#comment-16563728
 ] 

Julien NICOLAS commented on OFBIZ-10501:


Fixed version : R1837150

> Unable to create new facility when DB has no facility
> -
>
> Key: OFBIZ-10501
> URL: https://issues.apache.org/jira/browse/OFBIZ-10501
> Project: OFBiz
>  Issue Type: Bug
>  Components: hhfacility
>Affects Versions: Trunk
>Reporter: Julien NICOLAS
>Assignee: Julien NICOLAS
>Priority: Major
> Attachments: OFBIZ-10501.patch
>
>
> The "Create new facility" button is not visible until at least one facility 
> is selected.
> When the database is empty, impossible to create the first facility.
> After reading source code, I see some other mistake in the screen design like 
> a menu that is not using menu renderer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)