[jira] [Commented] (OFBIZ-10663) Amount field is editable at Product Detail Page
[ https://issues.apache.org/jira/browse/OFBIZ-10663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16812618#comment-16812618 ] Jacques Le Roux commented on OFBIZ-10663: - (y) > Amount field is editable at Product Detail Page > --- > > Key: OFBIZ-10663 > URL: https://issues.apache.org/jira/browse/OFBIZ-10663 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Reporter: Dikpal Kanungo >Assignee: Deepak Dixit >Priority: Major > Fix For: 17.12.01 > > Attachments: Editable amount.png, Missing Heading.png, > OFBIZ-10663.patch > > > The customer is able to enter the price of a product from the product detail > page which should not happen. > Steps to regenerate- > Open - ofbiz demo trunk for ecomm. > Click on the product - Tiny Gizmo > Try editing the Amount field. > -- > Click on product - .NIT Gizmo > Quantity text is missing and No value is coming in reference to Amount > heading. > Please have a look at the attached screenshots. > Cheers, > Dikpal !Missing Heading.png! > > > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10663) Amount field is editable at Product Detail Page
[ https://issues.apache.org/jira/browse/OFBIZ-10663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16812599#comment-16812599 ] Deepak Dixit commented on OFBIZ-10663: -- Here amount is not a Price. Its amount of product This has been fixed at OFBiz plugins trunk at r1857120 OFBiz plugins R18.12 at r1857121 OFBiz plugins R17.12 at r1857122 Also, I'd like to mark this as an improvement. > Amount field is editable at Product Detail Page > --- > > Key: OFBIZ-10663 > URL: https://issues.apache.org/jira/browse/OFBIZ-10663 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Reporter: Dikpal Kanungo >Assignee: Deepak Dixit >Priority: Major > Attachments: Editable amount.png, Missing Heading.png, > OFBIZ-10663.patch > > > The customer is able to enter the price of a product from the product detail > page which should not happen. > Steps to regenerate- > Open - ofbiz demo trunk for ecomm. > Click on the product - Tiny Gizmo > Try editing the Amount field. > -- > Click on product - .NIT Gizmo > Quantity text is missing and No value is coming in reference to Amount > heading. > Please have a look at the attached screenshots. > Cheers, > Dikpal !Missing Heading.png! > > > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10663) Amount field is editable at Product Detail Page
[ https://issues.apache.org/jira/browse/OFBIZ-10663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16812587#comment-16812587 ] Jacques Le Roux commented on OFBIZ-10663: - Thanks Deepak, looking forward :) > Amount field is editable at Product Detail Page > --- > > Key: OFBIZ-10663 > URL: https://issues.apache.org/jira/browse/OFBIZ-10663 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Reporter: Dikpal Kanungo >Assignee: Deepak Dixit >Priority: Major > Attachments: Editable amount.png, Missing Heading.png, > OFBIZ-10663.patch > > > The customer is able to enter the price of a product from the product detail > page which should not happen. > Steps to regenerate- > Open - ofbiz demo trunk for ecomm. > Click on the product - Tiny Gizmo > Try editing the Amount field. > -- > Click on product - .NIT Gizmo > Quantity text is missing and No value is coming in reference to Amount > heading. > Please have a look at the attached screenshots. > Cheers, > Dikpal !Missing Heading.png! > > > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10663) Amount field is editable at Product Detail Page
[ https://issues.apache.org/jira/browse/OFBIZ-10663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16812563#comment-16812563 ] Deepak Dixit commented on OFBIZ-10663: -- I think this was introduced due to bootstrap work. Let me commit the fix. > Amount field is editable at Product Detail Page > --- > > Key: OFBIZ-10663 > URL: https://issues.apache.org/jira/browse/OFBIZ-10663 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Reporter: Dikpal Kanungo >Assignee: Deepak Dixit >Priority: Major > Attachments: Editable amount.png, Missing Heading.png, > OFBIZ-10663.patch > > > The customer is able to enter the price of a product from the product detail > page which should not happen. > Steps to regenerate- > Open - ofbiz demo trunk for ecomm. > Click on the product - Tiny Gizmo > Try editing the Amount field. > -- > Click on product - .NIT Gizmo > Quantity text is missing and No value is coming in reference to Amount > heading. > Please have a look at the attached screenshots. > Cheers, > Dikpal !Missing Heading.png! > > > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10663) Amount field is editable at Product Detail Page
[ https://issues.apache.org/jira/browse/OFBIZ-10663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16812438#comment-16812438 ] Jacques Le Roux commented on OFBIZ-10663: - Apart my comment above, I don't think the solution from the current [^OFBIZ-10663.patch] is satisfying > Amount field is editable at Product Detail Page > --- > > Key: OFBIZ-10663 > URL: https://issues.apache.org/jira/browse/OFBIZ-10663 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Reporter: Dikpal Kanungo >Assignee: Jacques Le Roux >Priority: Major > Attachments: Editable amount.png, Missing Heading.png, > OFBIZ-10663.patch > > > The customer is able to enter the price of a product from the product detail > page which should not happen. > Steps to regenerate- > Open - ofbiz demo trunk for ecomm. > Click on the product - Tiny Gizmo > Try editing the Amount field. > -- > Click on product - .NIT Gizmo > Quantity text is missing and No value is coming in reference to Amount > heading. > Please have a look at the attached screenshots. > Cheers, > Dikpal !Missing Heading.png! > > > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10663) Amount field is editable at Product Detail Page
[
https://issues.apache.org/jira/browse/OFBIZ-10663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790368#comment-16790368
]
Jacques Le Roux commented on OFBIZ-10663:
-
Thanks Sasikant,
I did not have time to try yet, are you sure there are no side effects? I
wonder because of this code:
{noformat}
<#if "Y" == product.requireAmount?default("N")>
<#assign hiddenStyle = "visible">
<#else>
<#assign hiddenStyle = "hidden">
{noformat}
> Amount field is editable at Product Detail Page
> ---
>
> Key: OFBIZ-10663
> URL: https://issues.apache.org/jira/browse/OFBIZ-10663
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
>Reporter: Dikpal Kanungo
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: Editable amount.png, Missing Heading.png,
> OFBIZ-10663.patch
>
>
> The customer is able to enter the price of a product from the product detail
> page which should not happen.
> Steps to regenerate-
> Open - ofbiz demo trunk for ecomm.
> Click on the product - Tiny Gizmo
> Try editing the Amount field.
> --
> Click on product - .NIT Gizmo
> Quantity text is missing and No value is coming in reference to Amount
> heading.
> Please have a look at the attached screenshots.
> Cheers,
> Dikpal !Missing Heading.png!
>
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10663) Amount field is editable at Product Detail Page
[ https://issues.apache.org/jira/browse/OFBIZ-10663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788660#comment-16788660 ] Sasikant Biswal commented on OFBIZ-10663: - *Steps to verify:-* # Navigate to ecommerce # Click on Tiny Gizmo product. # Edit the amount field. *Affected Screen:-* 1. View Product page. *Reason:-* 1. Amount field is editable. *Fix:-* 1. Made the text field hidden for edit amount. *Comment:-* 1. Changes working fine on the application and patch also provided. > Amount field is editable at Product Detail Page > --- > > Key: OFBIZ-10663 > URL: https://issues.apache.org/jira/browse/OFBIZ-10663 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Reporter: Dikpal Kanungo >Assignee: Sasikant Biswal >Priority: Major > Attachments: Editable amount.png, Missing Heading.png, > OFBIZ-10663.patch > > > The customer is able to enter the price of a product from the product detail > page which should not happen. > Steps to regenerate- > Open - ofbiz demo trunk for ecomm. > Click on the product - Tiny Gizmo > Try editing the Amount field. > -- > Click on product - .NIT Gizmo > Quantity text is missing and No value is coming in reference to Amount > heading. > Please have a look at the attached screenshots. > Cheers, > Dikpal !Missing Heading.png! > > > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10663) Amount field is editable at Product Detail Page
[ https://issues.apache.org/jira/browse/OFBIZ-10663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16741311#comment-16741311 ] Jacques Le Roux commented on OFBIZ-10663: - This could be somehow related with OFBIZ-10536 > Amount field is editable at Product Detail Page > --- > > Key: OFBIZ-10663 > URL: https://issues.apache.org/jira/browse/OFBIZ-10663 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Reporter: Dikpal Kanungo >Assignee: Sasikant Biswal >Priority: Major > Attachments: Editable amount.png, Missing Heading.png > > > The customer is able to enter the price of a product from the product detail > page which should not happen. > Steps to regenerate- > Open - ofbiz demo trunk for ecomm. > Click on the product - Tiny Gizmo > Try editing the Amount field. > -- > Click on product - .NIT Gizmo > Quantity text is missing and No value is coming in reference to Amount > heading. > Please have a look at the attached screenshots. > Cheers, > Dikpal !Missing Heading.png! > > > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10663) Amount field is editable at Product Detail Page
[ https://issues.apache.org/jira/browse/OFBIZ-10663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16705914#comment-16705914 ] Jacques Le Roux commented on OFBIZ-10663: - I agree Ratnesh, could you handle it? > Amount field is editable at Product Detail Page > --- > > Key: OFBIZ-10663 > URL: https://issues.apache.org/jira/browse/OFBIZ-10663 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Reporter: Dikpal Kanungo >Priority: Major > Attachments: Editable amount.png, Missing Heading.png > > > The customer is able to enter the price of a product from the product detail > page which should not happen. > Steps to regenerate- > Open - ofbiz demo trunk for ecomm. > Click on the product - Tiny Gizmo > Try editing the Amount field. > -- > Click on product - .NIT Gizmo > Quantity text is missing and No value is coming in reference to Amount > heading. > Please have a look at the attached screenshots. > Cheers, > Dikpal !Missing Heading.png! > > > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10663) Amount field is editable at Product Detail Page
[ https://issues.apache.org/jira/browse/OFBIZ-10663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697689#comment-16697689 ] Ratnesh Upadhyay commented on OFBIZ-10663: -- [~Dikpal.Kanungo] Thanks for raising the issue, I have quickly reviewed the issue and to me it seems that the amount field should be applicable for gift card products only and it should appear when user choose the other amount option OR user want to reload existing gift card with different amount. I think we can modify the current implementation to show amount field for digital good type products OR gift card products only to resolve this issue. I hope it helps! > Amount field is editable at Product Detail Page > --- > > Key: OFBIZ-10663 > URL: https://issues.apache.org/jira/browse/OFBIZ-10663 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Reporter: Dikpal Kanungo >Priority: Major > Attachments: Editable amount.png, Missing Heading.png > > > The customer is able to enter the price of a product from the product detail > page which should not happen. > Steps to regenerate- > Open - ofbiz demo trunk for ecomm. > Click on the product - Tiny Gizmo > Try editing the Amount field. > -- > Click on product - .NIT Gizmo > Quantity text is missing and No value is coming in reference to Amount > heading. > Please have a look at the attached screenshots. > Cheers, > Dikpal !Missing Heading.png! > > > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
