[jira] [Commented] (OFBIZ-10846) In AddFinAccountTrans selectable glAccountId values are sorted on glAccountId
[
https://issues.apache.org/jira/browse/OFBIZ-10846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805628#comment-16805628
]
Suraj Khurana commented on OFBIZ-10846:
---
Thanks [~jacques.le.roux],
As there are no objections for treating this ticket as improvement, I will
commit it as an improvement for trunk only.
> In AddFinAccountTrans selectable glAccountId values are sorted on glAccountId
> -
>
> Key: OFBIZ-10846
> URL: https://issues.apache.org/jira/browse/OFBIZ-10846
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk,
> Release Branch 15.12, 17.12.01, Release Branch 16.11, 16.11.04, 16.11.05,
> 16.11.06, Release Branch 17.12, Release Branch 18.12, 18.12.01
>Reporter: Pierre Smits
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10846.patch
>
>
> In the AddFinAccountTrans form in FinAccountForms.xml the values in the field
> glAccountId are sorted on the primary key, per
> {code:java}
>
>
> key-field-name="glAccountId" description="${accountCode} - ${accountName}
> [${glAccountId}]">
> operator="equals" env-name="defaultOrganizationPartyId"/>
>
>
>
>
> {code}
> The sort order should however be on the accountCode field of the entity
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10846) In AddFinAccountTrans selectable glAccountId values are sorted on glAccountId
[
https://issues.apache.org/jira/browse/OFBIZ-10846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789443#comment-16789443
]
Jacques Le Roux commented on OFBIZ-10846:
-
Pierre,
bq. Every bug fix is an improvement.
This is confusing as hell, bug fix need backporting, improvemens need not!
> In AddFinAccountTrans selectable glAccountId values are sorted on glAccountId
> -
>
> Key: OFBIZ-10846
> URL: https://issues.apache.org/jira/browse/OFBIZ-10846
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk,
> Release Branch 15.12, 17.12.01, Release Branch 16.11, 16.11.04, 16.11.05,
> 16.11.06, Release Branch 17.12, Release Branch 18.12, 18.12.01
>Reporter: Pierre Smits
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10846.patch
>
>
> In the AddFinAccountTrans form in FinAccountForms.xml the values in the field
> glAccountId are sorted on the primary key, per
> {code:java}
>
>
> key-field-name="glAccountId" description="${accountCode} - ${accountName}
> [${glAccountId}]">
> operator="equals" env-name="defaultOrganizationPartyId"/>
>
>
>
>
> {code}
> The sort order should however be on the accountCode field of the entity
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10846) In AddFinAccountTrans selectable glAccountId values are sorted on glAccountId
[
https://issues.apache.org/jira/browse/OFBIZ-10846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789193#comment-16789193
]
Suraj Khurana commented on OFBIZ-10846:
---
Hello,
>>Every bug fix is an improvement.
Could you please explain this, with reason how a simple sorting thing can be a
bug rather than improvement?
It will help others to put their thoughts on this.
Thanks for reporting the bug (improvement) ;)
> In AddFinAccountTrans selectable glAccountId values are sorted on glAccountId
> -
>
> Key: OFBIZ-10846
> URL: https://issues.apache.org/jira/browse/OFBIZ-10846
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk,
> Release Branch 15.12, 17.12.01, Release Branch 16.11, 16.11.04, 16.11.05,
> 16.11.06, Release Branch 17.12, Release Branch 18.12, 18.12.01
>Reporter: Pierre Smits
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10846.patch
>
>
> In the AddFinAccountTrans form in FinAccountForms.xml the values in the field
> glAccountId are sorted on the primary key, per
> {code:java}
>
>
> key-field-name="glAccountId" description="${accountCode} - ${accountName}
> [${glAccountId}]">
> operator="equals" env-name="defaultOrganizationPartyId"/>
>
>
>
>
> {code}
> The sort order should however be on the accountCode field of the entity
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10846) In AddFinAccountTrans selectable glAccountId values are sorted on glAccountId
[
https://issues.apache.org/jira/browse/OFBIZ-10846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788631#comment-16788631
]
Pierre Smits commented on OFBIZ-10846:
--
No matter how this is regarded by the assignee/committer, the fact remains
that the bug can be observed in any of the previous releases and existing
branches.
Hence, I will reset the affected version values.
> In AddFinAccountTrans selectable glAccountId values are sorted on glAccountId
> -
>
> Key: OFBIZ-10846
> URL: https://issues.apache.org/jira/browse/OFBIZ-10846
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10846.patch
>
>
> In the AddFinAccountTrans form in FinAccountForms.xml the values in the field
> glAccountId are sorted on the primary key, per
> {code:java}
>
>
> key-field-name="glAccountId" description="${accountCode} - ${accountName}
> [${glAccountId}]">
> operator="equals" env-name="defaultOrganizationPartyId"/>
>
>
>
>
> {code}
> The sort order should however be on the accountCode field of the entity
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10846) In AddFinAccountTrans selectable glAccountId values are sorted on glAccountId
[
https://issues.apache.org/jira/browse/OFBIZ-10846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788623#comment-16788623
]
Pierre Smits commented on OFBIZ-10846:
--
Removing the 'affected version' values does not help our existing adopters (to
be clear: those organisations that have implemented older OFBiz versions).
> In AddFinAccountTrans selectable glAccountId values are sorted on glAccountId
> -
>
> Key: OFBIZ-10846
> URL: https://issues.apache.org/jira/browse/OFBIZ-10846
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10846.patch
>
>
> In the AddFinAccountTrans form in FinAccountForms.xml the values in the field
> glAccountId are sorted on the primary key, per
> {code:java}
>
>
> key-field-name="glAccountId" description="${accountCode} - ${accountName}
> [${glAccountId}]">
> operator="equals" env-name="defaultOrganizationPartyId"/>
>
>
>
>
> {code}
> The sort order should however be on the accountCode field of the entity
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10846) In AddFinAccountTrans selectable glAccountId values are sorted on glAccountId
[
https://issues.apache.org/jira/browse/OFBIZ-10846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788615#comment-16788615
]
Suraj Khurana commented on OFBIZ-10846:
---
Hello,
I will wait for sometime if someone else has any concern and proceed it as an
improvement in case of no concerns.
Thanks !!
> In AddFinAccountTrans selectable glAccountId values are sorted on glAccountId
> -
>
> Key: OFBIZ-10846
> URL: https://issues.apache.org/jira/browse/OFBIZ-10846
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10846.patch
>
>
> In the AddFinAccountTrans form in FinAccountForms.xml the values in the field
> glAccountId are sorted on the primary key, per
> {code:java}
>
>
> key-field-name="glAccountId" description="${accountCode} - ${accountName}
> [${glAccountId}]">
> operator="equals" env-name="defaultOrganizationPartyId"/>
>
>
>
>
> {code}
> The sort order should however be on the accountCode field of the entity
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10846) In AddFinAccountTrans selectable glAccountId values are sorted on glAccountId
[
https://issues.apache.org/jira/browse/OFBIZ-10846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788596#comment-16788596
]
Pierre Smits commented on OFBIZ-10846:
--
So, wrong gl transactions have been generated since forever and it's not a bug,
rather a feature that just needed some minor improvement?
> In AddFinAccountTrans selectable glAccountId values are sorted on glAccountId
> -
>
> Key: OFBIZ-10846
> URL: https://issues.apache.org/jira/browse/OFBIZ-10846
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10846.patch
>
>
> In the AddFinAccountTrans form in FinAccountForms.xml the values in the field
> glAccountId are sorted on the primary key, per
> {code:java}
>
>
> key-field-name="glAccountId" description="${accountCode} - ${accountName}
> [${glAccountId}]">
> operator="equals" env-name="defaultOrganizationPartyId"/>
>
>
>
>
> {code}
> The sort order should however be on the accountCode field of the entity
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10846) In AddFinAccountTrans selectable glAccountId values are sorted on glAccountId
[
https://issues.apache.org/jira/browse/OFBIZ-10846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788588#comment-16788588
]
Pawan Verma commented on OFBIZ-10846:
-
Yes, I also believe it should be an improvement rather than a bug. Changing
Issue type to improvement. Thanks!
> In AddFinAccountTrans selectable glAccountId values are sorted on glAccountId
> -
>
> Key: OFBIZ-10846
> URL: https://issues.apache.org/jira/browse/OFBIZ-10846
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk,
> Release Branch 15.12, 17.12.01, Release Branch 16.11, 16.11.04, 16.11.05,
> 16.11.06, Release Branch 17.12, Release Branch 18.12, 18.12.01
>Reporter: Pierre Smits
>Assignee: Pawan Verma
>Priority: Major
> Attachments: OFBIZ-10846.patch
>
>
> In the AddFinAccountTrans form in FinAccountForms.xml the values in the field
> glAccountId are sorted on the primary key, per
> {code:java}
>
>
> key-field-name="glAccountId" description="${accountCode} - ${accountName}
> [${glAccountId}]">
> operator="equals" env-name="defaultOrganizationPartyId"/>
>
>
>
>
> {code}
> The sort order should however be on the accountCode field of the entity
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10846) In AddFinAccountTrans selectable glAccountId values are sorted on glAccountId
[
https://issues.apache.org/jira/browse/OFBIZ-10846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788577#comment-16788577
]
Pierre Smits commented on OFBIZ-10846:
--
Every bug fix is an improvement.
Nevertheless, the patch looks ok to me.
Thanks for your assistance, [~pawan.verma]
> In AddFinAccountTrans selectable glAccountId values are sorted on glAccountId
> -
>
> Key: OFBIZ-10846
> URL: https://issues.apache.org/jira/browse/OFBIZ-10846
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk,
> Release Branch 15.12, 17.12.01, Release Branch 16.11, 16.11.04, 16.11.05,
> 16.11.06, Release Branch 17.12, Release Branch 18.12, 18.12.01
>Reporter: Pierre Smits
>Assignee: Pawan Verma
>Priority: Major
> Attachments: OFBIZ-10846.patch
>
>
> In the AddFinAccountTrans form in FinAccountForms.xml the values in the field
> glAccountId are sorted on the primary key, per
> {code:java}
>
>
> key-field-name="glAccountId" description="${accountCode} - ${accountName}
> [${glAccountId}]">
> operator="equals" env-name="defaultOrganizationPartyId"/>
>
>
>
>
> {code}
> The sort order should however be on the accountCode field of the entity
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10846) In AddFinAccountTrans selectable glAccountId values are sorted on glAccountId
[
https://issues.apache.org/jira/browse/OFBIZ-10846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788568#comment-16788568
]
Suraj Khurana commented on OFBIZ-10846:
---
Hello,
I think it should be an improvement rather than bug and we should change
affected version/s accordingly.
Just my two cents !!
> In AddFinAccountTrans selectable glAccountId values are sorted on glAccountId
> -
>
> Key: OFBIZ-10846
> URL: https://issues.apache.org/jira/browse/OFBIZ-10846
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk,
> Release Branch 15.12, 17.12.01, Release Branch 16.11, 16.11.04, 16.11.05,
> 16.11.06, Release Branch 17.12, Release Branch 18.12, 18.12.01
>Reporter: Pierre Smits
>Assignee: Pawan Verma
>Priority: Major
> Attachments: OFBIZ-10846.patch
>
>
> In the AddFinAccountTrans form in FinAccountForms.xml the values in the field
> glAccountId are sorted on the primary key, per
> {code:java}
>
>
> key-field-name="glAccountId" description="${accountCode} - ${accountName}
> [${glAccountId}]">
> operator="equals" env-name="defaultOrganizationPartyId"/>
>
>
>
>
> {code}
> The sort order should however be on the accountCode field of the entity
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10846) In AddFinAccountTrans selectable glAccountId values are sorted on glAccountId
[
https://issues.apache.org/jira/browse/OFBIZ-10846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788563#comment-16788563
]
Pawan Verma commented on OFBIZ-10846:
-
Yes, I also believe it should be accountCode instead of glAccountId. As
glAccountId is mostly system generated and accountCode is the right field to
order By GlAccounts.
Attaching patch for this improvement.
> In AddFinAccountTrans selectable glAccountId values are sorted on glAccountId
> -
>
> Key: OFBIZ-10846
> URL: https://issues.apache.org/jira/browse/OFBIZ-10846
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk,
> Release Branch 15.12, 17.12.01, Release Branch 16.11, 16.11.04, 16.11.05,
> 16.11.06, Release Branch 17.12, Release Branch 18.12, 18.12.01
>Reporter: Pierre Smits
>Assignee: Pawan Verma
>Priority: Major
> Attachments: OFBIZ-10846.patch
>
>
> In the AddFinAccountTrans form in FinAccountForms.xml the values in the field
> glAccountId are sorted on the primary key, per
> {code:java}
>
>
> key-field-name="glAccountId" description="${accountCode} - ${accountName}
> [${glAccountId}]">
> operator="equals" env-name="defaultOrganizationPartyId"/>
>
>
>
>
> {code}
> The sort order should however be on the accountCode field of the entity
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
