[jira] [Commented] (OFBIZ-10879) updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients from mail subject for general redirected mails

2020-01-29 Thread Ulrich Heidfeld (Jira) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-10879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17025770#comment-17025770
 ] 

Ulrich Heidfeld commented on OFBIZ-10879:
-

Hi [~deepak],

we have explict updated parameters toString, ccString and bccString, because in 
our integration testing system with some non-demo data, in value 
communicationEvent.toString is not the original sendTo mail address set. If we 
have redirectTo active, in communicationEvent.toString will set redirections 
mail address. Techicaly, this is correct, but to simulated a productive system, 
this is not correct.

> updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients 
> from mail subject for general redirected mails
> ---
>
> Key: OFBIZ-10879
> URL: https://issues.apache.org/jira/browse/OFBIZ-10879
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Attachments: OFBIZ-10879.patch, OFBIZ-10879.patch
>
>
> "updateCommEventAfterEmail" method in CommunicationEventServices.java could 
> generate  wrong result. If general.properties value 
> "mail.notifications.redirectTo" is used, it is possible that the subject 
> string has more than 255 character. 
> Now:
> {code:java}
> Original subject [To: , Cc: , Bcc: ]
> {code}
> Solution:
> {code:java}
> Original subject [RedirectedTo: recipi...@example.com]
> {code}
> In this way we have fixed this in one of our OFBiz forks. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-10879) updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients from mail subject for general redirected mails

2020-01-28 Thread Pawan Verma (Jira) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-10879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17025661#comment-17025661
 ] 

Pawan Verma commented on OFBIZ-10879:
-

Thanks, [~deepak] for the input.

I've reverted it at:
Trunk: 8902637669f85669c9191718cabc543c24d1f489
R18: df64a3b31e68e2e314331a99a898f487348301b6
R17: a2735318232cbe2518e3c05f7f026ac5ec55a29a

[~uHeidfeld] , Can you please address Deepak's comment?

> updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients 
> from mail subject for general redirected mails
> ---
>
> Key: OFBIZ-10879
> URL: https://issues.apache.org/jira/browse/OFBIZ-10879
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: 17.12.01, Upcoming Branch, 18.12.01
>
> Attachments: OFBIZ-10879.patch, OFBIZ-10879.patch
>
>
> "updateCommEventAfterEmail" method in CommunicationEventServices.java could 
> generate  wrong result. If general.properties value 
> "mail.notifications.redirectTo" is used, it is possible that the subject 
> string has more than 255 character. 
> Now:
> {code:java}
> Original subject [To: , Cc: , Bcc: ]
> {code}
> Solution:
> {code:java}
> Original subject [RedirectedTo: recipi...@example.com]
> {code}
> In this way we have fixed this in one of our OFBiz forks. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-10879) updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients from mail subject for general redirected mails

2020-01-28 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-10879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17025658#comment-17025658
 ] 

ASF subversion and git services commented on OFBIZ-10879:
-

Commit a2735318232cbe2518e3c05f7f026ac5ec55a29a in ofbiz-framework's branch 
refs/heads/release17.12 from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a273531 ]

Revert "Fixed: Potensial bug under 
CommunicationEventServices#updateCommEventAfterEmail for 
CommunicationEvent.subject field"
(OFBIZ-10879)

This reverts commit 9706acf064e26c291c0bd10081df8286ae6b359b.


> updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients 
> from mail subject for general redirected mails
> ---
>
> Key: OFBIZ-10879
> URL: https://issues.apache.org/jira/browse/OFBIZ-10879
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: 17.12.01, Upcoming Branch, 18.12.01
>
> Attachments: OFBIZ-10879.patch, OFBIZ-10879.patch
>
>
> "updateCommEventAfterEmail" method in CommunicationEventServices.java could 
> generate  wrong result. If general.properties value 
> "mail.notifications.redirectTo" is used, it is possible that the subject 
> string has more than 255 character. 
> Now:
> {code:java}
> Original subject [To: , Cc: , Bcc: ]
> {code}
> Solution:
> {code:java}
> Original subject [RedirectedTo: recipi...@example.com]
> {code}
> In this way we have fixed this in one of our OFBiz forks. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-10879) updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients from mail subject for general redirected mails

2020-01-28 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-10879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17025656#comment-17025656
 ] 

ASF subversion and git services commented on OFBIZ-10879:
-

Commit df64a3b31e68e2e314331a99a898f487348301b6 in ofbiz-framework's branch 
refs/heads/release18.12 from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=df64a3b ]

Revert "Fixed: Potensial bug under 
CommunicationEventServices#updateCommEventAfterEmail for 
CommunicationEvent.subject field"
(OFBIZ-10879)

This reverts commit bbcc4692dccdf573aa0205f927b56bc271719031.


> updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients 
> from mail subject for general redirected mails
> ---
>
> Key: OFBIZ-10879
> URL: https://issues.apache.org/jira/browse/OFBIZ-10879
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: 17.12.01, Upcoming Branch, 18.12.01
>
> Attachments: OFBIZ-10879.patch, OFBIZ-10879.patch
>
>
> "updateCommEventAfterEmail" method in CommunicationEventServices.java could 
> generate  wrong result. If general.properties value 
> "mail.notifications.redirectTo" is used, it is possible that the subject 
> string has more than 255 character. 
> Now:
> {code:java}
> Original subject [To: , Cc: , Bcc: ]
> {code}
> Solution:
> {code:java}
> Original subject [RedirectedTo: recipi...@example.com]
> {code}
> In this way we have fixed this in one of our OFBiz forks. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-10879) updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients from mail subject for general redirected mails

2020-01-28 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-10879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17025654#comment-17025654
 ] 

ASF subversion and git services commented on OFBIZ-10879:
-

Commit 8902637669f85669c9191718cabc543c24d1f489 in ofbiz-framework's branch 
refs/heads/trunk from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=8902637 ]

Revert "Fixed: Potensial bug under 
CommunicationEventServices#updateCommEventAfterEmail for 
CommunicationEvent.subject field"
(OFBIZ-10879)

This reverts commit 832076ce91dbca182ffab38d27ea72ca5e2cb0be.


> updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients 
> from mail subject for general redirected mails
> ---
>
> Key: OFBIZ-10879
> URL: https://issues.apache.org/jira/browse/OFBIZ-10879
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: 17.12.01, Upcoming Branch, 18.12.01
>
> Attachments: OFBIZ-10879.patch, OFBIZ-10879.patch
>
>
> "updateCommEventAfterEmail" method in CommunicationEventServices.java could 
> generate  wrong result. If general.properties value 
> "mail.notifications.redirectTo" is used, it is possible that the subject 
> string has more than 255 character. 
> Now:
> {code:java}
> Original subject [To: , Cc: , Bcc: ]
> {code}
> Solution:
> {code:java}
> Original subject [RedirectedTo: recipi...@example.com]
> {code}
> In this way we have fixed this in one of our OFBiz forks. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-10879) updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients from mail subject for general redirected mails

2020-01-25 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-10879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17023505#comment-17023505
 ] 

ASF subversion and git services commented on OFBIZ-10879:
-

Commit 9706acf064e26c291c0bd10081df8286ae6b359b in ofbiz-framework's branch 
refs/heads/release17.12 from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=9706acf ]

Fixed: Potensial bug under CommunicationEventServices#updateCommEventAfterEmail 
for CommunicationEvent.subject field
(OFBIZ-10879)

CommunicationEventServices#updateCommEventAfterEmail could generate wrong 
result. If general.properties value 'mail.notifications.redirectTo' is used, it 
is possible that the subject string has more than 255 character.

Thanks, Ulrich Heidfeld for your contribution.


> updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients 
> from mail subject for general redirected mails
> ---
>
> Key: OFBIZ-10879
> URL: https://issues.apache.org/jira/browse/OFBIZ-10879
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-10879.patch, OFBIZ-10879.patch
>
>
> "updateCommEventAfterEmail" method in CommunicationEventServices.java could 
> generate  wrong result. If general.properties value 
> "mail.notifications.redirectTo" is used, it is possible that the subject 
> string has more than 255 character. 
> Now:
> {code:java}
> Original subject [To: , Cc: , Bcc: ]
> {code}
> Solution:
> {code:java}
> Original subject [RedirectedTo: recipi...@example.com]
> {code}
> In this way we have fixed this in one of our OFBiz forks. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-10879) updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients from mail subject for general redirected mails

2020-01-25 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-10879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17023503#comment-17023503
 ] 

ASF subversion and git services commented on OFBIZ-10879:
-

Commit bbcc4692dccdf573aa0205f927b56bc271719031 in ofbiz-framework's branch 
refs/heads/release18.12 from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=bbcc469 ]

Fixed: Potensial bug under CommunicationEventServices#updateCommEventAfterEmail 
for CommunicationEvent.subject field
(OFBIZ-10879)

CommunicationEventServices#updateCommEventAfterEmail could generate wrong 
result. If general.properties value 'mail.notifications.redirectTo' is used, it 
is possible that the subject string has more than 255 character.

Thanks, Ulrich Heidfeld for your contribution.


> updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients 
> from mail subject for general redirected mails
> ---
>
> Key: OFBIZ-10879
> URL: https://issues.apache.org/jira/browse/OFBIZ-10879
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-10879.patch, OFBIZ-10879.patch
>
>
> "updateCommEventAfterEmail" method in CommunicationEventServices.java could 
> generate  wrong result. If general.properties value 
> "mail.notifications.redirectTo" is used, it is possible that the subject 
> string has more than 255 character. 
> Now:
> {code:java}
> Original subject [To: , Cc: , Bcc: ]
> {code}
> Solution:
> {code:java}
> Original subject [RedirectedTo: recipi...@example.com]
> {code}
> In this way we have fixed this in one of our OFBiz forks. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-10879) updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients from mail subject for general redirected mails

2020-01-25 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-10879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17023501#comment-17023501
 ] 

ASF subversion and git services commented on OFBIZ-10879:
-

Commit 832076ce91dbca182ffab38d27ea72ca5e2cb0be in ofbiz-framework's branch 
refs/heads/trunk from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=832076c ]

Fixed: Potensial bug under CommunicationEventServices#updateCommEventAfterEmail 
for CommunicationEvent.subject field
(OFBIZ-10879)

CommunicationEventServices#updateCommEventAfterEmail could generate wrong 
result. If general.properties value 'mail.notifications.redirectTo' is used, it 
is possible that the subject string has more than 255 character.

Thanks, Ulrich Heidfeld for your contribution.


> updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients 
> from mail subject for general redirected mails
> ---
>
> Key: OFBIZ-10879
> URL: https://issues.apache.org/jira/browse/OFBIZ-10879
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-10879.patch, OFBIZ-10879.patch
>
>
> "updateCommEventAfterEmail" method in CommunicationEventServices.java could 
> generate  wrong result. If general.properties value 
> "mail.notifications.redirectTo" is used, it is possible that the subject 
> string has more than 255 character. 
> Now:
> {code:java}
> Original subject [To: , Cc: , Bcc: ]
> {code}
> Solution:
> {code:java}
> Original subject [RedirectedTo: recipi...@example.com]
> {code}
> In this way we have fixed this in one of our OFBiz forks. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-10879) updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients from mail subject for general redirected mails

2019-04-01 Thread Ulrich Heidfeld (JIRA) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-10879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806483#comment-16806483
 ] 

Ulrich Heidfeld commented on OFBIZ-10879:
-

Hi, i have updated the affected version

> updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients 
> from mail subject for general redirected mails
> ---
>
> Key: OFBIZ-10879
> URL: https://issues.apache.org/jira/browse/OFBIZ-10879
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Attachments: OFBIZ-10879.patch, OFBIZ-10879.patch
>
>
> "updateCommEventAfterEmail" method in CommunicationEventServices.java could 
> generate  wrong result. If general.properties value 
> "mail.notifications.redirectTo" is used, it is possible that the subject 
> string has more than 255 character. 
> Now:
> {code:java}
> Original subject [To: , Cc: , Bcc: ]
> {code}
> Solution:
> {code:java}
> Original subject [RedirectedTo: recipi...@example.com]
> {code}
> In this way we have fixed this in one of our OFBiz forks. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OFBIZ-10879) updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients from mail subject for general redirected mails

2019-04-01 Thread Suraj Khurana (JIRA) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-10879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806424#comment-16806424
 ] 

Suraj Khurana commented on OFBIZ-10879:
---

Hello [~uHeidfeld],

Please update affect version/s so that this bug can be addressed.

Thanks in advance.

> updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients 
> from mail subject for general redirected mails
> ---
>
> Key: OFBIZ-10879
> URL: https://issues.apache.org/jira/browse/OFBIZ-10879
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Attachments: OFBIZ-10879.patch, OFBIZ-10879.patch
>
>
> "updateCommEventAfterEmail" method in CommunicationEventServices.java could 
> generate  wrong result. If general.properties value 
> "mail.notifications.redirectTo" is used, it is possible that the subject 
> string has more than 255 character. 
> Now:
> {code:java}
> Original subject [To: , Cc: , Bcc: ]
> {code}
> Solution:
> {code:java}
> Original subject [RedirectedTo: recipi...@example.com]
> {code}
> In this way we have fixed this in one of our OFBiz forks. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OFBIZ-10879) updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients from mail subject for general redirected mails

2019-03-30 Thread Pawan Verma (JIRA) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-10879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805651#comment-16805651
 ] 

Pawan Verma commented on OFBIZ-10879:
-

Hi [~uHeidfeld] ,

 

Your approach and patch look good to me, I have slightly updated patch and used 
EntityUtilProperties instead of UtilProperties. 

> updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients 
> from mail subject for general redirected mails
> ---
>
> Key: OFBIZ-10879
> URL: https://issues.apache.org/jira/browse/OFBIZ-10879
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Attachments: OFBIZ-10879.patch, OFBIZ-10879.patch
>
>
> "updateCommEventAfterEmail" method in CommunicationEventServices.java could 
> generate  wrong result. If general.properties value 
> "mail.notifications.redirectTo" is used, it is possible that the subject 
> string has more than 255 character. 
> Now:
> {code:java}
> Original subject [To: , Cc: , Bcc: ]
> {code}
> Solution:
> {code:java}
> Original subject [RedirectedTo: recipi...@example.com]
> {code}
> In this way we have fixed this in one of our OFBiz forks. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OFBIZ-10879) updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients from mail subject for general redirected mails

2019-03-29 Thread Ulrich Heidfeld (JIRA) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-10879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805045#comment-16805045
 ] 

Ulrich Heidfeld commented on OFBIZ-10879:
-

Hi, this patch cuts subject string in three parts (To, Cc, Bcc). Each part will 
be respectively put in string (To in toString, Cc in ccString, Bcc in 
bccString) to prevent an error. 

> updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients 
> from mail subject for general redirected mails
> ---
>
> Key: OFBIZ-10879
> URL: https://issues.apache.org/jira/browse/OFBIZ-10879
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Attachments: OFBIZ-10879.patch
>
>
> "updateCommEventAfterEmail" method in CommunicationEventServices.java could 
> generate  wrong result. If general.properties value 
> "mail.notifications.redirectTo" is used, it is possible that the subject 
> string has more than 255 character. 
> Now:
> {code:java}
> Original subject [To: , Cc: , Bcc: ]
> {code}
> Solution:
> {code:java}
> Original subject [RedirectedTo: recipi...@example.com]
> {code}
> In this way we have fixed this in one of our OFBiz forks. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)