[jira] [Commented] (OFBIZ-10939) @Override annotations should be used when possible
[ https://issues.apache.org/jira/browse/OFBIZ-10939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823806#comment-16823806 ] Jacques Le Roux commented on OFBIZ-10939: - I did not review it all, but the principe is good: +1 > @Override annotations should be used when possible > -- > > Key: OFBIZ-10939 > URL: https://issues.apache.org/jira/browse/OFBIZ-10939 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10939_Use-the-Override-annotation.patch > > > The ‘@Override’ annotation helps readers to understand that the method > at hand is overriding a super class or implementing an interface. > Additionally it allows the compiler to check if the methods annotated > with ‘@Override’ are actually implementing an abstract method. > Using that annotation makes ‘@see foo.bar.ParentClass#myMethod’ > comments useless. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10939) @Override annotations should be used when possible
[ https://issues.apache.org/jira/browse/OFBIZ-10939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823691#comment-16823691 ] Swapnil M Mane commented on OFBIZ-10939: Hi [~mthl] , On cursery view, the patch looks good to me, +1 to proceed with this change. Thanks for your work! > @Override annotations should be used when possible > -- > > Key: OFBIZ-10939 > URL: https://issues.apache.org/jira/browse/OFBIZ-10939 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10939_Use-the-Override-annotation.patch > > > The ‘@Override’ annotation helps readers to understand that the method > at hand is overriding a super class or implementing an interface. > Additionally it allows the compiler to check if the methods annotated > with ‘@Override’ are actually implementing an abstract method. > Using that annotation makes ‘@see foo.bar.ParentClass#myMethod’ > comments useless. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10939) @Override annotations should be used when possible
[ https://issues.apache.org/jira/browse/OFBIZ-10939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822711#comment-16822711 ] Mathieu Lirzin commented on OFBIZ-10939: I will wait a couple a days for comments before committing [^OFBIZ-10939_Use-the-Override-annotation.patch] > @Override annotations should be used when possible > -- > > Key: OFBIZ-10939 > URL: https://issues.apache.org/jira/browse/OFBIZ-10939 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10939_Use-the-Override-annotation.patch > > > The ‘@Override’ annotation helps readers to understand that the method > at hand is overriding a super class or implementing an interface. > Additionally it allows the compiler to check if the methods annotated > with ‘@Override’ are actually implementing an abstract method. > Using that annotation makes ‘@see foo.bar.ParentClass#myMethod’ > comments useless. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
