[jira] [Commented] (OFBIZ-10973) Rename custom component for SMS gateway integration
[
https://issues.apache.org/jira/browse/OFBIZ-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169300#comment-17169300
]
Jacques Le Roux commented on OFBIZ-10973:
-
Thanks for the explanation Pritam.
> Rename custom component for SMS gateway integration
> ---
>
> Key: OFBIZ-10973
> URL: https://issues.apache.org/jira/browse/OFBIZ-10973
> Project: OFBiz
> Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Priority: Major
>
> As per the comment by [~jacques.le.roux] on the commit log of the SMS gateway
> integration:
> {quote}
> "In understand that this component currently uses "msg91 services to send
> sms".
> But could we not have another name, more explicit, for this component, like
> sms or sendsms for instance?
> Services tend to disappear or change (Google is the best example). So I'd not
> associate the name of an open source component to a commercial services
> provider (with a free SMS quota option). Even if hopefully it will stay as
> is..."
> {quote}
> Need to rename the custom component and replace all occurrences in code level.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-10973) Rename custom component for SMS gateway integration
[
https://issues.apache.org/jira/browse/OFBIZ-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169282#comment-17169282
]
Pritam Kute commented on OFBIZ-10973:
-
Hello [~pawan], we can rename this plugin to "sms-msg91" which is suggested by
[~jleroux].
[~jleroux] the initial thought behind having this integration in place was to
have common code in the framework which could be so generic that users can
build any custom plugin and call framework methods to send SMS, WhatsApp
message or even a message on Facebook messenger. So that's why we had called it
"msggateway". But now, I think as it is an independent plugin and all generic
code is in the framework itself, we can rename this plugin as sms-msg91
> Rename custom component for SMS gateway integration
> ---
>
> Key: OFBIZ-10973
> URL: https://issues.apache.org/jira/browse/OFBIZ-10973
> Project: OFBiz
> Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Priority: Major
>
> As per the comment by [~jacques.le.roux] on the commit log of the SMS gateway
> integration:
> {quote}
> "In understand that this component currently uses "msg91 services to send
> sms".
> But could we not have another name, more explicit, for this component, like
> sms or sendsms for instance?
> Services tend to disappear or change (Google is the best example). So I'd not
> associate the name of an open source component to a commercial services
> provider (with a free SMS quota option). Even if hopefully it will stay as
> is..."
> {quote}
> Need to rename the custom component and replace all occurrences in code level.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-10973) Rename custom component for SMS gateway integration
[
https://issues.apache.org/jira/browse/OFBIZ-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168846#comment-17168846
]
Jacques Le Roux commented on OFBIZ-10973:
-
Could we not have sms in the name, to clearly shows that it's for sending
SMS... something like sms-msg91...?
> Rename custom component for SMS gateway integration
> ---
>
> Key: OFBIZ-10973
> URL: https://issues.apache.org/jira/browse/OFBIZ-10973
> Project: OFBiz
> Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Priority: Major
>
> As per the comment by [~jacques.le.roux] on the commit log of the SMS gateway
> integration:
> {quote}
> "In understand that this component currently uses "msg91 services to send
> sms".
> But could we not have another name, more explicit, for this component, like
> sms or sendsms for instance?
> Services tend to disappear or change (Google is the best example). So I'd not
> associate the name of an open source component to a commercial services
> provider (with a free SMS quota option). Even if hopefully it will stay as
> is..."
> {quote}
> Need to rename the custom component and replace all occurrences in code level.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-10973) Rename custom component for SMS gateway integration
[
https://issues.apache.org/jira/browse/OFBIZ-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168724#comment-17168724
]
Pawan Verma commented on OFBIZ-10973:
-
Hi [~pritam.kute]
I second [~mbrohl] here with name msggateway-msg91, WDYT?
> Rename custom component for SMS gateway integration
> ---
>
> Key: OFBIZ-10973
> URL: https://issues.apache.org/jira/browse/OFBIZ-10973
> Project: OFBiz
> Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Priority: Major
>
> As per the comment by [~jacques.le.roux] on the commit log of the SMS gateway
> integration:
> {quote}
> "In understand that this component currently uses "msg91 services to send
> sms".
> But could we not have another name, more explicit, for this component, like
> sms or sendsms for instance?
> Services tend to disappear or change (Google is the best example). So I'd not
> associate the name of an open source component to a commercial services
> provider (with a free SMS quota option). Even if hopefully it will stay as
> is..."
> {quote}
> Need to rename the custom component and replace all occurrences in code level.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-10973) Rename custom component for SMS gateway integration
[
https://issues.apache.org/jira/browse/OFBIZ-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028093#comment-17028093
]
Michael Brohl commented on OFBIZ-10973:
---
Isn't the implementation explicitely for the third party provider msg91? IMO
this is the same case as a PayPal or WorldPay integration.
Renaming to just msggateway is more confusing because it reads as if it is a
generic msg gateway functionality.
I would suggest to rename it to msggateway-msg91 which allows to have other
future msg gateway components with the same naming scheme.
> Rename custom component for SMS gateway integration
> ---
>
> Key: OFBIZ-10973
> URL: https://issues.apache.org/jira/browse/OFBIZ-10973
> Project: OFBiz
> Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Priority: Major
>
> As per the comment by [~jacques.le.roux] on the commit log of the SMS gateway
> integration:
> {quote}
> "In understand that this component currently uses "msg91 services to send
> sms".
> But could we not have another name, more explicit, for this component, like
> sms or sendsms for instance?
> Services tend to disappear or change (Google is the best example). So I'd not
> associate the name of an open source component to a commercial services
> provider (with a free SMS quota option). Even if hopefully it will stay as
> is..."
> {quote}
> Need to rename the custom component and replace all occurrences in code level.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-10973) Rename custom component for SMS gateway integration
[
https://issues.apache.org/jira/browse/OFBIZ-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827871#comment-16827871
]
Rishi Solanki commented on OFBIZ-10973:
---
[~pritam.kute]
I have committed the base changes in revision 1858279 and 1858307. Please do
the planned changes as per your plan. Thanks for your contribution.
> Rename custom component for SMS gateway integration
> ---
>
> Key: OFBIZ-10973
> URL: https://issues.apache.org/jira/browse/OFBIZ-10973
> Project: OFBiz
> Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Assignee: vivek singh bisen
>Priority: Major
>
> As per the comment by [~jacques.le.roux] on the commit log of the SMS gateway
> integration:
> {quote}
> "In understand that this component currently uses "msg91 services to send
> sms".
> But could we not have another name, more explicit, for this component, like
> sms or sendsms for instance?
> Services tend to disappear or change (Google is the best example). So I'd not
> associate the name of an open source component to a commercial services
> provider (with a free SMS quota option). Even if hopefully it will stay as
> is..."
> {quote}
> Need to rename the custom component and replace all occurrences in code level.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
