[jira] [Commented] (OFBIZ-11014) StringUtil cleanup
[
https://issues.apache.org/jira/browse/OFBIZ-11014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819573#comment-17819573
]
ASF subversion and git services commented on OFBIZ-11014:
-
Commit 65be575cdd1a2712a0e9b38603f4339952d79f60 in ofbiz-framework's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=65be575cdd ]
Improved: Migrate integration tests to unit tests when possible (OFBIZ-11067)
As mentioned by Mathieu in (OFBIZ-11014)
https://github.com/apache/ofbiz-framework/commit/aa874841cea2652dc193b919120fa77a9d50184f
<>
It uses @Ignore("Failing test") so better remove it
> StringUtil cleanup
> --
>
> Key: OFBIZ-11014
> URL: https://issues.apache.org/jira/browse/OFBIZ-11014
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Attachments:
> OFBIZ-11014_0001-Remove-useless-StringUtil-join-overload.patch,
> OFBIZ-11014_0002-Rewrite-StringUtil-join-method.patch,
> OFBIZ-11014_0003-Remove-unused-StringUtil-append-method.patch,
> OFBIZ-11014_0004-Remove-unused-StringUtil-split-overload.patch,
> OFBIZ-11014_0005-Inline-StringUtil-quoteStrList-method.patch,
> OFBIZ-11014_0006-Remove-unused-StringUtil-strToMap-overload.patch,
> OFBIZ-11014_0007-Remove-unused-StringUtil-mapToStr-method.patch,
> OFBIZ-11014_0008-Remove-unused-StringUtil-convertChar-method.patch,
> OFBIZ-11014_0009-Remove-unused-StringUtil-removeNumeric-meth.patch,
> OFBIZ-11014_0010-Remove-unused-StringUtil-collapseNewlines-m.patch,
> OFBIZ-11014_0011-Remove-unused-StringUtil-collapseSpaces-met.patch,
> OFBIZ-11014_0012-Remove-unused-StringUtil-collapseCharacter.patch,
> OFBIZ-11014_0013-Remove-unused-StringUtil-appendTo-methods.patch,
> OFBIZ-11014_0014-Turn-StringUtilTests-into-a-unit-test.patch,
> OFBIZ-11014_0015-Inline-StringUtil-toMap.patch
>
>
> {{StringUtil}} contains stuff that is not useful with recent version of Java.
> For example the {{StringUtil#split}} method could be replaced by the
> {{String#split}} method. As a consequence {{StringUtil}} should be cleaned up.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-11014) StringUtil cleanup
[
https://issues.apache.org/jira/browse/OFBIZ-11014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859399#comment-16859399
]
Jacques Le Roux commented on OFBIZ-11014:
-
+1
> StringUtil cleanup
> --
>
> Key: OFBIZ-11014
> URL: https://issues.apache.org/jira/browse/OFBIZ-11014
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Attachments:
> OFBIZ-11014_0001-Remove-useless-StringUtil-join-overload.patch,
> OFBIZ-11014_0002-Rewrite-StringUtil-join-method.patch,
> OFBIZ-11014_0003-Remove-unused-StringUtil-append-method.patch,
> OFBIZ-11014_0004-Remove-unused-StringUtil-split-overload.patch,
> OFBIZ-11014_0005-Inline-StringUtil-quoteStrList-method.patch,
> OFBIZ-11014_0006-Remove-unused-StringUtil-strToMap-overload.patch,
> OFBIZ-11014_0007-Remove-unused-StringUtil-mapToStr-method.patch,
> OFBIZ-11014_0008-Remove-unused-StringUtil-convertChar-method.patch,
> OFBIZ-11014_0009-Remove-unused-StringUtil-removeNumeric-meth.patch,
> OFBIZ-11014_0010-Remove-unused-StringUtil-collapseNewlines-m.patch,
> OFBIZ-11014_0011-Remove-unused-StringUtil-collapseSpaces-met.patch,
> OFBIZ-11014_0012-Remove-unused-StringUtil-collapseCharacter.patch,
> OFBIZ-11014_0013-Remove-unused-StringUtil-appendTo-methods.patch,
> OFBIZ-11014_0014-Turn-StringUtilTests-into-a-unit-test.patch,
> OFBIZ-11014_0015-Inline-StringUtil-toMap.patch
>
>
> {{StringUtil}} contains stuff that is not useful with recent version of Java.
> For example the {{StringUtil#split}} method could be replaced by the
> {{String#split}} method. As a consequence {{StringUtil}} should be cleaned up.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-11014) StringUtil cleanup
[
https://issues.apache.org/jira/browse/OFBIZ-11014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859323#comment-16859323
]
Mathieu Lirzin commented on OFBIZ-11014:
‘StringUtil#toMap’ is only used in the ‘CollectionConverters.StringToMap’
converter so in order to clean ‘StringUtil’ it seems better to inline it. I
will commit [^OFBIZ-11014_0015-Inline-StringUtil-toMap.patch] which is doing
that in a couple of days if nobody disagrees.
> StringUtil cleanup
> --
>
> Key: OFBIZ-11014
> URL: https://issues.apache.org/jira/browse/OFBIZ-11014
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Attachments:
> OFBIZ-11014_0001-Remove-useless-StringUtil-join-overload.patch,
> OFBIZ-11014_0002-Rewrite-StringUtil-join-method.patch,
> OFBIZ-11014_0003-Remove-unused-StringUtil-append-method.patch,
> OFBIZ-11014_0004-Remove-unused-StringUtil-split-overload.patch,
> OFBIZ-11014_0005-Inline-StringUtil-quoteStrList-method.patch,
> OFBIZ-11014_0006-Remove-unused-StringUtil-strToMap-overload.patch,
> OFBIZ-11014_0007-Remove-unused-StringUtil-mapToStr-method.patch,
> OFBIZ-11014_0008-Remove-unused-StringUtil-convertChar-method.patch,
> OFBIZ-11014_0009-Remove-unused-StringUtil-removeNumeric-meth.patch,
> OFBIZ-11014_0010-Remove-unused-StringUtil-collapseNewlines-m.patch,
> OFBIZ-11014_0011-Remove-unused-StringUtil-collapseSpaces-met.patch,
> OFBIZ-11014_0012-Remove-unused-StringUtil-collapseCharacter.patch,
> OFBIZ-11014_0013-Remove-unused-StringUtil-appendTo-methods.patch,
> OFBIZ-11014_0014-Turn-StringUtilTests-into-a-unit-test.patch,
> OFBIZ-11014_0015-Inline-StringUtil-toMap.patch
>
>
> {{StringUtil}} contains stuff that is not useful with recent version of Java.
> For example the {{StringUtil#split}} method could be replaced by the
> {{String#split}} method. As a consequence {{StringUtil}} should be cleaned up.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-11014) StringUtil cleanup
[
https://issues.apache.org/jira/browse/OFBIZ-11014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848129#comment-16848129
]
Swapnil M Mane commented on OFBIZ-11014:
Thank you!
> StringUtil cleanup
> --
>
> Key: OFBIZ-11014
> URL: https://issues.apache.org/jira/browse/OFBIZ-11014
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Attachments:
> OFBIZ-11014_0001-Remove-useless-StringUtil-join-overload.patch,
> OFBIZ-11014_0002-Rewrite-StringUtil-join-method.patch,
> OFBIZ-11014_0003-Remove-unused-StringUtil-append-method.patch,
> OFBIZ-11014_0004-Remove-unused-StringUtil-split-overload.patch,
> OFBIZ-11014_0005-Inline-StringUtil-quoteStrList-method.patch,
> OFBIZ-11014_0006-Remove-unused-StringUtil-strToMap-overload.patch,
> OFBIZ-11014_0007-Remove-unused-StringUtil-mapToStr-method.patch,
> OFBIZ-11014_0008-Remove-unused-StringUtil-convertChar-method.patch,
> OFBIZ-11014_0009-Remove-unused-StringUtil-removeNumeric-meth.patch,
> OFBIZ-11014_0010-Remove-unused-StringUtil-collapseNewlines-m.patch,
> OFBIZ-11014_0011-Remove-unused-StringUtil-collapseSpaces-met.patch,
> OFBIZ-11014_0012-Remove-unused-StringUtil-collapseCharacter.patch,
> OFBIZ-11014_0013-Remove-unused-StringUtil-appendTo-methods.patch,
> OFBIZ-11014_0014-Turn-StringUtilTests-into-a-unit-test.patch
>
>
> {{StringUtil}} contains stuff that is not useful with recent version of Java.
> For example the {{StringUtil#split}} method could be replaced by the
> {{String#split}} method. As a consequence {{StringUtil}} should be cleaned up.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-11014) StringUtil cleanup
[
https://issues.apache.org/jira/browse/OFBIZ-11014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848126#comment-16848126
]
Mathieu Lirzin commented on OFBIZ-11014:
Hello [~swapnilmmane],
done, thanks for suggesting.
> StringUtil cleanup
> --
>
> Key: OFBIZ-11014
> URL: https://issues.apache.org/jira/browse/OFBIZ-11014
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Attachments:
> OFBIZ-11014_0001-Remove-useless-StringUtil-join-overload.patch,
> OFBIZ-11014_0002-Rewrite-StringUtil-join-method.patch,
> OFBIZ-11014_0003-Remove-unused-StringUtil-append-method.patch,
> OFBIZ-11014_0004-Remove-unused-StringUtil-split-overload.patch,
> OFBIZ-11014_0005-Inline-StringUtil-quoteStrList-method.patch,
> OFBIZ-11014_0006-Remove-unused-StringUtil-strToMap-overload.patch,
> OFBIZ-11014_0007-Remove-unused-StringUtil-mapToStr-method.patch,
> OFBIZ-11014_0008-Remove-unused-StringUtil-convertChar-method.patch,
> OFBIZ-11014_0009-Remove-unused-StringUtil-removeNumeric-meth.patch,
> OFBIZ-11014_0010-Remove-unused-StringUtil-collapseNewlines-m.patch,
> OFBIZ-11014_0011-Remove-unused-StringUtil-collapseSpaces-met.patch,
> OFBIZ-11014_0012-Remove-unused-StringUtil-collapseCharacter.patch,
> OFBIZ-11014_0013-Remove-unused-StringUtil-appendTo-methods.patch,
> OFBIZ-11014_0014-Turn-StringUtilTests-into-a-unit-test.patch
>
>
> {{StringUtil}} contains stuff that is not useful with recent version of Java.
> For example the {{StringUtil#split}} method could be replaced by the
> {{String#split}} method. As a consequence {{StringUtil}} should be cleaned up.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-11014) StringUtil cleanup
[
https://issues.apache.org/jira/browse/OFBIZ-11014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848119#comment-16848119
]
Swapnil M Mane commented on OFBIZ-11014:
Dear [~mthl] ,
Thanks so much for your contribution, highly appriciated.
As you know, we are celebrating OFBiz community days event from 24th – 28th May.
Can you please set the Sprint of this ticket (and also in the other tickets) to
"OFBiz Community Day (May 2019)".
This will helps us track and report on the work done during the Community Days.
Please let me know if you need any help from myside.
Thank you!
> StringUtil cleanup
> --
>
> Key: OFBIZ-11014
> URL: https://issues.apache.org/jira/browse/OFBIZ-11014
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Attachments:
> OFBIZ-11014_0001-Remove-useless-StringUtil-join-overload.patch,
> OFBIZ-11014_0002-Rewrite-StringUtil-join-method.patch,
> OFBIZ-11014_0003-Remove-unused-StringUtil-append-method.patch,
> OFBIZ-11014_0004-Remove-unused-StringUtil-split-overload.patch,
> OFBIZ-11014_0005-Inline-StringUtil-quoteStrList-method.patch,
> OFBIZ-11014_0006-Remove-unused-StringUtil-strToMap-overload.patch,
> OFBIZ-11014_0007-Remove-unused-StringUtil-mapToStr-method.patch,
> OFBIZ-11014_0008-Remove-unused-StringUtil-convertChar-method.patch,
> OFBIZ-11014_0009-Remove-unused-StringUtil-removeNumeric-meth.patch,
> OFBIZ-11014_0010-Remove-unused-StringUtil-collapseNewlines-m.patch,
> OFBIZ-11014_0011-Remove-unused-StringUtil-collapseSpaces-met.patch,
> OFBIZ-11014_0012-Remove-unused-StringUtil-collapseCharacter.patch,
> OFBIZ-11014_0013-Remove-unused-StringUtil-appendTo-methods.patch,
> OFBIZ-11014_0014-Turn-StringUtilTests-into-a-unit-test.patch
>
>
> {{StringUtil}} contains stuff that is not useful with recent version of Java.
> For example the {{StringUtil#split}} method could be replaced by the
> {{String#split}} method. As a consequence {{StringUtil}} should be cleaned up.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-11014) StringUtil cleanup
[
https://issues.apache.org/jira/browse/OFBIZ-11014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848117#comment-16848117
]
Mathieu Lirzin commented on OFBIZ-11014:
Patch 1 to 14 has been commited on trunk on revisions:
r1859920 r1859921 r1859922 r1859923 r1859924 r1859925 r1859926 r1859927
r1859928 r1859929 r1859930 r1859932 r1859934
> StringUtil cleanup
> --
>
> Key: OFBIZ-11014
> URL: https://issues.apache.org/jira/browse/OFBIZ-11014
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Attachments:
> OFBIZ-11014_0001-Remove-useless-StringUtil-join-overload.patch,
> OFBIZ-11014_0002-Rewrite-StringUtil-join-method.patch,
> OFBIZ-11014_0003-Remove-unused-StringUtil-append-method.patch,
> OFBIZ-11014_0004-Remove-unused-StringUtil-split-overload.patch,
> OFBIZ-11014_0005-Inline-StringUtil-quoteStrList-method.patch,
> OFBIZ-11014_0006-Remove-unused-StringUtil-strToMap-overload.patch,
> OFBIZ-11014_0007-Remove-unused-StringUtil-mapToStr-method.patch,
> OFBIZ-11014_0008-Remove-unused-StringUtil-convertChar-method.patch,
> OFBIZ-11014_0009-Remove-unused-StringUtil-removeNumeric-meth.patch,
> OFBIZ-11014_0010-Remove-unused-StringUtil-collapseNewlines-m.patch,
> OFBIZ-11014_0011-Remove-unused-StringUtil-collapseSpaces-met.patch,
> OFBIZ-11014_0012-Remove-unused-StringUtil-collapseCharacter.patch,
> OFBIZ-11014_0013-Remove-unused-StringUtil-appendTo-methods.patch,
> OFBIZ-11014_0014-Turn-StringUtilTests-into-a-unit-test.patch
>
>
> {{StringUtil}} contains stuff that is not useful with recent version of Java.
> For example the {{StringUtil#split}} method could be replaced by the
> {{String#split}} method. As a consequence {{StringUtil}} should be cleaned up.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
