[jira] [Commented] (OFBIZ-11105) Add backward compatibility for inputParamEnumId in promotion management

2019-10-02 Thread Suraj Khurana (Jira) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-11105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942680#comment-16942680
 ] 

Suraj Khurana commented on OFBIZ-11105:
---

Committed slightly modified patch to OFBiz trunk at rev #1867879.

At release 18.12 at rev #1867880

Thanks: Lalit Dashora for reporting and providing the patch, Jacques Le Roux 
for review.

> Add backward compatibility for inputParamEnumId in promotion management
> ---
>
> Key: OFBIZ-11105
> URL: https://issues.apache.org/jira/browse/OFBIZ-11105
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk, Release Branch 18.12
>Reporter: Lalit Dashora
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: 18.12.01
>
> Attachments: OFBIZ-11105.patch, OFBIZ-11105.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11105) Add backward compatibility for inputParamEnumId in promotion management

2019-10-02 Thread Jacques Le Roux (Jira) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-11105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942672#comment-16942672
 ] 

Jacques Le Roux commented on OFBIZ-11105:
-

Fixed :)

> Add backward compatibility for inputParamEnumId in promotion management
> ---
>
> Key: OFBIZ-11105
> URL: https://issues.apache.org/jira/browse/OFBIZ-11105
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk, Release Branch 18.12
>Reporter: Lalit Dashora
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11105.patch, OFBIZ-11105.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11105) Add backward compatibility for inputParamEnumId in promotion management

2019-10-02 Thread Suraj Khurana (Jira) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-11105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942595#comment-16942595
 ] 

Suraj Khurana commented on OFBIZ-11105:
---

Thanks Jacques.

BTW, my name is Suraj :) 

> Add backward compatibility for inputParamEnumId in promotion management
> ---
>
> Key: OFBIZ-11105
> URL: https://issues.apache.org/jira/browse/OFBIZ-11105
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk, Release Branch 18.12
>Reporter: Lalit Dashora
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11105.patch, OFBIZ-11105.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11105) Add backward compatibility for inputParamEnumId in promotion management

2019-09-28 Thread Lalit Dashora (Jira) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-11105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16939938#comment-16939938
 ] 

Lalit Dashora commented on OFBIZ-11105:
---

Sure, Jacques, I will take care of patch format. Thanks!

> Add backward compatibility for inputParamEnumId in promotion management
> ---
>
> Key: OFBIZ-11105
> URL: https://issues.apache.org/jira/browse/OFBIZ-11105
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk, Release Branch 18.12
>Reporter: Lalit Dashora
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11105.patch, OFBIZ-11105.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11105) Add backward compatibility for inputParamEnumId in promotion management

2019-09-28 Thread Jacques Le Roux (Jira) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-11105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16939923#comment-16939923
 ] 

Jacques Le Roux commented on OFBIZ-11105:
-

Hi Lalit, Surag

After OFBIZ-10853 this patch no longer apply. Please find attached  
[^OFBIZ-11105.patch] . Also Lalit please use the standard patch format, not the 
Git one, thanks.

> Add backward compatibility for inputParamEnumId in promotion management
> ---
>
> Key: OFBIZ-11105
> URL: https://issues.apache.org/jira/browse/OFBIZ-11105
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk, Release Branch 18.12
>Reporter: Lalit Dashora
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11105.patch, OFBIZ-11105.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11105) Add backward compatibility for inputParamEnumId in promotion management

2019-06-22 Thread Lalit Dashora (JIRA) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-11105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870251#comment-16870251
 ] 

Lalit Dashora commented on OFBIZ-11105:
---

Hi,

I have done all the improvements related to the usage of inputParamEnumId and 
customMethodId in promotion management. Please find the attached patch. Here is 
the parent ticket OFBIZ-10370.

Thanks!

> Add backward compatibility for inputParamEnumId in promotion management
> ---
>
> Key: OFBIZ-11105
> URL: https://issues.apache.org/jira/browse/OFBIZ-11105
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Lalit Dashora
>Assignee: Lalit Dashora
>Priority: Major
> Attachments: OFBIZ-11105.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)