[jira] [Commented] (OFBIZ-11147) OFBiz-Camel integration
[ https://issues.apache.org/jira/browse/OFBIZ-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914844#comment-16914844 ] Girish Vasmatkar commented on OFBIZ-11147: -- [~adityasharma] : Thanks. I raised [https://github.com/bibryam/ofbiz-camel/pull/7] with Bilgin. > OFBiz-Camel integration > --- > > Key: OFBIZ-11147 > URL: https://issues.apache.org/jira/browse/OFBIZ-11147 > Project: OFBiz > Issue Type: New Feature >Affects Versions: Trunk >Reporter: Girish Vasmatkar >Assignee: Girish Vasmatkar >Priority: Minor > Attachments: ofbiz-camel.tar.gz > > > This OFBiz plug in will provide capability for OFBiz to integrate with Apache > Camel. The plug in should provide capability for OFBiz to interface with > various external systems via Apache Camel. > Similarly, the integration will allow inbound communication from external > system into OFBiz via Apache Camel. > Here's the list to the ML discussion thread - > [https://lists.apache.org/thread.html/36ee6e3d2425ecc5eed7cf44e41e27125f7263080870bacd72ae556e@%3Cuser.ofbiz.apache.org%3E] -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (OFBIZ-11147) OFBiz-Camel integration
[
https://issues.apache.org/jira/browse/OFBIZ-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914837#comment-16914837
]
Aditya Sharma commented on OFBIZ-11147:
---
Thanks Girish for looking into it. My bad. I tested for 16.11 and 17.12. It
works for the trunk.
I have updated the affected version. Thanks Pierre for pointing that out.
I noticed a warning:
{code:java}
ofbiz-camel/src/main/java/org/apache/ofbiz/camel/services/CamelServices.java:47:
warning: [unchecked] unchecked cast
Map headers = (Map) context.get("headers");
^
required: Map
found: Object
1 warning
{code}
I think we can suppress it with
[SuppressWarnings|https://docs.oracle.com/javase/6/docs/api/java/lang/SuppressWarnings.html]
annotation.
{code:java}
@SuppressWarnings("unchecked")
Map headers = (Map) context.get("headers");
{code}
> OFBiz-Camel integration
> ---
>
> Key: OFBIZ-11147
> URL: https://issues.apache.org/jira/browse/OFBIZ-11147
> Project: OFBiz
> Issue Type: New Feature
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Minor
> Attachments: ofbiz-camel.tar.gz
>
>
> This OFBiz plug in will provide capability for OFBiz to integrate with Apache
> Camel. The plug in should provide capability for OFBiz to interface with
> various external systems via Apache Camel.
> Similarly, the integration will allow inbound communication from external
> system into OFBiz via Apache Camel.
> Here's the list to the ML discussion thread -
> [https://lists.apache.org/thread.html/36ee6e3d2425ecc5eed7cf44e41e27125f7263080870bacd72ae556e@%3Cuser.ofbiz.apache.org%3E]
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (OFBIZ-11147) OFBiz-Camel integration
[ https://issues.apache.org/jira/browse/OFBIZ-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914305#comment-16914305 ] Girish Vasmatkar commented on OFBIZ-11147: -- [~adityasharma] : Thanks Aditya! The method in question is deprecated so used the one with only one argument. I am still able to compile the code with latest changes on TRUNK. Can you please check if your local copy has the below method (with single parameter) defined? I can see on trunk the method does exist. ContainerConfig.getConfiguration(String) > OFBiz-Camel integration > --- > > Key: OFBIZ-11147 > URL: https://issues.apache.org/jira/browse/OFBIZ-11147 > Project: OFBiz > Issue Type: New Feature >Reporter: Girish Vasmatkar >Assignee: Girish Vasmatkar >Priority: Minor > Fix For: Upcoming Branch > > Attachments: ofbiz-camel.tar.gz > > > This OFBiz plug in will provide capability for OFBiz to integrate with Apache > Camel. The plug in should provide capability for OFBiz to interface with > various external systems via Apache Camel. > Similarly, the integration will allow inbound communication from external > system into OFBiz via Apache Camel. > Here's the list to the ML discussion thread - > [https://lists.apache.org/thread.html/36ee6e3d2425ecc5eed7cf44e41e27125f7263080870bacd72ae556e@%3Cuser.ofbiz.apache.org%3E] -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (OFBIZ-11147) OFBiz-Camel integration
[
https://issues.apache.org/jira/browse/OFBIZ-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914284#comment-16914284
]
Aditya Sharma commented on OFBIZ-11147:
---
Thanks Girish and Bilgin for the amazing contribution :) It will indeed add a
lot of value.
I tried the plugin in the attached file and it fails on the build.
{code:java}
/ofbiz-camel/src/main/java/org/apache/ofbiz/camel/loader/CamelContainer.java:54:
error: method getConfiguration in class ContainerConfig cannot be applied to
given
types;/ofbiz-camel/src/main/java/org/apache/ofbiz/camel/loader/CamelContainer.java:54:
error: method getConfiguration in class ContainerConfig cannot be applied to
given types;> Building 0% > ContainerConfig.Configuration cfg =
ContainerConfig.getConfiguration(name);
^ required: String,String found: String reason: actual and formal
argument lists differ in length
{code}
I traced out it, it seems there are some changes in tar file from Github
[repository|https://github.com/bibryam/ofbiz-camel]
{code:java}
- ContainerConfig.Configuration cfg = ContainerConfig.getConfiguration(name,
configFile);
+ ContainerConfig.Configuration cfg = ContainerConfig.getConfiguration(name);
{code}
Other than that:
As runtime extends compile-time dependencies. There should be no need to again
add camel dependency as a runtime dependency.
See
[https://docs.gradle.org/2.12/userguide/java_plugin.html]
[https://docs.gradle.org/4.9/userguide/java_plugin.html#java_plugin]
I have raised a pull request for the same
[#6|https://github.com/bibryam/ofbiz-camel/pull/6]
> OFBiz-Camel integration
> ---
>
> Key: OFBIZ-11147
> URL: https://issues.apache.org/jira/browse/OFBIZ-11147
> Project: OFBiz
> Issue Type: New Feature
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: ofbiz-camel.tar.gz
>
>
> This OFBiz plug in will provide capability for OFBiz to integrate with Apache
> Camel. The plug in should provide capability for OFBiz to interface with
> various external systems via Apache Camel.
> Similarly, the integration will allow inbound communication from external
> system into OFBiz via Apache Camel.
> Here's the list to the ML discussion thread -
> [https://lists.apache.org/thread.html/36ee6e3d2425ecc5eed7cf44e41e27125f7263080870bacd72ae556e@%3Cuser.ofbiz.apache.org%3E]
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (OFBIZ-11147) OFBiz-Camel integration
[ https://issues.apache.org/jira/browse/OFBIZ-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16913217#comment-16913217 ] Pierre Smits commented on OFBIZ-11147: -- This ticket should not show a value in the 'Fix Version' field, as the field is set when the set of functionalities is incorporated in the code base. Instead set a value in the 'Affected Version' field. > OFBiz-Camel integration > --- > > Key: OFBIZ-11147 > URL: https://issues.apache.org/jira/browse/OFBIZ-11147 > Project: OFBiz > Issue Type: New Feature >Reporter: Girish Vasmatkar >Assignee: Girish Vasmatkar >Priority: Minor > Fix For: Upcoming Branch > > Attachments: ofbiz-camel.tar.gz > > > This OFBiz plug in will provide capability for OFBiz to integrate with Apache > Camel. The plug in should provide capability for OFBiz to interface with > various external systems via Apache Camel. > Similarly, the integration will allow inbound communication from external > system into OFBiz via Apache Camel. > Here's the list to the ML discussion thread - > [https://lists.apache.org/thread.html/36ee6e3d2425ecc5eed7cf44e41e27125f7263080870bacd72ae556e@%3Cuser.ofbiz.apache.org%3E] -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (OFBIZ-11147) OFBiz-Camel integration
[ https://issues.apache.org/jira/browse/OFBIZ-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905191#comment-16905191 ] Girish Vasmatkar commented on OFBIZ-11147: -- Attached is the ofbiz-camel plug in. It has added feature of auto discovery of Camel Routes on top of what [~bibryam] created. > OFBiz-Camel integration > --- > > Key: OFBIZ-11147 > URL: https://issues.apache.org/jira/browse/OFBIZ-11147 > Project: OFBiz > Issue Type: New Feature >Reporter: Girish Vasmatkar >Assignee: Girish Vasmatkar >Priority: Minor > Fix For: Upcoming Branch > > Attachments: ofbiz-camel.tar.gz > > > This OFBiz plug in will provide capability for OFBiz to integrate with Apache > Camel. The plug in should provide capability for OFBiz to interface with > various external systems via Apache Camel. > Similarly, the integration will allow inbound communication from external > system into OFBiz via Apache Camel. > Here's the list to the ML discussion thread - > [https://lists.apache.org/thread.html/36ee6e3d2425ecc5eed7cf44e41e27125f7263080870bacd72ae556e@%3Cuser.ofbiz.apache.org%3E] -- This message was sent by Atlassian JIRA (v7.6.14#76016)
