[jira] [Commented] (OFBIZ-11239) Refactor OrderTests.groovy and separate order and return test services

2019-10-08 Thread Suraj Khurana (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946705#comment-16946705
 ] 

Suraj Khurana commented on OFBIZ-11239:
---

Thanks [~jleroux]

> Refactor OrderTests.groovy and separate order and return test services
> --
>
> Key: OFBIZ-11239
> URL: https://issues.apache.org/jira/browse/OFBIZ-11239
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11239.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11239) Refactor OrderTests.groovy and separate order and return test services

2019-10-07 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945764#comment-16945764
 ] 

Jacques Le Roux commented on OFBIZ-11239:
-

Actually it's only 4  "testSendOrder..." tests, better let them in 
OrderTests.groovy

> Refactor OrderTests.groovy and separate order and return test services
> --
>
> Key: OFBIZ-11239
> URL: https://issues.apache.org/jira/browse/OFBIZ-11239
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-11239.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11239) Refactor OrderTests.groovy and separate order and return test services

2019-10-07 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945748#comment-16945748
 ] 

Jacques Le Roux commented on OFBIZ-11239:
-

Hi Suraj, 

Thanks for your recent related commits. I'll continue your work, I notably 
think we should also separate the 16 "testSendOrder..." tests, WIP...

> Refactor OrderTests.groovy and separate order and return test services
> --
>
> Key: OFBIZ-11239
> URL: https://issues.apache.org/jira/browse/OFBIZ-11239
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11239.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11239) Refactor OrderTests.groovy and separate order and return test services

2019-10-06 Thread Suraj Khurana (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945330#comment-16945330
 ] 

Suraj Khurana commented on OFBIZ-11239:
---

Hello [~jleroux],

Please share your thoughts regarding this patch. If looks good, we can merge it 
and move ahead with remaining items of OFBIZ-1463.

Thanks in advance !!

> Refactor OrderTests.groovy and separate order and return test services
> --
>
> Key: OFBIZ-11239
> URL: https://issues.apache.org/jira/browse/OFBIZ-11239
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11239.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)