[jira] [Commented] (OFBIZ-11275) bug in depends-on in ofbiz-component.xml
[
https://issues.apache.org/jira/browse/OFBIZ-11275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985710#comment-16985710
]
ASF subversion and git services commented on OFBIZ-11275:
-
Commit 87d7465306df2b7294587e4c0297360cf234ef92 in ofbiz-framework's branch
refs/heads/trunk from Mathieu Lirzin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=87d7465 ]
Improved: Move ‘ComponentContainerTest’ data to src/test/resources/
(OFBIZ-11275)
Remove unnecessary webapp declaration inside the test component
configurations.
> bug in depends-on in ofbiz-component.xml
>
>
> Key: OFBIZ-11275
> URL: https://issues.apache.org/jira/browse/OFBIZ-11275
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk, 18.12.01
>Reporter: Samuel Trégouët
>Assignee: Mathieu Lirzin
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments:
> 0001-Implemented-Show-dependency-resolution-algorithm-pro.patch,
> 0002-Implemented-Add-a-generic-directed-graph-utilitary-c.patch,
> 0003-Fixed-Remove-dependency-management-from-ComponentCon.patch,
> 0004-Fixed-graphSpec-should-be-a-LinkedHashMap-to-preserv.patch
>
>
> when using `depends-on` tag in obfiz-component.xml one should expect ofbiz to
> load component (and in particular container listed in ofbiz-component.xml) in
> particular order.
> I mean if component `accounting` has this line in its ofbiz-component.xml
> {noformat}
> {noformat}
> ofbiz should load order component first and then accounting. This is not the
> case. Only classpath is modified according to depends-on declaration (and
> this is not really a usefull/used feature but we'll see this in another issue
> ;) )
> So here are patches to fix this issue. First one is only a test (which is
> skipped to allow ./gradlew test to be ok, so if one need to be convinced one
> should comment Ignore annotation) to illustrate issue, the two others are
> actual fixes
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11275) bug in depends-on in ofbiz-component.xml
[
https://issues.apache.org/jira/browse/OFBIZ-11275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16981520#comment-16981520
]
Samuel Trégouët commented on OFBIZ-11275:
-
just added a new patch
(0004-Fixed-graphSpec-should-be-a-LinkedHashMap-to-preserv.patch) to fix
previous error
> bug in depends-on in ofbiz-component.xml
>
>
> Key: OFBIZ-11275
> URL: https://issues.apache.org/jira/browse/OFBIZ-11275
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk, 18.12.01
>Reporter: Samuel Trégouët
>Assignee: Mathieu Lirzin
>Priority: Major
> Fix For: Trunk
>
> Attachments:
> 0001-Implemented-Show-dependency-resolution-algorithm-pro.patch,
> 0002-Implemented-Add-a-generic-directed-graph-utilitary-c.patch,
> 0003-Fixed-Remove-dependency-management-from-ComponentCon.patch,
> 0004-Fixed-graphSpec-should-be-a-LinkedHashMap-to-preserv.patch
>
>
> when using `depends-on` tag in obfiz-component.xml one should expect ofbiz to
> load component (and in particular container listed in ofbiz-component.xml) in
> particular order.
> I mean if component `accounting` has this line in its ofbiz-component.xml
> {noformat}
> {noformat}
> ofbiz should load order component first and then accounting. This is not the
> case. Only classpath is modified according to depends-on declaration (and
> this is not really a usefull/used feature but we'll see this in another issue
> ;) )
> So here are patches to fix this issue. First one is only a test (which is
> skipped to allow ./gradlew test to be ok, so if one need to be convinced one
> should comment Ignore annotation) to illustrate issue, the two others are
> actual fixes
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11275) bug in depends-on in ofbiz-component.xml
[
https://issues.apache.org/jira/browse/OFBIZ-11275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970452#comment-16970452
]
Mathieu Lirzin commented on OFBIZ-11275:
Thanks for your contribution [~stregouet]
> bug in depends-on in ofbiz-component.xml
>
>
> Key: OFBIZ-11275
> URL: https://issues.apache.org/jira/browse/OFBIZ-11275
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk, 18.12.01
>Reporter: Samuel Trégouët
>Assignee: Mathieu Lirzin
>Priority: Major
> Fix For: Trunk
>
> Attachments:
> 0001-Implemented-Show-dependency-resolution-algorithm-pro.patch,
> 0002-Implemented-Add-a-generic-directed-graph-utilitary-c.patch,
> 0003-Fixed-Remove-dependency-management-from-ComponentCon.patch
>
>
> when using `depends-on` tag in obfiz-component.xml one should expect ofbiz to
> load component (and in particular container listed in ofbiz-component.xml) in
> particular order.
> I mean if component `accounting` has this line in its ofbiz-component.xml
> {noformat}
> {noformat}
> ofbiz should load order component first and then accounting. This is not the
> case. Only classpath is modified according to depends-on declaration (and
> this is not really a usefull/used feature but we'll see this in another issue
> ;) )
> So here are patches to fix this issue. First one is only a test (which is
> skipped to allow ./gradlew test to be ok, so if one need to be convinced one
> should comment Ignore annotation) to illustrate issue, the two others are
> actual fixes
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11275) bug in depends-on in ofbiz-component.xml
[
https://issues.apache.org/jira/browse/OFBIZ-11275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967511#comment-16967511
]
Samuel Trégouët commented on OFBIZ-11275:
-
I have attached patch formatted with `git format-patch`. So patches contain
diff *and* commit messages, as we now use git as primary vcs I hope these kind
of patch will ease commiter work. Let me know if I'm wrong.
> bug in depends-on in ofbiz-component.xml
>
>
> Key: OFBIZ-11275
> URL: https://issues.apache.org/jira/browse/OFBIZ-11275
> Project: OFBiz
> Issue Type: Bug
>Reporter: Samuel Trégouët
>Priority: Major
> Attachments:
> 0001-Implemented-Show-dependency-resolution-algorithm-pro.patch,
> 0002-Implemented-Add-a-generic-directed-graph-utilitary-c.patch,
> 0003-Fixed-Remove-dependency-management-from-ComponentCon.patch
>
>
> when using `depends-on` tag in obfiz-component.xml one should expect ofbiz to
> load component (and in particular container listed in ofbiz-component.xml) in
> particular order.
> I mean if component `accounting` has this line in its ofbiz-component.xml
> {noformat}
> {noformat}
> ofbiz should load order component first and then accounting. This is not the
> case. Only classpath is modified according to depends-on declaration (and
> this is not really a usefull/used feature but we'll see this in another issue
> ;) )
> So here are patches to fix this issue. First one is only a test (which is
> skipped to allow ./gradlew test to be ok, so if one need to be convinced one
> should comment Ignore annotation) to illustrate issue, the two others are
> actual fixes
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
