[jira] [Commented] (OFBIZ-11310) JSON renderer for screen/menu/form
[ https://issues.apache.org/jira/browse/OFBIZ-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713645#comment-17713645 ] Daniel Watford commented on OFBIZ-11310: Hi [~holivier] , OFBIZ-12789 added the ability for OFBiz subprojects to build some aspects using node/npm. A demonstration of this was added to the example plugin where a react app was built with npm and the assets served through the servlet ([https://github.com/apache/ofbiz-plugins/pull/77]) It might be useful as a way to build the VueJS front end. > JSON renderer for screen/menu/form > --- > > Key: OFBIZ-11310 > URL: https://issues.apache.org/jira/browse/OFBIZ-11310 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk, Upcoming Branch >Reporter: Olivier Heintz >Assignee: Olivier Heintz >Priority: Minor > Attachments: FrontJsFormRenderer.java, FrontJsMenuRenderer.java, > FrontJsOutput.java, FrontJsScreenRenderer.java, > FrontJsScreenViewHandler.java, FrontJsTreeRenderer.java, OFBIZ-11310.patch > > > In a POC approach for using a SPA framework for GUI in OFBiz, json renderer > have been developed. > This Jira could be used to do code review on these renderer. > Currently, these renderer are on a V0 situation, it's a work in process > situation. After mailing-list discussion with mathieu we decide to go to a > V0.1 by 2-3 tasks > * add some javadoc each time it's necessary or needed > * remove all comment code or explain the decision waiting to activate or > remove the code > * do checkstyle > On first step, code will be with only what is used in a use case (no code for > tag not currently manage). > Json renderer are part of vuejs-portal plugin, in ofbizextra gitlab > (https://gitlab.ofbizextra.org/ofbizextra/ofbizplugins/vuejsPortal), so > commit are done on it, and mailing-list with these commit [are > ofbizextra-com...@lists.sourceforge.net.|mailto:are%c2%a0ofbizextra-com...@lists.sourceforge.net.] > But we will publish an update on this Jira each week there are some > modifications on renderer files > This task will take some time because it will used to do a complete code > review, not only in renderer but in vuejs component too, and so complete > documentation. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-11310) JSON renderer for screen/menu/form
[ https://issues.apache.org/jira/browse/OFBIZ-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063366#comment-17063366 ] James Yong commented on OFBIZ-11310: Hi Olivier, No hurry for an updated patch. Will come back to review when the JSON renderer is ready. > JSON renderer for screen/menu/form > --- > > Key: OFBIZ-11310 > URL: https://issues.apache.org/jira/browse/OFBIZ-11310 > Project: OFBiz > Issue Type: New Feature > Components: framework >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Attachments: FrontJsFormRenderer.java, FrontJsMenuRenderer.java, > FrontJsOutput.java, FrontJsScreenRenderer.java, > FrontJsScreenViewHandler.java, FrontJsTreeRenderer.java, OFBIZ-11310.patch > > > In a POC approach for using a SPA framework for GUI in OFBiz, json renderer > have been developed. > This Jira could be used to do code review on these renderer. > Currently, these renderer are on a V0 situation, it's a work in process > situation. After mailing-list discussion with mathieu we decide to go to a > V0.1 by 2-3 tasks > * add some javadoc each time it's necessary or needed > * remove all comment code or explain the decision waiting to activate or > remove the code > * do checkstyle > On first step, code will be with only what is used in a use case (no code for > tag not currently manage). > Json renderer are part of vuejs-portal plugin, in ofbizextra gitlab > (https://gitlab.ofbizextra.org/ofbizextra/ofbizplugins/vuejsPortal), so > commit are done on it, and mailing-list with these commit [are > ofbizextra-com...@lists.sourceforge.net.|mailto:are%c2%a0ofbizextra-com...@lists.sourceforge.net.] > But we will publish an update on this Jira each week there are some > modifications on renderer files > This task will take some time because it will used to do a complete code > review, not only in renderer but in vuejs component too, and so complete > documentation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11310) JSON renderer for screen/menu/form
[ https://issues.apache.org/jira/browse/OFBIZ-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061638#comment-17061638 ] Olivier Heintz commented on OFBIZ-11310: clearly a new feature, even if it's only new renderer, a json renderer usable without vuejsPortal plugin > JSON renderer for screen/menu/form > --- > > Key: OFBIZ-11310 > URL: https://issues.apache.org/jira/browse/OFBIZ-11310 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Attachments: FrontJsFormRenderer.java, FrontJsMenuRenderer.java, > FrontJsOutput.java, FrontJsScreenRenderer.java, > FrontJsScreenViewHandler.java, FrontJsTreeRenderer.java, OFBIZ-11310.patch > > > In a POC approach for using a SPA framework for GUI in OFBiz, json renderer > have been developed. > This Jira could be used to do code review on these renderer. > Currently, these renderer are on a V0 situation, it's a work in process > situation. After mailing-list discussion with mathieu we decide to go to a > V0.1 by 2-3 tasks > * add some javadoc each time it's necessary or needed > * remove all comment code or explain the decision waiting to activate or > remove the code > * do checkstyle > On first step, code will be with only what is used in a use case (no code for > tag not currently manage). > Json renderer are part of vuejs-portal plugin, in ofbizextra gitlab > (https://gitlab.ofbizextra.org/ofbizextra/ofbizplugins/vuejsPortal), so > commit are done on it, and mailing-list with these commit [are > ofbizextra-com...@lists.sourceforge.net.|mailto:are%c2%a0ofbizextra-com...@lists.sourceforge.net.] > But we will publish an update on this Jira each week there are some > modifications on renderer files > This task will take some time because it will used to do a complete code > review, not only in renderer but in vuejs component too, and so complete > documentation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11310) JSON renderer for screen/menu/form
[ https://issues.apache.org/jira/browse/OFBIZ-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061556#comment-17061556 ] Jacques Le Roux commented on OFBIZ-11310: - +1 with Pierre's remark > JSON renderer for screen/menu/form > --- > > Key: OFBIZ-11310 > URL: https://issues.apache.org/jira/browse/OFBIZ-11310 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Attachments: FrontJsFormRenderer.java, FrontJsMenuRenderer.java, > FrontJsOutput.java, FrontJsScreenRenderer.java, > FrontJsScreenViewHandler.java, FrontJsTreeRenderer.java, OFBIZ-11310.patch > > > In a POC approach for using a SPA framework for GUI in OFBiz, json renderer > have been developed. > This Jira could be used to do code review on these renderer. > Currently, these renderer are on a V0 situation, it's a work in process > situation. After mailing-list discussion with mathieu we decide to go to a > V0.1 by 2-3 tasks > * add some javadoc each time it's necessary or needed > * remove all comment code or explain the decision waiting to activate or > remove the code > * do checkstyle > On first step, code will be with only what is used in a use case (no code for > tag not currently manage). > Json renderer are part of vuejs-portal plugin, in ofbizextra gitlab > (https://gitlab.ofbizextra.org/ofbizextra/ofbizplugins/vuejsPortal), so > commit are done on it, and mailing-list with these commit [are > ofbizextra-com...@lists.sourceforge.net.|mailto:are%c2%a0ofbizextra-com...@lists.sourceforge.net.] > But we will publish an update on this Jira each week there are some > modifications on renderer files > This task will take some time because it will used to do a complete code > review, not only in renderer but in vuejs component too, and so complete > documentation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11310) JSON renderer for screen/menu/form
[ https://issues.apache.org/jira/browse/OFBIZ-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061533#comment-17061533 ] Pierre Smits commented on OFBIZ-11310: -- Is it correct that this is not just an improvement, but rather a new feature, given the introduction of a new plugin (vuejsPortal)? > JSON renderer for screen/menu/form > --- > > Key: OFBIZ-11310 > URL: https://issues.apache.org/jira/browse/OFBIZ-11310 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Attachments: FrontJsFormRenderer.java, FrontJsMenuRenderer.java, > FrontJsOutput.java, FrontJsScreenRenderer.java, > FrontJsScreenViewHandler.java, FrontJsTreeRenderer.java, OFBIZ-11310.patch > > > In a POC approach for using a SPA framework for GUI in OFBiz, json renderer > have been developed. > This Jira could be used to do code review on these renderer. > Currently, these renderer are on a V0 situation, it's a work in process > situation. After mailing-list discussion with mathieu we decide to go to a > V0.1 by 2-3 tasks > * add some javadoc each time it's necessary or needed > * remove all comment code or explain the decision waiting to activate or > remove the code > * do checkstyle > On first step, code will be with only what is used in a use case (no code for > tag not currently manage). > Json renderer are part of vuejs-portal plugin, in ofbizextra gitlab > (https://gitlab.ofbizextra.org/ofbizextra/ofbizplugins/vuejsPortal), so > commit are done on it, and mailing-list with these commit [are > ofbizextra-com...@lists.sourceforge.net.|mailto:are%c2%a0ofbizextra-com...@lists.sourceforge.net.] > But we will publish an update on this Jira each week there are some > modifications on renderer files > This task will take some time because it will used to do a complete code > review, not only in renderer but in vuejs component too, and so complete > documentation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11310) JSON renderer for screen/menu/form
[ https://issues.apache.org/jira/browse/OFBIZ-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061531#comment-17061531 ] Olivier Heintz commented on OFBIZ-11310: James, OFBIZ-11310.patch is not currently up to date. We are working to clean code in renderer and in vuejs, so vuejsPortal in gitlab.ofbizextra.org is the right place. To be able to test, the best way is to follow install documentation [https://ofbizextra.org/ofbizextra_adocs/docs/asciidoc/developer-manual.html#_poc_vuejs_portal] or you can test directly on the two "demo" site : * [https://ofbiz-selenium.ofbizextra.org/examplefjs/control/main] <= vuejs is build with dev to be able to look component and store in vuejs console but it's our integration plateform so with the cleaning sometime bugs are present ;) * [https://demo-vuejs.ofbizextra.org/examplefjs/control/main] more stable version but npm build with prod If you need, I can update the patch. > JSON renderer for screen/menu/form > --- > > Key: OFBIZ-11310 > URL: https://issues.apache.org/jira/browse/OFBIZ-11310 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Attachments: FrontJsFormRenderer.java, FrontJsMenuRenderer.java, > FrontJsOutput.java, FrontJsScreenRenderer.java, > FrontJsScreenViewHandler.java, FrontJsTreeRenderer.java, OFBIZ-11310.patch > > > In a POC approach for using a SPA framework for GUI in OFBiz, json renderer > have been developed. > This Jira could be used to do code review on these renderer. > Currently, these renderer are on a V0 situation, it's a work in process > situation. After mailing-list discussion with mathieu we decide to go to a > V0.1 by 2-3 tasks > * add some javadoc each time it's necessary or needed > * remove all comment code or explain the decision waiting to activate or > remove the code > * do checkstyle > On first step, code will be with only what is used in a use case (no code for > tag not currently manage). > Json renderer are part of vuejs-portal plugin, in ofbizextra gitlab > (https://gitlab.ofbizextra.org/ofbizextra/ofbizplugins/vuejsPortal), so > commit are done on it, and mailing-list with these commit [are > ofbizextra-com...@lists.sourceforge.net.|mailto:are%c2%a0ofbizextra-com...@lists.sourceforge.net.] > But we will publish an update on this Jira each week there are some > modifications on renderer files > This task will take some time because it will used to do a complete code > review, not only in renderer but in vuejs component too, and so complete > documentation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11310) JSON renderer for screen/menu/form
[ https://issues.apache.org/jira/browse/OFBIZ-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061457#comment-17061457 ] James Yong commented on OFBIZ-11310: Encountered compilation errors after I applied [^OFBIZ-11310.patch] and added vuejs-portal plugin from [https://gitlab.ofbizextra.org/ofbizextra/ofbizplugins/vuejsPortal] > JSON renderer for screen/menu/form > --- > > Key: OFBIZ-11310 > URL: https://issues.apache.org/jira/browse/OFBIZ-11310 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Attachments: FrontJsFormRenderer.java, FrontJsMenuRenderer.java, > FrontJsOutput.java, FrontJsScreenRenderer.java, > FrontJsScreenViewHandler.java, FrontJsTreeRenderer.java, OFBIZ-11310.patch > > > In a POC approach for using a SPA framework for GUI in OFBiz, json renderer > have been developed. > This Jira could be used to do code review on these renderer. > Currently, these renderer are on a V0 situation, it's a work in process > situation. After mailing-list discussion with mathieu we decide to go to a > V0.1 by 2-3 tasks > * add some javadoc each time it's necessary or needed > * remove all comment code or explain the decision waiting to activate or > remove the code > * do checkstyle > On first step, code will be with only what is used in a use case (no code for > tag not currently manage). > Json renderer are part of vuejs-portal plugin, in ofbizextra gitlab > (https://gitlab.ofbizextra.org/ofbizextra/ofbizplugins/vuejsPortal), so > commit are done on it, and mailing-list with these commit [are > ofbizextra-com...@lists.sourceforge.net.|mailto:are%c2%a0ofbizextra-com...@lists.sourceforge.net.] > But we will publish an update on this Jira each week there are some > modifications on renderer files > This task will take some time because it will used to do a complete code > review, not only in renderer but in vuejs component too, and so complete > documentation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11310) JSON renderer for screen/menu/form
[ https://issues.apache.org/jira/browse/OFBIZ-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17060551#comment-17060551 ] Mathieu Lirzin commented on OFBIZ-11310: Given the current situation I revoke my proposal to review your work. Sorry for dropping the ball here. The best next move for you would be to ask on ML for someone else to review this work, if nobody step up feel free to go ahead and commit. Kind regards > JSON renderer for screen/menu/form > --- > > Key: OFBIZ-11310 > URL: https://issues.apache.org/jira/browse/OFBIZ-11310 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Attachments: FrontJsFormRenderer.java, FrontJsMenuRenderer.java, > FrontJsOutput.java, FrontJsScreenRenderer.java, > FrontJsScreenViewHandler.java, FrontJsTreeRenderer.java, OFBIZ-11310.patch > > > In a POC approach for using a SPA framework for GUI in OFBiz, json renderer > have been developed. > This Jira could be used to do code review on these renderer. > Currently, these renderer are on a V0 situation, it's a work in process > situation. After mailing-list discussion with mathieu we decide to go to a > V0.1 by 2-3 tasks > * add some javadoc each time it's necessary or needed > * remove all comment code or explain the decision waiting to activate or > remove the code > * do checkstyle > On first step, code will be with only what is used in a use case (no code for > tag not currently manage). > Json renderer are part of vuejs-portal plugin, in ofbizextra gitlab > (https://gitlab.ofbizextra.org/ofbizextra/ofbizplugins/vuejsPortal), so > commit are done on it, and mailing-list with these commit [are > ofbizextra-com...@lists.sourceforge.net.|mailto:are%c2%a0ofbizextra-com...@lists.sourceforge.net.] > But we will publish an update on this Jira each week there are some > modifications on renderer files > This task will take some time because it will used to do a complete code > review, not only in renderer but in vuejs component too, and so complete > documentation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11310) JSON renderer for screen/menu/form
[ https://issues.apache.org/jira/browse/OFBIZ-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17013595#comment-17013595 ] Mathieu Lirzin commented on OFBIZ-11310: Sorry Olivier for the late reply I did not notice that you actually opened a ticket for the JSON screen renderer. To avoid this kind of issue next time, feel free to either send a message on the mailing list on the associated thread linking the discussion with the ticket, or you can ping people with a [~mthl] mention. In order to start the review, it will help me if you could provide a patch combining the newly added files and defining the location inside the framework where those file will be put. Thanks > JSON renderer for screen/menu/form > --- > > Key: OFBIZ-11310 > URL: https://issues.apache.org/jira/browse/OFBIZ-11310 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Olivier Heintz >Assignee: Mathieu Lirzin >Priority: Minor > Attachments: FrontJsFormRenderer.java, FrontJsMenuRenderer.java, > FrontJsOutput.java, FrontJsScreenRenderer.java, > FrontJsScreenViewHandler.java, FrontJsTreeRenderer.java > > > In a POC approach for using a SPA framework for GUI in OFBiz, json renderer > have been developed. > This Jira could be used to do code review on these renderer. > Currently, these renderer are on a V0 situation, it's a work in process > situation. After mailing-list discussion with mathieu we decide to go to a > V0.1 by 2-3 tasks > * add some javadoc each time it's necessary or needed > * remove all comment code or explain the decision waiting to activate or > remove the code > * do checkstyle > On first step, code will be with only what is used in a use case (no code for > tag not currently manage). > Json renderer are part of vuejs-portal plugin, in ofbizextra gitlab > (https://gitlab.ofbizextra.org/ofbizextra/ofbizplugins/vuejsPortal), so > commit are done on it, and mailing-list with these commit [are > ofbizextra-com...@lists.sourceforge.net.|mailto:are%c2%a0ofbizextra-com...@lists.sourceforge.net.] > But we will publish an update on this Jira each week there are some > modifications on renderer files > This task will take some time because it will used to do a complete code > review, not only in renderer but in vuejs component too, and so complete > documentation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11310) JSON renderer for screen/menu/form
[ https://issues.apache.org/jira/browse/OFBIZ-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16998102#comment-16998102 ] Olivier Heintz commented on OFBIZ-11310: FrontFsOutput.java and FrontJsScreenViewHandler.java have been reviewed for javadoc and comment. FrontJsScreenRenderer is the next step.. > JSON renderer for screen/menu/form > --- > > Key: OFBIZ-11310 > URL: https://issues.apache.org/jira/browse/OFBIZ-11310 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Attachments: FrontJsFormRenderer.java, FrontJsMenuRenderer.java, > FrontJsOutput.java, FrontJsScreenRenderer.java, > FrontJsScreenViewHandler.java, FrontJsTreeRenderer.java > > > In a POC approach for using a SPA framework for GUI in OFBiz, json renderer > have been developed. > This Jira could be used to do code review on these renderer. > Currently, these renderer are on a V0 situation, it's a work in process > situation. After mailing-list discussion with mathieu we decide to go to a > V0.1 by 2-3 tasks > * add some javadoc each time it's necessary or needed > * remove all comment code or explain the decision waiting to activate or > remove the code > * do checkstyle > On first step, code will be with only what is used in a use case (no code for > tag not currently manage). > Json renderer are part of vuejs-portal plugin, in ofbizextra gitlab > (https://gitlab.ofbizextra.org/ofbizextra/ofbizplugins/vuejsPortal), so > commit are done on it, and mailing-list with these commit [are > ofbizextra-com...@lists.sourceforge.net.|mailto:are%c2%a0ofbizextra-com...@lists.sourceforge.net.] > But we will publish an update on this Jira each week there are some > modifications on renderer files > This task will take some time because it will used to do a complete code > review, not only in renderer but in vuejs component too, and so complete > documentation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
