[jira] [Commented] (OFBIZ-11350) Checkstyle improvements
[ https://issues.apache.org/jira/browse/OFBIZ-11350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17284864#comment-17284864 ] Jacques Le Roux commented on OFBIZ-11350: - Thanks Ecomify! > Checkstyle improvements > --- > > Key: OFBIZ-11350 > URL: https://issues.apache.org/jira/browse/OFBIZ-11350 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > > This is an umbrella task for checkstyle improvements. > See related discussion on the dev mailinglist: > https://lists.apache.org/thread.html/rf417d7b136eda217916483592f7e072184a0687babfe7f0b74bf820e%40%3Cdev.ofbiz.apache.org%3E -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11350) Checkstyle improvements
[ https://issues.apache.org/jira/browse/OFBIZ-11350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17284835#comment-17284835 ] Michael Brohl commented on OFBIZ-11350: --- We are down to 127 checkstyle errors now for framework and plugins, more to come... > Checkstyle improvements > --- > > Key: OFBIZ-11350 > URL: https://issues.apache.org/jira/browse/OFBIZ-11350 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > > This is an umbrella task for checkstyle improvements. > See related discussion on the dev mailinglist: > https://lists.apache.org/thread.html/rf417d7b136eda217916483592f7e072184a0687babfe7f0b74bf820e%40%3Cdev.ofbiz.apache.org%3E -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11350) Checkstyle improvements
[ https://issues.apache.org/jira/browse/OFBIZ-11350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17284170#comment-17284170 ] Jacques Le Roux commented on OFBIZ-11350: - Hi Wiebke, Sounds good to me. We could also clean all the cases where a cast (are there much among the 32 case?) is not the concern and let cases like bq. ((HttpURLConnection) con).disconnect(); I don't hate that much :) In other words, do as you prefer ;) > Checkstyle improvements > --- > > Key: OFBIZ-11350 > URL: https://issues.apache.org/jira/browse/OFBIZ-11350 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > > This is an umbrella task for checkstyle improvements. > See related discussion on the dev mailinglist: > https://lists.apache.org/thread.html/rf417d7b136eda217916483592f7e072184a0687babfe7f0b74bf820e%40%3Cdev.ofbiz.apache.org%3E -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11350) Checkstyle improvements
[
https://issues.apache.org/jira/browse/OFBIZ-11350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283738#comment-17283738
]
Wiebke Pätzold commented on OFBIZ-11350:
Hi [~jleroux],
I did a little research on the Checkstyle rules for the parentheses and I think
it is only possible to completely allow '(' at the beginning of a line. I did
not find a way to specify this only for type cast.
So maybe it is better to store the type cast in a variable before.
> Checkstyle improvements
> ---
>
> Key: OFBIZ-11350
> URL: https://issues.apache.org/jira/browse/OFBIZ-11350
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
>
> This is an umbrella task for checkstyle improvements.
> See related discussion on the dev mailinglist:
> https://lists.apache.org/thread.html/rf417d7b136eda217916483592f7e072184a0687babfe7f0b74bf820e%40%3Cdev.ofbiz.apache.org%3E
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11350) Checkstyle improvements
[
https://issues.apache.org/jira/browse/OFBIZ-11350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282952#comment-17282952
]
Jacques Le Roux commented on OFBIZ-11350:
-
Hi Wiebke,
bq. My idea would be either to store the type cast before in an own variable
or to adapt the checkstyle rules. What are your opinions?
Is it possible to adapt the checkstyle rules at this level? I mean specifying
type cast and wraping '('? Else I'd say it's better to fix them.
bq. The name of the functions are all in upper case while it should be lower
case letters.
I guess it's due to being related to SQL. I have a mixed feeling on that, I'd
recommend to discuss that on dev ML...
> Checkstyle improvements
> ---
>
> Key: OFBIZ-11350
> URL: https://issues.apache.org/jira/browse/OFBIZ-11350
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
>
> This is an umbrella task for checkstyle improvements.
> See related discussion on the dev mailinglist:
> https://lists.apache.org/thread.html/rf417d7b136eda217916483592f7e072184a0687babfe7f0b74bf820e%40%3Cdev.ofbiz.apache.org%3E
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11350) Checkstyle improvements
[
https://issues.apache.org/jira/browse/OFBIZ-11350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282385#comment-17282385
]
Wiebke Pätzold commented on OFBIZ-11350:
Hi all,
while I was fixing some checkstyle errors I noticed the following:
Several checkstyle errors exist under the description " '(' should be on the
previous line."
There are several reasons for this:
- A type cast at the beginning of the line (usually checked before with
'instance of')
- The line before had more than 150 characters and is wrapped at a '(' e.g. a
mathematical function which is used
How do we proceed with this? My idea would be either to store the type cast
before in an own variable or to adapt the checkstyle rules. What are your
opinions?
And another point I noticed is in the class EntityFunction.java the checkstyle
error "Name (e.g. UPPER) must match pattern '^[a-z][a-zA-Z0-9]*$'" occurs. Here
the name of the functions are all in upper case while it should be lower case
letters. So it needs a refactoring over all their occurrences. Or what do you
think?
> Checkstyle improvements
> ---
>
> Key: OFBIZ-11350
> URL: https://issues.apache.org/jira/browse/OFBIZ-11350
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
>
> This is an umbrella task for checkstyle improvements.
> See related discussion on the dev mailinglist:
> https://lists.apache.org/thread.html/rf417d7b136eda217916483592f7e072184a0687babfe7f0b74bf820e%40%3Cdev.ofbiz.apache.org%3E
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11350) Checkstyle improvements
[ https://issues.apache.org/jira/browse/OFBIZ-11350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140736#comment-17140736 ] Jacques Le Roux commented on OFBIZ-11350: - Hi Eugen, This has not been discussed yet and think it's worth adding a message to the thread! > Checkstyle improvements > --- > > Key: OFBIZ-11350 > URL: https://issues.apache.org/jira/browse/OFBIZ-11350 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > > This is an umbrella task for checkstyle improvements. > See related discussion on the dev mailinglist: > https://lists.apache.org/thread.html/rf417d7b136eda217916483592f7e072184a0687babfe7f0b74bf820e%40%3Cdev.ofbiz.apache.org%3E -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11350) Checkstyle improvements
[ https://issues.apache.org/jira/browse/OFBIZ-11350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140587#comment-17140587 ] Ioan Eugen Stan commented on OFBIZ-11350: - Haven't read the full discussion. Are you aware of https://github.com/openrewrite/rewrite-gradle-plugin and https://github.com/diffplug/spotless ? They can provide IDE independent formatting and checking . > Checkstyle improvements > --- > > Key: OFBIZ-11350 > URL: https://issues.apache.org/jira/browse/OFBIZ-11350 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > > This is an umbrella task for checkstyle improvements. > See related discussion on the dev mailinglist: > https://lists.apache.org/thread.html/rf417d7b136eda217916483592f7e072184a0687babfe7f0b74bf820e%40%3Cdev.ofbiz.apache.org%3E -- This message was sent by Atlassian Jira (v8.3.4#803005)
