[jira] [Commented] (OFBIZ-11369) Convert findAssocContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17415083#comment-17415083 ] ASF subversion and git services commented on OFBIZ-11369: - Commit 46d53b513eb455f453950db221d45e9023a0b04c in ofbiz-framework's branch refs/heads/trunk from Nicolas Malin [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=46d53b5 ] Improved: Convert findAssocContent service from mini-lang to groovy DSL (OFBIZ-11369) Thanks to Prakhar Kumar > Convert findAssocContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11369 > URL: https://issues.apache.org/jira/browse/OFBIZ-11369 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Nicolas Malin >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11369.patch > > > Convert findAssocContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11369) Convert findAssocContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092166#comment-17092166 ] Devanshu Vyas commented on OFBIZ-11369: --- [~prakhar.kumar], I did a review of your patch and the first thing I noticed is that the validations on the service input parameters were removed. I think they should remain as is. > Convert findAssocContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11369 > URL: https://issues.apache.org/jira/browse/OFBIZ-11369 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Prakhar Kumar >Priority: Minor > Attachments: OFBIZ-11369.patch > > > Convert findAssocContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11369) Convert findAssocContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092137#comment-17092137 ] Mridul Pathak commented on OFBIZ-11369: --- Hi [~prakhar.kumar], Please use iterator for mapKeys as in original simple method. IN operator could end up giving performance issues for heavily populated ContentAssoc entity. > Convert findAssocContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11369 > URL: https://issues.apache.org/jira/browse/OFBIZ-11369 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Prakhar Kumar >Priority: Minor > Attachments: OFBIZ-11369.patch > > > Convert findAssocContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11369) Convert findAssocContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17069334#comment-17069334 ] Prakhar Kumar commented on OFBIZ-11369: --- I doubt the utility of this service. In my opinion, an entity query would suffice. Suggestions/views are welcome. > Convert findAssocContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11369 > URL: https://issues.apache.org/jira/browse/OFBIZ-11369 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Prakhar Kumar >Priority: Minor > Attachments: OFBIZ-11369.patch > > > Convert findAssocContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11369) Convert findAssocContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17069322#comment-17069322 ] Prakhar Kumar commented on OFBIZ-11369: --- Attached the patch containing conversion of findAssocContent service code from mini lang to groovy along with the removal of the mini lang service. [^OFBIZ-11369.patch] > Convert findAssocContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11369 > URL: https://issues.apache.org/jira/browse/OFBIZ-11369 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Prakhar Kumar >Priority: Minor > Attachments: OFBIZ-11369.patch > > > Convert findAssocContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
