[jira] [Commented] (OFBIZ-11376) Convert createTopic service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17043434#comment-17043434 ] Priya Sharma commented on OFBIZ-11376: -- Hello Jacques, I have attached the updated patch, wherein I have removed the service definition and the mini-lang implementation. Please review the patch and let me know if I have misunderstood anything. > Convert createTopic service from mini-lang to groovy DSL > > > Key: OFBIZ-11376 > URL: https://issues.apache.org/jira/browse/OFBIZ-11376 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: Image 005.png, OFBIZ-11376-updated.patch, > OFBIZ-11376.patch > > > Convert createTopic service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11376) Convert createTopic service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17043205#comment-17043205 ] Jacques Le Roux commented on OFBIZ-11376: - Thanks Priya, The link works here, here is a copy: !Image 005.png! > Convert createTopic service from mini-lang to groovy DSL > > > Key: OFBIZ-11376 > URL: https://issues.apache.org/jira/browse/OFBIZ-11376 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: Image 005.png, OFBIZ-11376.patch > > > Convert createTopic service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11376) Convert createTopic service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17043170#comment-17043170 ] Priya Sharma commented on OFBIZ-11376: -- Hey [~jleroux] Thanks for the reply, but the above link is inaccessible, perhaps all svn related links [http://svn.apache.org/viewvc?view=revision] Sure, I will update the patch as per your comment. > Convert createTopic service from mini-lang to groovy DSL > > > Key: OFBIZ-11376 > URL: https://issues.apache.org/jira/browse/OFBIZ-11376 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11376.patch > > > Convert createTopic service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11376) Convert createTopic service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042844#comment-17042844 ] Jacques Le Roux commented on OFBIZ-11376: - Thanks Priya, Indeed with [r1160971|http://svn.apache.org/viewvc?view=revision=1160971] this has been commented out by Hans from start in 2011. I don't think we need to backport the service but rather to remove all references. > Convert createTopic service from mini-lang to groovy DSL > > > Key: OFBIZ-11376 > URL: https://issues.apache.org/jira/browse/OFBIZ-11376 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11376.patch > > > Convert createTopic service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11376) Convert createTopic service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042485#comment-17042485 ] Priya Sharma commented on OFBIZ-11376: -- Hello Devanshu, I have added the patch * Added the groovy implementation for the service * Updated the service definition * Removed the xml version of the service Please verify the patch and let me know in case some modifications are needed. But I could not find any references for this service in the code base, i.e. this service has not been used anywhere, do we still want to keep it? > Convert createTopic service from mini-lang to groovy DSL > > > Key: OFBIZ-11376 > URL: https://issues.apache.org/jira/browse/OFBIZ-11376 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11376.patch > > > Convert createTopic service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
